profile
viewpoint
Alex McKenzie Arrrlex Alexander Thamm Berlin alexmck.com I'm a software engineer with a Maths and Philosophy background. Also check out my gitlab: gitlab.com/Arrrlex

Arrrlex/alexwebsite 0

My personal website

Arrrlex/at-python-template 0

The official Python Project Template of Alexander Thamm GmbH

Arrrlex/jina 0

An easier way to build neural search in the cloud

Arrrlex/poetry 0

Python dependency management and packaging made easy.

Arrrlex/SymbolicMathematics 0

Deep Learning for Symbolic Mathematics

push eventat-gmbh/at-python-template

Carsten Böhm

commit sha 6cb34ee22c434c0c84c35f0091a8a76aba47879a

Add venv creation for caching

view details

push time in 2 days

push eventat-gmbh/at-python-template

Carsten Böhm

commit sha be7cf7896732f3be1c4b1224669ab5b8ea55290f

Add templated gitlab ci file

view details

push time in 2 days

push eventat-gmbh/at-python-template

Sebastian Straub

commit sha 68e60baf2dbaa7ec302a4a7ea713cc2101373c90

fix the conda action (project moved to conda-incubator) (#25)

view details

Sebastian Straub

commit sha f092282c3399ec5a1ea86ca7e1b1c3bfca339cf2

add shields.io badges (#24) for build status, compatible python version, license & github stars

view details

Carsten Böhm

commit sha 52e460a9159c07d7355274c8a06bc699396a354b

Add option for generating gitlab ci yml

view details

Carsten Böhm

commit sha ee2df4fd3126da50c6c8323060761d042f572c16

Add first static version of gitlab ci

view details

push time in 3 days

MemberEvent

push eventat-gmbh/at-python-template

Sebastian Straub

commit sha f092282c3399ec5a1ea86ca7e1b1c3bfca339cf2

add shields.io badges (#24) for build status, compatible python version, license & github stars

view details

push time in 6 days

delete branch at-gmbh/at-python-template

delete branch : feature/badges

delete time in 6 days

PR merged at-gmbh/at-python-template

Add shields.io Badges

for build status, compatible python version, license & github stars

+5 -0

0 comment

1 changed file

klamann

pr closed time in 6 days

delete branch at-gmbh/at-python-template

delete branch : bugfix/conda-workflow

delete time in 6 days

push eventat-gmbh/at-python-template

Sebastian Straub

commit sha 68e60baf2dbaa7ec302a4a7ea713cc2101373c90

fix the conda action (project moved to conda-incubator) (#25)

view details

push time in 6 days

create barnchat-gmbh/at-python-template

branch : bugfix/conda-workflow

created branch time in 6 days

delete branch at-gmbh/at-python-template

delete branch : refactor/windowsfriendly-conda

delete time in 6 days

delete branch at-gmbh/at-python-template

delete branch : bugfix/fix-broken-util-test-poetry

delete time in 6 days

PR opened at-gmbh/at-python-template

Add shields.io Badges

for build status, compatible python version, license & github stars

+5 -0

0 comment

1 changed file

pr created time in 6 days

create barnchat-gmbh/at-python-template

branch : feature/badges

created branch time in 6 days

push eventat-gmbh/at-python-template

push time in 6 days

push eventat-gmbh/at-python-template

Carsten Böhm

commit sha 079fb21920b12f1431daf3630f2070b40a760979

Add option for generating gitlab ci yml

view details

Carsten Böhm

commit sha ea187cdce849445fcb08d8df04e5cb854bcfdde6

Add first static version of gitlab ci

view details

push time in 6 days

create barnchat-gmbh/at-python-template

branch : ft/gitlab-ci

created branch time in 6 days

delete branch at-gmbh/at-python-template

delete branch : feature/version-check

delete time in 21 days

push eventat-gmbh/at-python-template

Sebastian Straub

commit sha 7ba8f260ba6decdda61fee71b5c2b4759e4fbbeb

Version Check (#21) * add a version check to pre-gen hooks * add tests for version checks mock incompatible python & cookiecutter versions and see if it fails * update dependencies * also upgrade the conda environment... * add a version check for unsupported python versions * python version & syntax fix * version check adjusted (detect error categories) * don't fail fast * adjust pre-gen hooks so they work with older python versions

view details

push time in 21 days

PR merged at-gmbh/at-python-template

Reviewers
Version Check enhancement

add a version check (for Python and cookiecutter) to the pre-gen hooks.

This way, we can notify the user that their Python version is outdated or that they should upgrade their cookiecutter installation, instead of throwing random error messages at them, e.g. slugify not available (cookiecutter 1.6 or lower) or f-strings are not supported (Python 3.5 or lower)

+153 -14

8 comments

8 changed files

klamann

pr closed time in 21 days

issue closedat-gmbh/at-python-template

Verify the user environment (Python & cookiecutter version)

We should check that a compatible Python interpreter is used and that the right cookiecutter version is installed on the user's system instead of letting them run into cryptic error messages. This accounts for a lot of the support requests we get.

closed time in 21 days

klamann

pull request commentat-gmbh/at-python-template

Version Check

I agree, let's merge this 🚀

klamann

comment created time in 21 days

pull request commentat-gmbh/at-python-template

Version Check

Yep, it's annoying. We already have the requirement for cookiecutter >= 1.7.2 pretty prominently in our README. Maybe we'll just have to leave it at that and only add the Python version check (which I anticipate to be very useful to many users going forward) along with the many other smaller useful changes you included in this PR?

klamann

comment created time in 21 days

pull request commentat-gmbh/at-python-template

Version Check

Could that cause this issue, since we are using the slugify filter in cookiecutter.json, which is not available in Cookiecutter < 1.7.2?

yeah, I think that might be the problem. Ugh, how annoying 🙄 The ideal solution would be to check for all these versioning issues before we ask for user input, but cookiecutter does not provide any hooks to do so. I don't think we have a way to handle this problem, unless we remove the slugify filter (which I don't want to do because it's really useful). Hmm...

klamann

comment created time in 21 days

pull request commentat-gmbh/at-python-template

Version Check

Thanks @klamann, I just checked and can confirm that the Python >= 3.6 version check works fine now!

The Cookiecutter version check doesn't work for me though and I get the following error: image

Based on your helpful docstring in pre_gen_project.py, I understand the hooks are run after the user entered their config. Could that cause this issue, since we are using the slugify filter in cookiecutter.json, which is not available in Cookiecutter < 1.7.2?

klamann

comment created time in 21 days

pull request commentat-gmbh/at-python-template

Version Check

@sbunzel I think I fixed it, can you confirm?

klamann

comment created time in 21 days

push eventat-gmbh/at-python-template

Sebastian Straub

commit sha 48f77edf52aec70cd04c0ae7c23995def5520425

don't fail fast

view details

Sebastian Straub

commit sha e0e0f05d2580597ca7cd276c9787a9949bbaa44e

adjust pre-gen hooks so they work with older python versions

view details

push time in 21 days

push eventat-gmbh/at-python-template

Sebastian Straub

commit sha 5392cbbe636745a467defaf3448044b75694013c

version check adjusted (detect error categories)

view details

push time in 21 days

more