profile
viewpoint
If you are wondering where the data of this site comes from, please visit https://api.github.com/users/zzmp/events. GitMemory does not store any data, but only uses NGINX to cache data for a period of time. The idea behind GitMemory is simply to give users a better reading experience.

adrichman/timbre 1

Real Time Conversation Transcriptions over webRTC using PubNub and Wit.AI APIs

zzmp/chrubuntu-kernel 1

Scripts/builds to update/manipulate the ChrUbuntu kernel, using a Samsung 2 Intel

edoecohen/opinionations 0

Record the news and voice your opinion!

zzmp/- 0

Extend == to node's `fs`

zzmp/actix-website 0

The Actix website.

zzmp/agar.io-clone 0

Agar.io clone written with Socket.IO and HTML5 canvas

zzmp/algorithms 0

Notes from Algorithms, by CLRS

zzmp/angular 0

One framework. Mobile & desktop.

startedweiran-zsd/dts-cli

started time in 3 hours

issue commentUniswap/interface

Track bundle size as a metric - fail a unit test if it grows more than X%

The bundle can be named using a react-create-app configurator (like @craco/craco), at which point a simple CLI tool (bundlesize or size-limit) can be used to test the size as part of CI.

zzmp

comment created time in 8 hours

push eventUniswap/interface

Zach Pomerantz

commit sha 3cdf00fcf0c661ef9210d8f1233649b228ef8661

fix: respect yarn scripts

view details

push time in 9 hours

PR opened Uniswap/interface

Reviewers
chore: clean up package scripts
+12 -15

0 comment

2 changed files

pr created time in 10 hours

create barnchUniswap/interface

branch : clean-scripts

created branch time in 10 hours

delete branch Uniswap/interface

delete branch : clean-scripts

delete time in 10 hours

PR closed Uniswap/interface

chore: clean up package scripts
+95 -122

2 comments

7 changed files

zzmp

pr closed time in 10 hours

delete branch Uniswap/interface

delete branch : clean-input

delete time in 10 hours

delete branch Uniswap/interface

delete branch : ban-esnext

delete time in 10 hours

delete branch Uniswap/interface

delete branch : first-frame

delete time in 10 hours

delete branch Uniswap/interface

delete branch : redux-dev-tools

delete time in 10 hours

delete branch Uniswap/interface

delete branch : perf-chunks

delete time in 10 hours

delete branch Uniswap/interface

delete branch : ether-chunk

delete time in 10 hours

push eventUniswap/interface

Zach Pomerantz

commit sha 322c45bef438d0275e807b4a031cac78bb03f241

perf: import lodash only as modules (#2426)

view details

Zach Pomerantz

commit sha 8de6bb6d5161c3adcc75e427dd2ca1290c544344

perf(swap): initialize swap inputs from url (#2402) * fix(swap): use undefined as initial currencyId state Null should be used for a selection state, not an unknown state. undefined may signify that a currency was passed in the URL but not yet parsed. * perf(swap): initialize swap with url Initializes SwapState with URL parameters so that currency input may be rendered on the first frame. * test(swap): update hooks tests * test: fix casing * fix: check nullish to allow eg 0

view details

Jordan Frankfurt

commit sha 384f674e485ac50b9c7f0a496a4404c431c4367e

fix(L2): add common bases to L2s (#2428) * add common bases to L2s * pr feedback

view details

Zach Pomerantz

commit sha 6450347d6525fe4fd239e6c63658313143073035

perf: add tooling to analyze sourcemaps

view details

push time in 12 hours

push eventUniswap/interface

Zach Pomerantz

commit sha 8de6bb6d5161c3adcc75e427dd2ca1290c544344

perf(swap): initialize swap inputs from url (#2402) * fix(swap): use undefined as initial currencyId state Null should be used for a selection state, not an unknown state. undefined may signify that a currency was passed in the URL but not yet parsed. * perf(swap): initialize swap with url Initializes SwapState with URL parameters so that currency input may be rendered on the first frame. * test(swap): update hooks tests * test: fix casing * fix: check nullish to allow eg 0

view details

push time in 16 hours

delete branch Uniswap/interface

delete branch : perf-swap-input

delete time in 16 hours

PR merged Uniswap/interface

perf(swap): initialize swap inputs from url

Allows swap inputs to be rendered in the first frame.

+25 -24

3 comments

5 changed files

zzmp

pr closed time in 16 hours

PullRequestReviewEvent

Pull request review commentUniswap/interface

perf(swap): initialize swap inputs from url

 export function useCurrency(currencyId: string | null | undefined): Currency | n   const { chainId } = useActiveWeb3React()   const isETH = currencyId?.toUpperCase() === 'ETH'   const token = useToken(isETH ? undefined : currencyId)-  const extendedEther = useMemo(() => (chainId ? ExtendedEther.onChain(chainId) : undefined), [chainId])+  const extendedEther = useMemo(+    () =>+      chainId+        ? ExtendedEther.onChain(chainId)+        : // display mainnet when not connected+          ExtendedEther.onChain(SupportedChainId.MAINNET),

That should be a larger change in the future. I think it will also help with first paint and linking semantics (ie links can rely on the chain being correct).

zzmp

comment created time in 16 hours

pull request commentUniswap/interface

perf: lazy load routes to reduce initial bundle size

Regarding your concern about that /swap, it's not lazy loaded in this pull request

My mistake, good job there.

development environment

Perf improvements only need to target production bundles. Sometimes what looks like a win (or loss) in development drastically changes when using more aggressive webpack/optimization options.

production environment

This looks like a 34% reduction in size, also great, but the largest chunk that we deliver is the vendors chunk. Does this have any effect there?

Another thing to look at is how this affects the pageload. Does loading the other pages in the initial chunk holding up the main thread? You can take a performance trace (using a production bundle) to determine if there is any improvement here, but I suspect it will be minimal.

Because the vendors chunk is so much larger, I think this should be judged based on the effect there, because lazy loading means that pages other than Swap will load slightly slower, so we need to see some substantial improvement to Swap to make it worthwhile. Do you agree / disagree?

chenxsan

comment created time in 17 hours

push eventUniswap/interface

Zach Pomerantz

commit sha 322c45bef438d0275e807b4a031cac78bb03f241

perf: import lodash only as modules (#2426)

view details

push time in 18 hours

delete branch Uniswap/interface

delete branch : perf-lodash-mod

delete time in 18 hours

PR merged Uniswap/interface

perf: import lodash only as modules

Removing from 'lodash' reduces the uncompressed vendor bundle by 69.93 KB.

+16 -9

1 comment

2 changed files

zzmp

pr closed time in 18 hours

push eventzzmp/davatar-helpers

Gail Wilson

commit sha fc3a88412236697bcada99a2fe98dd4024b79f89

Add optional defaultComponent prop to davatar image component

view details

Carlos Diaz-Padron

commit sha bb6ccd1360ea5d5ccc38ebb1d6a20b5716c62040

add example for defaultComponent

view details

GailWilson

commit sha 1395658e04923cadb1ebad5b2c7bc5fe2a64b696

Merge pull request #5 from TBDAO/gail/add-optional-default-component-prop Add optional defaultComponent prop to davatar image component

view details

Gail Wilson

commit sha 8c7bea0f6cd8c36b23d3ab9ce4b2b449f8cf5995

Bump to version 1.5.0

view details

Zach Pomerantz

commit sha 82b73767f507538d56a2a163150b3566442aee40

Merge branch 'master' into perf-ethers-mod

view details

push time in a day

pull request commentUniswap/interface

perf: import @ethersproject directly to enforce modularization

The entire ethers package is also brought in as a dependency to @davatar/react, which should be resolved by https://github.com/TBDAO/davatar-helpers/pull/4. This commit will be ineffective without an update to @davatar/react.

zzmp

comment created time in a day

create barnchUniswap/interface

branch : analyze-source-maps

created branch time in a day

PR opened Uniswap/interface

Reviewers
perf: rm duplicated ua-parser

react-device-detect was only used to detect mobile devices, which duplicates ua-parser. react-device-detect wraps ua-parser.min.js, so ua-parser was being imported twice. Re-using ua-parser to detect mobile devices (see src/utils/userAgent.ts) reduces the uncompressed vendors bundle by 16 KB and allows us to remove react-device-detect from from devDependencies.

+16 -21

0 comment

9 changed files

pr created time in a day

create barnchUniswap/interface

branch : perf-ua-parser

created branch time in a day

PR opened Uniswap/interface

Reviewers
perf: import lodash only as modules

Removing from 'lodash' reduces the uncompressed vendor bundle by 69.93 KB.

+16 -9

0 comment

2 changed files

pr created time in a day