profile
viewpoint

Peltoche/lsd 6590

The next gen ls command

pqrs-org/KE-complex_modifications 834

Karabiner-Elements complex_modifications rules

zwpaper/devdocker 1

Dev Env in docker

zwpaper/go-bean 1

Beancount Parser

zwpaper/AlgorithmPractice 0

Gadgets to kill time

zwpaper/anote 0

another markdown note (inspired by evernote)

zwpaper/axel 0

Improvement of Axel Download Accelerator

zwpaper/bash-language-server 0

A language server for Bash

zwpaper/caddy 0

Fast, cross-platform HTTP/2 web server with automatic HTTPS

startedmanateelazycat/popweb

started time in 6 days

issue closedPeltoche/lsd

lsd --group-dirs not working correctly

  • os: Void linux
  • lsd --version: 0.20.1
  • echo $TERM: foot
  • echo $LS_COLORS: di=1;35:fi=0;97:ln=4;36:or=5;31:ex=1;0;44:su=30;41:ow=30;42:st=30;44:

Expected behavior

Running lsd --group-dirs should, atleast by the name, group all the directories together in the output.

Actual behavior

But when I run it I get cases where it doesn't work as intended. one is shown below: scrn-6

closed time in 6 days

WilliamBehrens

issue commentPeltoche/lsd

lsd --group-dirs not working correctly

fixed by https://github.com/Peltoche/lsd/pull/592

WilliamBehrens

comment created time in 6 days

push eventPeltoche/lsd

Juan

commit sha 0a3a6f10e75942bbabcb5a330302723288102ac2

made the group-dirs flag require a value

view details

push time in 6 days

PR merged Peltoche/lsd

Reviewers
made the group-dirs flag require a value

<!--- PR Description ---> group-dirs flag requires a value

Hi! I saw this issue https://github.com/Peltoche/lsd/issues/580. Should be straightforward. Let me know if there's any other changes I need to make.

TODO

  • [ ] Use cargo fmt
  • [ ] Add necessary tests
  • [ ] Add changelog entry
+0 -1

2 comments

1 changed file

juansc

pr closed time in 6 days

pull request commentPeltoche/lsd

made the group-dirs flag require a value

@juansc thanks for contributing!

juansc

comment created time in 6 days

issue commentPeltoche/lsd

Fixing -t option according to the GNU ls behaviour

Hmmm, let me try to explain myself more precisely, how can I reproduce the difference between lsd -t and ls -t?

can you show me an example so that I can let ls -t list output in a one-column style?

Gasu16

comment created time in 6 days

issue commentPeltoche/lsd

Fixing -t option according to the GNU ls behaviour

what's your GNU ls version?

it is strange that my GNU ls arrange the result in grid mode:

root@235be0e82ad0:/# ls --version
ls (GNU coreutils) 8.28
Copyright (C) 2017 Free Software Foundation, Inc.
License GPLv3+: GNU GPL version 3 or later <http://gnu.org/licenses/gpl.html>.
This is free software: you are free to change and redistribute it.
There is NO WARRANTY, to the extent permitted by law.

Written by Richard M. Stallman and David MacKenzie.
root@235be0e82ad0:/# ls -t
dev  proc  sys  etc  lsd  tmp  go  root  bin  sbin  lib  lib64  run  var  media  mnt  opt  srv  usr  boot  home
Gasu16

comment created time in 7 days

issue commentPeltoche/lsd

Fixing -t option according to the GNU ls behaviour

could you paste some examples?

it seems in a grid view when I tested locally

image

Gasu16

comment created time in 7 days

pull request commentPeltoche/lsd

WIP: theme: :sparkles: add default and update the others optional

Hi @meain, thanks for the input, as I mentioned in the description, I also wondering how should we handle the default color.

This PR could be a small Proof of Concept and discussion.

a fallback to the default theme is something like patch the default theme, I was thinking how about letting people create some brand new themes, and sharing or switching themes.

so that a fixed default value seems better than falling back to the default theme, also, people could copy and modify the default theme from README if this is what they want.

this also answers your second question, why I did not choose to use theme.yaml as the theme file name and create a theme dir for the themes.

zwpaper

comment created time in 7 days

issue commentPeltoche/lsd

Fixing -t option according to the GNU ls behaviour

I have checked the manpage and found:

-t sort by time, newest first; see --time

ref: https://man7.org/linux/man-pages/man1/ls.1.html

Did I get you wrong?

Gasu16

comment created time in 8 days

issue commentPeltoche/lsd

Theme file doesn't load

related https://github.com/Peltoche/lsd/pull/591

ranebrown

comment created time in 8 days

PR opened Peltoche/lsd

WIP: theme: :sparkles: add default and update the others optional

<!--- PR Description --->

fix https://github.com/Peltoche/lsd/issues/549

difference:

  1. use a default value as fallback color instead of falling back to the default theme, one may copy the default theme value from README
  2. no options for the terminal default foreground color, still suffering how to represent this

TODO

  • [ ] Use cargo fmt
  • [ ] Add necessary tests
  • [ ] Add changelog entry
+255 -181

0 comment

3 changed files

pr created time in 8 days

create barnchzwpaper/lsd

branch : dev-theme-default

created branch time in 8 days

issue closedPeltoche/lsd

Incompatible CLI parameters `--all` and `--directory-only` / Inconsistent behavior w.r.t. original `ls`

  • os: Linux Mint 20.2
  • lsd --version: lsd 0.20.1
  • echo $TERM: xterm-256color
  • echo $LS_COLORS:

Expected behavior

If applicable, add the output of the classic ls command (\ls -la) in order to show the buggy file/directory.

If I define alias ls='ls -ahl --color' and then use ls -d *, this works and lists all the names of the directories in my current dir (even those starting with .) but not their contents. This is what is expected from -a and -d CLI parameters.

I would expect the same behavior from lsd

Actual behavior

If the application panics run the command with the trace (RUST_BACKTRACE=1 lsd ...). In case of graphical errors, add a screenshot if possible.

When I define alias ls='lsd -ahl --color auto', and I attempt to run ls -d *, I get error: The argument '--all' cannot be used with '--directory-only'.

Fist of all, this behavior is inconsistent with the behavior of original ls. Second, I don't see why these CLI parameters would be incompatible. Indeed, original ls behavior seems reasonable. Thus I would expect lsd to consider them compatible too.

closed time in 10 days

liar666

issue commentPeltoche/lsd

Incompatible CLI parameters `--all` and `--directory-only` / Inconsistent behavior w.r.t. original `ls`

fixed by https://github.com/Peltoche/lsd/pull/587

liar666

comment created time in 10 days

push eventPeltoche/lsd

Gasu16

commit sha 0d8743cd87eb026c7632a76d96ad3952f7c3867d

Resolving conflict in issue #582

view details

Gasu16

commit sha c49a67085ab459aee80c57275e315140aca7c289

Resolving issue #582

view details

Gasu16

commit sha 3a28c71cfef078926b08f725398ed9d841c4c2d9

retrigger tests for issue #582

view details

Gasu16

commit sha fba600daee685b248b1c3dcba81e5eb6fb2bf2c8

done requested changes

view details

push time in 10 days

PR merged Peltoche/lsd

Reviewers
Resolving conflict in issue #582

<!--- PR Description --->


TODO

  • [x] Use cargo fmt
  • [x] Add necessary tests
  • [x] Add changelog entry
+18 -6

6 comments

3 changed files

Gasu16

pr closed time in 10 days

pull request commentPeltoche/lsd

Resolving conflict in issue #582

@Gasu16 Thanks for contributing!

Gasu16

comment created time in 10 days

issue commentPeltoche/lsd

Some icons are missing or rendering wrong

both icon size and icon content is controlled by fonts or terminal emulator too, so your solution is still to update the fonts or terminal config.

isak102

comment created time in 11 days

issue closedPeltoche/lsd

Some icons are missing or rendering wrong

  • os: linux
  • lsd --version: lsd 0.20.1
  • echo $TERM: xterm-kitty

Some icons dont show up, for example icons that have the .sh and .hs extension. I have nerd fonts and fontawesome installed. As you can see, the majority of icons are showing up properly but not all. Is there a way to manually add extra icons in a config file? image

closed time in 12 days

isak102

issue commentPeltoche/lsd

Some icons are missing

this is always because of the font, make sure you installed a Nerd Font, Hack Nerd Font for example

isak102

comment created time in 12 days

pull request commentPeltoche/lsd

Resolving conflict in issue #582

Hi @Gasu16, thanks for the contribution, but it seems the -d is not working with -a perfectly, there is something that has to do to align with the GNU ls.

your implementation:

$ cargo run -- -a -d
    Finished dev [unoptimized + debuginfo] target(s) in 0.06s
     Running `target/debug/lsd -a -d`
 .   ..   .git   .github   .gitignore   .release.toml   build.rs   Cargo.lock   Cargo.toml   CHANGELOG.md   ci   CODEOWNERS   doc   LICENSE   README.md   src   target   tests

GNU ls:

$ \ls -a -d
.

without -a:

$ \ls -d
.

$ lsd -d
 .

show directories:

$ \ls -d -a */
ci/     doc/    src/    target/ tests/

$ cargo run -- -d -a */
    Finished dev [unoptimized + debuginfo] target(s) in 0.27s
     Running `target/debug/lsd -d -a ci/ doc/ src/ target/ tests/`

ci/:
 .   ..   before_deploy.bash   before_install.bash   script.bash

doc/:
 .   ..   lsd.md

src/:
 .   ..   app.rs   color   color.rs   config_file.rs   core.rs   display.rs   flags   flags.rs   icon.rs   main.rs   meta   sort.rs

target/:
 .   ..   .rustc_info.json   CACHEDIR.TAG   debug

tests/:
 .   ..   integration.rs
Gasu16

comment created time in 13 days

pull request commentPeltoche/lsd

Resolving conflict in issue #582

Hi @Gasu16, thanks for the contribution, but it seems the -d is not working with -a perfectly, there is something that has to do to align with the GNU ls.

your implementation:

$ cargo run -- -a -d
    Finished dev [unoptimized + debuginfo] target(s) in 0.06s
     Running `target/debug/lsd -a -d`
 .   ..   .git   .github   .gitignore   .release.toml   build.rs   Cargo.lock   Cargo.toml   CHANGELOG.md   ci   CODEOWNERS   doc   LICENSE   README.md   src   target   tests

GNU ls:

$ \ls -a -d
.

without -a:

$ \ls -d
.

$ lsd -d
 .

show directories:

$ \ls -d -a */
ci/     doc/    src/    target/ tests/

$ cargo run -- -d -a */
    Finished dev [unoptimized + debuginfo] target(s) in 0.27s
     Running `target/debug/lsd -d -a ci/ doc/ src/ target/ tests/`

ci/:
 .   ..   before_deploy.bash   before_install.bash   script.bash

doc/:
 .   ..   lsd.md

src/:
 .   ..   app.rs   color   color.rs   config_file.rs   core.rs   display.rs   flags   flags.rs   icon.rs   main.rs   meta   sort.rs

target/:
 .   ..   .rustc_info.json   CACHEDIR.TAG   debug

tests/:
 .   ..   integration.rs
Gasu16

comment created time in 13 days

startedtimdorr/tesla-api

started time in 14 days

issue commentPeltoche/lsd

Incompatible CLI parameters `--all` and `--directory-only` / Inconsistent behavior w.r.t. original `ls`

hi @Gasu16, yes, you get the point right! and we still need to check if the output behavior matches the GNU ls.

a PR is welcome if you could help to check it and validate the output!

also don't forget to add a test after the implementation.

liar666

comment created time in 14 days

issue commentPeltoche/lsd

Some directory name are not showed entirely

hi @astrale-sharp, this is always a font or terminal problem, could your try to change your font to Hack Nerd Font or use another terminal emulator.

Fonts rendering is not something could be handled by lsd

there are some related issues:

  • https://github.com/Peltoche/lsd/issues/553#issuecomment-922462347
  • https://github.com/Peltoche/lsd/issues/568
  • https://github.com/Peltoche/lsd/issues/429
astrale-sharp

comment created time in 14 days

PR opened Peltoche/lsd

faq: :sparkles: add putty/kitty icon render faq

add putty/kitty icon render faq


TODO

None code update.

  • [ ] Use cargo fmt
  • [ ] Add necessary tests
  • [ ] Add changelog entry
+6 -0

0 comment

1 changed file

pr created time in 17 days

push eventzwpaper/lsd

Wei Zhang

commit sha 3e9c98fb5a7c86f44d91089de34b0d6b8ac99267

faq: :sparkles: add putty/kitty icon render faq

view details

push time in 17 days

push eventzwpaper/lsd

auronandace

commit sha e738de7b8c162cd876f64c77f8afbe755dd737d3

clippy lint: avoid manual implementation of Option

view details

auronandace

commit sha 62b1eecb62ec07eb0150793d0b0f8491dcc02ff5

run cargo fmt

view details

zwPapEr

commit sha 30373d79561f541f619832b11be3b4ad261cf022

config: :hammer: using target enum and vec string for config options Signed-off-by: zwPapEr <zw.paper@gmail.com>

view details

zwPapEr

commit sha ec77d91952a738ffbbd15a2b5a157b76ce13e8c0

log: :doc: unique error output and update comment to fit config

view details

zwPapEr

commit sha b553d07faa618d33d788bb6bc46029531c0b5b8d

color: :sparkles: add parse theme file Signed-off-by: zwPapEr <zw.paper@gmail.com>

view details

zwPapEr

commit sha b13a171a41f1798f02692753ead450a47e3935a7

theme/test: :mag: :hammer: update tests to fit theme update Signed-off-by: zwPapEr <zw.paper@gmail.com>

view details

zwPapEr

commit sha 80a0a704c6c00ef03f429debba52bdd420f46e6d

theme/test: :mag: :sparkles: add tests for theme Signed-off-by: zwPapEr <zw.paper@gmail.com>

view details

zwPapEr

commit sha e88ca0feb10319c7dcefb64e4e0fdc2c24ccc789

theme: :hammer: using default to return dark theme and more tests Signed-off-by: zwPapEr <zw.paper@gmail.com>

view details

zwPapEr

commit sha e29966978e9e2c1a21a157df256be5330923312d

theme: :art: :memo: update readme, change log, error log Signed-off-by: zwPapEr <zw.paper@gmail.com>

view details

zwPapEr

commit sha 5e40a1c2cb2774377f378363ecd00c13672c2bc7

:sparkles: done use crossterm to impl theme, functionally works Signed-off-by: zwPapEr <zw.paper@gmail.com>

view details

zwPapEr

commit sha b3bdcfd337167e78224ec8f304b007524f614794

:mag: :hammer: update tests to fit crossterm color Signed-off-by: zwPapEr <zw.paper@gmail.com>

view details

zwPapEr

commit sha f85b87cbe7d865afd110e3f590fff84672da0746

:memo: :hammer: update readme to corssterm color Signed-off-by: zwPapEr <zw.paper@gmail.com>

view details

zwPapEr

commit sha 83986e72fbf49028493e50491ac751c8a31b5a3d

:fire: get rid of ansi term in all code Signed-off-by: zwPapEr <zw.paper@gmail.com>

view details

zwPapEr

commit sha 81c1a79c8566962604088bdf9adf1b4a828fc1f8

build: :arrow_up: update dependency to deserialize color Signed-off-by: zwPapEr <zw.paper@gmail.com>

view details

zwPapEr

commit sha 61121e599d5b619dc6552c370820596eaf5d6116

theme: :hammer: use `themes` dir for themes configurations Signed-off-by: zwPapEr <zw.paper@gmail.com>

view details

zwPapEr

commit sha fc7d2337abba5095c72e854258462f57ec64f8c0

config: :hammer: user do not have to config yaml extension for theme Signed-off-by: zwPapEr <zw.paper@gmail.com>

view details

zwPapEr

commit sha d58a7a3656f8e395dcbddfcc4abc999abe6d250d

:memo: add filename coloring explanation between LS_COLOR and theme Signed-off-by: zwPapEr <zw.paper@gmail.com>

view details

zwPapEr

commit sha 861822cb04fc4c96504ce4513c557cdd66beb39b

theme: :hammer: not deserialize no color and no lscolors from config Signed-off-by: zwPapEr <zw.paper@gmail.com>

view details

zwPapEr

commit sha 9f656fdd9d20341fa2db86ae2202b723d59e84d2

:hammer: use lscolors for filename only, skip from theme configure Signed-off-by: zwPapEr <zw.paper@gmail.com>

view details

zwPapEr

commit sha edfc57178e366517353a4036d78aea5966f9dfc4

theme: :hammer: use dark color for default theme Signed-off-by: zwPapEr <zw.paper@gmail.com>

view details

push time in 17 days

more