profile
viewpoint
If you are wondering where the data of this site comes from, please visit https://api.github.com/users/zorgiepoo/events. GitMemory does not store any data, but only uses NGINX to cache data for a period of time. The idea behind GitMemory is simply to give users a better reading experience.

zorgiepoo/Bit-Slicer 636

Universal game trainer for macOS

zorgiepoo/Komet 131

Cocoa editor for creating commit messages

zorgiepoo/Sparkle 31

A Sparkle fork focussed on sandboxing, extendable UI, and remote updating. Update: Branch in official repo is more up to date! Go there!

zorgiepoo/Sky-Checkers 12

Blast off enemies and be the last one standing!

zorgiepoo/deepsign 6

Create code signatures for application bundles recursively

zorgiepoo/CoreSymbolication 4

Reverse engineered headers for Apples CoreSymbolication private framework; plus the set of test cases I used to validate it. Note: this fork is behind, don't use it!

zorgiepoo/DDMathParser 1

NSString ⟹ NSNumber

zorgiepoo/sparkle-ui-xpc-issues 1

Issues for my UI/Core & XPC/Sandbox friendly branch of Sparkle

zorgiepoo/capstone 0

Capstone disassembly framework: Core + Python + Ocaml + Java bindings

issue commentsparkle-project/Sparkle

Shipping pre-release builds of Sparkle 2.x via Swift Package Manager

The more that I think about this, I think I should re-evaluate bundling the installer launcher and downloader XPC Services inside the framework (still making them optional / opt-in). It has been several years since I've last tried doing it that way.

Unfortunately after trying this, XPC Services inside a framework in an app bundle don't get recognized (or I can't get this to work / find the service name), so this is probably not an option.

tonyarnold

comment created time in 5 hours

issue commentsparkle-project/Sparkle

Multiple alert popups to download and install new version

Can you log the instances of SPUStandardUpdaterController and make sure they correspond to the same pointer?

I can guess some of them but I don't know exactly what delegate methods you are observing corresponding to all those logs so this is not easy to follow.

If you're looking at -updater:willInstallUpdate: for Will install update, the installer has sent a quit event to the application. The update cycle should not end before the application is terminated, contrary to your logs, I believe.

abdullahselek

comment created time in a day

pull request commentsparkle-project/Sparkle

Use entitlements check to determine whether to use legacy WebView

Thanks for the PR.

This has more correct behavior (at least in the common case) such that an app that uses the XPC service (but does not need to be using it) will opt into WebKit2. However I am weary about using these Security APIs - I don't know what they do under the hood and what's their cost is; e.g, if they can block or depend on some system service, etc.

There aren't really good options here. I would much prefer the framework did not have sandbox checks and WebKit would just fix their bug (I would encourage filing duplicate feedback reports..)

Consider also an edge case like an application inheriting a sandbox from a parent process (like a screen saver plug-in for example) - is this code still correct, or if it is, does it come at a cost?

As an aside SUHost operations are for a specific bundle; the code is correct about caring about the 'currently running process' (I believe), but it's not associated with SUHost correctly.

If we make changes to how XPC Services are integrated and its integration guide on Sparkle's website we may also be able to reset some old assumptions about "integrating all the services"

danielpunkass

comment created time in a day

issue closedsparkle-project/sparkle-project.github.io

Generated API Documentation has validation issues

I disabled CI validation of generated API documentation website from jazzy in https://github.com/sparkle-project/sparkle-project.github.io/commit/e10765f1ba81af90e5dd7ea05251e361cd61c707

Issues I remember running into:

  • there is a closing div tag at the end that doesn't match any earlier div tag (need to report upstream)
  • img tag has no specified "alt" attribute; one example is carret image. looks like jazzy is wrong here and it's required.
  • xml linter doesn't like the defer attribute missing an explicit value in the javascript script tag or something. I think the linter is wrong here..
  • linter didn't like © or something for copyright symbol, not sure why.
  • linter doesn't like <meta charset='utf-8'> line, maybe because it isn't closing with />.. But I think linter is wrong here, and HTML is valid.

closed time in 2 days

zorgiepoo

issue commentsparkle-project/sparkle-project.github.io

Generated API Documentation has validation issues

I reported the valid issues upstream. Other issues are invalid so we'll need to keep validation for API reference disabled or maybe replace the validator some day..

zorgiepoo

comment created time in 2 days

push eventsparkle-project/Sparkle

Daniel Jalkut

commit sha 1ede0bc994b6a863d442b211569a08a8c4b3b4eb

When applying the system font size to the baseline CSS for the web view, use px instead of pt to specify the font size. This is consistent with best practices for web content, and alleviates a problem wherein the text in the web view, if not based on a full-fledged release notes HTML document, appears too large. (#1962)

view details

push time in 2 days

push eventsparkle-project/Sparkle

Daniel Jalkut

commit sha a9d5a4276886de9a905e542a9dc07bf8716b9fda

When applying the system font size to the baseline CSS for the web view, use px instead of pt to specify the font size. This is consistent with best practices for web content, and alleviates a problem wherein the text in the web view, if not based on a full-fledged release notes HTML document, appears too large. (#1962)

view details

push time in 2 days

PR merged sparkle-project/Sparkle

Use px instead of pt when specifying font size

When applying the system font size to the baseline CSS for the web vi…ew, use px instead of pt to specify the font size. This is consistent with best practices for web content, and alleviates a problem wherein the text in the web view, if not based on a full-fledged release notes HTML document, appears too large.

  • [x] My change is being tested and reviewed against the Sparkle 2.x branch. New changes must be developed on the 2.x development branch first.

Type of change

  • [x] Bug fix (non-breaking change which fixes an issue)

Testing

I tested and verified my change by using one or multiple of these methods:

  • [x] My own app

macOS version tested: 12.0 (21A5522h)

+1 -1

2 comments

1 changed file

danielpunkass

pr closed time in 2 days

PullRequestReviewEvent

pull request commentsparkle-project/Sparkle

Use px instead of pt when specifying font size

Thank you. I may have gotten used to the wrong default font size 😅

danielpunkass

comment created time in 2 days

pull request commentsparkle-project/Sparkle

Fix to prevent Sparkle manipulating the host app's high level WebView defaults

For reference, this bug affects:

  • 2.x: when applications use the downloader XPC Service
  • 1.x: when the user running operating system is < 10.11 (fix was backported to master as well)
danielpunkass

comment created time in 2 days

pull request commentsparkle-project/Sparkle

Fix to prevent Sparkle manipulating the host app's high level WebView defaults

The current check sees if the downloader XPC Service is available. I think only sandboxed apps that don't use the outgoing networking entitlement should be using the XPC Service. An entitlement check could be an improvement, but it depends on the APIs used to achieve that.. I'm also as of just recently re-considering XPC Service integration in #1883

danielpunkass

comment created time in 2 days

issue commentsparkle-project/Sparkle

Shipping pre-release builds of Sparkle 2.x via Swift Package Manager

The more that I think about this, I think I should re-evaluate bundling the installer launcher and downloader XPC Services inside the framework (still making them optional / opt-in). It has been several years since I've last tried doing it that way.

tonyarnold

comment created time in 2 days

push eventsparkle-project/Sparkle

Daniel Jalkut

commit sha 5b8ab1b919f0901d0b42c6c1f623af798b201f7e

Don't manipulate the default WebView preferences, which at least on Monterey beta returns a preferences instance with nil identifier and with autosaves set to YES. This has the unfortunate effect of causing Sparkle, when it uses SULegacyWebView, to pollute the host app's user defaults with high level WebKit defaults for user style sheet, font sizes, etc. Specifying a unique identifier as well as turning autosaves off should both ensure Sparkle doesn't impose app-wide defaults on the host app, and also avoid littering the host app's preference file with identifier-prefixed defaults. (#1961)

view details

push time in 2 days

push eventsparkle-project/Sparkle

Daniel Jalkut

commit sha 9364c96336ada4b9c7e4adfe3bdd248fc25b1315

Don't manipulate the default WebView preferences, which at least on Monterey beta returns a preferences instance with nil identifier and with autosaves set to YES. This has the unfortunate effect of causing Sparkle, when it uses SULegacyWebView, to pollute the host app's user defaults with high level WebKit defaults for user style sheet, font sizes, etc. Specifying a unique identifier as well as turning autosaves off should both ensure Sparkle doesn't impose app-wide defaults on the host app, and also avoid littering the host app's preference file with identifier-prefixed defaults. (#1961)

view details

push time in 2 days

PR merged sparkle-project/Sparkle

Fix to prevent Sparkle manipulating the host app's high level WebView defaults

This patch prevents Sparkle from manipulating the default WebView preferences, which at least on Monterey beta returns a preferences instance with nil identifier and with autosaves set to YES. This has the unfortunate effect of causing Sparkle, when it uses SULegacyWebView, to pollute the host app's user defaults with high level WebKit defaults for user style sheet, font sizes, etc. Specifying a unique identifier as well as turning autosaves off should both ensure Sparkle doesn't impose app-wide defaults on the host app, and also avoid littering the host app's preference file with identifier-prefixed defaults.

  • [x ] My change is being tested and reviewed against the Sparkle 2.x branch. New changes must be developed on the 2.x development branch first.

Type of change

  • [x ] Bug fix (non-breaking change which fixes an issue)

Testing

I tested and verified my change by using one or multiple of these methods:

  • [x ] My own app

macOS version tested: 12.0 (21A5522h)

+3 -2

1 comment

1 changed file

danielpunkass

pr closed time in 2 days

PullRequestReviewEvent

pull request commentsparkle-project/Sparkle

Fix to prevent Sparkle manipulating the host app's high level WebView defaults

I accidentally regressed when adding the newer WebKit implementation / refactoring the old :/

Thank you for pinpointing/fixing this + the autosave change.

danielpunkass

comment created time in 2 days

IssuesEvent

issue commentsparkle-project/Sparkle

Shipping pre-release builds of Sparkle 2.x via Swift Package Manager

Re-opening for sake of seeking and documenting a working workflow (if possible)

tonyarnold

comment created time in 3 days

issue commentsparkle-project/Sparkle

Shipping pre-release builds of Sparkle 2.x via Swift Package Manager

I don't know. From @1024jp's analysis it doesn't sound like Xcode has a good way of referencing additional artifacts in a project like the XPC Services. And I don't think it is possible to just serve the XPC Services as swift packages. This would probably be worthy of a feedback report to Apple.

Unfortunately the XPC Services and the framework bundles do need to be aligned (the CFBundleVersion and CFBundleShortVersionString values will match when they're aligned), so if the framework updates, the XPC Services need to update too, if you go with the route of just copying them.

Maybe one hack is having an automated script that copies the XPC Services to your project and updates the XPC Services automatically when they become un-aligned with the framework used..

CocoaPods actually does this better I think and makes the XPC Services easy to reference.

tonyarnold

comment created time in 3 days

issue commentsparkle-project/Sparkle

Multiple alert popups to download and install new version

Are you by any chance instantiating multiple instances of SPUUpdater or SPUStandardUpdaterController?

abdullahselek

comment created time in 3 days

pull request commentsparkle-project/Sparkle

Add support for channels

Since the appcast item will be only be available to those who subscribe to the beta channel can you just not use a different beta release notes file for them? People on the default channel shouldn’t see them.

zorgiepoo

comment created time in 3 days

issue openedrealm/jazzy

HTML validation issues

While integrating jazzy (v0.14.0) in our project's website using the jony theme, we ran into a couple issues with our CI validating the HTML. Some of these issues were invalid, but I think it caught a couple valid ones. They are also pointed out by an online HTML validator for our website. Notably:

  • There is an extraneous closing </div> tag right before the ending </html> that doesn't have a matching opening <div>
  • img tags, eg <img id="carat" src="img/carat.png" /> don't have an alt attribute which is apparently required.
  • The online validator seems to be complaining about duplicate rel attributes, eg rel="noopener" rel="external", likely it wants rel="noopener external"

I'm not sure if there are other errors on other pages. Our website is here, although I think some of these issues surface in the example websites on this project and for other themes.

created time in 4 days

issue closedsparkle-project/sparkle-project.github.io

Make github action workflow to update API reference documentation

We should make a github action workflow to update the API reference documentation from Sparkle.framework

It would probably clone Sparkle's source code and the website repo, run make docs in the source repo, and cp documentation/html output to documentation/api-reference in the website repo, then create & push a new commit.

closed time in 5 days

zorgiepoo

push eventsparkle-project/sparkle-project.github.io

Sparkle-Bot

commit sha b704a08244ab005df3046203d67d3d1217dd8b3e

Update API reference documentation

view details

push time in 5 days

push eventsparkle-project/sparkle-project.github.io

Zorg

commit sha 601afb4dc21f5d0418e6e06c43bc762576d5793a

Fix issues with update API reference workflow (#91)

view details

push time in 5 days

push eventsparkle-project/sparkle-project.github.io

Zorg

commit sha 1741f547c50b43ac73992b4966ed797e84549993

Revert "Update API reference documentation" This reverts commit 715df4eed2322fe9986a28976ef77f7df859e0c4.

view details

push time in 5 days