profile
viewpoint

jippi/hashi-ui 1025

A modern user interface for @hashicorp Consul & Nomad

zhammer/morning-cd 4

What was the first piece of music you listened to this morning?

seatgeek/tornado-async-transformer 2

libcst transformer that replaces tornado's legacy @gen.coroutine syntax with python3.5+ native async/await

abepeterkin/Dixit 1

Web version of the card game Dixit

zhammer/adventure-anywhere 0

Port of the 1977 ADVENTURE game that supports long-running sessions amongst multiple players.

zhammer/array-explorer 0

⚡️ A resource to help figure out what JavaScript array method would be best to use at any given time

zhammer/atmosphere 0

zach's mac atmosphere

zhammer/cook 0

terminal color theme based on Wendy MacNaughton's illustrations for Samin Nosrat's book: 'Salt Fat Acid Heat'

zhammer/cssgridgenerator 0

🧮Generate basic CSS Grid code to make dynamic layouts!

zhammer/dd-trace-py 0

Datadog Tracing Python Client

issue commentDataDog/dd-trace-py

Feature request - Cross service tracing for calls made in a Tornado app via its httpclient library

if it helps, here's a simplified version how we set this up! (once this has been live for a bit with no hiccups i can contribute a PR 😄)

import tornado
import ddtrace
from ddtrace.propagation.http import HTTPPropagator

class TracedTornadoClient(tornado.httpclient.AsyncHTTPClient):

    def fetch_impl(self, request, callback) -> None:
        if not ddtrace.tracer.enabled:
            return super(TracedTornadoClient, self).fetch_impl(request, callback)

        span = ddtrace.tracer.trace("http.request", resource=request.url, service="tornado-http-client")
        HTTPPropagator().inject(span.context, request.headers)

        def handle_response(response):
            """
            Here we wrap tornado's default `handle_response` callback which updates the returned future's result.
            Extra steps before forwarding response to the default callback:
            - set span tags
            - finish span
            see: https://github.com/tornadoweb/tornado/blob/b4e39e52cd27d6b3b324a399dff046f71545c4a5/tornado/httpclient.py#L297-L302
            """
            span.set_tags({
                "http.method": request.method,
                "http.url": request.url,
                "http.status_code": response.code,
                "span.kind": "http"
            })
            span.finish()
            callback()

        return super(TracedTornadoClient, self).fetch_impl(request, handle_response)

(didn't test this simplified writeup btw, may have an issue or two but this is the general idea)

someboredkiddo

comment created time in 2 days

issue commentDataDog/dd-trace-py

can you globally disable tracer via an environment variable?

ha yeah that's what i was thinking :)

zhammer

comment created time in 12 days

issue commentDataDog/dd-trace-py

can you globally disable tracer via an environment variable?

great. yeah in these cases we're not running via ddtrace-run.

can help out with a PR if needed

zhammer

comment created time in 12 days

issue openedDataDog/dd-trace-py

can you globally disable tracer via an environment variable?

it'd be helpful for our local/test development environments if we could disable ddtrace globally via an environment variable.

i tried using DD_TRACE_ANALYTICS_ENABLED but that doesn't seem to do the trick

$ python -c "import ddtrace; print(ddtrace.tracer.enabled)"
True
$ DD_TRACE_ANALYTICS_ENABLED=false python -c "import ddtrace; print(ddtrace.tracer.enabled)"
True

also can't find any env var in the docs or from poking around the code here: https://github.com/DataDog/dd-trace-py/blob/3f8970e17e62fd81e916c14a0b5f5f70c2107036/ddtrace/tracer.py#L114

if it helps, our main requirement is that the traces aren't actually sent over network once done. it's still fine if the traces are instrumented locally!

created time in 12 days

pull request commentDataDog/dd-trace-py

guard against missing botocore response metadata

Ahh, didn’t realize ddtrace-run does a patch_all

Libraries that are automatically instrumented when the ddtrace-run command is used or the patch_all() method is called. Always use patch() and patch_all() as soon as possible in your Python entrypoint.

This explains it. Appreciate the help here, was quite confused

zhammer

comment created time in 15 days

pull request commentDataDog/dd-trace-py

guard against missing botocore response metadata

We are using ddtrace-run. Only one patch_all though.

zhammer

comment created time in 15 days

pull request commentDataDog/dd-trace-py

guard against missing botocore response metadata

also @brettlangdon i should note, a big reason why this has been blocking is that when we tried to update our patch all to patch_all(..., botocore=False, boto=False), the boto patch was still being instrumented. e.g. we can't disable boto until the fix is up.

i looked through the source code for patching and couldn't figure out why that was the case so it could very well be user-error on our end. i've been busy with other work so haven't gotten the chance to replicate that behavior, if i do confirm that boto/botocore=False doesn't work i'll open an issue

zhammer

comment created time in 16 days

pull request commentDataDog/dd-trace-py

guard against missing botocore response metadata

thanks @brettlangdon !

zhammer

comment created time in 16 days

issue commentdocker/compose

Support buildkit?

@guysoft from this blog post seems like 1.25.1 https://www.docker.com/blog/faster-builds-in-compose-thanks-to-buildkit-support/

khs1994

comment created time in 16 days

pull request commentDataDog/dd-trace-py

guard against missing botocore response metadata

thanks for the eyes on this! any chance the boto fix could make it into a patch release today? 😄

zhammer

comment created time in 16 days

push eventseatgeek/dd-trace-py

Julien Danjou

commit sha 218b16ef8e3285b22593d65bb787a67914b91b16

feat: add support for aiohttp 3.6 (#1237)

view details

Zach Hammer

commit sha 9862e582c4ca74c722c91ac67630f4c8cd7d30fb

Merge branch 'master' into zh-guard-against-missing-aws-metadata

view details

push time in 16 days

push eventzhammer/rags-nyc

Zach Hammer

commit sha 4df0fb3b842423102ccfa28ae2baec7447ab44bb

Fix typo

view details

push time in 16 days

push eventzhammer/rags-nyc

Zach Hammer

commit sha f0688f808e38e55dad0f03d64603703b0d4e5e21

basic webpage (#1)

view details

push time in 16 days

PR merged zhammer/rags-nyc

setup basic landing page

using screenshot of flyer that ian sent me. lungs link isn't ready yet so that link goes right to lungs' landing page

ian flyer mockup

+84 -1

0 comment

2 changed files

zhammer

pr closed time in 16 days

Pull request review commentDataDog/dd-trace-py

guard against missing botocore response metadata

 def patched_api_call(original_func, instance, args, kwargs):         result = original_func(*args, **kwargs)          response_meta = result['ResponseMetadata']-        span.set_tag(http.STATUS_CODE, response_meta['HTTPStatusCode'])-        span.set_tag('retry_attempts', response_meta['RetryAttempts'])++        http_status_code = response_meta.get('HTTPStatusCode')+        if http_status_code:+            span.set_tag(http.STATUS_CODE, http_status_code)++        retry_attempts = response_meta.get('RetryAttempts')+        if retry_attempts:

done in 05347fe 👍

zhammer

comment created time in 16 days

push eventseatgeek/dd-trace-py

Zach Hammer

commit sha 05347fecf384e3d8368ae3a5c7871fbe3b04f5da

avoid omitting false-y values

view details

push time in 16 days

PR opened DataDog/dd-trace-py

guard against missing botocore response metadata

ran into an issue with the botocore patching due to a missing RetryAttempts key in the aws response metadata.

will be running this through some tests tomorrow but since it's a sensible change thought i'd put it up as a PR now.

also seems like guarding against unset metadata was already thumbs up'd in the original PR, just missed these two - https://github.com/DataDog/dd-trace-py/pull/1248#discussion_r389036357.

can update here once we've run this on our end!

+8 -2

0 comment

1 changed file

pr created time in 17 days

create barnchseatgeek/dd-trace-py

branch : zh-guard-against-missing-aws-metadata

created branch time in 17 days

PR opened zhammer/rags-nyc

setup basic landing page

using screenshot of flyer that ian sent me. lungs link isn't ready yet so that link goes right to lungs' landing page

ian flyer mockup

+84 -1

0 comment

2 changed files

pr created time in 17 days

create barnchzhammer/rags-nyc

branch : zh-setup-basic-landing-page

created branch time in 17 days

pull request commentDataDog/dd-trace-py

Use DATADOG_SERVICE_NAME as default tornado name

seems that the open-trace ci error is unrelated so will leave as is. if i'm wrong about that lmk and i'll take a look at the pr changes!

zhammer

comment created time in 18 days

push eventzhammer/dd-trace-py

Zach Hammer

commit sha bf203e1a5c12eeadb67202e449a255f2cb094fe8

Use getenv

view details

push time in 18 days

push eventzhammer/dd-trace-py

Zach Hammer

commit sha 4ce6dc14d4c47b2e498a58d825890ae2741938c1

Update docs to follow flask integration docs

view details

push time in 18 days

push eventzhammer/dd-trace-py

Zach Hammer

commit sha ac15bd43bf6adb250d9f9361500ab78860143757

Use DATADOG_SERVICE_NAME as default tornado name

view details

push time in 18 days

push eventzhammer/rags-nyc

Zach Hammer

commit sha 8cbf614fdab09c36553608df905deebec4b5acf3

add hello world html

view details

push time in 18 days

create barnchzhammer/rags-nyc

branch : master

created branch time in 18 days

created repositoryzhammer/rags-nyc

created time in 18 days

issue openedzhammer/scribly

scribly dreams

as a person who dreams i want to be able to use scribly as a dream journal and optionally share my dreams on a shared journal with some "dream friends". i may even want to share some dreams on a public dream journal for everyone who uses scribly.

if there were ever a point that there were a lot of posts on a public scribly dream journal, it'd be cool if every once in a while scribly has a dream, based on some neural net from reading all other dreams on the public scribly dream journal. an email that says "scribly had a dream!" would be funny

created time in 20 days

issue commentzhammer/playlist-souffle

Can't find a specific playlist

hey @mcmd. it's been a while since i've worked on playlist souffle so can't answer off the bat.

i'll take a look soon :) feel free to bump me here if i forget

mcmd

comment created time in a month

issue closedzhammer/scribly

is there anything worse than a mobile website that scrolls horizontally (just a little bit)

https://twitter.com/sophiebits/status/1228937053133369344

60627927-5EF2-4E93-9063-4A99B39DB0DF 40EA1ECD-914E-40B6-BD9F-63F10FF09023

closed time in a month

zhammer

issue commentzhammer/scribly

is there anything worse than a mobile website that scrolls horizontally (just a little bit)

hm i reloaded the page and it's not an issue.c losing.

zhammer

comment created time in a month

PR opened jippi/hashi-ui

Fix services -> in sync column stuck on question mark (jobs page)

got pretty stumped by this for a while. eventually added console.log(this.props.jobID) to JobHealth->componentDidMount and realized on all cases of stuck question mark, componentDidMount was never actually being called, so NOMAD_WATCH_JOB_HEALTH was never dispatched.

without digging too deep into why, i copied over some logic from AllocationConsulHealth which fixed the issue. (we dispatch watch and unwatch when the job id prop changes in addition to mount / unmount.)

my best guess as to why this is happening is that maybe fixed-data-table-2 reuses row components in the table and just passes new props, instead of unmounting the old cell and mounting a new one?

+20 -5

0 comment

1 changed file

pr created time in a month

create barnchjippi/hashi-ui

branch : zh-fix-in-sync

created branch time in a month

create barnchzhammer/hashi-ui

branch : zh-fix-in-sync

created branch time in a month

startedjippi/hashi-ui

started time in a month

PR opened jippi/hashi-ui

Fix resizing on jobslist

Used the wrong name for the resize handler

+2 -2

0 comment

1 changed file

pr created time in a month

create barnchjippi/hashi-ui

branch : zh-fix-responsiveness

created branch time in a month

create barnchzhammer/hashi-ui

branch : zh-fix-responsiveness

created branch time in a month

PR opened jippi/hashi-ui

Virtualize job list rendering

Currently JobList doesn't use virtualized rendering; loading a large number of jobs basically makes the page unusable. This PR ports over virtualized table rendering setup from AllocationList to JobList.

Added benefit is this syncs the styles of JobList to match AllocationList (previously the headers had different formatting, I think the headers on AllocationList look nicer anyway).

+132 -56

0 comment

1 changed file

pr created time in a month

create barnchzhammer/hashi-ui

branch : zh-improved-list-rendering

created branch time in a month

fork zhammer/hashi-ui

A modern user interface for @hashicorp Consul & Nomad

fork in a month

issue openedzhammer/scribly

is there anything worse than a mobile website that scrolls horizontally (just a little bit)

https://twitter.com/sophiebits/status/1228937053133369344

60627927-5EF2-4E93-9063-4A99B39DB0DF 40EA1ECD-914E-40B6-BD9F-63F10FF09023

created time in a month

issue commentmoby/moby

Incorrect syntax highlighting in dockerfiles with escaped double quotes

Thanks @JacksonKearl

JacksonKearl

comment created time in a month

issue openedmicrosoft/vscode

Docker extension: windows escaped strings break syntax highlighting

Windows dockerfiles require double quotes in RUN commands to be escaped, like \" (see: https://github.com/StefanScherer/dockerfiles-windows/tree/master/quotes).

Escaping a doublequote in vscode breaks the docker extension's syntax highlighting: screenshot of broken syntax highlighting


  • VSCode Version: 1.42.1
  • OS Version: Darwin x64 18.6.0

Steps to Reproduce:

  1. Make a new Dockerfile and paste the following content:
FROM microsoft/windowsservercore:latest

RUN powershell Write-Host \"Hello world\"

COPY . .

Does this issue occur when all extensions are disabled?: N/A (specifically a docker extension bug)

created time in a month

delete branch zhammer/scribly

delete branch : zh-turn-ids

delete time in a month

push eventzhammer/scribly

Zach Hammer

commit sha ed57248c668969fdeac788fcb3d6199dae0c6692

Add turn ids to story page and link to them (#76) * Add id to story turns * Add test for email linking to last turn * Link to turn in email notification * Mount worker in dev mode * Try chrome browser I'm curious if the url # will properly scroll to the id with this

view details

push time in a month

PR merged zhammer/scribly

Add turn ids to story page and link to them

Resolves #71

+66 -14

0 comment

11 changed files

zhammer

pr closed time in a month

issue closedzhammer/scribly

Email links directly to latest turn

Shouldn’t be hard to set an id on each section in a story like “#turn1”, then could include that in links

new turn email screenshot

closed time in a month

zhammer

PR opened zhammer/scribly

Add turn ids to story page and link to them

Resolves #71

+66 -14

0 comment

11 changed files

pr created time in a month

issue closedzhammer/scribly

scribly.glitch.me

  • [ ] env.SENDGRID_ENABLED
    • based on if sendgrid env vars are passed
    • if not, use a mock emails gateway
    • use jinja global variable to conditionally add email buttons to app
  • [x] sqlite impl of database
  • [x] decide if it's better to keep this a fork or branch
    • i'm leaning towards fork
  • [x] if glitch app will be able to support emails / any future async actions, would have to figure out some rabbit replacement
    • i wonder if message gateway could bind directly to the consumers and enqueue async tasks to them?? that way it all runs through the main app
    • something like asyncio.create_task but with a .5s delay? https://docs.python.org/3/library/asyncio-task.html#asyncio.create_task
    • or add REST routes to the starlette server for the consumer tasks, message gateway sends requests to those? if really necessary could add some secret key only the app knows for verifying those requests come from app but really wouldn't be necessary
    • all the messagegateway methods could have some decorator like @create_task_with_delay(.5)

closed time in a month

zhammer

issue commentzhammer/scribly

scribly.glitch.me

this exists at https://github.com/zhammer/scribly/tree/glitch / glitch.com/~scribly

zhammer

comment created time in a month

push eventzhammer/scribly

zhammer

commit sha 4f49564826fe0bcc5182546f7d4a756efa207943

Try chrome browser I'm curious if the url # will properly scroll to the id with this

view details

push time in a month

push eventzhammer/scribly

zhammer

commit sha 2453ce3fb2e2df4466832b96dc636102cf371a98

Mount worker in dev mode

view details

push time in a month

push eventzhammer/scribly

zhammer

commit sha 7c40a416b0a8ddd4e3e4573c760312edcc8b6b55

Link to turn in email notification

view details

push time in a month

create barnchzhammer/scribly

branch : zh-turn-ids

created branch time in a month

issue commentzhammer/scribly

might make more sense for nudge to nudge on a turn, not a user

eh don't care enough about this

zhammer

comment created time in a month

delete branch zhammer/scribly

delete branch : zh-cypress-4

delete time in a month

push eventzhammer/scribly

Zach Hammer

commit sha b9a1c86d214ee0d5ae105dd32fc0a9c8c0736930

Upgrade to cypress 4 (#73)

view details

push time in a month

PR merged zhammer/scribly

Upgrade to cypress 4
+346 -253

0 comment

2 changed files

zhammer

pr closed time in a month

issue openedzhammer/scribly

Robot writers trained on neural networks!!

created time in a month

PR opened zhammer/scribly

Upgrade to cypress 4
+346 -253

0 comment

2 changed files

pr created time in a month

create barnchzhammer/scribly

branch : zh-cypress-4

created branch time in a month

issue opened0xrawsec/golang-evtx

Question: Can I use evtxmon to read from evtx file paths that are active?

i'm trying to set up some windows containers so that their windows event log directories are mounted to a shared volume with a sidecar task that monitors and ships directly from those log files.

is this possible with evtxmon? going to try this out on my own but thought i'd post the question here for added support.

(some background trying to get this up with another tool: https://discuss.elastic.co/t/winlogbeat-as-a-docker-sibling-sidecar-container/217409)

created time in 2 months

issue closedzhammer/scribly

donation page

10% of funds go to some program for incarcerated people writing

i've always liked the idea of a totally transparent donation page, e.g.

  • show a history of all donations (named or anonymous, like kickstarter)
  • show all spending from that account and est. expenses
    • like heroku costs, etc.
  • show out of pocket expenses from donation lows

basically people can see what expenses are, decide if it makes sense to donate

closed time in 2 months

zhammer

issue commentzhammer/scribly

donation page

Closing because Too Far Off

zhammer

comment created time in 2 months

issue openedzhammer/scribly

Cowriter suggestions on new story

Thinking there could be a table that shows all users another user has interacted with and that could be used to make a datalist for cowriter inputs

created time in 2 months

issue openedzhammer/scribly

Email links directly to latest turn

created time in 2 months

push eventzhammer/scribly

Zach Hammer

commit sha 665cf5dd4a077f12e9e5d4dec72d1eab752742d3

Set PORT to 8000

view details

push time in 2 months

issue commentzhammer/scribly

scribly publisher

Upload an image that could be the banner of the page.

Also upload custom stylesheet

zhammer

comment created time in 2 months

push eventzhammer/scribly

zhammer

commit sha 8453da9553f42c7ccc7cd37383add4da70a19ba9

Just going to do this manually

view details

push time in 2 months

push eventzhammer/scribly

zhammer

commit sha 4e283bc05c8b16a2473ffe6bb14ad54e0b5ca3d8

followup

view details

push time in 2 months

push eventzhammer/scribly

zhammer

commit sha 55fb91f9cbd95162ad8b00ef247570a581164976

figure where cypress runs invoke command

view details

push time in 2 months

push eventzhammer/scribly

zhammer

commit sha b7922ab14fab8245e340ec41596b63cbece04368

Try fixing CI again

view details

push time in 2 months

push eventzhammer/scribly

zhammer

commit sha 1a7525c748ee6031e60496c47a843e89b208852a

Update README

view details

push time in 2 months

push eventzhammer/scribly

zhammer

commit sha 6ba9c0d66749a977e55a212cd4391b833955de1c

Run dev docker compose in CI so sqlite db gets mounted

view details

push time in 2 months

push eventzhammer/scribly

zhammer

commit sha b3fa64c2b08cfa5e7c9371f536c69af66de235c6

Explicitly use python3

view details

push time in 2 months

push eventzhammer/scribly

zhammer

commit sha 9123679319646f811c4093433bcaf0b1061abe54

Fix pytest

view details

push time in 2 months

push eventzhammer/scribly

zhammer

commit sha 0bbe7f6133346e84f1aad7f90364ae4e116070ac

Black formatter

view details

push time in 2 months

push eventzhammer/scribly

zhammer

commit sha 5b12562b76085c909bfab2b2931b867f6c95ca4f

start porting over database to glitch

view details

zhammer

commit sha 0047178bfb61888001f072298be97654e9f0b008

Start getting the cypress test suite working with sqlite

view details

zhammer

commit sha 05a0aa81551a9ae6817dc03cb6e9ca14f6db544f

Setup glitch message gateway Also kills of worker, rabbit

view details

zhammer

commit sha 4d5e7a51f5ad9a9ad7d2c051f175d0fbbeb5fca9

Delete unused code (not used by glitch version)

view details

zhammer

commit sha 318d32b012b108db787d549823aae4a024c6ea19

fixup

view details

zhammer

commit sha 6e0def71b5cbf63c4f1bc749f0cdd867a3617744

Set default WEBSITE_URL to scribly.glitch.me (since it's harder to put this stuff in .env in case someone remixes project and they lose the WEBSITE_URL override)

view details

zhammer

commit sha b1f4df94e5468d7d0238eb22d21fc926ba8fb67e

Add .env.sample

view details

zhammer

commit sha 5914ed09ca4fbcffa46a829f99ee26d5442f008e

Add glitch.json

view details

push time in 2 months

push eventzhammer/scribly

Zach Hammer

commit sha 0060fdabf792dd3c771d0188a4d909354d662132

Allow passing args to dev script

view details

push time in 2 months

create barnchzhammer/scribly

branch : glitch

created branch time in 2 months

issue commentzhammer/scribly

scribly.glitch.me

https://github.com/zhammer/scribly-glitch

zhammer

comment created time in 2 months

create barnchzhammer/scribly-glitch

branch : master

created branch time in 2 months

created repositoryzhammer/scribly-glitch

scribly ported for glitch

created time in 2 months

push eventzhammer/scribly

Zach Hammer

commit sha 8f4f48ec0564ed0446ca859ebe6d5c6536d708df

Update head.html

view details

push time in 2 months

issue closedzhammer/scribly

Mobile story opacity not working

mobile screenshot

closed time in 2 months

zhammer

issue commentzhammer/scribly

Mobile story opacity not working

resolved by https://github.com/zhammer/scribly/commit/ea6d43cee248b5422a4f76c44b5d8a105f5e9e0b

zhammer

comment created time in 2 months

push eventzhammer/scribly

Zach Hammer

commit sha ea6d43cee248b5422a4f76c44b5d8a105f5e9e0b

Update me.html

view details

push time in 2 months

push eventzhammer/scribly

Zach Hammer

commit sha 2ecfeea430d11f75e1c179679cda752d2c6414af

Update style.css

view details

push time in 2 months

issue openedzhammer/scribly

Mobile story opacity not working

mobile screenshot

created time in 2 months

issue closedzhammer/scribly

hide stories

i want to be able to hide stories that clutter my home screen. if there is new activity on a hidden script, it should be unhidden. i want to be able to go somewhere (e.g. ?showHidden=true) to see hidden stories and unhide them

closed time in 2 months

zhammer

push eventzhammer/scribly

Zach Hammer

commit sha e04ace1bfbf44dea1c8317014cd596da10e37344

Hide/unhide stories from Me page (#69) * Start on database changes * sketch out use cases * Add story with user meta (And migration for tests, this may update later) * Add story_li macro to me.html * Add hide policies * Start on story hide views * Fix database * Keep query params on hide/unhide action * black formatter * Use opacity instead of visibility for a11y * Add styling to view preferences * Add simple cypress test * Don't use opacity on mobile views Can't test this on cypress due to https://github.com/cypress-io/cypress/issues/2100 * black formatter

view details

push time in 2 months

PR merged zhammer/scribly

Hide/unhide stories from Me page

scribly-hide-unhide-demo

Resolves #25

todo:

  • [x] mobile-friendly (e.g. hovering for link won't work)
  • [x] accessibility testing (are hidden forms okay?)
  • [x] cypress tests for hides
  • [x] run migration
+302 -33

3 comments

12 changed files

zhammer

pr closed time in 2 months

push eventzhammer/scribly

zhammer

commit sha fdce7f85d0e41d842407028466f5ad4b0a417cf5

black formatter

view details

push time in 2 months

push eventzhammer/scribly

zhammer

commit sha 142627fe3ef495cde455136b8d3bd545d35ca076

Use opacity instead of visibility for a11y

view details

zhammer

commit sha cb8e743cec1ac00b4dc412d4381a948d361cdb0b

Add styling to view preferences

view details

zhammer

commit sha b068edeb3393753f44c797aac5c9635d7eab8b1b

Add simple cypress test

view details

zhammer

commit sha d0887b497b2b28d5d729d9234a9a5ae6865874aa

Don't use opacity on mobile views Can't test this on cypress due to https://github.com/cypress-io/cypress/issues/2100

view details

push time in 2 months

pull request commentzhammer/scribly

Hide/unhide stories from Me page

Re accessibility:

display:none; or visibility: hidden; These styles will hide text from all users. The text is removed from the visual flow of the page and is ignored by screen readers. Do not use this CSS if you want the content to be read by a screen reader. But DO use it for content you don't want read by screen readers.

Probably should do opacity (will double check it’s still read by screen readers).

zhammer

comment created time in 2 months

more