profile
viewpoint
Justin Bennett zephraph @artsy Manhattan, NY

egoist/docute 2986

📚 Effortless documentation, done right.

vue-play/vue-play 964

🍭 A minimalistic framework for demonstrating your Vue components

intuit/auto 636

Generate releases based on semantic version labels on pull requests.

relay-tools/relay-compiler-language-typescript 145

A language plugin for Relay that adds TypeScript support, including emitting type definitions.

ben-eb/css-values 57

Validate CSS property value pairs.

ben-eb/postcss-merge-longhand 29

DEPRECATED, see https://github.com/cssnano/cssnano | Merge longhand properties into shorthand with PostCSS.

auto-it/autobot 10

A GitHub app for intuit's auto

zephraph/atom-github-notifications 5

A Github Notifications package for the Atom editor

jmichaliga/ssr-js-talk 2

A discussion about Server Side Rendering

push eventartsy/reaction

Lily Pacegit

commit sha 9a989ae56ad0f358dedd828b30fbc4642edcacde

fixed

view details

Lily Pacegit

commit sha 31ece4cd20c0654882ebdec678e2f5642e0e477e

updated fixture

view details

Lily Pacegit

commit sha 4266fc4f2b2d30f1d0f0476862f21e3d5e0481a7

typo

view details

Lily Pacegit

commit sha 3b5808884037f4386f77a0dceb678189bef75b91

updated another ficture

view details

Justin Bennett

commit sha 40a044da2ee07b38968d59b227074e8c2b83f9f0

Merge pull request #3201 from lilyfromseattle/birthdate-fix use `formattedNationalityAndBirthday` in artist header

view details

push time in an hour

PR merged artsy/reaction

use `formattedNationalityAndBirthday` in artist header Jira Synced Merge On Green Version: Patch

PURCHASE-1808

I changed the way we display nationality and birth year after noticing a bug where there was a comma but no year for Banksy. We now use formattedNationalityAndBirthday, which will do the formatting work for us.

Before: Screen Shot 2020-02-26 at 5 43 38 PM

After: Screen Shot 2020-02-26 at 5 47 10 PM

+21 -45

1 comment

6 changed files

lilyfromseattle

pr closed time in an hour

pull request commentartsy/reaction

use `formattedNationalityAndBirthday` in artist header

Awesome! Great catch.

lilyfromseattle

comment created time in 2 hours

push eventartsy/reaction

Lily Pace

commit sha a77ce8483e4c67e1ccb3eb1b88d6a552f72d6ee9

initial text changesa

view details

Lily Pace

commit sha 16bbd97d34c3e23903e7a149380e1ff6332ab7b9

updated tests

view details

Lily Pacegit

commit sha dbe5d125faed039d86da22cd254cfa9f28a91ecd

updated snapshots and fixed tests

view details

Lily Pacegit

commit sha 27988a4de80194c9f2b14653145daf1a4f18587d

updated snapshots

view details

Lily Pacegit

commit sha 6b3aaf58fef70bf9fc8c181191800d8e3076fee7

Merge branch 'master' of github.com:artsy/reaction into works-for-sale-copy-change

view details

Lily Pacegit

commit sha e6513966b9116abcaffda2881806ce3a5d6fc18d

updated snapshots

view details

Lily Pace

commit sha 019651c62a434d2c55e0a2aff18686d3f9f9bb22

Update src/Apps/Artist/Routes/Overview/index.tsx Co-Authored-By: Justin Bennett <zephraph@gmail.com>

view details

Justin Bennett

commit sha 50b1af4e11d6993f0c15074056fa74536156f770

Merge pull request #3197 from lilyfromseattle/works-for-sale-copy-change Handle "works for sale" copy and tabs on artwork page if no works for sale

view details

push time in 2 hours

PR merged artsy/reaction

Handle "works for sale" copy and tabs on artwork page if no works for sale Jira Synced Merge On Green Version: Minor

[PURCHASE-1783]

Slack discussion: https://artsy.slack.com/archives/C9YNS4X32/p1581012423395200

"Works for sale" copy is confusing when there are no works for sale. Should be changed to "Artworks".

Before: Screen Shot 2020-02-25 at 10 57 17 AM

Screen Shot 2020-02-25 at 11 13 57 AM

After: Screen Shot 2020-02-25 at 10 57 09 AM

Screen Shot 2020-02-25 at 11 13 36 AM

+28 -5

1 comment

5 changed files

lilyfromseattle

pr closed time in 2 hours

push eventartsy/reaction

Lily Pacegit

commit sha b6be9a915474e2a2007d4c67c1e147f8eb223fc0

final touches, added tests

view details

Justin Bennett

commit sha 2c91db5ca2073bd646a3b3c94942f80e96026d39

Merge pull request #3200 from lilyfromseattle/tappable-badges Link header badges to Auction Result / Career Highlights

view details

push time in 2 hours

PR merged artsy/reaction

Link header badges to Auction Result / Career Highlights Jira Synced Version: Minor

PURCHASE-1782

User experience feedback: The new labels Highest auction result and Career Stage feel/look tappable – could also lead users to Auction Result / Career Highlights?

I updated the indicators so that the auction record indicator links to the auction results tab, and the career stage indicator links to the cv page.

+51 -16

1 comment

3 changed files

lilyfromseattle

pr closed time in 2 hours

pull request commentartsy/reaction

Link header badges to Auction Result / Career Highlights

Looks good! I played w/ it on storybooks too. 👍

lilyfromseattle

comment created time in 2 hours

Pull request review commentartsy/reaction

Handle "works for sale" copy and tabs on artwork page if no works for sale

 export class OverviewRoute extends React.Component<OverviewRouteProps, {}> {             </Media>             <Row>               <Col>-                <SectionHeader headerString="Works For Sale" />+                <SectionHeader+                  headerString={+                    artist.counts.forSaleArtworks
                    artist.counts.forSaleArtworks > 0

It's a really minor thing, but we're explicit about the count comparison in other places which could be mirrored here.

I don't consider this a required change, I'll leave it up to you.

lilyfromseattle

comment created time in 2 hours

PR opened intuit/auto

Reviewers
Don't release canary on skip-release by default, add force flag

Fixes #962

What Changed

Canaries now no longer publish for PRs that skip the release. A flag --force was added to the canary subcommand to make it always publish, regardless of label.

Why

Often times for things like docs updates or other trivial changes deploying a canary is extra noise that's unnecessary.

Open questions

  1. Does shipit need to be updated with some sort of force flag?
  2. Eslint complexity is over the limit on the canary function. Should I increase it or refactor that function to pull out some checks?
  3. Did I miss updating things anywhere?
  4. Should we invert this PR to make it where it releases by default but has a flag to skip canaries if skip release. (i.e. --respect-labels or something)

Todo:

  • [ ] Figure out how to handle eslint complexity failure
  • [ ] Add tests
  • [ ] Add docs
+26 -5

0 comment

3 changed files

pr created time in 6 hours

create barnchintuit/auto

branch : no-canary-on-non-deploy

created branch time in 6 hours

delete branch artsy/palette

delete branch : remove-acl-again

delete time in 7 hours

push eventartsy/palette

Justin Bennett

commit sha 92c5189562b8f2ac4a1ee9fe064c1811fce9d344

Re-add acl permissions to avoid publishing private assets

view details

Justin Bennett

commit sha 0d736f977eb4c798b051d548676efc255b9c1569

Merge pull request #645 from artsy/remove-acl-again Re-add acl permissions to avoid publishing private assets

view details

push time in 7 hours

PR merged artsy/palette

Re-add acl permissions to avoid publishing private assets Version: Trivial

This is technically a revert of #644. When the publish was successful files in the bucket were private. I manually set them to public, but I'm not certain they wouldn't default to private on the next publish.

I've updated the permissions for this set to be able to control the ACL rules for its bucket, just to ensure the proper permissions are provided on deployments.

At least now we know it's deploying correctly though!

cc @eessex <!-- GITHUB_RELEASE PR BODY: canary-version --> <details> <summary>📦 Published PR as canary version: <code>7.1.2-canary.645.9773.0</code></summary> <br />

:sparkles: Test out this PR locally via:

npm install @artsy/palette@7.1.2-canary.645.9773.0
# or 
yarn add @artsy/palette@7.1.2-canary.645.9773.0

</details> <!-- GITHUB_RELEASE PR BODY: canary-version -->

+0 -1

0 comment

1 changed file

zephraph

pr closed time in 7 hours

issue closedintuit/auto

`auto shipit --verbose` failing

Describe the bug

When attempting to upgrade Arty's auto installation to v9.10.4, I ran across a weird failure where auto shipit --verbose fails

Here's the error message

Error: Cannot find module '/home/circleci/project/--version'
    at Function.Module._resolveFilename (internal/modules/cjs/loader.js:634:15)
    at Function.Module._resolveFilename (pkg/prelude/bootstrap.js:1287:46)
    at Function.Module._load (internal/modules/cjs/loader.js:560:25)
    at Function.Module.runMain (pkg/prelude/bootstrap.js:1316:12)
    at startup (internal/bootstrap/node.js:320:19)
    at bootstrapNodeJSCore (internal/bootstrap/node.js:660:3)
{ Error: Command failed: /usr/local/bin/auto --version
internal/modules/cjs/loader.js:636
    throw err;
    ^

Error: Cannot find module '/home/circleci/project/--version'
    at Function.Module._resolveFilename (internal/modules/cjs/loader.js:634:15)
    at Function.Module._resolveFilename (pkg/prelude/bootstrap.js:1287:46)
    at Function.Module._load (internal/modules/cjs/loader.js:560:25)
    at Function.Module.runMain (pkg/prelude/bootstrap.js:1316:12)
    at startup (internal/bootstrap/node.js:320:19)
    at bootstrapNodeJSCore (internal/bootstrap/node.js:660:3)

    at checkExecSyncError (child_process.js:629:11)
    at Object.execSync (child_process.js:666:13)
    at Object.childProcess.execSync (pkg/prelude/bootstrap.js:1448:30)
    at Auto.info (/snapshot/auto/node_modules/@auto-it/core/dist/auto.js:260:41)

To Reproduce

I haven't verified yet that it always happens when the verbose flag is used, but I SSH'd into the failing job on circle and ran without it successfully.

Here's a link to the failing build: https://app.circleci.com/jobs/github/artsy/reaction/5172

closed time in 7 hours

zephraph

issue commentintuit/auto

`auto shipit --verbose` failing

It's not, no.

zephraph

comment created time in 7 hours

PR opened artsy/palette

Re-add acl permissions to avoid publishing private assets Version: Trivial

This is technically a revert of #644. When the publish was successful files in the bucket were private. I manually set them to public, but I'm not certain they wouldn't default to private on the next publish.

I've updated the permissions for this set to be able to control the ACL rules for its bucket, just to ensure the proper permissions are provided on deployments.

At least now we know it's deploying correctly though!

cc @eessex

+0 -1

0 comment

1 changed file

pr created time in 7 hours

create barnchartsy/palette

branch : remove-acl-again

created branch time in 7 hours

delete branch artsy/palette

delete branch : more-permissions-fiddling

delete time in 7 hours

push eventartsy/palette

Justin Bennett

commit sha 973a6d0c7f1ab9d14b8fda806f3a745465504351

Disable acl to bypass requiring the addition of extra permissions

view details

Justin Bennett

commit sha f70e916a8a28d7499811319587cb1f3e788a5635

Merge pull request #644 from artsy/more-permissions-fiddling Disable acl to bypass requiring the addition of extra permissions

view details

push time in 7 hours

PR merged artsy/palette

Reviewers
Disable acl to bypass requiring the addition of extra permissions Version: Trivial

Adding acl: null to not require a special ACL permissions grant in IAM.

I also updated the S3 permissions slightly.

See #643 for more context.

+1 -0

0 comment

1 changed file

zephraph

pr closed time in 7 hours

PR opened artsy/palette

Reviewers
Disable acl to bypass requiring the addition of extra permissions

Adding acl: null to not require a special ACL permissions grant in IAM.

I also updated the S3 permissions slightly.

See #643 for more context.

+1 -0

0 comment

1 changed file

pr created time in 7 hours

create barnchartsy/palette

branch : more-permissions-fiddling

created branch time in 8 hours

push eventartsy/metaphysics

Justin Bennett

commit sha 51a8293138b257378ebf43b891278cdc9a250b82

Fix description typo

view details

push time in 8 hours

delete branch artsy/palette

delete branch : update-upload-context

delete time in 8 hours

push eventartsy/palette

Justin Bennett

commit sha 0f978e3d8cb498f3ef4e3bdfbd7831d61d5429b8

Add new context w/ proper permissions to upload to S3

view details

Justin Bennett

commit sha 07d2e90727403f09ab23b86cad8672086c158bb7

Merge pull request #643 from artsy/update-upload-context Add new context w/ proper permissions to upload to S3

view details

push time in 8 hours

PR merged artsy/palette

Add new context w/ proper permissions to upload to S3 Version: Trivial

cc @eessex, @damassi

I created a new IAM role w/ write-only permissions to palette's S3 bucket. This should fix our problem w/ master failing to upload site artifacts.
<!-- GITHUB_RELEASE PR BODY: canary-version --> <details> <summary>📦 Published PR as canary version: <code>7.1.2-canary.643.9742.0</code></summary> <br />

:sparkles: Test out this PR locally via:

npm install @artsy/palette@7.1.2-canary.643.9742.0
# or 
yarn add @artsy/palette@7.1.2-canary.643.9742.0

</details> <!-- GITHUB_RELEASE PR BODY: canary-version -->

+1 -1

0 comment

1 changed file

zephraph

pr closed time in 8 hours

PR opened artsy/palette

Add new context w/ proper permissions to upload to S3

cc @eessex, @damassi

I created a new IAM role w/ write-only permissions to palette's S3 bucket. This should fix our problem w/ master failing to upload site artifacts.

+1 -1

0 comment

1 changed file

pr created time in 8 hours

create barnchartsy/palette

branch : update-upload-context

created branch time in 8 hours

startedAnuken/Mindustry

started time in 16 hours

push eventartsy/reaction

Justin Bennett

commit sha 4d59b8ad6dfaa48f74a8b490a1d51316e4c4f588

Remove opening auction results from filters

view details

Justin Bennett

commit sha 962f7b437be48f507eaadd567386acb844d10276

Fix types in tests

view details

Justin Bennett

commit sha 877a8eab50a38d7b8ef7c22b6bb46d7a7806ab5f

Remove remaining openItemIndex from test

view details

Justin Bennett

commit sha f8de7e28ce2fbff95a281d2c6f2e6a2f8e05b02d

Merge pull request #3198 from artsy/PURCHASE-1806 Fix issue where expanding auction result changed page

view details

push time in a day

delete branch artsy/reaction

delete branch : PURCHASE-1806

delete time in a day

PR merged artsy/reaction

Fix issue where expanding auction result changed page Merge On Green Version: Patch

When on any auction results page other than the initial page, expanding an auction card would bring you back to the first page and expand whatever auction card was at that position on the first page.

The index of the expanded card was previously stored as a filter. When we updated the filter logic to not reset the page we were puzzled when it continued to reset anyway. After some exploration, we discovered a different bug where pagination disregards the page provided by the filters: it just always resets to 1 when a filter changes. This isn't an issue normally because the default expected behavior is to go back to the first page when a filter is changed. In this case though, we wanted to keep the current page.

Instead of fixing that larger underlying bug, which very likely would require metaphysics changes, we decided to simplify the card expanding logic by pulling it out of filters. There is a slight behavior change in which multiple cards can be expanded at one time. If needed we can follow up and fix that behavior.

Given that expansion is no longer driven by filters we added a new tracking method called Auction result item clicked. cc @louislecluse, you might want to test this after we merge. <!-- GITHUB_RELEASE PR BODY: canary-version --> <details> <summary>📦 Published PR as canary version: <code>25.18.2-canary.3198.52571.0</code></summary> <br />

:sparkles: Test out this PR locally via:

npm install @artsy/reaction@25.18.2-canary.3198.52571.0
# or 
yarn add @artsy/reaction@25.18.2-canary.3198.52571.0

</details> <!-- GITHUB_RELEASE PR BODY: canary-version -->

+50 -68

1 comment

6 changed files

zephraph

pr closed time in a day

push eventartsy/reaction

Justin Bennett

commit sha 877a8eab50a38d7b8ef7c22b6bb46d7a7806ab5f

Remove remaining openItemIndex from test

view details

push time in a day

PR opened artsy/reaction

Fix issue where expanding auction result changed page

When on any auction results page other than the initial page, expanding an auction card would bring you back to the first page and expand whatever auction card was at that position on the first page.

The index of the expanded card was previously stored as a filter. When we updated the filter logic to not reset the page we were puzzled when it continued to reset anyway. After some exploration, we discovered a different bug where pagination disregards the page provided by the filters: it just always resets to 1 when a filter changes. This isn't an issue normally because the default expected behavior is to go back to the first page when a filter is changed. In this case though, we wanted to keep the current page.

Instead of fixing that larger underlying bug, which very likely would require metaphysics changes, we decided to simplify the card expanding logic by pulling it out of filters. There is a slight behavior change in which multiple cards can be expanded at one time. If needed we can follow up and fix that behavior.

Given that expansion is no longer driven by filters we added a new tracking method called Auction result item clicked. cc @louislecluse, you might want to test this after we merge.

+50 -67

0 comment

5 changed files

pr created time in a day

create barnchartsy/reaction

branch : PURCHASE-1806

created branch time in a day

push eventartsy/reaction

Renovate Bot

commit sha c439b7ec80a78490c43fa931c57a06cb07b5d745

Update dep @artsy/palette from 7.1.0 to v7.1.1

view details

Justin Bennett

commit sha 3f5d675da19ccb0f1165ba0b848d82cb43ba84b3

Merge pull request #3194 from artsy/renovate/artsy-palette-7.x Update dep @artsy/palette from 7.1.0 to v7.1.1

view details

push time in a day

delete branch artsy/reaction

delete branch : renovate/artsy-palette-7.x

delete time in a day

PR merged artsy/reaction

Reviewers
Update dep @artsy/palette from 7.1.0 to v7.1.1 Version: Trivial

This PR contains the following updates:

Package Type Update Change
@artsy/palette devDependencies patch 7.1.0 -> 7.1.1

See full list of changes here.


Release Notes

<details> <summary>artsy/palette</summary>

v7.1.1

Compare Source

🐛 Bug Fix
Authors: 1

</details>


Renovate configuration

:date: Schedule: At any time (no schedule defined).

:vertical_traffic_light: Automerge: Enabled.

:recycle: Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

:no_bell: Ignore: Close this PR and you won't be reminded about this update again.


  • [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

This PR has been generated by WhiteSource Renovate. View repository job log here.

+5 -5

1 comment

2 changed files

renovate[bot]

pr closed time in a day

PR closed artsy/reaction

Add user agents to buildClientApp and SystemContext Version: Patch

This is a minor update to add more hooks for passing user agents to the relay connection constructor. It will not completely fixed PURCHASE-1140, but it should ensure client side relay requests have the proper UA.

To completely fix PURCHASE-1140, we need to make sure that all usages of SystemContextProvider eventually get the correct prop when called in force.

+14 -1

3 comments

2 changed files

zephraph

pr closed time in a day

pull request commentartsy/reaction

Add user agents to buildClientApp and SystemContext

Will revisit when we look at this issue again.

zephraph

comment created time in a day

startedsaasify-sh/sheetful

started time in a day

issue commentartsy/artsy.github.io

RFC: Meaningful pull requests

@pepopowitz what I mentioned re: code tours: https://github.com/artsy/reaction/pull/2774#pullrequestreview-288095754

pepopowitz

comment created time in a day

push eventartsy/reaction

Renovate Bot

commit sha 2871ab44e0c58f7724e2ea371be8bbe959edcbdf

Pin dependencies

view details

Justin Bennett

commit sha 330275dd2e99509d8ca84a3d98aba79d376d5ced

Merge pull request #3195 from artsy/renovate/pin-dependencies Pin dependencies

view details

push time in a day

delete branch artsy/reaction

delete branch : renovate/pin-dependencies

delete time in a day

PR merged artsy/reaction

Reviewers
Pin dependencies Version: Trivial

This PR contains the following updates:

Package Type Update Change
@babel/plugin-proposal-nullish-coalescing-operator devDependencies pin ^7.8.3 -> 7.8.3
@babel/plugin-proposal-optional-chaining devDependencies pin ^7.8.3 -> 7.8.3
express-http-context devDependencies pin ^1.2.3 -> 1.2.3

:pushpin: Important: Renovate will wait until you have merged this Pin PR before creating any upgrade PRs for the affected packages. Add the preset :preserveSemverRanges your config if you instead don't wish to pin dependencies.


Renovate configuration

:date: Schedule: At any time (no schedule defined).

:vertical_traffic_light: Automerge: Enabled.

:recycle: Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

:ghost: Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.


  • [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

This PR has been generated by WhiteSource Renovate. View repository job log here.

+6 -6

1 comment

2 changed files

renovate[bot]

pr closed time in a day

startedaiFigueiredo/aiDee

started time in 2 days

startedNetflix/dispatch

started time in 2 days

Pull request review commentartsy/force

Hard-code CDN for now

 FROM node:12.14-alpine  WORKDIR /app -ENV CDN_PRODUCTION_URL=https://d1s2w0upia4e9w.cloudfront.net CDN_STAGING_URL=https://d1rmpw1xlv9rxa.cloudfront.net

I pulled that syntax directly from the docs

The second form, ENV <key>=<value> ..., allows for multiple variables to be set at one time. Notice that the second form uses the equals sign (=) in the syntax, while the first form does not. Like command line parsing, quotes and backslashes can be used to include spaces within values.

https://docs.docker.com/engine/reference/builder/#env

damassi

comment created time in 2 days

issue commentartsy/artsy.github.io

RFC: Meaningful pull requests

@erikdstock's idea of doing code tours and @dblandin usage of them have always been really interesting to me. Will try to find some of those PRs after standup unless someone else has one handy.

pepopowitz

comment created time in 2 days

pull request commentartsy/reaction

Add attachments to each message

Can you add a little more context to the PR?

ashkan18

comment created time in 3 days

push eventartsy/force

Justin Bennett

commit sha e9c06973dae658a154c66cfe7dec1ee1f6fb6462

Move cdn envs to docker image

view details

Justin Bennett

commit sha 61890ccc7606dc902f904f2a3b93a4da746877db

Merge pull request #5106 from artsy/add-cdn-urls Move cdn envs to docker image

view details

push time in 3 days

delete branch artsy/force

delete branch : add-cdn-urls

delete time in 3 days

PR merged artsy/force

Move cdn envs to docker image Merge On Green

So #5105 failed because the envs weren't available at build time like I expected they would be. I've moved them directly to the dockerfile because I'm mostly sure that'll make them available...

cc @eessex or @izakp If there's a better way to do this we should probably follow up w/ a cleanup

+2 -2

0 comment

2 changed files

zephraph

pr closed time in 3 days

PR opened artsy/force

Move cdn envs to docker image Merge On Green

So #5105 failed because the envs weren't available at build time like I expected they would be. I've moved them directly to the dockerfile because I'm mostly sure that'll make them available...

cc @eessex or @izakp If there's a better way to do this we should probably follow up w/ a cleanup

+2 -2

0 comment

2 changed files

pr created time in 3 days

create barnchartsy/force

branch : add-cdn-urls

created branch time in 3 days

push eventartsy/force

Justin Bennett

commit sha 98b11963f309570ff8cbf91a4e02f02fac2fdf36

Remove CDN_URL from webpack config

view details

Justin Bennett

commit sha 9dc8d2a953ea8a0bc9c7bed02ffbcad5fbc36fdf

Revert "Remove CDN_URL from webpack config" This reverts commit 98b11963f309570ff8cbf91a4e02f02fac2fdf36.

view details

Justin Bennett

commit sha d6a86911c9e80a88764f8ed050aee2548002325f

Add staging/prod cdn env urls

view details

Justin Bennett

commit sha 3be60b600de6e1e4dace50a1f62307fc72135535

Merge pull request #5105 from artsy/env-update-take-6 Dynamically choose CDN url at runtime

view details

push time in 3 days

delete branch artsy/force

delete branch : env-update-take-6

delete time in 3 days

PR merged artsy/force

Dynamically choose CDN url at runtime

Given that we only build the force image once, we need to provide both CDN url references at build time and dynamically switch between them at runtime.

+18 -15

0 comment

3 changed files

zephraph

pr closed time in 3 days

Pull request review commentartsy/force

Dynamically choose CDN url at runtime

 exports.baseConfig = {     new webpack.DefinePlugin({       "process.env": {         NODE_ENV: JSON.stringify(NODE_ENV),-        CDN_URL: JSON.stringify(process.env.CDN_URL),+        CND_PRODUCTION_URL: JSON.stringify(process.env.CND_PRODUCTION_URL),+        CDN_STAGING_URL: JSON.stringify(process.env.CDN_STAGING_URL),

We want to replace both of these values at buildtime

zephraph

comment created time in 3 days

Pull request review commentartsy/force

Dynamically choose CDN url at runtime

  * @see https://github.com/artsy/force/blob/master/src/lib/middleware/assetMiddleware.ts  */ if (process.env.NODE_ENV === "production") {-  __webpack_public_path__ = "https://d1rmpw1xlv9rxa.cloudfront.net/assets/"--  // @ts-ignore-  window._logAssetPath = () => process.env.CDN_URL + "/assets/"+  __webpack_public_path__ =+    (window.location.hostname === "www.artsy.net"+      ? process.env.CDN_PRODUCTION_URL+      : process.env.CDN_STAGING_URL) + "/assets/"

If we're on prod we'll use the production url, otherwise we'll use staging. This isn't necessarily ideal, but it'll do for now.

zephraph

comment created time in 3 days

Pull request review commentartsy/force

Dynamically choose CDN url at runtime

 services:     environment:       - CI=true       - CIRCLE_NODE_INDEX+      - CDN_PRODUCTION_URL+      - CDN_STAGING_URL

I'm pretty sure using this syntax pulls in the envs from CI. I've added both of these environment variables in force's env settings in circleci's UI.

zephraph

comment created time in 3 days

PR opened artsy/force

Dynamically choose CDN url at runtime

Given that we only build the force image once, we need to provide both CDN url references at build time and dynamically switch between them at runtime.

+18 -15

0 comment

3 changed files

pr created time in 3 days

push eventartsy/force

Justin Bennett

commit sha 9dc8d2a953ea8a0bc9c7bed02ffbcad5fbc36fdf

Revert "Remove CDN_URL from webpack config" This reverts commit 98b11963f309570ff8cbf91a4e02f02fac2fdf36.

view details

Justin Bennett

commit sha d6a86911c9e80a88764f8ed050aee2548002325f

Add staging/prod cdn env urls

view details

push time in 3 days

create barnchartsy/force

branch : env-update-take-6

created branch time in 3 days

push eventartsy/dupe-report

Justin Bennett

commit sha e11e77535c33673b0bc182e1dd3bca5d02e2c0aa

Update ts build

view details

push time in 4 days

push eventartsy/reaction

Renovate Bot

commit sha 2bdb748726b91dc42aa9375e26c7ad6bbecc183f

Update dep typescript from 3.7.5 to v3.8.2

view details

Justin Bennett

commit sha 8c9acd152226e4f8200789dbafc992b0c887e9b3

Fix some type failures

view details

David Sheldrick

commit sha 2ba412b79aaf0ea2d8c91988533897e3fe9af3bf

Be more explicit about concrete types

view details

David Sheldrick

commit sha 9c8eacfd799395e175955e84bb1380686550f6c0

give up with this one

view details

Justin Bennett

commit sha a3ebc3df2c2d63128a10fa41bca2720bad861eae

Merge pull request #3183 from artsy/renovate/typescript-3.x Update dep typescript from 3.7.5 to v3.8.2

view details

push time in 4 days

delete branch artsy/reaction

delete branch : renovate/typescript-3.x

delete time in 4 days

PR merged artsy/reaction

Reviewers
Update dep typescript from 3.7.5 to v3.8.2 Version: Trivial

This PR contains the following updates:

Package Type Update Change
typescript (source) devDependencies minor 3.7.5 -> 3.8.2

Renovate configuration

:date: Schedule: At any time (no schedule defined).

:vertical_traffic_light: Automerge: Enabled.

:recycle: Rebasing: Whenever PR becomes conflicted, or if you tick the rebase/retry checkbox below.

:no_bell: Ignore: Close this PR and you won't be reminded about this update again.


  • [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

This PR has been generated by WhiteSource Renovate. View repository job log here. <!-- GITHUB_RELEASE PR BODY: canary-version --> <details> <summary>📦 Published PR as canary version: <code>25.14.2-canary.3183.52223.0</code></summary> <br />

:sparkles: Test out this PR locally via:

npm install @artsy/reaction@25.14.2-canary.3183.52223.0
# or 
yarn add @artsy/reaction@25.14.2-canary.3183.52223.0

</details> <!-- GITHUB_RELEASE PR BODY: canary-version -->

+31 -12

2 comments

8 changed files

renovate[bot]

pr closed time in 4 days

startedUnwrittenFun/svelte-vscode

started time in 4 days

issue commentintuit/auto

auto with a non-lerna project

Yeah, it's just the fact that a js file isn't statically analyzable in the same way that a JSON/yml file is so it makes it challenging to build automation against.

pvinis

comment created time in 4 days

delete branch artsy/palette

delete branch : add-delay-to-spinner

delete time in 5 days

push eventartsy/palette

Christopher Pappas

commit sha a3b39d53e09b139888b47377d420b6b968b68080

[Spinner] Adds delay prop for visibility

view details

Christopher Pappas

commit sha 70210afe3c9f3139f7e143937daf19a12d7398ce

[Spinner] Add quiick slight fade in

view details

Justin Bennett

commit sha e099a4c90a0db079982f27b68b4c18c901faa1bb

Merge pull request #640 from artsy/add-delay-to-spinner [Spinner] Adds delay prop for visibility

view details

push time in 5 days

PR merged artsy/palette

[Spinner] Adds delay prop for visibility Version: Minor

There's a lot of content around Artsy.net right now that is rendered by a QueryRender, which by default uses a spinner. However, often we make a request to MP but then decide not to render the content, leaving the UI jumpy as the spinner shows and hides.

Also added a quick 400ms fade in to make the transition less jarring.

This adds a new delay prop which will delay the rendering until x milliseconds. <!-- GITHUB_RELEASE PR BODY: canary-version --> <details> <summary>📦 Published PR as canary version: <code>7.0.1-canary.640.9679.0</code></summary> <br />

:sparkles: Test out this PR locally via:

npm install @artsy/palette@7.0.1-canary.640.9679.0
# or 
yarn add @artsy/palette@7.0.1-canary.640.9679.0

</details> <!-- GITHUB_RELEASE PR BODY: canary-version -->

+43 -3

0 comment

3 changed files

damassi

pr closed time in 5 days

pull request commentartsy/palette

Small dropdown arrow is misaligned

Looks good! Nice catch.

lilyfromseattle

comment created time in 5 days

PR opened artsy/force

Reviewers
Ensure dynamic chunks get cdn url prefix

Fixes an issue we saw on production where dynamic chunks were getting pulled from force instead of from the CDN.

+4 -1

0 comment

2 changed files

pr created time in 5 days

create barnchartsy/force

branch : fix-asset-paths-for-dynamic-chunks

created branch time in 5 days

delete branch zephraph/saasify

delete branch : patch-1

delete time in 6 days

push eventartsy/reaction

Justin Bennett

commit sha 8c9acd152226e4f8200789dbafc992b0c887e9b3

Fix some type failures

view details

push time in 6 days

PR opened saasify-sh/saasify

Update language to be consistent with pivot

A little de-emphasis on OSS and more focus on APIs.

This is just a suggestion, feel free to tweak the wording.

+2 -2

0 comment

1 changed file

pr created time in 6 days

push eventzephraph/saasify

Justin Bennett

commit sha c124912d33e71d87a748d7263cd50a4abf8d07df

Update language to be consistent with pivot A little de-emphasis on OSS and more focus on APIs. This is just a suggestion, feel free to tweak the wording.

view details

push time in 6 days

PR opened artsy/artsy.github.io

Typo correction

Just a small typo fix

+1 -1

0 comment

1 changed file

pr created time in 6 days

create barnchartsy/artsy.github.io

branch : zephraph-patch-1

created branch time in 6 days

startedPostHog/posthog

started time in 6 days

startedwoltapp/blurhash

started time in 6 days

startedgetgauge/taiko

started time in 6 days

push eventartsy/reaction

sepans

commit sha 074f7c4711d8604014dc05dbdafe7d7b9d8cbd0f

Add auction result filter instrumentation

view details

sepans

commit sha 061496426e4165371a639ba108afb3fd59ebb4e3

Add test, fix test

view details

Justin Bennett

commit sha cfc3e07e914357e86e93d9b33fe5b23eed7ac88b

Merge pull request #3178 from sepans/auction-house-instrumentation [PURCHASE-1790] Add auction result filter instrumentation

view details

push time in 6 days

PR merged artsy/reaction

Reviewers
[PURCHASE-1790] Add auction result filter instrumentation Version: Minor

Fixes PURCHASE-1790

Sample tracking events:

When size filter changes:

{
  "context_page": "Artist Auction Results",
  "context_page_owner_id": "4d8b928b4eb68a1b2c0001f2",
  "context_page_owner_slug": "pablo-picasso",
  "context_page_owner_type": "Artist",
  "action_type": "Auction results filter params changed",
  "current": {
    "organizations": [],
    "sizes": [
      "MEDIUM"
    ],
    "openedItemIndex": null,
    "page": 1,
    "sort": "ESTIMATE_AND_DATE_DESC"
  },
  "changed": {
    "sizes": [
      "MEDIUM"
    ]
  }
}

When sort changes:

{
  "context_page": "Artist Auction Results",
  "context_page_owner_id": "4d8b928b4eb68a1b2c0001f2",
  "context_page_owner_slug": "pablo-picasso",
  "context_page_owner_type": "Artist",
  "action_type": "Auction results filter params changed",
  "current": {
    "organizations": [],
    "sizes": [],
    "openedItemIndex": null,
    "page": 1,
    "sort": "ESTIMATE_AND_DATE_DESC"
  },
  "changed": {
    "sort": "ESTIMATE_AND_DATE_DESC"
  }
}

When a lot is expanded:

{
  "context_page": "Artist Auction Results",
  "context_page_owner_id": "4d8b928b4eb68a1b2c0001f2",
  "context_page_owner_slug": "pablo-picasso",
  "context_page_owner_type": "Artist",
  "action_type": "Auction results filter params changed",
  "current": {
    "organizations": [],
    "sizes": [],
    "openedItemIndex": 2,
    "page": 1,
    "sort": "ESTIMATE_AND_DATE_DESC"
  },
  "changed": {
    "openedItemIndex": 2
  }
}
+52 -16

4 comments

4 changed files

sepans

pr closed time in 6 days

pull request commentartsy/reaction

[PURCHASE-1790] Add auction result filter instrumentation

@sepands, I believe that is the case, yes.

sepans

comment created time in 6 days

push eventartsy/reaction

Justin Bennett

commit sha 9bc53ce3a4a97bf0ca7ec5d487aa3c09d55c6acf

Revert "Test behavior when a dependency changes" This reverts commit 45308533bc87f87f3028f8fa085f4c8089bfac29.

view details

push time in 7 days

delete branch artsy/artsy.github.io

delete branch : deploying-canaries-with-auto

delete time in 7 days

push eventartsy/artsy.github.io

Justin Bennett

commit sha 1bac9c0543ae5cc50e2061449751222cc305b68d

Add blogpost on using auto to deploy canary packages

view details

Justin Bennett

commit sha 358bd8ff558bb925a7ddf82485cecb7fc9a77b51

Add line break

view details

Justin Bennett

commit sha 05edaa1998f16844dd07184f610b80c5f257846f

Merge pull request #607 from artsy/deploying-canaries-with-auto Add blogpost on using auto to deploy canary packages

view details

push time in 7 days

PR merged artsy/artsy.github.io

Add blogpost on using auto to deploy canary packages

I recently enabled automatic canary package releases across all our auto powered repositories. This blog post details some of the motivations behind that.

Feedback welcome 🙏. It's a little high level right now, let me know if I should dig into more specifics.

cc @mzikherman, @eessex, and @anandaroop being as you've all been apart of this process in some way.

+65 -0

0 comment

1 changed file

zephraph

pr closed time in 7 days

push eventartsy/reaction

Justin Bennett

commit sha f5237d4c6fa32287b16870e78d08d581376ef90f

bump to force rebuild

view details

push time in 7 days

push eventartsy/orbs

Justin Bennett

commit sha af1885611f185bcc2a9a385855691469557abbfd

Update diff to also check origin/master

view details

push time in 7 days

push eventartsy/reaction

Justin Bennett

commit sha 4da97ef039812b40eb7a65c226dfc3c7ccc91454

Remove weird 2 file generated by yarn integrate

view details

Justin Bennett

commit sha 5452b87f35bcb4a67b5cb377f3040741f0e3df02

Merge pull request #3180 from artsy/fix-integrate-pollution Remove weird 2 file generated by yarn integrate

view details

push time in 7 days

delete branch artsy/reaction

delete branch : fix-integrate-pollution

delete time in 7 days

PR merged artsy/reaction

Remove weird 2 file generated by yarn integrate Merge On Green Version: Trivial

yarn integrate likes to create this file which accidentally gets checked in. Not sure what it's for, but it doesn't need to be in git. <!-- GITHUB_RELEASE PR BODY: canary-version --> <details> <summary>📦 Published PR as canary version: <code>25.11.7-canary.3180.52017.0</code></summary> <br />

:sparkles: Test out this PR locally via:

npm install @artsy/reaction@25.11.7-canary.3180.52017.0
# or 
yarn add @artsy/reaction@25.11.7-canary.3180.52017.0

</details> <!-- GITHUB_RELEASE PR BODY: canary-version -->

+1 -1

1 comment

2 changed files

zephraph

pr closed time in 7 days

push eventartsy/reaction

Justin Bennett

commit sha 45308533bc87f87f3028f8fa085f4c8089bfac29

Test behavior when a dependency changes

view details

push time in 7 days

pull request commentartsy/reaction

Experiment with making CI times much faster

Okay, that last commit worked perfectly 👍

zephraph

comment created time in 7 days

more