profile
viewpoint
If you are wondering where the data of this site comes from, please visit https://api.github.com/users/zackschuster/events. GitMemory does not store any data, but only uses NGINX to cache data for a period of time. The idea behind GitMemory is simply to give users a better reading experience.
Zack Schuster zackschuster @CodestackSJ ø git.sr.ht/~ledge g̶r̷o̵w̸ ̷o̸l̵d̴ ̵a̸l̸o̸n̴g̶ ̵w̴i̷t̶h̶ ̴m̴e̵!̷ ̴t̴h̵e̸ ̵b̷e̶s̷t̷ ̵i̸s̴ ̶y̵e̸t̵ ̵t̶o̸ ̶b̴e̷

eleith/emailjs 1943

html emails and attachments to any smtp server with nodejs

zackschuster/programming-books 10

epub/mobi/pdf downloads for various guides

zackschuster/ng-app 6

Powerful, easy-to-use app container for Angular.js with ES Modules. Supports IE11. Types Included. [Mirror of git.sr.ht/~ledge/ng-app - Issues only; PRs not accepted]

CodeStackSJ/CodeStackMeetup 0

CodeStack Meetup Presentations and Code Samples

zackschuster/twitter-export-image-fill 0

A script to download (backup locally) all the images accompanying your tweets

zackschuster/vscode-duck-keybindings 0

Some custom keymaps for VS Code. Quack.

startedtc39/proposal-hashbang

started time in 2 days

push eventCodeStackSJ/CodeStackMeetup

Zack Schuster

commit sha 2c185d2449bc607806c4c341143c599b8af96369

0030: init

view details

push time in 15 days

pull request commenteleith/emailjs

feat: return promise from Message read

@CarsonF this (as well as your other PR) should be live as of v3.6.0 😄

CarsonF

comment created time in 16 days

issue commenteleith/emailjs

embedding image

closing as stalled

velociwabbit

comment created time in 19 days

issue closedeleith/emailjs

embedding image

I am not sure whether to mention this here or in your website but embedding svg images is unclear with the docs that you presently provide.

I have an image called betimg where the first few chars are

"data:image/svg+xml;base64,PHN2ZyB4bWxucz0iaHR0cDo..."

I want to embed it into an email. I have successfully sent it as template_params value

template_params : { betimg: 'data:image/svg+xml;base64,PH..." }

and have added a content-ID value to the the fetch

xhr.setRequestHeader('Content-ID' , 'betimg' )

also on the template have added it as a parameter and a file name

and nothing I do with the template works to render the image

It is unclear whether your template {{betimg}} would be sufficient or do I need to declare an HTML section and embed it there? and if so will the following work <img src="cid:betimg" />

or do I need something like this:

<HTML><body><img src="cid:betimg" /></body></HTML>

And if HTML is disabled is there another way to embed an image? I think that the email spec provides it but your docs are sparse.

Example templates that include embedded images would be helpful.

Just to be clear and hopefully give you an alarm bell that this is a serious quality problem.

Emailjs has been around for many years and this issue is not covered properly on your website.

I am a small customer now but hope to be a bigger one...

closed time in 19 days

velociwabbit

PR opened eleith/emailjs

Reviewers
release: update for 3.6.0
+351 -266

0 comment

12 changed files

pr created time in 20 days

create barncheleith/emailjs

branch : v3.6.0

created branch time in 20 days

push eventeleith/emailjs

Zack Schuster

commit sha c31412f0ea91dfdd89bdd31a55aea914bd1b89f7

chore: upgrade deps typescript update blocked due to https://github.com/microsoft/TypeScript/issues/45633

view details

Zack Schuster

commit sha 0d497e9072163907f9817c1d24248dc31a5df2e5

test: prepare for ts4.4

view details

Zack Schuster

commit sha 52b82711f129b401cdf456793072008361ad15af

chore: add example to readme

view details

push time in 20 days

push eventeleith/emailjs

Zack Schuster

commit sha a2b240d17705c21a7178e1b63b7fd16ea85abeaf

chore: upgrade deps typescript update blocked due to https://github.com/microsoft/TypeScript/issues/45633

view details

Zack Schuster

commit sha 4374122320a8f9456372aa4b7803fbcbc08bcb7a

test: prepare for ts4.4

view details

Zack Schuster

commit sha 82c5bffac4531207955a5e219ae5d59c6bdb63d6

chore: add example to readme

view details

push time in 20 days

push eventeleith/emailjs

Zack Schuster

commit sha 81cc94b92919ea81c24daa28e1e6c1051d05852e

message: add `checkValidity` method & deprecate `valid`

view details

push time in 20 days

PR merged eleith/emailjs

message: add `checkValidity` method & deprecate `valid`

it's time to clean it up, i think.

valid will be kept for compat purposes, with an eye on removing it in (a completely hypothetical) v4. downstream will be encouraged to switch to the new apis via the @deprecated jsdoc tag.

of note: isValidAsync will technically never resolve to false, which just feels incorrect. i'm open to suggestions for changing that design.

+89 -83

3 comments

4 changed files

zackschuster

pr closed time in 20 days

issue commentangular/angular-cli

Component level CSS optimization error - Invalid version: "TP"

angular's official window of support is extremely short, which is specifically why i went for that config. the compiler should not error out-of-hand over such things, especially when the subset of features i use strictly conforms to a 2017-era compatibility matrix. if i want to go beyond what angular supports, then angular should not get in my way.

zackschuster

comment created time in 21 days

issue commentangular/angular-cli

Component level CSS optimization error - Invalid version: "TP"

i had supports es6-module in .browserslistrc, same as the linked issue. adding not safari tp indeed fixes the build. still seems kind of weird overall, not just to have to do that but that it only affects css compilation (??).

zackschuster

comment created time in 21 days

issue openedangular/angular-cli

Component-level CSS compilation on macOS broken on ~12.2.3

Which @angular/* package(s) are the source of the bug?

compiler

Is this a regression?

Yes

Description

see title. this occurs for all css, whether inlined using styles or referenced via styleUrls, and occurs for scss compilation as well. global css compiles fine.

Please provide a link to a minimal reproduction of the bug

No response

Please provide the exception or error you saw

Error: [REDACTED].scss from Css Minimizer
Error: Transform failed with 1 error:
error: Invalid version: "TP"
    at failureErrorWithLog (/Users/zschuster/Source/SARC_V2_Client/node_modules/esbuild/lib/main.js:1451:15)
    at /Users/zschuster/Source/SARC_V2_Client/node_modules/esbuild/lib/main.js:1262:29
    at /Users/zschuster/Source/SARC_V2_Client/node_modules/esbuild/lib/main.js:609:9
    at handleIncomingPacket (/Users/zschuster/Source/SARC_V2_Client/node_modules/esbuild/lib/main.js:706:9)
    at Socket.readFromStdout (/Users/zschuster/Source/SARC_V2_Client/node_modules/esbuild/lib/main.js:576:7)
    at Socket.emit (node:events:394:28)
    at addChunk (node:internal/streams/readable:312:12)
    at readableAddChunk (node:internal/streams/readable:287:9)
    at Socket.Readable.push (node:internal/streams/readable:226:10)
    at Pipe.onStreamRead (node:internal/stream_base_commons:190:23)

Please provide the environment you discovered this bug in

Angular CLI: 12.2.3
Node: 14.17.4
Package Manager: npm 7.20.3
OS: darwin x64

Angular: 12.2.3
... animations, cdk, cli, common, compiler, compiler-cli, core
... forms, material, platform-browser, platform-browser-dynamic
... router

Package                         Version
---------------------------------------------------------
@angular-devkit/architect       0.1202.3
@angular-devkit/build-angular   12.2.3
@angular-devkit/core            12.2.3
@angular-devkit/schematics      12.2.3
@schematics/angular             12.2.3
rxjs                            7.3.0
typescript                      4.3.5

Anything else?

this appears to be a bug in esbuild browser version detection

created time in 21 days

issue openedangular/angular

SCSS compilation on macOS broken for v12.2.4

Which @angular/* package(s) are the source of the bug?

compiler

Is this a regression?

Yes

Description

see title

Please provide a link to a minimal reproduction of the bug

No response

Please provide the exception or error you saw

Error: [REDACTED].scss from Css Minimizer
Error: Transform failed with 1 error:
error: Invalid version: "TP"
    at failureErrorWithLog (/Users/zschuster/Source/SARC_V2_Client/node_modules/esbuild/lib/main.js:1451:15)
    at /Users/zschuster/Source/SARC_V2_Client/node_modules/esbuild/lib/main.js:1262:29
    at /Users/zschuster/Source/SARC_V2_Client/node_modules/esbuild/lib/main.js:609:9
    at handleIncomingPacket (/Users/zschuster/Source/SARC_V2_Client/node_modules/esbuild/lib/main.js:706:9)
    at Socket.readFromStdout (/Users/zschuster/Source/SARC_V2_Client/node_modules/esbuild/lib/main.js:576:7)
    at Socket.emit (node:events:394:28)
    at addChunk (node:internal/streams/readable:312:12)
    at readableAddChunk (node:internal/streams/readable:287:9)
    at Socket.Readable.push (node:internal/streams/readable:226:10)
    at Pipe.onStreamRead (node:internal/stream_base_commons:190:23)

Please provide the environment you discovered this bug in

Angular CLI: 12.2.4
Node: 14.17.4
Package Manager: npm 7.20.3
OS: darwin x64

Angular: 12.2.4
... animations, cli, common, compiler, compiler-cli, core, forms
... localize, platform-browser, platform-browser-dynamic, router

Package                         Version
---------------------------------------------------------
@angular-devkit/architect       0.1202.4
@angular-devkit/build-angular   12.2.4
@angular-devkit/core            12.2.4
@angular-devkit/schematics      12.2.4
@schematics/angular             12.2.4
rxjs                            6.6.7
typescript                      4.3.5

Anything else?

No response

created time in 21 days

delete branch CodeStackSJ/CodeStackMeetup

delete branch : dependabot/npm_and_yarn/0008-IonicBeginner/ionicExample/tar-4.4.19

delete time in 21 days

push eventCodeStackSJ/CodeStackMeetup

dependabot[bot]

commit sha 401a0803086e0ed6a951fa0658a06a59764bd88a

build(deps): bump tar in /0008-IonicBeginner/ionicExample Bumps [tar](https://github.com/npm/node-tar) from 4.4.15 to 4.4.19. - [Release notes](https://github.com/npm/node-tar/releases) - [Changelog](https://github.com/npm/node-tar/blob/main/CHANGELOG.md) - [Commits](https://github.com/npm/node-tar/compare/v4.4.15...v4.4.19) --- updated-dependencies: - dependency-name: tar dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>

view details

push time in 21 days

PR merged CodeStackSJ/CodeStackMeetup

build(deps): bump tar from 4.4.15 to 4.4.19 in /0008-IonicBeginner/ionicExample dependencies

Bumps tar from 4.4.15 to 4.4.19. <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/npm/node-tar/commit/9a6faa017ca90538840f3ae2ccdb4550ac3f4dcf"><code>9a6faa0</code></a> 4.4.19</li> <li><a href="https://github.com/npm/node-tar/commit/70ef812593184cc54ea1bc74c5dae2d22995002d"><code>70ef812</code></a> drop dirCache for symlink on all platforms</li> <li><a href="https://github.com/npm/node-tar/commit/3e35515c09da615ac268254bed85fe43ee71e2f0"><code>3e35515</code></a> 4.4.18</li> <li><a href="https://github.com/npm/node-tar/commit/52b09e309bcae0c741a7eb79a17ef36e7828b946"><code>52b09e3</code></a> fix: prevent path escape using drive-relative paths</li> <li><a href="https://github.com/npm/node-tar/commit/bb93ba243746f705092905da1955ac3b0509ba1e"><code>bb93ba2</code></a> fix: reserve paths properly for unicode, windows</li> <li><a href="https://github.com/npm/node-tar/commit/2f1bca027286c23e110b8dfc7efc10756fa3db5a"><code>2f1bca0</code></a> fix: prune dirCache properly for unicode, windows</li> <li><a href="https://github.com/npm/node-tar/commit/9bf70a8cf725c3af5fe2270f1e5d2e06d1559b93"><code>9bf70a8</code></a> 4.4.17</li> <li><a href="https://github.com/npm/node-tar/commit/6aafff0a8621ba9509b63654bde28762be373d58"><code>6aafff0</code></a> fix: skip extract if linkpath is stripped entirely</li> <li><a href="https://github.com/npm/node-tar/commit/5c5059a69c2aaaedfe4e9766e102ae9fb79e8255"><code>5c5059a</code></a> fix: reserve paths case-insensitively</li> <li><a href="https://github.com/npm/node-tar/commit/fd6accba697070560f301604b8f5f7e2995a2a8b"><code>fd6accb</code></a> 4.4.16</li> <li>Additional commits viewable in <a href="https://github.com/npm/node-tar/compare/v4.4.15...v4.4.19">compare view</a></li> </ul> </details> <br />

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


<details> <summary>Dependabot commands and options</summary> <br />

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language

You can disable automated security fix PRs for this repo from the Security Alerts page.

</details>

+18 -10

0 comment

1 changed file

dependabot[bot]

pr closed time in 21 days

push eventeleith/emailjs

Carson Full

commit sha 0516e3825cf75ce62183367f3a2108ab165c779d

feat: Message readAsync

view details

Zack Schuster

commit sha 6f435a402e901d9bce2358ce18702996d78242ad

message: add `checkValidity` method & deprecate `valid`

view details

push time in a month

pull request commenteleith/emailjs

feat: return promise from Message read

Thank you! 😄

CarsonF

comment created time in a month

push eventeleith/emailjs

Carson Full

commit sha 0516e3825cf75ce62183367f3a2108ab165c779d

feat: Message readAsync

view details

push time in a month

PR merged eleith/emailjs

feat: return promise from Message read

I want to use this library to build mime messages that I'll send to AWS SES directly. This makes it easier to get the built message back.

+12 -0

2 comments

1 changed file

CarsonF

pr closed time in a month

PullRequestReviewEvent

pull request commenteleith/emailjs

message: add `checkValidity` method & deprecate `valid`

after a bit of thought, i went with a single new synchronous API, naming it checkValidity due to the similarly named HTMLObjectElement API. it will never intentionally throw, and instead returns an object with the validation results inside it. valid is now a proxy to checkValidity.

zackschuster

comment created time in a month

push eventeleith/emailjs

Zack Schuster

commit sha d51f016220aee0d713fd6d89717e31aa2a60ac0c

message: add `checkValidity` method & deprecate `valid`

view details

push time in a month

pull request commenteleith/emailjs

message: add `isValid`/`isValidAsync` methods & deprecate `valid`

@CarsonF i think so too. the only problem is that valid and isValid/validate return both a boolean & a reason why validation failed. the most straightforward way of replicating that pattern is to throw an error & leave it implied by the rejection that validation failed. unsure how to proceed.

zackschuster

comment created time in a month

issue commenteleith/emailjs

node 10 support & the future

update: ts-node@10 can now override "type": "module", which allows us to test our dual-package setup without sacrificing node@10. this means that as of d7b9236ed06cc3a74c056807b9d00da9596041d3, yarn test now runs natively as ESM on node@>=12, while yarn test-cjs will always compile & run as CJS. woohoo!

unfortunately, the tradeoff was being forced to use --ignore-engines to install on node@10, since ts-node@10 deprecated that version. for now it's fine since we're only using ts-node's legacy CJS code, but it does officially put us on borrowed time w/r/t upgrading. still, i believe this is as a pretty substantial win. 🎉

zackschuster

comment created time in a month

PR opened eleith/emailjs

Reviewers
message: add `isValid`/`isValidAsync` methods & deprecate `valid`

it's time to clean it up, i think.

valid will be kept for compat purposes, with an eye on removing it in (a completely hypothetical) v4. downstream will be encouraged to switch to the new apis via the @deprecated jsdoc tag.

of note: isValidAsync will technically never resolve to false, which just feels incorrect. i'm open to suggestions for changing that design.

+43 -22

0 comment

4 changed files

pr created time in a month

push eventeleith/emailjs

Zack Schuster

commit sha 63401a086826b1bf398ed4f517baaa34bc132c8b

build: fix workflows for node 10

view details

Zack Schuster

commit sha 0e461c55f0e3ee168653af57ac026e6482dc2fb5

message: add `isValid`/`isValidAsync` methods & deprecate `valid`

view details

push time in a month

push eventeleith/emailjs

Zack Schuster

commit sha 63401a086826b1bf398ed4f517baaa34bc132c8b

build: fix workflows for node 10

view details

push time in a month