profile
viewpoint

yixingz3/gson 0

A Java serialization/deserialization library to convert Java Objects into JSON and back

yixingz3/java-design-patterns 0

Design patterns implemented in Java

pull request commentgoogle/gson

feat: added UPPER_CASE_WITH_UNDERSCORES in FieldNamingPolicy

e future: GitHub understa

Thank you for the tips! Next time I'll make sure to use one of the keywords :)

yixingz3

comment created time in 4 days

delete branch yixingz3/gson

delete branch : add_UPPER_CASE_WITH_UNDERSCORES_Field_Name_Policy

delete time in 4 days

Pull request review commentgoogle/gson

feat: added UPPER_CASE_WITH_UNDERSCORES in FieldNamingPolicy

     }   }, +  /**+   * Using this naming policy with Gson will modify the Java Field name from its camel cased+   * form to a upper case field name where each word is separated by an underscore (_).+   *+   * <p>Here's a few examples of the form "Java Field Name" ---&gt; "JSON Field Name":</p>

No problem! In this case, I think "a few" would be more appropriate as we are emphasizing that there are some examples. Also found some readings on the subject: this and this. Hopefully, now we've got everything and thank you again!

yixingz3

comment created time in 7 days

PullRequestReviewEvent

push eventyixingz3/gson

Yixing Zheng

commit sha b63e52c32888a9a7a4aaa2a2085efb82fa9545c8

fix: update it to "here are a few examples"

view details

push time in 7 days

pull request commentgoogle/gson

feat: added UPPER_CASE_WITH_UNDERSCORES in FieldNamingPolicy

It might require some minor documentation adjustments. But besides that it is great how well you integrated it into the existing tests!

Note that I am not a member of Gson, so please consider my review comments only as suggestions.

Thank you so much for reviewing it! Somehow I messed up the committed request from you so I had to make the change and re-commit, hopefully that's okay. The issues are fixed though.

yixingz3

comment created time in 10 days

push eventyixingz3/gson

Yixing Zheng

commit sha 0622367f51fbd5e9ff748562df103abd595cccaf

fix: fixed comment

view details

push time in 10 days

push eventyixingz3/gson

Yixing Zheng

commit sha 15efddf5139ebb394396a8e10990ade24274ac55

fix: fixed doc

view details

push time in 10 days

push eventyixingz3/gson

Marcono1234

commit sha 16b42ff5805074126c2e5484450c182773e408a2

Update Caliper dependency; disable automatic result upload (#2019)

view details

Yixing Zheng

commit sha 05d2f782b5bd49ddc26a6dc790beaf2a22067793

fix: fixed comment grammar

view details

Yixing Zheng

commit sha 37593b2a3749637fb455ca8bb78d94bfb2b8454a

Merge branch 'master' of github.com:google/gson into add_UPPER_CASE_WITH_UNDERSCORES_Field_Name_Policy

view details

push time in 10 days

push eventyixingz3/gson

yixingz3

commit sha 9676f33f588dec7e8a26bdfaa3625270e46cb64c

fixed comment grammar Co-authored-by: Marcono1234 <Marcono1234@users.noreply.github.com>

view details

push time in 10 days

Pull request review commentgoogle/gson

feat: added UPPER_CASE_WITH_UNDERSCORES in FieldNamingPolicy

     }   }, +  /**+   * Using this naming policy with Gson will modify the Java Field name from its camel cased+   * form to a upper case field name where each word is separated by an underscore (_).+   *+   * <p>Here's a few examples of the form "Java Field Name" ---&gt; "JSON Field Name":</p>

Yes, you are right, grammar-wise It should be 'Here are'. But I guess 'Here is' would also work in this case, similar to 'Any changes', not seen here but also commonly used. And for consistency, should we just leave it as is?

yixingz3

comment created time in 10 days

PullRequestReviewEvent

push eventyixingz3/gson

yixingz3

commit sha 7d3abf5c650575ad3f7e9b5e5939987280b84d51

Update gson/src/main/java/com/google/gson/FieldNamingPolicy.java Co-authored-by: Marcono1234 <Marcono1234@users.noreply.github.com>

view details

push time in 10 days

Pull request review commentgoogle/gson

feat: added UPPER_CASE_WITH_UNDERSCORES in FieldNamingPolicy

     }   }, +  /**+   * Using this naming policy with Gson will modify the Java Field name from its camel cased+   * form to a upper case field name where each word is separated by an underscore (_).

Thank you for catching these!

yixingz3

comment created time in 10 days

PullRequestReviewEvent

Pull request review commentgoogle/gson

feat: added UPPER_CASE_WITH_UNDERSCORES in FieldNamingPolicy

     }   }, +    /**

Ah! Good catch, don't know how I missed it...it's fixed now. And thank you for reviewing it so quickly!

yixingz3

comment created time in 10 days

PullRequestReviewEvent

push eventyixingz3/gson

Yixing Zheng

commit sha 837c4263b1a7553d2f5e3c46e3c22ab5f61262a8

fix: fixed indentation

view details

push time in 10 days

push eventyixingz3/gson

Yixing Zheng

commit sha f43d910736a96c292b284a8b311e8c236721a57f

feat: added UPPER_CASE_WITH_UNDERSCORES for FieldNamingPolicy

view details

push time in 11 days

PR opened google/gson

feat: added UPPER_CASE_WITH_UNDERSCORES in FieldNamingPolicy
  • added UPPER_CASE_WITH_UNDERSCORES in FieldNamingPolicy
  • added tests for the new field
+45 -1

0 comment

4 changed files

pr created time in 11 days

fork yixingz3/gson

A Java serialization/deserialization library to convert Java Objects into JSON and back

fork in 11 days

PR opened iluwatar/java-design-patterns

feat: Added Serialized lob design pattern (Issue #1596)
  • Added SLOB design pattern.
  • Serialize a graph into a single large object (LOB) and store it in the database.

This issue has two duplications, #1314 and #1596. At the time I picked the issue, I didn't realize there was a nearly completed PR for #1314. And I was going with a slightly different approach (without XML), hopefully it's still okay.

Also, I understand that this issue (#1596) was assigned to @dctrue2 a few weeks ago. We are working as a team to contribute to different issues (~6) in this repo. And in this case, I will submit the PR for #1596 and another member of my team will submit the PR for the issue that I initially signed up for. We are sorry about the confusion and hope this wouldn't be too much inconvenience for you. I will be actively making changes to this PR and aiming for merging it in (if the approach is okay), so please let me know what you think and what I can do, Thank you!

+899 -0

0 comment

11 changed files

pr created time in 13 days

push eventyixingz3/java-design-patterns

Yixing Zheng

commit sha b8523b1b3bd8403cd3b8cc6a5041132ab1eda158

feat: added code for SOLB design pattern

view details

Yixing Zheng

commit sha f410c0073f87092689697f9939c0d077b48cbde5

fix: updated logic for SLOB pattern

view details

push time in 13 days

push eventyixingz3/java-design-patterns

Yixing Zheng

commit sha 516e9c3ad0161b2c123982a6a25c3774060fc7e4

feat: added code for SOLB design pattern

view details

push time in 17 days

create barnchyixingz3/java-design-patterns

branch : serializedLOB

created branch time in 17 days

push eventyixingz3/java-design-patterns

Yixing Zheng

commit sha 3dc1dd4a9961c63bc106308e8b2cb3c8dc59d778

first commit

view details

push time in a month

create barnchyixingz3/java-design-patterns

branch : issueName1

created branch time in a month

issue commentiluwatar/java-design-patterns

Application Controller pattern

We would like to give a shot at this in October/November. Could you assign it to me? Thank you!

iluwatar

comment created time in 2 months

more