profile
viewpoint

yach-yf/kvm-guest-drivers-windows 0

Windows paravirtualized

delete branch yach-yf/kvm-guest-drivers-windows

delete branch : netkvm-ipv6-ipsec-fix

delete time in 2 months

PR closed yach-yf/kvm-guest-drivers-windows

NetKVM: Fix dropping IPv6 IPsec packets.

Explicitly treat IPv6 ESP packet as usual packet (TCP, UDP, etc.). ESP header should not be treated like other extension headers. Because it does not start with 'Next Header' and 'Hdr Ext Len' fields and next header is encrypted.

Signed-off-by: yach-yf 90957906+yach-yf@users.noreply.github.com

+2 -2

0 comment

1 changed file

yach-yf

pr closed time in 2 months

PR opened yach-yf/kvm-guest-drivers-windows

NetKVM: Fix dropping IPv6 IPsec packets.

Explicitly treat IPv6 ESP packet as usual packet (TCP, UDP, etc.). ESP header should not be treated like other extension headers. Because it does not start with 'Next Header' and 'Hdr Ext Len' fields and next header is encrypted.

Signed-off-by: yach-yf 90957906+yach-yf@users.noreply.github.com

+2 -2

0 comment

1 changed file

pr created time in 2 months

push eventyach-yf/kvm-guest-drivers-windows

yach-yf

commit sha e04ad11081daf83de7bf982aed241c9bb3bfc488

NetKVM: Fix dropping IPv6 IPsec packets. Explicitly treat IPv6 ESP packet as usual packet (TCP, UDP, etc.). ESP header should not be treated like other extension headers. Because it does not start with 'Next Header' and 'Hdr Ext Len' fields and next header is encrypted. Signed-off-by: yach-yf <90957906+yach-yf@users.noreply.github.com>

view details

Kostiantyn Kostiuk

commit sha a38ed283e89fd078189b94e2ea9f177a8be4a97f

Build DLV for vioinput\hidpassthrough Signed-off-by: Kostiantyn Kostiuk <konstantin@daynix.com>

view details

push time in 2 months

pull request commentvirtio-win/kvm-guest-drivers-windows

NetKVM: Fix dropping IPv6 IPsec packets.

Thank you very much. I'm looking forward to get signed driver, to turn off the test mode of my VPN server.

yach-yf

comment created time in 2 months

pull request commentvirtio-win/kvm-guest-drivers-windows

NetKVM: Fix dropping IPv6 IPsec packets.

I added "Signed-off-by: " by the feature of TortoiseGit. Of course, I confirmed no file differences.

yach-yf

comment created time in 2 months

push eventyach-yf/kvm-guest-drivers-windows

yach-yf

commit sha 382034e8576a4ec70b007012b5a09f9e6811085f

NetKVM: Fix dropping IPv6 IPsec packets. Explicitly treat IPv6 ESP packet as usual packet (TCP, UDP, etc.). ESP header should not be treated like other extension headers. Because it does not start with 'Next Header' and 'Hdr Ext Len' fields and next header is encrypted. Signed-off-by: yach-yf <90957906+yach-yf@users.noreply.github.com>

view details

push time in 2 months

pull request commentvirtio-win/kvm-guest-drivers-windows

NetKVM: Fix dropping IPv6 IPsec packets.

I confirmed that IPv6 IPsec works fine at HEAD revision(328edb5c6c9ba6227e9ed00b05855add52022726).

yach-yf

comment created time in 3 months

pull request commentvirtio-win/kvm-guest-drivers-windows

NetKVM: Fix dropping IPv6 IPsec packets.

Rebased. I confirmed no file differences.

yach-yf

comment created time in 3 months

push eventyach-yf/kvm-guest-drivers-windows

yach-yf

commit sha 328edb5c6c9ba6227e9ed00b05855add52022726

NetKVM: Fix dropping IPv6 IPsec packets. Explicitly treat IPv6 ESP packet as usual packet (TCP, UDP, etc.). ESP header should not be treated like other extension headers. Because it does not start with 'Next Header' and 'Hdr Ext Len' fields and next header is encrypted.

view details

push time in 3 months

push eventyach-yf/kvm-guest-drivers-windows

Kostiantyn Kostiuk

commit sha 119238e3d3485aa1cfe3cc9ff4e22376e2e93fc1

NetKVM: Use 'enum class' instead of 'enum' (CA warning 26812) Update _etagHistoryLogOperation enum Signed-off-by: Kostiantyn Kostiuk <konstantin@daynix.com>

view details

Kostiantyn Kostiuk

commit sha a5a72476c586d30e2925a551768c9eeea4f75714

NetKVM: Use 'enum class' instead of 'enum' (CA warning 26812) Update NotifyEvent enum Signed-off-by: Kostiantyn Kostiuk <konstantin@daynix.com>

view details

Kostiantyn Kostiuk

commit sha cab22f35078a5472c6a79d66083d9fe85a38f1ac

NetKVM: Use 'enum class' instead of 'enum' (CA warning 26812) Update FlowState enum Signed-off-by: Kostiantyn Kostiuk <konstantin@daynix.com>

view details

Kostiantyn Kostiuk

commit sha bf50cc9a3a2a4d33c753aa303607fa1e5afdc72e

NetKVM: Use 'enum class' instead of 'enum' (CA warning 26812) Update MiniportState enum Signed-off-by: Kostiantyn Kostiuk <konstantin@daynix.com>

view details

Kostiantyn Kostiuk

commit sha e169859ae5c9011ee4d48d7860f3f3d0922a4b97

NetKVM: Use 'enum class' instead of 'enum' (CA warning 26812) Update _tagPARANDIS_RSS_MODE enum. Signed-off-by: Kostiantyn Kostiuk <konstantin@daynix.com>

view details

Kostiantyn Kostiuk

commit sha d5ba0cb3090e1ed913cd859a395a600d7b946dc8

NetKVM: Move ParaNdis-SM.h to header files group Signed-off-by: Kostiantyn Kostiuk <konstantin@daynix.com>

view details

Kostiantyn Kostiuk

commit sha e5eaaf9f650494ca3999ef3157bc288202c627a3

NetKVM: Use 'enum class' instead of 'enum' (CA warning 26812) Updatee SMNotifications enum Signed-off-by: Kostiantyn Kostiuk <konstantin@daynix.com>

view details

Kostiantyn Kostiuk

commit sha 4378dddc00ef6b7b94a4e066cf70ab968fa7f8e8

NetKVM: Fix SMNotifications enum value spelling Signed-off-by: Kostiantyn Kostiuk <konstantin@daynix.com>

view details

Kostiantyn Kostiuk

commit sha 483395fcbee8572e597debb8d6d212df9b39bcc6

NetKVM: Use 'enum class' instead of 'enum' (CA warning 26812) Update _tagSubmitTxPacketResult enum. Signed-off-by: Kostiantyn Kostiuk <konstantin@daynix.com>

view details

Kostiantyn Kostiuk

commit sha 9b4b3998c8a5a0054f86669f82a4f1ae2cee13eb

NetKVM: Use 'enum class' instead of 'enum' (CA warning 26812) Update _tagppResult enum. Signed-off-by: Kostiantyn Kostiuk <konstantin@daynix.com>

view details

Kostiantyn Kostiuk

commit sha 45e37d579abf5a7c08221788ae3568bbae658350

NetKVM: Use 'enum class' instead of 'enum' (CA warning 26812) Update _tagPacketOffloadRequest enum. Signed-off-by: Kostiantyn Kostiuk <konstantin@daynix.com>

view details

Ilya Rudakov

commit sha 60db79b36a0a02bd2c7423efe7600778682a807b

viosock: missing vio_wsk.h Signed-off-by: Ilya Rudakov <irudakov@virtuozzo.com>

view details

yach-yf

commit sha a233c0cef1ec197a083489b0f1ef3fd6d4fb9787

Merge branch 'virtio-win:master' into netkvm-ipv6-ipsec-fix

view details

push time in 3 months

push eventyach-yf/kvm-guest-drivers-windows

Kostiantyn Kostiuk

commit sha 119238e3d3485aa1cfe3cc9ff4e22376e2e93fc1

NetKVM: Use 'enum class' instead of 'enum' (CA warning 26812) Update _etagHistoryLogOperation enum Signed-off-by: Kostiantyn Kostiuk <konstantin@daynix.com>

view details

Kostiantyn Kostiuk

commit sha a5a72476c586d30e2925a551768c9eeea4f75714

NetKVM: Use 'enum class' instead of 'enum' (CA warning 26812) Update NotifyEvent enum Signed-off-by: Kostiantyn Kostiuk <konstantin@daynix.com>

view details

Kostiantyn Kostiuk

commit sha cab22f35078a5472c6a79d66083d9fe85a38f1ac

NetKVM: Use 'enum class' instead of 'enum' (CA warning 26812) Update FlowState enum Signed-off-by: Kostiantyn Kostiuk <konstantin@daynix.com>

view details

Kostiantyn Kostiuk

commit sha bf50cc9a3a2a4d33c753aa303607fa1e5afdc72e

NetKVM: Use 'enum class' instead of 'enum' (CA warning 26812) Update MiniportState enum Signed-off-by: Kostiantyn Kostiuk <konstantin@daynix.com>

view details

Kostiantyn Kostiuk

commit sha e169859ae5c9011ee4d48d7860f3f3d0922a4b97

NetKVM: Use 'enum class' instead of 'enum' (CA warning 26812) Update _tagPARANDIS_RSS_MODE enum. Signed-off-by: Kostiantyn Kostiuk <konstantin@daynix.com>

view details

Kostiantyn Kostiuk

commit sha d5ba0cb3090e1ed913cd859a395a600d7b946dc8

NetKVM: Move ParaNdis-SM.h to header files group Signed-off-by: Kostiantyn Kostiuk <konstantin@daynix.com>

view details

Kostiantyn Kostiuk

commit sha e5eaaf9f650494ca3999ef3157bc288202c627a3

NetKVM: Use 'enum class' instead of 'enum' (CA warning 26812) Updatee SMNotifications enum Signed-off-by: Kostiantyn Kostiuk <konstantin@daynix.com>

view details

Kostiantyn Kostiuk

commit sha 4378dddc00ef6b7b94a4e066cf70ab968fa7f8e8

NetKVM: Fix SMNotifications enum value spelling Signed-off-by: Kostiantyn Kostiuk <konstantin@daynix.com>

view details

Kostiantyn Kostiuk

commit sha 483395fcbee8572e597debb8d6d212df9b39bcc6

NetKVM: Use 'enum class' instead of 'enum' (CA warning 26812) Update _tagSubmitTxPacketResult enum. Signed-off-by: Kostiantyn Kostiuk <konstantin@daynix.com>

view details

Kostiantyn Kostiuk

commit sha 9b4b3998c8a5a0054f86669f82a4f1ae2cee13eb

NetKVM: Use 'enum class' instead of 'enum' (CA warning 26812) Update _tagppResult enum. Signed-off-by: Kostiantyn Kostiuk <konstantin@daynix.com>

view details

Kostiantyn Kostiuk

commit sha 45e37d579abf5a7c08221788ae3568bbae658350

NetKVM: Use 'enum class' instead of 'enum' (CA warning 26812) Update _tagPacketOffloadRequest enum. Signed-off-by: Kostiantyn Kostiuk <konstantin@daynix.com>

view details

Ilya Rudakov

commit sha 60db79b36a0a02bd2c7423efe7600778682a807b

viosock: missing vio_wsk.h Signed-off-by: Ilya Rudakov <irudakov@virtuozzo.com>

view details

push time in 3 months

push eventyach-yf/kvm-guest-drivers-windows

yach-yf

commit sha 1907cb975604b91f4ac68f4ffbf5a7ad51761799

NetKVM: Fix dropping IPv6 IPsec packets. Explicitly treat IPv6 ESP packet as usual packet (TCP, UDP, etc.). ESP header should not be treated like other extension headers. Because it does not start with 'Next Header' and 'Hdr Ext Len' fields and next header is encrypted.

view details

push time in 3 months

push eventyach-yf/kvm-guest-drivers-windows

yach-yf

commit sha 335c02008996e35d4fa6cb85736a1c0a2877a6f6

NetKVM: Explicitly treat IPv6 ESP packet as usual packet (TCP, UDP, etc.)

view details

push time in 3 months

pull request commentvirtio-win/kvm-guest-drivers-windows

NetKVM: Fix dropping IPv6 IPsec packets.

I think it would be better to make it clearly in the code and not just remove any mention of it.

Yes, you're right. 'Fragment Header' is so. I re-wrote the code. It has no effect on behavior.

yach-yf

comment created time in 3 months

push eventyach-yf/kvm-guest-drivers-windows

yach-yf

commit sha 5f1801f31e700dc6738e2d390076d6540ca20271

NetKVM: Explicitly treat IPv6 ESP packet as usual packet (TCP, UDP, etc.)

view details

push time in 3 months

pull request commentvirtio-win/kvm-guest-drivers-windows

NetKVM: Fix dropping IPv6 IPsec packets.

ESP header start with 'Security Parameters Index (SPI)' field, see the section 2 of RFC4303. https://datatracker.ietf.org/doc/html/rfc4303#section-2

Sorry, my explanation was insufficient. 'Hdr Ext Len' field next to 'Next Header' field is the cause of ESP packet being determined to be malformed. It is not on ESP header too.

For reference, I attached a Wireshark screen capture of an ESP packet. IPv6_ESP_Wireshark

yach-yf

comment created time in 3 months

PR opened virtio-win/kvm-guest-drivers-windows

NetKVM: Fix dropping IPv6 IPsec packets.

IPv6 ESP header is treated as usual header(TCP, UDP etc.) by this change.

ESP header should not be treated like other extension headers. Because it does not start with 'Next Header' field and next header is encrypted. So base version of NetKVM drops IPv6 ESP(IPsec) packet as malformed packet.

+0 -3

0 comment

1 changed file

pr created time in 3 months

create barnchyach-yf/kvm-guest-drivers-windows

branch : netkvm-ipv6-ipsec-fix

created branch time in 3 months

more