profile
viewpoint
Dimitri John Ledkov xnox Canonical Ltd, Ubuntu Project, Debian Project London, UK https://blog.surgut.co.uk

microsoft/WSL-DistroLauncher 1136

Sample/reference launcher app for WSL distro Microsoft Store packages.

snapcore/models 3

Reference Models

xnox/clusterit 3

clusterit

CanonicalLtd/dns-violations 0

List of DNS violations by implementations, software and/or systems

CanonicalLtd/fb-util-for-appx 0

Create .appx files.

xnox/abi-compliance-checker 0

A tool for checking backward compatibility of a C/C++ library

pull request commentCanonicalLtd/netplan

Fix rename of matched interfaces at runtime (LP: #1904662)

Codecov Report

Merging #174 (47dffad) into master (6eafac5) will decrease coverage by 0.28%. The diff coverage is 8.69%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #174      +/-   ##
==========================================
- Coverage   98.90%   98.62%   -0.29%     
==========================================
  Files          49       49              
  Lines        7316     7339      +23     
==========================================
+ Hits         7236     7238       +2     
- Misses         80      101      +21     
Impacted Files Coverage Δ
netplan/cli/commands/apply.py 100.00% <ø> (ø)
netplan/cli/utils.py 82.20% <8.69%> (-17.80%) :arrow_down:
src/dbus.c 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 6eafac5...47dffad. Read the comment docs.

slyon

comment created time in 2 hours

push eventCanonicalLtd/netplan

Lukas Märdian

commit sha c7b8d111ba52a0126492a5887996ad4181b4c786

WIP: refactor interface rename code udevadm test-builtin net_setup_link seems to be only running once (at boot time) and _not_ rename interfaces during 'netplan apply'

view details

Lukas Märdian

commit sha 47dffadae2a40225241ef43b3453e5523cd4933b

cli: keep udev link changes like WakeOnLan=

view details

push time in 2 hours

issue commentibm-s390-tools/s390-tools

genprotimg/boot fails to compile and doesn't abort build

Just checked. It looks like stage3a_init.S also needs a change.

vapier

comment created time in 7 hours

issue commentibm-s390-tools/s390-tools

genprotimg/boot fails to compile and doesn't abort build

@vapier Does something like the following work for you (replace llill with lgfi)

diff --git a/genprotimg/boot/head.S b/genprotimg/boot/head.S index 8fae46049b9c..a709c30487c4 100644 --- a/genprotimg/boot/head.S +++ b/genprotimg/boot/head.S @@ -24,6 +24,6 @@ _start: sam64

    /* Initialize stack */
  •   lgfi    %r15, STACK_ADDRESS + STACK_SIZE - STACK_FRAME_OVERHEAD
    
  •   llill   %r15, STACK_ADDRESS + STACK_SIZE - STACK_FRAME_OVERHEAD
      brasl   %r14, initialize
    

.previous

vapier

comment created time in 7 hours

delete branch CanonicalLtd/netplan

delete branch : slyon/docs-get-set-dbus

delete time in 7 hours

issue commentibm-s390-tools/s390-tools

RFE: add virtio-ccw support to zdev

@mihajlov FYA.

cohuck

comment created time in 8 hours

issue commentibm-s390-tools/s390-tools

genprotimg/boot fails to compile and doesn't abort build

FWIW, lgfi was added with the extended immediate facility (z990). The problem is probably that on gentoo there is no architecture level set to anything newer than z900 for gcc. The binutils will reject mnemonics that are newer than the architecture level. So The fix would be to compile this file with march=z990 or newer or - which is better - to change the code to not use lgfi.

vapier

comment created time in 8 hours

PR opened mementum/backtrader

Adding in Single Logic for singular math calculations.

Adding in Single Logic for singular math calculations

On behalf of: Neil Murphy Issue: https://github.com/backtrader2/backtrader/issues/35

+163 -0

0 comment

2 changed files

pr created time in 10 hours

push eventCanonicalLtd/netplan

Lukas Märdian

commit sha 40aef1be099a67f6cf15c1da27e62cb31bdc0008

Documentation for get/set CLI and DBus Config/Try/Cancel/Apply/Get/Set (#173) Add man pages for netplan get/set CLI and Config/Try/Cancel/Apply/Get/Set DBus methods. This PR also adds a dbus-config feature flag, to indicate the availability of the DBus configuration management.

view details

push time in 20 hours

PR merged CanonicalLtd/netplan

Documentation for get/set CLI and DBus Config/Try/Cancel/Apply/Get/Set

Description

Add man pages for netplan get/set CLI and Config/Try/Cancel/Apply/Get/Set DBus methods. This PR also adds a dbus-config feature flag, to indicate the availability of the DBus configuration management.

Checklist

  • [x] Runs make check successfully.
  • [x] Retains 100% code coverage (make check-coverage).
  • [x] New/changed keys in YAML format are documented.
  • [x] (Optional) Adds example YAML for new feature.
  • [ ] (Optional) Closes an open bug in Launchpad.
+170 -3

2 comments

8 changed files

slyon

pr closed time in 20 hours

PR opened CanonicalLtd/netplan

Fix rename of matched interfaces at runtime (LP: #1904662)

Description

WIP

Checklist

  • [ ] Runs make check successfully.
  • [ ] Retains 100% code coverage (make check-coverage).
  • [ ] New/changed keys in YAML format are documented.
  • [ ] (Optional) Adds example YAML for new feature.
  • [ ] (Optional) Closes an open bug in Launchpad.
+64 -7

0 comment

3 changed files

pr created time in a day

push eventCanonicalLtd/netplan

Lukas Märdian

commit sha 9a03b3e24faccacbead7cfeeccba05bc0c7f4b22

cli: fix linter

view details

push time in a day

create barnchCanonicalLtd/netplan

branch : slyon/lp1904662

created branch time in a day

pull request commentsnapcore/pi-gadget

gadget: add placeholder partion for boot select

yep, tryboot it is. +1 to close this

kubiko

comment created time in a day

pull request commentCanonicalLtd/netplan

Documentation for get/set CLI and DBus Config/Try/Cancel/Apply/Get/Set

Thank you! I've updated the netplan-dbus.8 manpage accordingly and also added a brief DBus config management scenario in examples/dbus_config_scenario.txt, by showing the control flow via busctl commands.

slyon

comment created time in a day

Pull request review commentCanonicalLtd/netplan

Documentation for get/set CLI and DBus Config/Try/Cancel/Apply/Get/Set

+---+title: netplan-dbus+section: 8+author:+- Lukas Märdian (<lukas.maerdian@canonical.com>)+...++# NAME++netplan-dbus - daemon to access netplan's functionality via a DBus API++# SYNOPSIS++  **netplan-dbus**++# DESCRIPTION++**netplan-dbus** is a DBus daemon, providing ``io.netplan.Netplan`` on the system bus. The ``/io/netplan/Netplan`` object provides an ``io.netplan.Netplan`` interface, offering the following methods:++ * ``Apply() -> b``: calls **netplan apply** and returns a success or failure status.+ * ``Info() -> a(sv)``: returns a dict "Features -> as", containing an array of all available feature flags.+ * ``Config() -> o``: prepares a new config object as ``/io/netplan/Netplan/config/<ID>``, by copying the current state from ``/{etc,run,lib}/netplan/*.yaml``++The ``/io/netplan/Netplan/config/<ID>`` objects provide a ``io.netplan.Netplan.Config`` interface, offering the following methods:++ * ``Get() -> s``: calls **netplan get --root-dir=/tmp/netplan-config-ID all** and returns the merged YAML config of the the given config object's state+ * ``Set(s:CONFIG_DELTA, s:ORIGIN_HINT) -> b``: calls **netplan set --root-dir=/tmp/netplan-config-ID --origin-hint=<ORIGIN_HINT> CONFIG_DELTA**, where CONFIG_DELTA can be something like: ``network.ethernets.eth0.dhcp4=true`` and ORIGIN_HINT can be something like: ``70-snapd`` (it will then write the config to ``70-snapd.yaml``)

I've extended the description of Set() a bit, to explain the conflict management.

slyon

comment created time in a day

push eventCanonicalLtd/netplan

Lukas Märdian

commit sha 6fdb51b0368cac38e7bc567ec8a7e4b351339e48

doc:dbus: describe confilct management and dirty states

view details

Lukas Märdian

commit sha 4692fd0f605f5cbdf3173df26980a23001e5d150

examples: add dbus_config_scenario.txt

view details

push time in a day

pull request commentmementum/backtrader

Fix multiprocessing memory usage issues by instantiating Pool with maxtasksperchild

If I recall correctly (this is some months ago) the memory leak actually emerged from PandasData; switching to GenericCSVData effectively resolved the issue.

schwartzman

comment created time in a day

pull request commentsnapcore/pi-gadget

gadget: add placeholder partion for boot select

We can't do this until we have GPT partition scheme, as we now up to the max number (4) of primary partitions with MBR partition scheme.

Additionally, the pi bootloader has gained some (which seems to be "enough") support for trying assets recently which does not require another partition, so I think we are okay to close this PR until we have more information from the pi foundation.

kubiko

comment created time in 2 days

Pull request review commentCanonicalLtd/netplan

Documentation for get/set CLI and DBus Config/Try/Cancel/Apply/Get/Set

+---+title: netplan-dbus+section: 8+author:+- Lukas Märdian (<lukas.maerdian@canonical.com>)+...++# NAME++netplan-dbus - daemon to access netplan's functionality via a DBus API++# SYNOPSIS++  **netplan-dbus**++# DESCRIPTION++**netplan-dbus** is a DBus daemon, providing ``io.netplan.Netplan`` on the system bus. The ``/io/netplan/Netplan`` object provides an ``io.netplan.Netplan`` interface, offering the following methods:++ * ``Apply() -> b``: calls **netplan apply** and returns a success or failure status.+ * ``Info() -> a(sv)``: returns a dict "Features -> as", containing an array of all available feature flags.+ * ``Config() -> o``: prepares a new config object as ``/io/netplan/Netplan/config/<ID>``, by copying the current state from ``/{etc,run,lib}/netplan/*.yaml``++The ``/io/netplan/Netplan/config/<ID>`` objects provide a ``io.netplan.Netplan.Config`` interface, offering the following methods:++ * ``Get() -> s``: calls **netplan get --root-dir=/tmp/netplan-config-ID all** and returns the merged YAML config of the the given config object's state+ * ``Set(s:CONFIG_DELTA, s:ORIGIN_HINT) -> b``: calls **netplan set --root-dir=/tmp/netplan-config-ID --origin-hint=<ORIGIN_HINT> CONFIG_DELTA**, where CONFIG_DELTA can be something like: ``network.ethernets.eth0.dhcp4=true`` and ORIGIN_HINT can be something like: ``70-snapd`` (it will then write the config to ``70-snapd.yaml``)

I think we need to include information about the conflict management here, probably in the Set() description.

slyon

comment created time in 2 days

Pull request review commentCanonicalLtd/netplan

Documentation for get/set CLI and DBus Config/Try/Cancel/Apply/Get/Set

 method_try(sd_bus_message *m, void *userdata, sd_bus_error *ret_error)  * io.netplan.Netplan.Config methods  */ +/* netplan-feature: dbus-config */

Good catch! Missed that last time - we indeed need a feature flag for this.

slyon

comment created time in 2 days

Pull request review commentCanonicalLtd/subiquity

fixes for FBA, unformatted, and passed-via virtio dasds

 def _can_PARTITION(self):             return False         if self.free_for_partitions <= 0:             return False-        if self.ptable == 'vtoc' and len(self._partitions) >= 3:+        # we only use msdos partition tables with FBA dasds, which+        # only support 3 partitions.+        if self.ptable in ['vtoc', 'msdos'] and len(self._partitions) >= 3:

Don't we know DASD type? if not, you could scope the 3 partition limit to arch=s390x to avoid tripping existing MSDOS layouts on non-s390x.

mwhudson

comment created time in 2 days

push eventCanonicalLtd/netplan

Lukas Märdian

commit sha d639de23ed996d88a0be8cfbcdb33d94a33e9c09

dbus: add 'dbus-config' feature flag

view details

push time in 2 days

CommitCommentEvent

pull request commentCanonicalLtd/netplan

doc: Add documentation for get/set CLI and Config/Try/Cancel/Apply/Get/Set DBus methods

Codecov Report

Merging #173 (4a5cb28) into master (6eafac5) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #173   +/-   ##
=======================================
  Coverage   98.90%   98.90%           
=======================================
  Files          49       49           
  Lines        7316     7316           
=======================================
  Hits         7236     7236           
  Misses         80       80           

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 6eafac5...c70dfc2. Read the comment docs.

slyon

comment created time in 2 days

push eventCanonicalLtd/netplan

Lukas Märdian

commit sha c70dfc2fd3c5edf38177a513a46805744028876b

doc: fix netplan-set typos

view details

push time in 2 days

PR opened CanonicalLtd/netplan

doc: Add documentation for get/set CLI and Config/Try/Cancel/Apply/Get/Set DBus methods

Description

Add man pages for netplan get/set CLI and Config/Try/Cancel/Apply/Get/Set DBus methods

Checklist

  • [x] Runs make check successfully.
  • [x] Retains 100% code coverage (make check-coverage).
  • [x] New/changed keys in YAML format are documented.
  • [x] (Optional) Adds example YAML for new feature.
  • [ ] (Optional) Closes an open bug in Launchpad.
+125 -3

0 comment

6 changed files

pr created time in 2 days

create barnchCanonicalLtd/netplan

branch : slyon/docs-get-set-dbus

created branch time in 2 days

pull request commentcanonical/probert

dasd probing enhancements

I'll add dasdview output for a FBA drive before merging, but the s390x systems are currently inaccessible due to the DC move

mwhudson

comment created time in 3 days

pull request commentCanonicalLtd/subiquity

fixes for FBA, unformatted, and passed-via virtio dasds

i should add dasdview output for a FBA drive but the s390x system is still inaccessible due to the data centre move.

mwhudson

comment created time in 3 days

more