profile
viewpoint

sindresorhus/globals 197

Global identifiers from different JavaScript environments

kentcdodds/webpack-validator-DEPRECATED 98

Use this to save yourself some time when working on a webpack configuration.

xjamundx/CollabPaintJS 41

A collaborative painting app built on top of NodeJS and Socket.IO

TheLarkInn/js-parser-discussions 31

Discussions & Collaboration on a Unified/Base set of parser features for JavaScript

kentcdodds/configuration-validator 10

A pluggable configuration validator (UNMAINTAINED)

kentcdodds/slice-js 9

This is archived because I don't have time to work on it or maintain it, but feel free to explore/fork/etc.

rvagg/archived-quantities 5

JavaScript library for physical quantity representation and conversion

xjamundx/asts-utahjs-2015 4

Notes and demo from my AST talk at UtahJS 2015

krakenjs/neff 3

nconf & express based feature flags

pull request commentxjamundx/eslint-plugin-promise

fix(no-return-wrap): fix it not reporting for arrow functions without braces

Awesome work. Will check this out tomorrow

On Wed, Jul 1, 2020 at 9:39 PM cherryblossom000 notifications@github.com wrote:

What is the purpose of this pull request?

  • Documentation update
  • Bug fix
  • New rule
  • Changes an existing rule
  • Add autofixing to a rule
  • Other, please explain:

What changes did you make? (Give an overview) Checks CallExpressions that are direct descendants of ArrowFunctionExpressions (meaning that the arrow function returns a CallExpression without braces) and reports if it is Promise.resolve or Promise.reject.

Fixes #193 https://github.com/xjamundx/eslint-plugin-promise/issues/193.

You can view, comment on, or merge this pull request online at:

https://github.com/xjamundx/eslint-plugin-promise/pull/194 Commit Summary

  • fix(no-return-wrap): fix it not reporting for arrow functions without braces (fixes #193)

File Changes

Patch Links:

  • https://github.com/xjamundx/eslint-plugin-promise/pull/194.patch
  • https://github.com/xjamundx/eslint-plugin-promise/pull/194.diff

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/xjamundx/eslint-plugin-promise/pull/194, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAB4C76MNGJI76K22WL6TLTRZQFPLANCNFSM4OOQDNJA .

cherryblossom000

comment created time in 15 minutes

pull request commentxjamundx/eslint-plugin-promise

Meta type

I'm basically fine with this change, but not really in love with the formatting change (specifically adding trailing commas). If you want to introduce another PR where you bring in prettier that would be fine, but otherwise I'd prefer if you could remove that change and then I'll be fine with merging.

brettz9

comment created time in a month

pull request commentxjamundx/eslint-plugin-promise

Meta type

Will try to look this weekend or on Monday. Appreciate it

On Fri, May 15, 2020 at 8:21 PM Brett Zamir notifications@github.com wrote:

Any chance y'all can take a look? Thanks...

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/xjamundx/eslint-plugin-promise/pull/185#issuecomment-629580730, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAB4C7YSDDNNZRBKMBZBE3LRRYBERANCNFSM4MF6MCUQ .

brettz9

comment created time in 2 months

push eventxjamundx/egghead-express

Jamund Ferguson

commit sha d9686aa6ad08933ba748f5df6a05d169a8efc229

updates

view details

Jamund Ferguson

commit sha dd2b61dc426347cb2590e037eafe66a580c99d48

data

view details

Jamund Ferguson

commit sha 556164397f4de722bc31e3f9f8e3f37963e962e4

store

view details

Jamund Ferguson

commit sha 14799a4ba51d5e8792918798c850fd0941f2cec2

map store

view details

push time in 2 months

push eventxjamundx/egghead-express

Jamund Ferguson

commit sha 0202f4dc0c9768dfe1e8be4a06dee2392495df74

first draft

view details

Jamund Ferguson

commit sha d53e35fad83f90ed606eae8767519b384416d71e

saving things

view details

Jamund Ferguson

commit sha 450c0b8f9a92872b3c7e0c5332f0ebbc5bb09367

front-end only

view details

Jamund Ferguson

commit sha 7539326dbc829a2e708aa7904069f7f3758e73d0

server setup

view details

Jamund Ferguson

commit sha 24ce29be03fa073149e8ce79d5a0aab2a1549cdc

fully working

view details

Jamund Ferguson

commit sha c32d03d566bed94871f87c1ed3fc3312eb9d1ebf

better

view details

Jamund Ferguson

commit sha 62ef866acb791bba8ab9c0384566e532699c970a

cooler

view details

Jamund Ferguson

commit sha aa4d519c19d9564ca582781960a2996a4de03741

step 1

view details

Jamund Ferguson

commit sha 7e966826d624edf81433148afa669d548da7d396

get note individually from server

view details

Jamund Ferguson

commit sha 1ea395f0f12416c6e71c4034a62d2c7f0bd27c60

looking swell

view details

Jamund Ferguson

commit sha 3c6b7c096c90c18aab29f1f7e075afa2bd66fdea

fix tailwind'

view details

Jamund Ferguson

commit sha a9018a2784f232e4f8ce3a964d3d08f2674a751b

things

view details

Jamund Ferguson

commit sha 5c5a61287fc05b38640f58a5c09b4e3fc0c1c1ce

things

view details

push time in 2 months

create barnchxjamundx/egghead-express

branch : master

created branch time in 2 months

created repositoryxjamundx/egghead-express

Resources for my Egghead collection on using express 5

created time in 2 months

push eventxjamundx/eslint-plugin-promise

markfields

commit sha 2ae6c85368209dd60dee195bd45f00ca4724f245

Simplify Invalid examples The Invalid examples were also violating the rule `always-return`, but now they don't.

view details

Jamund Ferguson

commit sha f9a9ee03942ca398c306605a946e154e6b45bbf4

Merge pull request #182 from markfields/patch-1 Simplify Invalid examples for the no-nesting rule

view details

push time in 2 months

pull request commentxjamundx/eslint-plugin-promise

Simplify Invalid examples for the no-nesting rule

smart thanks

markfields

comment created time in 2 months

PR merged xjamundx/eslint-plugin-promise

Simplify Invalid examples for the no-nesting rule

What is the purpose of this pull request?

  • [x] Documentation update
  • [ ] Bug fix
  • [ ] New rule
  • [ ] Changes an existing rule
  • [ ] Add autofixing to a rule
  • [ ] Other, please explain:

What changes did you make? (Give an overview) The Invalid examples were also violating the rule always-return, but now they don't.

+8 -8

1 comment

1 changed file

markfields

pr closed time in 2 months

issue commentwebcomponents/polyfills

IE11 Symbol Issue

A workaround that works in a webpack situation of the problem is to alias lodash.omitBy to another module that exports its own pickBy method. I think omitBy may also cause the same issue.

function pickBy(obj, pickFn) {
    return Object.fromEntries(
        Object.entries(obj).filter(([, value]) => {
            return pickFn(value);
        })
    );
}

export default pickBy;
export { pickBy };
xjamundx

comment created time in 2 months

issue openedwebcomponents/polyfills

IE11 Symbol Issue

In Internet Explorer 11 I get this error message when using the web components polyfill and lodash omitBy.

Unable to get property '@@__symbol:iterator0.93819982581614551' of undefined or null reference

This is not a duplicate of #43, though there are some similarities.

This has occurred with other polyfills as well:

  • https://github.com/Financial-Times/polyfill-service/issues/1058
  • https://github.com/zloirock/core-js/commit/78770786a4e5f2f87ea32b4dada46b9ce0a92887

Lodash similarly has blocked the issue on their end, I believe thinking that polyfills need to resolve the issue: https://github.com/lodash/lodash/issues/2308

Some interesting things about reproduction:


This one will fail with the above error:

<script src="https://unpkg.com/@webcomponents/webcomponentsjs/webcomponents-loader.js"></script>
<script src="https://cdnjs.cloudflare.com/ajax/libs/lodash.js/4.17.15/lodash.min.js"></script>
<script>
var obj = {a: 1, b: 2}
var smaller = _.omitBy(obj, function (val) { return val > 1 })
console.log(smaller)
</script>

This one works fine:

<script src="https://cdnjs.cloudflare.com/ajax/libs/webcomponentsjs/2.4.3/custom-elements-es5-adapter.js"></script>
<script src="https://cdnjs.cloudflare.com/ajax/libs/lodash.js/4.17.15/lodash.min.js"></script>
<script>
var obj = {a: 1, b: 2}
var smaller = _.omitBy(obj, function (val) { return val > 1 })
console.log(smaller)
</script>

Does that just mean I'm using the wrong polyfill? My real use case is a complex webpack bundle thing with core-js and other, we first ran into #43 now this :)


Screen Shot 2020-05-05 at 11 13 05 AM


You can see it for yourself here: https://jsfiddle.net/s8yzcjne/3/embedded/result,css,html,js

created time in 2 months

more