profile
viewpoint

brynary/rack-bug 1090

Debugging toolbar for Rack applications implemented as middleware

dchelimsky/rspec-rails 768

RSpec extension library for Ruby on Rails

alexcrichton/toml-rs 602

A TOML encoding/decoding library for Rust

ember-engines/ember-engines 476

Composable Ember applications for ambitious user experiences

dherman/defense-of-dot-js 439

In Defense of .js: A Proposal for Node.js Modules

BackburnerJS/backburner.js 381

A rewrite of the Ember.js run loop as a generic microlibrary

ezmobius/chef-deploy 297

Chef Resources and Providers for deploying ruby web apps without capistrano

carllerche/astaire-old 161

The basic Sinatra DSL inside of ActionController

create barnchemberjs/ember-inspector

branch : update-changelog

created branch time in 5 days

push eventemberjs/ember-inspector

Godfrey Chan

commit sha bfb90b31c10a9d9d8857cd340da8913195cb4416

CHANGELOG for v3.13.2

view details

Godfrey Chan

commit sha 3a018c7a7283abb4419bccfcb9a3f645349a7add

v3.13.2

view details

push time in 5 days

created tagemberjs/ember-inspector

tagv3.13.2

Adds an Ember tab to the browser's Developer Tools that allows you to inspect Ember objects in your application.

created time in 5 days

push eventemberjs/ember-inspector

dependabot[bot]

commit sha 00e2e3c505de1f97ff7455393faf0bf9c6335e64

Bump handlebars from 4.2.1 to 4.5.3 (#1122) Bumps [handlebars](https://github.com/wycats/handlebars.js) from 4.2.1 to 4.5.3. - [Release notes](https://github.com/wycats/handlebars.js/releases) - [Changelog](https://github.com/wycats/handlebars.js/blob/master/release-notes.md) - [Commits](https://github.com/wycats/handlebars.js/compare/v4.2.1...v4.5.3) Signed-off-by: dependabot[bot] <support@github.com> (cherry picked from commit 14c2d19cfc7e0993f53c33d01ed62391132dc4b1)

view details

Godfrey Chan

commit sha 807704ffc87857726d157a029e8b45ae54ca5e08

Fix canary test failure (#1130) (cherry picked from commit 0a592cb9f3d8184cc5b8137c67c7008e51ef325d)

view details

Matthew Beale

commit sha bb9912cfc7229ce2227601f83e248cbd14071953

Bump Ember Table to 2.2.2 (#1131) * Bump Ember Table to 2.2.2 * await ember-table rendering before asserting DOM Co-authored-by: Robert Wagner <rwwagner90@gmail.com> (cherry picked from commit 14584c7f78eb92b003f054791d08cba2e69ccbfe)

view details

Eli Flanagan

commit sha ea9d8ab705a1414d1c4f6eb8796079f47dddd827

only boot inspector on HTML pages (#1137) Fix #1136. I chose to whitelist the [HTML mime type](https://www.iana.org/assignments/media-types/media-types.xhtml#text) only since it is simpler. Per Godfrey's comment, we could declare [matching in the manifest](https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/Match_patterns) but it does so by URL or protocol. Because of that I think checking the mime type in the document is simpler and more readable. (cherry picked from commit 87f805914bda5067e85fa8eecec98df961eafee1)

view details

Chris Garrett

commit sha e696040a50484eca10c7c3effbbcb55e4622fcd3

[BUGFIX] Updates "import" paths for autotracking APIs (#1138) (cherry picked from commit 545e3c1c7a47f7a033025037f6f1e8d1d4c60624)

view details

Yehuda Katz

commit sha da9c574ca99be0a2e0e328622205cc218a1e0863

Fix fallback to old inspectors As @chancancode explained in #1120[1], the injected debug code previously did too much work in order to report a version miss. To help understand what went wrong, I'll give an abridged version of the boot-up protocol, and how the fallback logic fits in. 1. The Ember inspector application boots up inside of a devtools iframe, and injects the version of `ember_debug.js` for the latest version of the Ember inspector. 2. `ember_debug.js` to become aware of any supported version of Ember, and when that happens, it checks whether the version of Ember on the current page is supported by the current version of `ember_debug.js`. 3. If it matches, everything proceeds as usual, and `ember_debug.js` starts communicating with the inspector pane. 4. If it doesn't match, `ember_debug.js` sends a `version-mismatch` message to the inspector pane along with the current version of Ember used on the current page. The inspector pane then calculates which version of the inspector to use (currently either `0-0-0` for Ember 0.0 to Ember 2.6 or `2-7-0` for Ember 2.8 to Ember 3.2). When this happens, the inspector navigates itself to the older version of the inspector, allowing that version to bootstrap itself. Note that the inspector uses the Ember registry and loader to register its modules, so any modules for the latest version of ember_debug will *still be registered* when the older version of `ember_debug.js` is evaluated. This is not intrinsically a problem, since the calls to `define` in the new version of `ember_debug.js` will replace the old modules. Any modules that were present in the latest version but not the previous version will still be registered, but won't be used by the older code. The problem with all of that is that if any module is *required* in the process of reporting the version miss, the module's exports will remain cached in Ember's loader. Replacing the module with new source code has no effect, because the next time someone tries to require the module, it will just return the old cached exports, and the new `define` is completely ignored. This means that, depending on which code is required as part of reporting the version miss, a random Frankenstein combination of modules will be used at runtime. It should come as no surprise that this could have problems. The reason that it didn't cause any issues until recently is a coincidence: the assortment of modules in question happened to work well enough to avoid any problems that incited a user to report the bug. The solution to the problem in this commit is to completely avoid requiring any modules before the version is correctly matched. There were three modules previously required: 1. Two utility modules: `on-ready` and `version`. These modules were small so I inlined the code next to the version reporting logic. 2. The ember_debug adapter. This is a much thornier dependency, because it sucks in a whole bunch of additional dependencies and is the root cause of the current issue. I addressed this dependency by hand-coding just enough logic to create a `MessageChannel`, post it to the current window, and `postMessage` a `version-mismatch` message through the channel. This works as long as the adapter uses a `MessageChannel` to communicate the version mismatch. This is how `web-extension.js` works, which covers Chrome, Firefox, Edgium, and remote debugging using the remote debugging protocol. It does not cover other backends, but those backends are currently broken for other reasons. It doesn't substantially burden the work of making other backends work again, it simply constrains backends to use a `MessageChannel` (posted to the inspected app's window) to communicate version mismatches. It doesn't otherwise constrain any adapter functionality in `ember_debug` or the Ember Inspector. If this constraint isn't acceptable for a future backend, we could also support alternative ways of communicating the version mismatch, as long as that didn't require the version reporting code to load in the entire adapter module. [1]: https://github.com/emberjs/ember-inspector/issues/1120#issuecomment-569373059 (cherry picked from commit 9022a0224e5db94d5ae377b51ae8a17ee8664bab)

view details

patricklx

commit sha f4dc79c5fd3b008e33eebaa02c4d240553b9cdbd

fix recursion of getTagTrackedProps (#1144) (cherry picked from commit edcce98e8b913a19a8270f7ddd5193b0aff87a60)

view details

push time in 5 days

pull request commentglimmerjs/glimmer-vm

[BUGFIX] Fixes {{has-block}} when used with curry components as a variable

lgtm

Thanks so much for the detailed comment!

pzuraq

comment created time in 11 days

push eventemberjs/ember-inspector

Yehuda Katz

commit sha 9022a0224e5db94d5ae377b51ae8a17ee8664bab

Fix fallback to old inspectors As @chancancode explained in #1120[1], the injected debug code previously did too much work in order to report a version miss. To help understand what went wrong, I'll give an abridged version of the boot-up protocol, and how the fallback logic fits in. 1. The Ember inspector application boots up inside of a devtools iframe, and injects the version of `ember_debug.js` for the latest version of the Ember inspector. 2. `ember_debug.js` to become aware of any supported version of Ember, and when that happens, it checks whether the version of Ember on the current page is supported by the current version of `ember_debug.js`. 3. If it matches, everything proceeds as usual, and `ember_debug.js` starts communicating with the inspector pane. 4. If it doesn't match, `ember_debug.js` sends a `version-mismatch` message to the inspector pane along with the current version of Ember used on the current page. The inspector pane then calculates which version of the inspector to use (currently either `0-0-0` for Ember 0.0 to Ember 2.6 or `2-7-0` for Ember 2.8 to Ember 3.2). When this happens, the inspector navigates itself to the older version of the inspector, allowing that version to bootstrap itself. Note that the inspector uses the Ember registry and loader to register its modules, so any modules for the latest version of ember_debug will *still be registered* when the older version of `ember_debug.js` is evaluated. This is not intrinsically a problem, since the calls to `define` in the new version of `ember_debug.js` will replace the old modules. Any modules that were present in the latest version but not the previous version will still be registered, but won't be used by the older code. The problem with all of that is that if any module is *required* in the process of reporting the version miss, the module's exports will remain cached in Ember's loader. Replacing the module with new source code has no effect, because the next time someone tries to require the module, it will just return the old cached exports, and the new `define` is completely ignored. This means that, depending on which code is required as part of reporting the version miss, a random Frankenstein combination of modules will be used at runtime. It should come as no surprise that this could have problems. The reason that it didn't cause any issues until recently is a coincidence: the assortment of modules in question happened to work well enough to avoid any problems that incited a user to report the bug. The solution to the problem in this commit is to completely avoid requiring any modules before the version is correctly matched. There were three modules previously required: 1. Two utility modules: `on-ready` and `version`. These modules were small so I inlined the code next to the version reporting logic. 2. The ember_debug adapter. This is a much thornier dependency, because it sucks in a whole bunch of additional dependencies and is the root cause of the current issue. I addressed this dependency by hand-coding just enough logic to create a `MessageChannel`, post it to the current window, and `postMessage` a `version-mismatch` message through the channel. This works as long as the adapter uses a `MessageChannel` to communicate the version mismatch. This is how `web-extension.js` works, which covers Chrome, Firefox, Edgium, and remote debugging using the remote debugging protocol. It does not cover other backends, but those backends are currently broken for other reasons. It doesn't substantially burden the work of making other backends work again, it simply constrains backends to use a `MessageChannel` (posted to the inspected app's window) to communicate version mismatches. It doesn't otherwise constrain any adapter functionality in `ember_debug` or the Ember Inspector. If this constraint isn't acceptable for a future backend, we could also support alternative ways of communicating the version mismatch, as long as that didn't require the version reporting code to load in the entire adapter module. [1]: https://github.com/emberjs/ember-inspector/issues/1120#issuecomment-569373059

view details

Yehuda Katz

commit sha 2555c5ff6403763e6b1c92462364be12da316aa2

Merge pull request #1141 from emberjs/fix-fallback Fix fallback to old inspectors

view details

push time in 11 days

PR merged emberjs/ember-inspector

Fix fallback to old inspectors

Closes #1120

As @chancancode explained in #11201, the injected debug code previously did too much work in order to report a version miss.

To help understand what went wrong, I'll give an abridged version of the boot-up protocol, and how the fallback logic fits in.

  1. The Ember inspector application boots up inside of a devtools iframe, and injects the version of ember_debug.js for the latest version of the Ember inspector.
  2. ember_debug.js to become aware of any supported version of Ember, and when that happens, it checks whether the version of Ember on the current page is supported by the current version of ember_debug.js.
  3. If it matches, everything proceeds as usual, and ember_debug.js starts communicating with the inspector pane.
  4. If it doesn't match, ember_debug.js sends a version-mismatch message to the inspector pane along with the current version of Ember used on the current page. The inspector pane then calculates which version of the inspector to use (currently either 0-0-0 for Ember 0.0 to Ember 2.6 or 2-7-0 for Ember 2.8 to Ember 3.2). When this happens, the inspector navigates itself to the older version of the inspector, allowing that version to bootstrap itself.

Note that the inspector uses the Ember registry and loader to register its modules, so any modules for the latest version of ember_debug will still be registered when the older version of ember_debug.js is evaluated.

This is not intrinsically a problem, since the calls to define in the new version of ember_debug.js will replace the old modules. Any modules that were present in the latest version but not the previous version will still be registered, but won't be used by the older code.

The problem with all of that is that if any module is required in the process of reporting the version miss, the module's exports will remain cached in Ember's loader. Replacing the module with new source code has no effect, because the next time someone tries to require the module, it will just return the old cached exports, and the new define is completely ignored.

This means that, depending on which code is required as part of reporting the version miss, a random Frankenstein combination of modules will be used at runtime. It should come as no surprise that this could have problems. The reason that it didn't cause any issues until recently is a coincidence: the assortment of modules in question happened to work well enough to avoid any problems that incited a user to report the bug.

The solution to the problem in this commit is to completely avoid requiring any modules before the version is correctly matched. There were three modules previously required:

  1. Two utility modules: on-ready and version. These modules were small so I inlined the code next to the version reporting logic.
  2. The ember_debug adapter. This is a much thornier dependency, because it sucks in a whole bunch of additional dependencies and is the root cause of the current issue. I addressed this dependency by hand-coding just enough logic to create a MessageChannel, post it to the current window, and postMessage a version-mismatch message through the channel.

This works as long as the adapter uses a MessageChannel to communicate the version mismatch. This is how web-extension.js works, which covers Chrome, Firefox, Edgium, and remote debugging using the remote debugging protocol.

It does not cover other backends, but those backends are currently broken for other reasons. It doesn't substantially burden the work of making other backends work again, it simply constrains backends to use a MessageChannel (posted to the inspected app's window) to communicate version mismatches. It doesn't otherwise constrain any adapter functionality in ember_debug or the Ember Inspector. If this constraint isn't acceptable for a future backend, we could also support alternative ways of communicating the version mismatch, as long as that didn't require the version reporting code to load in the entire adapter module.

+103 -21

1 comment

4 changed files

wycats

pr closed time in 11 days

issue closedemberjs/ember-inspector

Error message: Ember.meta(...).peekDescriptors is not a function - Object are not shown for any ember component

Issue and Steps to Reproduce

  • Open Ember Inspecter and click on any controller name to view the object

Your environment

ember-cli: 2.18.2

Browser : Chrome - Version 79.0.3945.79

Screenshots

image

image

closed time in 11 days

ufthelp

Pull request review commentemberjs/ember-inspector

Fix fallback to old inspectors

 var EMBER_VERSIONS_SUPPORTED = {{EMBER_VERSIONS_SUPPORTED}};     return !toVersion || compareVersion(version, toVersion) === -1;   } +  function onReady(callback) {+    if (document.readyState === 'complete' || document.readyState === 'interactive') {+      setTimeout(completed);+    } else {+      document.addEventListener("DOMContentLoaded", completed, false);+      // For some reason DOMContentLoaded doesn't always work+      window.addEventListener("load", completed, false);+    }++    function completed() {+      document.removeEventListener("DOMContentLoaded", completed, false);+      window.removeEventListener("load", completed, false);+      callback();+    }+  }++  /**+   * Compares two Ember versions.+   *+   * Returns:+   * `-1` if version1 < version+   * 0 if version1 == version2+   * 1 if version1 > version2+   *+   * @param {String} version1+   * @param {String} version2+   * @return {Boolean} result of the comparison+   */+  function compareVersion(version1, version2) {

@rwwagner90 We can't import those functions because this code isn't allowed to import anything during the period where it's checking the version.

I explained it in more detail in the commit message, but the short version is that if we require anything here, some pieces of the current ember_debug.js will stick around even after we load the earlier version of ember_debug.js, creating a big frankenstein mess. That was the root cause of the original bug.

wycats

comment created time in 11 days

pull request commentemberjs/ember-inspector

Fix fallback to old inspectors

I tested this by creating a new Ember 3.3 app, copying the 2-7-0 contents into the dist directory. I then reproduced the problem with the requireModule lines in place. I then removed the requireModule lines and verified that the problem no longer manifested.

wycats

comment created time in 13 days

PR opened emberjs/ember-inspector

Fix fallback to old inspectors

Closes #1120

As @chancancode explained in #11201, the injected debug code previously did too much work in order to report a version miss.

To help understand what went wrong, I'll give an abridged version of the boot-up protocol, and how the fallback logic fits in.

  1. The Ember inspector application boots up inside of a devtools iframe, and injects the version of ember_debug.js for the latest version of the Ember inspector.
  2. ember_debug.js to become aware of any supported version of Ember, and when that happens, it checks whether the version of Ember on the current page is supported by the current version of ember_debug.js.
  3. If it matches, everything proceeds as usual, and ember_debug.js starts communicating with the inspector pane.
  4. If it doesn't match, ember_debug.js sends a version-mismatch message to the inspector pane along with the current version of Ember used on the current page. The inspector pane then calculates which version of the inspector to use (currently either 0-0-0 for Ember 0.0 to Ember 2.6 or 2-7-0 for Ember 2.8 to Ember 3.2). When this happens, the inspector navigates itself to the older version of the inspector, allowing that version to bootstrap itself.

Note that the inspector uses the Ember registry and loader to register its modules, so any modules for the latest version of ember_debug will still be registered when the older version of ember_debug.js is evaluated.

This is not intrinsically a problem, since the calls to define in the new version of ember_debug.js will replace the old modules. Any modules that were present in the latest version but not the previous version will still be registered, but won't be used by the older code.

The problem with all of that is that if any module is required in the process of reporting the version miss, the module's exports will remain cached in Ember's loader. Replacing the module with new source code has no effect, because the next time someone tries to require the module, it will just return the old cached exports, and the new define is completely ignored.

This means that, depending on which code is required as part of reporting the version miss, a random Frankenstein combination of modules will be used at runtime. It should come as no surprise that this could have problems. The reason that it didn't cause any issues until recently is a coincidence: the assortment of modules in question happened to work well enough to avoid any problems that incited a user to report the bug.

The solution to the problem in this commit is to completely avoid requiring any modules before the version is correctly matched. There were three modules previously required:

  1. Two utility modules: on-ready and version. These modules were small so I inlined the code next to the version reporting logic.
  2. The ember_debug adapter. This is a much thornier dependency, because it sucks in a whole bunch of additional dependencies and is the root cause of the current issue. I addressed this dependency by hand-coding just enough logic to create a MessageChannel, post it to the current window, and postMessage a version-mismatch message through the channel.

This works as long as the adapter uses a MessageChannel to communicate the version mismatch. This is how web-extension.js works, which covers Chrome, Firefox, Edgium, and remote debugging using the remote debugging protocol.

It does not cover other backends, but those backends are currently broken for other reasons. It doesn't substantially burden the work of making other backends work again, it simply constrains backends to use a MessageChannel (posted to the inspected app's window) to communicate version mismatches. It doesn't otherwise constrain any adapter functionality in ember_debug or the Ember Inspector. If this constraint isn't acceptable for a future backend, we could also support alternative ways of communicating the version mismatch, as long as that didn't require the version reporting code to load in the entire adapter module.

+103 -21

0 comment

4 changed files

pr created time in 13 days

create barnchemberjs/ember-inspector

branch : fix-fallback

created branch time in 13 days

push eventglimmerjs/glimmer-vm

Godfrey Chan

commit sha 58b53961df9cc0c10ae829c0be829c78092eb2da

Ensure trailing new line when saving package.json

view details

push time in 14 days

create barnchglimmerjs/glimmer-vm

branch : upgrade-async-disk-cache

created branch time in 14 days

push eventglimmerjs/glimmer-vm

Godfrey Chan

commit sha 66536579fb83260811be7701605ad70692417902

Avoid double-clearing `{{in-element}}` This usually happens when the app uses `{{in-element}}` to append to `Ember.Application.rootElement` during initial render, which causes Glimmer to (incorrectly) include the "remoted content" in the root render result. When the render result is torn down, the "remoted content" gets removed as well, and so by the time its destructor runs it will be trying to clear its content again, which causes the double-clearing error ("The node to be removed is not a child of this node." in "removeChild"). This is probably a better fix to how Glimmer views the boundaries it manages, but this should be sufficient to supress the error for now without too much undesirable side-effects. Fixes emberjs/ember.js#18696 Co-authored-by: Yehuda Katz <wycats@gmail.com>

view details

push time in 18 days

create barnchglimmerjs/glimmer-vm

branch : fix-in-element

created branch time in 18 days

issue commentnushell/nushell

Steps for adding aliases

I'm gonna start this off by making the block parser and the any expression parser handle braced blocks. I'm not entirely sure when that stopped working, but it shouldn't be too hard to fix.

jonathandturner

comment created time in 19 days

create barnchemberjs/ember.js

branch : fix-tracked-initializers

created branch time in a month

push eventglimmerjs/glimmer-vm

Godfrey Chan

commit sha 80361a222c1a4bfe83bd0a0ba293d42fffdd50ce

[BUGFIX] ensure untracked `@tracked` initializers Given... ```js class Thing { @tracked foo = `foo ${this.bar}`; @tracked bar = 'bar'; } ``` When this is rendered... ```hbs {{this.foo}} ``` The curly will invalidates when `this.bar` invalidates, if it happens to be the first thing that accesses `this.foo` on the object. This is incorrect: initializers only run once, and whatever code were run inside should never cause the tracked property to become invalidated.

view details

push time in a month

create barnchglimmerjs/glimmer-vm

branch : untracked-initializers

created branch time in a month

created tagglimmerjs/glimmer-vm

tagv0.47.3

created time in a month

push eventglimmerjs/glimmer-vm

Godfrey Chan

commit sha 3e117129996d0af5af490b191a0b5dcf4394de49

Add v0.47.3 to CHANGELOG.md.

view details

Godfrey Chan

commit sha 6b8a17143f532317428a5e14774241c200b3d125

Release v0.47.3

view details

push time in a month

create barnchglimmerjs/glimmer-vm

branch : fix-package-versions

created branch time in a month

push eventglimmerjs/glimmer-vm

Godfrey Chan

commit sha 92a7b8be997891296766e50ad637746b5230910b

Add v0.47.2 to CHANGELOG.md.

view details

Godfrey Chan

commit sha f979dd6fd7e0bd79cd1220e7bd8f7cc83668cc7b

v0.47.2

view details

push time in a month

created tagglimmerjs/glimmer-vm

tagv0.47.2

created time in a month

create barnchglimmerjs/glimmer-vm

branch : fix-tracked-initializers

created branch time in a month

push eventnushell/nushell

Alex

commit sha 4af9e1de4158e4a4f3056d0dfcddff4343405fed

Resolves #750 (#1164) Pick now produces an error when none of the columns are found

view details

Shaurya Shubham

commit sha b574dc6365795da63fb241b77f06847986c49306

Add the from-ods command (#1161) * Put a sample_data.ods file for testing This is a copy of the sample_data.xlsx file but in ods format * Add the from-ods command Most of the work was doing `rg xlsx` and then copy/paste with light editing * Add tests for the from-ods command * Fix failing test The problem was improper filename sorting in the test `prepares_and_decorates_filesystem_source_files`

view details

Jonathan Turner

commit sha 41ebc6b42ddc45aebd10f0dd88a4ed1c5d3162cd

Bump to 0.8.0 (#1166)

view details

Jason Gedge

commit sha 7451414b9e4099dd2a6d372d7fd541677bed71b1

Eliminate ClassifiedInputStream in favour of InputStream. (#1056)

view details

Andrés N. Robalino

commit sha 00c03270310f32eb5216fafadaa37e91e76c0788

Support more Values to plain string. (#1169) * Support more Values to plain string. * Continue converting to delimited data for simple values.

view details

Alex

commit sha c3e466e464b7186288908f05604336a2ce335c32

Make debug command always prettty-print (Resolves #1178) (#1180)

view details

Jonathan Turner

commit sha 515a3b33f82809388dc858b090ad7c8f5b08c5b7

Thin-lines for tables for better rendering (#1181) The thick lines are pretty subtle and some fonts have issues with it. Seems keeping the lines consistent works better across fonts.

view details

Jonathan Turner

commit sha 5692a08e7fbcdd6a28b642008ae0f88a0cf2225c

Update README.md

view details

Jason Gedge

commit sha 347f91ab5334af95a046eaa25a2379f2f6004923

Have internal/external/pipelines taken an optional InputStream. (#1182) Primarily, this fixes an issue where we always open a stdin pipe for external commands, which can break various interactive commands (e.g., editors).

view details

Andrés N. Robalino

commit sha 6d3a30772da05c6840f126c21ba1c79792562205

Get error message improvements. (#1185) More especific "get" command error messages + Test refactoring.

view details

Yehuda Katz

commit sha ded7df627862264d9c9c72af3e102376bd704832

Tests pass

view details

Andrés N. Robalino

commit sha 60043df9172b44bb96dc6d312d2c683d146158de

Allow ColumnPaths when picking tables. (#1191)

view details

Jonathan Turner

commit sha 147bfefd7e575c6450f8380dc8d301b0aef2fd2a

Sort ls case-insensitively by default (#1192)

view details

Jonathan Turner

commit sha 63885c4ee6b0797907fb6b7fd3fe10cc608bf9ad

Change black to other colors (#1194)

view details

Jonathan Turner

commit sha 02d0a4107e8595b3bf57aa4183676b8d244b49b1

A few ls improvements. New welcome message (#1195)

view details

Andrés N. Robalino

commit sha 0dcd90cb8fab98b0f530d703f770cb2d37f23ff6

Silence stdout for test runs. (#1198)

view details

Jonathan Turner

commit sha 5fd3191d9167307bfda943d14e217d738ebd6da6

Fix randomly failing test (#1200) * Fix randomly failing test * Fix randomly failing test

view details

Andrés N. Robalino

commit sha d3dae057148b20319cf5a09890dfd7d78f563348

Groundwork for coverage with Nu internals. (#1205)

view details

Corvus Corax

commit sha 2f039b3abc3dcd5f0754cc875f3ab0c193de31d9

Fix crash when attempting to enter help shell (#1201) `enter help` would result in a crash

view details

Andrés N. Robalino

commit sha 29fd8b55fb12833e52060a915d443881140d1c75

Keep dummies in default features for convenience. (#1212)

view details

push time in a month

issue commentrust-analyzer/rust-analyzer

Thread priorities on Windows

Sometime soon after this PR, rust-analyzer became useless to me. I think 196b374eb might have been a mistake :wink:

matklad

comment created time in a month

create barnchemberjs/ember-inspector

branch : inspector-rework

created branch time in a month

push eventwycats/core-data

Yehuda Katz

commit sha 147dd078b0411d24f79b6502f90c761890ac8e03

More progress

view details

push time in 2 months

create barnchwycats/core-data

branch : master

created branch time in 2 months

created repositorywycats/core-data

Very experimental data layer

created time in 2 months

push eventnushell/nushell

Yehuda Katz

commit sha d9283f0df3c6c4d47cb7c00d3260a3c504906011

Remove test that doesn't make sense on Windows

view details

push time in 2 months

push eventnushell/nushell

Yehuda Katz

commit sha ff21c69ac4efca9d3b32f9a9920c7e33b1218a0c

Restructure and streamline token expansion The purpose of this commit is to streamline the token expansion code, by removing aspects of the code that are no longer relevant, removing pointless duplication, and eliminating the need to pass the same arguments to `expand_syntax`. The first big-picture change in this commit is that instead of a handful of `expand_` functions, which take a TokensIterator and ExpandContext, a smaller number of methods on the `TokensIterator` do the same job. The second big-picture change in this commit is fully eliminating the coloring traits, making coloring a responsibility of the base expansion implementations. This also means that the coloring tracer is merged into the expansion tracer, so you can follow a single expansion and see how the expansion process produced colored tokens. One side effect of this change is that the expander itself is marginally more error-correcting. The error correction works by switching from structured expansion to `BackoffColoringMode` when an unexpected token is found, which guarantees that all spans of the source are colored, but may not be the most optimal error recovery strategy. That said, because `BackoffColoringMode` only extends as far as a closing delimiter (`)`, `]`, `}`) or pipe (`|`), it does result in fairly granular correction strategy. The current code still produces an `Err` (plus a complete list of colored shapes) from the parsing process if any errors are encountered, but this could easily be addressed now that the underlying expansion is error-correcting. This commit also colors any spans that are syntax errors in red, and causes the parser to include some additional information about what tokens were expected at any given point where an error was encountered, so that completions and hinting could be more robust in the future.

view details

push time in 2 months

push eventnushell/nushell

Yehuda Katz

commit sha 3371438cc582ccf2286385378a4ec09bd2d74067

Restructure and streamline token expansion The purpose of this commit is to streamline the token expansion code, by removing aspects of the code that are no longer relevant, removing pointless duplication, and eliminating the need to pass the same arguments to `expand_syntax`. The first big-picture change in this commit is that instead of a handful of `expand_` functions, which take a TokensIterator and ExpandContext, a smaller number of methods on the `TokensIterator` do the same job. The second big-picture change in this commit is fully eliminating the coloring traits, making coloring a responsibility of the base expansion implementations. This also means that the coloring tracer is merged into the expansion tracer, so you can follow a single expansion and see how the expansion process produced colored tokens. One side effect of this change is that the expander itself is marginally more error-correcting. The error correction works by switching from structured expansion to `BackoffColoringMode` when an unexpected token is found, which guarantees that all spans of the source are colored, but may not be the most optimal error recovery strategy. That said, because `BackoffColoringMode` only extends as far as a closing delimiter (`)`, `]`, `}`) or pipe (`|`), it does result in fairly granular correction strategy. The current code still produces an `Err` (plus a complete list of colored shapes) from the parsing process if any errors are encountered, but this could easily be addressed now that the underlying expansion is error-correcting. This commit also colors any spans that are syntax errors in red, and causes the parser to include some additional information about what tokens were expected at any given point where an error was encountered, so that completions and hinting could be more robust in the future.

view details

push time in 2 months

PR opened nushell/nushell

Restructure and streamline token expansion

The purpose of this commit is to streamline the token expansion code, by removing aspects of the code that are no longer relevant, removing pointless duplication, and eliminating the need to pass the same arguments to expand_syntax.

The first big-picture change in this commit is that instead of a handful of expand_ functions, which take a TokensIterator and ExpandContext, a smaller number of methods on the TokensIterator do the same job.

The second big-picture change in this commit is fully eliminating the coloring traits, making coloring a responsibility of the base expansion implementations. This also means that the coloring tracer is merged into the expansion tracer, so you can follow a single expansion and see how the expansion process produced colored tokens.

One side effect of this change is that the expander itself is marginally more error-correcting. The error correction works by switching from structured expansion to BackoffColoringMode when an unexpected token is found, which guarantees that all spans of the source are colored, but may not be the most optimal error recovery strategy.

That said, because BackoffColoringMode only extends as far as a closing delimiter (), ], }) or pipe (|), it does result in fairly granular correction strategy.

The current code still produces an Err (plus a complete list of colored shapes) from the parsing process if any errors are encountered, but this could easily be addressed now that the underlying expansion is error-correcting.

This commit also colors any spans that are syntax errors in red, and causes the parser to include some additional information about what tokens were expected at any given point where an error was encountered, so that completions and hinting could be more robust in the future.

+4377 -5960

0 comment

74 changed files

pr created time in 2 months

push eventnushell/nushell

Yehuda Katz

commit sha 98c59f77b2bc2a7349b08c6ed1bcc31fa2e41421

Merge pull request #1078 from nushell/enable_coloring_in_tokens Remove the coloring_in_tokens feature flag

view details

Matteo Bertini

commit sha 219b7e64cdaabad9e95067b0e5abcbd4e396b9c1

Use shellexpand to expand ~ in external commands Add tests for ~tilde expansion: - test that "~" is expanded (no more "~" in output) - ensure that "1~1" is not expanded to "1/home/user1" as it was before Fixes #972 Note: the first test does not check the literal expansion because the path on Windows is expanded as a Linux path, but the correct expansion may come for free once `shellexpand` will use the `dirs` crate too (https://github.com/netvl/shellexpand/issues/3).

view details

Jonathan Turner

commit sha 550bda477b0460cb9d9020f5612609c712357079

Merge pull request #1060 from naufraghi/issues-972-expand-tilde-as-home-in-external-commands Expand tilde as home in external commands

view details

Jonathan Turner

commit sha 31c703891a379683c749f1bf0d8065b6740ad647

Bump heim and necessary deps

view details

Jonathan Turner

commit sha 4b9ef5a9d04118fe46c520907d61d45d841a3cab

Merge pull request #1079 from jonathandturner/bump_some_deps Bump heim and necessary deps

view details

Andrés N. Robalino

commit sha 87cc6d6f0194092bfa7b3960a23bd46a9ccedfed

Separate internal and external command definitions.

view details

Sebastian Jung

commit sha cbbb246a6dc0fe0f43adc48dd22e312439d4774f

update links to books

view details

Andrés N. Robalino

commit sha 52cf65c19e14b1cfc6580adc2e12e7bf5d7a54e3

Merge pull request #1080 from andrasio/command-refactor Separate internal and external command definitions.

view details

Andrés N. Robalino

commit sha 4034129dba433a56c58e9fab01dd8496cb0aec91

This commit is the continuing phase of extracting functionality to subcrates. We extract test helpers and begin to change Nu shell's test organization along with it.

view details

Andrés N. Robalino

commit sha 6c577e18ca0851b8b3845cce5b3a267a54c07e83

Merge pull request #1081 from andrasio/test-extract Start test organization facelift.

view details

Jonathan Turner

commit sha fa9329c8e3032d71912ac51e35634a548d13537f

Merge pull request #1082 from sebastian-xyz/update-book-links update links to books

view details

Andrés N. Robalino

commit sha 5e961815fcd2130a964796e350f3e97dba216603

can contain a string line or plain string data.

view details

Andrés N. Robalino

commit sha 594eae1cbcc2674bc99c9385b297c7d37d36e57f

Merge pull request #1085 from andrasio/externals-line $it can contain a string line or plain string data.

view details

Jonathan Turner

commit sha 6540509911f9d9e8726921c77c1669f3e77c2f53

Bump Nu version

view details

Jonathan Turner

commit sha 98233dcec13dc782518e494cfbfc6f8c4ed7c1f5

Subcrate versions

view details

Jonathan Turner

commit sha 14817ef2298e5412a616bcc0689d4c10c81965bb

Subcrate versions

view details

Jonathan Turner

commit sha f7f1fba94f6657e25ba8618726b331f4f144ecc1

Merge pull request #1089 from jonathandturner/bump Bump Nu version

view details

Jonathan Turner

commit sha 314c3c4a97f5b89180606612c9fc1f0eb9af0b27

Add missing descriptions and licenses to subcrates

view details

Jonathan Turner

commit sha 761fc9ae7313a519a74b160c09099910915f8c51

Merge pull request #1090 from jonathandturner/add_descs Add missing descriptions and licenses to subcrates

view details

Jonathan Turner

commit sha 2c6336c806373cda2961383fe37dc6fa8d3e9600

Oops

view details

push time in 2 months

push eventnushell/nushell

Yehuda Katz

commit sha e924704f3616def375906d05904b00aff33b684d

Restructure and streamline token expansion The purpose of this commit is to streamline the token expansion code, by removing aspects of the code that are no longer relevant, removing pointless duplication, and eliminating the need to pass the same arguments to `expand_syntax`. The first big-picture change in this commit is that instead of a handful of `expand_` functions, which take a TokensIterator and ExpandContext, a smaller number of methods on the `TokensIterator` do the same job. The second big-picture change in this commit is fully eliminating the coloring traits, making coloring a responsibility of the base expansion implementations. This also means that the coloring tracer is merged into the expansion tracer, so you can follow a single expansion and see how the expansion process produced colored tokens. One side effect of this change is that the expander itself is marginally more error-correcting. The error correction works by switching from structured expansion to `BackoffColoringMode` when an unexpected token is found, which guarantees that all spans of the source are colored, but may not be the most optimal error recovery strategy. That said, because `BackoffColoringMode` only extends as far as a closing delimiter (`)`, `]`, `}`) or pipe (`|`), it does result in fairly granular correction strategy. The current code still produces an `Err` (plus a complete list of colored shapes) from the parsing process if any errors are encountered, but this could easily be addressed now that the underlying expansion is error-correcting. This commit also colors any spans that are syntax errors in red, and causes the parser to include some additional information about what tokens were expected at any given point where an error was encountered, so that completions and hinting could be more robust in the future.

view details

push time in 2 months

push eventnushell/nushell

Yehuda Katz

commit sha ce0b15f0fa71e8b318ad36f50e60efe7ea217d8e

WIP

view details

push time in 2 months

startedemberjs/rfcs

started time in 2 months

pull request commentember-learn/ember-blog

Add a short blurb summarizing what Octane is.

Yeah, I spoke with @NullVoxPopuli and I think this change is a little bit too reactionary and makes this post describe Octane as more of a delta from a previous thing at a high level.

NullVoxPopuli

comment created time in 2 months

push eventnushell/nushell

Yehuda Katz

commit sha f8b92a6b5fc207d946e4b257e55d886f5b1eabf7

More restructure

view details

push time in 2 months

push eventnushell/nushell

Yehuda Katz

commit sha cd608fc444d0a4b96dd6c116ded8fbf51f497927

Finish another checkpoint

view details

push time in 2 months

push eventemberjs/ember-inspector

Godfrey Chan

commit sha c0d920b5166c2b98d4a61954962884414db46f8d

Almost fixed view debug tests

view details

push time in 2 months

push eventemberjs/ember-inspector

Godfrey Chan

commit sha beb0d1988e804612e9b12b33e9005df2df872056

Add a polyfill for the `captureRenderTree` API

view details

Godfrey Chan

commit sha b58a3d0b5e6f141feb33b6940918a49c83728a93

GlimmerTree -> RenderTree

view details

Godfrey Chan

commit sha 06ac39cef4c9330eef3512958f21c31be811bb32

[WIP] view inspecting

view details

Godfrey Chan

commit sha d6b4ce83e2be66ab452d6fbcab3043656854d5a6

Correctly insert outlet nodes

view details

Godfrey Chan

commit sha ff7cfe62020c3759cac367d0c0698db39bf8e122

Wire-up more of the UI

view details

Godfrey Chan

commit sha 69b03b29ec8b2fa6c6f1dcaf16af00ad159a2f3b

Get pinning working

view details

Godfrey Chan

commit sha db8ab9e7d79105c87b0f472db5c0bf3d56a32013

Fix vertical-collection

view details

Godfrey Chan

commit sha 8a2950fdc1ec0d48e31b789f6b0dfcf1f613fbd6

Fix object inspection

view details

Godfrey Chan

commit sha 30467f3c4e16f7031305dd87e6ce914e15436c35

Fix polyfill

view details

Godfrey Chan

commit sha 17ae609a6b2c0edb551f13602b594f0ed2f59157

Tooltip positionining Closes #1089

view details

Godfrey Chan

commit sha 045e3fa98bf15940431f0b36f15ece84be9dcf41

Use polyfill for 3.14.0/3.14.1

view details

Godfrey Chan

commit sha ffd0d6a1aaf2af750836d19722e882482e13dcb4

Set `EmberENV._DEBUG_RENDER_TREE`

view details

Godfrey Chan

commit sha ac4d0165cd4a1c8deef39f52ecc09c7bc0feb771

Some improvements to the tooltip

view details

Godfrey Chan

commit sha d9d2950e15a5fdf63fc6ad2fe03e68a5a4939ecc

Refactor render tree to use Octane idioms

view details

Godfrey Chan

commit sha 92c1e3f5d13a405a1c39652839dc9e2c6340396b

Fix debouncing, don't cause a ton of user-runloops

view details

Godfrey Chan

commit sha 12c884d917d67a493b80a6559be18740955c2fce

Don't shadow methods (requested by @rwjblue)

view details

Godfrey Chan

commit sha d52c6f4127c29159f5162b454a6ed03f21653f81

Implement remaining features * Automatically scroll to the appropiate row * Make sure the view inspection tooltips and the inspector tab stays in sync

view details

Godfrey Chan

commit sha fa084af3b0336665379c61a3868a18f1be863225

Fix pinning

view details

Godfrey Chan

commit sha 20acbc4c4517392b52fddaf531a37006173c7ca8

Some performance improvements

view details

Godfrey Chan

commit sha d9ff5d407fa77c4ed26795b5d2d33908c997bca9

General cleanup, ensure correct teardown

view details

push time in 2 months

push eventemberjs/ember-inspector

Godfrey Chan

commit sha ca4eeddae49e30b87ed31afc9e4b554fe40bc2c1

Fix inspecting Glimmer components w/ obj inspector (#1106) Glimmer components instead dev mode assertion getters to warn about mismatches between the Ember.js vs legacy Glimmer.js APIs. Skip these properties when inspecting them to avoid tripping them.

view details

Godfrey Chan

commit sha 772594876ec0367dcdf11d6d2e251e11547ae373

Add a polyfill for the `captureRenderTree` API

view details

Godfrey Chan

commit sha ab887ca32cb969dfbf2548fdd31c54e86a477546

GlimmerTree -> RenderTree

view details

Godfrey Chan

commit sha b973ca2b1271b88c3b0de0d8828740cae9b95311

[WIP] view inspecting

view details

Godfrey Chan

commit sha b6aff5ab2eeed5fb5038b1c98d2d951743cd31ee

Correctly insert outlet nodes

view details

Godfrey Chan

commit sha 5470fd69a2af6473fdf29df6a1c960fe6518b4f0

Wire-up more of the UI

view details

Godfrey Chan

commit sha 0513cc9880a9b1961af7354e6f6256ab24a04fe0

Get pinning working

view details

Godfrey Chan

commit sha 7c757051c8af88fc10aa4b201979dacf1d017b5a

Fix vertical-collection

view details

Godfrey Chan

commit sha 5ed54b6dabb10f0c880f84a44700b38552e16e52

Fix object inspection

view details

Godfrey Chan

commit sha e55a810aaf175fedb76c0176f8391b153f77ae45

Fix polyfill

view details

Godfrey Chan

commit sha 74d714ecf07fcb51feb3bb5351d5adec8a267092

Tooltip positionining Closes #1089

view details

Godfrey Chan

commit sha 20e86e8c75fdac7c0538bb596569a7c2be35765d

Use polyfill for 3.14.0/3.14.1

view details

Godfrey Chan

commit sha 992f78060a62d73a8f8ac2c6ad4ab859a0868bbd

Set `EmberENV._DEBUG_RENDER_TREE`

view details

Godfrey Chan

commit sha 3469ece7c1c1e6c7e661542c7c3c40d7f6671349

Some improvements to the tooltip

view details

Godfrey Chan

commit sha 252beff571d93004da58c670cd7a38998383f118

Refactor render tree to use Octane idioms

view details

Godfrey Chan

commit sha 3706563dbb7f0c07d509e93358c81c624c3ca3c9

Fix debouncing, don't cause a ton of user-runloops

view details

Godfrey Chan

commit sha fb2ed3846afd754dbb448c0a4c120a6abe7b193d

Don't shadow methods (requested by @rwjblue)

view details

Godfrey Chan

commit sha c82f78c2e061668cd2bf1ba09e57ae32f446d102

Implement remaining features * Automatically scroll to the appropiate row * Make sure the view inspection tooltips and the inspector tab stays in sync

view details

Godfrey Chan

commit sha 52544f3172e547cf48fd903763e9a972eb78751b

Fix pinning

view details

Godfrey Chan

commit sha 3be5bccc93af9ed47a51d2914f0a96e24415109e

Some performance improvements

view details

push time in 2 months

push eventemberjs/ember-inspector

Godfrey Chan

commit sha 50ac13bbb814d29b0f49f214fe2422b3742352a2

Only deepClone when w/o prototype extensions This adds a non-trivial amount of cost for each message (especially the complex ones like the view tree) that is not necessary in most apps.

view details

Godfrey Chan

commit sha e9ebeda68870c7c7ea064723eb328ca5cbb73ad2

Update `inspectNode` implementation (#1105) A while ago we discovered the reason this dance was needed, so we documented the reason and simplified the implementation a little bit while we are at it.

view details

Robert Wagner

commit sha 794dfb53c2197942ea176079eaa893c1df52d1a1

Merge branch 'master' into no-deep-clone

view details

Godfrey Chan

commit sha 4a5de94c27e7fbda658ba6ac6298f13a3e49d439

Merge pull request #1107 from emberjs/no-deep-clone Only deepClone when without prototype extensions

view details

Godfrey Chan

commit sha 27fd45f4cab71e744899b7344d9145afcf845b4a

Upload PR artifacts This commit uploads the artifacts from pull requests, allow PRs to be easily tested in Chrome/Firefox/etc before merging into master. General instructions for testing PRs: 1. Click on the "Checks" tabs in the pull request, wait for the "Build and Publish" > "Build extensions" CI job to finish. 2. Under the "Artifacts" dropdown of the CI job, download either the "chrome" or "firefox" build. 3. Extract the zip file. It should result in a "chrome" or "firefox" folder. 4. For Chrome: 4.1. Navigate to `chrome://extensions/`. 4.2. Make sure "Developer mode" (top-right corner) is enabled. 4.3. Disable the Ember Inspector extension (if you have it). 4.4. Click the "Load unpacked" button. 4.5. Select the "chrome" folder from step 3. 5. For Firefox: 5.1. Navigate to `about:addons` and choose "Extensions". 5.2. Disable the Ember Inspector extension (if you have it). 5.3. Click the little cog icon and select "Debug addons". 5.4. Click the "Load Temporary Add-on..." button. 5.5. Navigate to the "firefox" folder from step 3. 5.6. Select the "manifest.json" file from within the folder. 6. The inspector tab should show something like "Ember [PR #123]". 7. Try the inspector on different Ember apps and report any issues. 8. When you are done testing, uninstall the special extension build. 9. (Optionally) Re-install the published inspector from the stores.

view details

Godfrey Chan

commit sha 06b48246cd2dff44e54bc33046d2cd868e07b13a

Merge pull request #1104 from emberjs/upload-pr-artifacts Upload PR artifacts

view details

Godfrey Chan

commit sha 74a6705512f86eec80e6444ca56d832f34ae5b05

Don't abuse timers (#1108) Previously, the object inspector would schedule an infinite timer that fires every 300ms to update the current object (it actually fires even where there isn't a current object to update). This is extremely inefficient, and it causes a lot of extra work in big apps, since the timer starts a runloop which results in a full top-down revalidation. The more appropriate thing to do is tap into the runloop callbacks, since as far as Ember is concerned, if there are no runloops, there are no observable changes.

view details

Godfrey Chan

commit sha 7cade607a583299f5f4f590d40b73a5d44d5dd89

Fix inspecting Glimmer components w/ obj inspector Glimmer components instead dev mode assertion getters to warn about mismatches between the Ember.js vs legacy Glimmer.js APIs. Skip these properties when inspecting them to avoid tripping them.

view details

Godfrey Chan

commit sha b8945e084f38cfa3eb902563fe52529b689f9c8c

Add a polyfill for the `captureRenderTree` API

view details

Godfrey Chan

commit sha 6ccd2a8d73c8abf35644df9a180531123102f754

GlimmerTree -> RenderTree

view details

Godfrey Chan

commit sha 06300f4fb40abe9fc03811d52ecd864fbe21c446

[WIP] view inspecting

view details

Godfrey Chan

commit sha 06370f38cb086e3f357364c5c801c967e0d9fcb8

Correctly insert outlet nodes

view details

Godfrey Chan

commit sha 28998c7e1413785fe3ce6c89317687a7275b552a

Wire-up more of the UI

view details

Godfrey Chan

commit sha e1c715e121097d22783a7d0ca3ed1f8f4f0e77b4

Get pinning working

view details

Godfrey Chan

commit sha 07e61b06979cae6b4001f45a1a28b65ecbc03a3d

Fix vertical-collection

view details

Godfrey Chan

commit sha 3ad59ed003dbedfd19bd08ef302eee5d1f93b6f5

Fix object inspection

view details

Godfrey Chan

commit sha 03380b3caf75754c412a54f71114ceb0843dd1a3

Fix polyfill

view details

Godfrey Chan

commit sha 78cfda3e1896c6acd1607ea8766119743f04da8c

Tooltip positionining Closes #1089

view details

Godfrey Chan

commit sha 031a5da839198922caa0eb210afbe04ecdc95822

Use polyfill for 3.14.0/3.14.1

view details

Godfrey Chan

commit sha aad9b7a895e7c7dd915ed9e8bea6f6eed9069df2

Set `EmberENV._DEBUG_RENDER_TREE`

view details

push time in 2 months

push eventemberjs/ember-inspector

Godfrey Chan

commit sha 7cade607a583299f5f4f590d40b73a5d44d5dd89

Fix inspecting Glimmer components w/ obj inspector Glimmer components instead dev mode assertion getters to warn about mismatches between the Ember.js vs legacy Glimmer.js APIs. Skip these properties when inspecting them to avoid tripping them.

view details

push time in 2 months

push eventemberjs/ember-inspector

Godfrey Chan

commit sha 27fd45f4cab71e744899b7344d9145afcf845b4a

Upload PR artifacts This commit uploads the artifacts from pull requests, allow PRs to be easily tested in Chrome/Firefox/etc before merging into master. General instructions for testing PRs: 1. Click on the "Checks" tabs in the pull request, wait for the "Build and Publish" > "Build extensions" CI job to finish. 2. Under the "Artifacts" dropdown of the CI job, download either the "chrome" or "firefox" build. 3. Extract the zip file. It should result in a "chrome" or "firefox" folder. 4. For Chrome: 4.1. Navigate to `chrome://extensions/`. 4.2. Make sure "Developer mode" (top-right corner) is enabled. 4.3. Disable the Ember Inspector extension (if you have it). 4.4. Click the "Load unpacked" button. 4.5. Select the "chrome" folder from step 3. 5. For Firefox: 5.1. Navigate to `about:addons` and choose "Extensions". 5.2. Disable the Ember Inspector extension (if you have it). 5.3. Click the little cog icon and select "Debug addons". 5.4. Click the "Load Temporary Add-on..." button. 5.5. Navigate to the "firefox" folder from step 3. 5.6. Select the "manifest.json" file from within the folder. 6. The inspector tab should show something like "Ember [PR #123]". 7. Try the inspector on different Ember apps and report any issues. 8. When you are done testing, uninstall the special extension build. 9. (Optionally) Re-install the published inspector from the stores.

view details

Godfrey Chan

commit sha 06b48246cd2dff44e54bc33046d2cd868e07b13a

Merge pull request #1104 from emberjs/upload-pr-artifacts Upload PR artifacts

view details

Godfrey Chan

commit sha 74a6705512f86eec80e6444ca56d832f34ae5b05

Don't abuse timers (#1108) Previously, the object inspector would schedule an infinite timer that fires every 300ms to update the current object (it actually fires even where there isn't a current object to update). This is extremely inefficient, and it causes a lot of extra work in big apps, since the timer starts a runloop which results in a full top-down revalidation. The more appropriate thing to do is tap into the runloop callbacks, since as far as Ember is concerned, if there are no runloops, there are no observable changes.

view details

Godfrey Chan

commit sha 0adf16d6567c4a3ccc43c2d9e83719fa525fd16e

Fix inspecting Glimmer components w/ obj inspector Glimmer components instead dev mode assertion getters to warn about mismatches between the Ember.js vs legacy Glimmer.js APIs. Skip these properties when inspecting them to avoid tripping them.

view details

push time in 2 months

push eventemberjs/ember-inspector

Godfrey Chan

commit sha 27fd45f4cab71e744899b7344d9145afcf845b4a

Upload PR artifacts This commit uploads the artifacts from pull requests, allow PRs to be easily tested in Chrome/Firefox/etc before merging into master. General instructions for testing PRs: 1. Click on the "Checks" tabs in the pull request, wait for the "Build and Publish" > "Build extensions" CI job to finish. 2. Under the "Artifacts" dropdown of the CI job, download either the "chrome" or "firefox" build. 3. Extract the zip file. It should result in a "chrome" or "firefox" folder. 4. For Chrome: 4.1. Navigate to `chrome://extensions/`. 4.2. Make sure "Developer mode" (top-right corner) is enabled. 4.3. Disable the Ember Inspector extension (if you have it). 4.4. Click the "Load unpacked" button. 4.5. Select the "chrome" folder from step 3. 5. For Firefox: 5.1. Navigate to `about:addons` and choose "Extensions". 5.2. Disable the Ember Inspector extension (if you have it). 5.3. Click the little cog icon and select "Debug addons". 5.4. Click the "Load Temporary Add-on..." button. 5.5. Navigate to the "firefox" folder from step 3. 5.6. Select the "manifest.json" file from within the folder. 6. The inspector tab should show something like "Ember [PR #123]". 7. Try the inspector on different Ember apps and report any issues. 8. When you are done testing, uninstall the special extension build. 9. (Optionally) Re-install the published inspector from the stores.

view details

Godfrey Chan

commit sha 06b48246cd2dff44e54bc33046d2cd868e07b13a

Merge pull request #1104 from emberjs/upload-pr-artifacts Upload PR artifacts

view details

Godfrey Chan

commit sha 203193b13f62d770a0d63bed21a7403b7bd2ba19

Don't abuse timers Previously, the object inspector would schedule an infinite timer that fires every 300ms to update the current object (it actually fires even where there isn't a current object to update). This is extremely inefficient, and it causes a lot of extra work in big apps, since the timer starts a runloop which results in a full top-down revalidation. The more appropriate thing to do is tap into the runloop callbacks, since as far as Ember is concerned, if there are no runloops, there are no observable changes.

view details

push time in 2 months

pull request commentemberjs/ember-inspector

Don't abuse timers

Awesome! Really good work.

chancancode

comment created time in 2 months

push eventemberjs/ember-inspector

Godfrey Chan

commit sha 53b453d91f3d3066c4710139a0f516201522ccfc

Don't abuse timers Previously, the object inspector would schedule an infinite timer that fires every 300ms to update the current object (it actually fires even where there isn't a current object to update). This is extremely inefficient, and it causes a lot of extra work in big apps, since the timer starts a runloop which results in a full top-down revalidation. The more appropriate thing to do is tap into the runloop callbacks, since as far as Ember is concerned, if there are no runloops, there are no observable changes.

view details

Godfrey Chan

commit sha 6265252d5a3a66d6c2f7e2b52029604d3630cd55

Fix inspecting Glimmer components w/ obj inspector Glimmer components instead dev mode assertion getters to warn about mismatches between the Ember.js vs legacy Glimmer.js APIs. Skip these properties when inspecting them to avoid tripping them.

view details

push time in 2 months

push eventemberjs/ember-inspector

Godfrey Chan

commit sha 27fd45f4cab71e744899b7344d9145afcf845b4a

Upload PR artifacts This commit uploads the artifacts from pull requests, allow PRs to be easily tested in Chrome/Firefox/etc before merging into master. General instructions for testing PRs: 1. Click on the "Checks" tabs in the pull request, wait for the "Build and Publish" > "Build extensions" CI job to finish. 2. Under the "Artifacts" dropdown of the CI job, download either the "chrome" or "firefox" build. 3. Extract the zip file. It should result in a "chrome" or "firefox" folder. 4. For Chrome: 4.1. Navigate to `chrome://extensions/`. 4.2. Make sure "Developer mode" (top-right corner) is enabled. 4.3. Disable the Ember Inspector extension (if you have it). 4.4. Click the "Load unpacked" button. 4.5. Select the "chrome" folder from step 3. 5. For Firefox: 5.1. Navigate to `about:addons` and choose "Extensions". 5.2. Disable the Ember Inspector extension (if you have it). 5.3. Click the little cog icon and select "Debug addons". 5.4. Click the "Load Temporary Add-on..." button. 5.5. Navigate to the "firefox" folder from step 3. 5.6. Select the "manifest.json" file from within the folder. 6. The inspector tab should show something like "Ember [PR #123]". 7. Try the inspector on different Ember apps and report any issues. 8. When you are done testing, uninstall the special extension build. 9. (Optionally) Re-install the published inspector from the stores.

view details

push time in 2 months

push eventemberjs/ember-inspector

Godfrey Chan

commit sha bef7b038c360806b5ea831268eeacc584d2207f1

Fix inspecting Glimmer components w/ obj inspector Glimmer components instead dev mode assertion getters to warn about mismatches between the Ember.js vs legacy Glimmer.js APIs. Skip these properties when inspecting them to avoid tripping them.

view details

push time in 2 months

push eventemberjs/ember-inspector

Godfrey Chan

commit sha 50ac13bbb814d29b0f49f214fe2422b3742352a2

Only deepClone when w/o prototype extensions This adds a non-trivial amount of cost for each message (especially the complex ones like the view tree) that is not necessary in most apps.

view details

Godfrey Chan

commit sha e9ebeda68870c7c7ea064723eb328ca5cbb73ad2

Update `inspectNode` implementation (#1105) A while ago we discovered the reason this dance was needed, so we documented the reason and simplified the implementation a little bit while we are at it.

view details

Robert Wagner

commit sha 794dfb53c2197942ea176079eaa893c1df52d1a1

Merge branch 'master' into no-deep-clone

view details

Godfrey Chan

commit sha 4a5de94c27e7fbda658ba6ac6298f13a3e49d439

Merge pull request #1107 from emberjs/no-deep-clone Only deepClone when without prototype extensions

view details

Godfrey Chan

commit sha 53b453d91f3d3066c4710139a0f516201522ccfc

Don't abuse timers Previously, the object inspector would schedule an infinite timer that fires every 300ms to update the current object (it actually fires even where there isn't a current object to update). This is extremely inefficient, and it causes a lot of extra work in big apps, since the timer starts a runloop which results in a full top-down revalidation. The more appropriate thing to do is tap into the runloop callbacks, since as far as Ember is concerned, if there are no runloops, there are no observable changes.

view details

push time in 2 months

push eventemberjs/ember-inspector

Godfrey Chan

commit sha de5871457632ce41c17353101fa7172694a3b3a6

Don't abuse timers Previously, the object inspector would schedule an infinite timer that fires every 300ms to update the current object (it actually fires even where there isn't a current object to update). This is extremely inefficient, and it causes a lot of extra work in big apps, since the timer starts a runloop which results in a full top-down revalidation. The more appropriate thing to do is tap into the runloop callbacks, since as far as Ember is concerned, if there are no runloops, there are no observable changes.

view details

push time in 2 months

push eventemberjs/ember-inspector

Godfrey Chan

commit sha a90ca583f93544fb357a66e3b6eb4a0fd6b31421

Upload PR artifacts This commit uploads the artifacts from pull requests, allow PRs to be easily tested in Chrome/Firefox/etc before merging into master. General instructions for testing PRs: 1. Click on the "Checks" tabs in the pull request, wait for the "Build and Publish" > "Build extensions" CI job to finish. 2. Under the "Artifacts" dropdown of the CI job, download either the "chrome" or "firefox" build. 3. Extract the zip file. It should result in a "chrome" or "firefox" folder. 4. For Chrome: 4.1. Navigate to `chrome://extensions/`. 4.2. Make sure "Developer mode" (top-right corner) is enabled. 4.3. Disable the Ember Inspector extension (if you have it). 4.4. Click the "Load unpacked" button. 4.5. Select the "chrome" folder from step 3. 5. For Firefox: 5.1. Navigate to `about:addons` and choose "Extensions". 5.2. Disable the Ember Inspector extension (if you have it). 5.3. Click the little cog icon and select "Debug addons". 5.4. Click the "Load Temporary Add-on..." button. 5.5. Navigate to the "firefox" folder from step 3. 5.6. Select the "manifest.json" file from within the folder. 6. The inspector tab should show something like "Ember [PR #123]". 7. Try the inspector on different Ember apps and report any issues. 8. When you are done testing, uninstall the special extension build. 9. (Optionally) Re-install the published inspector from the stores. (cherry picked from commit 649d3ce24f89ab278e49f1f020baf84ee33509c9)

view details

Godfrey Chan

commit sha 6832dc0f736168487a9cb0d4c51228f547dcad48

Update `inspectNode` implementation A while ago we discovered the reason this dance was needed, so we documented the reason and simplified the implementation a little bit while we are at it. (cherry picked from commit da47ab3a20ea88259f7e4972d1bfd3cea90962ae)

view details

Godfrey Chan

commit sha b2aa544b351b52b3aeee082bbc50455d65793fb6

Fix inspecting Glimmer components w/ obj inspector Glimmer components instead dev mode assertion getters to warn about mismatches between the Ember.js vs legacy Glimmer.js APIs. Skip these properties when inspecting them to avoid tripping them. (cherry picked from commit 30cfa1e9e0cf4773b6edf1b4f2729464667bd278)

view details

Godfrey Chan

commit sha d89e461150740c9b523c1a651ddb7e81c7262ffb

Only deepClone when w/o prototype extensions This adds a non-trivial amount of cost for each message (especially the complex ones like the view tree) that is not necessary in most apps. (cherry picked from commit 50ac13bbb814d29b0f49f214fe2422b3742352a2)

view details

Godfrey Chan

commit sha 003c36ec20140e9171c80556a0c487443f7c52da

Don't abuse timers Previously, the object inspector would schedule an infinite timer that fires every 300ms to update the current object (it actually fires even where there isn't a current object to update). This is extremely inefficient, and it causes a lot of extra work in big apps, since the timer starts a runloop which results in a full top-down revalidation. The more appropriate thing to do is tap into the runloop callbacks, since as far as Ember is concerned, if there are no runloops, there are no observable changes. (cherry picked from commit 57c8a36f5774d98418ad24da82faec346358af2f)

view details

Godfrey Chan

commit sha 2035845345ee8779945a5bc16fa8dd95f7dc7b1c

Add a polyfill for the `captureRenderTree` API

view details

Godfrey Chan

commit sha b959811d777b2e368e95af2b48e70df1f557b996

GlimmerTree -> RenderTree

view details

Godfrey Chan

commit sha 22d7cc95651dc9877f11c52fa6415f9498a5333f

[WIP] view inspecting

view details

Godfrey Chan

commit sha 33873e3d6b962137a66ca93376c6c7729269f26b

Correctly insert outlet nodes

view details

Godfrey Chan

commit sha 4c2c48fdab1c39602ce8b115853d105b2a2adcf5

Wire-up more of the UI

view details

Godfrey Chan

commit sha 00209d45f1d515ed85561ae5b7064923ce92e9ce

Get pinning working

view details

Godfrey Chan

commit sha d814a2580bc0654ba64ad9ca63b4387882b24191

Fix vertical-collection

view details

Godfrey Chan

commit sha 171b681e4c31d572e3704b969ad908b31d4cfa30

Fix object inspection

view details

Godfrey Chan

commit sha f5b544090351e06422c2486abaca03bba03c44d0

Fix polyfill

view details

Godfrey Chan

commit sha acb13b7e072c46d4019a00119002e92b63b51a24

Tooltip positionining Closes #1089

view details

Godfrey Chan

commit sha 5982ca81169f831790b07a3242f3d301038c569c

Use polyfill for 3.14.0/3.14.1

view details

Godfrey Chan

commit sha 7a44e7b6bb3f866c2542ea2102358d598d348b48

Set `EmberENV._DEBUG_RENDER_TREE`

view details

Godfrey Chan

commit sha 17afa0ac89a4a32b8aa63de6f250c01ad4973894

Some improvements to the tooltip

view details

Godfrey Chan

commit sha 04b63a00075166cd81b7f9057874dd9628d3f2a4

Refactor render tree to use Octane idioms

view details

Godfrey Chan

commit sha 3382a255f3d47a6673b1b9a0f4998ad572310d1e

Fix debouncing, don't cause a ton of user-runloops

view details

push time in 2 months

push eventemberjs/ember-inspector

Godfrey Chan

commit sha 57c8a36f5774d98418ad24da82faec346358af2f

Don't abuse timers Previously, the object inspector would schedule an infinite timer that fires every 300ms to update the current object (it actually fires even where there isn't a current object to update). This is extremely inefficient, and it causes a lot of extra work in big apps, since the timer starts a runloop which results in a full top-down revalidation. The more appropriate thing to do is tap into the runloop callbacks, since as far as Ember is concerned, if there are no runloops, there are no observable changes.

view details

push time in 2 months

create barnchemberjs/ember-inspector

branch : no-timers

created branch time in 2 months

push eventemberjs/ember-inspector

Godfrey Chan

commit sha 50ac13bbb814d29b0f49f214fe2422b3742352a2

Only deepClone when w/o prototype extensions This adds a non-trivial amount of cost for each message (especially the complex ones like the view tree) that is not necessary in most apps.

view details

push time in 2 months

push eventemberjs/ember-inspector

Godfrey Chan

commit sha 9a20539943d07da4db26f694ff7738fbd0f1f8f6

Only deepClone when w/o prototype extensions This adds a non-trivial amount of cost for each message (especially the complex ones like the view tree) that is not necessary in most apps.

view details

push time in 2 months

push eventemberjs/ember-inspector

Godfrey Chan

commit sha 30cfa1e9e0cf4773b6edf1b4f2729464667bd278

Fix inspecting Glimmer components w/ obj inspector Glimmer components instead dev mode assertion getters to warn about mismatches between the Ember.js vs legacy Glimmer.js APIs. Skip these properties when inspecting them to avoid tripping them.

view details

push time in 2 months

push eventemberjs/ember-inspector

Godfrey Chan

commit sha d8777666469cb1868dea333db5e1ed709852ddf9

Only deepClone when w/o prototype extensions This adds a non-trivial amount of cost for each message (especially the complex ones like the view tree) that is not necessary in most apps.

view details

push time in 2 months

create barnchemberjs/ember-inspector

branch : no-deep-clone

created branch time in 2 months

push eventemberjs/ember-inspector

Godfrey Chan

commit sha 706750977745443af383d02ecdb822a710026ef7

Upload PR artifacts This commit uploads the artifacts from pull requests, allow PRs to be easily tested in Chrome/Firefox/etc before merging into master. General instructions for testing PRs: 1. Click on the "Checks" tabs in the pull request, wait for the "Build and Publish" > "Build extensions" CI job to finish. 2. Under the "Artifacts" dropdown of the CI job, download either the "chrome" or "firefox" build. 3. Extract the zip file. It should result in a "chrome" or "firefox" folder. 4. For Chrome: 4.1. Navigate to `chrome://extensions/`. 4.2. Make sure "Developer mode" (top-right corner) is enabled. 4.3. Disable the Ember Inspector extension (if you have it). 4.4. Click the "Load unpacked" button. 4.5. Select the "chrome" folder from step 3. 5. For Firefox: 5.1. Navigate to `about:addons` and choose "Extensions". 5.2. Disable the Ember Inspector extension (if you have it). 5.3. Click the little cog icon and select "Debug addons". 5.4. Click the "Load Temporary Add-on..." button. 5.5. Navigate to the "firefox" folder from step 3. 5.6. Select the "manifest.json" file from within the folder. 6. The inspector tab should show something like "Ember [PR #123]". 7. Try the inspector on different Ember apps and report any issues. 8. When you are done testing, uninstall the special extension build. 9. (Optionally) Re-install the published inspector from the stores. (cherry picked from commit 649d3ce24f89ab278e49f1f020baf84ee33509c9)

view details

Godfrey Chan

commit sha 35d16bef0a116187b2f4af030c088aa1676515fc

Update `inspectNode` implementation A while ago we discovered the reason this dance was needed, so we documented the reason and simplified the implementation a little bit while we are at it. (cherry picked from commit da47ab3a20ea88259f7e4972d1bfd3cea90962ae)

view details

Godfrey Chan

commit sha c2e18328e63e8481f894dad3408dcb5ffb3be6f5

Fix inspecting Glimmer components w/ obj inspector Glimmer components instead dev mode assertion getters to warn about mismatches between the Ember.js vs legacy Glimmer.js APIs. Skip these properties when inspecting them to avoid tripping them. (cherry picked from commit bc8b902b233d3808bb5f7a6e33a7f619e78084f5)

view details

Godfrey Chan

commit sha 12751abb444482b90b89989c6bcb2d67d5cc8f4e

Add a polyfill for the `captureRenderTree` API

view details

Godfrey Chan

commit sha 7fb08120d1448adcbf1968b1f6160a5f42ab82e8

GlimmerTree -> RenderTree

view details

Godfrey Chan

commit sha b58ad2ea741c2ec77e5c61bb26fbe0232c72a500

[WIP] view inspecting

view details

Godfrey Chan

commit sha 9ce7f739500da0f8282d07002d87ea283cff904d

Correctly insert outlet nodes

view details

Godfrey Chan

commit sha 61ffebce8093fd45a4cd3f743d9244ffa6bd1a96

Wire-up more of the UI

view details

Godfrey Chan

commit sha 6afef94ac23ff033f34af4a2aebdcf33a7190fb0

Get pinning working

view details

Godfrey Chan

commit sha fe425cdc02e0d90d850b7668a52c6e8dac4e1e27

Fix vertical-collection

view details

Godfrey Chan

commit sha 254710c600e1f1838c2737677127d4e0845c0aa7

Fix object inspection

view details

Godfrey Chan

commit sha 722309e9e474541e477f3a8a2e5027b8501868c2

Fix polyfill

view details

Godfrey Chan

commit sha fab234acd048cdac20cc3e4e43ee518c6fa90c46

Tooltip positionining Closes #1089

view details

Godfrey Chan

commit sha eba93004cdafcdac7116a5d8c87b357bdc97fda5

Use polyfill for 3.14.0/3.14.1

view details

Godfrey Chan

commit sha 7b07f06896ef586c3e36d38e46ff21dce81f5285

Set `EmberENV._DEBUG_RENDER_TREE`

view details

Godfrey Chan

commit sha 7647a8478f1fd31b28b0f34f13ce29598b7bd50d

Some improvements to the tooltip

view details

Godfrey Chan

commit sha 77c1cb959a3e36f9d623cd0f770a7b765bd46861

Refactor render tree to use Octane idioms

view details

Godfrey Chan

commit sha a8124a5c58301857c3673f996f8d53a90df49682

Fix debouncing, don't cause a ton of user-runloops

view details

Godfrey Chan

commit sha 2e38bb47768445b64b9b00f211b0887cf681e18c

Don't shadow methods (requested by @rwjblue)

view details

Godfrey Chan

commit sha 1872bf225be966d16df8d54a2f7f8384fcd5758c

Implement remaining features * Automatically scroll to the appropiate row * Make sure the view inspection tooltips and the inspector tab stays in sync

view details

push time in 2 months

push eventemberjs/ember-inspector

Godfrey Chan

commit sha bc8b902b233d3808bb5f7a6e33a7f619e78084f5

Fix inspecting Glimmer components w/ obj inspector Glimmer components instead dev mode assertion getters to warn about mismatches between the Ember.js vs legacy Glimmer.js APIs. Skip these properties when inspecting them to avoid tripping them.

view details

push time in 2 months

push eventemberjs/ember-inspector

Godfrey Chan

commit sha 8ab435e2da574063f228df18ff809460e130683e

Merge pull request #1103 from emberjs/refactor-acceptance-tests Refactor acceptance tests

view details

Godfrey Chan

commit sha ef0ee2cae767cdcabddb58faef69bd138b1c015b

Upload PR artifacts This commit uploads the artifacts from pull requests, allow PRs to be easily tested in Chrome/Firefox/etc before merging into master. General instructions for testing PRs: 1. Click on the "Checks" tabs in the pull request, wait for the "Build and Publish" > "Build extensions" CI job to finish. 2. Under the "Artifacts" dropdown of the CI job, download either the "chrome" or "firefox" build. 3. Extract the zip file. It should result in a "chrome" or "firefox" folder. 4. For Chrome: 4.1. Navigate to `chrome://extensions/`. 4.2. Make sure "Developer mode" (top-right corner) is enabled. 4.3. Disable the Ember Inspector extension (if you have it). 4.4. Click the "Load unpacked" button. 4.5. Select the "chrome" folder from step 3. 5. For Firefox: 5.1. Navigate to `about:addons` and choose "Extensions". 5.2. Disable the Ember Inspector extension (if you have it). 5.3. Click the little cog icon and select "Debug addons". 5.4. Click the "Load Temporary Add-on..." button. 5.5. Navigate to the "firefox" folder from step 3. 5.6. Select the "manifest.json" file from within the folder. 6. The inspector tab should show something like "Ember [PR #123]". 7. Try the inspector on different Ember apps and report any issues. 8. When you are done testing, uninstall the special extension build. 9. (Optionally) Re-install the published inspector from the stores. (cherry picked from commit 649d3ce24f89ab278e49f1f020baf84ee33509c9)

view details

Godfrey Chan

commit sha a61fc153686b26b422608bb89f6b2684e3d413b7

Update `inspectNode` implementation A while ago we discovered the reason this dance was needed, so we documented the reason and simplified the implementation a little bit while we are at it. (cherry picked from commit da47ab3a20ea88259f7e4972d1bfd3cea90962ae)

view details

Godfrey Chan

commit sha aac037db91b858fc02f8ec4f538bb94ff3919305

Fix inspecting Glimmer components w/ obj inspector Glimmer components instead dev mode assertion getters to warn about mismatches between the Ember.js vs legacy Glimmer.js APIs. Skip these properties when inspecting them to avoid tripping them. (cherry picked from commit 92d03fbd367dfdda6b568660b16e4b92a7e87bb4)

view details

Godfrey Chan

commit sha 0de55083ca9b64b6011ce82e10dffb20c8e1578b

Add a polyfill for the `captureRenderTree` API

view details

Godfrey Chan

commit sha 7358ab53a46c9210a3615d91b1950b2f403ecfd5

GlimmerTree -> RenderTree

view details

Godfrey Chan

commit sha e20cead9738868293ef665f528f53559b747cf5b

[WIP] view inspecting

view details

Godfrey Chan

commit sha e6b28ce483410086c1afe79b86971d3deebbfe8d

Correctly insert outlet nodes

view details

Godfrey Chan

commit sha 142c76469374bff761ec659b47bde8fe9becde85

Wire-up more of the UI

view details

Godfrey Chan

commit sha f3d4a46c4efef9cf6802ee853d20ce36a69f72e9

Get pinning working

view details

Godfrey Chan

commit sha 92f8d44661068a8c6fe990a6be177fe75d06bcb6

Fix vertical-collection

view details

Godfrey Chan

commit sha 2c8326bec1809a81d871257b2c229f64635a8ab4

Fix object inspection

view details

Godfrey Chan

commit sha 1a24da720d2fe18bfbe3b58d24419b883dd9b64e

Fix polyfill

view details

Godfrey Chan

commit sha 27eb1d7852dee5fbfa90e0ad7bda08d244c4a890

Tooltip positionining Closes #1089

view details

Godfrey Chan

commit sha 1624c3ee7dbaede849a18b16c37883d39e503072

Use polyfill for 3.14.0/3.14.1

view details

Godfrey Chan

commit sha ec0466b7c7f29fc42d52911a62a87ea281e774d1

Set `EmberENV._DEBUG_RENDER_TREE`

view details

Godfrey Chan

commit sha 3c239bdd09df11d5e41b76b2a3e957d2eda1503a

Some improvements to the tooltip

view details

Godfrey Chan

commit sha 2ba4071736a4ffeb8427c8e1bf11ce7890db94b9

Refactor render tree to use Octane idioms

view details

Godfrey Chan

commit sha f5e114f90c1387a078b2dcad292550d1495eac25

Fix debouncing, don't cause a ton of user-runloops

view details

Godfrey Chan

commit sha 47a1bc137326593c58bbf734626e5c8b007f33d8

Don't shadow methods (requested by @rwjblue)

view details

push time in 2 months

create barnchemberjs/ember-inspector

branch : inspect-glimmer-component

created branch time in 2 months

create barnchemberjs/ember-inspector

branch : inspect-node

created branch time in 2 months

push eventemberjs/ember-inspector

Godfrey Chan

commit sha 0b541c6ae8cfa63c4f8c9e29d714f5a86278b9b3

Refactor acceptance tests The main goal is to get the tests to more accurately reflect what actually happen in real applications. Instead of mocking/reopening the application "port", we now directly replace the adapter with a `TestAdapter` that faithfully implements the required hooks the same way that a "real" adapter does. This allows us to write acceptance tests by only sending/responding to messages in a way that is, as a far as the inspector app can is concerned, indistinguishable from the "real" ember debug behaves in the real world. The new API also allows us to be a bit more precise in terms of the expectations (messages sent/received the correct number of times, in the right order, etc).

view details

Godfrey Chan

commit sha 8ab435e2da574063f228df18ff809460e130683e

Merge pull request #1103 from emberjs/refactor-acceptance-tests Refactor acceptance tests

view details

Godfrey Chan

commit sha 649d3ce24f89ab278e49f1f020baf84ee33509c9

Upload PR artifacts This commit uploads the artifacts from pull requests, allow PRs to be easily tested in Chrome/Firefox/etc before merging into master. General instructions for testing PRs: 1. Click on the "Checks" tabs in the pull request, wait for the "Build and Publish" > "Build extensions" CI job to finish. 2. Under the "Artifacts" dropdown of the CI job, download either the "chrome" or "firefox" build. 3. Extract the zip file. It should result in a "chrome" or "firefox" folder. 4. For Chrome: 4.1. Navigate to `chrome://extensions/`. 4.2. Make sure "Developer mode" (top-right corner) is enabled. 4.3. Disable the Ember Inspector extension (if you have it). 4.4. Click the "Load unpacked" button. 4.5. Select the "chrome" folder from step 3. 5. For Firefox: 5.1. Navigate to `about:addons` and choose "Extensions". 5.2. Disable the Ember Inspector extension (if you have it). 5.3. Click the little cog icon and select "Debug addons". 5.4. Click the "Load Temporary Add-on..." button. 5.5. Navigate to the "firefox" folder from step 3. 5.6. Select the "manifest.json" file from within the folder. 6. The inspector tab should show something like "Ember [PR #123]". 7. Try the inspector on different Ember apps and report any issues. 8. When you are done testing, uninstall the special extension build. 9. (Optionally) Re-install the published inspector from the stores.

view details

push time in 2 months

create barnchemberjs/ember-inspector

branch : upload-pr-artifacts

created branch time in 2 months

push eventemberjs/ember-inspector

Godfrey Chan

commit sha 0b541c6ae8cfa63c4f8c9e29d714f5a86278b9b3

Refactor acceptance tests The main goal is to get the tests to more accurately reflect what actually happen in real applications. Instead of mocking/reopening the application "port", we now directly replace the adapter with a `TestAdapter` that faithfully implements the required hooks the same way that a "real" adapter does. This allows us to write acceptance tests by only sending/responding to messages in a way that is, as a far as the inspector app can is concerned, indistinguishable from the "real" ember debug behaves in the real world. The new API also allows us to be a bit more precise in terms of the expectations (messages sent/received the correct number of times, in the right order, etc).

view details

Godfrey Chan

commit sha 1b4f59bdeb5642c57bd748ebd8f34c0de919dc77

Add a polyfill for the `captureRenderTree` API

view details

Godfrey Chan

commit sha f1c6c2e3eea60e026c8cbd4f63f1dc6a3b163499

GlimmerTree -> RenderTree

view details

Godfrey Chan

commit sha 04f2d1bb210d10d5bf69f054673cd274df40cd09

[WIP] view inspecting

view details

Godfrey Chan

commit sha f35b9ac9023a04f2a1746e340b7b872cbbd0f102

Correctly insert outlet nodes

view details

Godfrey Chan

commit sha ab17cee6666413cadafe1e23f61f3210419b4ac9

Wire-up more of the UI

view details

Godfrey Chan

commit sha 3629c268c597dc62aea776a69eb0f6c646ac5d17

Get pinning working

view details

Godfrey Chan

commit sha 60fc741c7678364e9075cef1703f010404b80b17

Fix vertical-collection

view details

Godfrey Chan

commit sha 1a457e85a770705d63f24b89a6017de3472a7463

Fix object inspection

view details

Godfrey Chan

commit sha 110db1282123878d858a69a96bec380ee6182ea4

Fix polyfill

view details

Godfrey Chan

commit sha f09db9be2bfaa72dbe66db2aa943e4557e8e179e

Tooltip positionining Closes #1089

view details

Godfrey Chan

commit sha 68023b36c8a0cf3f5211c1d9e993a2c4f8a03157

Use polyfill for 3.14.0/3.14.1

view details

Godfrey Chan

commit sha 729898f3c4cb02e4e961aa35a4f0b033a38e85b4

Set `EmberENV._DEBUG_RENDER_TREE`

view details

Godfrey Chan

commit sha d5e29ace4639c958c77332692bf36149607e52a3

Some improvements to the tooltip

view details

Godfrey Chan

commit sha 164ecd6b003f24e13eca1d824cb8a67ea23e144f

Add [Nightly] and [PR] to tab title

view details

Godfrey Chan

commit sha 5071b8894aae13bc13da0c2e56e9e6f2abe2071b

Refactor render tree to use Octane idioms

view details

Godfrey Chan

commit sha bd69ff7351e3a213ce99ed1d3f9b302b0caee715

Fix debouncing, don't cause a ton of user-runloops

view details

Godfrey Chan

commit sha 743093b0b1a551d44f3f0b3d167f0989dfe0e0fa

Don't shadow methods (requested by @rwjblue)

view details

Godfrey Chan

commit sha a9bd13ed1de136012a882a6c2a7f591a9e129c1b

Implement remaining features * Automatically scroll to the appropiate row * Make sure the view inspection tooltips and the inspector tab stays in sync

view details

Godfrey Chan

commit sha d9590f5572f519bd031d4c8afa03a18cf10cb4bc

Fix pinning

view details

push time in 2 months

push eventemberjs/ember-inspector

Godfrey Chan

commit sha 0b541c6ae8cfa63c4f8c9e29d714f5a86278b9b3

Refactor acceptance tests The main goal is to get the tests to more accurately reflect what actually happen in real applications. Instead of mocking/reopening the application "port", we now directly replace the adapter with a `TestAdapter` that faithfully implements the required hooks the same way that a "real" adapter does. This allows us to write acceptance tests by only sending/responding to messages in a way that is, as a far as the inspector app can is concerned, indistinguishable from the "real" ember debug behaves in the real world. The new API also allows us to be a bit more precise in terms of the expectations (messages sent/received the correct number of times, in the right order, etc).

view details

push time in 2 months

push eventemberjs/ember-inspector

Godfrey Chan

commit sha 8461e01fb8222e0adb68f5ffff13f8ec645416e1

remove unused code

view details

push time in 2 months

push eventemberjs/ember-inspector

Godfrey Chan

commit sha 6bf2677b4a7d830008de7fc5ffb4c437a68ea5f0

Fix app-picker-test, introduce a more robust testing setup

view details

push time in 2 months

push eventemberjs/ember-inspector

patricklx

commit sha b369e9437839818f830f4adbc8a4d216d19b9b07

fix accessing properties of Object Proxy (#1092) * fix access of Object Proxy also for tracked detection * Update object-inspector-test.js

view details

patricklx

commit sha a5a406599f38423ca78e9f8727fd695d3396d3c3

fix issue with ember tracking reentry assert (#1094) * fix issue with ember tracking reentry assert this causes: Assertion Failed: You attempted to update `[]` on `[object Object]`, but it had already been used previously in the same computation * use suggestion Co-Authored-By: Chris Garrett <me@pzuraq.com>

view details

Godfrey Chan

commit sha 5aad4a5be035ce746535dfef0c29f5d9f9a4e02b

Refactor acceptance tests The main goal is to get the tests to more accurately reflect what actually happen in real applications. Instead of mocking/reopening the application "port", we now directly replace the adapter with a `TestAdapter` that faithfully implements the required hooks the same way that a "real" adapter does. This allows us to write acceptance tests by only sending/responding to messages in a way that is, as a far as the inspector app can is concerned, indistinguishable from the "real" ember debug behaves in the real world. The new API also allows us to be a bit more precise in terms of the expectations (messages sent/received the correct number of times, in the right order, etc).

view details

Godfrey Chan

commit sha 0e5e4342060226ef428865668a74afbb6deb8536

Add a polyfill for the `captureRenderTree` API

view details

Godfrey Chan

commit sha 3a700d3bb7ede3404a54a1316a5758673aaa5adb

GlimmerTree -> RenderTree

view details

Godfrey Chan

commit sha c8999bd99179904a82e031c0033fef31fa81e6c1

[WIP] view inspecting

view details

Godfrey Chan

commit sha 3ff91b2881e33aa22fcea120cdf40e55e9049d5f

Correctly insert outlet nodes

view details

Godfrey Chan

commit sha 0531d048c821d53d433e82ac374c5fe77501238b

Wire-up more of the UI

view details

Godfrey Chan

commit sha 843f118d057cd166945304b9990e8b7792d26441

Get pinning working

view details

Godfrey Chan

commit sha 3ec25befcbd46cbb9c13d0974d98e28cbd61bb55

Fix vertical-collection

view details

Godfrey Chan

commit sha 229fb03a293bc36465ce67aff5f6bb00c5122421

Fix object inspection

view details

Godfrey Chan

commit sha 553935d492220cb8d3ee9e0a6aee1f116f53fec6

Fix polyfill

view details

Godfrey Chan

commit sha 72145dc55c6a70f10befa953938c3f8ba4e56528

Tooltip positionining Closes #1089

view details

Godfrey Chan

commit sha 84bdf58b28f34b73bad8ddc5953e1723e6051ae7

Use polyfill for 3.14.0/3.14.1

view details

Godfrey Chan

commit sha 3d18addb9a238e09cb5875b81a31dc77ff206b38

Set `EmberENV._DEBUG_RENDER_TREE`

view details

Godfrey Chan

commit sha 1f720f2dbe9a7100efdd81a792b3a75dd38726f3

Some improvements to the tooltip

view details

Godfrey Chan

commit sha a46390868027c1031edc0aed540d0c5b459f1cb0

Add [Nightly] and [PR] to tab title

view details

Godfrey Chan

commit sha 3d226220995dbc7bbc6acd2d3a1699515666222e

Refactor render tree to use Octane idioms

view details

Godfrey Chan

commit sha bc2e5447a1d14abb4299280ae2293c14fa0c8a2f

Fix debouncing, don't cause a ton of user-runloops

view details

Godfrey Chan

commit sha 3bfe8becb19b6eb235f7f3507adfd6fb669dc3f2

Don't shadow methods (requested by @rwjblue)

view details

push time in 2 months

push eventemberjs/ember-inspector

Godfrey Chan

commit sha 5aad4a5be035ce746535dfef0c29f5d9f9a4e02b

Refactor acceptance tests The main goal is to get the tests to more accurately reflect what actually happen in real applications. Instead of mocking/reopening the application "port", we now directly replace the adapter with a `TestAdapter` that faithfully implements the required hooks the same way that a "real" adapter does. This allows us to write acceptance tests by only sending/responding to messages in a way that is, as a far as the inspector app can is concerned, indistinguishable from the "real" ember debug behaves in the real world. The new API also allows us to be a bit more precise in terms of the expectations (messages sent/received the correct number of times, in the right order, etc).

view details

push time in 2 months

push eventemberjs/ember-inspector

Godfrey Chan

commit sha 34a96992908a339a7b7ed76d93889e2cc249cefe

Refactor acceptance tests The main goal is to get the tests to more accurately reflect what actually happen in real applications. Instead of mocking/reopening the application "port", we now directly replace the adapter with a `TestAdapter` that faithfully implements the required hooks the same way that a "real" adapter does. This allows us to write acceptance tests by only sending/responding to messages in a way that is, as a far as the inspector app can is concerned, indistinguishable from the "real" ember debug behaves in the real world. The new API also allows us to be a bit more precise in terms of the expectations (messages sent/received the correct number of times, in the right order, etc).

view details

push time in 2 months

push eventemberjs/ember-inspector

patricklx

commit sha a5a406599f38423ca78e9f8727fd695d3396d3c3

fix issue with ember tracking reentry assert (#1094) * fix issue with ember tracking reentry assert this causes: Assertion Failed: You attempted to update `[]` on `[object Object]`, but it had already been used previously in the same computation * use suggestion Co-Authored-By: Chris Garrett <me@pzuraq.com>

view details

Godfrey Chan

commit sha 890ccb11deba317ade465671c3e53c2cae587beb

Refactor acceptance tests The main goal is to get the tests to more accurately reflect what actually happen in real applications. Instead of mocking/reopening the application "port", we now directly replace the adapter with a `TestAdapter` that faithfully implements the required hooks the same way that a "real" adapter does. This allows us to write acceptance tests by only sending/responding to messages in a way that is, as a far as the inspector app can is concerned, indistinguishable from the "real" ember debug behaves in the real world. The new API also allows us to be a bit more precise in terms of the expectations (messages sent/received the correct number of times, in the right order, etc).

view details

push time in 2 months

create barnchemberjs/ember-inspector

branch : refactor-acceptance-tests

created branch time in 2 months

push eventemberjs/ember-inspector

Godfrey Chan

commit sha 0fbca9f69c1843e1128b425ec4686f0b213475f2

simplify api

view details

push time in 2 months

push eventemberjs/ember-inspector

Godfrey Chan

commit sha b58c33d5022efcf42ba2951b6f62d492fe521cf6

simplify api

view details

push time in 2 months

push eventemberjs/ember-inspector

Godfrey Chan

commit sha c67c2708d67d0d05a79ad5df8d9e53a60e1ad446

Fix what's new tests

view details

push time in 2 months

push eventemberjs/ember-inspector

Godfrey Chan

commit sha e9dce5f05cdada9f04f57380cd62e897638b5f10

Fix whitespace

view details

Godfrey Chan

commit sha c5d15e4cac36a9af3a25d7ba1f06cf1ccb3ab777

Fix render tree tests

view details

Godfrey Chan

commit sha 7d6f05e9095c8071ee4cddb8df8f630e105dd3b4

Fix route tests

view details

push time in 2 months

push eventnushell/nushell

Yehuda Katz

commit sha e0017e693c303cea9fb2592b9742adc40c5a15c5

WIP start merging color and expand Types don't check

view details

push time in 2 months

push eventemberjs/ember-inspector

Godfrey Chan

commit sha 25df18aa6cbcf390fb4708900f2e9c7425d74d2f

Fix app picker test for now

view details

push time in 2 months

push eventemberjs/ember-inspector

Godfrey Chan

commit sha 0d5c5b2b278290ea0de70a9581a333c125cba1e1

fix promise tests

view details

push time in 2 months

push eventemberjs/ember-inspector

Godfrey Chan

commit sha 53f07b480f13ab12ec2741e9beec6865f692e634

fix promise tests

view details

push time in 2 months

push eventemberjs/ember-inspector

Godfrey Chan

commit sha 3a9144aac874b1dfc8dbea8e55a4caf7e28867b7

Fix object inspector tests

view details

push time in 2 months

push eventemberjs/ember-inspector

Godfrey Chan

commit sha 89a7e2ac64c20c18c27a846b1e7e3ef510ca0c34

Fix info tests

view details

push time in 2 months

push eventemberjs/ember-inspector

Godfrey Chan

commit sha f7ecded96458c62613623f671dd10bd4986d598f

Fix deprecation tests

view details

push time in 2 months

push eventnushell/nushell

Yehuda Katz

commit sha 623d5da3f11476ed7a44e5b8572a2568dcd520f3

WIP More token restructuring

view details

push time in 2 months

create barnchnushell/nushell

branch : restructure-tokens

created branch time in 2 months

create barnchemberjs/ember-inspector

branch : debug-build

created branch time in 2 months

create barnchemberjs/ember-inspector

branch : fix-lint

created branch time in 2 months

create barnchemberjs/ember-inspector

branch : yarn-list

created branch time in 2 months

push eventemberjs/ember-inspector

Godfrey Chan

commit sha 3f70183091ad8e196f30bc53da3c8010d78013cc

Lock broccoli-funnel to 3.0.0 See https://github.com/broccolijs/broccoli-funnel/issues/121

view details

push time in 2 months

push eventemberjs/ember-inspector

Godfrey Chan

commit sha c2cd2f33acbff3b3fbb5429af2d5b8daf178dd94

bump more deps

view details

push time in 2 months

push eventemberjs/ember-inspector

Godfrey Chan

commit sha be3cb9f587618d7c3eb467649154ec59b59ca0ae

bump more deps

view details

push time in 2 months

push eventemberjs/ember-inspector

Godfrey Chan

commit sha 4bc1436ba7c68508cee9aa3225b7bd4683ce4a24

bump more deps

view details

push time in 2 months

more