profile
viewpoint

pmorie/kubernetes 1

Container Cluster Manager

wongma7/amazon-eks-ami 1

Packer configuration for building a custom EKS AMI

wongma7/aws-ebs-csi-driver 1

CSI driver for Amazon EBS https://aws.amazon.com/ebs/

wongma7/eksctl 1

The official CLI for Amazon EKS

childsb/external-storage 0

External Storage Plugins, Provisoners, and Helper Libraries

gnufied/kubernetes 0

Production-Grade Container Scheduling and Management

wongma7/2bwm 0

A fast floating WM written over the XCB library and derived from mcwm.

push eventwongma7/aws-efs-csi-driver

Tim Petersen

commit sha 9c25639de888e74830f301650b508a639a73e02f

fix: add volMetricsOptIn option for emitting volume metrics #454

view details

Tim Petersen

commit sha 1502bba0c28b100419d4994a273fa0d8b02d77c3

fix: fixing typo in cmd flag

view details

Kubernetes Prow Robot

commit sha 5549c90933556f77ab0ddad8b994d76590ffc2a6

Merge pull request #561 from makomatic/enable-metrics fix: add volMetricsOptIn option for emitting volume metrics #454

view details

Matthew Wong

commit sha b2bd323b4bb3c3b8bb124d58a13a51eb80412c1a

Fix chart 2.2.0 appVersion to be 1.3.4

view details

push time in 2 days

pull request commentkubernetes-sigs/aws-efs-csi-driver

Allow more control of the name of the directory created by the Access Point under Dynamic Provisioning

I like wolffberg's idea, it is easy to reason about.

My highest priority is backwards compatibility, I think it is too soon for a major version update and an upgrade story that entails recreating storageclasses is hard to reason about and could be troublesome.

Another option is to maintain both basePath and rootDirectoryPath and make them mutually exclusive. I don't like this because it is confusing and I want to avoid doing validation of storageclass in general (because validation cannot occur at storageclass creation time, it can only happen later at pv provision time, it is unpleasant UX). But I mention it for completeness

Also, I slightly prefer reusing go templating syntax over coming up with something new. helm should let us escape expressions. Another option is to copy https://github.com/kubernetes-sigs/nfs-subdir-external-provisioner pathPattern parameter templating syntax. I don't know how they arrived at that syntax. But there's probably a nonzero overlap of users who would benefit from consistency since https://github.com/kubernetes-sigs/nfs-subdir-external-provisioner does technically work with EFS too.

jonathanrainer

comment created time in 2 days

pull request commentkubernetes-sigs/aws-ebs-csi-driver

Support for custom labels

/approve

nlamirault

comment created time in 3 days

pull request commentkubernetes-sigs/aws-efs-csi-driver

Refactoring labels and support custom labels

/ok-to-test

nlamirault

comment created time in 3 days

PR opened kubernetes-sigs/aws-efs-csi-driver

Fix chart 2.2.0 appVersion to be 1.3.4

Is this a bug fix or adding new feature? fixes https://github.com/kubernetes-sigs/aws-efs-csi-driver/issues/591

What is this PR about? / Why do we need it? Since the appVersoin in release-1.3 branch is correct, and the branched helm chart is the "canonical" one, https://github.com/kubernetes-sigs/aws-efs-csi-driver/blob/gh-pages/index.yaml#L24 https://github.com/kubernetes-sigs/aws-efs-csi-driver/commit/3f74187046eac621af4187dbd98f283e9d818071, it is safe to simply bump the master branch appVersion to match the 'canonical' release-1.3 appVersion

What testing is done?

+1 -1

0 comment

1 changed file

pr created time in 3 days

create barnchwongma7/aws-efs-csi-driver

branch : appVersion

created branch time in 3 days

issue commentkubernetes-sigs/aws-efs-csi-driver

uid/gid Parameters Ignored

Yes, the driver is due for a 1.4.0 release containing this change and until then the master branch can be used but I don't recommend it except as a short-term workaround. (A release is due anyway to update to the latest amazon linux 2 base image to address security issues etc. so there might be a 1.3.5 as well in parallel, not sure yet.)

I understand it is misleading that the master branch README refers to these unreleased parameters. I think we could modify the default branch to be the latest release branch i.e. release-1.3, I am open to suggestions on this.

iAnomaly

comment created time in 3 days

PR closed kubernetes-sigs/aws-efs-csi-driver

Reviewers
[release-0.3] Ignore 'wait: no child processes' error when calling mount/umount (cherry-pick of kubernetes/kubernetes#103780) approved size/XXL cncf-cla: yes

Is this a bug fix or adding new feature? /bug

What is this PR about? / Why do we need it? 0.3.0 is the latest beta release. Backport the fix for 'wait: no child processes' here. This PR is effectively equivalent to https://github.com/kubernetes-sigs/aws-efs-csi-driver/pull/571 against master branch. But it looks different because master branch has a much more up-to-date go.mod and moreover has the vendor dir checked in.

An alternative would be to backport https://github.com/kubernetes-sigs/aws-efs-csi-driver/pull/514 which is intended to fix the same 'wait: no child processes' error, but https://github.com/kubernetes-sigs/aws-efs-csi-driver/pull/514 is much larger.

What testing is done? CI will test

CI might complain about vendor dir not being "clean" since I have patched it. In that case, I will disable the CI vendor verification.

+1761220 -1

3 comments

5767 changed files

wongma7

pr closed time in 3 days

pull request commentkubernetes-sigs/aws-efs-csi-driver

Move interfaces to _interface.go files and generate mocks from them

/test pull-aws-efs-csi-driver-verify

wongma7

comment created time in 3 days

push eventwongma7/aws-efs-csi-driver

Matthew Wong

commit sha f85ed378fdc05b6bf453163a978173a8bb9d705c

Move interfaces to _interface.go files and generate mocks from them

view details

push time in 3 days

push eventwongma7/aws-efs-csi-driver

Nicolas Geniteau

commit sha 4385e97d3c277f3d79555af8e57440e9e7310643

add uid and gid parameters

view details

Kubernetes Prow Robot

commit sha 78b89dbbfa9d1cde80733e362b8da43600ca26c4

Merge pull request #434 from neovops/add-uid-gid-paremeter Add uid and gid parameter

view details

Matthew Wong

commit sha 6e2684e407a73ab263cf70bc41370d1a83d720f9

Move interfaces to _interface.go files and generate mocks from them

view details

push time in 3 days

issue commentkubernetes-sigs/aws-ebs-csi-driver

still no ChangeLog for v1.5.0

thx, I'll see how we can make changelog point to the branch of the release https://github.com/kubernetes-sigs/aws-ebs-csi-driver/blob/master/.github/workflows/release.yaml#L24

And maybe github could mark the release pre-release and then as practice we could mark it as released only after we are done the final merge.

rubroboletus

comment created time in 3 days

pull request commentkubernetes-sigs/aws-ebs-csi-driver

Release 1.5

/ok-to-test

gtxu

comment created time in 3 days

push eventwongma7/aws-efs-csi-driver

Matthew Wong

commit sha 2faa1e2b81c089bd7c8eca7e428df587b2a53352

Move interfaces to _interface.go files and generate mocks from them

view details

push time in 3 days

issue commentkubernetes-sigs/aws-ebs-csi-driver

still no ChangeLog for v1.5.0

https://github.com/kubernetes-sigs/aws-ebs-csi-driver/pull/1114/files and https://github.com/kubernetes-sigs/aws-ebs-csi-driver/pull/1118/files need to be pushed to master branch (or the release should link to the changelog in the release branch) @gtxu

rubroboletus

comment created time in 3 days

pull request commentkubernetes-sigs/aws-efs-csi-driver

Conditionally added AWS_STS_REGIONAL_ENDPOINTS flag

/ok-to-test

holmesb

comment created time in 3 days

pull request commentkubernetes-sigs/aws-efs-csi-driver

Adds more permissions to avoid errors during deployment

/ok-to-test /check-cla

heitorrbarros

comment created time in 3 days

push eventwongma7/aws-efs-csi-driver

Matthew Wong

commit sha e894603690a13d6443af83eb54dba30506a92514

Update mount-utils to v0.23.0-rc.0 to pick up 'wait: no child processes' change

view details

push time in 3 days

pull request commentkubernetes-sigs/aws-ebs-csi-driver

add ecr-private kustomize overlay

/lgtm thanks !

I won't be able to get v1.1.0 csi-resizer until monday next week though so will merge then

t0rr3sp3dr0

comment created time in 6 days

pull request commentkubernetes-sigs/aws-ebs-csi-driver

images: fix invalid k8s-staging-test-infra/gcb-docker-gcloud tag

/lgtm /approve no worries

spiffxp

comment created time in 6 days

pull request commentkubernetes-sigs/aws-ebs-csi-driver

add ec2-private kustomize overlay

I think a "default" ./deploy/kubernetes/overlays/stable/kustomization.yaml is still needed in addition to ./deploy/kubernetes/overlays/stable/gcr/kustomization.yaml but i am not sure how to achieve that cleanly. So I am fine if it is simply moved to gcr and the install instruction gets updated for next release.

and it makes sense to have ecr use gcr as base. The only potential issue there is if a (new) tag exists in gcr but not ecr since ecr is an imperfect mirror of gcr, but ideally if when bumping tags we always check they are actually pullable from all registries..

./deploy/kubernetes/overlays/stable/kustomization.yaml (== ./deploy/kubernetes/overlays/stable/ecr-public/kustomization.yaml ? ) ./deploy/kubernetes/overlays/stable/ecr/kustomization.yaml ./deploy/kubernetes/overlays/stable/ecr-public/kustomization.yaml ./deploy/kubernetes/overlays/stable/gcr/kustomization.yaml

I am still working on getting newer csi-resizer versions into that 602401143452 account

t0rr3sp3dr0

comment created time in 6 days

pull request commentkubernetes-sigs/aws-ebs-csi-driver

images: use k8s-staging-test-infra/gcb-docker-gcloud

/lgtm /approve /retest

spiffxp

comment created time in 6 days

pull request commentkubernetes-sigs/aws-ebs-csi-driver

add ec2-private kustomize overlay

Currently the latest available resizer image maintained by AWS is "v1.0.0" under the name "602401143452.dkr.ecr.us-west-2.amazonaws.com/eks/csi-resizer:v1.0.0". i.e. the repository "csi-resizer" as opposed to "external-resizer"

So let me get v1.1.0 (and also newer versions while at it?) pushed to "602401143452.dkr.ecr.us-west-2.amazonaws.com/eks/csi-resizer:v1.1.0" then we will have parity

/hold

t0rr3sp3dr0

comment created time in 6 days

pull request commentkubernetes-sigs/aws-ebs-csi-driver

[chart] Allow installing snapshotter with storage.io API v1beta1

/ok-to-test /lgtm /approve

patrungel

comment created time in 6 days

pull request commentkubernetes-sigs/aws-ebs-csi-driver

Support for custom labels

/lgtm

nlamirault

comment created time in 6 days

pull request commentkubernetes-sigs/aws-ebs-csi-driver

Support for custom labels

/ok-to-test

nlamirault

comment created time in 6 days

more