profile
viewpoint
Wesley Wigham weswigham Microsoft Seattle, WA http://ham.io

chrisbenti/PS-Config 45

Powershell Config

ethanjurman/shoot-it 6

Shooting gallery for tons of fun! Use your smart device and fire away!

weswigham/cross 4

Cross-compiler environment management

weswigham/blowfish 2

Block cipher implementation in python

djrenren/achievables 1

A universal achievement system

typescript-bot/TypeScript 1

TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

GeoffreyBooth/node 0

Node.js JavaScript runtime :sparkles::turtle::rocket::sparkles:

weswigham/ad-blocking 0

Prototypes of ad blocking techniques proposed in the "Future of Ad Blocking" paper

weswigham/apache-httpd-bugs 0

Processes apache httpd bugs and links them up to the commits they were fixed in

push eventDefinitelyTyped/DefinitelyTyped

Arnulfo Solis Ramirez

commit sha ee044bd8faafa661fcf89b37b697c0a8d220cbc9

Preparing for mocha 8 (#46017) * Mocha parallel and jobs options * Remove deprecated functions * Removed deprecated types * Replace MochaSetupOptions for MochaOptions in browser mode * Update deps to not use deprecated interfaces * Added unloadFiles to mocha

view details

push time in 14 hours

PR merged DefinitelyTyped/DefinitelyTyped

Preparing for mocha 8 Critical package Edits multiple packages Perf: Same

This PR cleans up the types for the new major version of mocha v8.0 and It adds the parallel and jobs options.

The PR was already getting very big, decided to add the RootHooks in a different PR (as a follow up) https://mochajs.org/api/mocha

Please fill in this template.

  • [x] Use a meaningful title for the pull request. Include the name of the package modified.
  • [x] Test the change in your own code. (Compile and run.)
  • [x] Add or edit tests to reflect the change. (Run with npm test.)
  • [x] Follow the advice from the readme.
  • [x] Avoid common mistakes.
  • [x] Run npm run lint package-name (or tsc if no tslint.json is present).

Changing an existing definition:

  • [x] Provide a URL to documentation or source code which provides context for the suggested changes: https://mochajs.org/api/mocha
  • [x] If this PR brings the type definitions up to date with a new version of the JS library, update the version number in the header.
  • [x] Include tests for your changes
  • [x] If you are making substantial changes, consider adding a tslint.json containing { "extends": "dtslint/dt.json" }. If for reason the any rule need to be disabled, disable it for that line using // tslint:disable-next-line [ruleName] and not for whole package so that the need for disabling can be reviewed.
+62 -396

4 comments

7 changed files

arnulfojr

pr closed time in 14 hours

push eventDefinitelyTyped/DefinitelyTyped

Pierre-Antoine Mills

commit sha 92a75538fb982f93982c3c989db65a75853acc95

chore: update lowest compatibility to ts@3.7 (#45977) Because ramda depends on the ts-toolbelt@6.x.x, the oldest supported version of TypeScript is 3.7.

view details

push time in 14 hours

PR merged DefinitelyTyped/DefinitelyTyped

chore: update lowest compatibility to ts@3.7 Author is Owner Perf: Same Popular package Untested Change

Because ramda depends on the ts-toolbelt@6.x.x, the oldest supported version of TypeScript is 3.7.

Please fill in this template.

  • [x] Use a meaningful title for the pull request. Include the name of the package modified.
  • [x] Test the change in your own code. (Compile and run.)
  • [x] Add or edit tests to reflect the change. (Run with npm test.)
  • [x] Follow the advice from the readme.
  • [x] Avoid common mistakes.
  • [x] Run npm run lint package-name (or tsc if no tslint.json is present).

Select one of these and delete the others:

If adding a new definition:

  • [ ] The package does not already provide its own types, or cannot have its .d.ts files generated via --declaration
  • [ ] If this is for an NPM package, match the name. If not, do not conflict with the name of an NPM package.
  • [ ] Create it with dts-gen --dt, not by basing it on an existing project.
  • [ ] Represents shape of module/library correctly
  • [ ] tslint.json should be present and it shouldn't have any additional or disabling of rules. Just content as { "extends": "dtslint/dt.json" }. If for reason the some rule need to be disabled, disable it for that line using // tslint:disable-next-line [ruleName] and not for whole package so that the need for disabling can be reviewed.
  • [ ] tsconfig.json should have noImplicitAny, noImplicitThis, strictNullChecks, and strictFunctionTypes set to true.

If changing an existing definition:

  • [ ] Provide a URL to documentation or source code which provides context for the suggested changes: <<url here>>
  • [ ] If this PR brings the type definitions up to date with a new version of the JS library, update the version number in the header.
  • [ ] Include tests for your changes
  • [ ] If you are making substantial changes, consider adding a tslint.json containing { "extends": "dtslint/dt.json" }. If for reason the any rule need to be disabled, disable it for that line using // tslint:disable-next-line [ruleName] and not for whole package so that the need for disabling can be reviewed.

If removing a declaration:

  • [ ] If a package was never on Definitely Typed, you don't need to do anything. (If you wrote a package and provided types, you don't need to register it with us.)
  • [ ] Delete the package's directory.
  • [ ] Add it to notNeededPackages.json.
+1 -1

4 comments

1 changed file

pirix-gh

pr closed time in 14 hours

push eventDefinitelyTyped/DefinitelyTyped

Alex Kondratyuk

commit sha 7190d61d167e4302bb4cfacc84aa0500a5864f14

Update extract-files typings (#46002) * Update extract-files typings * fix errors

view details

push time in 14 hours

PR merged DefinitelyTyped/DefinitelyTyped

Update extract-files typings Config Edit Owner Approved Perf: Worse Popular package

Please fill in this template.

  • [x] Use a meaningful title for the pull request. Include the name of the package modified.
  • [x] Test the change in your own code. (Compile and run.)
  • [x] Add or edit tests to reflect the change. (Run with npm test.)
  • [x] Follow the advice from the readme.
  • [x] Avoid common mistakes.
  • [x] Run npm run lint package-name (or tsc if no tslint.json is present).

Select one of these and delete the others:

If changing an existing definition:

  • [x Provide a URL to documentation or source code which provides context for the suggested changes: https://github.com/jaydenseric/extract-files
  • [x] If this PR brings the type definitions up to date with a new version of the JS library, update the version number in the header.
  • [x] Include tests for your changes
  • [x] If you are making substantial changes, consider adding a tslint.json containing { "extends": "dtslint/dt.json" }. If for reason the any rule need to be disabled, disable it for that line using // tslint:disable-next-line [ruleName] and not for whole package so that the need for disabling can be reviewed.
+35 -14

6 comments

3 changed files

lynxtaa

pr closed time in 14 hours

push eventDefinitelyTyped/DefinitelyTyped

Pat Lillis

commit sha 322ea30bfbe543dfb7acf271b911177fad276dac

Add type definitions for "nuclear-js-react-addons-chefsplate" module (#46011) * add type definitions for nuclear-js-react-addons-chefsplate module * make tsline disable inline * remove unnecessary generic

view details

push time in 14 hours

PR merged DefinitelyTyped/DefinitelyTyped

Add type definitions for "nuclear-js-react-addons-chefsplate" module New Definition

NOTE: I only added types for connect(), and left the other exports as any. I only use connect() in my own code, so that's the only one I care about having types for.

Please fill in this template.

  • [X] Use a meaningful title for the pull request. Include the name of the package modified.
  • [X] Test the change in your own code. (Compile and run.)
  • [X] Add or edit tests to reflect the change. (Run with npm test.)
  • [X] Follow the advice from the readme.
  • [X] Avoid common mistakes.
  • [X] Run npm run lint package-name (or tsc if no tslint.json is present).

Select one of these and delete the others:

If adding a new definition:

  • [X] The package does not already provide its own types, or cannot have its .d.ts files generated via --declaration
  • [X] If this is for an NPM package, match the name. If not, do not conflict with the name of an NPM package.
  • [X] Create it with dts-gen --dt, not by basing it on an existing project.
  • [X] Represents shape of module/library correctly
  • [X] tslint.json should be present and it shouldn't have any additional or disabling of rules. Just content as { "extends": "dtslint/dt.json" }. If for reason the some rule need to be disabled, disable it for that line using // tslint:disable-next-line [ruleName] and not for whole package so that the need for disabling can be reviewed.
  • [X] tsconfig.json should have noImplicitAny, noImplicitThis, strictNullChecks, and strictFunctionTypes set to true.
+256 -0

3 comments

4 changed files

patlillis

pr closed time in 14 hours

push eventDefinitelyTyped/DefinitelyTyped

Eric Liu

commit sha 09c9ab36a3f647db06b58c902962ad5fb8d6929a

types: add carbon-components (#46022)

view details

push time in 14 hours

PR merged DefinitelyTyped/DefinitelyTyped

types: add carbon-components New Definition

Please fill in this template.

  • [x] Use a meaningful title for the pull request. Include the name of the package modified.
  • [x] Test the change in your own code. (Compile and run.)
  • [x] Add or edit tests to reflect the change. (Run with npm test.)
  • [x] Follow the advice from the readme.
  • [x] Avoid common mistakes.
  • [x] Run npm run lint package-name (or tsc if no tslint.json is present).

Select one of these and delete the others:

If adding a new definition:

  • [x] The package does not already provide its own types, or cannot have its .d.ts files generated via --declaration
  • [x] If this is for an NPM package, match the name. If not, do not conflict with the name of an NPM package.
  • [ ] Create it with dts-gen --dt, not by basing it on an existing project.
  • [x] Represents shape of module/library correctly
  • [x] tslint.json should be present and it shouldn't have any additional or disabling of rules. Just content as { "extends": "dtslint/dt.json" }. If for reason the some rule need to be disabled, disable it for that line using // tslint:disable-next-line [ruleName] and not for whole package so that the need for disabling can be reviewed.
  • [x] tsconfig.json should have noImplicitAny, noImplicitThis, strictNullChecks, and strictFunctionTypes set to true.
+1007 -0

3 comments

41 changed files

metonym

pr closed time in 14 hours

push eventDefinitelyTyped/DefinitelyTyped

Adriaan Knapen

commit sha b5503ad6dc27488b29769b76e07e5263e16d9a65

feat(hex2dec): adds types for hex2dec (#46018)

view details

push time in 14 hours

PR merged DefinitelyTyped/DefinitelyTyped

feat(hex2dec): adds types for hex2dec New Definition Other Approved

Please fill in this template.

  • [x] Use a meaningful title for the pull request. Include the name of the package modified.
  • [x] Test the change in your own code. (Compile and run.)
  • [x] Add or edit tests to reflect the change. (Run with npm test.)
  • [x] Follow the advice from the readme.
  • [x] Avoid common mistakes.
  • [x] Run npm run lint package-name (or tsc if no tslint.json is present).

Select one of these and delete the others:

If adding a new definition:

  • [x] The package does not already provide its own types, or cannot have its .d.ts files generated via --declaration
  • [x] If this is for an NPM package, match the name. If not, do not conflict with the name of an NPM package.
  • [x] Create it with dts-gen --dt, not by basing it on an existing project.
  • [x] Represents shape of module/library correctly
  • [x] tslint.json should be present and it shouldn't have any additional or disabling of rules. Just content as { "extends": "dtslint/dt.json" }. If for reason the some rule need to be disabled, disable it for that line using // tslint:disable-next-line [ruleName] and not for whole package so that the need for disabling can be reviewed.
  • [x] tsconfig.json should have noImplicitAny, noImplicitThis, strictNullChecks, and strictFunctionTypes set to true.
+42 -0

3 comments

4 changed files

Addono

pr closed time in 14 hours

push eventDefinitelyTyped/DefinitelyTyped

Piotr Błażejewicz (Peter Blazejewicz)

commit sha e8378bbd714cc2fc874402ab555220f53348093f

feat(docdown): new type definition (#46020) Definition types for 'docdown': - definitioins files - tests https://github.com/jdalton/docdown#readme Thanks!

view details

push time in 14 hours

PR merged DefinitelyTyped/DefinitelyTyped

feat(docdown): new type definition New Definition

Definition types for 'docdown':

  • definitioins files
  • tests

https://github.com/jdalton/docdown#readme

Thanks!

  • [x] Use a meaningful title for the pull request. Include the name of the package modified.
  • [x] Test the change in your own code. (Compile and run.)
  • [x] Add or edit tests to reflect the change. (Run with npm test.)
  • [x] Follow the advice from the readme.
  • [x] Avoid common mistakes.
  • [x] Run npm run lint package-name (or tsc if no tslint.json is present).
  • [x] The package does not already provide its own types, or cannot have its .d.ts files generated via --declaration
  • [x] If this is for an NPM package, match the name. If not, do not conflict with the name of an NPM package.
  • [x] Create it with dts-gen --dt, not by basing it on an existing project.
  • [x] Represents shape of module/library correctly
  • [x] tslint.json should be present and it shouldn't have any additional or disabling of rules.
  • [x] tsconfig.json should have noImplicitAny, noImplicitThis, strictNullChecks, and strictFunctionTypes set to true.
+92 -0

3 comments

4 changed files

peterblazejewicz

pr closed time in 14 hours

push eventDefinitelyTyped/DefinitelyTyped

Praveen Kumar Saini

commit sha 0bfb40fb476dbfeb65a739a1ef9e39c1b47ddca9

Add @types/workerb-api (#46007) * Added workerb minimal types * Added documentation to the type definition * Improve type definitions * Added dom to tsconfig * Added tests for workerb * Fix linting * Added change in tslint in workerb types * Fix: eventsProps type * Remove unnecessary comments * renamed package name * Improve types documentation * Fix: Spacing issue in tslint.json

view details

push time in 14 hours

PR merged DefinitelyTyped/DefinitelyTyped

Add @types/workerb-api New Definition

Please fill in this template.

  • [x] Use a meaningful title for the pull request. Include the name of the package modified.
  • [x] Test the change in your own code. (Compile and run.)
  • [x] Add or edit tests to reflect the change. (Run with npm test.)
  • [x] Follow the advice from the readme.
  • [x] Avoid common mistakes.
  • [x] Run npm run lint package-name (or tsc if no tslint.json is present).

If adding a new definition:

  • [x] The package does not already provide its own types, or cannot have its .d.ts files generated via --declaration
  • [x] If this is for an NPM package, match the name. If not, do not conflict with the name of an NPM package.
  • [x] Create it with dts-gen --dt, not by basing it on an existing project.
  • [x] tslint.json should be present and it shouldn't have any additional or disabling of rules. Just content as { "extends": "dtslint/dt.json" }. If for reason the some rule need to be disabled, disable it for that line using // tslint:disable-next-line [ruleName] and not for whole package so that the need for disabling can be reviewed.
  • [x] Represents shape of module/library correctly
  • [x] tsconfig.json should have noImplicitAny, noImplicitThis, strictNullChecks, and strictFunctionTypes set to true.
+528 -0

3 comments

4 changed files

praveen-me

pr closed time in 14 hours

push eventDefinitelyTyped/DefinitelyTyped

Ashish Yadav

commit sha a5ebae94414f514c66aba5e90967d03865b2ce80

Add types for 'react-nepal-map' module (#46015)

view details

push time in 14 hours

PR merged DefinitelyTyped/DefinitelyTyped

Add types for 'react-nepal-map' module New Definition

Please fill in this template.

  • [x] Use a meaningful title for the pull request. Include the name of the package modified.
  • [x] Test the change in your own code. (Compile and run.)
  • [x] Add or edit tests to reflect the change. (Run with npm test.)
  • [x] Follow the advice from the readme.
  • [x] Avoid common mistakes.
  • [x] Run npm run lint package-name (or tsc if no tslint.json is present).

Select one of these and delete the others:

If adding a new definition:

  • [x] The package does not already provide its own types, or cannot have its .d.ts files generated via --declaration
  • [x] If this is for an NPM package, match the name. If not, do not conflict with the name of an NPM package.
  • [x] Create it with dts-gen --dt, not by basing it on an existing project.
  • [x] Represents shape of module/library correctly
  • [x] tslint.json should be present and it shouldn't have any additional or disabling of rules. Just content as { "extends": "dtslint/dt.json" }. If for reason the some rule need to be disabled, disable it for that line using // tslint:disable-next-line [ruleName] and not for whole package so that the need for disabling can be reviewed.
  • [x] tsconfig.json should have noImplicitAny, noImplicitThis, strictNullChecks, and strictFunctionTypes set to true.
+199 -0

3 comments

4 changed files

ashiishme

pr closed time in 14 hours

push eventDefinitelyTyped/DefinitelyTyped

Peter Munyao

commit sha 8f4efcd2ee5b98668dc63aa28b0d77fe2e1c051e

Add type definitions for mpesa-node (#46003)

view details

push time in 14 hours

PR merged DefinitelyTyped/DefinitelyTyped

Add type definitions for mpesa-node New Definition
  • [x] Use a meaningful title for the pull request. Include the name of the package modified.
  • [x] Test the change in your own code. (Compile and run.)
  • [x] Add or edit tests to reflect the change. (Run with npm test.)
  • [x] Follow the advice from the readme.
  • [x] Avoid common mistakes.
  • [x] Run npm run lint package-name (or tsc if no tslint.json is present).

Select one of these and delete the others:

If adding a new definition:

  • [x] The package does not already provide its own types, or cannot have its .d.ts files generated via --declaration
  • [x] If this is for an NPM package, match the name. If not, do not conflict with the name of an NPM package.
  • [x] Create it with dts-gen --dt, not by basing it on an existing project.
  • [x] Represents shape of module/library correctly
  • [x] tslint.json should be present and it shouldn't have any additional or disabling of rules. Just content as { "extends": "dtslint/dt.json" }. If for reason the some rule need to be disabled, disable it for that line using // tslint:disable-next-line [ruleName] and not for whole package so that the need for disabling can be reviewed.
  • [x] tsconfig.json should have noImplicitAny, noImplicitThis, strictNullChecks, and strictFunctionTypes set to true.
+102 -0

3 comments

5 changed files

petekmunz

pr closed time in 14 hours

push eventDefinitelyTyped/DefinitelyTyped

mtgto

commit sha 607b638249ff2f685ad671efc3313d402d81aa80

[codemirror] Add Doc#lineSeparator (#45851)

view details

push time in 14 hours

PR merged DefinitelyTyped/DefinitelyTyped

[codemirror] Add Doc#lineSeparator (move from Editor#lineSeparator) Merge:YSYL Perf: Same Popular package

function lineSeparator can be called from Doc. https://codemirror.net/doc/manual.html#lineSeparator https://github.com/codemirror/CodeMirror/blob/5.55.0/src/model/Doc.js#L421

new CodeMirror.Doc("xxxx", "", 1, "foo").lineSeparator();
// => "foo"
  • [x] Use a meaningful title for the pull request. Include the name of the package modified.
  • [x] Test the change in your own code. (Compile and run.)
  • [x] Add or edit tests to reflect the change. (Run with npm test.)
  • [x] Follow the advice from the readme.
  • [x] Avoid common mistakes.
  • [x] Run npm run lint package-name (or tsc if no tslint.json is present).

If changing an existing definition:

  • [x] Provide a URL to documentation or source code which provides context for the suggested changes: https://codemirror.net/doc/manual.html#lineSeparator
  • [ ] If this PR brings the type definitions up to date with a new version of the JS library, update the version number in the header.
  • [x] Include tests for your changes
  • [ ] If you are making substantial changes, consider adding a tslint.json containing { "extends": "dtslint/dt.json" }. If for reason the any rule need to be disabled, disable it for that line using // tslint:disable-next-line [ruleName] and not for whole package so that the need for disabling can be reviewed.
+4 -3

4 comments

2 changed files

mtgto

pr closed time in 14 hours

push eventDefinitelyTyped/DefinitelyTyped

Mariano Vazquez

commit sha d3facd7b56e1a96ad4c0fa0110490f0fc9100655

fix(yargs-interactive): Extend Interactive interface with yargs.Argv interface (#45831)

view details

push time in 14 hours

PR merged DefinitelyTyped/DefinitelyTyped

fix(yargs-interactive): Extend Interactive interface with yargs.Argv interface Author is Owner Merge:YSYL Perf: Same

This PR adds missing types to the yargs interactive Interactive interface. Since this library is an extension of yargs, its interface has to extend from it.


Please fill in this template.

  • [x] Use a meaningful title for the pull request. Include the name of the package modified.
  • [x] Test the change in your own code. (Compile and run.)
  • [x] Add or edit tests to reflect the change. (Run with npm test.)
  • [x] Follow the advice from the readme.
  • [x] Avoid common mistakes.
  • [ ] Run npm run lint package-name (or tsc if no tslint.json is present).

Select one of these and delete the others:

If adding a new definition:

  • [ ] The package does not already provide its own types, or cannot have its .d.ts files generated via --declaration
  • [ ] If this is for an NPM package, match the name. If not, do not conflict with the name of an NPM package.
  • [ ] Create it with dts-gen --dt, not by basing it on an existing project.
  • [ ] Represents shape of module/library correctly
  • [ ] tslint.json should be present and it shouldn't have any additional or disabling of rules. Just content as { "extends": "dtslint/dt.json" }. If for reason the some rule need to be disabled, disable it for that line using // tslint:disable-next-line [ruleName] and not for whole package so that the need for disabling can be reviewed.
  • [ ] tsconfig.json should have noImplicitAny, noImplicitThis, strictNullChecks, and strictFunctionTypes set to true.

If changing an existing definition:

  • [x] Provide a URL to documentation or source code which provides context for the suggested changes: https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/types/yargs/index.d.ts#L47
  • [ ] If this PR brings the type definitions up to date with a new version of the JS library, update the version number in the header.
  • [x] Include tests for your changes
  • [ ] If you are making substantial changes, consider adding a tslint.json containing { "extends": "dtslint/dt.json" }. If for reason the any rule need to be disabled, disable it for that line using // tslint:disable-next-line [ruleName] and not for whole package so that the need for disabling can be reviewed.

If removing a declaration:

  • [ ] If a package was never on Definitely Typed, you don't need to do anything. (If you wrote a package and provided types, you don't need to register it with us.)
  • [ ] Delete the package's directory.
  • [ ] Add it to notNeededPackages.json.
+7 -2

3 comments

2 changed files

nanovazquez

pr closed time in 14 hours

push eventDefinitelyTyped/DefinitelyTyped

Dmitry Minkovsky

commit sha eb94c374696a4a81a648d5ac22501d3ecaa98500

[@types/braintree-web-drop-in] Typed `off` method added in 1.19 (#45832)

view details

push time in 14 hours

PR merged DefinitelyTyped/DefinitelyTyped

[@types/braintree-web-drop-in] Typed `off` method added in 1.19 Merge:YSYL Perf: Same

Please fill in this template.

  • [x] Use a meaningful title for the pull request. Include the name of the package modified.
  • [x] Test the change in your own code. (Compile and run.)
  • [x] Add or edit tests to reflect the change. (Run with npm test.)
  • [x] Follow the advice from the readme.
  • [x] Avoid common mistakes.
  • [x] Run npm run lint package-name (or tsc if no tslint.json is present).

If changing an existing definition:

  • [x] Provide a URL to documentation or source code which provides context for the suggested changes:
  • https://github.com/braintree/braintree-web-drop-in/blob/bd5a9a997337aaad4f779c201097a2d917f9609e/CHANGELOG.md#1190
  • https://braintree.github.io/braintree-web-drop-in/docs/current/Dropin.html#off
  • [x] If this PR brings the type definitions up to date with a new version of the JS library, update the version number in the header.
  • [x] Include tests for your changes
  • [x] If you are making substantial changes, consider adding a tslint.json containing { "extends": "dtslint/dt.json" }. If for reason the any rule need to be disabled, disable it for that line using // tslint:disable-next-line [ruleName] and not for whole package so that the need for disabling can be reviewed.
+51 -15

5 comments

3 changed files

dminkovsky

pr closed time in 14 hours

push eventDefinitelyTyped/DefinitelyTyped

Andrew Schekatihin

commit sha 80ddbd163b2e934ba4cc8fb593994df9c007f458

mysql: When configured Pool.config has different structure from what's expected at createPool() (#45860) * When configured Pool.config has different structure from what's expected at createPool() * Test added

view details

push time in 14 hours

PR merged DefinitelyTyped/DefinitelyTyped

mysql: When configured Pool.config has different structure from what's expected at createPool() Merge:YSYL Perf: Same Popular package

If changing an existing definition:

  • [x] Provide a URL to documentation or source code which provides context for the suggested changes: Related issue
+11 -2

4 comments

2 changed files

aschekatihin

pr closed time in 14 hours

issue closedmicrosoft/TypeScript

[regression] recursive like types => maximum call stack error

TypeScript Version: 3.9.x and 4.0.0

<!-- Search terms you tried before logging this (so others can find this issue more easily) --> Search Terms: maximum call stack, recursive type

Code

  • source code here: https://github.com/lifaon74/observables
  • yarn install, yarn run build_all

On one of my big projet, migrating from typescript 3.8.3 to 3.9.3 broke many things:

  • "circular constraint" errors appeared. I need some kind of circular reference to check if a Generic type matches a specific pattern
  • "maximum call stack" error when building the project (simply running tsc)

Expected behavior: should transpile

Related Issues: https://github.com/microsoft/TypeScript/issues/37475 https://github.com/microsoft/TypeScript/issues/38198

closed time in 2 days

lifaon74

create barnchweswigham/TypeScript

branch : instantiation-stackoverflow

created branch time in 2 days

pull request commentmicrosoft/TypeScript

Add extensions to `bin` scripts.

Yep, that looks to be a report of the same thing.

sosoba

comment created time in 2 days

pull request commentmicrosoft/TypeScript

Add extensions to `bin` scripts.

We... don't set type: module in our package.json - #39381 is totally indicative of an error in the implementation of the experimental flag in node itself.

sosoba

comment created time in 2 days

push eventDefinitelyTyped/DefinitelyTyped

Andrei Alecu

commit sha 3839e8d6ed7c2856981673321e16796544e723ad

fix(mongoose): allow specifying objectids as strings in create (#45610) * fix(mongoose): allow specifying objectids as strings in create * add additional types * allow number for decimal128 * refactor * ensure bad enum value is not allowed and add additional tests * improve performance and refactor

view details

push time in 2 days

PR merged DefinitelyTyped/DefinitelyTyped

Reviewers
fix(mongoose): allow specifying objectids as strings in create Author is Owner Perf: Same Popular package

Fixes #45609

Please fill in this template.

  • [x] Use a meaningful title for the pull request. Include the name of the package modified.
  • [x] Test the change in your own code. (Compile and run.)
  • [x] Add or edit tests to reflect the change. (Run with npm test.)
  • [x] Follow the advice from the readme.
  • [x] Avoid common mistakes.
  • [x] Run npm run lint package-name (or tsc if no tslint.json is present).

Select one of these and delete the others:

If changing an existing definition:

  • [ ] Provide a URL to documentation or source code which provides context for the suggested changes: <<url here>>
  • [ ] If this PR brings the type definitions up to date with a new version of the JS library, update the version number in the header.
  • [x] Include tests for your changes
  • [ ] If you are making substantial changes, consider adding a tslint.json containing { "extends": "dtslint/dt.json" }. If for reason the any rule need to be disabled, disable it for that line using // tslint:disable-next-line [ruleName] and not for whole package so that the need for disabling can be reviewed.
+78 -17

15 comments

2 changed files

andreialecu

pr closed time in 2 days

issue closedDefinitelyTyped/DefinitelyTyped

@types/mongoose create schema doesn't allow string source to objectid

  • [x] I tried using the @types/mongoose package and had problems.
  • [x] I tried using the latest stable version of tsc. https://www.npmjs.com/package/typescript
  • [x] Mention the authors (see Definitions by: in index.d.ts) so they can respond.
    • Authors: @andreialecu

@andreialecu This is another example of how your PR breaks totally valid code.

I'm going to post a PR that reverts it soon.

This is not the first attempt made at creating a schema for document creation. See https://github.com/DefinitelyTyped/DefinitelyTyped/commit/26587aa3aa75e0021180a9a7f9b4cb45e036002b#diff-f77e4c92e873042528b4ef79285cdf3c https://github.com/DefinitelyTyped/DefinitelyTyped/commit/22761c884a9542171583f83ccd178acd0c1e3b11#diff-f77e4c92e873042528b4ef79285cdf3c

This attempt was also not adequately testd and had PLENTY of issues.

I reverted it in https://github.com/DefinitelyTyped/DefinitelyTyped/commit/c860c1dc7ba152a7e09b518eee900125a1a3bc3d#diff-f77e4c92e873042528b4ef79285cdf3c

Please STOP adding schema to create without testing all the possibilities. This is not that simple and causes the rest of us to waste a lot of time.

import * as Mongoose from 'mongoose'

interface IDocument extends Mongoose.Document {
    objectId: Mongoose.Types.ObjectId
}

const schema = new Mongoose.Schema({
    objectId: Mongoose.Types.ObjectId,
})

const model = Mongoose.model<IDocument>('model', schema);

/*
TS2769: No overload matches this call.   The last overload gave the following error.     Type 'string' has no properties in common with type '{ generationTime?: number; }'.  tmp.ts(4, 5): The expected type comes from property 'objectId' which is declared here on type 'Pick<{ _id?: any; objectId?: { generationTime?: number; }; } & { _id: any; }, "objectId"> & { _id?: any; }' index.d.ts(3259, 5): The last overload is declared here.
 */
model.create({
    objectId: 'valid-object-id-source',
});

// passes
model.create({
    objectId: new Mongoose.Types.ObjectId(),
});

closed time in 2 days

tomyam1

push eventDefinitelyTyped/DefinitelyTyped

Donald Pipowitch

commit sha 070f24304792838efcd87f23472c0e184896306f

Update ALBResult (#45936)

view details

push time in 2 days

PR merged DefinitelyTyped/DefinitelyTyped

Update ALBResult in aws-lambda Owner Approved Perf: Same Popular package Untested Change

Please fill in this template.

  • [x] Use a meaningful title for the pull request. Include the name of the package modified.
  • [x] Test the change in your own code. (Compile and run.)
  • [ ] Add or edit tests to reflect the change. (Run with npm test.)
  • [ ] Follow the advice from the readme.
  • [ ] Avoid common mistakes.
  • [ ] Run npm run lint package-name (or tsc if no tslint.json is present).

Select one of these and delete the others:

If changing an existing definition:

  • [x] Provide a URL to documentation or source code which provides context for the suggested changes: <<url here>>
  • [ ] If this PR brings the type definitions up to date with a new version of the JS library, update the version number in the header.
  • [ ] Include tests for your changes
  • [ ] If you are making substantial changes, consider adding a tslint.json containing { "extends": "dtslint/dt.json" }. If for reason the any rule need to be disabled, disable it for that line using // tslint:disable-next-line [ruleName] and not for whole package so that the need for disabling can be reviewed.

As far as I can tell statusDescription and isBase64Encoded are optional. E.g. statusDescription is also not a part of this official example: https://github.com/aws/elastic-load-balancing-tools/blob/master/application-load-balancer-serverless-app/whatismyip/whatismyip.py#L14

But I'm not super familiar with the API. There are several old blog post which says that those fields are required, but my tests can't verify this. Same results for me if I drop those fields? Maybe ALB changed it's behavior?

+2 -2

3 comments

1 changed file

donaldpipowitch

pr closed time in 2 days

push eventDefinitelyTyped/DefinitelyTyped

Piotr Błażejewicz (Peter Blazejewicz)

commit sha 7b855576c64adaec08bc2043969523be10fe557a

update(weighted): DT definition changes (#45939) This adds changes discussed in merged PR: `#45633 - CommonJS module shape - proper alias for select - TS config and TSLint config updated to just follow DT defaults - tests amended with modern syntax - but still using existing tests Thanks!

view details

push time in 2 days

PR merged DefinitelyTyped/DefinitelyTyped

update(weighted): DT definition changes Config Edit Owner Approved Perf: Same

This adds changes discussed in merged PR: Please reffer to: #45633

  • CommonJS module shape
  • proper alias for select
  • TS config and TSLint config updated to just follow DT defaults
  • tests amended with modern syntax - but still using existing tests

Thanks!

  • [x] Use a meaningful title for the pull request. Include the name of the package modified.
  • [x] Test the change in your own code. (Compile and run.)
  • [x] Add or edit tests to reflect the change. (Run with npm test.)
  • [x] Follow the advice from the readme.
  • [x] Run npm run lint package-name (or tsc if no tslint.json is present).
+38 -38

3 comments

5 changed files

peterblazejewicz

pr closed time in 2 days

issue closedDefinitelyTyped/DefinitelyTyped

webpack-env missing path

I'm using the latest typescript version and due to the addition from path to node in 12.12.48 I get this error in webpack-env:

node_modules/@types/webpack-env/index.d.ts:349:15 - error TS2430: Interface 'NodeJS.Module' incorrectly extends interface '__WebpackModuleApi.Module'.
  Types of property 'parent' are incompatible.
    Type 'Module | null' is not assignable to type 'NodeModule | null'.
      Property 'path' is missing in type 'Module' but required in type 'NodeModule'.

349     interface Module extends __WebpackModuleApi.Module {}
                  ~~~~~~

  node_modules/@types/node/globals.d.ts:236:5
    236     path: string;
            ~~~~
    'path' is declared here.

@use-strict @rhonsby

closed time in 2 days

Nber1

push eventDefinitelyTyped/DefinitelyTyped

Piotr Błażejewicz (Peter Blazejewicz)

commit sha 181b253d3a6a8752970f3f3574b512a2feda100b

fix(45927): fix missing `path` for Module in v12 (#45940) * fix(45927): fix missing `path` for Module in v12 This is an attempt to fix a problem reported in #45927 /cc @tk-1io Thanks! Fixes #45927 * Update types/node/v12/node-tests.ts thx to @Exe-Boss Co-authored-by: ExE Boss <3889017+ExE-Boss@users.noreply.github.com> Co-authored-by: ExE Boss <3889017+ExE-Boss@users.noreply.github.com>

view details

push time in 2 days

PR merged DefinitelyTyped/DefinitelyTyped

fix(45927): fix missing `path` for Module in v12 Author is Owner Critical package Owner Approved Perf: Same

This is an attempt to fix a problem reported in #45927

/cc @tk-1io

Thanks!

Fixes #45927

  • [x] Use a meaningful title for the pull request. Include the name of the package modified.
  • [x] Test the change in your own code. (Compile and run.)
  • [x] Add or edit tests to reflect the change. (Run with npm test.)
+7 -0

8 comments

2 changed files

peterblazejewicz

pr closed time in 2 days

push eventDefinitelyTyped/DefinitelyTyped

cherryblossom000

commit sha 28a932ba836b195814aaf89cdc04dccf43598780

nedb: Make errors in callbacks nullable (#45765)

view details

push time in 2 days

PR merged DefinitelyTyped/DefinitelyTyped

nedb: Make errors in callbacks nullable Merge:YSYL Perf: Same

Please fill in this template.

  • [x] Use a meaningful title for the pull request. Include the name of the package modified.
  • [x] Test the change in your own code. (Compile and run.)
  • [x] Add or edit tests to reflect the change. (Run with npm test.)
  • [x] Follow the advice from the readme.
  • [x] Avoid common mistakes.
  • [x] Run npm run lint package-name (or tsc if no tslint.json is present).

Select one of these and delete the others:

If changing an existing definition:

  • [x] Provide a URL to documentation or source code which provides context for the suggested changes:
  • [ ] If this PR brings the type definitions up to date with a new version of the JS library, update the version number in the header.
  • [x] Include tests for your changes
  • [ ] If you are making substantial changes, consider adding a tslint.json containing { "extends": "dtslint/dt.json" }. If for reason the any rule need to be disabled, disable it for that line using // tslint:disable-next-line [ruleName] and not for whole package so that the need for disabling can be reviewed.
+75 -75

3 comments

2 changed files

cherryblossom000

pr closed time in 2 days

push eventDefinitelyTyped/DefinitelyTyped

pokutuna

commit sha 7df6da08d2211a6c011c593c46ae94908ba0a558

[asciichart] Add colors and other settings to fit for current(1.5.21) version (#45761)

view details

push time in 2 days

PR merged DefinitelyTyped/DefinitelyTyped

[asciichart] Add colors and other settings Author is Owner Merge:YSYL No Other Owners Perf: Same

Please fill in this template.

  • [x] Use a meaningful title for the pull request. Include the name of the package modified.
  • [x] Test the change in your own code. (Compile and run.)
  • [x] Add or edit tests to reflect the change. (Run with npm test.)
  • [x] Follow the advice from the readme.
  • [x] Avoid common mistakes.
  • [x] Run npm run lint package-name (or tsc if no tslint.json is present).

Select one of these and delete the others:

If changing an existing definition:

  • [x] Provide a URL to documentation or source code which provides context for the suggested changes: https://github.com/kroitor/asciichart/blob/master/asciichart.js
  • [x] If this PR brings the type definitions up to date with a new version of the JS library, update the version number in the header.
  • [x] Include tests for your changes
  • [x] If you are making substantial changes, consider adding a tslint.json containing { "extends": "dtslint/dt.json" }. If for reason the any rule need to be disabled, disable it for that line using // tslint:disable-next-line [ruleName] and not for whole package so that the need for disabling can be reviewed.
+52 -0

2 comments

2 changed files

pokutuna

pr closed time in 2 days

push eventDefinitelyTyped/DefinitelyTyped

markdreyer

commit sha 5e1fd7eaf08eba32531f4fb9f0d9f147d6fef9aa

fix (readable-stream): fixed type compatibility with node v10 (#45563) * fix: fixed type compatability with node v10 * refactor: add my name to author list for notifications * fix: forgot version directories don't work with reference types

view details

push time in 2 days

PR merged DefinitelyTyped/DefinitelyTyped

fix (readable-stream): fixed type compatibility with node v10 Merge:YSYL Perf: Same Popular package

Please fill in this template.

  • [x ] Use a meaningful title for the pull request. Include the name of the package modified.
  • [x] Test the change in your own code. (Compile and run.)
  • [x] Add or edit tests to reflect the change. (Run with npm test.)
  • [x] Follow the advice from the readme.
  • [x] Avoid common mistakes.
  • [x] Run npm run lint package-name (or tsc if no tslint.json is present).

If changing an existing definition:

  • [x] Provide a URL to documentation or source code which provides context for the suggested changes: <https://github.com/DefinitelyTyped/DefinitelyTyped/issues/45371>
  • [ ] If this PR brings the type definitions up to date with a new version of the JS library, update the version number in the header.
  • [x] Include tests for your changes
  • [x] If you are making substantial changes, consider adding a tslint.json containing { "extends": "dtslint/dt.json" }. If for reason the any rule need to be disabled, disable it for that line using // tslint:disable-next-line [ruleName] and not for whole package so that the need for disabling can be reviewed.
+21 -5

5 comments

2 changed files

markdreyer

pr closed time in 2 days

push eventDefinitelyTyped/DefinitelyTyped

Takashi Tamura

commit sha d983f99f80862f19cd9e6963a95a8193e6ef68fa

[workerpool] Remove WorkerPool.clear and WorkerPoolOptions.nodeWorker. (#45753)

view details

push time in 2 days

PR merged DefinitelyTyped/DefinitelyTyped

[workerpool] Remove WorkerPool.clear and WorkerPoolOptions.nodeWorker. Merge:YSYL Perf: Same

Please fill in this template.

  • [x] Use a meaningful title for the pull request. Include the name of the package modified.
  • [x] Test the change in your own code. (Compile and run.)
  • [ ] Add or edit tests to reflect the change. (Run with npm test.)
  • [x] Follow the advice from the readme.
  • [x] Avoid common mistakes.
  • [x] Run npm run lint package-name (or tsc if no tslint.json is present).

Select one of these and delete the others:

If changing an existing definition:

  • [x] Provide a URL to documentation or source code which provides context for the suggested changes: https://github.com/josdejong/workerpool/blob/master/HISTORY.md#2020-05-13-version-600
  • [x] If this PR brings the type definitions up to date with a new version of the JS library, update the version number in the header.
  • [x] Include tests for your changes
  • [ ] If you are making substantial changes, consider adding a tslint.json containing { "extends": "dtslint/dt.json" }. If for reason the any rule need to be disabled, disable it for that line using // tslint:disable-next-line [ruleName] and not for whole package so that the need for disabling can be reviewed.

WorkerPool.clear and WorkerPoolOptions.nodeWorker have been removed.

+5 -23

3 comments

2 changed files

tamuratak

pr closed time in 2 days

push eventDefinitelyTyped/DefinitelyTyped

Emily Marigold Klassen

commit sha 0c32e6afd64364f0cd2964c8555264ebaa04c46d

[workerpool] Ensure that the promise typing is PromiseLike (#45399) * [workerpool] Ensure that the promise typing is PromiseLike * [workerpool] add forivall to maintainers It seems like the current maintainers are absent

view details

push time in 2 days

PR merged DefinitelyTyped/DefinitelyTyped

[workerpool] Ensure that the promise typing is PromiseLike Merge:YSYL Perf: Same

Please fill in this template.

  • [x] Use a meaningful title for the pull request. Include the name of the package modified.
  • [x] Test the change in your own code. (Compile and run.)
  • [x] Add or edit tests to reflect the change. (Run with npm test.)
  • [x] Follow the advice from the readme.
  • [x] Avoid common mistakes.
  • [x] Run npm run lint package-name (or tsc if no tslint.json is present).

Select one of these and delete the others:

If changing an existing definition:

  • [x] Provide a URL to documentation or source code which provides context for the suggested changes: N/A, https://github.com/josdejong/workerpool/pull/159 (it conforms to the standard promiselike type definition at least, so my changes are valid)
  • [ ] ~If this PR brings the type definitions up to date with a new version of the JS library, update the version number in the header.~
  • [x] Include tests for your changes
  • [ ] ~If you are making substantial changes, consider adding a tslint.json containing { "extends": "dtslint/dt.json" }. If for reason the any rule need to be disabled, disable it for that line using // tslint:disable-next-line [ruleName] and not for whole package so that the need for disabling can be reviewed.~
+4 -1

4 comments

2 changed files

forivall

pr closed time in 2 days

push eventDefinitelyTyped/DefinitelyTyped

Tom Haines

commit sha eb4fb2d6b5d84e4be9dfd2faefe12e40d74cf4f3

Add CAF receiver version constant (#45948)

view details

push time in 2 days

PR merged DefinitelyTyped/DefinitelyTyped

Add CAF receiver version constant Owner Approved Perf: Worse Untested Change

Please fill in this template.

  • [X] Use a meaningful title for the pull request. Include the name of the package modified.
  • [X] Test the change in your own code. (Compile and run.)
  • [ ] Add or edit tests to reflect the change. (Run with npm test.)
  • [X] Follow the advice from the readme.
  • [X] Avoid common mistakes.
  • [X] Run npm run lint package-name (or tsc if no tslint.json is present).

Select one of these and delete the others:

If adding a new definition:

  • [ ] The package does not already provide its own types, or cannot have its .d.ts files generated via --declaration
  • [ ] If this is for an NPM package, match the name. If not, do not conflict with the name of an NPM package.
  • [ ] Create it with dts-gen --dt, not by basing it on an existing project.
  • [ ] Represents shape of module/library correctly
  • [ ] tslint.json should be present and it shouldn't have any additional or disabling of rules. Just content as { "extends": "dtslint/dt.json" }. If for reason the some rule need to be disabled, disable it for that line using // tslint:disable-next-line [ruleName] and not for whole package so that the need for disabling can be reviewed.
  • [ ] tsconfig.json should have noImplicitAny, noImplicitThis, strictNullChecks, and strictFunctionTypes set to true.

If changing an existing definition:

  • [X] Provide a URL to documentation or source code which provides context for the suggested changes: <https://developers.google.com/cast/docs/reference/caf_receiver/cast.framework#.VERSION>
  • [ ] If this PR brings the type definitions up to date with a new version of the JS library, update the version number in the header.
  • [ ] Include tests for your changes
  • [ ] If you are making substantial changes, consider adding a tslint.json containing { "extends": "dtslint/dt.json" }. If for reason the any rule need to be disabled, disable it for that line using // tslint:disable-next-line [ruleName] and not for whole package so that the need for disabling can be reviewed.

If removing a declaration:

  • [ ] If a package was never on Definitely Typed, you don't need to do anything. (If you wrote a package and provided types, you don't need to register it with us.)
  • [ ] Delete the package's directory.
  • [ ] Add it to notNeededPackages.json.
+5 -0

3 comments

1 changed file

tomhaines432

pr closed time in 2 days

push eventDefinitelyTyped/DefinitelyTyped

Konstantin Simeonov

commit sha c359932f9d8bc654f556522bef3409f025762d19

Add type definitions for guacamole-client package (#45949) * Add partial typedefs * More stuff * Fix typings and set up playground * More typings * Move files * Git ready for dee ploy mate * Add readme * Add stuff to readme * Add keywords * Type more stuff * Bump to 0.0.3 * Type a bunch of stuff in Display and others * Finish typedefs for layers * Bump version * Type more stuff * Split stuff in files * Bump version * Format with prettier * Add missing class defs * Aha * Fix constructor typings and add some missing defs * Finish guacamole typings * Fix most dtslint errors * Get rid of Function type * Add headers and fix config files * Get rid of npmignore * Improve tunnel typings * Fix tests

view details

push time in 2 days

PR merged DefinitelyTyped/DefinitelyTyped

Add type definitions for guacamole-client package New Definition

Definitions in this PR are based on:

  • JSDocs - http://guacamole.apache.org/doc/guacamole-common-js

  • Github mirror - https://github.com/apache/guacamole-client

  • NPM package - https://www.npmjs.com/package/guacamole-client

  • [x] Use a meaningful title for the pull request. Include the name of the package modified.

  • [x] Test the change in your own code. (Compile and run.)

  • [x] Add or edit tests to reflect the change. (Run with npm test.)

  • [x] Follow the advice from the readme.

  • [x] Avoid common mistakes.

  • [x] Run npm run lint package-name (or tsc if no tslint.json is present).

  • [x] The package does not already provide its own types, or cannot have its .d.ts files generated via --declaration

+3273 -0

2 comments

38 changed files

KonstantinSimeonov

pr closed time in 2 days

push eventDefinitelyTyped/DefinitelyTyped

Stuart

commit sha 1c70b92460aed972f25050f0c18e7735b979eb8a

[dockerode] Add types for exec instances (#45954)

view details

push time in 2 days

PR merged DefinitelyTyped/DefinitelyTyped

[dockerode] Add types for exec instances Author is Owner Owner Approved Perf: Same Untested Change

Please fill in this template.

  • [X] Use a meaningful title for the pull request. Include the name of the package modified.
  • [X] Test the change in your own code. (Compile and run.)
  • [ ] Add or edit tests to reflect the change. (Run with npm test.)
  • [X] Follow the advice from the readme.
  • [X] Avoid common mistakes.
  • [X] Run npm run lint package-name (or tsc if no tslint.json is present).

Select one of these and delete the others:

If changing an existing definition:

  • [X] Provide a URL to documentation or source code which provides context for the suggested changes:

  • Docker API: <https://docs.docker.com/engine/api/v1.40/#tag/Exec>

  • docker-modem: <https://github.com/apocas/dockerode/blob/master/lib/exec.js#L31>

  • [ ] If this PR brings the type definitions up to date with a new version of the JS library, update the version number in the header.

  • [ ] Include tests for your changes

  • [ ] If you are making substantial changes, consider adding a tslint.json containing { "extends": "dtslint/dt.json" }. If for reason the any rule need to be disabled, disable it for that line using // tslint:disable-next-line [ruleName] and not for whole package so that the need for disabling can be reviewed.

+49 -7

4 comments

1 changed file

stuartthomson

pr closed time in 2 days

push eventDefinitelyTyped/DefinitelyTyped

RomChung

commit sha a43602b59ef1b2faf5681fd74deeb20e32884393

Add type definition file for wechat-miniprogram (#45950) * Add wechat-miniprogram * Update type definition for wechat-miniprogram * Update index.d.ts * FIX * FIX * FIX * FIX * FIX * FIX * FIX * FIX * FIX * FIX * FIX * FIX * fix * FIX

view details

push time in 2 days

PR merged DefinitelyTyped/DefinitelyTyped

Add type definition file for wechat-miniprogram New Definition

Please fill in this template.

  • [X] Use a meaningful title for the pull request. Include the name of the package modified.
  • [X] Test the change in your own code. (Compile and run.)
  • [X] Add or edit tests to reflect the change. (Run with npm test.)
  • [X] Follow the advice from the readme.
  • [X] Avoid common mistakes.
  • [X] Run npm run lint package-name (or tsc if no tslint.json is present).

Select one of these and delete the others:

If adding a new definition:

  • [X] The package does not already provide its own types, or cannot have its .d.ts files generated via --declaration
  • [X] If this is for an NPM package, match the name. If not, do not conflict with the name of an NPM package.
  • [ ] Create it with dts-gen --dt, not by basing it on an existing project.
  • [ ] Represents shape of module/library correctly
  • [X] tslint.json should be present and it shouldn't have any additional or disabling of rules. Just content as { "extends": "dtslint/dt.json" }. If for reason the some rule need to be disabled, disable it for that line using // tslint:disable-next-line [ruleName] and not for whole package so that the need for disabling can be reviewed.
  • [X] tsconfig.json should have noImplicitAny, noImplicitThis, strictNullChecks, and strictFunctionTypes set to true.

If changing an existing definition:

  • [ ] Provide a URL to documentation or source code which provides context for the suggested changes: <<url here>>
  • [ ] If this PR brings the type definitions up to date with a new version of the JS library, update the version number in the header.
  • [ ] Include tests for your changes
  • [ ] If you are making substantial changes, consider adding a tslint.json containing { "extends": "dtslint/dt.json" }. If for reason the any rule need to be disabled, disable it for that line using // tslint:disable-next-line [ruleName] and not for whole package so that the need for disabling can be reviewed.

If removing a declaration:

  • [ ] If a package was never on Definitely Typed, you don't need to do anything. (If you wrote a package and provided types, you don't need to register it with us.)
  • [ ] Delete the package's directory.
  • [ ] Add it to notNeededPackages.json.
+20008 -0

4 comments

10 changed files

TtTRz

pr closed time in 2 days

push eventDefinitelyTyped/DefinitelyTyped

Bryce Barbara

commit sha 1d07531f7bce5810c9b374d88d38b94af2355321

Update getSorters to match actual functionality. (#45957)

view details

push time in 2 days

PR merged DefinitelyTyped/DefinitelyTyped

Update getSorters in tabulator-tables Owner Approved Perf: Same Untested Change
  • [x] Use a meaningful title for the pull request. Include the name of the package modified.
  • [x] Test the change in your own code. (Compile and run.)
  • [ ] Add or edit tests to reflect the change. (Run with npm test.)
  • [x] Follow the advice from the readme.
  • [x] Avoid common mistakes.
  • [ ] Run npm run lint package-name (or tsc if no tslint.json is present).

If changing an existing definition:

  • [x] Provide a URL to documentation or source code which provides context for the suggested changes: http://tabulator.info/docs/4.7/sort (scroll down to the "Get Current Sorters" section)
  • [ ] If this PR brings the type definitions up to date with a new version of the JS library, update the version number in the header.
  • [ ] Include tests for your changes
  • [ ] If you are making substantial changes, consider adding a tslint.json containing { "extends": "dtslint/dt.json" }. If for reason the any rule need to be disabled, disable it for that line using // tslint:disable-next-line [ruleName] and not for whole package so that the need for disabling can be reviewed.

This is a pretty straightforward change.

I wasn't able to run npm run lint due to only having access to use the github online editor right now. If that's a problem, I can definitely run it in the future when I regain access to my usual PC. Please let me know if there is anything else I need to do! 😊

+10 -1

4 comments

1 changed file

BryceBarbara

pr closed time in 2 days

push eventDefinitelyTyped/DefinitelyTyped

Maxim Mazurok

commit sha 7b92110590ffde7e5c3f12b556963413eb5d1fd3

automatic gapi.client.classroom update @ Fri, 10 Jul 2020 14:16:12 GMT (#45961)

view details

push time in 2 days

PR merged DefinitelyTyped/DefinitelyTyped

[gapi.client.classroom] automatic update Author is Owner No Other Owners Perf: Same Untested Change
  • [x] Use a meaningful title for the pull request. Include the name of the package modified.
  • [x] Test the change in your own code. (Compile and run.)
  • [x] Add or edit tests to reflect the change. (Run with npm test.)
  • [x] Follow the advice from the readme.
  • [x] Avoid common mistakes.
  • [x] Run npm run lint package-name (or tsc if no tslint.json is present).

Select one of these and delete the others:

If changing an existing definition:

  • [x] Provide a URL to documentation or source code which provides context for the suggested changes: https://github.com/Maxim-Mazurok/google-api-typings-generator#google-api-typings-generator
  • [x] If this PR brings the type definitions up to date with a new version of the JS library, update the version number in the header.
  • [x] Include tests for your changes
  • [x] If you are making substantial changes, consider adding a tslint.json containing { "extends": "dtslint/dt.json" }. If for reason the any rule need to be disabled, disable it for that line using // tslint:disable-next-line [ruleName] and not for whole package so that the need for disabling can be reviewed.

🤖 This pull request was automatically created by Maxim-Mazurok/google-api-typings-generator which generates types from Google API Discovery Service. Types were linted and tested before submission.

If there is an issue with this pull request, consider submitting a new issue.

Note you can also use these types from our types branch which is updated hourly.

+5 -4

2 comments

1 changed file

Maxim-Mazurok

pr closed time in 2 days

push eventDefinitelyTyped/DefinitelyTyped

brlam

commit sha 9da2f8a40a21853dc4068a931d4c4f5f42e71f50

Fix issues in chrome/chrome-cast typings (#45962) - Fixed some deviations from official documentation (https://developers.google.com/cast/docs/reference/chrome): - chrome.cast.ApiConfig: autojoinPolicy field is non-optional and non-nullable. - chrome.cast.Error: description field is non-optional and nullable. - chrome.cast.Error: details field is an non-optional and non-nullable Object. - chrome.cast.Image: height and width fields are non-optional and nullable. - chrome.cast.SenderApplication: url and packageId fields are non-optional and nullable. - chrome.cast.SessionRequest: language field is a non-optional and nullable. - chrome.cast.Session: Added statusText and transportId fields. - chrome.cast.Volume: level and muted fields are non-optional and nullable. - chrome.cast.media.Media: idleReason field is nullable.

view details

push time in 2 days

PR merged DefinitelyTyped/DefinitelyTyped

Fix issues in chrome/chrome-cast typings Perf: Same Popular package Untested Change
  • Fixed some deviations from official documentation (https://developers.google.com/cast/docs/reference/chrome):
    • chrome.cast.ApiConfig: autojoinPolicy field is non-optional and non-nullable.
    • chrome.cast.Error: description field is non-optional and nullable.
    • chrome.cast.Error: details field is an non-optional and non-nullable Object.
    • chrome.cast.Image: height and width fields are non-optional and nullable.
    • chrome.cast.SenderApplication: url and packageId fields are non-optional and nullable.
    • chrome.cast.SessionRequest: language field is a non-optional and nullable.
    • chrome.cast.Session: Added statusText and transportId fields.
    • chrome.cast.Volume: level and muted fields are non-optional and nullable.
    • chrome.cast.media.Media: idleReason field is nullable.

Please fill in this template.

  • [x] Use a meaningful title for the pull request. Include the name of the package modified.
  • [x] Test the change in your own code. (Compile and run.)
  • [ ] Add or edit tests to reflect the change. (Run with npm test.)
  • [ ] Follow the advice from the readme.
  • [x] Avoid common mistakes.
  • [ ] Run npm run lint package-name (or tsc if no tslint.json is present).

If changing an existing definition:

  • [x] Provide a URL to documentation or source code which provides context for the suggested changes: https://developers.google.com/cast/docs/reference/chrome
  • [ ] If this PR brings the type definitions up to date with a new version of the JS library, update the version number in the header.
  • [ ] Include tests for your changes
  • [ ] If you are making substantial changes, consider adding a tslint.json containing { "extends": "dtslint/dt.json" }. If for reason the any rule need to be disabled, disable it for that line using // tslint:disable-next-line [ruleName] and not for whole package so that the need for disabling can be reviewed.
+14 -12

3 comments

1 changed file

brlam

pr closed time in 2 days

PR merged DefinitelyTyped/DefinitelyTyped

Improve deprecated reasons for @types/node Critical package Owner Approved Perf: Same Untested Change

Please fill in this template.

  • [X] Use a meaningful title for the pull request. Include the name of the package modified.
  • [X] Test the change in your own code. (Compile and run.)
  • [X] Add or edit tests to reflect the change. (Run with npm test.)
  • [X] Follow the advice from the readme.
  • [X] Avoid common mistakes.
  • [X] Run npm run lint package-name (or tsc if no tslint.json is present).

Select one of these and delete the others:

If changing an existing definition:

  • [X] Provide a URL to documentation or source code which provides context for the suggested changes: https://nodejs.org/api/fs.html#fs_fs_exists_path_callback

  • [X] If this PR brings the type definitions up to date with a new version of the JS library, update the version number in the header.

  • [ ] Include tests for your changes

  • [ ] If you are making substantial changes, consider adding a tslint.json containing { "extends": "dtslint/dt.json" }. If for reason the any rule need to be disabled, disable it for that line using // tslint:disable-next-line [ruleName] and not for whole package so that the need for disabling can be reviewed.

  • Adds a few missing messages on deprecated apis about which alternatives to use

  • Marks code references in deprecated messages with markdown backticks

/cc @DanielRosenwasser

+15 -15

3 comments

6 changed files

mjbvz

pr closed time in 2 days

push eventDefinitelyTyped/DefinitelyTyped

Matt Bierner

commit sha ab8cb3f97439fa5a630b09d6b16991c1b81251df

Improve deprecated reasons for @types/node (#45965) - Adds a few missing messages on deprecated apis about which alternatives to use - Marks code references in deprecated messages with markdown backticks

view details

push time in 2 days

push eventDefinitelyTyped/DefinitelyTyped

notchairmk

commit sha e39b0ad3bbd90d7db3a2587266afaee8fd5e095b

[@types/hapi__joi]: fix SchemaInternals.$_getRule return type (#45552) * Adds GetRuleOptions type * Fixes return type of SchemaInternal.$_getRule to return optional GetRuleOptions object, previously array

view details

push time in 2 days

PR merged DefinitelyTyped/DefinitelyTyped

Reviewers
[@types/hapi__joi]: fix SchemaInternals.$_getRule return type Merge:Auto Merge:YSYL Owner Approved Perf: Same Popular package

Please fill in this template.

  • [x] Use a meaningful title for the pull request. Include the name of the package modified.
  • [x] Test the change in your own code. (Compile and run.)
  • [x] Add or edit tests to reflect the change. (Run with npm test.)
  • [x] Follow the advice from the readme.
  • [x] Avoid common mistakes.
  • [x] Run npm run lint package-name (or tsc if no tslint.json is present).

If changing an existing definition:

  • [x] Provide a URL to documentation or source code which provides context for the suggested changes: https://github.com/hapijs/joi/blob/b3728a27513f88469022183814a8c4416ee709b1/lib/base.js#L374-L380
  • [ ] If this PR brings the type definitions up to date with a new version of the JS library, update the version number in the header.
  • [x] Include tests for your changes
  • [ ] If you are making substantial changes, consider adding a tslint.json containing { "extends": "dtslint/dt.json" }. If for reason the any rule need to be disabled, disable it for that line using // tslint:disable-next-line [ruleName] and not for whole package so that the need for disabling can be reviewed.
+15 -1

7 comments

2 changed files

notchairmk

pr closed time in 2 days

PR merged DefinitelyTyped/DefinitelyTyped

`http-errors`: add support for new `isHttpError` Merge:YSYL Perf: Worse Popular package

Please fill in this template.

  • [x] Use a meaningful title for the pull request. Include the name of the package modified.
  • [x] Test the change in your own code. (Compile and run.)
  • [x] Add or edit tests to reflect the change. (Run with npm test.)
  • [x] Follow the advice from the readme.
  • [x] Avoid common mistakes.
  • [x] Run npm run lint package-name (or tsc if no tslint.json is present).

Select one of these and delete the others:

If changing an existing definition:

  • [x] Provide a URL to documentation or source code which provides context for the suggested changes: https://github.com/jshttp/http-errors#createerrorishttperrorval
  • [x] If this PR brings the type definitions up to date with a new version of the JS library, update the version number in the header.
  • [x] Include tests for your changes
  • [ ] If you are making substantial changes, consider adding a tslint.json containing { "extends": "dtslint/dt.json" }. If for reason the any rule need to be disabled, disable it for that line using // tslint:disable-next-line [ruleName] and not for whole package so that the need for disabling can be reviewed.
+10 -2

4 comments

2 changed files

OliverJAsh

pr closed time in 2 days

push eventDefinitelyTyped/DefinitelyTyped

Oliver Joseph Ash

commit sha 1fcf2f98a0780ef141bdb15bc1cf124318af53d5

`http-errors`: add support for new `isHttpError` (#45773) * `http-errors`: add support for new `isHttpError` Added in: - https://github.com/jshttp/http-errors/commit/e11f87db72bec8b3c457cf0e3df9e0cbb09c7e62 - https://github.com/jshttp/http-errors/releases/tag/1.8.0 Docs: https://github.com/jshttp/http-errors#createerrorishttperrorval * Bump

view details

push time in 2 days

push eventDefinitelyTyped/DefinitelyTyped

Connor Fitzgerald

commit sha 50ea9a24c0a911775346dc677b15d5cbe7869b53

Upgrade oracledb to 5.0 (#45781) * Allow undefined bind parameters * Upgrading oracledbto 4.1 * Update version number * Fix tsconfig typo * Make DBObject generic * increase min ts version to 3.5 * Upgrade oracledb to v5.0 * update oracledb version number

view details

push time in 2 days

PR merged DefinitelyTyped/DefinitelyTyped

Upgrade oracledb to 5.0 Author is Owner Merge:YSYL Perf: Same

Please fill in this template.

  • [X] Use a meaningful title for the pull request. Include the name of the package modified.

  • [X] Test the change in your own code. (Compile and run.)

  • [X] Add or edit tests to reflect the change. (Run with npm test.)

  • [X] Follow the advice from the readme.

  • [X] Avoid common mistakes.

  • [X] Run npm run lint package-name (or tsc if no tslint.json is present).

  • [X] Provide a URL to documentation or source code which provides context for the suggested changes: <https://github.com/oracle/node-oracledb/blob/master/CHANGELOG.md>

  • [X] If this PR brings the type definitions up to date with a new version of the JS library, update the version number in the header.

  • [X] Include tests for your changes

  • [X] If you are making substantial changes, consider adding a tslint.json containing { "extends": "dtslint/dt.json" }. If for reason the any rule need to be disabled, disable it for that line using // tslint:disable-next-line [ruleName] and not for whole package so that the need for disabling can be reviewed.

+326 -11

3 comments

2 changed files

connorjayfitzgerald

pr closed time in 2 days

push eventDefinitelyTyped/DefinitelyTyped

Piotr Błażejewicz (Peter Blazejewicz)

commit sha 1c9097afc5048b8411767189454ef46e0951b704

update(auth0-js): WebAuth.checkSession minor changes (#45785) From 9.13.* version: - correct parameter name (`callback` => `cb`) to match original source - add JSDoc external link for common use case (token refresh) - udpate tests to cover token refresh code (requiring empty options object) Ref: https://github.com/auth0/auth0.js/compare/v9.13.2...v9.13.3 Thanks!

view details

push time in 2 days

PR merged DefinitelyTyped/DefinitelyTyped

update(auth0-js): WebAuth.checkSession minor changes Author is Owner Merge:YSYL Perf: Worse Popular package

From 9.13.* version:

  • correct parameter name (callback => cb) to match original source
  • add JSDoc external link for common use case (token refresh)
  • udpate tests to cover token refresh code (requiring empty options object)

Ref: https://github.com/auth0/auth0.js/compare/v9.13.2...v9.13.3

Thanks!

  • [x] Use a meaningful title for the pull request. Include the name of the package modified.
  • [x] Test the change in your own code. (Compile and run.)
  • [x] Add or edit tests to reflect the change. (Run with npm test.)
+12 -2

4 comments

2 changed files

peterblazejewicz

pr closed time in 2 days

push eventDefinitelyTyped/DefinitelyTyped

Shrey Banga

commit sha 5777f5675a8107ca47b266a5877aea99286191ab

mailgun-js: fix type of recipient-variables (#45789) I think the type here is mistakenly fixed to the example in https://documentation.mailgun.com/en/latest/user_manual.html#batch-sending which uses `first` and `id` as example variables, but `recipient-variables` should allow any variable names to be used.

view details

push time in 2 days

PR merged DefinitelyTyped/DefinitelyTyped

mailgun-js: fix type of recipient-variables Merge:YSYL Perf: Same

I think the type here is mistakenly fixed to the example in https://documentation.mailgun.com/en/latest/user_manual.html#batch-sending which uses first and id as example variables, but recipient-variables should allow any variable names to be used. Moreover, the library also allows stringified values to be passed in directly, so a string is also valid here.

Please fill in this template.

  • [x] Use a meaningful title for the pull request. Include the name of the package modified.
  • [x] Test the change in your own code. (Compile and run.)
  • [x] Add or edit tests to reflect the change. (Run with npm test.)
  • [x] Follow the advice from the readme.
  • [x] Avoid common mistakes.
  • [x] Run npm run lint package-name (or tsc if no tslint.json is present).

Select one of these and delete the others:

If changing an existing definition:

  • [x] Provide a URL to documentation or source code which provides context for the suggested changes: https://documentation.mailgun.com/en/latest/user_manual.html#batch-sending
  • [ ] If this PR brings the type definitions up to date with a new version of the JS library, update the version number in the header.
  • [x] Include tests for your changes
  • [ ] If you are making substantial changes, consider adding a tslint.json containing { "extends": "dtslint/dt.json" }. If for reason the any rule need to be disabled, disable it for that line using // tslint:disable-next-line [ruleName] and not for whole package so that the need for disabling can be reviewed.
+30 -5

3 comments

2 changed files

banga

pr closed time in 2 days

push eventDefinitelyTyped/DefinitelyTyped

Shrey Banga

commit sha c26ebfd1fe1527ef985ff2147594ba5afc1844ae

mailgun-js: update generic request method types (#45790) * mailgun-js: fix type of recipient-variables I think the type here is mistakenly fixed to the example in https://documentation.mailgun.com/en/latest/user_manual.html#batch-sending which uses `first` and `id` as example variables, but `recipient-variables` should allow any variable names to be used. * Update request types

view details

push time in 2 days

PR merged DefinitelyTyped/DefinitelyTyped

mailgun-js: update generic request method types Merge:YSYL Perf: Same

The generic request methods support a variety of signatures, as can be seen here: https://github.com/highlycaffeinated/mailgun-js/blob/a1cd9a5ef1001e39fb6480d844d5e8f9699cc571/lib/request.js#L152-L161. This updates the types to match this behavior.

  • [x] Use a meaningful title for the pull request. Include the name of the package modified.
  • [x] Test the change in your own code. (Compile and run.)
  • [x] Add or edit tests to reflect the change. (Run with npm test.)
  • [x] Follow the advice from the readme.
  • [x] Avoid common mistakes.
  • [x] Run npm run lint package-name (or tsc if no tslint.json is present).

Select one of these and delete the others:

If changing an existing definition:

  • [x] Provide a URL to documentation or source code which provides context for the suggested changes: https://github.com/highlycaffeinated/mailgun-js/blob/a1cd9a5ef1001e39fb6480d844d5e8f9699cc571/lib/request.js#L152-L161
  • [ ] If this PR brings the type definitions up to date with a new version of the JS library, update the version number in the header.
  • [x] Include tests for your changes
  • [ ] If you are making substantial changes, consider adding a tslint.json containing { "extends": "dtslint/dt.json" }. If for reason the any rule need to be disabled, disable it for that line using // tslint:disable-next-line [ruleName] and not for whole package so that the need for disabling can be reviewed.
+35 -7

3 comments

2 changed files

banga

pr closed time in 2 days

push eventDefinitelyTyped/DefinitelyTyped

Sebastian Silbermann

commit sha 1cdcf67387349c8e76e4a0722aef368648e78d86

docs(react): Link better explanation for non-generic target (#45663)

view details

push time in 2 days

PR merged DefinitelyTyped/DefinitelyTyped

Reviewers
docs(react): Link better explanation for non-generic target Author is Owner Critical package Owner Approved Perf: Same Untested Change

JSDOC is visible in vscode.

The current link is not very helpful immediately and requires some navigating of linked prs/issues. At some point you land on https://github.com/DefinitelyTyped/DefinitelyTyped/issues/11508#issuecomment-256045682 which is in my opinion a better explanation. Especially because the very first sentence relates to the issue ("generic target").

+1 -1

5 comments

1 changed file

eps1lon

pr closed time in 2 days

push eventDefinitelyTyped/DefinitelyTyped

Joachim Van Herwegen

commit sha ffb4ece5e651770a25d87905bcbe4aec7b2cf687

Add joachimvh as contributor to N3.js (#45968)

view details

push time in 2 days

PR merged DefinitelyTyped/DefinitelyTyped

Add joachimvh as contributor to N3.js Owner Approved Perf: Same Untested Change

This is simply a change to add myself to the contributors so I can help maintain new changes.

Please fill in this template.

  • [X] Use a meaningful title for the pull request. Include the name of the package modified.
  • [X] Test the change in your own code. (Compile and run.)
  • [ ] Add or edit tests to reflect the change. (Run with npm test.)
  • [X] Follow the advice from the readme.
  • [X] Avoid common mistakes.
  • [X] Run npm run lint package-name (or tsc if no tslint.json is present).

Select one of these and delete the others:

If changing an existing definition:

  • [ ] Provide a URL to documentation or source code which provides context for the suggested changes: <<url here>>
  • [ ] If this PR brings the type definitions up to date with a new version of the JS library, update the version number in the header.
  • [ ] Include tests for your changes
  • [ ] If you are making substantial changes, consider adding a tslint.json containing { "extends": "dtslint/dt.json" }. If for reason the any rule need to be disabled, disable it for that line using // tslint:disable-next-line [ruleName] and not for whole package so that the need for disabling can be reviewed.
+1 -0

4 comments

1 changed file

joachimvh

pr closed time in 2 days

push eventDefinitelyTyped/DefinitelyTyped

SteveBunlon

commit sha 575459d20447fcfa2b0e8483cde6dbd2889dde18

add forest-express package types (#45970)

view details

push time in 2 days

PR merged DefinitelyTyped/DefinitelyTyped

add forest-express[sequelize | mongoose] packages types Edits multiple packages New Definition

Please fill in this template.

  • [x] Use a meaningful title for the pull request. Include the name of the package modified.
  • [x] Test the change in your own code. (Compile and run.)
  • [x] Add or edit tests to reflect the change. (Run with npm test.)
  • [x] Follow the advice from the readme.
  • [x] Avoid common mistakes.
  • [x] Run npm run lint package-name (or tsc if no tslint.json is present).

Select one of these and delete the others:

If adding a new definition:

  • [x] The package does not already provide its own types, or cannot have its .d.ts files generated via --declaration
  • [x] If this is for an NPM package, match the name. If not, do not conflict with the name of an NPM package.
  • [x] Create it with dts-gen --dt, not by basing it on an existing project.
  • [x] Represents shape of module/library correctly
  • [x] tslint.json should be present and it shouldn't have any additional or disabling of rules. Just content as { "extends": "dtslint/dt.json" }. If for reason the some rule need to be disabled, disable it for that line using // tslint:disable-next-line [ruleName] and not for whole package so that the need for disabling can be reviewed.
  • [x] tsconfig.json should have noImplicitAny, noImplicitThis, strictNullChecks, and strictFunctionTypes set to true.
+442 -0

4 comments

8 changed files

SteveBunlon

pr closed time in 2 days

push eventDefinitelyTyped/DefinitelyTyped

Tomasz Pluskiewicz

commit sha 98ee4c56b2db83e1613c6a93018a874c76bf1f72

rdf-js: immutable methods cannot return this (#45720) * rdf-js: immutable methods cannot return this * add tests

view details

push time in 2 days

PR merged DefinitelyTyped/DefinitelyTyped

rdf-js: immutable methods cannot return this Author is Owner Edits multiple packages Perf: Same

Dataset methods which return a new instance have to return the actual type.

Please fill in this template.

  • [x] Use a meaningful title for the pull request. Include the name of the package modified.
  • [x] Test the change in your own code. (Compile and run.)
  • [x] Add or edit tests to reflect the change. (Run with npm test.)
  • [x] Follow the advice from the readme.
  • [x] Avoid common mistakes.
  • [x] Run npm run lint package-name (or tsc if no tslint.json is present).

Select one of these and delete the others:

If changing an existing definition:

  • [x] Provide a URL to documentation or source code which provides context for the suggested changes: https://gitter.im/rdfjs/public?at=5ef507a56c06cd1bf4548898
  • [x] If this PR brings the type definitions up to date with a new version of the JS library, update the version number in the header.
  • [x] Include tests for your changes
  • [x] If you are making substantial changes, consider adding a tslint.json containing { "extends": "dtslint/dt.json" }. If for reason the any rule need to be disabled, disable it for that line using // tslint:disable-next-line [ruleName] and not for whole package so that the need for disabling can be reviewed.
+131 -7

4 comments

4 changed files

tpluscode

pr closed time in 2 days

push eventDefinitelyTyped/DefinitelyTyped

Tom Plant

commit sha 4c835028430064ce2bcec72b7f8e35b0258cfb0d

Add @types/objects-to-csv (#45973) * Added types for objects-to-csv * removed leftover type * Updated after running npm test properly

view details

push time in 2 days

PR merged DefinitelyTyped/DefinitelyTyped

Add @types/objects-to-csv New Definition
  • [x] Use a meaningful title for the pull request. Include the name of the package modified.
  • [x] Test the change in your own code. (Compile and run.)
  • [x] Add or edit tests to reflect the change. (Run with npm test.)
  • [x] Follow the advice from the readme.
  • [x] Avoid common mistakes.
  • [x] Run npm run lint package-name (or tsc if no tslint.json is present).
  • [x] The package does not already provide its own types, or cannot have its .d.ts files generated via --declaration
  • [x] If this is for an NPM package, match the name. If not, do not conflict with the name of an NPM package.
  • [x] Create it with dts-gen --dt, not by basing it on an existing project.
  • [x] Represents shape of module/library correctly
  • [x] tslint.json should be present and it shouldn't have any additional or disabling of rules. Just content as { "extends": "dtslint/dt.json" }. If for reason the some rule need to be disabled, disable it for that line using // tslint:disable-next-line [ruleName] and not for whole package so that the need for disabling can be reviewed.
  • [x] tsconfig.json should have noImplicitAny, noImplicitThis, strictNullChecks, and strictFunctionTypes set to true.
+91 -0

3 comments

4 changed files

pl4nty

pr closed time in 2 days

push eventDefinitelyTyped/DefinitelyTyped

Tim Baumann

commit sha de475b6d82b5e3645daaaf8b84b1948f49bf62d0

prosemirror-commands: Fix Command type (#45972) The 'dispatch' and 'view' arguments must be optional to support 'dry runs'. Also add doc comment for 'Command' type by copying relevant the part from the ProseMirror documentation. Also simplify type definition of 'chainCommands' using 'Command'.

view details

push time in 2 days

PR merged DefinitelyTyped/DefinitelyTyped

prosemirror-commands: Fix Command type Author is Owner Edits multiple packages Owner Approved Perf: Same

The 'dispatch' and 'view' arguments must be optional to support 'dry runs'.

Also add doc comment for 'Command' type by copying relevant the part from the ProseMirror documentation.

Also simplify type definition of 'chainCommands' using 'Command'.

Please fill in this template.

  • [x] Use a meaningful title for the pull request. Include the name of the package modified.
  • [ ] Test the change in your own code. (Compile and run.)
  • [x] Add or edit tests to reflect the change. (Run with npm test.)
  • [x] Follow the advice from the readme.
  • [x] Avoid common mistakes.
  • [x] Run npm run lint package-name (or tsc if no tslint.json is present).

If changing an existing definition:

  • [x] Provide a URL to documentation or source code which provides context for the suggested changes: ProseMirror docs, discussion in PR which added the Command interface
  • [x] If this PR brings the type definitions up to date with a new version of the JS library, update the version number in the header.
  • [x] Include tests for your changes
  • [ ] If you are making substantial changes, consider adding a tslint.json containing { "extends": "dtslint/dt.json" }. If for reason the any rule need to be disabled, disable it for that line using // tslint:disable-next-line [ruleName] and not for whole package so that the need for disabling can be reviewed.
+21 -9

7 comments

3 changed files

timjb

pr closed time in 2 days

push eventDefinitelyTyped/DefinitelyTyped

kyriiherman

commit sha 2bcb0b9260756d26ab85db1d7a1749ae0cd690e9

#45975 fix AutocompletePrediction typings (#45976)

view details

push time in 2 days

PR merged DefinitelyTyped/DefinitelyTyped

#45975 fix AutocompletePrediction typings Perf: Same Popular package Untested Change

Please fill in this template. Closes #45975. Package: @types/googlemaps.

+1 -1

4 comments

1 changed file

kyriiherman

pr closed time in 2 days

issue closedDefinitelyTyped/DefinitelyTyped

types/googlemaps -> places-autocomplete-service.d.ts: id is optional in AutocompletePrediction model

I can't find any documentation that can prove that id is might be absent, but I have screenshot with response without id (first item in collection), search query is "Maluku". Screenshot 2020-07-09 at 16 34 31

closed time in 2 days

kyriiherman

push eventDefinitelyTyped/DefinitelyTyped

Nikita Volodin

commit sha 0caab4f807dc787abe0308e2548709e609b3ba82

Export config interfaces (#45980)

view details

push time in 2 days

PR merged DefinitelyTyped/DefinitelyTyped

[rascal] Export config interfaces Owner Approved Perf: Same Untested Change

Just exporting configuration interfaces so that it is easier to write wrappers of provided functions.

  • [x] Use a meaningful title for the pull request. Include the name of the package modified.
  • [x] Test the change in your own code. (Compile and run.)
  • [ ] Add or edit tests to reflect the change. (Run with npm test.)
  • [x] Follow the advice from the readme.
  • [x] Avoid common mistakes.
  • [x] Run npm run lint package-name (or tsc if no tslint.json is present).

If changing an existing definition:

  • [ ] Provide a URL to documentation or source code which provides context for the suggested changes: <<url here>>
  • [ ] If this PR brings the type definitions up to date with a new version of the JS library, update the version number in the header.
  • [ ] Include tests for your changes
  • [ ] If you are making substantial changes, consider adding a tslint.json containing { "extends": "dtslint/dt.json" }. If for reason the any rule need to be disabled, disable it for that line using // tslint:disable-next-line [ruleName] and not for whole package so that the need for disabling can be reviewed.
+14 -13

5 comments

1 changed file

qlonik

pr closed time in 2 days

push eventDefinitelyTyped/DefinitelyTyped

Dasa Paddock

commit sha 0d4dbb9762709e22ae41a5d6c33a02e540aed24b

Update for ArcGIS API for JavaScript version 4.16 (#45983)

view details

push time in 2 days

PR merged DefinitelyTyped/DefinitelyTyped

[arcgis-js-api] Update for version 4.16 Owner Approved Perf: Same Untested Change

Please fill in this template.

  • [x] Use a meaningful title for the pull request. Include the name of the package modified.
  • [x] Test the change in your own code. (Compile and run.)
  • [ ] Add or edit tests to reflect the change. (Run with npm test.)
  • [x] Follow the advice from the readme.
  • [x] Avoid common mistakes.
  • [x] Run npm run lint package-name (or tsc if no tslint.json is present).

If changing an existing definition:

  • [x] Provide a URL to documentation or source code which provides context for the suggested changes: https://developers.arcgis.com/javascript/latest/guide/release-notes/
  • [x] If this PR brings the type definitions up to date with a new version of the JS library, update the version number in the header.
  • [ ] Include tests for your changes
  • [ ] If you are making substantial changes, consider adding a tslint.json containing { "extends": "dtslint/dt.json" }. If for reason the any rule need to be disabled, disable it for that line using // tslint:disable-next-line [ruleName] and not for whole package so that the need for disabling can be reviewed.
+18030 -12525

3 comments

1 changed file

dasa

pr closed time in 2 days

more