profile
viewpoint
Andre Weinand weinand Microsoft Zurich, Switzerland http://code.visualstudio.com

microsoft/vscode-node-debug 189

A VS Code debug adapter for node

microsoft/vscode-debugadapter-node 145

Debug adapter protocol and implementation for VS Code.

microsoft/vscode-mock-debug 124

Starter sample for developing debug adapters for VSCode.

microsoft/vscode-mono-debug 106

A simple VS Code debug adapter for mono

weinand/vscode-processes 104

Provide access to all VS Code child processes

weinand/vscode-auto-attach 3

Automatically attach to node.js processes launched from VS Code

weinand/golang-vscode 1

docker image with golang and vscode

weinand/server-ready 1

Open uri if server under debugging is ready

weinand/applescript-json 0

AppleScript JSON encoder

pull request commentmicrosoft/vscode

debug: use previous node debug for auto attach in the the July release

@roblourens thanks for reviewing and approving this. @connor4312 I'm on vacation right now and only an iPad. The code looks good but I could not run it...

connor4312

comment created time in 13 hours

issue commentmicrosoft/vscode

envFile support in launch.json not working with input variable reference

Yes, "envFile" is a feature of the node debugger whereas ${} variables are substituted before the node debugger runs.

PaulGrimshaw

comment created time in 13 hours

issue closedmicrosoft/vscode

vscode print too much log on terminal

--- Truncated to last 15 messages, set outputCapture to 'all' to see more ---
Fri, 10 Jul 2020 03:31:38 GMT express:application set "subdomain offset" to 2
Fri, 10 Jul 2020 03:31:38 GMT express:application set "trust proxy" to false
Fri, 10 Jul 2020 03:31:38 GMT express:application set "trust proxy fn" to [Function: trustNone]
Fri, 10 Jul 2020 03:31:38 GMT express:application booting in development mode
Fri, 10 Jul 2020 03:31:38 GMT express:application set "view" to [Function: View]
Fri, 10 Jul 2020 03:31:38 GMT express:application set "views" to '/Users/yilikun/test/logOutput/views'
Fri, 10 Jul 2020 03:31:38 GMT express:application set "jsonp callback name" to 'callback'
Fri, 10 Jul 2020 03:31:38 GMT express:router use '/' query
Fri, 10 Jul 2020 03:31:38 GMT express:router:layer new '/'
Fri, 10 Jul 2020 03:31:38 GMT express:router use '/' expressInit
Fri, 10 Jul 2020 03:31:38 GMT express:router:layer new '/'
Fri, 10 Jul 2020 03:31:38 GMT express:router:route new '/'
Fri, 10 Jul 2020 03:31:38 GMT express:router:layer new '/'
Fri, 10 Jul 2020 03:31:38 GMT express:router:route get '/'
Fri, 10 Jul 2020 03:31:38 GMT express:router:layer new '/'
Process exited with code null
/usr/local/bin/node /Users/yilikun/test/logOutput/index.js
Debugger listening on ws://127.0.0.1:53698/1af20b06-4623-4f24-9595-14c0d872809a
For help, see: https://nodejs.org/en/docs/inspector
Debugger attached.

when I debug with setting:

{
  // Use IntelliSense to learn about possible attributes.
  // Hover to view descriptions of existing attributes.
  // For more information, visit: https://go.microsoft.com/fwlink/?linkid=830387
  "version": "0.2.0",
  "configurations": [
    {
      "type": "node",
      "request": "launch",
      "name": "Launch Program",
      "program": "${workspaceFolder}/index.js",
    }
  ]
}

please help me, I have been troubled by this problem for a long time. i had google it and look for help in github issues. oh my god, i can not post this problem. Got same issue with same vscode version but on mac.

closed time in 13 hours

yilikunNEO

issue commentmicrosoft/vscode

vscode print too much log on terminal

I'm not aware that VS Code sets the env variable DEBUG. I'm not seeing this with a plain VS Code.

Please try to clear the DEBUG env variable by setting it to "null":

   {
      "type": "node",
      "request": "launch",
      "name": "Launch Program",
      "program": "${workspaceFolder}/index.js",
      "env": {
          "DEBUG": null
      }
    }
yilikunNEO

comment created time in 13 hours

issue commentmicrosoft/vscode

Debugger stops on hot reload for Flask in debugger

Please file against "docker" debugger.

melvinkokxw

comment created time in 3 days

issue commentmicrosoft/vscode

Debugger highlights the wrong line when stopping if word wrap is present higher up in file

No, VS Code knows nothing about Python (or any other language). All language specific functionality is provided by extensions.

LightCC

comment created time in 3 days

issue commentmicrosoft/vscode

Consider adding a mechanism akin to .NET's 'DebuggerTypeProxyAttribute' for JS/TS debugging

If I understand this feature request correctly, you are asking for more debug extension API for controlling the generic debugger UI in VS Code, right? And this would not be used by an end user, but by an debug extension developer?

rbuckton

comment created time in 3 days

issue commentmicrosoft/vscode

SERVERLESS Debugger don't attach #bug #serverless #aws

Sorry, but the npm script only shows how you start your program in debug mode.

It does not show how you actually debug this in VS Code. Are you using a launch configuration (in launch.json) or are you using the "autoattach" feature?

henriquetgoncalves

comment created time in 3 days

issue commentmicrosoft/vscode

SERVERLESS Debugger don't attach #bug #serverless #aws

How does your bug configuration (launch.json) looks like?

henriquetgoncalves

comment created time in 3 days

issue commentmicrosoft/vscode

SERVERLESS Debugger don't attach #bug #serverless #aws

If you want us to look into your issue you will have to provide reproducible steps. Based on your initial description I have no clue what this issue is all about and how to reproduce it.

In addition I don't understand why you went back to VS Code 1.42 if the issues occurred in 1.47. A more sensible step would be to go back to 1.46, right?

henriquetgoncalves

comment created time in 3 days

issue commentmicrosoft/vscode

SERVERLESS Debugger don't attach #bug #serverless #aws

Sorry, but this functionality is not VS Code's built-in functionality. This must be some extension your are using. Please file this issue against this extension.

henriquetgoncalves

comment created time in 4 days

issue commentmicrosoft/vscode

SERVERLESS Debugger don't attach #bug #serverless #aws

What serverless debugger are you using?

henriquetgoncalves

comment created time in 4 days

issue commentmicrosoft/vscode

Extension Development Host can't open when selecting Chinese as language

Just open the Chrome devtools in VS Code before pressing F5

mfkwgizhoujian

comment created time in 4 days

issue commentmicrosoft/vscode

Cannot start debugging electron app on MacOS

Workaround is to use the old node-debug with this setting: "debug.javascript.usePreview": false

lini

comment created time in 4 days

issue commentmicrosoft/vscode

Extension Development Host can't open when selecting Chinese as language

@bpasero no, Chrome DevConsole is all we have...

mfkwgizhoujian

comment created time in 4 days

issue commentmicrosoft/vscode

Extension Development Host can't open when selecting Chinese as language

Chrome DevConsole shows a (harmless) 1000ms timeout for the new JS debug.

mfkwgizhoujian

comment created time in 4 days

issue commentmicrosoft/vscode

Extension Development Host can't open when selecting Chinese as language

I cannot reproduce.

What I did:

  • created Hello Word extension
  • installed "Chinese (Simplified) Language Pack for Visual Studio Code"
  • restarted VS Code
  • ran "Configure Display Language" and switched to "zn-cn"
  • restarted VS Code
  • F5

Result: 2020-07-10_12-12-51

Do I have to switch the OS to Chinese as well?

mfkwgizhoujian

comment created time in 4 days

issue closedmicrosoft/vscode

"Run without Debugging" causes "Start Debugging" to no longer run with debugging

This one has been puzzling me for a few days! This happens with all debuggers - VS Code is incorrectly passing noDebug: true for a debug session if it was previously run without debugging.

To repro:

  • create a simple JS script:
    console.log('test');
    
  • Add a breakpoint and click Run -> Start Debugging and the breakpoint will be hit (correct)
  • Run again with Run -> Run Without Debugging and the breakpoint will not be hit (correct)
  • Run aagin with Run -> Start Debugging and the breakpoint will not be hit (incorrect)

@isidorn unsure if this is at all related to #100364 (seems like an opposite problem, perhaps related to the fix?)

closed time in 5 days

DanTup

issue commentmicrosoft/vscode

Debug session ends but orphans extension host window

For extension host debugging we (debug UI) don't take down the window. We just terminate the node.js instance (the extension host) and that triggers some workbench code that closes the window.

@bpasero where is the code that shuts down the window in this case?

connor4312

comment created time in 5 days

issue commentmicrosoft/vscode

Launch fails if launch config type is a platform-specific property

@chausner I've added this note to the, doc: https://github.com/microsoft/vscode-docs/commit/53f9b3b976d7c04791e7bf7009164bb5ccfd81b1

/cc @gregvanl fyi

chausner

comment created time in 5 days

push eventmicrosoft/vscode-docs

Andre Weinand

commit sha 53f9b3b976d7c04791e7bf7009164bb5ccfd81b1

add note about `type` not being platform specific

view details

push time in 5 days

issue commentmicrosoft/vscode

Expose a `stopDebugging` API to extensions

I've released both variants of the API to proposed.

@connor4312 I agree that "terminate" does not convey the semantics in a good way. And I like the symmetry between startDebugging and stopDebugging. So I will push vscode.debug.stopDebugging through the API process...

connor4312

comment created time in 5 days

push eventmicrosoft/vscode

Andre Weinand

commit sha 673e35d278fc6201ab631b6d10d35a397695747f

new proposed API stopDebugging; see #101883

view details

push time in 5 days

issue commentmicrosoft/vscode

Launch fails if launch config type is a platform-specific property

if a debug extension is installed on a remote system, the type is associated with that system (and its platform/OS).

chausner

comment created time in 6 days

issue commentmicrosoft/vscode

Setting a breakpoint when multiple debug sessions are present not working properly

no, breakpoints are sent to all sessions.

quoctruong

comment created time in 6 days

issue commentmicrosoft/vscode

Launch fails if launch config type is a platform-specific property

The "type" property is needed before the platform is determined, because "type" determines the location (and therefore the platform).

This works as designed (but probably not as documented). I'll fix the doc.

chausner

comment created time in 6 days

push eventmicrosoft/vscode

Andre Weinand

commit sha af9af1ea05d932a16c797bc27771294b650d7ff3

fix documentation for DebugService.stopSession

view details

Andre Weinand

commit sha e308dd3b3674ff47542f199346b08daa8a593131

add DebugSession.terminate; see #101883

view details

push time in 6 days

issue commentmicrosoft/vscode

[Question] Bi-directional communication between adapter and extension

@indiejames Please check out Mock Debug. The debug adapter now runs inside the extension which makes debugging/inspection much easier: just press F5 and you can step everywhere, both the extension and the DA. The other modes of running the DA are still there and you can configure theme here: https://github.com/microsoft/vscode-mock-debug/blob/dc3ccfeb2195a1d2e5876f40fc9436b3b6f58a40/src/extension.ts#L12-L16

indiejames

comment created time in 6 days

issue commentmicrosoft/vscode

Expose a `stopDebugging` API to extensions

IMO there are two APIs possible:

A new terminate method on the DebugSession:

	export interface DebugSession {

		/**
		 * Terminates the session.
		 */
		terminate(): Thenable<void>;
	}

This approach is similar to TaskExecution.terminate() and the name "terminate" matches the already existing onDidTerminateDebugSession .

A new function stopDebugging:

	export namespace debug {

		/**
		 * Stop the given debug session or if no session is given stop all sessions.
		 */
		export function stopDebugging(session?: DebugSession): Thenable<void>;
	}

stopDebugging matches startDebugging and the optional session matches our internal semantics of IDebugService.stopSession.

@connor4312 @isidorn opinions?

connor4312

comment created time in 6 days

issue commentmicrosoft/vscode

debug-alt codicon in size for action bar

I've verified that this works in Insiders.

isidorn

comment created time in 6 days

issue commentmicrosoft/vscode

[Question] Bi-directional communication between adapter and extension

@indiejames I've moved the issue to the VS Code repo since the raised question is independent from the npm module that implements a DAP library for node.js.

indiejames

comment created time in 6 days

issue commentmicrosoft/vscode-debugadapter-node

[Question] Bi-directional communication between adapter and extension

@indiejames if your DA is written in JS or TS you can inline it into the extension so that it runs in the same process. With this approach you have access to the full VS Code extension API from within the DA.

indiejames

comment created time in 6 days

issue commentmicrosoft/vscode

Expose DAP IDs of breakpoints in vscode API

I've planned to investigate in July what to do here.

connor4312

comment created time in 6 days

issue commentmicrosoft/vscode

Is there any command to pick file,and get the select path?

@Layty I don't think that there is a command that allows you to pick a file and return the path to the file. But it is simple to create an extension that does this...

Layty

comment created time in 6 days

issue commentmicrosoft/vscode

Debugger highlights the wrong line when stopping if word wrap is present higher up in file

I don't think that word-wrap (which is a view only feature) and Python (where the syntax relies on correct indentation) goes together well. Please file the issue against the Python extension first.

LightCC

comment created time in 6 days

pull request commentmicrosoft/vscode

New Sort Order Lexicographic Options setting for Explorer

@leilapearson Isidor is out of the office until the end of this month. So don't expect any progress on this.

leilapearson

comment created time in 6 days

issue commentmicrosoft/vscode

Unable to debug unit tests

Please file against C# extension

mrj001

comment created time in 7 days

issue commentmicrosoft/vscode

open integrated terminal run node debugger

If "auto attach" is on, the debugger will attach to any node.js program. Are you running a node.js program from your .zshrc file?

fablec

comment created time in 7 days

push eventmicrosoft/vscode-debugadapter-node

Andre Weinand

commit sha ea7c9f84719ff74afa2cea6101bd9b2d7dabe93c

update modules to newer versions; fixes #233

view details

push time in 7 days

issue closedmicrosoft/vscode-debugadapter-node

Security alert with minimist 0.0.8 package

Debug adapter protocol depends on mkdirp ^0.5.1, which has dependency on minimist 0.0.8. Recently, there is a securtiy vulnerability found in minisist 0.0.8, please refer to VS Code April 2020 for more details

closed time in 7 days

0Steve0

issue closedmicrosoft/vscode

there seems to be no obvious way to "unsplit" a splitted terminal

I got into a situation where my terminal is splitted:

2020-07-02_12-31-45

How do I get rid of this? There seems to be no obvious way to unsplit.

closed time in 7 days

weinand

issue commentmicrosoft/vscode

there seems to be no obvious way to "unsplit" a splitted terminal

@Tyriar no, I just wanted to remove individual terminals in the splitted case. The "trashcan" wasn't obvious to me...

weinand

comment created time in 7 days

issue commentmicrosoft/debug-adapter-protocol

Possible race condition with disconnect request

@TylerLeonhardt thanks for creating this issue.

Just some terminology so that we are on the same page as the DAP spec:

  • the target of debugging (typically the end user's program) is the "debug target" or the "debuggee" .
  • the code that handles DAP messages and talks to a real debugger or runtime is the "debug adapter" or "DA" (because it "adapts" the DAP protocol to a real debugger or runtime but is not itself a debugger).
  • a debug adapter can be implemented in different ways:
    • as a standalone program (called "debug adapter") that handles a single debug session,
    • as a standalone server (called "DAP server" ) that handles multiple debug sessions concurrently,
    • as an inline implementation that runs inside some other program or extension (your case).
    • etc.

In the original issue description from above "debuggee" is used for the debug adapter which is a bit confusing...


Now back to the "disconnect" issue.

The spec says:

The ‘disconnect’ request is sent from the client to the debug adapter in order to stop debugging. It asks the debug adapter to disconnect from the debuggee and to terminate the debug adapter. If the debuggee has been started with the ‘launch’ request, the ‘disconnect’ request terminates the debuggee. If the ‘attach’ request was used to connect to the debuggee, ‘disconnect’ does not terminate the debuggee.

So I read this as follows:

after the DA has received a ‘disconnect’ request from the client (e.g. VS Code), the DA disconnects from the debuggee. If the DA had launched the debuggee initially, it "owns" it and it is responsible to terminate it. If the DA was attached to the debuggee initially, it does not "own" it and so it must not terminate it.

The DA is free to decide when to send a response for the ‘disconnect’ request:

  • it could send a response immediately before doing anything (this is the "fire and forget" approach)
  • it could send a response immediately after disconnecting from the debuggee.
  • it could send a response after terminating the debuggee (only in the 'launch' case).

Then the DA terminates (after properly flushing the output channel so that the response could be successfully sent). Terminating means different things for the different implementation options:

  • a standalone debug adapter would just end or call "exit(...)"
  • a DAP server would end the session by closing the comm channel.

So where exactly is the race condition?

TylerLeonhardt

comment created time in 7 days

issue commentmicrosoft/debug-adapter-protocol

Security alert with minimist 0.0.8 package

@0Steve0 where do you see the security alert? I cannot find any dependency on mkdirp ^0.5.1.

0Steve0

comment created time in 7 days

issue commentmicrosoft/vscode

debug-alt codicon in size for action bar

I've already changed the 1.47 release notes to use "debug-alt-small" instead of "debug-alt": https://github.com/microsoft/vscode-docs/commit/3f9a91d4a45af8b678ede593c0dd157f26276ea1

isidorn

comment created time in 7 days

push eventmicrosoft/vscode-docs

Andre Weinand

commit sha 3f9a91d4a45af8b678ede593c0dd157f26276ea1

rename "debug-alt" icon to "debug-alt-small"; see microsoft/vscode#101026

view details

push time in 7 days

issue commentmicrosoft/vscode

debug-alt codicon in size for action bar

Here is the Mock Debug sample with the new "debug-alt-small" icon:

run-and-debug-actions

isidorn

comment created time in 7 days

issue commentmicrosoft/vscode

debug-alt codicon in size for action bar

@misolori great, thanks

isidorn

comment created time in 7 days

issue commentmicrosoft/vscode

debug-alt codicon in size for action bar

@misolori the new icon looks great.

The only problem is that it introduces a new name. In this milestone we will announce "debug-alt" (and "debug-alt-small" is not yet available) and in the next milestone we have to change the name to "debug-alt-small".

Would it be possible to ship "debug-alt-small" already in the June milestone? If yes I will adapt the sample and the doc accordingly.

isidorn

comment created time in 7 days

issue commentmicrosoft/vscode

Debugger: debug.inlineValues support for case insensitive variable names

Yes, this is a valid feature request.

chrisdp

comment created time in 8 days

push eventmicrosoft/vscode-docs

Andre Weinand

commit sha c8a698ee95b6c34cbe58b0c8058a4f9279db16cd

sort notable fixes

view details

push time in 8 days

push eventmicrosoft/vscode-docs

Andre Weinand

commit sha 3ad7e3a384486794b6a363b82fc6f68de4c66072

remove duplicate screenshot

view details

push time in 8 days

push eventmicrosoft/vscode-docs

Andre Weinand

commit sha ad426442cf92ca86590db233c6c07b5eed5e1afa

tweak debug section

view details

push time in 8 days

push eventmicrosoft/vscode-docs

Andre Weinand

commit sha db1831d22faa9a0d4860af66e4758fec52ddbd6a

single file debug experience guidelines

view details

Andre Weinand

commit sha 7ad0e7564fda1ebfbe3f1589dc62a860752facba

add notebook debugging samples

view details

Andre Weinand

commit sha 617ef66c4c2454e99171968c63cdaf424f8dbd70

add two missing debug images

view details

push time in 8 days

issue commentmicrosoft/vscode-debugadapter-node

Can you release a new version?

why? you get the latest release via npm.

fxsg20151212

comment created time in 8 days

push eventmicrosoft/vscode-docs

Andre Weinand

commit sha 1d1e3338efffd38f2b9a842c2f249132a93a4e31

add Notable fixes for debug

view details

push time in 9 days

issue commentmicrosoft/vscode-js-debug

support the `noDebug` flag

@connor4312 the DAP spec is not very precise on noDebug:

If noDebug is true the launch request should launch the program without enabling debugging.

So what you are doing for js-debug makes perfect sense.

captainsafia

comment created time in 9 days

push eventmicrosoft/vscode-docs

Andre Weinand

commit sha 97989efc2b8ae8b12ec7b610177ca7c0cb428501

add PR thank yous

view details

push time in 9 days

pull request commentmicrosoft/debug-adapter-protocol

Add Android debug adapter

Thanks for the PR.

adelphes

comment created time in 9 days

push eventmicrosoft/debug-adapter-protocol

Dave Holoway

commit sha 0cde2ee76ece8fc815daac6754b0cd45e00f2966

Add Android debug adapter

view details

Andre Weinand

commit sha 2f0164e70bf673eec7e0fb0aeb6d89afb032f55d

Merge pull request #125 from adelphes/patch-1 Add Android debug adapter

view details

push time in 9 days

pull request commentmicrosoft/debug-adapter-protocol

update on Broadcom extension

Thanks for the PR.

zimlu02

comment created time in 9 days

push eventmicrosoft/debug-adapter-protocol

lukas

commit sha 213ca229c082a3f5f1afbb94174a7a8ada9e3ae1

update on Broadcom extension

view details

Andre Weinand

commit sha df4a54747b0bebce4fdd374f1464aa019a76be2c

Merge pull request #121 from zimlu02/gh-pages update on Broadcom extension

view details

push time in 9 days

issue commentmicrosoft/debug-adapter-protocol

Security alert with minimist 0.0.8 package

Thanks. Please note that the DAP is not an npm module but just a JSON schema. Using this schema does not add any dependencies.

0Steve0

comment created time in 9 days

issue closedmicrosoft/vscode

High CPU Usage (Windows)

Issue Type: <b>Bug</b>

If I launch VS Code and use "Open Folder" on a certain project's folder then VS Code repeatedly and indefinitely spawns a child WMI process very ~1 second that eats up a lot of CPU. The query it runs is "wmic process get CommandLine,CreationDate,ParentProcessId,ProcessId".

I tried to track it down myself to no avail. I've tried --disable-extensions as well as -n, same issue. Can't see what's special about the project either (Not using autoAttachChildProcesses).

Any idea what could be causing this?

VS Code version: Code 1.27.2 (f46c4c469d6e6d8c46f268d1553c5dc4b475840f, 2018-09-12T16:17:45.060Z) OS version: Windows_NT x64 10.0.17134

closed time in 10 days

SimonGustavsson

issue commentmicrosoft/vscode

High CPU Usage (Windows)

If you are using VS Code's new JS debugger, it is already fixed.

Please see: https://code.visualstudio.com/updates/v1_46#_new-javascript-debugger

SimonGustavsson

comment created time in 10 days

push eventmicrosoft/vscode-docs

Andre Weinand

commit sha 93e6dfd5b3c149dadb32c1971735e8d15e0bccd7

adding more debug items

view details

push time in 11 days

issue commentmicrosoft/vscode

Debug doesn't wait until the process ends

@JonaVDM Could you please try to use the integrated terminal and see whether this makes a difference. Just add "console": "integratedTerminal" to your launch config.

JonaVDM

comment created time in 11 days

issue closedmicrosoft/vscode

debug not work after "run without debugging"

We have written the needed data into your clipboard because it was too large to send. Please paste.

Issue Type: <b>Bug</b>

create a simple python file, and set a breakpoint

1.click run->run without debugging 2.click run->start debugging

the breakpoint not work.

VS Code version: Code 1.46.1 (cd9ea6488829f560dc949a8b2fb789f3cdc05f5d, 2020-06-17T21:17:14.222Z) OS version: Darwin x64 19.5.0

<details> <summary>System Info</summary>

Item Value
CPUs Intel(R) Core(TM) i9-8950HK CPU @ 2.90GHz (12 x 2900)
GPU Status 2d_canvas: enabled<br>flash_3d: enabled<br>flash_stage3d: enabled<br>flash_stage3d_baseline: enabled<br>gpu_compositing: enabled<br>metal: disabled_off<br>multiple_raster_threads: enabled_on<br>oop_rasterization: disabled_off<br>protected_video_decode: unavailable_off<br>rasterization: enabled<br>skia_renderer: disabled_off_ok<br>video_decode: enabled<br>viz_display_compositor: enabled_on<br>viz_hit_test_surface_layer: disabled_off_ok<br>webgl: enabled<br>webgl2: enabled
Load (avg) 2, 1, 1
Memory (System) 32.00GB (6.25GB free)
Process Argv .
Screen Reader no
VM 0%

</details><details><summary>Extensions (21)</summary>

Extension Author (truncated) Version
markdown-mermaid bie 1.5.1
vscode-markdownlint Dav 0.36.1
beautify Hoo 1.5.0
vscode-docker ms- 1.3.1
vscode-kubernetes-tools ms- 1.2.1
python ms- 2020.6.91350
cpptools ms- 0.28.3
debugger-for-chrome msj 4.12.8
vscode-spring-boot Piv 1.19.0
java red 0.63.0
vscode-yaml red 0.8.0
markdown-preview-enhanced shd 0.5.12
vscodeintellicode Vis 1.2.9
vscode-java-debug vsc 0.26.0
vscode-java-dependency vsc 0.10.2
vscode-java-pack vsc 0.9.1
vscode-java-test vsc 0.23.0
vscode-maven vsc 0.22.0
vim vsc 1.14.5
markdown-all-in-one yzh 3.1.0
material-theme zhu 3.8.2

</details> <!-- generated by issue reporter -->

closed time in 11 days

atreeyang

issue commentmicrosoft/vscode

debug not work after "run without debugging"

@atreeyang thanks for verifying that this problem is fixed in Insiders (which will become Stable next week).

atreeyang

comment created time in 11 days

issue closedmicrosoft/vscode

yeoman generator "Notebook Renderer" does not create extension in working directory

Testing #101319

When running the yeoman generator "Notebook Renderer" it says at the end:

2020-07-02_12-22-09

This did not work for me since there was no renderer "nbr" generated in my current working directory.

I tried this multiple times but there was no error explaining why the creation failed.

In the end I searched the whole filesystem and found that yeoman had created the renderer extension in the parent directory of the vscode repository.

But when running the yeoman generator I was in a directory "Notebooks" (and I expected the new extension to live in that directory).

This behavior is very surprising without proper explanation. I don't know why the generator insists on creating the extension next to vscode.

terminal transcript: transscript.txt

closed time in 12 days

weinand

issue commentmicrosoft/vscode

yeoman generator "Notebook Renderer" does not create extension in working directory

On reviewing the transscript, I noticed the following at the beginning:

Just found a `.yo-rc.json` in a parent directory.
Setting the project root at: /Users/weinand/MS/Projects

     _-----_     ╭──────────────────────────╮
    |       |    │   Welcome to the Visual  │
    |--(o)--|    │   Studio Code Extension  │
   `---------´   │        generator!        │
    ( _´U`_ )    ╰──────────────────────────╯
 ...

So this explains the behavior.

weinand

comment created time in 12 days

issue closedmicrosoft/vscode

Test: yeoman generator for notebook

Refs: #101056

  • [x] anyOS @weinand
  • [x] anyOS @alexdima

Complexity: 2

Create Issue


Note: the starter was tested last endgame, this is sanity checking the generator code

  1. Grab the latest npm install -g yo generator-code
  2. Run INCLUDE_PROPOSED=1 yo code and select the notebook starter
  3. Fill out options. Check that it generates sane, runnable code for you.

If you use the test provider, you'll be able to see a sample notebook by creating an empty file with your chosen file extension (e.g. foo.my-cool-notebook).

closed time in 12 days

connor4312

issue commentmicrosoft/vscode

Debugging breaks on first line of code

Please don't specify a "--inspect" argument - the debug extension does that automatically.

vainamov

comment created time in 12 days

issue openedmicrosoft/vscode

there seems to be no obvious way to "unsplit" a splitted terminal

I got into a situation where my terminal is splitted:

2020-07-02_12-31-45

How do I get rid of this? There seems to be no obvious way to unsplit.

created time in 12 days

issue openedmicrosoft/vscode

yeoman generator "Notebook Renderer" does not create extension in working directory

Testing #101319

When running the yeoman generator "Notebook Renderer" it says at the end:

2020-07-02_12-22-09

This did not work for me since there was no Notebook Renderer generated in my current working directory.

I tried this multiple times but there was no error explaining why the creation failed.

In the end I searched the whole filesystem and found that yeoman had created the renderer extension in the parent directory of the vscode repository.

But when running the yeoman generator I was in a directory "Notebooks" (and expected the new extension to live in that directory).

This behavior was surprising. I don't know why the generator insists on creating the extension next to vscode.

created time in 12 days

issue commentmicrosoft/vscode

Test: yeoman generator for notebook

The correct name of the generator is "Notebook Renderer" not "notebook starter".

connor4312

comment created time in 12 days

issue commentmicrosoft/vscode

Debugging breaks on first line of code

@vainamov you are specifying the runtimeArg --inspect-brk which makes the debugger "break" on the first line. Just remove the "runtimeArgs" array since it is not necessary.

vainamov

comment created time in 12 days

issue commentmicrosoft/vscode

VS Code stops debugging after running "run without debug for the first time"

What version of VS Code are you using?

Please read our guidelines for how to create a good bug report here: https://github.com/microsoft/vscode/wiki/Submitting-Bugs-and-Suggestions

nirothehero1983

comment created time in 13 days

issue commentmicrosoft/vscode

Explore improving the single file debug experience

Verified that the proposal works and looks fine. The icons are not yet aligned, but I commented here: https://github.com/microsoft/vscode/issues/101026#issuecomment-652342966

weinand

comment created time in 13 days

issue commentmicrosoft/vscode

debug-alt codicon in size for action bar

@misolori I just verified how the current icons look in Mock debug and I got the impression that the debug icon (play with bug) is just fine. Only the "play" icon is a little small.

2020-07-01_12-38-24

Instead of changing "debug" (and all other icons used in the activity bar), wouldn't it be possible to just make the play icon one pixel larger and move it up one pixel?

isidorn

comment created time in 13 days

issue commentmicrosoft/vscode

debug-alt codicon in size for action bar

What is proposed above (and copied below), looks perfect to me:

2020-07-01_12-25-26

isidorn

comment created time in 13 days

IssuesEvent

issue commentmicrosoft/vscode

Allow right-click paste inside the debug console

Verifying... After a right-click "Paste" from the upper part of the "Debug Console" (which cannot receive keyboard input), the focus stays on that part (which is pretty useless). The focus should be transferred to the bottom text box so that I can just press return to execute the pasted command. The "Clear Console" command transfers the focus correctly.

phgmacedo

comment created time in 13 days

issue commentmicrosoft/vscode

compacted debug sessions should show name of child and not of parent

@isidorn yes, I agree with your proposal.

Another argument for that approach: with the current behavior the "weird name" child gets the "nice name" from the parent. But if another child arrives, two "weird names" shows up...

weinand

comment created time in 13 days

issue closedmicrosoft/vscode

Test: Install VSIX through drag'n'drop to extension viewlet

Refs: #12090

  • [x] macOS @weinand
  • [x] linux @deepak1556
  • [x] windows @mjbvz

Authors: @lszomoru, @joaomoreno

Complexity: 2

Create Issue


We have added support to install a VSIX file by dragging and dropping it onto the Extensions viewlet.

Verification:

  • Download one or more VSIX files from the marketplace - https://marketplace.visualstudio.com/vscode
    • Drag'n'drop one or more VSIX files onto the Extensions viewlet and confirm that the extensions are installed
  • Drag'n'drop any files that do not have a VSIX extension. While the file can be dropped onto the viewlet, nothing should happen.
  • Rename an image file to have the .vsix extension. Drag'n'drop the file onto the viewlet. This should result in an error that the ZIP is corrupt.

closed time in 13 days

lszomoru

issue commentmicrosoft/vscode

Test: Install VSIX through drag'n'drop to extension viewlet

@lszomoru FYI, on macOS it is possible to remove the ".vsix" from the extension file and still D&D it successfully onto the Extensions viewlet. The reason for this is that macOS detects the removal of the ".vsix" from the name as a request to hide the file's extension. This can be seen with "Get Info":

2020-07-01_09-41-06

lszomoru

comment created time in 13 days

issue commentmicrosoft/vscode

DAP's progress events do not show on status bar if they end within 500ms

In my proposal the delay does not affect the appearance of the progress end message. If there is an end message, it comes immediate (even before the delay).

So the following is not true:

The longer the delay between a user pressing something and them seeing feedback, the less attractive using this API is because it makes things feel slower.

DanTup

comment created time in 14 days

issue openedmicrosoft/vscode

Improve explanation of "compacted with the parent"

Testing #101009

The comment for the new "noCompact" option says:

Controls if the debug session created will be compacted with the parent in the CALL STACK view. Compact with the parent is only done if the session is the only child of its parent session. Default is to compact.

IMO "compacted with the parent" is not very clear to me. I think this can be improved to something like:

Controls if the debug session's parent session is shown even if it has only a single child. Default is to hide the parent session in this case in order to make the tree more compact.

@connor4312 any suggestions from a native speaker?

created time in 14 days

issue openedmicrosoft/vscode

do not show twistie for compressed nodes

Testing #101009

An uncompressed debug session tree shows twisties only where it makes sense: 2020-06-30_18-40-53

The corresponding compressed tree shows a twistie despite the fact that it is really the "leaf" from the uncompressed tree: 2020-06-30_18-42-40

created time in 14 days

issue openedmicrosoft/vscode

compressed debug sessions should show name of child and not of parent

Testing #101009

When hierarchical debug sessions are compressed, the resulting tree node uses the name of the parent session, not the child session.

IMO this does not make sense because the compress feature eliminates the parent when there is only on child and not the child.

created time in 14 days

issue commentmicrosoft/vscode

DAP's progress events do not show on status bar if they end within 500ms

I agree, 500ms is too long. I think initially I proposed 300ms

DanTup

comment created time in 14 days

issue commentmicrosoft/vscode

DAP's progress events do not show on status bar if they end within 500ms

@isidorn since the current behavior is neither new nor a regression, I don't think that we have to rush this into the June release. But if the change is low-risk you can try...

DanTup

comment created time in 14 days

issue commentmicrosoft/vscode

DAP's progress events do not show on status bar if they end within 500ms

I agree with @DanTup that dropping the final message if the progress ends before the 500ms delay isn't helpful.

Dan's proposal in the previous comment makes sense to me:

  • keep the delay and show no progress if the progress ends before the 500ms.
  • but if ProgressEndEvent has a message, then show it.
DanTup

comment created time in 14 days

issue commentmicrosoft/vscode-debugadapter-node

Can you release a new version?

The latest released version is 1.41.0.

fxsg20151212

comment created time in 14 days

issue closedmicrosoft/vscode-debugadapter-node

Can you release a new version?

Hello, the latest version is 1.29.0, but it is a long time ago. Will a new version be released recently?

closed time in 14 days

fxsg20151212

issue openedmicrosoft/vscode

typo in JSON fileMatch hover text

An "is" is missing:

2020-06-30_15-43-36

created time in 14 days

more