profile
viewpoint
If you are wondering where the data of this site comes from, please visit https://api.github.com/users/vladimir-mencl-eresearch/events. GitMemory does not store any data, but only uses NGINX to cache data for a period of time. The idea behind GitMemory is simply to give users a better reading experience.
Vlad Mencl vladimir-mencl-eresearch REANNZ Christchurch, New Zealand https://reannz.co.nz/about/our-people/vladimir-mencl/

grnet/djnro 7

DjNRO hits the decks of eduroam database management

nesi/BeSTGRID-legacy 2

BeSTRID legacy code - import of original BeSTGRID SVN, https://subversion.ceres.auckland.ac.nz/BeSTGRID/

shivshankar-rajasekaran/Foreign-Federation-Opt-In 2

New Plugin to Add Opt-in Workflow

REANNZ/groovy 0

Fork of Apache Groovy for the purpose of backporting the GROOVY-7664 fix to 2.0.8

shundezhang/webdavis 0

Automatically exported from code.google.com/p/webdavis

vladimir-mencl-eresearch/ansible 0

Ansible is a radically simple IT automation platform that makes your applications and systems easier to deploy. Avoid writing scripts or custom code to deploy and update your applications — automate in a language that approaches plain English, using SSH, with no agents to install on remote systems. https://docs.ansible.com/ansible/

vladimir-mencl-eresearch/envplate 0

Docker-friendly trivial templating for configuration files using environment keys

vladimir-mencl-eresearch/ipcalc 0

Python IP Calculator

created tagREANNZ/saml-service

tag1.7.2

AAF service responsible for SAML data storage, metadata generation and inter-federation (eduGAIN) metadata processing.

created time in 2 days

created tagREANNZ/saml-service

tag1.7.2-tuakiri1

AAF service responsible for SAML data storage, metadata generation and inter-federation (eduGAIN) metadata processing.

created time in 2 days

push eventREANNZ/saml-service

dependabot[bot]

commit sha fda1babeadd8c62d328b3561207d181d969a00c7

Bump nokogiri from 1.12.3 to 1.12.5 Bumps [nokogiri](https://github.com/sparklemotion/nokogiri) from 1.12.3 to 1.12.5. - [Release notes](https://github.com/sparklemotion/nokogiri/releases) - [Changelog](https://github.com/sparklemotion/nokogiri/blob/main/CHANGELOG.md) - [Commits](https://github.com/sparklemotion/nokogiri/compare/v1.12.3...v1.12.5) --- updated-dependencies: - dependency-name: nokogiri dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>

view details

Waldo Fouche

commit sha 63ea37e88f5e83764c9ceb41c3de2c1ed7567a94

Merge pull request #247 from ausaccessfed/dependabot/bundler/nokogiri-1.12.5 Bump nokogiri from 1.12.3 to 1.12.5

view details

Matthew Puku

commit sha 35f2712cf0684e192a562e3fb2153a3c3f11812b

Add setup instructions This script assumes some system dependencies: - Ruby (with bundler) - Mysql - The ability to compile lib-v8 Given those are present, it gets the app to a state where one can run the tests.

view details

Matthew Puku

commit sha 99f6eb7506122167b83550de8567aae73013895f

Merge pull request #251 from ausaccessfed/chore/setup-script Add setup instructions

view details

Matthew Puku

commit sha 0e71fec546169515cac308491cfcb9bafc888516

Fix flake in RawEntityDescriptorsController spec (#252) The test on line 410 often failed because one or two of the new tags sent by the controller might already be on the record. The test then expects the updated record to be tagged twice. This commit fixes the issue by manually specifying the pre-existing tags and the new tags sent in the update request. This removes the possibility of collision.

view details

Matthew Puku

commit sha 426dad3cfd3dd1f2c251d20e515f928f65eb9595

Expand the first use of each acronym in README.md (#253) Except AAF :)

view details

Vlad Mencl

commit sha 7e83666ef3188079a4b1885d81d70e31058cabd3

fix: FR-sync/RequestedAttr: import only approved attributes In tests, set the approved flag on fudged import data.

view details

Vlad Mencl

commit sha 94984bd05db90c9a24b037fd350b8ed3855547ca

new: Spec: FR-sync/RequestedAttr: test only approved attributes are imported Adjust tests to also test that only approved attributes are imported. Add approved flag to the test `attribute_instances` data and use that for `requested_attribute_json`. Add an extra element to attribute_instance with `approved: false`. In test `requests expected number of attributes`, the expected value stays the same (attribute_count + 1), expecting the unapproved attribute not to count. However, the sanity check in `is provided with attributes that are not acceptable` needs to adjust with the extra unapproved attribute to `attribute_count + 3`

view details

Vlad Mencl

commit sha 4f541c2a88504f2edd18228326eff05e74ca2c8a

fix: FR-sync: filter out requestedAttrs requiring spec with no requested values earlier Fix the situation where an SPSSODescriptor with a a solo eduPersonEntitlement requestedAttribute with no value breaks metadata generation - the requestedAttribute is filtered out (for being an attribute that requires specification but not providing a value), but this happens too late and an AttributeConsumingService is already created. As SAML Metadata specification does not allow an AttributeConsumingService with no RequestedAttribute, the rendered metadata fails XML schema validation. Fix this by bringing the `correctly_specified?` check forward, filtering the attributes before the AttributeConsumingService is created. Add a test covering this situation to make sure that an SSPSSODescriptor "with a solo requestedAttribute requiring specification with no requested value provided" does not create a new AttributeConsumingService.

view details

Vlad Mencl

commit sha 33dc06827708fc66eb64381356e8306ab7736ad7

nfc: fix rubocop line length violation Co-authored-by: Matthew Puku <47205255+matthew-puku@users.noreply.github.com>

view details

Matthew Puku

commit sha 6bd258a9bdc5039e031e16e7ceca3c3de7e7d213

Merge pull request #249 from REANNZ/bugfix/filter_unapproved_requested_attributes - Import only approved RequestedAttributes from FR - Fix a case which creates an invalid AttributeConsumingService

view details

Vlad Mencl

commit sha f5ce1d9f382cd4b1786c6041eac1f09ffd4d33b9

Merge branch 'aaf-develop' into code-develop * aaf-develop: nfc: fix rubocop line length violation fix: FR-sync: filter out requestedAttrs requiring spec with no requested values earlier new: Spec: FR-sync/RequestedAttr: test only approved attributes are imported fix: FR-sync/RequestedAttr: import only approved attributes Expand the first use of each acronym in README.md (#253) Fix flake in RawEntityDescriptorsController spec (#252) Add setup instructions Bump nokogiri from 1.12.3 to 1.12.5

view details

Vlad Mencl

commit sha 1e18aabe40878a80e4cb6c9075f088a5385b9019

nfc: fix rubocop line length violation in sync_to_git

view details

Vlad Mencl

commit sha 5db0acf2b134eff899246f6faee3bd63bbd696bf

Merge branch 'code-develop' * code-develop: nfc: fix rubocop line length violation in sync_to_git nfc: fix rubocop line length violation fix: FR-sync: filter out requestedAttrs requiring spec with no requested values earlier new: Spec: FR-sync/RequestedAttr: test only approved attributes are imported fix: FR-sync/RequestedAttr: import only approved attributes Expand the first use of each acronym in README.md (#253) Fix flake in RawEntityDescriptorsController spec (#252) Add setup instructions Bump nokogiri from 1.12.3 to 1.12.5

view details

push time in 2 days

push eventREANNZ/saml-service

dependabot[bot]

commit sha fda1babeadd8c62d328b3561207d181d969a00c7

Bump nokogiri from 1.12.3 to 1.12.5 Bumps [nokogiri](https://github.com/sparklemotion/nokogiri) from 1.12.3 to 1.12.5. - [Release notes](https://github.com/sparklemotion/nokogiri/releases) - [Changelog](https://github.com/sparklemotion/nokogiri/blob/main/CHANGELOG.md) - [Commits](https://github.com/sparklemotion/nokogiri/compare/v1.12.3...v1.12.5) --- updated-dependencies: - dependency-name: nokogiri dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>

view details

Waldo Fouche

commit sha 63ea37e88f5e83764c9ceb41c3de2c1ed7567a94

Merge pull request #247 from ausaccessfed/dependabot/bundler/nokogiri-1.12.5 Bump nokogiri from 1.12.3 to 1.12.5

view details

Matthew Puku

commit sha 35f2712cf0684e192a562e3fb2153a3c3f11812b

Add setup instructions This script assumes some system dependencies: - Ruby (with bundler) - Mysql - The ability to compile lib-v8 Given those are present, it gets the app to a state where one can run the tests.

view details

Matthew Puku

commit sha 99f6eb7506122167b83550de8567aae73013895f

Merge pull request #251 from ausaccessfed/chore/setup-script Add setup instructions

view details

Matthew Puku

commit sha 0e71fec546169515cac308491cfcb9bafc888516

Fix flake in RawEntityDescriptorsController spec (#252) The test on line 410 often failed because one or two of the new tags sent by the controller might already be on the record. The test then expects the updated record to be tagged twice. This commit fixes the issue by manually specifying the pre-existing tags and the new tags sent in the update request. This removes the possibility of collision.

view details

Matthew Puku

commit sha 426dad3cfd3dd1f2c251d20e515f928f65eb9595

Expand the first use of each acronym in README.md (#253) Except AAF :)

view details

Vlad Mencl

commit sha 7e83666ef3188079a4b1885d81d70e31058cabd3

fix: FR-sync/RequestedAttr: import only approved attributes In tests, set the approved flag on fudged import data.

view details

Vlad Mencl

commit sha 94984bd05db90c9a24b037fd350b8ed3855547ca

new: Spec: FR-sync/RequestedAttr: test only approved attributes are imported Adjust tests to also test that only approved attributes are imported. Add approved flag to the test `attribute_instances` data and use that for `requested_attribute_json`. Add an extra element to attribute_instance with `approved: false`. In test `requests expected number of attributes`, the expected value stays the same (attribute_count + 1), expecting the unapproved attribute not to count. However, the sanity check in `is provided with attributes that are not acceptable` needs to adjust with the extra unapproved attribute to `attribute_count + 3`

view details

Vlad Mencl

commit sha 4f541c2a88504f2edd18228326eff05e74ca2c8a

fix: FR-sync: filter out requestedAttrs requiring spec with no requested values earlier Fix the situation where an SPSSODescriptor with a a solo eduPersonEntitlement requestedAttribute with no value breaks metadata generation - the requestedAttribute is filtered out (for being an attribute that requires specification but not providing a value), but this happens too late and an AttributeConsumingService is already created. As SAML Metadata specification does not allow an AttributeConsumingService with no RequestedAttribute, the rendered metadata fails XML schema validation. Fix this by bringing the `correctly_specified?` check forward, filtering the attributes before the AttributeConsumingService is created. Add a test covering this situation to make sure that an SSPSSODescriptor "with a solo requestedAttribute requiring specification with no requested value provided" does not create a new AttributeConsumingService.

view details

Vlad Mencl

commit sha 33dc06827708fc66eb64381356e8306ab7736ad7

nfc: fix rubocop line length violation Co-authored-by: Matthew Puku <47205255+matthew-puku@users.noreply.github.com>

view details

Matthew Puku

commit sha 6bd258a9bdc5039e031e16e7ceca3c3de7e7d213

Merge pull request #249 from REANNZ/bugfix/filter_unapproved_requested_attributes - Import only approved RequestedAttributes from FR - Fix a case which creates an invalid AttributeConsumingService

view details

Vlad Mencl

commit sha f5ce1d9f382cd4b1786c6041eac1f09ffd4d33b9

Merge branch 'aaf-develop' into code-develop * aaf-develop: nfc: fix rubocop line length violation fix: FR-sync: filter out requestedAttrs requiring spec with no requested values earlier new: Spec: FR-sync/RequestedAttr: test only approved attributes are imported fix: FR-sync/RequestedAttr: import only approved attributes Expand the first use of each acronym in README.md (#253) Fix flake in RawEntityDescriptorsController spec (#252) Add setup instructions Bump nokogiri from 1.12.3 to 1.12.5

view details

Vlad Mencl

commit sha 1e18aabe40878a80e4cb6c9075f088a5385b9019

nfc: fix rubocop line length violation in sync_to_git

view details

push time in 2 days

delete branch REANNZ/saml-service

delete branch : bugfix/filter_unapproved_requested_attributes

delete time in 2 days

push eventREANNZ/saml-service

Vlad Mencl

commit sha 7e83666ef3188079a4b1885d81d70e31058cabd3

fix: FR-sync/RequestedAttr: import only approved attributes In tests, set the approved flag on fudged import data.

view details

Vlad Mencl

commit sha 94984bd05db90c9a24b037fd350b8ed3855547ca

new: Spec: FR-sync/RequestedAttr: test only approved attributes are imported Adjust tests to also test that only approved attributes are imported. Add approved flag to the test `attribute_instances` data and use that for `requested_attribute_json`. Add an extra element to attribute_instance with `approved: false`. In test `requests expected number of attributes`, the expected value stays the same (attribute_count + 1), expecting the unapproved attribute not to count. However, the sanity check in `is provided with attributes that are not acceptable` needs to adjust with the extra unapproved attribute to `attribute_count + 3`

view details

Vlad Mencl

commit sha 4f541c2a88504f2edd18228326eff05e74ca2c8a

fix: FR-sync: filter out requestedAttrs requiring spec with no requested values earlier Fix the situation where an SPSSODescriptor with a a solo eduPersonEntitlement requestedAttribute with no value breaks metadata generation - the requestedAttribute is filtered out (for being an attribute that requires specification but not providing a value), but this happens too late and an AttributeConsumingService is already created. As SAML Metadata specification does not allow an AttributeConsumingService with no RequestedAttribute, the rendered metadata fails XML schema validation. Fix this by bringing the `correctly_specified?` check forward, filtering the attributes before the AttributeConsumingService is created. Add a test covering this situation to make sure that an SSPSSODescriptor "with a solo requestedAttribute requiring specification with no requested value provided" does not create a new AttributeConsumingService.

view details

Vlad Mencl

commit sha 33dc06827708fc66eb64381356e8306ab7736ad7

nfc: fix rubocop line length violation Co-authored-by: Matthew Puku <47205255+matthew-puku@users.noreply.github.com>

view details

Matthew Puku

commit sha 6bd258a9bdc5039e031e16e7ceca3c3de7e7d213

Merge pull request #249 from REANNZ/bugfix/filter_unapproved_requested_attributes - Import only approved RequestedAttributes from FR - Fix a case which creates an invalid AttributeConsumingService

view details

push time in 2 days

pull request commentausaccessfed/saml-service

Import only approved RequestedAttributes from FR

Thanks for the quick response - and sorry about the line length, I missed doing a final rubocop check before committing...

vladimir-mencl-eresearch

comment created time in 3 days

push eventREANNZ/saml-service

Vlad Mencl

commit sha 33dc06827708fc66eb64381356e8306ab7736ad7

nfc: fix rubocop line length violation Co-authored-by: Matthew Puku <47205255+matthew-puku@users.noreply.github.com>

view details

push time in 3 days

pull request commentausaccessfed/saml-service

Import only approved RequestedAttributes from FR

Hi @matthew-puku ,

I've added the tests covering the change.

When testing, I also found one related aspect of the FR-sync - where a very specific setup of requested attributes could break metadata generation: an SPSSODescriptor with a a solo eduPersonEntitlement requestedAttribute with no value provided would cause the generated metadata to fail XML validation. It would fail because an AtributeConsumingService must have at least one RequestedAttribute - but no RequestedAttribute would be rendered, as eduPersonEntitlement would be filtered out if no specific value is requested.

I've fixed this as well - by bringing the correctly_specified? check forward, filtering the attributes before the AttributeConsumingService is created.

I have also added a test covering this situation to make sure that an SSPSSODescriptor "with a solo requestedAttribute requiring specification with no requested value provided" does not create a new AttributeConsumingService.

Over to you now....

vladimir-mencl-eresearch

comment created time in 3 days

Pull request review commentausaccessfed/saml-service

Import only approved RequestedAttributes from FR

 def requested_attribute_json(ra)       name: Faker::Lorem.word,       is_required: false,       reason: Faker::Lorem.word,+      approved: true,

Test added.

vladimir-mencl-eresearch

comment created time in 3 days

PullRequestReviewEvent

push eventREANNZ/saml-service

Vlad Mencl

commit sha 94984bd05db90c9a24b037fd350b8ed3855547ca

new: Spec: FR-sync/RequestedAttr: test only approved attributes are imported Adjust tests to also test that only approved attributes are imported. Add approved flag to the test `attribute_instances` data and use that for `requested_attribute_json`. Add an extra element to attribute_instance with `approved: false`. In test `requests expected number of attributes`, the expected value stays the same (attribute_count + 1), expecting the unapproved attribute not to count. However, the sanity check in `is provided with attributes that are not acceptable` needs to adjust with the extra unapproved attribute to `attribute_count + 3`

view details

Vlad Mencl

commit sha 4f541c2a88504f2edd18228326eff05e74ca2c8a

fix: FR-sync: filter out requestedAttrs requiring spec with no requested values earlier Fix the situation where an SPSSODescriptor with a a solo eduPersonEntitlement requestedAttribute with no value breaks metadata generation - the requestedAttribute is filtered out (for being an attribute that requires specification but not providing a value), but this happens too late and an AttributeConsumingService is already created. As SAML Metadata specification does not allow an AttributeConsumingService with no RequestedAttribute, the rendered metadata fails XML schema validation. Fix this by bringing the `correctly_specified?` check forward, filtering the attributes before the AttributeConsumingService is created. Add a test covering this situation to make sure that an SSPSSODescriptor "with a solo requestedAttribute requiring specification with no requested value provided" does not create a new AttributeConsumingService.

view details

push time in 3 days

push eventREANNZ/saml-service

Matthew Puku

commit sha 426dad3cfd3dd1f2c251d20e515f928f65eb9595

Expand the first use of each acronym in README.md (#253) Except AAF :)

view details

Vlad Mencl

commit sha 7e83666ef3188079a4b1885d81d70e31058cabd3

fix: FR-sync/RequestedAttr: import only approved attributes In tests, set the approved flag on fudged import data.

view details

push time in 3 days

push eventREANNZ/saml-service

Matthew Puku

commit sha 426dad3cfd3dd1f2c251d20e515f928f65eb9595

Expand the first use of each acronym in README.md (#253) Except AAF :)

view details

push time in 3 days

PullRequestReviewEvent

Pull request review commentausaccessfed/saml-service

Import only approved RequestedAttributes from FR

 def requested_attribute_json(ra)       name: Faker::Lorem.word,       is_required: false,       reason: Faker::Lorem.word,+      approved: true,

Thanks, will do.

vladimir-mencl-eresearch

comment created time in 3 days

Pull request review commentausaccessfed/saml-service

Import only approved RequestedAttributes from FR

 def discovery_response_services(sp, drservices_data)       end     end +    # rubocop:disable Metrics/MethodLength, Metrics/AbcSize     def attribute_consuming_services(sp, acservices_data)       sp.attribute_consuming_services.each(&:destroy)       acservices_data.each_with_index do |ac_data, i|-        next if ac_data[:attributes].empty?+        requested_attributes = ac_data[:attributes].select { |ra| ra[:approved] }

Hi @rianniello ,

As long as the workflows work correctly, any so-far-unapproved attribute requests should have a corresponding pending workflow, visible at /federationregistry/workflow/approval/administrative (Workflow -> Approvals -> All)

And, you can check these explicitly with a console script:

import aaf.fr.foundation.*
    

RequestedAttribute.getAll().each {
    if (!it.approved) { println it }
}
null

Hope this helps.

Cheers, Vlad

PS: And I've just force-pushed a rebase...

vladimir-mencl-eresearch

comment created time in 3 days

PullRequestReviewEvent

push eventREANNZ/saml-service

dependabot[bot]

commit sha fda1babeadd8c62d328b3561207d181d969a00c7

Bump nokogiri from 1.12.3 to 1.12.5 Bumps [nokogiri](https://github.com/sparklemotion/nokogiri) from 1.12.3 to 1.12.5. - [Release notes](https://github.com/sparklemotion/nokogiri/releases) - [Changelog](https://github.com/sparklemotion/nokogiri/blob/main/CHANGELOG.md) - [Commits](https://github.com/sparklemotion/nokogiri/compare/v1.12.3...v1.12.5) --- updated-dependencies: - dependency-name: nokogiri dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>

view details

Waldo Fouche

commit sha 63ea37e88f5e83764c9ceb41c3de2c1ed7567a94

Merge pull request #247 from ausaccessfed/dependabot/bundler/nokogiri-1.12.5 Bump nokogiri from 1.12.3 to 1.12.5

view details

Matthew Puku

commit sha 35f2712cf0684e192a562e3fb2153a3c3f11812b

Add setup instructions This script assumes some system dependencies: - Ruby (with bundler) - Mysql - The ability to compile lib-v8 Given those are present, it gets the app to a state where one can run the tests.

view details

Matthew Puku

commit sha 99f6eb7506122167b83550de8567aae73013895f

Merge pull request #251 from ausaccessfed/chore/setup-script Add setup instructions

view details

Matthew Puku

commit sha 0e71fec546169515cac308491cfcb9bafc888516

Fix flake in RawEntityDescriptorsController spec (#252) The test on line 410 often failed because one or two of the new tags sent by the controller might already be on the record. The test then expects the updated record to be tagged twice. This commit fixes the issue by manually specifying the pre-existing tags and the new tags sent in the update request. This removes the possibility of collision.

view details

Vlad Mencl

commit sha a0996c5e4aa34e781654741a28b147507bbd5c63

fix: FR-sync/RequestedAttr: import only approved attributes In tests, set the approved flag on fudged import data.

view details

push time in 3 days

push eventREANNZ/saml-service

dependabot[bot]

commit sha fda1babeadd8c62d328b3561207d181d969a00c7

Bump nokogiri from 1.12.3 to 1.12.5 Bumps [nokogiri](https://github.com/sparklemotion/nokogiri) from 1.12.3 to 1.12.5. - [Release notes](https://github.com/sparklemotion/nokogiri/releases) - [Changelog](https://github.com/sparklemotion/nokogiri/blob/main/CHANGELOG.md) - [Commits](https://github.com/sparklemotion/nokogiri/compare/v1.12.3...v1.12.5) --- updated-dependencies: - dependency-name: nokogiri dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>

view details

Waldo Fouche

commit sha 63ea37e88f5e83764c9ceb41c3de2c1ed7567a94

Merge pull request #247 from ausaccessfed/dependabot/bundler/nokogiri-1.12.5 Bump nokogiri from 1.12.3 to 1.12.5

view details

Matthew Puku

commit sha 35f2712cf0684e192a562e3fb2153a3c3f11812b

Add setup instructions This script assumes some system dependencies: - Ruby (with bundler) - Mysql - The ability to compile lib-v8 Given those are present, it gets the app to a state where one can run the tests.

view details

Matthew Puku

commit sha 99f6eb7506122167b83550de8567aae73013895f

Merge pull request #251 from ausaccessfed/chore/setup-script Add setup instructions

view details

Matthew Puku

commit sha 0e71fec546169515cac308491cfcb9bafc888516

Fix flake in RawEntityDescriptorsController spec (#252) The test on line 410 often failed because one or two of the new tags sent by the controller might already be on the record. The test then expects the updated record to be tagged twice. This commit fixes the issue by manually specifying the pre-existing tags and the new tags sent in the update request. This removes the possibility of collision.

view details

push time in 3 days

pull request commentausaccessfed/saml-service

Import only approved RequestedAttributes from FR

Hi @rianniello , do you need me to rebase this on current branch tip?

Just checking whether this is in any way waiting one me...

Cheers, Vlad

vladimir-mencl-eresearch

comment created time in 4 days

created tagREANNZ/federationregistry2-Tuakiri

tag2.9.5-tuakiri4

Federation Registry2 by the Australian Access Federation - local Tuakiri customizations

created time in 13 days

push eventREANNZ/federationregistry2-Tuakiri

Vlad Mencl

commit sha 32a53c27bdb37ad001fb53296175b3e3016eb4ee

fix: base/forms: prevent forms with single input text from wrongly submitting In forms with exactly one input of type text, browsers automatically submit the form when Enter is pressed. However, for some of the forms (in particular related to endpoint manipulation), this is a wrong thing to do. The forms are not designed to be submitted (not in the literal sense). They have a button with a Javascript handler that constructs an AJAX POST message - but no action URL and method to submit. The browser defaults to submitting to the location of the page (like SP details page) via query string - which is just a very confusing user experience. (The contents of the form disappears without being actually submitted anywhere). Fix this by preventing these forms from being submitted with onsubmit="return false;" Fixes REANNZ#7

view details

Vlad Mencl

commit sha 2a57494268de9eedb7f3bea281c4dfbcc17ec024

Version: internal Tuakiri release 2.9.5-tuakiri4 Minor fixes: stop single-field forms from auto-submitting on Enter.

view details

Vlad Mencl

commit sha adca7121ae1bf646ee04272eb6b9e2ebb031f679

Merge branch 'code-develop' into tuakiri-develop * code-develop: Version: internal Tuakiri release 2.9.5-tuakiri4 fix: base/forms: prevent forms with single input text from wrongly submitting

view details

Vlad Mencl

commit sha 04750ae4026131fda2f2f90ece249a607fa66673

Merge branch 'tuakiri-develop' * tuakiri-develop: Version: internal Tuakiri release 2.9.5-tuakiri4 fix: base/forms: prevent forms with single input text from wrongly submitting

view details

push time in 13 days

issue closedREANNZ/federationregistry2-Tuakiri

Form submission issue when adding a RequestedAttribute

When adding a RequestedAttribute (under Service Providers -> View -> SAML -> Attributes -> Add Attribute), pressing Enter on the Reason field submits the form to the current location (via GET with Query String).

The form should really be submitted via POST to a different location, and this is done via Javascript code attached to the Add button.

And pressing Enter on input items in other forms is ignored - just in this particular form, it is not.

I have not been able to find any difference in the source code:

Works OK for adding endpoints in app/plugins/base/grails-app/views/templates/endpoints/_create.gsp

Submits "the wrong way" for adding RequestedAttributes in app/plugins/base/grails-app/views/templates/acs/_list.gsp (Enter is ignored from the attrid select element, but processed from reasoning and isrequired)

closed time in 13 days

vladimir-mencl-eresearch

push eventREANNZ/federationregistry2-Tuakiri

Vlad Mencl

commit sha 32a53c27bdb37ad001fb53296175b3e3016eb4ee

fix: base/forms: prevent forms with single input text from wrongly submitting In forms with exactly one input of type text, browsers automatically submit the form when Enter is pressed. However, for some of the forms (in particular related to endpoint manipulation), this is a wrong thing to do. The forms are not designed to be submitted (not in the literal sense). They have a button with a Javascript handler that constructs an AJAX POST message - but no action URL and method to submit. The browser defaults to submitting to the location of the page (like SP details page) via query string - which is just a very confusing user experience. (The contents of the form disappears without being actually submitted anywhere). Fix this by preventing these forms from being submitted with onsubmit="return false;" Fixes REANNZ#7

view details

Vlad Mencl

commit sha 2a57494268de9eedb7f3bea281c4dfbcc17ec024

Version: internal Tuakiri release 2.9.5-tuakiri4 Minor fixes: stop single-field forms from auto-submitting on Enter.

view details

Vlad Mencl

commit sha adca7121ae1bf646ee04272eb6b9e2ebb031f679

Merge branch 'code-develop' into tuakiri-develop * code-develop: Version: internal Tuakiri release 2.9.5-tuakiri4 fix: base/forms: prevent forms with single input text from wrongly submitting

view details

push time in 13 days

push eventREANNZ/federationregistry2-Tuakiri

Vlad Mencl

commit sha 2a57494268de9eedb7f3bea281c4dfbcc17ec024

Version: internal Tuakiri release 2.9.5-tuakiri4 Minor fixes: stop single-field forms from auto-submitting on Enter.

view details

push time in 13 days

push eventREANNZ/federationregistry2-Tuakiri

Vlad Mencl

commit sha 32a53c27bdb37ad001fb53296175b3e3016eb4ee

fix: base/forms: prevent forms with single input text from wrongly submitting In forms with exactly one input of type text, browsers automatically submit the form when Enter is pressed. However, for some of the forms (in particular related to endpoint manipulation), this is a wrong thing to do. The forms are not designed to be submitted (not in the literal sense). They have a button with a Javascript handler that constructs an AJAX POST message - but no action URL and method to submit. The browser defaults to submitting to the location of the page (like SP details page) via query string - which is just a very confusing user experience. (The contents of the form disappears without being actually submitted anywhere). Fix this by preventing these forms from being submitted with onsubmit="return false;" Fixes REANNZ#7

view details

push time in 13 days

issue commentREANNZ/federationregistry2-Tuakiri

Form submission issue when adding a RequestedAttribute

After some digging, I can see the issue (Enter submitting the form the wrong way, to the current page URL via GET and with no validation) happens on forms that have exactly one input field of type text.

So this may be generic browser behaviour: https://stackoverflow.com/questions/1370021/why-does-forms-with-single-input-field-submit-upon-pressing-enter-key-in-input

The suggested workaround actually works: adding onsubmit="return false;" to the containing form element.

As the actual submission is via an onclick event on the button (under form-actions), this does not interfere.

A sample location of where onsubmit="return false;" would be used is e.g. https://github.com/REANNZ/federationregistry2-Tuakiri/blob/master/app/plugins/base/grails-app/views/templates/endpoints/_create.gsp#L13

vladimir-mencl-eresearch

comment created time in 17 days

pull request commentausaccessfed/saml-service

Import only approved RequestedAttributes from FR

Hi @rianniello , would you be able to review this request? Details & rationale are in #248 .

Cheers, Vlad

vladimir-mencl-eresearch

comment created time in 18 days