profile
viewpoint
Vinamra Jain vinamra28 Red Hat India I love my computer because all my friends live inside it.

jenkinsci/tekton-client-plugin 32

Trigger Tekton Pipelines from Jenkins

adityabajpai/WorkOut 1

It is an android application that primarily focuses on exercises that an individual can do on their own. It keeps a record of activities done in the past 30 days.

arhamyoga/ArhamApp 1

Arham mobile app

vinamra28/ChatApp 1

You can here chat with an individual or in a group.

PuneetPunamiya/hub 0

The tekton hub, official

vinamra28/androidx 0

Development environment for Jetpack Android extension libraries. Synchronized with Jetpack's primary development branch on AOSP.

PullRequestReviewEvent
PullRequestReviewEvent

pull request commenttektoncd/catalog

Small changes to task argocd-task-sync-and-wait

@vinamra28 Good question. I agree that this might justify a version bump in the task.

I'm not familiar with Tekton and its ecosystem, but I stumbled over this today from a question that someone had and pointed me to this task. Argo CD v1.0.2 is pretty out of date (June 2019), so I would dare to say that the task as it is now might be breaking for everyone with a more or less recent Argo CD installation using the defaults provided.

As for backwards compatibility, the v2.2 CLI will work with the currently supported Argo CD releases (and most likely, with versions beyond support as well).

I'm happy to bump up the version number of the task as well. Is there anything special I need to know/take care of? Or just copycat the 0.1 directory to 0.2 and make my changes in the new file?

@jannfis, can we say that we are now deprecating 0.1 version of this task and bumping a new version? If yes, then you need to add an annotation tekton.dev/deprecated: "true" and before that, you need to copycat the 0.1 directory to 0.2 and make your changes in the respective file(s). Thanks for doing it :slightly_smiling_face:

jannfis

comment created time in 4 hours

pull request commenttektoncd/catalog

kythe-go version bump and deprecating the previous versions

I have a concern with this that, we may end up with some users not able to use kythe-task as the minimum pipeline version requirement for 0.2 has been bumped a lot from 0.12 to 0.27

0.12 is very very old, and I think we have already a "decent" amount of Task that require 0.27 or higher, isn't ?

I also agree with @vdemeester here, 0.12 is too old to support :sweat_smile:

vinamra28

comment created time in 16 hours

PullRequestReviewEvent

PR opened tektoncd/catalog

Revert contribution guide on how to bump a task/pipeline and add info about `diff-task` tool

Changes

  • We already have a Tekton Job in place which shows the diff between the new version and previous version of the task, so we can avoid this now, hence reverting the commit 1a238ce7a661a6fe65fabfda52d4d04bfd764263.
  • Adding info about /diff-task tool which shows difference between taskname/0.(x) and taskname/0.(x+1)

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you review them:

  • [ ] Follows the authoring recommendations
  • [ ] Includes docs (if user facing)
  • [ ] Includes tests (if functionality of task changed or new task added)
  • [ ] Commit messages follow commit message best practices
  • [ ] Complies with Catalog Organization TEP, see example. Note An issue has been filed to automate this validation
    • [ ] File path follows <kind>/<name>/<version>/name.yaml

    • [ ] Has README.md at <kind>/<name>/<version>/README.md

    • [ ] Has mandatory metadata.labels - app.kubernetes.io/version the same as the <version> of the resource

    • [ ] Has mandatory metadata.annotations tekton.dev/pipelines.minVersion

    • [ ] mandatory spec.description follows the convention

        ```
      
        spec:
          description: >-
            one line summary of the resource
      
            Paragraph(s) to describe the resource.
        ```
      

See the contribution guide for more details.


+2 -25

0 comment

1 changed file

pr created time in 17 hours

create barnchvinamra28/catalog

branch : revert-contributing-guidelines

created branch time in 17 hours

pull request commenttektoncd/catalog

kythe-go version bump and deprecating the previous versions

/diff-task

vinamra28

comment created time in a day

issue commenttektoncd/hub

Catalog is not rendered while using Github Enterprise

/remove-lifecycle stale /lifecycle frozen

spuranam

comment created time in a day

issue commenttektoncd/hub

Configure Hub via configmap

/remove-lifecycle rotten /lifecycle frozen /reopen

afrittoli

comment created time in a day

pull request commenttektoncd/catalog

Adds a tool to create a simple task template

/remove-lifecycle stale /lifecycle frozen

PuneetPunamiya

comment created time in 2 days

push eventvinamra28/cli

vinamra28

commit sha f5592a96ac57c1448bfcc660069b7ae6b7712eba

Show all cancelled taskruns in message section When a pipelinerun was cancelled along with multiple taskruns being going into cancelled state, the message section of describe command was showing only one taskrun instead of multiple. This PR handles the showing of list of multiple cancelled taskruns in the message section of the pipelinerun describe command. Also added tests. Signed-off-by: vinamra28 <vinjain@redhat.com>

view details

push time in 2 days

push eventvinamra28/cli

vinamra28

commit sha 66ddd4cebaa2ade48d04b399002984a626d1f527

Show all cancelled taskruns in message section When a pipelinerun was cancelled along with multiple taskruns being going into cancelled state, the message section of describe command was showing only one taskrun instead of multiple. This PR handles the showing of list of multiple cancelled taskruns in the message section of the pipelinerun describe command. Also added tests. Signed-off-by: vinamra28 <vinjain@redhat.com>

view details

push time in 2 days

push eventvinamra28/cli

vinamra28

commit sha bfe15200ca163fa982b6e6a808998dddff8459b4

Show all cancelled taskruns in message section When a pipelinerun was cancelled along with multiple taskruns being going into cancelled state, the message section of describe command was showing only one taskrun instead of multiple. This PR handles the showing of list of multiple cancelled taskruns in the message section of the pipelinerun describe command. Also added tests. Signed-off-by: vinamra28 <vinjain@redhat.com>

view details

push time in 3 days

PR opened tektoncd/cli

Show all cancelled taskruns in message section

Changes

When a pipelinerun was cancelled along with multiple taskruns being going into cancelled state, the message section of describe command was showing only one taskrun instead of multiple.

This PR handles the showing of list of multiple cancelled taskruns in the message section of the pipelinerun describe command. Also added tests.

closes #1216

Signed-off-by: vinamra28 vinjain@redhat.com

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you review them:

  • [X] Includes tests (if functionality changed/added)
  • [X] Run the code checkers with make check
  • [X] Regenerate the manpages, docs and go formatting with make generated
  • [X] Commit messages follow commit message best practices

See the contribution guide for more details.

Release Notes

NONE
+167 -2

0 comment

3 changed files

pr created time in 3 days

create barnchvinamra28/cli

branch : issue-1216

created branch time in 3 days

push eventvinamra28/catalog

vinamra28

commit sha 4f8f6aebff1da8ce881d33b040aad502f7894ab9

Add kythe-go version 0.2 The following version of kythe-go task contains the latest changes in order to make it compatible with the latest kythe binary. Added a few environment variables and mountPath which contains go.mod Signed-off-by: vinamra28 <vinjain@redhat.com>

view details

push time in 3 days

push eventvinamra28/catalog

Jorge Andrada Prieto

commit sha 83c2016c6af44a55891965ef44951de02cf409fc

Fix Readme hadolint task 0.1 Fix Readme hadolint task 0.1, no compatible tags with tekton catalog web

view details

Frerik Andriessen

commit sha 25d9a7669cf5a2d97845d078f6a22a2fd3a30324

Add image param to yq task

view details

Frerik Andriessen

commit sha 69781086c844068bd73a1be895fb2a70cbc9c9fc

Make yq task fail if one of the replacements fails

view details

Frerik Andriessen

commit sha 578e1b9fe71024b8ce62f6d4ca64288d05f52d67

Add Basic Auth option to github-add-comment

view details

Ruben van Kruistum

commit sha 04e1310fec5ab79fa4380cea76d14c3a30c5428e

Remove quotes from args param in pytest script The quotation marks are breaking the proper execution of args

view details

Jorge Andrada Prieto

commit sha 27472bf750d078d48f4e6c9f903b3cf89675764c

Add asciidoctor Task Asciidoctor text processor task

view details

vinamra28

commit sha fb4a30cefb8c78f3e08468001b093165cf3a3095

Deprecate kythe-go version 0.1 Kythe-go version 0.1 is being deprecated as it's incompatible with latest versions of golang and the tests are also failing. Signed-off-by: vinamra28 <vinjain@redhat.com>

view details

vinamra28

commit sha e7073cf9bb63167082002b447df023403d0b8a78

Add kythe-go version 0.2 The following version of kythe-go task contains the latest changes in order to make it compatible with the latest kythe binary. Added a few environment variables and mountPath which contains go.mod Signed-off-by: vinamra28 <vinjain@redhat.com>

view details

push time in 3 days

pull request commenttektoncd/catalog

Update e2e test script to Pipelines v0.32.0

@sbwsg thanks for the hint :+1: I guess the following PR can fix the issue https://github.com/tektoncd/catalog/pull/901

sbwsg

comment created time in 3 days

PR opened tektoncd/catalog

kythe-go version bump and deprecating the previous versions

Changes

The following PR contains the version bump of kythe-go task and deprecating version 0.1 of the task as it's failing with latest versions of golang

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you review them:

  • [X] Follows the authoring recommendations
  • [X] Includes docs (if user facing)
  • [X] Includes tests (if functionality of task changed or new task added)
  • [X] Commit messages follow commit message best practices
  • [X] Complies with Catalog Organization TEP, see example. Note An issue has been filed to automate this validation
    • [X] File path follows <kind>/<name>/<version>/name.yaml

    • [X] Has README.md at <kind>/<name>/<version>/README.md

    • [X] Has mandatory metadata.labels - app.kubernetes.io/version the same as the <version> of the resource

    • [X] Has mandatory metadata.annotations tekton.dev/pipelines.minVersion

    • [X] mandatory spec.description follows the convention

        ```
      
        spec:
          description: >-
            one line summary of the resource
      
            Paragraph(s) to describe the resource.
        ```
      

See the contribution guide for more details.


+109 -0

0 comment

5 changed files

pr created time in 3 days

create barnchvinamra28/catalog

branch : kythe-bump

created branch time in 3 days

pull request commenttektoncd/catalog

Add StackRox Image Scan & Image Check Tasks - Replace #783

/approve @MoOyeg there is one task failing upstream and because of that CI is failing. I am working on a fix

MoOyeg

comment created time in 3 days

PullRequestReviewEvent

pull request commenttektoncd/catalog

Update e2e test script to Pipelines v0.32.0

@sbwsg it's failing for past 1 week. Not sure where it is failing. Any hints? 😅

sbwsg

comment created time in 4 days

PullRequestReviewEvent
PullRequestReviewEvent

Pull request review commenttektoncd/catalog

Change sonarqube scanner workspace name + tests

+apiVersion: tekton.dev/v1beta1+kind: Task+metadata:+  name: sonarqube-scanner+  labels:+    app.kubernetes.io/version: "0.1"
    app.kubernetes.io/version: "0.2"
rvankruistum

comment created time in 4 days

Pull request review commenttektoncd/catalog

Change sonarqube scanner workspace name + tests

+---+apiVersion: tekton.dev/v1beta1+kind: Pipeline+metadata:+  name: sonarqube-pipeline+spec:+  workspaces:+    - name: shared-workspace+    - name: sonar-settings+  tasks:+    - name: fetch-repository+      taskRef:+        name: git-clone+      workspaces:+        - name: output+          workspace: shared-workspace+      params:+        - name: url+          value: https://github.com/vinamra28/sonartest+        - name: subdirectory+          value: ""+        - name: deleteExisting+          value: "true"+    - name: create-sonar-properties+      params:+        - name: path+          value: ./sonar-project.properties+        - name: contents+          value: |+            sonar.projectKey=sonarqube-scanner+            sonar.projectName=sonarqube-scanner+            sonar.projectVersion=1.0+            sonar.host.url=https://sonarcloud.io/+            sonar.sources=.+            sonar.organization=tekton-catalog-test+      runAfter:+        - fetch-repository+      taskRef:+        kind: Task+        name: write-file+      workspaces:+        - name: output+          workspace: shared-workspace+    - name: code-analysis+      taskRef:+        name: sonarqube-scanner+      runAfter:+        - create-sonar-properties+      workspaces:+        - name: source+          workspace: shared-workspace+        - name: sonar-settings+          workspace: sonar-settings+---+apiVersion: tekton.dev/v1beta1+kind: PipelineRun+metadata:+  name: sonarqube-run+spec:+  pipelineRef:+    name: sonarqube-pipeline+  workspaces:+    - name: shared-workspace+      persistentvolumeclaim:

nit

      persistentVolumeClaim:
rvankruistum

comment created time in 4 days

PullRequestReviewEvent
more