profile
viewpoint
If you are wondering where the data of this site comes from, please visit https://api.github.com/users/victorpavlenko/events. GitMemory does not store any data, but only uses NGINX to cache data for a period of time. The idea behind GitMemory is simply to give users a better reading experience.
React victorpavlenko Belarus, Minsk https://victorpavlenko.github.io UI|UX Frontend React

victorpavlenko/redux-raven-middleware 0

:bird: Redux middleware for sending error reports to Sentry through raven-js.

issue commentgregberge/loadable-components

Component.preload() doesn't work?

Probably because you are rendering Component as a string, not as a Component

ozgrozer

comment created time in 7 hours

issue commentgregberge/loadable-components

requireEntrypoint broken on Webpack 5

Related: #791, #770

polkovnikov-ph

comment created time in 7 hours

issue commentgregberge/loadable-components

object is undefined

Please refer to the documentation to understand what loadable can and supposed to do. Please also provide more information on what you trying to achieve, and provided code has no sense.

Feel free to create a new issue following the issue template.

martingg88

comment created time in 7 hours

issue closedgregberge/loadable-components

object is undefined

I do have class view.js like this

View.js var View = { test: function(){ console.log('abc'); } }

export default View;

i get Undefined issue when calling like this.

const View = loadable(() => import('react-laravel'));

View.test

closed time in 7 hours

martingg88

issue commentgregberge/loadable-components

requireEntrypoint broken on Webpack 5

Hey @polkovnikov-ph :wave:, Thank you for opening an issue. We'll get back to you as soon as we can. Please, consider supporting us on Open Collective. We give a special attention to issues opened by backers. If you use Loadable at work, you can also ask your company to sponsor us :heart:. <link>

polkovnikov-ph

comment created time in a day

issue openedgregberge/loadable-components

requireEntrypoint broken on Webpack 5

🐛 Bug Report

compilation.getStats() doesn't return whatever it returned previously. Now corresponding object in loadable-stats file looks like this:

  "assets": [
    {
      "type": "assets by status",
      "cached": true,
      "filteredChildren": 4,
      "size": 98968
    }
  ],

Monkey-patching assets prior to new ChunkExtractor in this way helps:

const stats = JSON.parse(memfs.readFileSync(statsFile));
stats.assets = Object.values(stats.namedChunkGroups);
const nodeExtractor = new ChunkExtractor({ stats });
const foo = nodeExtractor.requireEntrypoint();

To Reproduce

  1. requireEntrypoint
TypeError [ERR_INVALID_ARG_TYPE]: The "path" argument must be of type string. Received undefined
    at new NodeError (node:internal/errors:363:5)
    at validateString (node:internal/validators:119:11)
    at Object.extname (node:path:837:5)
    at getFileScriptType (PROJECT\node_modules\@loadable\server\lib\ChunkExtractor.js:49:60)
    at isScriptFile (PROJECT\node_modules\@loadable\server\lib\ChunkExtractor.js:53:10)
    at PROJECT\node_modules\@loadable\server\lib\ChunkExtractor.js:367:11
    at Array.filter (<anonymous>)
    at ChunkExtractor.requireEntrypoint (PROJECT\node_modules\@loadable\server\lib\ChunkExtractor.js:365:23)

Expected behavior

No error.

Link to repl or repo (highly encouraged)

Hopefully I've given enough information to reproduce. Otherwise let it stall.

Run npx envinfo --system --binaries --npmPackages @loadable/component,@loadable/server,@loadable/webpack-plugin,@loadable/babel-plugin --markdown --clipboard

Paste the results here:

## System:
 - OS: Windows 10
## Binaries:
 - Node: 16.2.0
 - npm: 7.13.0
## npmPackages:
 - @loadable/babel-plugin: 5.13.2 => 5.13.2
 - @loadable/component: 5.15.0 => 5.15.0
 - @loadable/server: 5.15.0 => 5.15.0
 - @loadable/webpack-plugin: 5.15.0 => 5.15.0

created time in a day

pull request commentgregberge/loadable-components

chore(deps): bump ssri from 6.0.1 to 6.0.2

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

dependabot[bot]

comment created time in a day

issue closedgregberge/loadable-components

Feature proposal: Option to turn off automatic chunk naming

🚀 Feature Proposal

Add a new option to the Babel plugin to turn off automatic chunk naming.

Motivation

The Babel plugin currently does two things, add SSR support and automatically add chunk naming via a magic Webpack comments. In some cases, you might only want to add the SSR support, but not add readable names to the chunks.

For example, with Webpack's split chunks, the chunk names will also affect the file names, and you might not want to expose the names of the chunks to the end users for various reasons (I also think having chunk names can in some cases affect how Webpack splits chunks). Even with Webpack 5s prod-default 'deterministic' option will still preserve these chunk names because they were added via a magic comment.

Example

new LoadablePlugin({ automaticChunkNames: false })

Pitch

There are valid cases where you don't want automatic chunk names and this feature makes sense/can only be implemented inside of Loadable itself. It's also a minimal API to both implement and maintain in the future, so no real downsides. This API also enables having chunk names in dev, but avoiding them in prod. Keeping the default to true makes this a non-breaking change.

If there is interest I could probably find time to try implementing this.

closed time in 2 days

Ephem

pull request commentgregberge/loadable-components

feat: filter chunk assets

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

cahnory

comment created time in 2 days

issue commentgregberge/loadable-components

[BUG] TypeError: Cannot read property 'find' of undefined on @loadable/server 5.14.2

@theKashey seems that there were no new plugin versions released after 5.13.2.

olso

comment created time in 2 days

issue commentgregberge/loadable-components

React 17 support

I use react@17.0.2 and @loadable/component@5.15.0. They work well.

apepper

comment created time in 2 days

PR opened gregberge/loadable-components

chore(deps): bump postcss from 7.0.18 to 7.0.36 in /examples/webpack/webpack4

Bumps postcss from 7.0.18 to 7.0.36. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/postcss/postcss/releases">postcss's releases</a>.</em></p> <blockquote> <h2>7.0.36</h2> <ul> <li>Backport ReDoS vulnerabilities from PostCSS 8.</li> </ul> <h2>7.0.35</h2> <ul> <li>Add <a href="https://github.com/postcss/postcss/wiki/PostCSS-8-for-end-users">migration guide link</a> to PostCSS 8 error text.</li> </ul> <h2>7.0.34</h2> <ul> <li>Fix compatibility with <code>postcss-scss</code> 2.</li> </ul> <h2>7.0.33</h2> <ul> <li>Add error message for PostCSS 8 plugins.</li> </ul> <h2>7.0.32</h2> <ul> <li>Fix error message (by <a href="https://github.com/admosity"><code>@​admosity</code></a>).</li> </ul> <h2>7.0.31</h2> <ul> <li>Use only the latest source map annotation (by <a href="https://github.com/emzoumpo"><code>@​emzoumpo</code></a>).</li> </ul> <h2>7.0.30</h2> <ul> <li>Fix TypeScript definition (by <a href="https://github.com/nex3"><code>@​nex3</code></a>)</li> </ul> <h2>7.0.29</h2> <ul> <li>Update <code>Processor#version</code>.</li> </ul> <h2>7.0.28</h2> <ul> <li>Fix TypeScript definition (by <a href="https://github.com/nex3"><code>@​nex3</code></a>).</li> </ul> <h2>7.0.27</h2> <ul> <li>Fix TypeScript definition (by <a href="https://github.com/nex3"><code>@​nex3</code></a>).</li> </ul> <h2>7.0.26</h2> <ul> <li>Fix TypeScript definition (by <a href="https://github.com/nex3"><code>@​nex3</code></a>)</li> </ul> <h2>7.0.25</h2> <ul> <li>Fix absolute path support for Windows (by <a href="https://github.com/tomrav"><code>@​tomrav</code></a>)</li> </ul> <h2>7.0.24</h2> <ul> <li>Fix TypeScript definition (by <a href="https://github.com/keithamus"><code>@​keithamus</code></a>).</li> </ul> <h2>7.0.23</h2> <ul> <li>Update <code>Processor#version</code>.</li> </ul> <h2>7.0.22</h2> <ul> <li>Add funding link for <code>npm fund</code>.</li> </ul> <h2>7.0.21</h2> <ul> <li>Revert passing <code>nodes</code> property to node constructor.</li> </ul> <h2>7.0.20</h2> <ul> <li>Allow to pass PostCSS’s nodes in <code>nodes</code> property to node constructor.</li> </ul> <!-- raw HTML omitted --> </blockquote> <p>... (truncated)</p> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/postcss/postcss/blob/main/CHANGELOG.md">postcss's changelog</a>.</em></p> <blockquote> <h2>7.0.36</h2> <ul> <li>Backport ReDoS vulnerabilities from PostCSS 8.</li> </ul> <h2>7.0.35</h2> <ul> <li>Add migration guide link to PostCSS 8 error text.</li> </ul> <h2>7.0.34</h2> <ul> <li>Fix compatibility with <code>postcss-scss</code> 2.</li> </ul> <h2>7.0.33</h2> <ul> <li>Add error message for PostCSS 8 plugins.</li> </ul> <h2>7.0.36</h2> <ul> <li>Backport ReDoS vulnerabilities from PostCSS 8.</li> </ul> <h2>7.0.35</h2> <ul> <li>Add migration guide link to PostCSS 8 error text.</li> </ul> <h2>7.0.34</h2> <ul> <li>Fix compatibility with <code>postcss-scss</code> 2.</li> </ul> <h2>7.0.33</h2> <ul> <li>Add error message for PostCSS 8 plugins.</li> </ul> <h2>7.0.32</h2> <ul> <li>Fix error message (by <a href="https://github.com/admosity"><code>@​admosity</code></a>).</li> </ul> <h2>7.0.31</h2> <ul> <li>Use only the latest source map annotation (by Emmanouil Zoumpoulakis).</li> </ul> <h2>7.0.30</h2> <ul> <li>Fix TypeScript definition (by Natalie Weizenbaum).</li> </ul> <h2>7.0.29</h2> <ul> <li>Update <code>Processor#version</code>.</li> </ul> <h2>7.0.28</h2> <ul> <li>Fix TypeScript definition (by Natalie Weizenbaum).</li> </ul> <h2>7.0.27</h2> <ul> <li>Fix TypeScript definition (by Natalie Weizenbaum).</li> </ul> <h2>7.0.26</h2> <ul> <li>Fix TypeScript definition (by Natalie Weizenbaum).</li> </ul> <h2>7.0.25</h2> <ul> <li>Fix absolute path support for Windows (by Tom Raviv).</li> </ul> <h2>7.0.24</h2> <ul> <li>Fix TypeScript definition (by Keith Cirkel).</li> </ul> <!-- raw HTML omitted --> </blockquote> <p>... (truncated)</p> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/postcss/postcss/commit/67e3d7b3402c5d3d036ab7c1e781f86910d6ca72"><code>67e3d7b</code></a> Release 7.0.36 version</li> <li><a href="https://github.com/postcss/postcss/commit/54cbf3c4847eb0fb1501b9d2337465439e849734"><code>54cbf3c</code></a> Backport ReDoS vulnerabilities from PostCSS 8</li> <li><a href="https://github.com/postcss/postcss/commit/12832f3d203474bd273bd06bd3b2407567bfe09e"><code>12832f3</code></a> Release 7.0.35 version</li> <li><a href="https://github.com/postcss/postcss/commit/4455ef6baf84ceea87cb662131f95d798063896c"><code>4455ef6</code></a> Use OpenCollective in funding</li> <li><a href="https://github.com/postcss/postcss/commit/e867c794b5d646839350dd4b76f3cc81423413e6"><code>e867c79</code></a> Add migration guide to PostCSS 8 error</li> <li><a href="https://github.com/postcss/postcss/commit/32a22a98bc4de9c7a2489041ceae24eedc62144f"><code>32a22a9</code></a> Release 7.0.34 version</li> <li><a href="https://github.com/postcss/postcss/commit/22939829688574b9acdbd29106ca2ec9470b2b17"><code>2293982</code></a> Lock build targets</li> <li><a href="https://github.com/postcss/postcss/commit/2c3a111a940b373a60fae196e63931b3b6e9d8ca"><code>2c3a111</code></a> Release 7.0.33 version</li> <li><a href="https://github.com/postcss/postcss/commit/4105f21b48d75847e822e89746633792c478922b"><code>4105f21</code></a> Use yaspeller instead of yaspeller-ci</li> <li><a href="https://github.com/postcss/postcss/commit/c8d02a0da503f9fa5d96a854a2c9244710c18c72"><code>c8d02a0</code></a> Revert yaspeller-ci removal</li> <li>Additional commits viewable in <a href="https://github.com/postcss/postcss/compare/7.0.18...7.0.36">compare view</a></li> </ul> </details> <br />

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


<details> <summary>Dependabot commands and options</summary> <br />

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language

You can disable automated security fix PRs for this repo from the Security Alerts page.

</details>

+6 -6

0 comment

1 changed file

pr created time in 3 days

delete branch gregberge/loadable-components

delete branch : dependabot/npm_and_yarn/examples/webpack/webpack5/postcss-8.2.15

delete time in 5 days

PR closed gregberge/loadable-components

chore(deps): bump postcss from 8.1.2 to 8.2.15 in /examples/webpack/webpack5 dependencies

Bumps postcss from 8.1.2 to 8.2.15. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/postcss/postcss/releases">postcss's releases</a>.</em></p> <blockquote> <h2>8.2.15</h2> <ul> <li>Fixed <code>list</code> type definitions (by <a href="https://github.com/n19htz"><code>@​n19htz</code></a>).</li> </ul> <h2>8.2.14</h2> <ul> <li>Removed <code>source-map</code> from client-side bundle (by <a href="https://github.com/barak007"><code>@​barak007</code></a>).</li> </ul> <h2>8.2.13</h2> <ul> <li>Fixed ReDoS vulnerabilities in source map parsing (by <a href="https://github.com/yetingli"><code>@​yetingli</code></a>).</li> </ul> <h2>8.2.12</h2> <ul> <li>Fixed <code>package.json</code> exports.</li> </ul> <h2>8.2.11</h2> <ul> <li>Fixed <code>DEP0148</code> warning in Node.js 16.</li> <li>Fixed docs (by <a href="https://github.com/semiromid"><code>@​semiromid</code></a>).</li> </ul> <h2>8.2.10</h2> <ul> <li>Fixed ReDoS vulnerabilities in source map parsing.</li> <li>Fixed webpack 5 support (by <a href="https://github.com/barak007"><code>@​barak007</code></a>).</li> <li>Fixed docs (by <a href="https://github.com/roelandmoors"><code>@​roelandmoors</code></a>).</li> </ul> <h2>8.2.9</h2> <ul> <li>Exported <code>NodeErrorOptions</code> type (by <a href="https://github.com/realityking"><code>@​realityking</code></a>)</li> </ul> <h2>8.2.8</h2> <ul> <li>Fixed browser builds in webpack 5 (by <a href="https://github.com/mattcompiles"><code>@​mattcompiles</code></a>).</li> </ul> <h2>8.2.7</h2> <ul> <li>Fixed browser builds in webpack 5 (by <a href="https://github.com/mattcompiles"><code>@​mattcompiles</code></a>).</li> </ul> <h2>8.2.6</h2> <ul> <li>Fixed <code>Maximum call stack size exceeded</code> in <code>Node#toJSON</code>.</li> <li>Fixed docs (by <a href="https://github.com/inokawa"><code>@​inokawa</code></a>).</li> </ul> <h2>8.2.5</h2> <ul> <li>Fixed escaped characters handling in <code>list.split</code> (by <a href="https://github.com/nex3"><code>@​nex3</code></a>).</li> </ul> <h2>8.2.4</h2> <ul> <li>Added plugin name to <code>postcss.plugin()</code> warning (by <a href="https://github.com/Alphy11"><code>@​Alphy11</code></a>).</li> <li>Fixed docs (by <a href="https://github.com/billcolumbia"><code>@​billcolumbia</code></a>).</li> </ul> <h2>8.2.3</h2> <ul> <li>Fixed <code>JSON.stringify(Node[])</code> support (by <a href="https://github.com/mischnic"><code>@​mischnic</code></a>).</li> </ul> <h2>8.2.2</h2> <ul> <li>Fixed CSS-in-JS support (by <a href="https://github.com/43081j"><code>@​43081j</code></a>).</li> <li>Fixed plugin types (by <a href="https://github.com/ludofischer"><code>@​ludofischer</code></a>).</li> <li>Fixed <code>Result#warn()</code> types.</li> </ul> <h2>8.2.1</h2> <!-- raw HTML omitted --> </blockquote> <p>... (truncated)</p> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/postcss/postcss/blob/main/CHANGELOG.md">postcss's changelog</a>.</em></p> <blockquote> <h2>8.2.15</h2> <ul> <li>Fixed <code>list</code> type definitions (by <a href="https://github.com/n19htz"><code>@​n19htz</code></a>).</li> </ul> <h2>8.2.14</h2> <ul> <li>Removed <code>source-map</code> from client-side bundle (by Barak Igal).</li> </ul> <h2>8.2.13</h2> <ul> <li>Fixed ReDoS vulnerabilities in source map parsing (by Yeting Li).</li> </ul> <h2>8.2.12</h2> <ul> <li>Fixed <code>package.json</code> exports.</li> </ul> <h2>8.2.11</h2> <ul> <li>Fixed <code>DEP0148</code> warning in Node.js 16.</li> <li>Fixed docs (by <a href="https://github.com/semiromid"><code>@​semiromid</code></a>).</li> </ul> <h2>8.2.10</h2> <ul> <li>Fixed ReDoS vulnerabilities in source map parsing.</li> <li>Fixed webpack 5 support (by Barak Igal).</li> <li>Fixed docs (by Roeland Moors).</li> </ul> <h2>8.2.9</h2> <ul> <li>Exported <code>NodeErrorOptions</code> type (by Rouven Weßling).</li> </ul> <h2>8.2.8</h2> <ul> <li>Fixed browser builds in webpack 4 (by Matt Jones).</li> </ul> <h2>8.2.7</h2> <ul> <li>Fixed browser builds in webpack 5 (by Matt Jones).</li> </ul> <h2>8.2.6</h2> <ul> <li>Fixed <code>Maximum call stack size exceeded</code> in <code>Node#toJSON</code>.</li> <li>Fixed docs (by inokawa).</li> </ul> <h2>8.2.5</h2> <ul> <li>Fixed escaped characters handling in <code>list.split</code> (by Natalie Weizenbaum).</li> </ul> <h2>8.2.4</h2> <ul> <li>Added plugin name to <code>postcss.plugin()</code> warning (by Tom Williams).</li> <li>Fixed docs (by Bill Columbia).</li> </ul> <h2>8.2.3</h2> <ul> <li>Fixed <code>JSON.stringify(Node[])</code> support (by Niklas Mischkulnig).</li> </ul> <h2>8.2.2</h2> <ul> <li>Fixed CSS-in-JS support (by James Garbutt).</li> <li>Fixed plugin types (by Ludovico Fischer).</li> <li>Fixed <code>Result#warn()</code> types.</li> </ul> <h2>8.2.1</h2> <!-- raw HTML omitted --> </blockquote> <p>... (truncated)</p> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/postcss/postcss/commit/5061f7b5ceba6b2cdde4b61dc169ffb201caf40b"><code>5061f7b</code></a> Release 8.2.15 version</li> <li><a href="https://github.com/postcss/postcss/commit/da88b2ee2a59bff9de198d2c409930381402f0d6"><code>da88b2e</code></a> Update fs-extra</li> <li><a href="https://github.com/postcss/postcss/commit/7a3d728f8c7e81cbfa6e45c2527039f5ef4a7fc8"><code>7a3d728</code></a> Try to fix CI</li> <li><a href="https://github.com/postcss/postcss/commit/f00a4486a02d714559c98829b38072aee6ef1559"><code>f00a448</code></a> Update dependncies</li> <li><a href="https://github.com/postcss/postcss/commit/29a260ed86134ed711979893a8f1c21e140e645a"><code>29a260e</code></a> Merge pull request <a href="https://github-redirect.dependabot.com/postcss/postcss/issues/1577">#1577</a> from n19htz/fix-list-declaration</li> <li><a href="https://github.com/postcss/postcss/commit/8a0e1eb5a28431286c79799dbaaeaedceff024c1"><code>8a0e1eb</code></a> fix List declartation</li> <li><a href="https://github.com/postcss/postcss/commit/ff8e52d708602f4b37433e125bf19ab8f7f00dc9"><code>ff8e52d</code></a> Release 8.2.14 version</li> <li><a href="https://github.com/postcss/postcss/commit/12359ea8e0457612a262c11cd6ffe7e4c3e10952"><code>12359ea</code></a> Update dependencies</li> <li><a href="https://github.com/postcss/postcss/commit/b158dd5f2fdad897fc5594ca8c6ae5a130d00b34"><code>b158dd5</code></a> Merge pull request <a href="https://github-redirect.dependabot.com/postcss/postcss/issues/1571">#1571</a> from barak007/source-map-browser</li> <li><a href="https://github.com/postcss/postcss/commit/de6f33c46c0a7162eb436d22942c69ed76907068"><code>de6f33c</code></a> remove source-map from browser build</li> <li>Additional commits viewable in <a href="https://github.com/postcss/postcss/compare/8.1.2...8.2.15">compare view</a></li> </ul> </details> <br />

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


<details> <summary>Dependabot commands and options</summary> <br />

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language

You can disable automated security fix PRs for this repo from the Security Alerts page.

</details>

+17 -26

1 comment

1 changed file

dependabot[bot]

pr closed time in 5 days

PR opened gregberge/loadable-components

chore(deps): bump postcss from 8.1.2 to 8.3.4 in /examples/webpack/webpack5

Bumps postcss from 8.1.2 to 8.3.4. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/postcss/postcss/releases">postcss's releases</a>.</em></p> <blockquote> <h2>8.3.4</h2> <ul> <li>Fixed broken AST detection.</li> </ul> <h2>8.3.3</h2> <ul> <li>Fixed broken AST on <code>postcss</code> dependency duplication in custom parsers.</li> </ul> <h2>8.3.2</h2> <ul> <li>Update changelog.</li> </ul> <h2>8.3.1</h2> <ul> <li>Fixed false positives <code>PostCSS does nothing</code> warning on <code>syntax</code> option.</li> </ul> <h2>8.3 “Duke Murmur”</h2> <!-- raw HTML omitted --> <p>PostCSS 8.3 improved source map parsing performance, added <code>Node#assign()</code> shortcut, and experimental <code>Document</code> node to AST.</p> <h2>Thanks to Sponsors</h2> <p>This release was possible thanks to our community.</p> <!-- raw HTML omitted --> <p>If your company wants to support the sustainability of front-end infrastructure or wants to give some love to PostCSS, you can join our supporters by:</p> <ul> <li><a href="https://tidelift.com/"><strong>Tidelift</strong></a> with a Spotify-like subscription model supporting all projects from your lock file.</li> <li>Direct donations in <a href="https://opencollective.com/postcss#section-contributors"><strong>PostCSS & Autoprefixer Open Collective</strong></a>.</li> </ul> <h2>Source Map Performance</h2> <p>Because PostCSS needs synchronous API, we can’t move from the old `source-map 0.6 to 0.7 (many other open-source projects too).</p> <p><a href="https://github.com/7rulnik"><code>@​7rulnik</code></a> forked <code>source-map</code> 0.6 to <a href="https://www.npmjs.com/package/source-map-js"><code>source-map-js</code></a> and back-ported performance improvements from 0.7. In 8.3 we <a href="https://github-redirect.dependabot.com/postcss/postcss/pull/1515">switched</a> from <code>source-map</code> to this <code>source-map-js</code> fork.</p> <p>You map see 4x performance improvements in parsing map from processing step before PostCSS (for instance, Sass).</p> <h2><code>Document</code> Nodes</h2> <p>Thanks to <a href="https://github.com/gucong3000"><code>@​gucong3000</code></a>, PostCSS already parse CSS from HTML and JS files (CSS-in-JS templates and objects).</p> <p>But his plugin need big updates. <a href="https://github.com/hudochenkov"><code>@​hudochenkov</code></a> from <a href="https://stylelint.io/">stylelint</a> team decided to create new parsers for styles inside <a href="https://github.com/stylelint/postcss-css-in-js">CSS-in-JS</a>, <a href="https://github.com/stylelint/postcss-html">HTML</a>, and <a href="https://github.com/stylelint/postcss-markdown">Markdown</a>.</p> <p>He <a href="https://github-redirect.dependabot.com/postcss/postcss/issues/1498">suggested</a> adding new <a href="https://postcss.org/api/#document"><code>Document</code></a> node type to PostCSS AST to keep multiple <code>Root</code> nodes inside and JS/HTML/Markdown code blocks between these style blocks.</p> <pre lang="js"><code></tr></table> </code></pre> </blockquote> <p>... (truncated)</p> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/postcss/postcss/blob/main/CHANGELOG.md">postcss's changelog</a>.</em></p> <blockquote> <h2>8.3.4</h2> <ul> <li>Fixed broken AST detection.</li> </ul> <h2>8.3.3</h2> <ul> <li>Fixed broken AST on <code>postcss</code> dependency duplication in custom parsers.</li> </ul> <h2>8.3.2</h2> <ul> <li>Update changelog.</li> </ul> <h2>8.3.1</h2> <ul> <li>Fixed false positives <code>PostCSS does nothing</code> warning on <code>syntax</code> option.</li> </ul> <h2>8.3 “Duke Murmur”</h2> <ul> <li>Added <code>Node#assign()</code> shortcut (by Jonathan Neal).</li> <li>Added experimental <code>Document</code> node to AST (by Aleks Hudochenkov).</li> <li>Moved to faster fork of <code>source-map</code> (by Valentin Semirulnik).</li> </ul> <h2>8.2.15</h2> <ul> <li>Fixed <code>list</code> type definitions (by <a href="https://github.com/n19htz"><code>@​n19htz</code></a>).</li> </ul> <h2>8.2.14</h2> <ul> <li>Removed <code>source-map</code> from client-side bundle (by Barak Igal).</li> </ul> <h2>8.2.13</h2> <ul> <li>Fixed ReDoS vulnerabilities in source map parsing (by Yeting Li).</li> </ul> <h2>8.2.12</h2> <ul> <li>Fixed <code>package.json</code> exports.</li> </ul> <h2>8.2.11</h2> <ul> <li>Fixed <code>DEP0148</code> warning in Node.js 16.</li> <li>Fixed docs (by <a href="https://github.com/semiromid"><code>@​semiromid</code></a>).</li> </ul> <h2>8.2.10</h2> <ul> <li>Fixed ReDoS vulnerabilities in source map parsing.</li> <li>Fixed webpack 5 support (by Barak Igal).</li> <li>Fixed docs (by Roeland Moors).</li> </ul> <h2>8.2.9</h2> <ul> <li>Exported <code>NodeErrorOptions</code> type (by Rouven Weßling).</li> </ul> <h2>8.2.8</h2> <ul> <li>Fixed browser builds in webpack 4 (by Matt Jones).</li> </ul> <h2>8.2.7</h2> <ul> <li>Fixed browser builds in webpack 5 (by Matt Jones).</li> </ul> <h2>8.2.6</h2> <ul> <li>Fixed <code>Maximum call stack size exceeded</code> in <code>Node#toJSON</code>.</li> <li>Fixed docs (by inokawa).</li> </ul> <!-- raw HTML omitted --> </blockquote> <p>... (truncated)</p> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/postcss/postcss/commit/c7bae29ec7ccfc6cec74621a4071fcd668236081"><code>c7bae29</code></a> Release 8.3.4 version</li> <li><a href="https://github.com/postcss/postcss/commit/8b4a8b1e253793a74081ac3366ed72869c21d9ea"><code>8b4a8b1</code></a> Fix Node[my] hack</li> <li><a href="https://github.com/postcss/postcss/commit/7ea0c9b2d44d1a536f532ebb50e173537842d161"><code>7ea0c9b</code></a> Release 8.3.3 version</li> <li><a href="https://github.com/postcss/postcss/commit/ff6abab345d193605ec3a8b2859133e7a62d8dc6"><code>ff6abab</code></a> Fix Symbol description</li> <li><a href="https://github.com/postcss/postcss/commit/e51efa0593869f6d2b21a1d62358a6723f345fb7"><code>e51efa0</code></a> Fix import order</li> <li><a href="https://github.com/postcss/postcss/commit/714c5c6263f5930a5ef0c1704bbc707db9581ed5"><code>714c5c6</code></a> Require PostCSS peer dependency from parser</li> <li><a href="https://github.com/postcss/postcss/commit/d8edfeda3804a63d81d010858ade6ce5e49b93a3"><code>d8edfed</code></a> Hot fix for broken isClean on AST dublication</li> <li><a href="https://github.com/postcss/postcss/commit/2da5501f709862c19e7103b81ba8fb224a5793ff"><code>2da5501</code></a> Update dependencies</li> <li><a href="https://github.com/postcss/postcss/commit/026416dac4062f0a75d664d183ea371b59b14bf9"><code>026416d</code></a> Release 8.3.2 version</li> <li><a href="https://github.com/postcss/postcss/commit/6c303240fe876ee95d9975275752e266f0900f4a"><code>6c30324</code></a> Merge pull request <a href="https://github-redirect.dependabot.com/postcss/postcss/issues/1600">#1600</a> from postcss/dependabot/npm_and_yarn/lodash-4.17.21</li> <li>Additional commits viewable in <a href="https://github.com/postcss/postcss/compare/8.1.2...8.3.4">compare view</a></li> </ul> </details> <br />

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


<details> <summary>Dependabot commands and options</summary> <br />

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language

You can disable automated security fix PRs for this repo from the Security Alerts page.

</details>

+23 -27

0 comment

1 changed file

pr created time in 5 days

issue commentgregberge/loadable-components

Improve the docs on SSR. There a big gap between the docs and repo used as the complete SSR example

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

cbdeveloper

comment created time in 5 days

issue commentgregberge/loadable-components

SSR is not work when adding vendor split chunks

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

idangozlan

comment created time in 5 days

pull request commentgregberge/loadable-components

Use prefetch, not preload for better TTI

I guess your findings will answer that question :)

justin808

comment created time in 9 days

pull request commentgregberge/loadable-components

Use prefetch, not preload for better TTI

Does this mean prefetch wins on a big SSR page?

On Fri, Jun 11, 2021 at 12:02 AM Jacob Groß ***@***.***> wrote:

Didn't test, but I could imagine preload wins when there is nothing SSR'd, as loading the JS is the top priority in that case (as it renders everything else).

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/gregberge/loadable-components/pull/790#issuecomment-859465313, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAIRB67KY3QBD3UBCZT6INLTSHNLBANCNFSM46M7AQDQ .

-- Justin Gordon | CEO | m: 808-281-7272 | shakacode.com http://www.shakacode.com/

justin808

comment created time in 9 days

issue commentgregberge/loadable-components

Feature proposal: Option to turn off automatic chunk naming

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

Ephem

comment created time in 9 days

pull request commentgregberge/loadable-components

Use prefetch, not preload for better TTI

Didn't test, but I could imagine preload wins when there is nothing SSR'd, as loading the JS is the top priority in that case (as it renders everything else).

justin808

comment created time in 9 days

pull request commentgregberge/loadable-components

Use prefetch, not preload for better TTI

😅 because that is 403 code, not 200 - Cloudflare is protecting you from bots :) image

justin808

comment created time in 9 days

pull request commentgregberge/loadable-components

Use prefetch, not preload for better TTI

Thank you, not every day I can be somebody's hero 😊. But yeah perf tests are great! I hope everybody will use tracerbench one day.

I think I have a couple of ideas for testing. I'll try to find the case when prefetch is worse than preload. I'm thinking about a testing playground with various combination of these factors:

  • No images vs small images vs big images vs enormous images
  • HTML layout: simple vs 20KB vs 80KB
  • Network speed
  • CPU throttling
  • Lighthouse vs custom metrics
  • renderToString vs streaming

It's possible to test all combinations (with lower fidelity). This way we can have more fair competition. @theKashey any other variables to add to the list?

I have a high-priority task on my job right now. But I'm curious about the results. I think I'll work on it when I'm free.

BTW, I used brottly compression for the AB-performance test. If the HTML gets downloaded in one peace I'll need some other explanation why the scores got better.

And why does https://flow-meter-ui.vercel.app/ reports there is 12KB when devtools network tab shows 50KB for 110grill.com. Can you help me correctly interpret this output? Why does your screenshot show there are 5 chunks on the left but two chunks on the right? image image

justin808

comment created time in 9 days

issue closedgregberge/loadable-components

Error with "path"

TypeError [ERR_INVALID_ARG_TYPE]: The "path" argument must be of type string. Received type undefined at validateString (internal/validators.js:125:11) at Object.extname (path.js:1365:5) at getFileScriptType (/home/lemit/loadable-components/examples/server-side-rendering-async-node/node_modules/@loadable/server/lib/ChunkExtractor.js:49:60) at isScriptFile (/home/lemit/loadable-components/examples/server-side-rendering-async-node/node_modules/@loadable/server/lib/ChunkExtractor.js:53:10) at stats.assets.filter (/home/lemit/loadable-components/examples/server-side-rendering-async-node/node_modules/@loadable/server/lib/ChunkExtractor.js:366:11) at Array.filter (<anonymous>) at ChunkExtractor.requireEntrypoint (/home/lemit/loadable-components/examples/server-side-rendering-async-node/node_modules/@loadable/server/lib/ChunkExtractor.js:364:23) at app.get (/home/lemit/loadable-components/examples/server-side-rendering-async-node/src/server/main.js:43:42) at Layer.handle [as handle_request] (/home/lemit/loadable-components/examples/server-side-rendering-async-node/node_modules/express/lib/router/layer.js:95:5) at next (/home/lemit/loadable-components/examples/server-side-rendering-async-node/node_modules/express/lib/router/route.js:137:13)

closed time in 9 days

MasterCPP

issue commentgregberge/loadable-components

Error with "path"

It was not very easy to understand that in order to reproduce it all I need is to run loadable-components/examples/server-side-rendering-async-node.

I will double-check if there are any problems.

As you've skipped the issue template, I have to close this one. Please try to valuable time of maintainers and invest a little more efforts from your side.

MasterCPP

comment created time in 9 days

issue commentgregberge/loadable-components

Error with "path"

Hey @MasterCPP :wave:, Thank you for opening an issue. We'll get back to you as soon as we can. Please, consider supporting us on Open Collective. We give a special attention to issues opened by backers. If you use Loadable at work, you can also ask your company to sponsor us :heart:. <link>

MasterCPP

comment created time in 10 days

issue openedgregberge/loadable-components

Error with "path"

TypeError [ERR_INVALID_ARG_TYPE]: The "path" argument must be of type string. Received type undefined at validateString (internal/validators.js:125:11) at Object.extname (path.js:1365:5) at getFileScriptType (/home/lemit/loadable-components/examples/server-side-rendering-async-node/node_modules/@loadable/server/lib/ChunkExtractor.js:49:60) at isScriptFile (/home/lemit/loadable-components/examples/server-side-rendering-async-node/node_modules/@loadable/server/lib/ChunkExtractor.js:53:10) at stats.assets.filter (/home/lemit/loadable-components/examples/server-side-rendering-async-node/node_modules/@loadable/server/lib/ChunkExtractor.js:366:11) at Array.filter (<anonymous>) at ChunkExtractor.requireEntrypoint (/home/lemit/loadable-components/examples/server-side-rendering-async-node/node_modules/@loadable/server/lib/ChunkExtractor.js:364:23) at app.get (/home/lemit/loadable-components/examples/server-side-rendering-async-node/src/server/main.js:43:42) at Layer.handle [as handle_request] (/home/lemit/loadable-components/examples/server-side-rendering-async-node/node_modules/express/lib/router/layer.js:95:5) at next (/home/lemit/loadable-components/examples/server-side-rendering-async-node/node_modules/express/lib/router/route.js:137:13)

created time in 10 days

issue closedgregberge/loadable-components

@loadable/server requireEntrypoint - The "path" argument must be of type string. Received undefined

Hey Friends :) I'm facing an issue with @loadable/server

🐛 Bug Report

Calling requireEntrypoint with my stats.json throws the following error: TypeError [ERR_INVALID_ARG_TYPE]: The "path" argument must be of type string. Received undefined

To Reproduce

  1. Generate a stats.json with the following assets property
"assets": [
    {
      "type": "assets by status",
      "cached": true,
      "filteredChildren": 21,
      "size": 6889077
    }
  ],
  1. Put the stats file into a chunkExtractor
const nodeExtractor = new ChunkExtractor({
    statsFile: nodeStatsFile,
    outputPath: `@weblake.io/pwa/build/bundles/${process.env.NODE_ENV}/node/`,
  });
  1. Try to requireTheEntrypoint

const { default: Application } = nodeExtractor.requireEntrypoint();

Expected behavior

The entrypoint should be required.

What happened:

Since the assets property has no name property the getFileScriptTypefunction will fail.

Questions:

Why does this asset have no name ?


## System:
 - OS: macOS 11.3.1
 - CPU: (8) x64 Intel(R) Core(TM) i7-7700HQ CPU @ 2.80GHz
 - Memory: 123.26 MB / 16.00 GB
 - Shell: 5.8 - /bin/zsh
## Binaries:
 - Node: 14.17.0 - ~/.nvm/versions/node/v14.17.0/bin/node
 - Yarn: 2.4.2 - /usr/local/bin/yarn
 - npm: 6.14.13 - ~/.nvm/versions/node/v14.17.0/bin/npm
 - Watchman: 4.9.0 - /usr/local/bin/watchman

closed time in 10 days

Tjerk-Haaye-Henricus