profile
viewpoint
If you are wondering where the data of this site comes from, please visit https://api.github.com/users/vdiez/events. GitMemory does not store any data, but only uses NGINX to cache data for a period of time. The idea behind GitMemory is simply to give users a better reading experience.
Victor vdiez @ebu Geneva, Switzerland

vdiez/360viewer 3

static page with video.js to receive rtmp

vdiez/hearthstone_dust_calculator 1

A script to calculate against HSReplay the amount of dust needed to complete your Hearthstone collection

vdiez/angularjs-slider 0

Slider directive for AngularJS 1.X. No dependencies and mobile friendly.

vdiez/BlastingOffWithBootstrapDemo 0

Example content associated with Code Schools Blasting Off With Bootstrap course.

vdiez/chokidar 0

A neat wrapper around node.js fs.watch / fs.watchFile / fsevents.

vdiez/ffmpeg-web-gui 0

This is a PHP script for FFmpeg which allows you to upload a video and convert it into html5 (mp4 h264, webm, ogv)

vdiez/fox-wamp 0

FOX.WAMP is a WAMP v2 message router implementation

vdiez/ftp-srv 0

:postbox: Modern FTP Server

vdiez/git-shell_bind 0

A script to manage Git repos; ssh+git_shell-only users and their public keys; user access to repos

startedmifi/lossless-cut

started time in 6 hours

push eventvdiez/protoclients

vdiez

commit sha c613fdef5ca87f86e128b896b471c00e71841b47

0.0.29

view details

vdiez

commit sha 644e4022c789b1efd74f48b9b1540cce18d830b8

do not create dir if root path on smb

view details

push time in 4 days

push eventvdiez/simple_wamp

vdiez

commit sha f10f4267437662ebebc3d1a6e5b1c326d466378b

2.1.0

view details

push time in 11 days

push eventvdiez/simple_wamp

vdiez

commit sha 59ae568edeaec67c8474a2784855b44096ed22c9

2.0.12

view details

vdiez

commit sha 16a2069cdb70fe41ca6e620c9ea6ba82e22ee5d2

full refactoring and bug fixes

view details

push time in 11 days

push eventvdiez/protoclients

vdiez

commit sha dd88b947ddda839420534992471cf35d9e5329fc

0.0.28

view details

vdiez

commit sha b1ed4a909681d8bc3feecb56605cb1b079fb07dc

do not add files when watcher has been stopped

view details

push time in a month

pull request commentautovance/ftp-srv

feat: allow dynamic pasv_url depending on remote address

thanks!

vdiez

comment created time in a month

pull request commentautovance/ftp-srv

feat: allow dynamic pasv_url depending on remote address

Thanks! Just added some explanations and an example which I hope clarifies the utility of this.

vdiez

comment created time in a month

push eventvdiez/ftp-srv

vdiez

commit sha 905a1e4ef327bd00ea241a25c61cfa89d88ac171

docs: documenting parameter pasv_url as function

view details

push time in a month

push eventvdiez/ftp-srv

vdiez

commit sha a6c14f12956166e97b75fe65462d8d860ddec147

fix: missing bluebird

view details

push time in a month

Pull request review commentautovance/ftp-srv

feat: allow dynamic pasv_url depending on remote address

 module.exports = {     this.connector = new PassiveConnector(this);     return this.connector.setupServer()     .then((server) => {-      let address = this.server.options.pasv_url;-      // Allow connecting from local-      if (isLocalIP(this.ip)) {-        address = this.ip;-      }       const {port} = server.address();+      let pasvAddress = this.server.options.pasv_url;+      if (typeof pasvAddress === "function") {+        return Promise.try(() => pasvAddress(this.ip))+          .then((address) => ({address, port}));+      }+      // Allow connecting from local+      if (isLocalIP(this.ip)) pasvAddress = this.ip;+      return {address: pasvAddress, port};+    })+    .then((address, port) => {

yes, sorry this was a mistake on my side

vdiez

comment created time in a month

PullRequestReviewEvent

Pull request review commentautovance/ftp-srv

feat: allow dynamic pasv_url depending on remote address

 module.exports = {     this.connector = new PassiveConnector(this);     return this.connector.setupServer()     .then((server) => {-      let address = this.server.options.pasv_url;-      // Allow connecting from local-      if (isLocalIP(this.ip)) {-        address = this.ip;-      }       const {port} = server.address();+      let pasvAddress = this.server.options.pasv_url;+      if (typeof pasvAddress === "function") {+        return Promise.try(() => pasvAddress(this.ip))+          .then((address) => ({address, port}));+      }+      // Allow connecting from local+      if (isLocalIP(this.ip)) pasvAddress = this.ip;

yes, I just changed the order in the commit, as I assumed that if the user wants to take the control about what IP to return to the FTP client, this should include if remote IP is local or not. If you don't agree I'll revert changes.

vdiez

comment created time in a month

PullRequestReviewEvent

push eventvdiez/ftp-srv

vdiez

commit sha 1f8d0d84edaf580f9cfac804ad0759215b81d478

fix: address and port should be destructured

view details

push time in a month

Pull request review commentautovance/ftp-srv

feat: allow dynamic pasv_url depending on remote address

 module.exports = {       return this.reply(502);     } +    let port;     this.connector = new PassiveConnector(this);     return this.connector.setupServer()     .then((server) => {-      let address = this.server.options.pasv_url;+      port = server.address().port;

just commited the changes. Not sure I understood your request for pasvAddress naming. Let me know if that's what you meant.

vdiez

comment created time in a month

PullRequestReviewEvent

push eventvdiez/ftp-srv

vdiez

commit sha fdabfe7911adf040ea45a2394b0abedb7c979b0f

chore: remove port from upper scope. renamed address to pasvAddress

view details

push time in a month

PullRequestReviewEvent

Pull request review commentautovance/ftp-srv

feat: allow dynamic pasv_url depending on remote address

 module.exports = {       return this.reply(502);     } +    let port;     this.connector = new PassiveConnector(this);     return this.connector.setupServer()     .then((server) => {-      let address = this.server.options.pasv_url;+      port = server.address().port;       // Allow connecting from local-      if (isLocalIP(this.ip)) {-        address = this.ip;-      }-      const {port} = server.address();+      if (isLocalIP(this.ip)) return this.ip;+      let address = this.server.options.pasv_url;+      if (typeof address === "function") return address(this.ip);
      if (typeof address === "function") {
        return Promise.resolve(address(this.ip))
          .then(address => ({address, port}))
vdiez

comment created time in a month

Pull request review commentautovance/ftp-srv

feat: allow dynamic pasv_url depending on remote address

 module.exports = {       return this.reply(502);     } +    let port;     this.connector = new PassiveConnector(this);     return this.connector.setupServer()     .then((server) => {-      let address = this.server.options.pasv_url;+      port = server.address().port;

But then it would be up to the pasv_url function to return a port also, which is outside of its control. I also don't like moving port to the upper scope. I can also chain an internal .then to the pasv_url function so that port is known

vdiez

comment created time in a month

PullRequestReviewEvent

push eventvdiez/protoclients

vdiez

commit sha c65e05e8cfb9520e1144b55f7ce7bb9c0ad6aefd

0.0.27

view details

vdiez

commit sha bb22d6a4ad2893885f73b5d246813fde4e5fbc0d

updated ssh2 version

view details

push time in 2 months

push eventvdiez/protoclients

vdiez

commit sha 29280606ac5dd9945008f9d500722c5654d11a68

additional parameters definitions

view details

push time in 2 months

push eventvdiez/protoclients

vdiez

commit sha 37a49ceb5171b6cbaa0c6809d41383d9c14b068a

0.0.26

view details

vdiez

commit sha 87bb6909dde7dab13738671b8d8eb67f3dd0d6b6

changed parameters syntax

view details

push time in 2 months

push eventvdiez/ftp-srv

vdiez

commit sha 8644104005c95083abf27c87aac470972e7d92f9

chore: use ip getter instead of address from socket

view details

push time in 2 months

pull request commentautovance/ftp-srv

feat: allow dynamic pasv_url depending on remote address

Hello! any chance to have this merged?

vdiez

comment created time in 2 months

MemberEvent

push eventvdiez/protoclients

vdiez

commit sha 3f89bc23b5e6790a00305ccf6a2debb4281f5814

0.0.25

view details

vdiez

commit sha 844e0810f7ee9d553f081d7eafe51441a02ef208

clean up on static methods

view details

push time in 2 months

push eventvdiez/protoclients

vdiez

commit sha bafb2cc148b62db63109ca1f8d4cfb82f8455130

0.0.24

view details

vdiez

commit sha 2b5d616be812d61219d54e27e7e6909dbdef3d03

bugfix on normalize path for fs on windows

view details

push time in 2 months

push eventvdiez/ftp-srv

vdiez

commit sha fa5ff5c2b17c67de6ae36ecd24193ce19aa13bba

fix: properly assign port

view details

push time in 2 months