profile
viewpoint
Victor Chudnovsky vchudnov-g @google

googleapis/gax-ruby 20

Google API Extensions for Ruby

googleapis/sample-tester 9

Tool for testing semantically equivalent samples in multiple languages and environments

vchudnov/awesomewm-config 0

My configuration for awesomewm

vchudnov-g/artman 0

Google API Artifact manager

PullRequestReviewEvent
PullRequestReviewEvent
PullRequestReviewEvent

issue commentgoogleapis/gapic-generator-go

gapic: non-optional number fields are excluded from REST query params if value is 0

That is indeed the behavior we should have. Sorry it wasn't called out explicitly for query params in the internal design doc...or included in integration tests. I will address those two points. Thanks for catching this!

noahdietz

comment created time in 6 days

push eventgoogleapis/gapic-showcase

yoshi-code-bot

commit sha a6d7ce7fe28b4b923f9016c2423537e49620b916

chore: regenerate sources (#931)

view details

push time in 12 days

PR merged googleapis/gapic-showcase

chore: regenerate sources kokoro:force-run cla: yes

Regenerated sources resulting from most recent commit to master

+46 -45

0 comment

1 changed file

yoshi-code-bot

pr closed time in 12 days

PullRequestReviewEvent

push eventgoogleapis/gapic-showcase

Victor Chudnovsky

commit sha d952e0b56d217c9005a633d131e5295d2efab5b3

fix!: add `parent` to method signature for Messaging.SearchBlurbs() (#930) BREAKING CHANGE: this changes the flattened method signature for the Messaging.SearchBlurbs() RPC to require a `parent` parameter. Without this change, the flattened method does not work, as the required field `parent` is not supplied.

view details

push time in 12 days

delete branch googleapis/gapic-showcase

delete branch : regapic_messaging_searchblurbs_parent

delete time in 12 days

PR merged googleapis/gapic-showcase

Reviewers
fix!: add `parent` to method signature for `Messaging.SearchBlurbs()` cla: yes

BREAKING CHANGE: this changes the flattened method signature for the Messaging.SearchBlurbs() RPC to require a parent parameter.

Without this change, the flattened method does not work, as the required field parent is not supplied.

+1 -1

0 comment

1 changed file

vchudnov-g

pr closed time in 12 days

PR opened googleapis/gapic-showcase

Reviewers
fix!: add `parent` to method signature for Messaging.SearchBlurbs()

BREAKING CHANGE: this changes the flattened method signature for the Messaging.SearchBlurbs() RPC to require a parent parameter.

Without this change, the flattened method does not work, as the required field parent is not supplied.

+1 -1

0 comment

1 changed file

pr created time in 12 days

Pull request review commentgoogleapis/googleapis

fix: make parent_id fields required compute move and insert methods

 service FirewallPolicies {     option (google.api.http) = {       post: "/compute/v1/locations/global/firewallPolicies/{firewall_policy}/move"     };-    option (google.api.method_signature) = "firewall_policy";+    option (google.api.method_signature) = "firewall_policy,parent_id";

ok, cool

vam-google

comment created time in 12 days

PullRequestReviewEvent

Pull request review commentgoogleapis/googleapis

fix: make parent_id fields required compute move and insert methods

         },         "move": {           "parameterOrder": [-            "firewallPolicy"+            "firewallPolicy",

it seems like we only have parentID for firewallpolicies and global operations. It seems to me it would make sense to have parentId be the first parameter, if it is required?

vam-google

comment created time in 12 days

PullRequestReviewEvent

Pull request review commentgoogleapis/googleapis

fix: make parent_id fields required compute move and insert methods

 service FirewallPolicies {     option (google.api.http) = {       post: "/compute/v1/locations/global/firewallPolicies/{firewall_policy}/move"     };-    option (google.api.method_signature) = "firewall_policy";+    option (google.api.method_signature) = "firewall_policy,parent_id";

Do we want this signature to be consistent with the previous one, so that aprent_id is always at the front (or always at the back)?

vam-google

comment created time in 12 days

Pull request review commentgoogleapis/googleapis

fix: make parent_id fields required compute move and insert methods

         },         "move": {           "parameterOrder": [-            "firewallPolicy"+            "firewallPolicy",

We should ping GCE as to the desired parameter order. What do other RPCs do with parentId?

vam-google

comment created time in 12 days

PullRequestReviewEvent
PullRequestReviewEvent

Pull request review commentgoogleapis/disco-to-proto3-converter

fix: Fix csharp package name and Fiel equals/hashcode

+# For the converter's Bazel rules testing and demonstration, specifically+# this file shows to to use the `proto_from_disco` build rule defined in this+# repository.+load(+    "//rules_gapic:disco_to_proto.bzl",+    "gapic_yaml_from_disco",+    "grpc_service_config_from_disco",+    "proto_from_disco",+)++_MESSAGE_IGNORE_LIST = [+    "HttpHealthCheck",+    "HttpsHealthCheck",+    "HttpHealthCheckList",+    "HttpsHealthCheckList",+    "GetHttpHealthCheckRequest",+    "GetHttpsHealthCheckRequest",+    "PatchHttpHealthCheckRequest",+    "PatchHttpsHealthCheckRequest",+    "UpdateHttpHealthCheckRequest",+    "UpdateHttpsHealthCheckRequest",+    "InsertHttpHealthCheckRequest",+    "InsertHttpsHealthCheckRequest",+    "ListHttpHealthChecksRequest",+    "ListHttpsHealthChecksRequest",+    "DeleteHttpHealthCheckRequest",+    "DeleteHttpsHealthCheckRequest",+]++_SERVICE_IGNORE_LIST = [+    "HttpHealthChecks",+    "HttpsHealthChecks",+]++proto_from_disco(+    name = "compute",+    src = "//:src/test/resources/compute.v1.json",

Are your files swapped? This file is under compute/v1small/ and references the full json, while the other one iunder/v1/ refers to to compute.v1small.json

vam-google

comment created time in 17 days

Pull request review commentgoogleapis/disco-to-proto3-converter

fix: Fix csharp package name and Fiel equals/hashcode

 # repository. load(     "//rules_gapic:disco_to_proto.bzl",+    "gapic_yaml_from_disco",+    "grpc_service_config_from_disco",     "proto_from_disco", )  proto_from_disco(-    name = "compute_small",-    src = "//:src/test/resources/compute.v1.small.json",+    name = "compute",

Would it be clearer to also call this computesmall? I had to look at the file to see the comment at the top that this is a demo file. The more descriptive name may help.

vam-google

comment created time in 17 days

PullRequestReviewEvent
PullRequestReviewEvent
PullRequestReviewEvent

Pull request review commentvchudnov-g/intjson

Use protobufjs to generate .js and .ts file

+Generate JSON Definiton

Could you also update the results section on unknown enums (https://github.com/vchudnov-g/intjson#by-language-1)? We want to see whether the enum related classes were generated (and it looks from intjson.d.ts like indeed they were)

summer-ji-eng

comment created time in 21 days

PullRequestReviewEvent
PullRequestReviewEvent

Pull request review commentgoogleapis/googleapis

fix: Move compute_small protos under its own directory

+# Google Compute Engine Minimal API (for Testing Purposes Only)++Minimal viable set of API methods from [GCE](https://cloud.google.com/error-reporting/reference/). 

I would spell out Google Compute Engine

vam-google

comment created time in 24 days

Pull request review commentgoogleapis/googleapis

fix: Move compute_small protos under its own directory

+# Google Compute Engine Minimal API (for Testing Purposes Only)++Minimal viable set of API methods from [GCE](https://cloud.google.com/error-reporting/reference/). ++These API definitions exist only for testing and to simplyfy development of 

sp: simplify

vam-google

comment created time in 24 days

more