profile
viewpoint
HuangYi ustbhuangyi zoom.us HeFei,China Web Frontend Architect

ustbhuangyi/better-scroll 11460

:scroll: inspired by iscroll, and it supports more features and has a better scroll perfermance

ustbhuangyi/animation 298

an common animation lib

ustbhuangyi/Cocos2djs-2048 39

基于cocos2djs 引擎实现的2048小游戏

ustbhuangyi/FunnyRabbit 39

基于Cocos2djs开发的有趣的兔子接月饼小游戏

ustbhuangyi/gulp-her-webapp 15

基于gulp编译工具和smarty plugin开发的一套前端集成解决方案

ustbhuangyi/bscroll.io 5

better-scroll 官网

ustbhuangyi/gulp-inline-js 3

在js文件中嵌入其它js文件,支持递归嵌入

ustbhuangyi/axios 2

Promise based HTTP client for the browser and node.js

cocoliForever/vue_demo 1

vue项目实战

ustbhuangyi/angular 1

One framework. Mobile & desktop.

push eventustbhuangyi/vue-analysis

ustbhuangyi

commit sha 6ad1c86f1226a5dd9c810881e53b3a021f580f91

deploy

view details

push time in 13 days

push eventustbhuangyi/vue-analysis

ustbhuangyi

commit sha 2372c3049e3f249b1f01f10ec3137c2ef1c890ef

deploy

view details

push time in 13 days

push eventustbhuangyi/vue-analysis

ustbhuangyi

commit sha 8e82f3e8a3710a320638962e43a0b1f9c510dbe5

deploy

view details

push time in 13 days

push eventustbhuangyi/vue-analysis

ustbhuangyi

commit sha f6af405e1e992dbb975950c60d38961a71e50c35

finish props

view details

push time in 13 days

create barnchustbhuangyi/vue-analysis

branch : props

created branch time in 13 days

startedvuejs/vue-test-utils

started time in 19 days

startedvuejs/vue-jest

started time in 19 days

startedbenjamn/ast-types

started time in a month

startedTencent/omi

started time in 2 months

startedGoogleChromeLabs/comlink

started time in 2 months

startedcheeriojs/cheerio

started time in 3 months

startedmozilla/vtt.js

started time in 4 months

startedvideojs/vtt.js

started time in 4 months

startedvuejs/jsx

started time in 4 months

startedvuejs/babel-plugin-transform-vue-jsx

started time in 4 months

push eventustbhuangyi/vue-analysis

ustbhuangyi

commit sha 30ded0589a1e4151e20fe2eddc5773d658f044a9

deploy

view details

push time in 4 months

push eventustbhuangyi/vue-analysis

ustbhuangyi

commit sha 86af76f1459ca9733b360080293a22e0ea302b63

fix typo

view details

push time in 4 months

push eventustbhuangyi/vue-analysis

ustbhuangyi

commit sha 49234f9b2e4bc335fedfbbcc9ef4cbb7c8e9a405

deploy

view details

push time in 4 months

PR closed ustbhuangyi/vue-analysis

change beforeCreatd to beforeCreate

change beforeCreatd to beforeCreate

+1 -1

1 comment

1 changed file

luoxuzhi

pr closed time in 4 months

pull request commentustbhuangyi/vue-analysis

change beforeCreatd to beforeCreate

fixed

luoxuzhi

comment created time in 4 months

push eventustbhuangyi/vue-analysis

ustbhuangyi

commit sha 59ef2f05a3480a20fdb8e9475a2bdfef1674836c

fix typo

view details

push time in 4 months

push eventustbhuangyi/vue-analysis

ustbhuangyi

commit sha c667bd3433e2902d9ba801480445a9cfe969ad7c

use vupress 1.x and add vue 3.x guide

view details

ustbhuangyi

commit sha 158d72dd7937b9c4519c7c8b8bb48996fe3f2382

Merge branch 'master' of github.com:ustbhuangyi/vue-analysis

view details

push time in 4 months

push eventustbhuangyi/vue-3.x-demos

ustbhuangyi

commit sha e7a2473620572be3fe39b5325e18394e3aaeabf6

update vue-next packages

view details

push time in 4 months

PublicEvent

startedustbhuangyi/vue-3.x-demos

started time in 4 months

push eventustbhuangyi/vue-3.x-demos

ustbhuangyi

commit sha c14d34fd45d8d975f2a5686fe1099de7e4517fe8

ignore idea

view details

push time in 4 months

push eventustbhuangyi/vue-3.x-demos

ustbhuangyi

commit sha 07e5b5cd5d989492cb14fad783a398568cce6129

rm idea

view details

push time in 4 months

startedtj/n

started time in 5 months

startedvuejs/vue-next

started time in 5 months

startedsass/sass

started time in 5 months

startedsindresorhus/multi-download

started time in 5 months

issue commentDDFE/DDFE-blog

滴滴 webapp 5.0 Vue 2.0 重构经验分享

@zicong-zhang 业务线打包生成 JS 发布到 cdn,同时更新 JSON 配置文件,主应用的后端负责读取业务线的 JSON 配置文件,然后输出到前端模板中,这样主应用前端就可以知道加载的 JS 地址了。

PS:现在回想自己当年做的这个,不就是现在炒的火热的”微前端”?

ustbhuangyi

comment created time in 5 months

startedw3c/csswg-drafts

started time in 5 months

Pull request review commentvideojs/video.js

fix: update the progress-bar correctly when pausing the video and cli…

 class SeekBar extends Slider {         this.duration_ = duration;       }     });--    return percent;

Ok, hope for a better solution.

ustbhuangyi

comment created time in 5 months

Pull request review commentvideojs/video.js

fix: update the progress-bar correctly when pausing the video and cli…

 class SeekBar extends Slider {         this.duration_ = duration;       }     });--    return percent;

@gkatsev, If you think removing the throttling of the update function is more reasonable, I will send another pr.

ustbhuangyi

comment created time in 5 months

Pull request review commentvideojs/video.js

fix: update the progress-bar correctly when pausing the video and cli…

 class SeekBar extends Slider {         this.duration_ = duration;       }     });--    return percent;

I tried to remove the throttling of the update function, it works, but may cause a little perf issue. So there's a trade-off.

ustbhuangyi

comment created time in 5 months

Pull request review commentvideojs/video.js

fix: update the progress-bar correctly when pausing the video and cli…

 class SeekBar extends Slider {         this.duration_ = duration;       }     });--    return percent;

Since the percent depends on the Slider's update function. The return of undefined does not make sense. https://github.com/videojs/video.js/blob/master/src/js/slider/slider.js#L238-L248

ustbhuangyi

comment created time in 5 months

Pull request review commentvideojs/video.js

fix: update the progress-bar correctly when pausing the video and cli…

 class SeekBar extends Slider {         this.duration_ = duration;       }     });--    return percent;

Before this follow commit: https://github.com/videojs/video.js/pull/6155 The update function does not has a return value, so I think it's not breaking change.

ustbhuangyi

comment created time in 5 months

Pull request review commentvideojs/video.js

fix: update the progress-bar correctly when pausing the video and cli…

 class SeekBar extends Slider {         this.duration_ = duration;       }     });--    return percent;

The return value of update function seems not used.

ustbhuangyi

comment created time in 5 months

Pull request review commentvideojs/video.js

fix: update the progress-bar correctly when pausing the video and cli…

 class SeekBar extends Slider {         this.duration_ = duration;       }     });--    return percent;

Because the update function is throttled, so even you trigger a timeupdate event manually when finish the seek on mouseup, the update function only called once at the same tick.

ustbhuangyi

comment created time in 5 months

Pull request review commentvideojs/video.js

fix: update the progress-bar correctly when pausing the video and cli…

 class SeekBar extends Slider {     if (document.hidden) {       this.disableInterval_(e);     } else {-      this.enableInterval_();+      if (!this.player_.paused() && !this.player_.hasClass('vjs-waiting')) {

Yes, it's a improvement.It's no need to call update if the player is paused or waiting.

ustbhuangyi

comment created time in 5 months

PR opened videojs/video.js

fix: update the progress-bar correctly when pausing the video and cli…

Description

First, when handle mouse down event of the seek-bar, we set player's scrubbing_ to true, and at the same tick, the update function called and we call super.update(). However, it returns undefined because the progress equals to the previous progress, the root cause is that we get cached currentTime. So we call super.update() in the next tick to make sure we can get the correct progress.

Second, when toggle visibility of the document, we should not call this.enableInterval_() when the player is paused or waiting.

Fixed https://github.com/videojs/video.js/issues/6232

Requirements Checklist

  • [x] Feature implemented / Bug fixed
  • [ ] If necessary, more likely in a feature request than a bug fix
    • [x] Change has been verified in an actual browser (Chome, Firefox, IE)
    • [ ] Unit Tests updated or fixed
    • [ ] Docs/guides updated
    • [ ] Example created (starter template on JSBin)
  • [ ] Reviewed by Two Core Contributors
+4 -5

0 comment

1 changed file

pr created time in 5 months

create barnchustbhuangyi/video.js

branch : fix-seek-bar

created branch time in 5 months

fork ustbhuangyi/video.js

Video.js - open source HTML5 & Flash video player

https://videojs.com

fork in 5 months

issue openedvideojs/video.js

[Bug report] ProgressBar does not update as expected

Description

When pausing the video and click the ProgressBar, the video update but the ProgressBar does not update as expected.

Test it with 'https://codepen.io/gkatsev/pen/GwZegv?editors=1000#0'.

Steps to reproduce

  1. click Play Button
  2. click Pause Button
  3. click ProgressBar

Results

Expected

Video update and ProgressBar update to the right position.

Actual

Video update but ProgressBar does not update.

Additional Information

versions

videojs

after v7.5.1, v7.5.0 is fine.

browsers

Chrome、Firefox etc.

OSes

Mac OS

created time in 5 months

more