profile
viewpoint

rust-lang/areweasyncyet.rs 153

Are we async yet?

mozillazg/rust-pinyin 68

汉字转拼音

mozilla/wg-decisions 5

A place for Gecko developers to track CSSWG decisions

upsuper/bgmrank 5

统计Bangumi上一个用户的收藏的评分分布情况

upsuper/assert-impl 4

Macro for static assert that types implement a trait or not.

siusin/Chinese-Layout 3

Chinese-Layout for W3C notes

servo/gecko-dev 2

Read-only Git mirror of the Mercurial gecko repositories at https://hg.mozilla.org. Please don't submit PRs, see: https://developer.mozilla.org/en-US/docs/Mercurial_FAQ#I%27m_all_used_to_git.2C_but_how_can_I_provide_Mercurial-ready_patches_.3F

upsuper/calories-calc 2

A simple calories calculator

upsuper/arc-bound-demo 1

Calculate bound of arc in an SVG path

push eventrust-lang/areweasyncyet.rs

Deployment Bot (from Travis CI)

commit sha 8342a54b35d491c352b6fe1285c4cc33c0083fa4

Deploy rust-lang/areweasyncyet.rs to github.com/rust-lang/areweasyncyet.rs.git:gh-pages

view details

push time in an hour

delete branch upsuper/rust-semver

delete branch : create-with

delete time in 16 hours

push eventrust-lang/areweasyncyet.rs

Deployment Bot (from Travis CI)

commit sha 1f30326a5b008e2cd32d1d67c070339ec5b4bc8f

Deploy rust-lang/areweasyncyet.rs to github.com/rust-lang/areweasyncyet.rs.git:gh-pages

view details

push time in a day

PR opened zserik/readfilez

simplify code via using delegate-attr
+9 -12

0 comment

2 changed files

pr created time in 2 days

create barnchupsuper/readfilez

branch : delegate-attr

created branch time in 2 days

fork upsuper/readfilez

Quite fast file to slice reading

fork in 2 days

PR opened durka/owned-chars

simplify code via using delegate-attr
+12 -21

0 comment

2 changed files

pr created time in 2 days

create barnchupsuper/owned-chars

branch : delegate-attr

created branch time in 2 days

fork upsuper/owned-chars

Rust package for owned iterators over the the chars of a string

https://crates.io/crates/owned-chars

fork in 2 days

push eventupsuper/delegate-attr

Xidorn Quan

commit sha 2d9bce3fa49d731d245faca540049f24eb211c83

Ensure self token has the right hygiene context Fix issue when using it inside macro.

view details

push time in 2 days

push eventupsuper/delegate-attr

Xidorn Quan

commit sha 16d6a441d4f425d82087c2e0cf84ee7f369eda1f

Add test & example for trait impl

view details

Xidorn Quan

commit sha 4b01b20edcfa6da8ce177cf9e7818e2a93ad204b

Bump version

view details

push time in 2 days

push eventrust-lang/areweasyncyet.rs

Deployment Bot (from Travis CI)

commit sha aebd015f3355e3ba7dfaaf4ae60347bedc6ef3b4

Deploy rust-lang/areweasyncyet.rs to github.com/rust-lang/areweasyncyet.rs.git:gh-pages

view details

push time in 2 days

pull request commentrust-lang/rust

Implement Fn traits for Rc and Arc

Fn traits have been implemented for several std pointer-like types including &, &mut, and Box, so not having it implemented for Rc and Arc itself feels like an inconsistency.

IIUC, the reason #[fundamental] attached to Fn traits was purely for regex to be able to rely on &str: !Fn (as the comment on the attribute shows), which is not being violated anyway. Unless Crater shows otherwise, there isn't evidence that it's actually utilized widely.

Because of the inconsistency, I think this can be considered an oversight when implementing Fn traits and marking them #[fundamental].

upsuper

comment created time in 2 days

push eventupsuper/delegate-attr

Xidorn Quan

commit sha 42e27ff3afb937c281cfb4a2e6f7fa9db24b2dde

Use cargo sync-readme to generate README

view details

Xidorn Quan

commit sha 738fb8c185b50920398b5a7f3afe4e2ed8dcb084

Add CI

view details

Xidorn Quan

commit sha 8b4d9fcd9bc085ef23f3b36a8488258719420e05

Add badges to README

view details

push time in 3 days

issue closedupsuper/delegate-attr

Improve error reporting

closed time in 3 days

upsuper

issue commentupsuper/delegate-attr

Improve error reporting

Fixed by 8a477b4467dd31d207c3f5568f1c10e021213b76, 632b6bb09e1308faa6e0146266ef01163e3f63c9, ac9663dbd82edeace281a26c4d9183374e29a7f9, and 741c76dd72809f6b6367ef8c3a7c46e17a37642b.

upsuper

comment created time in 3 days

push eventupsuper/delegate-attr

Xidorn Quan

commit sha 53539fbc98066f1d8017a138b55f35128d1285aa

Import proc_macro2's TokenStream for use

view details

Xidorn Quan

commit sha 632b6bb09e1308faa6e0146266ef01163e3f63c9

Improve error reporting of attributes

view details

Xidorn Quan

commit sha ac9663dbd82edeace281a26c4d9183374e29a7f9

Handle arbitrary receiver correctly and improve its error reporting

view details

Xidorn Quan

commit sha 741c76dd72809f6b6367ef8c3a7c46e17a37642b

Improve error reporting for input arguments

view details

Xidorn Quan

commit sha 219cb42eab00664d25f484e1c8246bc8832fc722

Add test for empty delegate

view details

Xidorn Quan

commit sha 65fe01e95684c69389b3bb8d706f86ff67edcd15

Bump version

view details

push time in 3 days

push eventrust-lang/areweasyncyet.rs

Deployment Bot (from Travis CI)

commit sha f953a38a867fbc574e63a6d33748e6d0a34058d3

Deploy rust-lang/areweasyncyet.rs to github.com/rust-lang/areweasyncyet.rs.git:gh-pages

view details

push time in 3 days

push eventrust-lang/areweasyncyet.rs

Deployment Bot (from Travis CI)

commit sha 6f262ccf95d77d2fc51911da88ddea0396bfa38e

Deploy rust-lang/areweasyncyet.rs to github.com/rust-lang/areweasyncyet.rs.git:gh-pages

view details

push time in 4 days

issue closedupsuper/delegate-attr

Add compiletest

closed time in 4 days

upsuper

issue commentupsuper/delegate-attr

Add compiletest

Done by a21e388d8cf954034e1801828c6355a7428407b6

upsuper

comment created time in 4 days

push eventupsuper/delegate-attr

Xidorn Quan

commit sha 2fba5986345bf78417112e3012a3295994d68061

Add FUNDING.yml

view details

push time in 4 days

push eventupsuper/delegate-attr

Xidorn Quan

commit sha a21e388d8cf954034e1801828c6355a7428407b6

Add some basic compile tests

view details

Xidorn Quan

commit sha 8a477b4467dd31d207c3f5568f1c10e021213b76

Improve error reporting for invalid delegate input

view details

push time in 4 days

push eventrust-lang/areweasyncyet.rs

Deployment Bot (from Travis CI)

commit sha ed0fe39f976cc24e55ecd33322dae7ee8b39c77d

Deploy rust-lang/areweasyncyet.rs to github.com/rust-lang/areweasyncyet.rs.git:gh-pages

view details

push time in 5 days

issue openedupsuper/delegate-attr

Add compiletest

created time in 5 days

issue openedupsuper/delegate-attr

Improve error reporting

created time in 5 days

push eventupsuper/delegate-attr

Xidorn Quan

commit sha 1ae9432e70c0f922a793e4116399d8eb54406864

Sync examples to README

view details

Xidorn Quan

commit sha fd30150ba55a7f39a6c346f592b9750bbef28195

Bump version

view details

push time in 5 days

issue openedrust-lang/cargo

Pass path or filename of built artifact to tests

<!-- Thanks for filing a 🙋 feature request 😄! -->

Describe the problem you are trying to solve <!-- A clear and concise description of the problem this feature request is trying to solve. --> I want to run compile test for procedural macros, but the test does not know how to look for the procedural library it should be testing.

Procedural macros are built to libmy_macro-xxxxxx.so in <target-dir>/<build-type>/deps. While it's possible to direct rustc to look at deps directory, there can be multiple instances of the library in the directory, making rustc unable to decide which one should be picked.

When cargo invokes rustc, however, it passes --extern my_macro=... to pick specific file for it, but tests have no way to get such information, mostly because it doesn't know the hash.

Describe the solution you'd like <!-- A clear and concise description of what you want to happen. --> It would be great if Cargo can pass the path or at least the file name of the built artifact to test via some new environment variable, for example CARGO_LIB_<name> or something like that, similar to the existing CARGO_BIN_EXE_<name>.

Notes <!-- Any additional context or information you feel may be relevant to the issue. -->

created time in 5 days

issue closedupsuper/delegate-attr

Support `#[call(method)]` attribute

... which should use the given method name instead for the generated code.

closed time in 5 days

upsuper

push eventupsuper/delegate-attr

Xidorn Quan

commit sha 079cd410befed3af3bd504046c2becefac32c00b

Mark delegated method always inline by default

view details

Xidorn Quan

commit sha 6ce1f1899c7487414801636cf02d54f7594e6539

Add support for #[call] and #[into] Closes #1 and #2.

view details

push time in 5 days

issue closedupsuper/delegate-attr

Support #[into] attribute

... which should add an .into() to the generated code.

closed time in 5 days

upsuper

push eventrust-lang/areweasyncyet.rs

Deployment Bot (from Travis CI)

commit sha 33db54c79146cd4e6c58e8423f59c8ad7a4ab296

Deploy rust-lang/areweasyncyet.rs to github.com/rust-lang/areweasyncyet.rs.git:gh-pages

view details

push time in 6 days

push eventupsuper/delegate-attr

Xidorn Quan

commit sha 798ab911eee5b22b90a258eef7333347aa1a1270

Add slightly more complicated examples

view details

Xidorn Quan

commit sha 66c15e8e04d2646a4171d8180c5f5819ab5ba0ac

Fix syntax highlight in README

view details

push time in 6 days

issue openedupsuper/delegate-attr

Support `#[call(method)]` attribute

... which should use the given method name instead for the generated code.

created time in 6 days

issue openedupsuper/delegate-attr

Support #[into] attribute

... which should add an .into() to the generated code.

created time in 6 days

push eventupsuper/delegate-attr

Xidorn Quan

commit sha 616f0fbacc8cffd550587e826e857980571cf06e

Add readme field

view details

Xidorn Quan

commit sha cae13590916e2d5bad51c2d3a0512a4778ee707b

Switch to expression for receiver

view details

Xidorn Quan

commit sha 22876dbae26ff2a7b1f4eacf3bb0cc39ba64e8d7

Support delegate a single method

view details

Xidorn Quan

commit sha 93f8d001d906e379302955acd7942c7d39245e34

Bump to 0.2

view details

push time in 6 days

create barnchupsuper/delegate-attr

branch : master

created branch time in 6 days

created repositoryupsuper/delegate-attr

Attribute proc-macro to delegate method to a field

created time in 6 days

push eventrust-lang/areweasyncyet.rs

Deployment Bot (from Travis CI)

commit sha 4fcfac427961cb9c51f40f2373a4f1b60c3f94ae

Deploy rust-lang/areweasyncyet.rs to github.com/rust-lang/areweasyncyet.rs.git:gh-pages

view details

push time in 7 days

push eventupsuper/telegram-rustevalbot

Xidorn Quan

commit sha 1c6bf28aa52aea26b365e6c4bd96321665848d84

Add atomic types and null functions to prelude

view details

push time in 7 days

push eventrust-lang/areweasyncyet.rs

Deployment Bot (from Travis CI)

commit sha 8e21c76d5f54eeca748add2e5baa4d09904321a7

Deploy rust-lang/areweasyncyet.rs to github.com/rust-lang/areweasyncyet.rs.git:gh-pages

view details

push time in 8 days

push eventupsuper/taskstats-rs

Xidorn Quan

commit sha 1c3274b8f89a2364f600a92df4ca31cd8b447377

Add readme to Cargo.toml

view details

Xidorn Quan

commit sha 20a1622ecd541bdd47ba3c5e20f04fdf2a944c23

Add repository to Cargo.toml

view details

push time in 9 days

push eventupsuper/taskstats-rs

Xidorn Quan

commit sha 5bdd1cf6e9a9c12ec9c78694b438a1fa6b77dc37

Fix some clippy warnings

view details

push time in 9 days

created tagupsuper/taskstats-rs

tagv0.1.0

High-level encapsulation of Linux's per-task statistics interface in Rust

created time in 9 days

create barnchupsuper/taskstats-rs

branch : master

created branch time in 9 days

created repositoryupsuper/taskstats-rs

High-level encapsulation of Linux's per-task statistics interface in Rust

created time in 9 days

push eventrust-lang/areweasyncyet.rs

Deployment Bot (from Travis CI)

commit sha d0b9fac0666817f0d14e0546db6583ea5a30e223

Deploy rust-lang/areweasyncyet.rs to github.com/rust-lang/areweasyncyet.rs.git:gh-pages

view details

push time in 9 days

push eventrust-lang/areweasyncyet.rs

Deployment Bot (from Travis CI)

commit sha 08671f94cd2785fb98167bb3dcff274e5e6659ce

Deploy rust-lang/areweasyncyet.rs to github.com/rust-lang/areweasyncyet.rs.git:gh-pages

view details

push time in 10 days

push eventupsuper/telegram-rustevalbot

Xidorn Quan

commit sha ad53b25a45a190c01931822bc2bff7097faa609f

Adjust prelude for /eval

view details

Xidorn Quan

commit sha 52ba765cc397f4bd25b5c3aac83da025c107e7e4

Update dependencies

view details

push time in 10 days

push eventrust-lang/areweasyncyet.rs

Deployment Bot (from Travis CI)

commit sha f36d803892ed16356435f71f2544c50a149e47be

Deploy rust-lang/areweasyncyet.rs to github.com/rust-lang/areweasyncyet.rs.git:gh-pages

view details

push time in 11 days

push eventrust-lang/areweasyncyet.rs

Deployment Bot (from Travis CI)

commit sha f463f948b55ac62ca75ec834e3f9232df3f01260

Deploy rust-lang/areweasyncyet.rs to github.com/rust-lang/areweasyncyet.rs.git:gh-pages

view details

push time in 12 days

issue commentw3c/csswg-drafts

[css-writing-modes] 1. addition of "writing-mode:upright-tb;" 2. "HORIZONTAL-IN-VERTICAL TEXT" in this

This example totally blows my mind...

This case would not work under the writing mode model either, because you can't mix different writing modes in the text flow. This has been made clear in the level 3 spec:

If a box has a different writing-mode value than its parent box (i.e. nearest ancestor without display: contents):

  • If the box would otherwise become an in-flow box with a computed display of inline, its display computes instead to inline-block.
  • If the box is a block container, then it establishes an independent block formatting context.
  • More generally, if its specified inner display type is flow, then its computed inner display type becomes flow-root.

However, I think it's probably achievable via extending text-orientation to support rotating characters in horizontal writing modes. With that you would be able to do things like this.

gminky

comment created time in 12 days

push eventrust-lang/areweasyncyet.rs

Deployment Bot (from Travis CI)

commit sha a8b15c280dc070382c3c5350a174b383f0a7c178

Deploy rust-lang/areweasyncyet.rs to github.com/rust-lang/areweasyncyet.rs.git:gh-pages

view details

push time in 13 days

push eventrust-lang/areweasyncyet.rs

Deployment Bot (from Travis CI)

commit sha c6ba878a6d3584c32c6a47a5550630e5eaf5a040

Deploy rust-lang/areweasyncyet.rs to github.com/rust-lang/areweasyncyet.rs.git:gh-pages

view details

push time in 14 days

push eventrust-lang/areweasyncyet.rs

Deployment Bot (from Travis CI)

commit sha 981d5913d190405e8c6f26e882903b503d28dc64

Deploy rust-lang/areweasyncyet.rs to github.com/rust-lang/areweasyncyet.rs.git:gh-pages

view details

push time in 15 days

pull request commentrust-lang/rust

Implement Fn traits for Rc and Arc

I am on board with adding the impls. Could you add some basic test coverage? It's too easy for this kind of impl to become accidentally infinite recursive in a refactor.

Yep, done! Hopefully it's enough to catch this kind of issues.

I actually tried to make one of the impl recursive with #[allow(unconditional_recursion)] (otherwise the compiler errors directly), and the test mysteriously doesn't fall into infinite recursion, but does fail with an incorrect result.

upsuper

comment created time in 16 days

push eventupsuper/rust

Xidorn Quan

commit sha 0cb80ab265f389f054f1f3ee08026596cfd9e6c4

Add tests for Fn impl of Rc and Arc

view details

push time in 16 days

push eventupsuper/rust

Stein Somers

commit sha 8f5c66c6a30cb770da3da953fa911b6c7a5769bb

Introduce BTreeMap benches of iter itself

view details

Stein Somers

commit sha 873022797ae7f09872738c7367d8d658a1a34ad5

Speed up BTreeMap iteration by intertwined descend to the initial leaf edges

view details

ThinkChaos

commit sha f121f094fe4d4f4e92142984e9230373c311e1e6

Add `RefCell::take` In the same vein as `Cell::take` and `Option::take`.

view details

ThinkChaos

commit sha 4ea83bfb3d457770f2e54965dd86f672fbbc87c2

Use Cell::take in a couple places

view details

Stefan Lankes

commit sha 4d3cf5bd9b6c48e5116fb8d9747a7a2dbde09d1d

use new interface to create threads on HermitCore - the new interface allows to define the stack size

view details

Stefan Lankes

commit sha 2c43746758f4bc60bd4dda30a761cf48d1f60635

use nicer code style to define DEFAULT_MIN_STACK_SIZE

view details

Guillaume Gomez

commit sha 9ae85e19dfb6172692908c514f4b4613fe8fe792

Unify lints handling in rustdoc

view details

Dylan MacKenzie

commit sha 23dbd33d9372bdb422eeb3978f4af90faebfb989

Direct contributors to try stage 0 rustdoc first

view details

Dylan MacKenzie

commit sha 5577b3554d3d111f7cff683669b5f7d37539d18d

Suggest stage 1 if stage 0 fails

view details

Dylan MacKenzie

commit sha 1f7c8967dcb695ebc645c9e920c14c9db1e3a440

Ensure that `./x.py doc --stage 0 src/libstd` works via CI

view details

Mark Rousskov

commit sha a1f81ff0ad112d1d8e1ce86df1feb8abcdac76b6

rustdoc supports const re-exports

view details

Bastian Kauschke

commit sha 9f34b82de203a01b7bb1afd57714886a65dbea8f

forbid `dyn Trait` in const generics

view details

Bastian Kauschke

commit sha 2f5c0f59a96612667ca6aeb40b6e40259f861e7e

emit err when using trait objects in pat

view details

Matthew Maurer

commit sha 0e7d5be4b808bd7ccb1d45aa8f7e5026a15aee93

Use .init_array rather than .ctors LLVM TargetMachines default to using the (now-legacy) .ctors representation of init functions. Mixing .ctors and .init_array representations can cause issues when linking with lld. This happens in practice for: * Our profiling runtime which is currently implicitly built with .init_array since it is built by clang, which sets this field. * External C/C++ code that may be linked into the same process. To support legacy systems which may use .ctors, targets may now specify that they use .ctors via the use_ctors attribute which defaults to false. For debugging and manual control, -Z use-ctors-section=yes/no will allow manual override. Fixes: #71233

view details

Mark Rousskov

commit sha 70fafed3c8c48062617a2811d0cd3e0fafcf3319

Remove unsized enum test This was already tested (at least) by src/test/ui/unsized/unsized-enum2.rs

view details

Mark Rousskov

commit sha bfed215cedceecb4e4c45ccf48d86b4a8df3ae38

Remove ignored type alias test This is tracked by a GH issue 17164, and having an ignored test for it isn't helpful.

view details

Ralf Jung

commit sha e2c99f0debfa6b13dc01565e18fc554373d57009

unleashed Miri: open all the gates

view details

Ralf Jung

commit sha 9273962aef4451e67b72539feb463f74e8e790ac

remove no longer needed feature flags

view details

Ralf Jung

commit sha c7eb91652fd26ccee708720ffcaf30954ac43f82

deduplicate warnings

view details

Jubilee Young

commit sha cd4c30940fdbc6755d5e10f2b6f74f6959f1d867

Test for zero-sized function items not ICEing

view details

push time in 16 days

push eventrust-lang/areweasyncyet.rs

Deployment Bot (from Travis CI)

commit sha ed4622f461aad5b4b76c7bc46e7bd087ad06e620

Deploy rust-lang/areweasyncyet.rs to github.com/rust-lang/areweasyncyet.rs.git:gh-pages

view details

push time in 16 days

delete branch upsuper/cargo-xbuild

delete branch : rustc-bootstrap

delete time in 16 days

PR closed rust-osdev/cargo-xbuild

Support building sysroot on stable/beta

RUSTC_BOOTSTRAP=1 is what the Rust itself uses to build itself (because otherwise it wouldn't build on any channel other than nightly).

The justification that std can use unstable features is that it's always bundled with rustc, and whenever an unstable feature changes, std would be updated at the same time.

Since for sysroot we are literally building src from Rust, I think the same justification applies as well.

+2 -9

4 comments

2 changed files

upsuper

pr closed time in 16 days

push eventrust-lang/areweasyncyet.rs

Deployment Bot (from Travis CI)

commit sha 8353b161c2c1bb6e2ebb53900d0ef6d577744a91

Deploy rust-lang/areweasyncyet.rs to github.com/rust-lang/areweasyncyet.rs.git:gh-pages

view details

push time in 17 days

push eventrust-lang/areweasyncyet.rs

Deployment Bot (from Travis CI)

commit sha 4f9aeda83f437bf10d1e572356de9e65cc8575ea

Deploy rust-lang/areweasyncyet.rs to github.com/rust-lang/areweasyncyet.rs.git:gh-pages

view details

push time in 18 days

issue closedmozilla/wg-decisions

[css-ruby] Applicability of width & height to various kinds of ruby boxes

A resolution was made for csswg-drafts/#4974.

[css-ruby] Applicability of width & height to various kinds of ruby boxes

  • RESOLVED: width and height don't apply to non-atomic ruby boxes

Discussion.


To file a bug automatically for these resolutions, add the bug label to the issue.

If no bug is needed, the issue can be closed.

closed time in 19 days

mozilla-apprentice

issue closedmozilla/wg-decisions

[css-ruby] Applicability and effect of margin / border / padding on ruby containers

A resolution was made for csswg-drafts/#4976.

[css-ruby] Applicability and effect of margin / border / padding on ruby containers

  • RESOLVED: ruby containers behave like inline boxes, and thus behavior of these properties is the same as for regular inline boxes

Discussion.


To file a bug automatically for these resolutions, add the bug label to the issue.

If no bug is needed, the issue can be closed.

closed time in 19 days

mozilla-apprentice

issue commentmozilla/wg-decisions

[css-ruby] Applicability and effect of margin / border / padding on ruby containers

I believe this matches what we do at the moment.

mozilla-apprentice

comment created time in 19 days

push eventrust-lang/areweasyncyet.rs

Deployment Bot (from Travis CI)

commit sha 79417a9a45f6970d5d7469006112c3ed8bd1213f

Deploy rust-lang/areweasyncyet.rs to github.com/rust-lang/areweasyncyet.rs.git:gh-pages

view details

push time in 19 days

issue commentw3c/csswg-drafts

[css-ruby] Box model / layout model for nested ruby containers (block axis)

Thinking about this again, I found that it would be interesting if the nested ruby is inside a vertical-aligned span inside another ruby base. It would come back to the vertical-align issue we discussed on day 2 but with an even trickier situation.

frivoal

comment created time in 19 days

issue closedmozilla/wg-decisions

[css-ruby] effect of `line-height` on nested ruby containers

A resolution was made for csswg-drafts/#4986.

[css-ruby] effect of `line-height` on nested ruby containers

  • RESOLVED: nested ruby containers behave as inline boxes for the purpose of line-height

Discussion.


To file a bug automatically for these resolutions, add the bug label to the issue.

If no bug is needed, the issue can be closed.

closed time in 19 days

mozilla-apprentice

issue commentmozilla/wg-decisions

[css-ruby] effect of `line-height` on nested ruby containers

I believe this is the current Firefox behavior.

mozilla-apprentice

comment created time in 19 days

issue closedmozilla/wg-decisions

[css-ruby] Does line-height have an effect on any of the ruby boxes?

Resolutions were made for csswg-drafts/#4979.

[css-ruby] Does line-height have an effect on any of the ruby boxes?

  • RESOLVED: line-height on the ruby container doesn't affect the boxes inside
  • RESOLVED: ruby containers, ruby bases and ruby base containers act like inline boxes, we'll use line-height as an example and call out exceptions in the spec
  • RESOLVED: line-height doesn't apply to annotations or annotation containers

Discussion.


To file a bug automatically for these resolutions, add the bug label to the issue.

If no bug is needed, the issue can be closed.

closed time in 19 days

mozilla-apprentice

issue commentmozilla/wg-decisions

[css-ruby] Does line-height have an effect on any of the ruby boxes?

That's the current Firefox behavior.

mozilla-apprentice

comment created time in 19 days

push eventrust-lang/areweasyncyet.rs

Deployment Bot (from Travis CI)

commit sha dd095012969df4950ac8b54a471495147e18f7a4

Deploy rust-lang/areweasyncyet.rs to github.com/rust-lang/areweasyncyet.rs.git:gh-pages

view details

push time in 20 days

push eventupsuper/default-boxed

Xidorn Quan

commit sha 9dd88008fd160387bb643816f47d9ab456318c22

Switch to GitHub Actions

view details

push time in 20 days

push eventupsuper/default-boxed

Xidorn Quan

commit sha 96c931c5e7bd326c89e9b36e2c1e878afaf90bef

Make the crate no_std Fixes #2.

view details

push time in 20 days

issue closedupsuper/default-boxed

Make this crate `no_std`

The crate is no_std-ready, but without no_std because we need to figure out what should we do with doctest.

Supposedly we can just wait until cfg(doctest) stabilized, then use #![cfg_attr(not(doctest), no_std)].

closed time in 20 days

upsuper

push eventrust-lang/areweasyncyet.rs

Deployment Bot (from Travis CI)

commit sha 5a5173b296c2ac53de4bea655851ef4a5cdcf406

Deploy rust-lang/areweasyncyet.rs to github.com/rust-lang/areweasyncyet.rs.git:gh-pages

view details

push time in 21 days

issue openedweb-platform-tests/wpt

ruby-position tests upstreamed from Chromium are incorrect

The tests upstreamed in #23221 fails on Firefox, and after inspecting the test, I believe there are two tests that are actually incorrect.

According to the spec, ruby-position only applies to ruby annotation containers, but there are two tests try to check it on <rt> which is ruby annotation, and thus should not be effective.

Please take a look, thanks.

cc @tkent-google @kojiishi

created time in 21 days

release rust-lang/areweasyncyet.rs

v20200504

released time in 21 days

push eventrust-lang/areweasyncyet.rs

Deployment Bot (from Travis CI)

commit sha a5ddb4e66dcb4219f14e24dd55353287f2678121

Deploy rust-lang/areweasyncyet.rs to github.com/rust-lang/areweasyncyet.rs.git:gh-pages

view details

push time in 21 days

issue commentrust-lang/areweasyncyet.rs

Actix: async ecosystem

Thanks for the suggestion.

naturallymitchell

comment created time in 21 days

created tagrust-lang/areweasyncyet.rs

tagv20200504

Are we async yet?

created time in 21 days

push eventrust-lang/areweasyncyet.rs

Xidorn Quan

commit sha 71270f4ed532846012f880dc21fbc78aeeef7599

Add actix to ecosystem Closes #31.

view details

push time in 21 days

issue closedrust-lang/areweasyncyet.rs

Actix: async ecosystem

How about an Actix mention in async ecosystem?

Something like:

Actix provides a higher-level abstraction for tokio which simplifies the creation and management of tokio event loops.

closed time in 21 days

naturallymitchell

issue openedupsuper/default-boxed

Add unsafe block in generated unsafe fn

With unsafe_block_in_unsafe_fn, we would need to have unsafe block in the unsafe fn we generate here.

created time in 22 days

issue openedupsuper/cstr

Drop the procedural-masquerade hack once fn-like proc macros in expression position is stabilized

We can drop the hack once rust-lang/rust#68717 gets merged and reaches stable.

created time in 22 days

push eventrust-lang/areweasyncyet.rs

Deployment Bot (from Travis CI)

commit sha 20e9d0cad6c21afdbd83427c555c1cdc10a6b354

Deploy rust-lang/areweasyncyet.rs to github.com/rust-lang/areweasyncyet.rs.git:gh-pages

view details

push time in 22 days

Pull request review commentrust-lang/rust

Implement Fn traits for Rc and Arc

 impl<T: ?Sized> fmt::Pointer for Rc<T> {     } } +#[unstable(feature = "rc_fn", issue = "none")]

Updated to mark it stable.

upsuper

comment created time in 23 days

push eventupsuper/rust

flip1995

commit sha b8b47ab6fe4e1c18db2685c406a508fe145c7de9

Add bors dummy jobs

view details

flip1995

commit sha abb095ddedd3c918d7c55d028d7f134bf4a507d3

Run bors checks unconditionally This is important, since bors doesn't know optional jobs. Otherwise bors would time out, when a check doesn't get run.

view details

flip1995

commit sha b47dada167dea3d889abd77b7ff584afdaaf0a86

Apply review comments

view details

flip1995

commit sha 622ece3153c7e0cf4144ee468d45d1ed4de19bd0

Remove deployment from travis

view details

flip1995

commit sha 27453463f2615920fa964625f104d6822c105b32

Install all required remark packages in travis

view details

flip1995

commit sha a0a21a8752b3e1616d183c9e407e5d78de39bd1e

Use nightly cargo to install cargo-cache Stable cargo install still errors when packages exists, instead of updating it

view details

flip1995

commit sha 3fac289c3d7f9caea256ce6cc65b54e214aa776e

Don't upload target/release in integration_build This dir was generated by compiling RTIM, when no cache is available

view details

bors

commit sha 71a5379bda71f19539dabac0232330561e19be1a

Auto merge of #5088 - rust-lang:gha, r=Manishearth,flip1995 Switch to GitHub Actions - Part 2 - From within This is a continuation of #5071. This time from a branch inside the rust-lang/rust-clippy repo, not from my fork, since secrets are not available in PRs from forks. Copying the description of #5071 to here: Closes #4577 ~~This is just an experiment. I don't think we have a consensus _if_ we should move away from travis/appveyor.~~ We have consensus: https://github.com/rust-lang/rust-clippy/pull/5071#issuecomment-576647638 ~~GHA would let us run up to 20 concurrent jobs. Since we have 15 integration tests and 4 (linux, linux 32-bit, macos, windows) basic tests, we would be able to run everything concurrently.~~ The org has a limit of 60 jobs across the org, so we limit the matrix of the integration tests to 6 concurrent jobs. ~~Also IIUC we only have to build Clippy once for every initegration test and then only check the repos.~~ Nope, dependent jobs exist, but they won't keep the artifacts (not even the checkout). TODO before merge: - [x] Add `DEPLOY_KEY` secret to github repo - [x] test deployment on test branch `gh-test`# - [x] Test normal deployment - [x] Test deployment no changes - [x] Test deployment of tag - [x] talk with `@rust-lang/infra` for bors, `@rust-lang/infra` is good with the move (crater also uses GHA+bors) - [x] ~~Get remark + clippy_dev check to work on pushes (https://github.community/t5/GitHub-Actions/~Builds-are-not-triggered-with-on-paths/m-p/44075; I contacted GH support about this) ~~That seems to start working again yesterday. Let's hope it keeps working.~~ Or not: df9be48. Now it works again: 723786a. I think we should wait, until this is reliable. It appears, that it doesn't work on force pushes (sometimes?): 5814142~~ We need to run the bors tests unconditionally anyway (47138d1) so it doesn't really matter. - [x] ~~impl homu checks for GHA https://github.com/rust-lang/rust-clippy/pull/5071#issuecomment-576642983 -- I prepared: https://github.com/flip1995/rust-central-station/commit/f40230dc3cebfe4120c9dce027f61c18dd8935cb. I'd suggest to first add GHA and keep the travis and appveyor checks for a few days and to remove them in a second pass. The bors dummy jobs are added in https://github.com/rust-lang/rust-clippy/pull/5088/commits/1a83b7ad7a45aa8db4db7da55a45931e725a1ca3 and work as expected: https://github.com/rust-lang/rust-clippy/pull/5088#issuecomment-582055695. I opened https://github.com/rust-lang/rust-central-station/pull/578~~ See https://github.com/rust-lang/rust-clippy/pull/5088#issuecomment-584581420 - [x] ~Add GHA badge to Cargo.toml (blocked on rust-lang/crates.io # 1838)~ Added a FIXME in 2332b57 - [x] ~Maybe we should also wait until GHA supports yaml anchors. https://github.community/t5/GitHub-Actions/Support-for-YAML-anchors/td-p/30336/~ WIll probably not be implemented in the near future. - [x] Add back travis + appveyor files for transition period (!) changelog: none

view details

flip1995

commit sha b0d25de54a62451cb5699080b69219ac12247023

Use list instead of array for branch names This is the officially supported method

view details

bors

commit sha 2432a16973bf50665f75cb3e56cab1611bd96ec0

Auto merge of #5162 - flip1995:gha_fix, r=flip1995 Fix GHA after the merge changelog: none

view details

flip1995

commit sha fb59043621f9297d641b16d3a7151c69e70f515e

Change badge branch master -> auto For some reason GHA classifies the bors merges on the master branch as a push to the auto branch, even though the workflow got triggered by a push to the master branch. I guess this has something to do with the same commit hash on master+auto directly after the merge?

view details

flip1995

commit sha 3241e4fed451b12e0fc347b1a2f884c832f2294e

Run deploy workflow on tags, instead of releases

view details

bors

commit sha 15c7841de09bbc0c91b18c029cf9dfe535dac99e

Auto merge of #5164 - flip1995:gha_deploy_fix, r=flip1995 Fix tag deployment on GHA I just want to test some things here currently. changelog: none

view details

Matthias Krüger

commit sha b755a7d714c40176958bf9a3da7896b50bebef47

gha: install cargo-cache with ci-autoclean feature which speeds up build time by a large margin.

view details

bors

commit sha eaed72f5372874622b32eb0138bcd56bab01a25a

Auto merge of #5165 - matthiaskrgr:ci_cargo_cache_autoclean, r=flip1995 gha: install cargo-cache with ci-autoclean feature which speeds up build time by a large margin. changelog: none

view details

bors

commit sha f8576c7bf42ce9d21fb92391255640be9da3e155

Auto merge of #5163 - flip1995:gha_fix, r=flip1995 Change badge branch from master to auto For some reason GHA classifies the bors merges on the master branch as a push to the auto branch, even though the workflow got triggered by a push to the master branch. I guess this has something to do with the same commit hash on master+auto directly after the merge? changelog: none

view details

Lily Chung

commit sha 7e0af69f1ce02efc69ca67bd3792969a84949411

Reclassify chars_next_cmp as a style lint. This makes it consistent with chars_last_cmp.

view details

Lily Chung

commit sha 385fd7cd0aa4d95a61962c20e62281c728447ea9

change in the right place, run update_lints

view details

Yuki Okushi

commit sha f77158bc14b991941f92225f85b06d44eb69ee34

Fix false positive in `zero_prefixed_literal`

view details

bors

commit sha 06777d509e768a21b50f2061cafffabebeaed2bc

Auto merge of #5170 - JohnTitor:fix-prefix, r=flip1995 Fix false positive in `zero_prefixed_literal` Fixes #5169 changelog: Fix false positive in `zero_prefixed_literal`

view details

push time in 23 days

PR opened rust-lang/rust

Implement Default for MaybeUninit

This would allow structs with MaybeUninit inside to derive Default without adding boilerplate.

+8 -0

0 comment

1 changed file

pr created time in 23 days

create barnchupsuper/rust

branch : maybe-uninit-default

created branch time in 23 days

push eventupsuper/rust

flip1995

commit sha 813d3192bb0267ba2971ab85c115d52119848ff5

Use hash of Cargo.lock file in cache name

view details

flip1995

commit sha b8b47ab6fe4e1c18db2685c406a508fe145c7de9

Add bors dummy jobs

view details

flip1995

commit sha abb095ddedd3c918d7c55d028d7f134bf4a507d3

Run bors checks unconditionally This is important, since bors doesn't know optional jobs. Otherwise bors would time out, when a check doesn't get run.

view details

flip1995

commit sha b47dada167dea3d889abd77b7ff584afdaaf0a86

Apply review comments

view details

flip1995

commit sha 622ece3153c7e0cf4144ee468d45d1ed4de19bd0

Remove deployment from travis

view details

flip1995

commit sha 27453463f2615920fa964625f104d6822c105b32

Install all required remark packages in travis

view details

flip1995

commit sha a0a21a8752b3e1616d183c9e407e5d78de39bd1e

Use nightly cargo to install cargo-cache Stable cargo install still errors when packages exists, instead of updating it

view details

flip1995

commit sha 3fac289c3d7f9caea256ce6cc65b54e214aa776e

Don't upload target/release in integration_build This dir was generated by compiling RTIM, when no cache is available

view details

bors

commit sha 71a5379bda71f19539dabac0232330561e19be1a

Auto merge of #5088 - rust-lang:gha, r=Manishearth,flip1995 Switch to GitHub Actions - Part 2 - From within This is a continuation of #5071. This time from a branch inside the rust-lang/rust-clippy repo, not from my fork, since secrets are not available in PRs from forks. Copying the description of #5071 to here: Closes #4577 ~~This is just an experiment. I don't think we have a consensus _if_ we should move away from travis/appveyor.~~ We have consensus: https://github.com/rust-lang/rust-clippy/pull/5071#issuecomment-576647638 ~~GHA would let us run up to 20 concurrent jobs. Since we have 15 integration tests and 4 (linux, linux 32-bit, macos, windows) basic tests, we would be able to run everything concurrently.~~ The org has a limit of 60 jobs across the org, so we limit the matrix of the integration tests to 6 concurrent jobs. ~~Also IIUC we only have to build Clippy once for every initegration test and then only check the repos.~~ Nope, dependent jobs exist, but they won't keep the artifacts (not even the checkout). TODO before merge: - [x] Add `DEPLOY_KEY` secret to github repo - [x] test deployment on test branch `gh-test`# - [x] Test normal deployment - [x] Test deployment no changes - [x] Test deployment of tag - [x] talk with `@rust-lang/infra` for bors, `@rust-lang/infra` is good with the move (crater also uses GHA+bors) - [x] ~~Get remark + clippy_dev check to work on pushes (https://github.community/t5/GitHub-Actions/~Builds-are-not-triggered-with-on-paths/m-p/44075; I contacted GH support about this) ~~That seems to start working again yesterday. Let's hope it keeps working.~~ Or not: df9be48. Now it works again: 723786a. I think we should wait, until this is reliable. It appears, that it doesn't work on force pushes (sometimes?): 5814142~~ We need to run the bors tests unconditionally anyway (47138d1) so it doesn't really matter. - [x] ~~impl homu checks for GHA https://github.com/rust-lang/rust-clippy/pull/5071#issuecomment-576642983 -- I prepared: https://github.com/flip1995/rust-central-station/commit/f40230dc3cebfe4120c9dce027f61c18dd8935cb. I'd suggest to first add GHA and keep the travis and appveyor checks for a few days and to remove them in a second pass. The bors dummy jobs are added in https://github.com/rust-lang/rust-clippy/pull/5088/commits/1a83b7ad7a45aa8db4db7da55a45931e725a1ca3 and work as expected: https://github.com/rust-lang/rust-clippy/pull/5088#issuecomment-582055695. I opened https://github.com/rust-lang/rust-central-station/pull/578~~ See https://github.com/rust-lang/rust-clippy/pull/5088#issuecomment-584581420 - [x] ~Add GHA badge to Cargo.toml (blocked on rust-lang/crates.io # 1838)~ Added a FIXME in 2332b57 - [x] ~Maybe we should also wait until GHA supports yaml anchors. https://github.community/t5/GitHub-Actions/Support-for-YAML-anchors/td-p/30336/~ WIll probably not be implemented in the near future. - [x] Add back travis + appveyor files for transition period (!) changelog: none

view details

flip1995

commit sha b0d25de54a62451cb5699080b69219ac12247023

Use list instead of array for branch names This is the officially supported method

view details

bors

commit sha 2432a16973bf50665f75cb3e56cab1611bd96ec0

Auto merge of #5162 - flip1995:gha_fix, r=flip1995 Fix GHA after the merge changelog: none

view details

flip1995

commit sha fb59043621f9297d641b16d3a7151c69e70f515e

Change badge branch master -> auto For some reason GHA classifies the bors merges on the master branch as a push to the auto branch, even though the workflow got triggered by a push to the master branch. I guess this has something to do with the same commit hash on master+auto directly after the merge?

view details

flip1995

commit sha 3241e4fed451b12e0fc347b1a2f884c832f2294e

Run deploy workflow on tags, instead of releases

view details

bors

commit sha 15c7841de09bbc0c91b18c029cf9dfe535dac99e

Auto merge of #5164 - flip1995:gha_deploy_fix, r=flip1995 Fix tag deployment on GHA I just want to test some things here currently. changelog: none

view details

Matthias Krüger

commit sha b755a7d714c40176958bf9a3da7896b50bebef47

gha: install cargo-cache with ci-autoclean feature which speeds up build time by a large margin.

view details

bors

commit sha eaed72f5372874622b32eb0138bcd56bab01a25a

Auto merge of #5165 - matthiaskrgr:ci_cargo_cache_autoclean, r=flip1995 gha: install cargo-cache with ci-autoclean feature which speeds up build time by a large margin. changelog: none

view details

bors

commit sha f8576c7bf42ce9d21fb92391255640be9da3e155

Auto merge of #5163 - flip1995:gha_fix, r=flip1995 Change badge branch from master to auto For some reason GHA classifies the bors merges on the master branch as a push to the auto branch, even though the workflow got triggered by a push to the master branch. I guess this has something to do with the same commit hash on master+auto directly after the merge? changelog: none

view details

Lily Chung

commit sha 7e0af69f1ce02efc69ca67bd3792969a84949411

Reclassify chars_next_cmp as a style lint. This makes it consistent with chars_last_cmp.

view details

Lily Chung

commit sha 385fd7cd0aa4d95a61962c20e62281c728447ea9

change in the right place, run update_lints

view details

Yuki Okushi

commit sha f77158bc14b991941f92225f85b06d44eb69ee34

Fix false positive in `zero_prefixed_literal`

view details

push time in 23 days

PR closed upsuper/rust

Merge rust new updates
+124737 -8106

0 comment

1972 changed files

upsuper

pr closed time in 23 days

PR opened upsuper/rust

Merge rust new updates
+124737 -8106

0 comment

1972 changed files

pr created time in 23 days

issue commentrust-lang/rust

Rust doesn't build without "python" name being available

Or if the scripts have been python3-ready, it should probably instead point to python3?

upsuper

comment created time in 23 days

issue openedrust-lang/rust

Rust doesn't build without "python" name being available

Since Ubuntu 20.04, the name python no longer available by default without python-is-python2 package being installed. The build scripts should point to python2 instead.

created time in 23 days

push eventrust-lang/areweasyncyet.rs

Deployment Bot (from Travis CI)

commit sha 500ca9ba3703dedc5f7cb8a0a33ddb60188d7232

Deploy rust-lang/areweasyncyet.rs to github.com/rust-lang/areweasyncyet.rs.git:gh-pages

view details

push time in 23 days

issue commentw3c/csswg-drafts

[css-ruby] vertical-align on ruby bases

So what Firefox currently does is that we assume that ruby base, ruby base container, and ruby container would all align on the same baseline, and size ruby base container and position ruby annotation containers based on that assumption.

A pseudo code of what's happening when reflow a ruby container is:

  1. set baseline and block size of ruby container based on font metrics
  2. for each segment in ruby container:
    1. set ascent and descent to zero
    2. for each pair in the segment:
      1. reflow all ruby annotations of the pair
      2. reflow the ruby base of the pair
      3. set ascent to max(ascent, ascent of the ruby base)
      4. set descent to max(descent, descent of the ruby base)
    3. vertical align all ruby annotations in the segment
    4. use ascent and descent for baseline and block size of the ruby base container
    5. vertical align ruby bases in the segment with non-top/bottom vertical-align
    6. for each ruby annotation container in the segment:
      1. calculate the size of the ruby annotation container to wrap all its children
      2. stack it around the ruby base container
  3. vertical align all ruby base containers with non-top/bottom vertical-align

These steps indicate that the vertical offset of ruby bases doesn't affect the block size of the ruby base container, and consequently doesn't affect the positioning of ruby annotation containers.

The observation is that, the ruby base container needs to have a baseline before its content can be vertically aligned, and because children are positioned relative to their parent's box, we would need the ascent / descent of the container to be available at that point. Theoretically, it is not impossible to update the ascent and descent after doing vertical alignment, but that means an additional step to update the (relative) position of all ruby bases again (after 2.5). Note that this extra step doesn't itself creates cycle, but it's impossible to take vertical-align: top | bottom into account.

So if there isn't a use case for vertical align on ruby base and have it consequently affect its annotation, I think implementation-wise this approach is simpler.

Worth noting that, because ruby annotations form a separate line, and the ruby annotation container is a container of the line (rather than an inline container), it doesn't have a baseline itself, and its size is calculated after vertical aligning ruby annotations, vertical-align on ruby annotations would affect levels outside it.

frivoal

comment created time in 23 days

more