profile
viewpoint

tschaub/authorized 50

Action based authorization middleware.

opengeospatial/wfs3hackathon 7

Repository for information about and results from the WFS 3.0 Hackathon, 6/7 March 2018

elemoine/foss4g2011_presentations 1

OpenLayers Mobile presentation for FOSS4G 2011

openlayers/closure-es-modules 1

Using the Closure Compiler with ES modules

tschaub/bench-it 1

Benchmark your code

tschaub/buildjs 1

Build app for JavaScript libraries.

tschaub/closure-compiler 1

Ringo package for using Google Closure Compiler

tschaub/css-asset-rebaser 1

Copies assets from node_modules and rewrites URLs in CSS

planetlabs/planet-css 0

CSS reset and some basic styles that comply with Planet design

created tagplanetlabs/planet-view-chrome-ext

tagv2.5.0

Extension for Google Chrome displaying Planet Labs imagery

created time in 3 hours

push eventplanetlabs/planet-view-chrome-ext

Tim Schaub

commit sha 4f8b48145114eff1d96f94b5e2b4b9fb152b9c55

Workaround for API using internal URLs

view details

Tim Schaub

commit sha 546ee43ad5abb2861c0558feb206ef897c247141

2.5.0

view details

push time in 3 hours

pull request commentopenlayers/openlayers

Ensure that effective min resolution is never higher than max resolution

#10862 introduced a number of conflicts with these changes. I've pushed a rebased, conflict-free version of your commits in 64a2f3681f32c21a2bda78b46ab9e2b1d749c7e9.

If you want to use this commit, you can do this:

git fetch openlayers
git reset --hard 64a2f3681f32c21a2bda78b46ab9e2b1d749c7e9
git push --force origin view-zoom-glitch
MoonE

comment created time in 5 hours

create barnchopenlayers/openlayers

branch : view-zoom-glitch

created branch time in 5 hours

pull request commentopenlayers/openlayers

Initial work to add filter function support for IsLike

#10862 brought in some new formatting rules that will require a small change to your commit. I've pushed a rebased, reformatted version of your commit in f988fc42a9b9b3617015e396df6a21f834e21a68. You can either do the rebase and reformatting yourself or use this commit.

If you want to rebase and reformat yourself, you can do something like this:

git pull --rebase openlayers master
npm run lint -- --fix

If you want to use the commit above, you can do this:

git fetch openlayers
git reset --hard f988fc42a9b9b3617015e396df6a21f834e21a68

In either case, you'll want to force push a change to your branch after making the changes:

git push --force origin issue-10823
glenselle

comment created time in 5 hours

create barnchopenlayers/openlayers

branch : issue-10823

created branch time in 6 hours

delete branch tschaub/openlayers

delete branch : prettier

delete time in 6 hours

push eventopenlayers/openlayers

Tim Schaub

commit sha 054af0903281760daa80a289d1c1d50481be59cc

Make code prettier This updates ESLint and our shared eslint-config-openlayers to use Prettier. Most formatting changes were automatically applied with this: npm run lint -- --fix A few manual changes were required: * In `examples/offscreen-canvas.js`, the `//eslint-disable-line` comment needed to be moved to the appropriate line to disable the error about the `'worker-loader!./offscreen-canvas.worker.js'` import. * In `examples/webpack/exapmle-builder.js`, spaces could not be added after a couple `function`s for some reason. While editing this, I reworked `ExampleBuilder` to be a class. * In `src/ol/format/WMSGetFeatureInfo.js`, the `// @ts-ignore` comment needed to be moved down one line so it applied to the `parsersNS` argument.

view details

Tim Schaub

commit sha 3014b68254be3ac0c4cfce9af41d90e2aa321a1b

Merge pull request #10862 from tschaub/prettier Use prettier

view details

push time in 6 hours

PR merged openlayers/openlayers

Use prettier

This updates our ESLint config to use Prettier. This wasn't possible previously because Prettier didn't allow JSDoc-style type casts (see prettier/prettier#7791 for the fix).

Contributors don't need to do any extra setup or install additional editor integrations beyond what they already use with ESLint. In fact, contributors should not set up their editors to use Prettier directly – instead it is used as an ESLint plugin.

If we merge this, all existing pull requests will likely need a rebase, and in some cases the conflicts will be nasty. So we should get in any larger pull requests before this one. After doing a rebase (or at any time), contributors can auto-fix formatting issues with this:

npm run lint -- --fix
+46421 -33353

2 comments

790 changed files

tschaub

pr closed time in 6 hours

push eventtschaub/openlayers

Tim Schaub

commit sha a936545a62329f78d80676ca540cd6d0155332ba

Use latest-browsers tag

view details

push time in 6 hours

push eventtschaub/openlayers

Tim Schaub

commit sha c26171c8498d6516f6e30c6b1ba2ca92f278dacd

Use a virtual framebuffer when running tests

view details

push time in 6 hours

push eventtschaub/openlayers

Tim Schaub

commit sha 054af0903281760daa80a289d1c1d50481be59cc

Make code prettier This updates ESLint and our shared eslint-config-openlayers to use Prettier. Most formatting changes were automatically applied with this: npm run lint -- --fix A few manual changes were required: * In `examples/offscreen-canvas.js`, the `//eslint-disable-line` comment needed to be moved to the appropriate line to disable the error about the `'worker-loader!./offscreen-canvas.worker.js'` import. * In `examples/webpack/exapmle-builder.js`, spaces could not be added after a couple `function`s for some reason. While editing this, I reworked `ExampleBuilder` to be a class. * In `src/ol/format/WMSGetFeatureInfo.js`, the `// @ts-ignore` comment needed to be moved down one line so it applied to the `parsersNS` argument.

view details

push time in 6 hours

PR opened openlayers/openlayers

Do xvfb-run before npm test

I'm trying to address build failures like this:

Failed to launch the browser process!
Fontconfig warning: "/etc/fonts/fonts.conf", line 100: unknown element "blank"
[781:781:0406/183457.293780:ERROR:browser_main_loop.cc(1512)] Unable to open X display.
+1 -1

0 comment

1 changed file

pr created time in 6 hours

create barnchtschaub/openlayers

branch : xvfb-run

created branch time in 6 hours

push eventtschaub/openlayers

Tim Schaub

commit sha 136fb310db1875f068ae5ca373a38561f9c84b38

Make code prettier This updates ESLint and our shared eslint-config-openlayers to use Prettier. Most formatting changes were automatically applied with this: npm run lint -- --fix A few manual changes were required: * In `examples/offscreen-canvas.js`, the `//eslint-disable-line` comment needed to be moved to the appropriate line to disable the error about the `'worker-loader!./offscreen-canvas.worker.js'` import. * In `examples/webpack/exapmle-builder.js`, spaces could not be added after a couple `function`s for some reason. While editing this, I reworked `ExampleBuilder` to be a class. * In `src/ol/format/WMSGetFeatureInfo.js`, the `// @ts-ignore` comment needed to be moved down one line so it applied to the `parsersNS` argument.

view details

push time in 6 hours

push eventtschaub/openlayers

mike-000

commit sha 9d8609dd08c0992a321c5793c5b4b307e7e439a8

Modify and snap to circle in user coordinates Correct modify interaction at center and at drawn circle circumference Correct snap interaction at drawn circle circumference Test circle geometry in a user projection

view details

mike-000

commit sha 560931e9763cf990cae16083e6707b1ef8b35aec

Set reprojection canvas context options Add example of disabling image smoothing Add test for reprojection context options

view details

philip

commit sha b71b87d7bbf4ab1c397af77a1a34f09be5c54179

Fix issue with reprojection and double drawing pixels.

view details

philip

commit sha a6b1df3574bb8f5ea520200a942fbdd7d0caba50

Fix missing corners of the world

view details

philip

commit sha 4040d03ae6ef8054671fda169d239e4dba810b12

Fix problem with zero size canvas drawing

view details

philip

commit sha f457093baf8650edf638c577c6e0cbf033d095b5

Handle the zoomed out case where the source extent is infinite. This does raise the question of whether an Infinite extent intersects a finite extent. It appears not to, but maybe it should.

view details

philip

commit sha 89ed757273b596eff023552dd9e8723df09e9be0

Fix indentation

view details

philip

commit sha e35795c5a38d4d216128e633dbb2db5b84beef1d

Rework code to pass eslint

view details

philip

commit sha 902ed53999bb398e101c824029bee601bffdf7bb

Add detection of browsers which cannot render correctly with diagonal clipping regions. In this case, modify the shape of the clip region so that it has (a number) of horizontal and vertical edges.

view details

philip

commit sha 852f6552c7dae58996893ba271c672d082f71fca

Fix pixel rounding

view details

philip

commit sha 6666014721cb0d4a63de8e59933ac80bdeb01e64

Merge remote-tracking branch 'origin/master' into fix_triangulation Conflicts: src/ol/TileCache.js

view details

philip

commit sha 1772c8198b52f8d7576527ef267c7a7e234be542

Added comment pointing to an area of improvement

view details

philip

commit sha d2b05991772342cf1c9afbc8c6584f6b853a5223

Dynamically chose the number of subdivisions based on the size of the Image.

view details

philip

commit sha ccf3532eb2d4a42e818930dc44e63091dfd369e4

Fix the parameter name to have the opt_ prefix.

view details

philip

commit sha 76b926420c2bc39ffe383b17fe583452963aedd2

Only draw the piece of the source canvas that is required. I.e. take the clip region into account.

view details

Maximilian Krög

commit sha 0057144b52e285c8dbaae5a28896cb6298c74e30

Add apidoc-debug task to debug the apidoc generation process

view details

mike-000

commit sha 7af9697b405e977a056bbc3803276b9861b10f3a

Merge branch 'master' into patch-4

view details

mike-000

commit sha 874b850d76880d8a319f507f934421290cec44ef

Merge branch 'master' into patch-4

view details

Olivier Guyot

commit sha 32321e381cead34f231724120ea834bb2320c69b

View / avoid solving constraints related to map size change during anim

view details

mike-000

commit sha e2ac566c05c6670704b577c316998e9dbf4f4c4f

Correct resolution used for scale. Add dpi option. Also add setDpi and setMinWidth methods Add Print to scale example

view details

push time in 6 hours

pull request commentopenlayers/openlayers

Apidoc - Fix toggle state when there are no hidden members

Thanks, @MoonE .

MoonE

comment created time in 8 hours

push eventopenlayers/openlayers

Maximilian Krög

commit sha a7a21aab088a757b0871c5bc10fc660496bbd71c

Fix toggle state when there are no hidden members

view details

Tim Schaub

commit sha 6eccf21543aaea816cdca9c774832be41512c985

Merge pull request #10882 from MoonE/apidoc-fix-toggle-state Apidoc - Fix toggle state when there are no hidden members

view details

push time in 8 hours

pull request commentopenlayers/openlayers

Ensure that effective min resolution is never higher than max resolution

It might also be worth looking into #10892 when addressing this.

MoonE

comment created time in 11 hours

PR closed openlayers/openlayers

Bump eslint-config-openlayers from 13.0.0 to 14.0.0 dependencies

Bumps eslint-config-openlayers from 13.0.0 to 14.0.0. <details> <summary>Commits</summary> <ul> <li>See full diff in <a href="https://github.com/openlayers/eslint-config-openlayers/commits/v14.0.0">compare view</a></li> </ul> </details> <br />

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


<details> <summary>Dependabot commands and options</summary> <br />

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot badge me will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in the .dependabot/config.yml file in this repo:

  • Update frequency
  • Out-of-range updates (receive only lockfile updates, if desired)
  • Security updates (receive only security updates, if desired)

</details>

+215 -43

1 comment

2 changed files

dependabot-preview[bot]

pr closed time in 12 hours

pull request commentopenlayers/openlayers

Bump eslint-config-openlayers from 13.0.0 to 14.0.0

This will be handled in #10862.

dependabot-preview[bot]

comment created time in 12 hours

push eventopenlayers/openlayers

dependabot-preview[bot]

commit sha c9d27e29d6b36a1a5cd0d919e3ff327a48b45b72

Bump rollup from 2.3.0 to 2.3.3 Bumps [rollup](https://github.com/rollup/rollup) from 2.3.0 to 2.3.3. - [Release notes](https://github.com/rollup/rollup/releases) - [Changelog](https://github.com/rollup/rollup/blob/master/CHANGELOG.md) - [Commits](https://github.com/rollup/rollup/compare/v2.3.0...v2.3.3) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

view details

Tim Schaub

commit sha c8fd78c5b3db3457822d0caa5e2e38901b19aae6

Merge pull request #10889 from openlayers/dependabot/npm_and_yarn/rollup-2.3.3 Bump rollup from 2.3.0 to 2.3.3

view details

push time in 12 hours

PR merged openlayers/openlayers

Bump rollup from 2.3.0 to 2.3.3 dependencies

Bumps rollup from 2.3.0 to 2.3.3. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/rollup/rollup/releases">rollup's releases</a>.</em></p> <blockquote> <h2>v2.3.3</h2> <p><em>2020-04-04</em></p> <h3>Bug Fixes</h3> <ul> <li>Add external namespaces to dynamic namespace objects (<a href="https://github-redirect.dependabot.com/rollup/rollup/issues/3474">#3474</a>)</li> </ul> <h3>Pull Requests</h3> <ul> <li><a href="https://github-redirect.dependabot.com/rollup/rollup/pull/3475">#3474</a>: Support external star exports on namespace objects (<a href="https://github.com/guybedford">@guybedford</a>)</li> </ul> <h2>v2.3.2</h2> <p><em>2020-03-31</em></p> <h3>Bug Fixes</h3> <ul> <li>Only warn but do not fail build when a namespace is called as a function (<a href="https://github-redirect.dependabot.com/rollup/rollup/issues/3475">#3475</a>)</li> <li>Make sure pre-existing sourcemap comments are also removed when rebuilding using the cache (<a href="https://github-redirect.dependabot.com/rollup/rollup/issues/3476">#3476</a>)</li> </ul> <h3>Pull Requests</h3> <ul> <li><a href="https://github-redirect.dependabot.com/rollup/rollup/pull/3475">#3475</a>: Call namespace error as a warning (<a href="https://github.com/guybedford">@guybedford</a>)</li> <li><a href="https://github-redirect.dependabot.com/rollup/rollup/pull/3476">#3476</a>: Store locations for removed comments in cache (<a href="https://github.com/lukastaegert">@lukastaegert</a>)</li> </ul> <h2>v2.3.1</h2> <p><em>2020-03-30</em></p> <h3>Bug Fixes</h3> <ul> <li>Do not fail if the config file returns an function returning a Promise (<a href="https://github-redirect.dependabot.com/rollup/rollup/issues/3472">#3472</a>)</li> </ul> <h3>Pull Requests</h3> <ul> <li><a href="https://github-redirect.dependabot.com/rollup/rollup/pull/3472">#3472</a>: Fix support for async functions as config (<a href="https://github.com/lukastaegert">@lukastaegert</a>)</li> </ul> </blockquote> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/rollup/rollup/blob/master/CHANGELOG.md">rollup's changelog</a>.</em></p> <blockquote> <h2>2.3.3</h2> <p><em>2020-04-04</em></p> <h3>Bug Fixes</h3> <ul> <li>Add external namespaces to dynamic namespace objects (<a href="https://github-redirect.dependabot.com/rollup/rollup/issues/3474">#3474</a>)</li> </ul> <h3>Pull Requests</h3> <ul> <li><a href="https://github-redirect.dependabot.com/rollup/rollup/pull/3475">#3474</a>: Support external star exports on namespace objects (<a href="https://github.com/guybedford">@guybedford</a>)</li> </ul> <h2>2.3.2</h2> <p><em>2020-03-31</em></p> <h3>Bug Fixes</h3> <ul> <li>Only warn but do not fail build when a namespace is called as a function (<a href="https://github-redirect.dependabot.com/rollup/rollup/issues/3475">#3475</a>)</li> <li>Make sure pre-existing sourcemap comments are also removed when rebuilding using the cache (<a href="https://github-redirect.dependabot.com/rollup/rollup/issues/3476">#3476</a>)</li> </ul> <h3>Pull Requests</h3> <ul> <li><a href="https://github-redirect.dependabot.com/rollup/rollup/pull/3475">#3475</a>: Call namespace error as a warning (<a href="https://github.com/guybedford">@guybedford</a>)</li> <li><a href="https://github-redirect.dependabot.com/rollup/rollup/pull/3476">#3476</a>: Store locations for removed comments in cache (<a href="https://github.com/lukastaegert">@lukastaegert</a>)</li> </ul> <h2>2.3.1</h2> <p><em>2020-03-30</em></p> <h3>Bug Fixes</h3> <ul> <li>Do not fail if the config file returns an function returning a Promise (<a href="https://github-redirect.dependabot.com/rollup/rollup/issues/3472">#3472</a>)</li> </ul> <h3>Pull Requests</h3> <ul> <li><a href="https://github-redirect.dependabot.com/rollup/rollup/pull/3472">#3472</a>: Fix support for async functions as config (<a href="https://github.com/lukastaegert">@lukastaegert</a>)</li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/rollup/rollup/commit/d18cb37d7c328a63c36761583ce456275f164462"><code>d18cb37</code></a> 2.3.3</li> <li><a href="https://github.com/rollup/rollup/commit/153cec84617672cb796dac6cbda4852011ffe0e5"><code>153cec8</code></a> Update changelog</li> <li><a href="https://github.com/rollup/rollup/commit/74cec2e0bd1886f9b94a65453b2daaac7d3ef828"><code>74cec2e</code></a> feat: support external star exports on namespace objects (<a href="https://github-redirect.dependabot.com/rollup/rollup/issues/3474">#3474</a>)</li> <li><a href="https://github.com/rollup/rollup/commit/722bc25be4233f2e4a4372dcdca189a3ea2f851c"><code>722bc25</code></a> Update changelog</li> <li><a href="https://github.com/rollup/rollup/commit/9e346a8a8a1338f2cac08d67b2d481b05abed40a"><code>9e346a8</code></a> Update changelog</li> <li><a href="https://github.com/rollup/rollup/commit/b97754ca1dbc1153641ef5af735786850ea92a31"><code>b97754c</code></a> output.{compact,esModule} doc: move <code>Default</code> to newline (<a href="https://github-redirect.dependabot.com/rollup/rollup/issues/3483">#3483</a>)</li> <li><a href="https://github.com/rollup/rollup/commit/85c59bacf1d6864764d4518f232bde6d2fd8c42e"><code>85c59ba</code></a> 2.3.2</li> <li><a href="https://github.com/rollup/rollup/commit/0580f82424e2f3672ca2f8fa0754aa6d14d8fa86"><code>0580f82</code></a> Update changelog</li> <li><a href="https://github.com/rollup/rollup/commit/36cea379b2086d47bd061867185371ed54a69e57"><code>36cea37</code></a> Store locations for removed comments in cache (<a href="https://github-redirect.dependabot.com/rollup/rollup/issues/3476">#3476</a>)</li> <li><a href="https://github.com/rollup/rollup/commit/c69c41be862d3413af2f600eea8985292d64f37f"><code>c69c41b</code></a> feat: Call namespace error as a warning (<a href="https://github-redirect.dependabot.com/rollup/rollup/issues/3475">#3475</a>)</li> <li>Additional commits viewable in <a href="https://github.com/rollup/rollup/compare/v2.3.0...v2.3.3">compare view</a></li> </ul> </details> <br />

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


<details> <summary>Dependabot commands and options</summary> <br />

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot badge me will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in the .dependabot/config.yml file in this repo:

  • Update frequency
  • Out-of-range updates (receive only lockfile updates, if desired)
  • Security updates (receive only security updates, if desired)

</details>

+3 -3

0 comment

1 changed file

dependabot-preview[bot]

pr closed time in 12 hours

push eventopenlayers/openlayers

dependabot-preview[bot]

commit sha 00d6b8272cf1e8ca790cfcda63e7b99a29a90580

Bump handlebars from 4.7.4 to 4.7.6 Bumps [handlebars](https://github.com/wycats/handlebars.js) from 4.7.4 to 4.7.6. - [Release notes](https://github.com/wycats/handlebars.js/releases) - [Changelog](https://github.com/wycats/handlebars.js/blob/master/release-notes.md) - [Commits](https://github.com/wycats/handlebars.js/compare/v4.7.4...v4.7.6) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

view details

Tim Schaub

commit sha 81ef29a51b5860aca7e4c0ad7a4e0a9e444886a0

Merge pull request #10891 from openlayers/dependabot/npm_and_yarn/handlebars-4.7.6 Bump handlebars from 4.7.4 to 4.7.6

view details

push time in 12 hours

PR merged openlayers/openlayers

Bump handlebars from 4.7.4 to 4.7.6 dependencies

Bumps handlebars from 4.7.4 to 4.7.6. <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/wycats/handlebars.js/blob/master/release-notes.md">handlebars's changelog</a>.</em></p> <blockquote> <h2>v4.7.6 - April 3rd, 2020</h2> <p>Chore/Housekeeping:</p> <ul> <li><a href="https://github-redirect.dependabot.com/wycats/handlebars.js/issues/1672">#1672</a> - Switch cmd parser to latest minimist (<a href="https://api.github.com/users/dougwilson">@dougwilson</a></li> </ul> <p>Compatibility notes:</p> <ul> <li>Restored Node.js compatibility</li> </ul> <p><a href="https://github.com/wycats/handlebars.js/compare/v4.7.5...v4.7.6">Commits</a></p> <h2>v4.7.5 - April 2nd, 2020</h2> <p>Chore/Housekeeping:</p> <ul> <li><del>Node.js version support has been changed to v6+</del> Reverted in 4.7.6</li> </ul> <p>Compatibility notes:</p> <ul> <li><del>Node.js < v6 is no longer supported</del> Reverted in 4.7.6</li> </ul> <p><a href="https://github.com/wycats/handlebars.js/compare/v4.7.4...v4.7.5">Commits</a></p> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/wycats/handlebars.js/commit/e6ad93ea01bcde1f8ddaa4b4ebe572dd616abfaa"><code>e6ad93e</code></a> v4.7.6</li> <li><a href="https://github.com/wycats/handlebars.js/commit/2bf4fc6fd3ae3d8f076d628653f284d85faebeb4"><code>2bf4fc6</code></a> Update release notes</li> <li><a href="https://github.com/wycats/handlebars.js/commit/b64202bc9197307bd785a58693e3820eb9bb41a8"><code>b64202b</code></a> Update release-notes.md</li> <li><a href="https://github.com/wycats/handlebars.js/commit/c2f1e6203178918569f085e12afdb762cae17fb0"><code>c2f1e62</code></a> Switch cmd parser to latest minimist</li> <li><a href="https://github.com/wycats/handlebars.js/commit/08e9a11a34c3ad8387a0b85b1334f97cab85191a"><code>08e9a11</code></a> Revert "chore: set Node.js compatibility to v6+"</li> <li><a href="https://github.com/wycats/handlebars.js/commit/1fd2edee2a12fb228061fcde807905c6b14339c4"><code>1fd2ede</code></a> v4.7.5</li> <li><a href="https://github.com/wycats/handlebars.js/commit/3c9c2f5cf29cf10f54d5fe4daca6b24b65f0adcf"><code>3c9c2f5</code></a> Update release notes</li> <li><a href="https://github.com/wycats/handlebars.js/commit/16487a088e13f4d52c6fd6610b9ec71c4a51be8a"><code>16487a0</code></a> chore: downgrade yargs to v14</li> <li><a href="https://github.com/wycats/handlebars.js/commit/309d2b49a11628d2a8f052c5587e7459968cd705"><code>309d2b4</code></a> chore: set Node.js compatibility to v6+</li> <li><a href="https://github.com/wycats/handlebars.js/commit/645ac73844918668f9a2f41e49b7cb18ce5abf36"><code>645ac73</code></a> test: fix integration tests</li> <li>Additional commits viewable in <a href="https://github.com/wycats/handlebars.js/compare/v4.7.4...v4.7.6">compare view</a></li> </ul> </details> <br />

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


<details> <summary>Dependabot commands and options</summary> <br />

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot badge me will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in the .dependabot/config.yml file in this repo:

  • Update frequency
  • Out-of-range updates (receive only lockfile updates, if desired)
  • Security updates (receive only security updates, if desired)

</details>

+6 -5

0 comment

2 changed files

dependabot-preview[bot]

pr closed time in 12 hours

Pull request review commentopenlayers/openlayers

Avoid page scrolling when freehand drawing on mobile

 class Draw extends PointerInteraction {     } else if (move) {       pass = event.type === MapBrowserEventType.POINTERMOVE;       if (pass && this.freehand_) {-        pass = this.handlePointerMove_(event);+        this.handlePointerMove_(event);+        if (this.shouldHandle_) {

Are there cases where this.shouldHandle_ is true and this.handlePointerMove_ wasn’t returning false?

ahocevar

comment created time in a day

pull request commentopenlayers/openlayers

fix return type

Thanks, @mike-000.

mike-000

comment created time in 2 days

push eventopenlayers/openlayers

mike-000

commit sha a1dd9cacf7c2f9ea4b8a3781148d5cc6ac5d887b

fix return type

view details

Tim Schaub

commit sha 61b3fb7111ff2e18fa4b4d956d1d5d81a7ccee00

Merge pull request #10874 from mike-000/patch-11 fix return type

view details

push time in 2 days

PR merged openlayers/openlayers

fix return type

This fixes what looks like and overlap between #10429 and #10840

+3 -3

0 comment

1 changed file

mike-000

pr closed time in 2 days

pull request commentopenlayers/openlayers

Remove inherit doc

It looks like the plugin for @inheritDoc can be removed too. Feel free to cherry pick https://github.com/tschaub/openlayers/commit/6a8f49904ec3b5c2a3c7648f3f6d690b6b5a39f0, to add your own commit, or to merge as is and we can remove it later. The generated docs look the same with and without the plugin.

fredj

comment created time in 3 days

create barnchtschaub/openlayers

branch : remove_inheritDoc

created branch time in 3 days

Pull request review commentopenlayers/openlayers

Remove inherit doc

 class CanvasVectorTileLayerRenderer extends CanvasTileLayerRenderer {   }    /**-   * @inheritdoc

Tricky spelling!

fredj

comment created time in 3 days

pull request commentopenlayers/openlayers

Remove inherit doc

Thanks for all the work on this, @fredj!

fredj

comment created time in 3 days

push eventopenlayers/openlayers

philip

commit sha d2b05991772342cf1c9afbc8c6584f6b853a5223

Dynamically chose the number of subdivisions based on the size of the Image.

view details

philip

commit sha ccf3532eb2d4a42e818930dc44e63091dfd369e4

Fix the parameter name to have the opt_ prefix.

view details

philip

commit sha 72907566bbbb6f760e2fb7be02d22766ecf191cd

Add comment to explain calculation.

view details

Tim Schaub

commit sha c196f2f7b022bcfa2889c47ec4954bead418666e

Merge pull request #10531 from pjsg/fix_image_reproj Dynamically chose the number of subdivisions based on the size of the Image to reproject

view details

push time in 4 days

PR merged openlayers/openlayers

Dynamically chose the number of subdivisions based on the size of the Image to reproject

This fixes #10511 by making the number of subdivisions be large when the object being reprojected is larger. It does this by figuring out the area of the object to be reprojected and seeing how much larger it is than one tile. This is then used to compute the number of subdivisions.

+21 -5

2 comments

3 changed files

pjsg

pr closed time in 4 days

issue closedopenlayers/openlayers

Reprojecting a Tile and an Image should use the same size of triangles

Describe the bug The number of triangles that a Tile and an Image can be split into is defined by the Triangulation class. This is independent of the size of the Image (or Tile).

To Reproduce Look at the code.

Expected behavior I would expect that the number of triangles would be related to the area of the screen covered rather than predetermined. If the Tiles are standard 256x256 tiles and the Image is 1024x1024 then they both have max_subdivision set to 10. I think that the image ought to be using max_subdivision = 14 so that the size of the triangles are comparable. This will make reprojected overlays look better on top of reprojected tiles.

closed time in 4 days

pjsg

pull request commentopenlayers/openlayers

Option to set additional canvas context properties for reprojection

@mike-000, if you ever need to rework a commit, you can commit with the --amend flag and then push with the --force flag.

You'll likely find a lot of suggestions online to avoid rewriting git history (or force pushing), but on this project, we embrace force pushes as a way to make things easier for reviewers. A branch with a few clear, logically separated commits can be a lot less intimidating to review than a branch with many commits that may or may not be significant. If you are working on a shared branch with others, it can require extra communication to make sure force pushes are ok with others (no work should be lost as long as everyone knows how to git pull --rebase some-remote shared-branch or equivalent to get the latest from a shared branch). When you are working individually on a branch, you can force push with impunity.

If you haven't done it before, the workflow would look something like this.

# assuming your remote is named "origin" and your branch is "my-branch"
# if you `git push origin my-branch` and then you realize you want to modify the last commit
git add path/to/the/changed/file.js # with the --patch option if you like to review your changes before adding
git commit --amend
# edit the commit message in your configured `git config --global core.editor`
git push --force origin my-branch

And then a complimentary set of commands if you want to rebase your changes on the latest from OpenLayers:

# assuming the upstream remote is named "openlayers"
git checkout my-banch
git pull --rebase openlayers master
# fix any conflicts (these would be the same conflicts if you had merged, but the fixes will be applied to the appropriate commits)
git push --force origin my-branch

If you already know all this, I hope it doesn't come off as patronizing.

mike-000

comment created time in 4 days

PR closed openlayers/openlayers

Draw interaction: Append coordinates to polygons and lines

<!-- Thank you for your interest in making OpenLayers better!

Before submitting a pull request, it is best to open an issue describing the bug you are fixing or the feature you are proposing to add.

Here are some other tips that make pull requests easier to review:

  • Commits in the branch are small and logically separated (with no unnecessary merge commits).
  • Commit messages are clear.
  • Existing tests pass, new functionality is covered by new tests, and fixes have regression tests.

Thanks --> This was built for an actual use case, as the user needs to be able to follow the borders on a vector layer, without snapping each edge point by hand. This could be a border of a region, or some part of a neighbouring feature. This of course requires some app specific handling for doing the snapping and slicing of those line segments before they can be added to the current geometry.

The extend feature doesn't allow adding points in the other end of a segment, and it also doesn't work on polygons. I was first trying to implement this using the extend feature, but I got confused and thought it was buggy. It was only after runnign the automated build tests that I actually understood what the extend feature was for, and why it was working the way it was. So now I've clarified the feature documentation to separate the two.

One might think all this could be achieved by just taking the coordinate arrays to be joined, concatenate them as you like, and creating a new feature, which then could be used in the extend feature. However, this doesn't work with polygons, as it will break the draw interaction.

The changes requested by @jahow have also been added to the branch, and the example was changed to better illustrate a typical use case.

(The previous pull request was closed by stale bot. I asked how to reopen it, but didn't get any response, so I'm opening a new one. Some discussions are found in the old one https://github.com/openlayers/openlayers/pull/9929)

+390 -8

8 comments

4 changed files

opelline

pr closed time in 4 days

pull request commentopenlayers/openlayers

Draw interaction: Append coordinates to polygons and lines

It looks like this should be closed after #10632. Please reopen if that is wrong.

opelline

comment created time in 4 days

push eventopenlayers/openlayers

Maximilian Krög

commit sha 0057144b52e285c8dbaae5a28896cb6298c74e30

Add apidoc-debug task to debug the apidoc generation process

view details

Tim Schaub

commit sha 0034d6f206be5b4093293d0859799f65eda8dbcb

Merge pull request #10618 from MoonE/apidoc-debug-task Add apidoc-debug task to debug the apidoc generation process

view details

push time in 4 days

PR merged openlayers/openlayers

Add apidoc-debug task to debug the apidoc generation process

Having this committed in the package.json makes it a little easier to work with when it is updated and somebody else may find it useful, too.

+1 -0

0 comment

1 changed file

MoonE

pr closed time in 4 days

pull request commentopenlayers/openlayers

Remove inherit doc

@fredj - this seems like it has good potential. How much more work do you think is needed to get it ready for review?

I want to make sure we don't loose good work by creating nasty conflicts in #10862. But if this is not going to be ready without a lot more work, that would be good to know.

fredj

comment created time in 4 days

PR closed openlayers/openlayers

Apidoc add experimental tag stale

This adds a 'experimental' notice to the api documentation similar to the one that is shown for examples using experimental features. It is shown for module pages when the module is tagged with @experimental and also for class pages belonging to such a module.

Add the ol/layer/WebGLPoints, ol/style/LiteralStyle.js and ol/style/expressions.js as experimental api and thus fixes one dead link from the WebGLPoints module as seen in #10460

+48 -1

4 comments

6 changed files

MoonE

pr closed time in 4 days

pull request commentopenlayers/openlayers

Apidoc add experimental tag

Thanks for your work on this, @MoonE. I'm going to close it for now since I don't think we want to classify "experimental" things at the module level.

We're working on getting a large, formatting only, conflict-prone change in (see #10862). After that is in, we can revisit the idea of more clearly identifying non-stable parts of the API in our docs.

MoonE

comment created time in 4 days

push eventopenlayers/openlayers

mike-000

commit sha 9d8609dd08c0992a321c5793c5b4b307e7e439a8

Modify and snap to circle in user coordinates Correct modify interaction at center and at drawn circle circumference Correct snap interaction at drawn circle circumference Test circle geometry in a user projection

view details

Tim Schaub

commit sha b4e51ed841523bfcb1f87da62a2d2928697bb05a

Merge pull request #10343 from mike-000/patch-10 Correct interactions with circle geometries when using user coordinates

view details

push time in 4 days

PR merged openlayers/openlayers

Correct interactions with circle geometries when using user coordinates

Fixes #10328

Correct modify interaction at center and at drawn circle circumference when using user coordinates. Corresponding update to snap interaction at circumference .

+210 -14

5 comments

4 changed files

mike-000

pr closed time in 4 days

issue closedopenlayers/openlayers

Modify interaction with useGeographic does not interact at drawn circle circumference

Describe the bug Additionally (as observed while investigating #10316) the modify interaction does not act on the circle center as it should.

To Reproduce Draw a circle in this example https://codesandbox.io/s/draw-and-modify-features-voi73 (which will be yellow and circular in the view) and the code will add a red circular polygon based on geographical coordinates which is oval in the view. Hover over both circles and see that the modify interaction is activated only over the red oval, but modifies the radius of the yellow circle. Also it does not activate over the circle center.

However, I cannot see any obvious link between this problem and problems using modify in conjunction with snap in view coordinates in #10316 as there is no problem with using only modify as above in view coordinates.

closed time in 4 days

mike-000

pull request commentopenlayers/openlayers

Correct interactions with circle geometries when using user coordinates

Thank you for your work on this, @mike-000!

mike-000

comment created time in 4 days

pull request commentopenlayers/openlayers

Correct interactions with circle geometries when using user coordinates

Example with the fix applied https://2781-4723248-gh.circle-artifacts.com/0/examples/draw-and-modify-features.html

mike-000

comment created time in 4 days

IssuesEvent

issue commentopenlayers/openlayers

Modify interaction with useGeographic does not interact at drawn circle circumference

Thanks for the report and for the super-helpful example, @mike-000.

mike-000

comment created time in 4 days

pull request commentopenlayers/openlayers

Use prettier

The only thing I am concerned about is the potential merge conflicts we get with open pull requests. Let's really put some effort into reviews of open pull requests before merging this.

Agreed. I'll leave it open and rebase as needed. When we feel ok about the size of the open PR list (maybe zero), we can follow up here and I'll merge.

tschaub

comment created time in 4 days

Pull request review commentopenlayers/openlayers

Use prettier

  * Define an @api tag  * @param {Object} dictionary The tag dictionary.  */-exports.defineTags = function(dictionary) {+exports.defineTags = function (dictionary) {

I think this one is going to take the most getting used to for me. Lots of reading about it on prettier/prettier#3903 - but I still don't really get the justification. But I'm just treating it as another example of a strong belief/convention/habit that there is really no reason to hang on to. It is really kind of liberating to just stop caring about things like this – while still getting satisfaction knowing that the ultimate goal of improved legibility due to consistency is being achieved.

tschaub

comment created time in 4 days

Pull request review commentopenlayers/openlayers

Use prettier

 class WMSGetFeatureInfo extends XMLFeature {           continue;         } -        const featureType = layerName +-            featureIdentifier;+        const featureType = layerName + featureIdentifier;          context['featureType'] = featureType;         context['featureNS'] = this.featureNS_;          /** @type {Object<string, import("../xml.js").Parser>} */         const parsers = {};         parsers[featureType] = makeArrayPusher(-          this.gmlFormat_.readFeatureElement, this.gmlFormat_);+          this.gmlFormat_.readFeatureElement,+          this.gmlFormat_+        );         const parsersNS = makeStructureNS(-          [context['featureNS'], null], parsers);+          [context['featureNS'], null],+          parsers+        );         layerElement.setAttribute('namespaceURI', this.featureNS_);         const layerFeatures = pushParseAndPop(           // @ts-ignore

Addressed in ad851e779f4545bc0a156820e0943f9a7bca0dbc.

tschaub

comment created time in 4 days

push eventtschaub/openlayers

Andreas Hocevar

commit sha 8e6b5ce0bf994a1fb69712e5d6a3f4f0bf4d3019

Update dependencies

view details

Andreas Hocevar

commit sha 612910bcd2d12ebebe8106666d29d0e026fae5a5

Merge pull request #10864 from ahocevar/dependency-updates Update dependencies

view details

Tim Schaub

commit sha ad851e779f4545bc0a156820e0943f9a7bca0dbc

Make code prettier This updates ESLint and our shared eslint-config-openlayers to use Prettier. Most formatting changes were automatically applied with this: npm run lint -- --fix A few manual changes were required: * In `examples/offscreen-canvas.js`, the `//eslint-disable-line` comment needed to be moved to the appropriate line to disable the error about the `'worker-loader!./offscreen-canvas.worker.js'` import. * In `examples/webpack/exapmle-builder.js`, spaces could not be added after a couple `function`s for some reason. While editing this, I reworked `ExampleBuilder` to be a class. * In `src/ol/format/WMSGetFeatureInfo.js`, the `// @ts-ignore` comment needed to be moved down one line so it applied to the `parsersNS` argument.

view details

push time in 4 days

Pull request review commentopenlayers/openlayers

Use prettier

 class WMSGetFeatureInfo extends XMLFeature {           continue;         } -        const featureType = layerName +-            featureIdentifier;+        const featureType = layerName + featureIdentifier;          context['featureType'] = featureType;         context['featureNS'] = this.featureNS_;          /** @type {Object<string, import("../xml.js").Parser>} */         const parsers = {};         parsers[featureType] = makeArrayPusher(-          this.gmlFormat_.readFeatureElement, this.gmlFormat_);+          this.gmlFormat_.readFeatureElement,+          this.gmlFormat_+        );         const parsersNS = makeStructureNS(-          [context['featureNS'], null], parsers);+          [context['featureNS'], null],+          parsers+        );         layerElement.setAttribute('namespaceURI', this.featureNS_);         const layerFeatures = pushParseAndPop(           // @ts-ignore

It looks like this comment needs to get pushed down a couple lines. I'll update in a new commit.

tschaub

comment created time in 4 days

created tagopenlayers/eslint-config-openlayers

tagv14.0.0

ESLint config for OpenLayers

created time in 4 days

push eventopenlayers/eslint-config-openlayers

Tim Schaub

commit sha 569917cd2a19389f9d43f6d90764b859946aef5a

14.0.0

view details

push time in 4 days

delete branch openlayers/eslint-config-openlayers

delete branch : prettier

delete time in 4 days

push eventopenlayers/eslint-config-openlayers

Tim Schaub

commit sha 54c1ce5a9fb8bd82fa71fe224f07b56b8677c48d

Use prettier

view details

Tim Schaub

commit sha 628c6a90bc2217f69ecc82903b29278cb6ddc93f

Remove unnecessary and conflicting rules

view details

Tim Schaub

commit sha a3c538294de13c3fb447bcf672f9a865b108b0b7

Merge pull request #21 from openlayers/prettier Use prettier

view details

push time in 4 days

PR merged openlayers/eslint-config-openlayers

Use prettier

I've been enjoying using Prettier on other projects for a few years. Although initially the style choices may not conform with everyone's tastes, after a while I've found that I no longer notice and instead enjoy having the machine make all whitespace choices for me.

I'm opening this pull request to get the opinions of others before proposing that we update the configuration for OpenLayers. The change there will involve a ton of churn, and it will break all outstanding pull requests. After that one time pain, things will work as they do currently – no extra tools or editor configuration is needed on the part of contributors – in particular, people will not have to and should not configure their editors to use Prettier directly.

The reason it is possible to use Prettier with OpenLayers now is because it now accepts JSDoc style type casts (see prettier/prettier#7791).

+917 -519

3 comments

7 changed files

tschaub

pr closed time in 4 days

push eventopenlayers/eslint-config-openlayers

Tim Schaub

commit sha 41b710c55e3ba215064ab5b8a390b805880ca397

Use GitHub actions

view details

Tim Schaub

commit sha 1d24b3167e6d768452fdc4bc382a905bc88e0d41

Merge pull request #22 from openlayers/actions Use GitHub actions

view details

Tim Schaub

commit sha 54c1ce5a9fb8bd82fa71fe224f07b56b8677c48d

Use prettier

view details

Tim Schaub

commit sha 628c6a90bc2217f69ecc82903b29278cb6ddc93f

Remove unnecessary and conflicting rules

view details

push time in 5 days

delete branch openlayers/eslint-config-openlayers

delete branch : actions

delete time in 5 days

push eventopenlayers/eslint-config-openlayers

Tim Schaub

commit sha 41b710c55e3ba215064ab5b8a390b805880ca397

Use GitHub actions

view details

Tim Schaub

commit sha 1d24b3167e6d768452fdc4bc382a905bc88e0d41

Merge pull request #22 from openlayers/actions Use GitHub actions

view details

push time in 5 days

PR merged openlayers/eslint-config-openlayers

Use GitHub actions

This runs tests using GitHub actions instead of Travis.

+30 -7

0 comment

2 changed files

tschaub

pr closed time in 5 days

PR opened openlayers/eslint-config-openlayers

Use GitHub actions

This runs tests using GitHub actions instead of Travis.

+30 -7

0 comment

2 changed files

pr created time in 5 days

create barnchopenlayers/eslint-config-openlayers

branch : actions

created branch time in 5 days

push eventtschaub/openlayers

Tim Schaub

commit sha acf90e3aac9457a0764d6bacb4b8564b44e953d3

Use prettier

view details

push time in 5 days

push eventopenlayers/eslint-config-openlayers

Tim Schaub

commit sha 64f60bf06d4cfba7b42769bde9239d1070ecb9f4

Remove unnecessary and conflicting rules

view details

push time in 5 days

pull request commentopenlayers/eslint-config-openlayers

Use prettier

See openlayers/openlayers#10862 for what this will look like in OpenLayers.

tschaub

comment created time in 5 days

PR opened openlayers/openlayers

Use prettier

This updates our ESLint config to use Prettier. This wasn't possible previously because Prettier didn't allow JSDoc-style type casts (see prettier/prettier#7791 for the fix).

Contributors don't need to do any extra setup or install additional editor integrations beyond what they already use with ESLint. In fact, contributors should not set up their editors to use Prettier directly – instead it is used as an ESLint plugin.

If we merge this, all existing pull requests will likely need a rebase, and in some cases the conflicts will be nasty. So we should get in any larger pull requests before this one. After doing a rebase (or at any time), contributors can auto-fix formatting issues with this:

npm run lint -- --fix
+45964 -32963

0 comment

788 changed files

pr created time in 5 days

create barnchtschaub/openlayers

branch : prettier

created branch time in 5 days

push eventopenlayers/eslint-config-openlayers

Tim Schaub

commit sha d660e173f71c46111f45dfa63ac2e0d0d08bbeaa

Remove unnecessary and conflicting rules

view details

push time in 5 days

Pull request review commentopenlayers/eslint-config-openlayers

Use prettier

 class Widget extends Component { }  Widget.propTypes = {-  name: string.isRequired+  name: string.isRequired,

If we don't want to have trailing commas, we can configure the Prettier rule with trailingComma: 'none'. I thought I'd start out by enforcing trailing commas though. I've come to appreciate how much easier it is to edit multi-line object literals and arrays when they are used.

tschaub

comment created time in 5 days

Pull request review commentopenlayers/eslint-config-openlayers

Use prettier

+const obj = {+  'bar': 'foo',+};+ export function foo() {-  return 'foo';+  // This is a legacy style from a time when Closure Compiler would mangle property names.+  // TODO: Confirm this is still needed and remove the `quoteProps: 'preserve'`+  // option for prettier if not.+  return obj['bar'];

I think we have determined that quoting object properties is no longer necessary. I don't think we need to change our convention now, but if we want to in the future, we can remove the quoteProps: 'preserve' configuration.

tschaub

comment created time in 5 days

Pull request review commentopenlayers/eslint-config-openlayers

Use prettier

 import path from 'path'; import {foo} from './mod.js';  function main(paths) {-  return Promise.all(paths.map(function(name) {-    return new Promise(function(resolve, reject) {-      fs.readFile(name, function(err, data) {-        if (err) {-          reject(err);-        } else {-          resolve(String(data));-        }+  return Promise.all(+    paths.map((name) => {+      return new Promise((resolve, reject) => {+        fs.readFile(name, (err, data) => {+          if (err) {+            reject(err);+          } else {+            resolve(String(data));+          }+        });       });-    });-  }));+    })+  ); }  if (require.main === module) {   process.stdout.write(foo()); -  const paths = ['main.js', '.eslintrc'].map(function(name) {-    return path.join(__dirname, name);-  });-  main(paths).then(function(contents) {-    contents.forEach(function(content, index) {-      process.stdout.write(paths[index] + '\n' + content + '\n');+  const paths = /** @type {Array<string>} */ (['main.js', '.eslintrc']);

This is here to demonstrate that JSDoc type casts are supported.

tschaub

comment created time in 5 days

Pull request review commentopenlayers/eslint-config-openlayers

Use prettier

 import path from 'path'; import {foo} from './mod.js';  function main(paths) {-  return Promise.all(paths.map(function(name) {-    return new Promise(function(resolve, reject) {-      fs.readFile(name, function(err, data) {-        if (err) {-          reject(err);-        } else {-          resolve(String(data));-        }+  return Promise.all(+    paths.map((name) => {

We don't have to use arrow functions, but I wanted some examples of formatting where we do use them.

tschaub

comment created time in 5 days

PR opened openlayers/eslint-config-openlayers

Use prettier

I've been enjoying using Prettier on other projects for a few years. Although initially the style choices may not conform with everyone's tastes, after a while I've found that I no longer notice and instead enjoy having the machine make all whitespace choices for me.

I'm opening this as a draft pull request to get the opinions of others before proposing that we update the configuration for OpenLayers. The change there will involve a ton of churn, and it will break all outstanding pull requests. After that one time pain, things will work as they do currently – no extra tools or editor configuration is needed on the part of contributors – in particular, people will not have to and should not configure their editors to use Prettier directly.

The reason it is possible to use Prettier with OpenLayers now is because it now accepts JSDoc style type casts (see prettier/prettier#7791).

+920 -498

0 comment

8 changed files

pr created time in 5 days

create barnchopenlayers/eslint-config-openlayers

branch : prettier

created branch time in 5 days

delete branch openlayers/eslint-config-openlayers

delete branch : dependabot/npm_and_yarn/acorn-6.4.1

delete time in 5 days

push eventopenlayers/eslint-config-openlayers

dependabot[bot]

commit sha 32d74ddb12ae9297aee314939c468a417da995d2

Bump acorn from 6.1.1 to 6.4.1 Bumps [acorn](https://github.com/acornjs/acorn) from 6.1.1 to 6.4.1. - [Release notes](https://github.com/acornjs/acorn/releases) - [Commits](https://github.com/acornjs/acorn/compare/6.1.1...6.4.1) Signed-off-by: dependabot[bot] <support@github.com>

view details

Tim Schaub

commit sha 5d393f1f304e2ca6601d3bba01526624629cea0b

Merge pull request #20 from openlayers/dependabot/npm_and_yarn/acorn-6.4.1 Bump acorn from 6.1.1 to 6.4.1

view details

push time in 5 days

PR merged openlayers/eslint-config-openlayers

Bump acorn from 6.1.1 to 6.4.1 dependencies

Bumps acorn from 6.1.1 to 6.4.1. <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/acornjs/acorn/commit/9a2e9b6678e243d66846b91179d650d28453e70c"><code>9a2e9b6</code></a> Mark version 6.4.1</li> <li><a href="https://github.com/acornjs/acorn/commit/90a9548ea0ce351b54f956e2c4ed27cca9631284"><code>90a9548</code></a> More rigorously check surrogate pairs in regexp validator</li> <li><a href="https://github.com/acornjs/acorn/commit/df0cf1a3e2b1a51a26c14984dc0f5412b7151b10"><code>df0cf1a</code></a> Mark version 6.4.0</li> <li><a href="https://github.com/acornjs/acorn/commit/53034126864b492da4e278628bb972cb2a9313d4"><code>5303412</code></a> Also export Parser via Parser.acorn</li> <li><a href="https://github.com/acornjs/acorn/commit/efe273e70123449a458157dbf578afaf109a49ab"><code>efe273e</code></a> give token types and etc to plugins</li> <li><a href="https://github.com/acornjs/acorn/commit/ac6decb94a3aa4eee99230fdaf5883dfaafe8479"><code>ac6decb</code></a> Mark version 6.3.0</li> <li><a href="https://github.com/acornjs/acorn/commit/7e9817d17639d95cc6dbacfde734a0626b2a7dea"><code>7e9817d</code></a> Allow sourceType: module even with ecmaVersion < 6</li> <li><a href="https://github.com/acornjs/acorn/commit/e2b8cc087386eccc2ad6fd4a02b4257833557cb3"><code>e2b8cc0</code></a> Fix broken parsing of new expressions when allowReserved=="never"</li> <li><a href="https://github.com/acornjs/acorn/commit/1555c528855b10320ce98b4154906d7898c92990"><code>1555c52</code></a> Update acorn.d.ts</li> <li><a href="https://github.com/acornjs/acorn/commit/77c20fa2c2f490e646b67e6a0ff7e75fb54ab6c8"><code>77c20fa</code></a> Mark version 6.2.1</li> <li>Additional commits viewable in <a href="https://github.com/acornjs/acorn/compare/6.1.1...6.4.1">compare view</a></li> </ul> </details> <br />

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


<details> <summary>Dependabot commands and options</summary> <br />

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language

You can disable automated security fix PRs for this repo from the Security Alerts page.

</details>

+3 -3

0 comment

1 changed file

dependabot[bot]

pr closed time in 5 days

issue commentopenlayers/openlayers

Raster webworkers not getting terminated

Thanks for the report, @EvertEt.

EvertEt

comment created time in 5 days

pull request commentopenlayers/openlayers

Add an example of clipping layer based on a vector source

Thanks, @SDaron!

SDaron

comment created time in 6 days

push eventopenlayers/openlayers

Simon Daron

commit sha 23c2e1062ca57cef829582eef11e1ad804152468

Add an example of clipping layer based on a vector source

view details

Tim Schaub

commit sha a073c5ab1e287c1c7a444269f63b821df0496c4a

Merge pull request #10859 from SDaron/clipping-layer Add an example of clipping layer based on a vector source

view details

push time in 6 days

PR merged openlayers/openlayers

Add an example of clipping layer based on a vector source

Following the discussion on #10838. This PR add an example of clipping layer based on a vector source.

+58 -0

0 comment

3 changed files

SDaron

pr closed time in 6 days

issue openeddeepmap/oapi-codegen

Generate functions to get operation URLs

For handlers that generate links to other resources, it would be useful to be able to call a function that generates a URL for an operation. The current NewOperationRequest type functions could be split into two functions. Roughly like this:

func NewOperationRequest(server string, params *OperationParams) (*http.Request, error) {
	operationURL, err := OperationURL(server, params)
	if err != nil {
		return nil, err
	}

	req, err := http.NewRequest("GET", operationURL.String(), nil)
	if err != nil {
		return nil, err
	}

	return req, nil
}

func OperationURL(server string, params *OperationParams) (*url.URL, error) {
	// use existing logic to generate the URL...
}

Would a pull request for something like this be acceptable?

created time in 9 days

pull request commentopenlayers/openlayers

Calculate tile grid extent from extent of bottom-level tile matrix

What an epic! Thanks for your persistence, @mloskot.

mloskot

comment created time in 10 days

issue openedgetkin/kin-openapi

AuthenticationFunc is prone to concurrent map writes

I was surprised to find that my AuthenticationFunc was being called concurrently in multiple goroutines. This periodically was causing fatal error: concurrent map writes because I was updating response headers. It seems like it would be somewhat common to set a header in an authentication function (for example, to add www-authenticate).

At a minimum, it feels like it would be useful to document that people who use AuthenticationFunc to update headers must manage their own locks if they write to the response headers (or otherwise write to a map). I can put together a pull request if this sounds like a good idea.

I'm also curious if it would have a negative impact to run the functions in series. I wonder if there are cases where there are multiple security requirements that are all long running for a single request.

created time in 11 days

issue commentgolangci/golangci-lint

could not run linter xxx:buildssa: analysis skipped: errors in package: xxx could not import xxx

I'm using golangci-lint via the Go extension for VSCode. I think I'm seeing the same issue that others are, but am uncertain if there are other tools used by the extension that are complicating the problem. Apologies if this is not the same issue as above.

I'm running golangci-lint@v1.24.0. Below are the steps to reproduce and the output from golangci-lint.

mkdir example && cd example && go mod init example.com/pkg/example
touch main.go

In VSCode, I paste the following (without imports):

package main

type Soup struct {
	Chicken bool
}

var _ json.Marshaler = (*Soup)(nil)

func (soup *Soup) MarshalJSON() ([]byte, error) {
	if soup.Chicken {
		return []byte(`"yum!"`), nil
	}
	return []byte(`"meh"`), nil
}

func main() {
	soup := &Soup{}
	data, err := json.Marshal(soup)
	if err != nil {
		log.Fatal(err)
	}
	fmt.Printf("soup: %s\n", string(data))
}

I see this output from the Go extension:

Starting linting the current package at /Users/tschaub/projects/example
Error while running tool: /Users/tschaub/go/bin/golangci-lint run --print-issued-lines=false
level=warning msg="[runner] Can't run linter goanalysis_metalinter: assign: failed prerequisites: [inspect@example.com/pkg/example: analysis skipped: errors in package: [/Users/tschaub/projects/example/main.go:7:7: undeclared name: json /Users/tschaub/projects/example/main.go:18:15: undeclared name: json /Users/tschaub/projects/example/main.go:20:3: undeclared name: log /Users/tschaub/projects/example/main.go:22:2: undeclared name: fmt]]"
level=warning msg="[runner] Can't run linter unused: buildir: analysis skipped: errors in package: [/Users/tschaub/projects/example/main.go:7:7: undeclared name: json /Users/tschaub/projects/example/main.go:18:15: undeclared name: json /Users/tschaub/projects/example/main.go:20:3: undeclared name: log /Users/tschaub/projects/example/main.go:22:2: undeclared name: fmt]"
level=error msg="Running error: buildir: analysis skipped: errors in package: [/Users/tschaub/projects/example/main.go:7:7: undeclared name: json /Users/tschaub/projects/example/main.go:18:15: undeclared name: json /Users/tschaub/projects/example/main.go:20:3: undeclared name: log /Users/tschaub/projects/example/main.go:22:2: undeclared name: fmt]"

After accepting the first suggested fix (import encoding/json), I see this output from the Go extension:

Starting linting the current package at /Users/tschaub/projects/example
Error while running tool: /Users/tschaub/go/bin/golangci-lint run --print-issued-lines=false
level=warning msg="[runner] Can't run linter goanalysis_metalinter: SA1025: failed prerequisites: [buildir@example.com/pkg/example: analysis skipped: errors in package: [/Users/tschaub/projects/example/main.go:22:3: undeclared name: log /Users/tschaub/projects/example/main.go:24:2: undeclared name: fmt]]"
level=warning msg="[runner] Can't run linter unused: buildir: analysis skipped: errors in package: [/Users/tschaub/projects/example/main.go:22:3: undeclared name: log /Users/tschaub/projects/example/main.go:24:2: undeclared name: fmt]"
level=error msg="Running error: buildir: analysis skipped: errors in package: [/Users/tschaub/projects/example/main.go:22:3: undeclared name: log /Users/tschaub/projects/example/main.go:24:2: undeclared name: fmt]"

At this point, the extension no longer works, and I see this "Your workspace is misconfigured" dialog.

image

ydcool

comment created time in 12 days

delete branch tschaub/openlayers

delete branch : sponsor

delete time in 21 days

push eventopenlayers/openlayers

Tim Schaub

commit sha dca694ccc9747f5089bea1f02f9739a770f628a5

Add sponsors section to the readme

view details

Tim Schaub

commit sha 9fe84e4dba134dba06646002bd2bf29344dda76c

Merge pull request #10813 from tschaub/sponsor Add sponsors section to the readme

view details

push time in 21 days

issue closedopenlayers/openlayers

Sponsor

@ahocevar @tschaub Hi Gents, Simon from Pozi here. I was wondering if we would be able to get our name on the Readme per the OpenCollective sponsor note. "Become a sponsor and get your logo on our README on Github with a link to your site."

https://opencollective.com/openlayers

Pozi helps connect communities through spatial thinking. We love Openlayers and it forms a core part of our platform. https://pozi.com/ https://app.pozi.com/

image

Thanks and keep up the great work!

closed time in 21 days

hutch120

PR merged openlayers/openlayers

Add sponsors section to the readme

This adds a section to our readme for regular Open Collective sponsors.

Fixes #10812.

+12 -0

0 comment

2 changed files

tschaub

pr closed time in 21 days

issue commentgatsbyjs/gatsby

Enable generating relative (as opposed to root-relative) URL websites

Perhaps some hope in https://github.com/NTmatter/gatsby/commit/921b5f4b2999d9dd6104a5e59055718ffd0c787b.

agentofuser

comment created time in 21 days

IssuesEvent

issue commentopenlayers/openlayers

Sponsor

I’ll reopen this until #10813 is in.

hutch120

comment created time in 21 days

issue commentopenlayers/openlayers

Sponsor

Hi @hutch120.

Let me know what you think of https://github.com/tschaub/openlayers/blob/sponsor/README.md#sponsors

And thank you for your generous support!

hutch120

comment created time in 21 days

PR opened openlayers/openlayers

Add sponsors section to the readme

This adds a section to our readme for regular Open Collective sponsors.

Fixes #10812.

+12 -0

0 comment

2 changed files

pr created time in 21 days

create barnchtschaub/openlayers

branch : sponsor

created branch time in 21 days

more