profile
viewpoint
Trivikram Kamat trivikr @aws Seattle, WA, USA https://twitter.com/trivikram Software Development Engineer | @nodejs core collaborator | @aws SDK JS maintainer | International Speaker

nodejs/node-code-ide-configs 3

VSCode configs to use while developing on Node.js core

Amplifiyer/amplify-js 0

A declarative JavaScript library for application development using cloud services.

trivikr/1x.engineer 0

The official website of 1x Engineers around the world

trivikr/advanced-react-patterns-v2 0

Created with CodeSandbox

trivikr/alerting-kibana-plugin 0

Open Distro for Elasticsearch Kibana Alerting Plugin

trivikr/awesome-deno 0

🎉A curated list of awesome things related to Deno

trivikr/awesome-rust 0

A curated list of Rust code and resources.

trivikr/aws-cdk 0

The AWS Cloud Development Kit is a framework for defining cloud infrastructure in code

trivikr/aws-cdk-examples 0

Example projects using the AWS CDK

trivikr/aws-cdk-intro-workshop 0

Introduction to the AWS CDK - Workshop

issue closedaws/aws-sdk-js-v3

`GetBucketAclCommand` throws `SignatureDoesNotMatch` error

Describe the bug It throws SignatureDoesNotMatch error when getting bucket acl.

SDK version number @aws-sdk/client-s3-node@0.1.0-preview.2

Is the issue in the browser/Node.js? Node.js

Details of the browser/Node.js version v10.15.3

To Reproduce (observed behavior) sample code

const {S3Client} = require('@aws-sdk/client-s3-node')
const {GetBucketAclCommand} = require('@aws-sdk/client-s3-node/commands/GetBucketAclCommand')
const s3 = new S3Client({
    credentials: {
        accessKeyId: 'xxx',
        secretAccessKey: 'xxx'
    }
    region: 'us-east-1'
})
const getBucketAcl = new GetBucketAclCommand({
    Bucket: 'mock'
})
s3.send(getBucketAcl).then(data => console.log(data))

Expected behavior A clear and concise description of what you expected to happen.

Screenshots If applicable, add screenshots to help explain your problem.

Additional context After some investigation, I found that the query string was omitted when signing. Please see below https://github.com/aws/aws-sdk-js-v3/blob/03237744a276b095e07b06f3d678adcaf02c551f/packages/signature-v4/src/getCanonicalQuery.ts#L7-L40 The request uri ofGetBucketAclCommand is "/{Bucket}?acl", and function getCanonicalQuery should return acl instead of empty string.

closed time in 18 minutes

hitlk

push eventaws/aws-sdk-js-v3

awstools

commit sha 2ab1c592f955ed76ea39a8a31f3aacb0e7cbfd0a

Publish v1.0.0-alpha.17

view details

Trivikram Kamat

commit sha 6b3bafa35eaafd7128353870bbeedb74279a8457

fix: remove aws.api from accessanalyzer and codeguruprofiler (#863)

view details

AllanFly120

commit sha 7ba37555d6c2504f33f1ea49fb536ecbe65e9574

fix(client-cognito-identity): insert signing mw selectively instead of removing later (#861) * fix: not inserting signing mw instead of removing later * chore: update client-cognito-identity

view details

Trivikram Kamat

commit sha 547c1125f2a868c568a1cbe724b21551ddd802df

fix: switch to fast-xml-parser (#818)

view details

Trivikram Kamat

commit sha 6227f21468915a929b54bff2fde7484929937884

chore: codegen for switch to fast-xml-parser (#819)

view details

AllanFly120

commit sha 2278f3ee87e27784f65ae8851fca9e3abd48448f

fix: exclude other clients from cognito identity customization (#865)

view details

Chase Coalwell

commit sha 8a4dd05499bbc160e89b428fff1fc49552c51440

fix: invalid serialization of empty body (#860)

view details

Trivikram Kamat

commit sha 0c65de68d6b65b6d8134937f551c80173bacf5fc

feat: add client-codeguruprofiler (#868)

view details

Trivikram Kamat

commit sha 0c95a919e9dac160550ac20c2d525a1ea79307c1

feat: add client-accessanalyzer (#867)

view details

Chase Coalwell

commit sha 9913924e78d6cdfd5e0dfacc440403e3eebe5dfd

feat: remove protocol-timestamp package (#816)

view details

Trivikram Kamat

commit sha 1a8783960a4d5f6124c49a4bdae7d755ead1efed

chore: codegen for invalid serialization of empty body (#869)

view details

awstools

commit sha 70b543013b1db04d7a2cf17034a089a97a9dfec2

Publish v1.0.0-alpha.18

view details

Trivikram Kamat

commit sha dc060814a60e2cf8a9d333f03c40984561df06b7

chore: codegen for URIencode label values (#875)

view details

Kevin Stich

commit sha 3bd1a8c087d14a08dafaebb0f0f596712570e22f

fix: JSON stringify structure/union payloads (#876)

view details

Chase Coalwell

commit sha 66c10e9674fbc56511212297956ee6672e816722

Enable path escaping for all clients except S3 (#877)

view details

Trivikram Kamat

commit sha 63303ea1a0a1804d132d5a0b6f9ee2ed3fb12737

chore: codegen for JSON stringify structure/union payloads (#878)

view details

Trivikram Kamat

commit sha a1d5260b179b3c834cfc9992462c917ab1b0a257

chore: codegen for exporting models/index.ts (#880)

view details

Chase Coalwell

commit sha 07134960c9c5410338285848ac1f3eea8772853f

fix: check null locations (#872)

view details

Trivikram Kamat

commit sha 1bdfed2dc306f4a833f4774e98b834c32cc44b66

chore: codegen for checking null locations (#879)

view details

AllanFly120

commit sha 4c8eb6cf9d5e8a87faf36655ca35605cbe45f3a6

chore(credential-provider-cognito-identity): export es modules (#882)

view details

push time in 9 days

delete branch trivikr/aws-sdk-js-v3

delete branch : codegen-default-errorCode

delete time in 9 days

push eventaws/aws-sdk-js-v3

Trivikram Kamat

commit sha c278e849833edb96b38b1a4c2e8590d3d1bd69f6

chore: codegen for using parsedBody.code in default case (#924)

view details

push time in 9 days

PR merged aws/aws-sdk-js-v3

chore: codegen for using parsedBody.code in default case

Issue #, if available: Refs: https://github.com/awslabs/smithy-typescript/pull/132

Description of changes: codegen for using parsedBody.code in default case

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

+8582 -7193

2 comments

218 changed files

trivikr

pr closed time in 9 days

PR opened aws/aws-sdk-js-v3

chore: codegen for using parsedBody.code in default case

Issue #, if available: Refs: https://github.com/awslabs/smithy-typescript/pull/132

Description of changes: codegen for using parsedBody.code in default case

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

+8582 -7193

0 comment

218 changed files

pr created time in 10 days

create barnchtrivikr/aws-sdk-js-v3

branch : codegen-default-errorCode

created branch time in 10 days

issue closedaws/aws-sdk-js-v3

yarn generate-clients fails with "method does not override or implement a method from a supertype"

Describe the bug yarn generate-clients fails with "method does not override or implement a method from a supertype"

SDK version number The branch smithy-codegen with commit https://github.com/aws/aws-sdk-js-v3/commit/debed62c47656377be305b1e0b9412adcb22b578

To Reproduce (observed behavior)

$ yarn generate-clients -m models
...
...
> Task :smithy-aws-typescript-codegen:compileJava FAILED

stderr: /local/home/trivikr/workspace/aws-sdk-js-v3/codegen/smithy-aws-typescript-codegen/src/main/java/software/amazon/smithy/aws/typescript/codegen/AwsQuery.java:137: error: method does not override or implement a method from a supertype
    @Override

stderr:     ^
/local/home/trivikr/workspace/aws-sdk-js-v3/codegen/smithy-aws-typescript-codegen/src/main/java/software/amazon/smithy/aws/typescript/codegen/AwsEc2.java:137: error: method does not override or implement a method from a supertype
    @Override
    ^
2 errors

FAILURE: Build failed with an exception.

Expected behavior The command yarn generate-clients succeeds

closed time in 10 days

trivikr

issue commentaws/aws-sdk-js-v3

yarn generate-clients fails with "method does not override or implement a method from a supertype"

Will cherry-pick commit from https://github.com/awslabs/smithy-typescript/pull/131 to unblock codegen for https://github.com/awslabs/smithy-typescript/pull/132, while https://github.com/awslabs/smithy-typescript/issues/128 is fixed

trivikr

comment created time in 10 days

issue commentaws/aws-sdk-js-v3

yarn generate-clients fails with "method does not override or implement a method from a supertype"

This happens because https://github.com/aws/aws-sdk-js-v3/pull/917 depends on https://github.com/awslabs/smithy-typescript/pull/131, and I was trying to codegen for https://github.com/awslabs/smithy-typescript/pull/132 by cherry-picking the commit

trivikr

comment created time in 10 days

issue openedaws/aws-sdk-js-v3

yarn generate-clients fails with "method does not override or implement a method from a supertype"

Describe the bug yarn generate-clients fails with "method does not override or implement a method from a supertype"

SDK version number The branch smithy-codegen with commit https://github.com/aws/aws-sdk-js-v3/commit/debed62c47656377be305b1e0b9412adcb22b578

To Reproduce (observed behavior)

$ yarn generate-clients -m models
...
...
> Task :smithy-aws-typescript-codegen:compileJava FAILED

stderr: /local/home/trivikr/workspace/aws-sdk-js-v3/codegen/smithy-aws-typescript-codegen/src/main/java/software/amazon/smithy/aws/typescript/codegen/AwsQuery.java:137: error: method does not override or implement a method from a supertype
    @Override

stderr:     ^
/local/home/trivikr/workspace/aws-sdk-js-v3/codegen/smithy-aws-typescript-codegen/src/main/java/software/amazon/smithy/aws/typescript/codegen/AwsEc2.java:137: error: method does not override or implement a method from a supertype
    @Override
    ^
2 errors

FAILURE: Build failed with an exception.

Expected behavior The command yarn generate-clients succeeds

created time in 10 days

delete branch trivikr/smithy-typescript

delete branch : unmodelled-error-code

delete time in 10 days

pull request commentaws/aws-sdk-js-v3

chore: codegen for using extended URI encoding

CI failure:

$ tsc
lerna ERR! yarn run pretest exited 2 in '@aws-sdk/client-accessanalyzer'
lerna ERR! yarn run pretest stdout:
$ tsc
protocols/Aws_restJson1_1.ts(685,38): error TS2345: Argument of type 'string[]' is not assignable to parameter of type 'string'.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
trivikr

comment created time in 10 days

delete branch trivikr/aws-sdk-js-v3

delete branch : codegen-return-empty-object

delete time in 10 days

push eventaws/aws-sdk-js-v3

Trivikram Kamat

commit sha debed62c47656377be305b1e0b9412adcb22b578

chore: codegen for return empty instead of undefined (#914)

view details

push time in 10 days

PR merged aws/aws-sdk-js-v3

chore: codegen for return empty instead of undefined

Issue #, if available: Refs: https://github.com/aws/aws-sdk-js-v3/pull/885

Description of changes: codegen for return empty instead of undefined

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

+4712 -0

4 comments

21 changed files

trivikr

pr closed time in 10 days

Pull request review commentawslabs/smithy-typescript

fix: set errorCode to parsedBody.code in default case

 static void generateCollectBodyString(GenerationContext context) {                          // Get the protocol specific error location for retrieving contents.                         String errorLocation = bodyErrorLocationModifier.apply(context, "parsedBody");-                        writer.write("errorCode = errorCode || \"UnknownError\";");+                        writer.write("errorCode = parsedBody.code || errorCode;");

Done in https://github.com/awslabs/smithy-typescript/pull/132/commits/6ec5660bce79511c324f585e660ccc3da9f5f9f2

trivikr

comment created time in 10 days

push eventtrivikr/smithy-typescript

Trivikram Kamat

commit sha 6ec5660bce79511c324f585e660ccc3da9f5f9f2

chore: use errorLocation instead of parsedBody

view details

push time in 10 days

PR opened aws/aws-sdk-js-v3

chore: codegen for using extended URI encoding

Issue #, if available: Refs: https://github.com/awslabs/smithy-typescript/pull/130

Description of changes: codegen for using extended URI encoding

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

+7072 -3763

0 comment

76 changed files

pr created time in 10 days

create barnchtrivikr/aws-sdk-js-v3

branch : codegen-extended-uri-encoding

created branch time in 10 days

push eventtrivikr/aws-sdk-js-v3

Trivikram Kamat

commit sha 4920829133e258e2511ec6fe712e2cdcff059c58

chore: codegen from fix in #919

view details

push time in 10 days

issue commentaws/aws-sdk-js-v3

@aws-sdk/client-s3-node S3.deleteObjects SignatureDoesNotMatch error

@KeithGillette The development of alpha versions is being done in smithy-codegen branch and it'll be soon merged to master https://github.com/aws/aws-sdk-js-v3/tree/smithy-codegen

Quick answers:

  • the repository &/or documentation for @aws-sdk/client-s3
    • https://github.com/aws/aws-sdk-js-v3/tree/smithy-codegen
  • Is @aws-sdk/client-s3 a universal client for node & browser?
    • Yes
  • If we should also be switching to @aws-sdk/client-s3 in the browser as well, what are the compatible packages for the related libraries we use with the S3 on the client
    • Please refer browser section of aws-samples/aws-sdk-js-tests https://github.com/aws-samples/aws-sdk-js-tests/tree/master/src/browser
KeithGillette

comment created time in 10 days

IssuesEvent

issue closedaws/aws-sdk-js-v3

@aws-sdk/client-s3-node S3.deleteObjects SignatureDoesNotMatch error

Describe the bug We get the following error when calling S3.deleteObjects in Node.js:

SignatureDoesNotMatch: The request signature we calculated does not match the signature you provided. Check your key and signing method.

S3.deleteObjects works in the browser and S3.deleteObject works in Node.js

SDK version number 0.1.0-preview.2

Is the issue in the browser/Node.js? Node.js

Details of the browser/Node.js version v12.14.1

To Reproduce (observed behavior)

import { DeleteObjectOutput, DeleteObjectsOutput, S3 } from '@aws-sdk/client-s3-node';

export class FileStorageService {
	private s3Client: S3 = new S3({
		credentials: {
			accessKeyId: process.env.ContentBucketKey,
			secretAccessKey: process.env.ContentBucketSecret
		},
		region: process.env.ContentBucketRegion
	});

	// Works fine:
	public deleteOne(s3ObjectKey: string): Promise<DeleteObjectOutput> {
		const s3Parameters = {
			Bucket: process.env.ContentBucketName,
			Key: s3ObjectKey
		};
		return this.s3Client.deleteObject(s3Parameters);
	}

	// Produces `SignatureDoesNotMatch` error:
	public deleteMany(s3ObjectKeyList: string[]): Promise<DeleteObjectsOutput> {
		const s3DeleteObjectsList = s3ObjectKeyList.map((s3ObjectKey: string) => {
			return { Key: s3ObjectKey };
		});
		const s3Parameters = {
			Bucket: process.env.ContentBucketName,
			Delete: {Objects: s3DeleteObjectsList}
		};
		return this.s3Client.deleteObjects(s3Parameters);
	}
}

Expected behavior Given the same S3 client configuration, S3.deleteObjects should work.

Screenshots N/A

Additional context

SignatureDoesNotMatch: The request signature we calculated does not match the signature you provided. Check your key and signing method.
    at RestParser.exports.s3ErrorUnmarshaller [as parseServiceException] (…/node_modules/@aws-sdk/s3-error-unmarshaller/build/index.js:46:58)
    at …/node_modules/@aws-sdk/protocol-rest/build/RestParser.js:27:29
    at …/node_modules/meteor-promise/fiber_pool.js:43:40 {
  name: 'SignatureDoesNotMatch',
  message: 'The request signature we calculated does not match the signature you provided. Check your key and signing method.',
  details: {},
  '$metadata': {
    httpHeaders: {
      'x-amz-request-id': '79694E11BA8B70BE',
      'x-amz-id-2': 'jyNuA8TEvbyThjnk26cq6GwIJdqzofTwITIznmX92g1FAXvqj9ss9QmT2gpPcJBGsukCG9xWdms=',
      'content-type': 'application/xml',
      'transfer-encoding': 'chunked',
      date: 'Tue, 11 Feb 2020 15:47:54 GMT',
      connection: 'close',
      server: 'AmazonS3'
    },
    httpStatusCode: 403,
    requestId: '79694E11BA8B70BE',
    extendedRequestId: 'jyNuA8TEvbyThjnk26cq6GwIJdqzofTwITIznmX92g1FAXvqj9ss9QmT2gpPcJBGsukCG9xWdms=',
    cfId: undefined,
    retries: 0,
    totalRetryDelay: 0
  }
}

closed time in 10 days

KeithGillette

issue commentaws/aws-sdk-js-v3

@aws-sdk/client-s3-node S3.deleteObjects SignatureDoesNotMatch error

Verified that s3. deleteObjects is successful in @aws-sdk/client-s3@1.0.0-alpha.8:

Code:

const AWS = require("aws-sdk");
const { S3 } = require("@aws-sdk/client-s3");

const getRandomString = () =>
  Math.random()
    .toString(36)
    .substring(2);

(async () => {
  let response;
  const bucketName = "test-bucket-" + getRandomString();
  const objectPrefix = "test-object-";
  const params = {
    Bucket: bucketName
  };

  const v2Client = new AWS.S3({ region: "us-west-2" });
  const v3Client = new S3({ region: "us-west-2" });

  console.log(`Creating bucket ${bucketName}`);
  await v3Client.createBucket(params);
  console.log(`Waiting for "${bucketName}" bucket creation\n`);
  await v2Client.waitFor("bucketExists", params).promise();

  for (let i = 0; i < 3; i++) {
    const Key = objectPrefix + getRandomString();
    console.log(`Putting object "${Key}" in ${bucketName}...`);
    await v3Client.putObject({
      Body: "000000",
      Bucket: bucketName,
      Key
    });
  }

  response = await v3Client.listObjects(params);
  console.log(`\nDeleting objects: ${response.Contents.map(obj => obj.Key)}\n`);

  await v3Client.deleteObjects({
    Bucket: bucketName,
    Delete: {
      Objects: response.Contents.map(obj => ({ Key: obj.Key }))
    }
  });

  response = await v3Client.listObjects(params);
  if (!response.Contents) {
    // Confirm that bucket is empty
    console.log(`Bucket ${bucketName} is empty`);
  }

  console.log(`Deleting bucket ${bucketName}`);
  await v2Client.deleteBucket(params).promise();
})();

Output:

Creating bucket test-bucket-gg3u4xcdsa4
Waiting for "test-bucket-gg3u4xcdsa4" bucket creation

Putting object "test-object-bqul94p92ed" in test-bucket-gg3u4xcdsa4...
Putting object "test-object-ficvf9xwrx" in test-bucket-gg3u4xcdsa4...
Putting object "test-object-lr7qz8k77m" in test-bucket-gg3u4xcdsa4...

Deleting objects: test-object-bqul94p92ed,test-object-ficvf9xwrx,test-object-lr7qz8k77m

Bucket test-bucket-gg3u4xcdsa4 is empty
Deleting bucket test-bucket-gg3u4xcdsa4

Closing, please comment if the issue exists

KeithGillette

comment created time in 10 days

push eventtrivikr/smithy-typescript

Trivikram Kamat

commit sha 48286e77c0cdffb724ab6c61d70036e2648df466

fix: set errorCode to parsedBody.code in default case

view details

push time in 10 days

PR opened awslabs/smithy-typescript

fix: set errorCode to parsedBody.name in default case

Issue #, if available: Refs: https://github.com/aws/aws-sdk-js-v3/issues/851

Description of changes:

  • set errorCode to parsedBody.name in default case
  • removes "UnknownError" assignment, as it's initialized on line 268

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

+1 -1

0 comment

1 changed file

pr created time in 10 days

create barnchtrivikr/smithy-typescript

branch : unmodelled-error-code

created branch time in 10 days

push eventtrivikr/smithy-typescript

stickevi

commit sha 67c733a6aa950ce074e1c2f3d66794efcdeb8eba

Allow RPC protocols to set the body without input

view details

Chase Coalwell

commit sha eccc2a5c73511d51a7af92858b70ab9b8aeac252

Use extended URI encoding function (#130)

view details

push time in 10 days

issue commentaws/aws-sdk-js-v3

InvalidParameterValueException not thrown in glacier.uploadArchive when checksum is invalid

This happens because output.headers don't have "x-amzn-errortype" https://github.com/aws/aws-sdk-js-v3/blob/a10e47019abd2e255e72f4462ec67f88b236eab7/clients/client-glacier/protocols/Aws_restJson1_1.ts#L4224-L4227

Because of this, name is set to "UnknownError" https://github.com/aws/aws-sdk-js-v3/blob/a10e47019abd2e255e72f4462ec67f88b236eab7/clients/client-glacier/protocols/Aws_restJson1_1.ts#L4266-L4273

trivikr

comment created time in 10 days

push eventaws/aws-sdk-js-v3

Chase Coalwell

commit sha a10e47019abd2e255e72f4462ec67f88b236eab7

fix: ignore /dist (#920)

view details

push time in 10 days

PR merged aws/aws-sdk-js-v3

fix: ignore /dist

Adds /dist/ to .gitignore following es modules being generated starting with https://github.com/aws/aws-sdk-js-v3/pull/882

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

+1 -0

2 comments

1 changed file

srchase

pr closed time in 10 days

issue commentaws/aws-sdk-js-v3

S3:PutObject doesn't work when key has any non alphanumeric character and getSignerURL doesn't work

Test code for characters in RFC3986 which is not covered:

  • Code: https://github.com/trivikr/aws-sdk-js-tests/blob/ebef5cfe7292cd7fa9aff11020f837ca01e9ec57/src/node.js
  • Branch: https://github.com/trivikr/aws-sdk-js-tests/tree/s3-putObject-RFC3986-test

Code:

const AWS = require("aws-sdk");
const { S3 } = require("@aws-sdk/client-s3");
const { REGION } = require("./config");

(async () => {
  let response;

  const bucketName =
    "test-bucket-" +
    Math.random()
      .toString(36)
      .substring(2);
  const params = {
    Bucket: bucketName
  };
  const prefix = "test-";
  const suffix = ".jpg";

  // Refs: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/encodeURIComponent#Description
  const rfc3986ExtendedChars = "!'()*";

  const v2Client = new AWS.S3({ region: REGION });
  const v3Client = new S3({ region: REGION });

  console.log(`Creating bucket ${bucketName}`);
  await v3Client.createBucket(params);

  // Using v2 waiter, as v3 one is not available
  console.log(`\nWaiting for "${bucketName}" bucket creation\n`);
  await v2Client.waitFor("bucketExists", params).promise();

  for (let i = 0; i < rfc3986ExtendedChars.length; i++) {
    const Key = `${prefix}${rfc3986ExtendedChars.charAt(i)}${suffix}`;
    console.log(`Putting "${Key}" in ${bucketName}`);
    try {
      await v3Client.putObject({
        Body: "000000",
        Bucket: bucketName,
        Key
      });
    } catch (e) {
      console.log(`PutObject "${Key}" failed...`);
    }
  }

  response = await v3Client.listObjects(params);
  console.log("\nlistObjects:");
  console.log(JSON.stringify(response, null, 2));
  console.log("\n");

  if (response.Contents) {
    for (let i = 0; i < response.Contents.length; i++) {
      const { Key } = response.Contents[i];
      console.log(`Deleting "${Key}" from ${bucketName}`);
      await v3Client.deleteObject({
        Bucket: bucketName,
        Key
      });
    }
  }

  console.log(`\nDeleting bucket ${bucketName}`);
  await v3Client.deleteBucket(params);
})();

Output:

Creating bucket test-bucket-15xrr6am05x

Waiting for "test-bucket-15xrr6am05x" bucket creation

Putting "test-!.jpg" in test-bucket-15xrr6am05x
PutObject "test-!.jpg" failed...
Putting "test-'.jpg" in test-bucket-15xrr6am05x
PutObject "test-'.jpg" failed...
Putting "test-(.jpg" in test-bucket-15xrr6am05x
PutObject "test-(.jpg" failed...
Putting "test-).jpg" in test-bucket-15xrr6am05x
PutObject "test-).jpg" failed...
Putting "test-*.jpg" in test-bucket-15xrr6am05x
PutObject "test-*.jpg" failed...

listObjects:
{
  "$metadata": {
    "httpStatusCode": 200,
    "httpHeaders": {
      "x-amz-id-2": "39mUhDIQPkQJJqHfK5CzPjc7rwOaiSqmfS2TsfNl0uh/n1sgnjToMhvxSDIkQe0MaZX4TS8eMDA=",
      "x-amz-request-id": "F9BE59A092CA0217",
      "date": "Tue, 11 Feb 2020 19:54:16 GMT",
      "x-amz-bucket-region": "us-west-2",
      "content-type": "application/xml",
      "transfer-encoding": "chunked",
      "server": "AmazonS3"
    },
    "retries": 0,
    "totalRetryDelay": 0
  },
  "__type": "ListObjectsOutput",
  "IsTruncated": false,
  "Marker": "",
  "MaxKeys": 1000,
  "Name": "test-bucket-15xrr6am05x",
  "Prefix": ""
}

Deleting bucket test-bucket-15xrr6am05x

MDN: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/encodeURIComponent#Description

Amplifiyer

comment created time in 11 days

create barnchtrivikr/aws-sdk-js-tests

branch : s3-putObject-RFC3986-test

created branch time in 11 days

pull request commentaws/aws-sdk-js-v3

chore: codegen for return empty instead of undefined

CI failed:

lerna ERR! yarn run pretest exited 2 in '@aws-sdk/client-s3'
lerna ERR! yarn run pretest stdout:
$ tsc
protocols/Aws_restXml.ts(5780,14): error TS2551: Property 'Error' does not exist on type 'DeleteObjectsOutput'. Did you mean 'Errors'?
protocols/Aws_restXml.ts(5931,14): error TS2339: Property 'AccessControlList' does not exist on type 'GetBucketAclOutput'.
protocols/Aws_restXml.ts(6045,14): error TS2551: Property 'CORSRule' does not exist on type 'GetBucketCorsOutput'. Did you mean 'CORSRules'?
protocols/Aws_restXml.ts(6206,14): error TS2551: Property 'Rule' does not exist on type 'GetBucketLifecycleConfigurationOutput'. Did you mean 'Rules'?
protocols/Aws_restXml.ts(6416,14): error TS2551: Property 'CloudFunctionConfiguration' does not exist on type 'NotificationConfiguration'. Did you mean 'LambdaFunctionConfigurations'?
protocols/Aws_restXml.ts(6430,14): error TS2551: Property 'QueueConfiguration' does not exist on type 'NotificationConfiguration'. Did you mean 'QueueConfigurations'?
protocols/Aws_restXml.ts(6444,14): error TS2551: Property 'TopicConfiguration' does not exist on type 'NotificationConfiguration'. Did you mean 'TopicConfigurations'?
protocols/Aws_restXml.ts(7096,14): error TS2339: Property 'AccessControlList' does not exist on type 'GetObjectAclOutput'.
protocols/Aws_restXml.ts(7715,14): error TS2339: Property 'AnalyticsConfiguration' does not exist on type 'ListBucketAnalyticsConfigurationsOutput'.
protocols/Aws_restXml.ts(7792,14): error TS2339: Property 'InventoryConfiguration' does not exist on type 'ListBucketInventoryConfigurationsOutput'.
protocols/Aws_restXml.ts(7869,14): error TS2339: Property 'MetricsConfiguration' does not exist on type 'ListBucketMetricsConfigurationsOutput'.
protocols/Aws_restXml.ts(8052,14): error TS2551: Property 'Upload' does not exist on type 'ListMultipartUploadsOutput'. Did you mean 'Uploads'?
protocols/Aws_restXml.ts(8138,14): error TS2551: Property 'DeleteMarker' does not exist on type 'ListObjectVersionsOutput'. Did you mean 'DeleteMarkers'?
protocols/Aws_restXml.ts(8182,14): error TS2551: Property 'Version' does not exist on type 'ListObjectVersionsOutput'. Did you mean 'Versions'?
protocols/Aws_restXml.ts(8512,14): error TS2551: Property 'Part' does not exist on type 'ListPartsOutput'. Did you mean 'Parts'?
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
trivikr

comment created time in 11 days

PR opened aws/aws-sdk-js-v3

chore: codegen for return empty instead of undefined

Issue #, if available: Refs: https://github.com/aws/aws-sdk-js-v3/pull/885

Description of changes: codegen for return empty instead of undefined

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

+4712 -0

0 comment

21 changed files

pr created time in 11 days

create barnchtrivikr/aws-sdk-js-v3

branch : codegen-return-empty-object

created branch time in 11 days

push eventaws-samples/aws-sdk-js-tests

Trivikram Kamat

commit sha 7c74b01c9f462397e1ad65b0a246bbcf5b88ed6c

chore: remove unused param from getV3BrowserResponse

view details

push time in 11 days

push eventtrivikr/aws-sdk-js-tests

Trivikram Kamat

commit sha 7c74b01c9f462397e1ad65b0a246bbcf5b88ed6c

chore: remove unused param from getV3BrowserResponse

view details

push time in 11 days

issue commentaws/aws-sdk-js-v3

s3.selectObjectContent returns SignatureDoesNotMatch error

Revisiting this issue testing with @aws-sdk/client-s3@1.0.0-alpha.15

  • Code: https://github.com/trivikr/aws-sdk-js-tests/blob/ce9ebbfadce04e3aad3cc1f14e3070c45930683d/src/shared/utils.js
  • Branch: https://github.com/trivikr/aws-sdk-js-tests/tree/s3-selectObjectContent-test

Output:

Data returned by v2:
AD-0001,heliport,Camí Heliport,,EU,AD,AD-04,La Massana,,,,"42.546257, 1.51916"
AD-ALV,heliport,Andorra la Vella Heliport,3450,EU,AD,AD-07,Andorra La Vella,,ALV,,"42.511174, 1.533551"


Data returned by v3:
(node:55667) UnhandledPromiseRejectionWarning: TypeError: response.Payload is not async iterable
    at /Users/trivikr/workspace/aws-sdk-js-tests/src/node/index.js:17:38
    at processTicksAndRejections (internal/process/task_queues.js:94:5)
(node:55667) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). (rejection id: 3)
(node:55667) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.
trivikr

comment created time in 11 days

create barnchtrivikr/aws-sdk-js-tests

branch : s3-selectObjectContent-test

created branch time in 11 days

push eventtrivikr/aws-sdk-js-tests

Trivikram Kamat

commit sha 74b4d14afcd67c0c497bb1e1241a69811455e795

feat: verify AWS JS SDK v3 in react-native (#10)

view details

push time in 11 days

delete branch trivikr/aws-sdk-js-tests

delete branch : react-native-v3

delete time in 11 days

push eventaws-samples/aws-sdk-js-tests

Trivikram Kamat

commit sha 74b4d14afcd67c0c497bb1e1241a69811455e795

feat: verify AWS JS SDK v3 in react-native (#10)

view details

push time in 11 days

PR merged aws-samples/aws-sdk-js-tests

feat: verify AWS JS SDK v3 in react-native

Issue #, if available: N/A

Description of changes: verify AWS JS SDK v3 in react-native

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

+90 -79

1 comment

3 changed files

trivikr

pr closed time in 11 days

push eventtrivikr/aws-sdk-js-tests

Trivikram Kamat

commit sha 95be3b018ea95824f4ed5346853b8785cf7cd429

chore: yarn upgrade --latest @aws-sdk/*@alpha

view details

push time in 11 days

issue closedaws/aws-sdk-js-v3

Release scripts should update CodeGen code (if necessary)

Describe the bug

  • When v0.2.0 was published in commit https://github.com/aws/aws-sdk-js-v3/commit/477dc72f2196f0b9c17dc5fef86017a2d2fd4d27, it updated devDependency @aws-sdk/client-documentation-generator from ^0.1.0-preview.1 to ^0.1.0-preview.2
  • It didn't update CodeGen in https://github.com/aws/aws-sdk-js-v3/blob/4013705828b1081a4a05c15106f9c09d854a8eef/packages/package-generator/src/ClientModuleGenerator.ts#L273 which was fixed in #301

To Reproduce (observed behavior) Run release scripts

Expected behavior If release scripts are updating some package version which affects CodeGen, related code change should also be made.

closed time in 11 days

trivikr

issue commentaws/aws-sdk-js-v3

Release scripts should update CodeGen code (if necessary)

Closing as we switched to java codegen in smithy-codegen

trivikr

comment created time in 11 days

issue closedaws/aws-sdk-js-v3

Opt out of minor and/or patch updates in automated dependency management

Is your feature request related to a problem? Please describe.

  • We've been using Greenkeeper for automated dependency management 2019/05/16 (original PR #248)
  • As of 2019/07/27, it has created 12 PRs as follows:
    • 2 initial PRs
    • 5 major version updates
    • 1 minor version update
    • 4 patch updates
    • we've disabled updates for some dependencies (link)
  • Find a way to opt out of minor version or patch updates (except if it's a security issue). Reason: they're not worth the time spent in reviewing PRs and testing.
    • We use carets (doc) for most of our dependencies, so latest “Compatible with version” will be installed
    • We plan to commit yarn lockfile once we move to yarn workspaces

Describe the solution you'd like Opt out of minor and/or dependency updates:

  • Greenkeeper doesn't seem to have an option as per https://github.com/greenkeeperio/greenkeeper/issues/1121
  • Dependabot (Greenkeeper alternative) doesn't have any such option https://github.com/aws/aws-sdk-js-v3/issues/280#issuecomment-514741516

Describe alternatives you've considered Reviewing/ignoring patch version updates PRs from greenkeeper

EDITs:

  • (trivikr) Updated issue link from greenkeeper repo

closed time in 11 days

trivikr

issue commentaws/aws-sdk-js-v3

Opt out of minor and/or patch updates in automated dependency management

Closing as we no longer use greenkeeper, and use increase_versions_if_necessary setting of dependabot

trivikr

comment created time in 11 days

issue closedaws/aws-sdk-js-v3

fix: update to yargs@12.0.2 to fix vulnerability

Details about the vulnerability https://snyk.io/test/github/aws/aws-sdk-js-v3

closed time in 11 days

trivikr

issue commentaws/aws-sdk-js-v3

fix: update to yargs@12.0.2 to fix vulnerability

Closing as yargs was updated in https://github.com/aws/aws-sdk-js-v3/pull/639

trivikr

comment created time in 11 days

issue closedaws/aws-sdk-js-v3

CodeGen assigns version 1.0.0 for newly generated clients

Describe the bug CodeGen assigns version 1.0.0 for newly generated clients

To Reproduce (observed behavior)

  • Run CodeGen following instructions in https://github.com/aws/aws-sdk-js-v3/pull/545
  • Example PR for generating client-api-gateway https://github.com/aws/aws-sdk-js-v3/pull/615
  • Notice that version number is 1.0.0 https://github.com/aws/aws-sdk-js-v3/blob/c43de93826707c41f212076ce4ec4e7526ae5ad9/clients/client-api-gateway/package.json#L4

Expected behavior The version number should be 0.1.0-preview.N (where N is any number which will be overwritten by lerna

closed time in 11 days

trivikr

issue commentaws/aws-sdk-js-v3

CodeGen assigns version 1.0.0 for newly generated clients

Closing as base package version is set as 1.0.0-alpha.1 in build.gradle.kts https://github.com/aws/aws-sdk-js-v3/blob/ce8ac664840b620ca6d03a570b57f4088b9b7693/codegen/sdk-codegen/build.gradle.kts#L57

Originally fixed in https://github.com/aws/aws-sdk-js-v3/pull/683

trivikr

comment created time in 11 days

issue closedaws/aws-sdk-js-v3

Tracking issue for yarn test:all failures

Describe the bug Tracking issue for yarn test:all failures

To Reproduce (observed behavior) Run yarn test:all on smithy-codegen

Expected behavior yarn test:all should succeed

closed time in 11 days

trivikr

issue commentaws/aws-sdk-js-v3

Tracking issue for yarn test:all failures

Resolving as yarn test:all succeeds on smithy-codegen

trivikr

comment created time in 11 days

issue closedaws/aws-sdk-js-v3

Pass current package-version to typescript-codegen when running codegen

Is your feature request related to a problem? Please describe.

  • The version for packages is currently set to "1.0.0" https://github.com/aws/aws-sdk-js-v3/blob/65740e3548fbacf93ff9b07fc379fe3731c622c1/codegen/sdk-codegen/build.gradle.kts#L57
  • Refs: https://github.com/awslabs/smithy-typescript/issues/79

Describe the solution you'd like Pass the existing PACKAGE_VERSION when calling typescript-codegen

Describe alternatives you've considered Have "1.0.0" as default versions for all packages, before lerna is run

closed time in 11 days

trivikr

issue commentaws/aws-sdk-js-v3

Pass current package-version to typescript-codegen when running codegen

Resolving as packageVersions are managed by lerna, and are not overridden by codegen

trivikr

comment created time in 11 days

issue closedaws/aws-sdk-js-v3

Codegen doesn't add new dependency in the client if package.json is already present

Describe the bug Codegen doesn't add new dependency in the client if package.json is already present

To Reproduce (observed behavior) This issue was noticed when release script failed in #798

  • The PR which added middleware-sdk-sqs https://github.com/aws/aws-sdk-js-v3/pull/719
  • It was not added as a dependency when CodeGen was run, as we our generate-clients script doesn't override package.json - if it's already present https://github.com/aws/aws-sdk-js-v3/blob/80e6356d329151138e144cc75b3abb8a142a83c3/scripts/generate-clients/copy-to-clients.js#L7-L17

Expected behavior

  • generate-clients scripts should read package.json output from CodeGen, and update it to latest lerna dependencies
  • if we go ahead with this solution, we'll need another task to update dependencies while merging as lerna would update version everyday post GA. This can be done using GitHub action on merge action.

closed time in 11 days

trivikr

issue commentaws/aws-sdk-js-v3

Codegen doesn't add new dependency in the client if package.json is already present

Verified that https://github.com/aws/aws-sdk-js-v3/pull/900 fixes this

trivikr

comment created time in 11 days

create barnchtrivikr/aws-sdk-js-v3

branch : test-update-dependencies

created branch time in 11 days

issue closedaws/aws-sdk-js-v3

CodeGen reformats package.json after prettier is run

Describe the bug

  • CodeGen reformats package.json after prettier is run
  • Prettier is run before copying to clients folder https://github.com/aws/aws-sdk-js-v3/blob/6c0af9c7bf069ef8dc5b70c201edd02dc95d2aa3/scripts/generate-clients/index.js#L25-L26
  • In #900, the package.json was reformatted using JSON.stringify https://github.com/aws/aws-sdk-js-v3/blob/6c0af9c7bf069ef8dc5b70c201edd02dc95d2aa3/scripts/generate-clients/copy-to-clients.js#L90
  • This is not an issue right now, as codegen is manually run and lint-staged runs prettier on package.json on precommit. But this will become an issue when codegen is run in release scripts.

To Reproduce (observed behavior) Run yarn generate-clients -m models, and notice that it updates all package.json files

Expected behavior The codegen should emit prettified code

closed time in 11 days

trivikr

issue commentaws/aws-sdk-js-v3

CodeGen reformats package.json after prettier is run

Fixed in https://github.com/aws/aws-sdk-js-v3/pull/913

trivikr

comment created time in 11 days

delete branch trivikr/aws-sdk-js-v3

delete branch : append-newline-package-json

delete time in 11 days

push eventaws/aws-sdk-js-v3

Trivikram Kamat

commit sha ce8ac664840b620ca6d03a570b57f4088b9b7693

fix: append newline at package.json EoF (#913)

view details

push time in 11 days

PR merged aws/aws-sdk-js-v3

fix: append newline at package.json EoF

Issue #, if available: Fixes: https://github.com/aws/aws-sdk-js-v3/issues/908

Description of changes:

  • append newline at package.json EoF
  • verified that package.json output is same as that formatted by prettier

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

+4 -1

0 comment

1 changed file

trivikr

pr closed time in 11 days

issue closedaws/aws-sdk-js-v3

npm install fails on sha256-browser dependencies

Describe the bug attempting to install a client using the alpha tag results in error for missing sha256-browser dependency

SDK version number alpha tag

Is the issue in the browser/Node.js? N/A

To Reproduce (observed behavior) In new directory, run npm i @aws-sdk/client-dynamodb@alpha Output:

npm ERR! code ETARGET
npm ERR! notarget No matching version found for @aws-sdk/util-utf8-browser@^0.1.0.
npm ERR! notarget In most cases you or one of your dependencies are requesting
npm ERR! notarget a package version that doesn't exist.
npm ERR! notarget
npm ERR! notarget It was specified as a dependency of '@aws-crypto/sha256-browser'
npm ERR! notarget

Also returns missing @aws-sdk/types@^0.1.0. dependency.

Expected behavior latest alpha tagged version of client-dynamodb is installed

closed time in 11 days

srchase

issue commentaws/aws-sdk-js-v3

npm install fails on sha256-browser dependencies

Fixed in v1.0.0-alpha.21 release

Verified as follows:

$ npm i @aws-sdk/client-dynamodb@alpha
npm notice created a lockfile as package-lock.json. You should commit this file.
npm WARN test-901@1.0.0 No description
npm WARN test-901@1.0.0 No repository field.

+ @aws-sdk/client-dynamodb@1.0.0-alpha.19
updated 1 package and audited 230 packages in 1.889s
found 0 vulnerabilities
$ yarn add @aws-sdk/client-dynamodb@alpha
yarn add v1.22.0
info No lockfile found.
[1/4] 🔍  Resolving packages...
[2/4] 🚚  Fetching packages...
[3/4] 🔗  Linking dependencies...
[4/4] 🔨  Building fresh packages...

success Saved lockfile.
success Saved 42 new dependencies.
info Direct dependencies
└─ @aws-sdk/client-dynamodb@1.0.0-alpha.19
info All dependencies
├─ @aws-crypto/ie11-detection@1.0.0-alpha.0
├─ @aws-crypto/sha256-browser@1.0.0-alpha.0
├─ @aws-crypto/sha256-js@1.0.0-alpha.0
├─ @aws-crypto/supports-web-crypto@1.0.0-alpha.0
├─ @aws-sdk/abort-controller@1.0.0-alpha.4
├─ @aws-sdk/client-dynamodb@1.0.0-alpha.19
├─ @aws-sdk/config-resolver@1.0.0-alpha.11
├─ @aws-sdk/credential-provider-env@1.0.0-alpha.5
├─ @aws-sdk/credential-provider-imds@1.0.0-alpha.4
├─ @aws-sdk/credential-provider-node@1.0.0-alpha.5
├─ @aws-sdk/credential-provider-process@1.0.0-alpha.4
├─ @aws-sdk/fetch-http-handler@1.0.0-alpha.7
├─ @aws-sdk/hash-node@1.0.0-alpha.4
├─ @aws-sdk/invalid-dependency@1.0.0-alpha.2
├─ @aws-sdk/middleware-content-length@1.0.0-alpha.6
├─ @aws-sdk/middleware-host-header@1.0.0-alpha.6
├─ @aws-sdk/middleware-retry@1.0.0-alpha.6
├─ @aws-sdk/middleware-serde@1.0.0-alpha.4
├─ @aws-sdk/middleware-signing@1.0.0-alpha.12
├─ @aws-sdk/middleware-user-agent@1.0.0-alpha.7
├─ @aws-sdk/node-http-handler@1.0.0-alpha.7
├─ @aws-sdk/region-provider@1.0.0-alpha.4
├─ @aws-sdk/service-error-classification@1.0.0-alpha.2
├─ @aws-sdk/smithy-client@1.0.0-alpha.5
├─ @aws-sdk/stream-collector-browser@1.0.0-alpha.4
├─ @aws-sdk/stream-collector-node@1.0.0-alpha.4
├─ @aws-sdk/stream-collector-rn@1.0.0-alpha.1
├─ @aws-sdk/url-parser-browser@1.0.0-alpha.4
├─ @aws-sdk/url-parser-node@1.0.0-alpha.5
├─ @aws-sdk/util-base64-browser@1.0.0-alpha.2
├─ @aws-sdk/util-base64-node@1.0.0-alpha.2
├─ @aws-sdk/util-body-length-browser@1.0.0-alpha.2
├─ @aws-sdk/util-body-length-node@1.0.0-alpha.2
├─ @aws-sdk/util-hex-encoding@1.0.0-alpha.2
├─ @aws-sdk/util-locate-window@1.0.0-alpha.2
├─ @aws-sdk/util-user-agent-browser@1.0.0-alpha.7
├─ @aws-sdk/util-user-agent-node@1.0.0-alpha.7
├─ @aws-sdk/util-utf8-node@1.0.0-alpha.2
├─ punycode@1.3.2
├─ querystring@0.2.0
├─ url@0.11.0
└─ uuid@3.4.0
✨  Done in 1.74s.
srchase

comment created time in 11 days

issue closedaws/aws-sdk-js-v3

CodeGen updates in #900 changes the order of dependencies

Is your feature request related to a problem? Please describe.

  • CodeGen updates in #900 changes the order of dependencies
  • This was noticed in commit https://github.com/aws/aws-sdk-js-v3/pull/903/commits/09659dad03a38b0c15665b3279db8fa402789382 of #903

Describe the solution you'd like CodeGen retains the order of dependencies/devDependencies same as that done by lerna

Describe alternatives you've considered changing the order after running codegen as in #900, and it being updated when release is run

closed time in 11 days

trivikr

issue commentaws/aws-sdk-js-v3

CodeGen updates in #900 changes the order of dependencies

Fixed in https://github.com/aws/aws-sdk-js-v3/pull/909

trivikr

comment created time in 11 days

PR opened aws/aws-sdk-js-v3

fix: append newline at package.json EoF

Issue #, if available: Fixes: https://github.com/aws/aws-sdk-js-v3/issues/908

Description of changes:

  • append newline at package.json EoF
  • verified that package.json output is same as that formatted by prettier

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

+4 -1

0 comment

1 changed file

pr created time in 11 days

create barnchtrivikr/aws-sdk-js-v3

branch : append-newline-package-json

created branch time in 11 days

issue commentaws/aws-sdk-js-v3

CodeGen reformats package.json after prettier is run

The only difference between existing codegen and command line prettier is no newline at end of file

Screen Shot 2020-02-10 at 7 36 53 PM

trivikr

comment created time in 11 days

push eventtrivikr/smithy-typescript

AllanFly120

commit sha fdfccfa79e197067b950348bc2ed54713835b102

fix wrong rn config template (#127)

view details

push time in 11 days

push eventtrivikr/aws-sdk-js-v3

Trivikram Kamat

commit sha a2388cf5935c4703618645d89826c85a4fecf01a

chore: codegen for rn config template fix (#912)

view details

Trivikram Kamat

commit sha 016e107c5ff9b339f790a05c5d9216197d604d5c

chore: codegen for add application/json JSON serde support

view details

Trivikram Kamat

commit sha d593f7c4802a1cd1fa0ee5b8c0382b730c617b39

chore: fix for CI failure

view details

Trivikram Kamat

commit sha 2b09bc1d65ae285b00643b5ff44e6bbdf4fbfb2c

Revert "chore: fix for CI failure" This reverts commit 7903e1c20bc823faba05593e44ceb1ba08487846.

view details

push time in 11 days

delete branch trivikr/smithy-typescript

delete branch : fix-namespace-_smithy

delete time in 11 days

PR closed awslabs/smithy-typescript

fix: typo _smithy.LazyJsonString to __LazyJsonString

Issue #, if available: Fixes: https://github.com/awslabs/smithy-typescript/issues/128

Description of changes: fix: typo _smithy.LazyJsonString to __LazyJsonString

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

+1 -1

1 comment

1 changed file

trivikr

pr closed time in 11 days

pull request commentawslabs/smithy-typescript

fix: typo _smithy.LazyJsonString to __LazyJsonString

Closing as this does not resolve the issue CI fails in models/index.ts https://github.com/aws/aws-sdk-js-v3/pull/911#issuecomment-584458700

trivikr

comment created time in 11 days

push eventtrivikr/aws-sdk-js-v3

Trivikram Kamat

commit sha 7903e1c20bc823faba05593e44ceb1ba08487846

chore: fix for CI failure

view details

push time in 11 days

delete branch trivikr/aws-sdk-js-v3

delete branch : codegen-fix-rn-config-template

delete time in 11 days

push eventaws/aws-sdk-js-v3

Trivikram Kamat

commit sha a2388cf5935c4703618645d89826c85a4fecf01a

chore: codegen for rn config template fix (#912)

view details

push time in 11 days

PR merged aws/aws-sdk-js-v3

chore: codegen for rn config template fix

Issue #, if available: Refs: https://github.com/awslabs/smithy-typescript/pull/127

Description of changes: codegen for rn config template fix

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

+1090 -218

2 comments

218 changed files

trivikr

pr closed time in 11 days

PR opened awslabs/smithy-typescript

fix: typo _smithy.LazyJsonString to __LazyJsonString

Issue #, if available: Fixes: https://github.com/awslabs/smithy-typescript/issues/128

Description of changes: fix: typo _smithy.LazyJsonString to __LazyJsonString

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

+1 -1

0 comment

1 changed file

pr created time in 11 days

create barnchtrivikr/smithy-typescript

branch : fix-namespace-_smithy

created branch time in 11 days

issue commentawslabs/smithy-typescript

CI in generated code fails with error TS2503: Cannot find namespace '_smithy'

This appears to be an issue with line https://github.com/awslabs/smithy-typescript/blob/65974f58c513794dcf7b2dea9a6db9868c1c8aa5/smithy-typescript-codegen/src/main/java/software/amazon/smithy/typescript/codegen/SymbolVisitor.java#L250

_smithy.LazyJsonString needs to be updated to __LazyJsonString Refs: https://github.com/awslabs/smithy-typescript/pull/124

trivikr

comment created time in 11 days

issue commentaws-samples/aws-sdk-js-v3-workshop

CI in generated code fails with error TS2503: Cannot find namespace '_smithy'

mistakenly cut with workshop repo Replaced by https://github.com/awslabs/smithy-typescript/issues/128

trivikr

comment created time in 11 days

issue closedaws-samples/aws-sdk-js-v3-workshop

CI in generated code fails with error TS2503: Cannot find namespace '_smithy'

Describe the bug CI in generated code fails with error TS2503: Cannot find namespace '_smithy'

To Reproduce Refs: https://github.com/aws/aws-sdk-js-v3/pull/911#issuecomment-584452544

Expected behavior CI is successful after CodeGen is run in aws/aws-sdk-js-v3

closed time in 11 days

trivikr

issue openedawslabs/smithy-typescript

CI in generated code fails with error TS2503: Cannot find namespace '_smithy'

Describe the bug CI in generated code fails with error TS2503: Cannot find namespace '_smithy'

To Reproduce Refs: https://github.com/aws/aws-sdk-js-v3/pull/911#issuecomment-584452544

Expected behavior CI is successful after CodeGen is run in aws/aws-sdk-js-v3

created time in 11 days

issue openedaws-samples/aws-sdk-js-v3-workshop

CI in generated code fails with error TS2503: Cannot find namespace '_smithy'

Describe the bug CI in generated code fails with error TS2503: Cannot find namespace '_smithy'

To Reproduce Refs: https://github.com/aws/aws-sdk-js-v3/pull/911#issuecomment-584452544

Expected behavior CI is successful after CodeGen is run in aws/aws-sdk-js-v3

created time in 11 days

PR opened aws/aws-sdk-js-v3

chore: codegen for rn config template fix

Issue #, if available: Refs: https://github.com/awslabs/smithy-typescript/pull/127

Description of changes: codegen for rn config template fix

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

+1090 -218

0 comment

218 changed files

pr created time in 11 days

create barnchtrivikr/aws-sdk-js-v3

branch : codegen-fix-rn-config-template

created branch time in 11 days

push eventawslabs/smithy-typescript

AllanFly120

commit sha fdfccfa79e197067b950348bc2ed54713835b102

fix wrong rn config template (#127)

view details

push time in 11 days

PR merged awslabs/smithy-typescript

fix wrong rn config template

fix: #125 Used the wrong commit last time. I take the blame.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

+5 -1

0 comment

1 changed file

AllanFly120

pr closed time in 11 days

PR opened aws/aws-sdk-js-v3

chore: codegen for add application/json JSON serde support

Issue #, if available: Refs: https://github.com/awslabs/smithy-typescript/pull/124

Description of changes: codegen for add application/json JSON serde support

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

+3597 -3682

0 comment

90 changed files

pr created time in 11 days

create barnchtrivikr/aws-sdk-js-v3

branch : codegen-serde-support

created branch time in 11 days

delete branch trivikr/aws-sdk-js-v3

delete branch : fix-sort-package-dependencies

delete time in 11 days

push eventaws/aws-sdk-js-v3

Trivikram Kamat

commit sha c1e6c645d37d17129f00d1eacd1c778a7e335b41

fix: sort deps/devDeps by keys (#909)

view details

push time in 11 days

PR merged aws/aws-sdk-js-v3

fix: sort deps/devDeps by keys

Issue #, if available: Fixes: https://github.com/aws/aws-sdk-js-v3/issues/906

Description of changes:

  • sort deps/devDeps by keys
  • verified that the changes in https://github.com/aws/aws-sdk-js-v3/commit/09659dad03a38b0c15665b3279db8fa402789382 were undone after this code change, will verify again by running codegen after lerna releases v1.0.0-alpha.21

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

+4 -0

4 comments

1 changed file

trivikr

pr closed time in 11 days

pull request commentaws/aws-sdk-js-v3

fix: sort deps/devDeps by keys

Verified after v1.0.0-alpha.21 release that ordering maintained by this PR is same as that maintained by lerna

trivikr

comment created time in 11 days

push eventtrivikr/smithy-typescript

stickevi

commit sha 65974f58c513794dcf7b2dea9a6db9868c1c8aa5

Add serde support for application/json String This commit adds support for serializing and deserialiizing String shapes as the LazyJsonString when they are marked with the mediatype trait with the value of application/json.

view details

push time in 11 days

more