profile
viewpoint
Tom Hatzer tomhatzer @twopeaks-digital Bregenz, Austria www.tomhatzer.com Fulltime PHP artist & Laravel enthusiast | Founder of twopeaks.digital

laravel/spark-aurelius-mollie 16

Laravel Spark, Mollie edition

tomhatzer/adonis-serverless 10

This is an example repository for running AdonisJS on AWS Lambda.

tomhatzer/aimeos-laravel 0

Laravel e-commerce package for professional, ultra fast online shops, complex B2B applications and #gigacommerce

tomhatzer/awesome-adonisjs 0

A curated list of awesome bookmarks, packages, tutorials, videos and other cool resources from the AdonisJS ecosystem.

tomhatzer/blade-svg-origin 0

A package to include svg icons directly into your blade views without copy&paste

tomhatzer/bref 0

Serverless PHP on AWS Lambda

tomhatzer/browsershot 0

Convert html to an image, pdf or string

startedmollie/laravel-cashier-mollie

started time in 15 days

pull request commentlaravelio/laravel.io

Show "updated by at" on replies and threads

@driesvints hahahaha 😁 I didn't know what was expected so I did what felt okay for me. If it's too much, closing the PR won't cause any harm.

tomhatzer

comment created time in a month

push eventtomhatzer/laravel.io

tomhatzer

commit sha 07dd697e77c64091a230d1ab50f1aeff4748ec8f

Remove unnecessary import from GithubController

view details

push time in a month

push eventtomhatzer/laravel.io

tomhatzer

commit sha 99c0481e826f36c4a95bc6517f12f38e49916b05

Remove unnecessary parameter from GithubController and add return type to HasEditLog trait

view details

push time in a month

push eventtomhatzer/laravel.io

tomhatzer

commit sha a4c680b5a440c4a07ff738b04ad2fc0d69741eee

Fix styling

view details

push time in a month

push eventtomhatzer/laravel.io

tomhatzer

commit sha ad0b2ca8dc9f3681ad16e24490e246fd7c4c4522

Fix failing tests

view details

push time in a month

push eventtomhatzer/laravel.io

tomhatzer

commit sha 7c3b2336880b468291ce90eda37c744d018f03c3

Fix styling

view details

push time in a month

PR opened laravelio/laravel.io

Show "updated by at" on replies and threads

Implements #675 and looks currently like this:

Articles: image

Threads: image

Replies: image

+140 -1

0 comment

10 changed files

pr created time in a month

push eventtomhatzer/laravel.io

tomhatzer

commit sha 2237db9a506a166efd67d120b0757ce5ade406ca

Add caching

view details

push time in a month

push eventtomhatzer/laravel.io

tomhatzer

commit sha c237a48e7ad47c5096e88b7f7646eb27fa164027

Add last edit by to articles, replies and threads

view details

push time in a month

pull request commentlaravelio/laravel.io

Remember me for GitHub authentication

Hey @driesvints, the github login "button" is only a link and has no other relationship to the form. We could check if remember me is checked and append it to the link as query parameter but that would be a pretty strange behaviour imho and I'm not sure if any user understands this.

When adding the parameter to the query we could do something like this:

Extend app/Http/Controllers/Auth/GithubController.php to look like this:

    /**
     * Redirect the user to the GitHub authentication page.
     */
    public function redirectToProvider(Request $request)
    {
        $rememberMe = $request->get('remember', '');

        if(!empty($rememberMe)) {
            session()->put('rememberMe', true);
        }

        return Socialite::driver('github')->redirect();
    }

and

    private function userFound(User $user, SocialiteUser $socialiteUser): RedirectResponse
    {
        $this->dispatchNow(new UpdateProfile($user, ['github_username' => $socialiteUser->getNickname()]));

        Auth::login($user, session()->has('rememberMe') ? session()->get('rememberMe') : false);

        return redirect()->route('profile');
    }

What do you think?

tomhatzer

comment created time in a month

PR opened laravelio/laravel.io

Remember me for GitHub authentication

This fixes #689 by passing true as second parameter to Auth::login() when logging in using github.

+1 -1

0 comment

1 changed file

pr created time in a month

Pull request review commentlaravelio/laravel.io

Fix #580 - Add (un-)decline functionality

+<?php++use Illuminate\Database\Migrations\Migration;+use Illuminate\Database\Schema\Blueprint;+use Illuminate\Support\Facades\Schema;++class AddDeclinedAtColumnToArticlesTable extends Migration+{+    public function up()+    {+        Schema::table('articles', function (Blueprint $table) {+            $table->timestamp('declined_at')->nullable()->after('shared_at');

As far as I know, for MariaDB and MySQL, a nullable column will default to NULL as value for existing database records. I just tested this with my local version by adding a new column to the migrations table as nullable. All existing items had the value NULL in them.

tomhatzer

comment created time in a month

PullRequestReviewEvent

pull request commentlaravelio/laravel.io

Fix #580 - Add (un-)decline functionality

Thanks for the review @driesvints, all changes have been implemented.

tomhatzer

comment created time in a month

Pull request review commentlaravelio/laravel.io

Fix #580 - Add (un-)decline functionality

 public function __construct(Article $article)     public function handle(): Article     {         $this->article->approved_at = Carbon::now();+        $this->article->declined_at = null;

Ah yeah, the declined_at column is already null by default. I've removed setting it to null here. This would only have made sense with the undecline feature.

tomhatzer

comment created time in a month

PullRequestReviewEvent

push eventtomhatzer/laravel.io

tomhatzer

commit sha c9def1618f68cdd844bcf0c3206e0ad0d609eabe

Remove setting declined_at to null in ApproveArticle job, remove returning article in DeclineArticle handle method

view details

push time in a month

push eventtomhatzer/laravel.io

Tom Hatzer

commit sha a56222be3f99a5ffd0dc65220e92113f36c0c127

Apply suggestions from code review Co-authored-by: Dries Vints <dries@vints.io>

view details

push time in a month

pull request commentlaravelio/laravel.io

Fix #580 - Add (un-)decline functionality

Hey @joedixon ,

I've just removed the undecline functionality.

Looking forward to your review 😃

Thank you!

tomhatzer

comment created time in a month

push eventtomhatzer/laravel.io

tomhatzer

commit sha e33874697f229b514e85788ed18e5b66dce6e9c6

Remove undecline functionality

view details

push time in a month

pull request commentlaravelio/laravel.io

Fix #695 - Add word breaks to titles

Hey @joedixon , sure thing!

Currently it looks like this on laravel.io with the content overlapping the layout on the right: image

With this PR it looks like this with the content breaking to the next line: image

Would this be ok?

Thank you very much for reviewing.

tomhatzer

comment created time in a month

push eventtomhatzer/laravel.io

tomhatzer

commit sha 0c6bf8b1f3a189552d948a56e3154a26c0412dbb

Remove use for functions

view details

push time in a month

PR opened laravelio/laravel.io

Fix #580 - Add (un-)decline functionality

Hey!

This fixes #580 and adds decline and undecline functionality to the articles. It adds a new nullable column to the articles table named declined_at.

Feel free to comment if you have any recommendations or if there's something missing.

Have a great day! 😃

+181 -5

0 comment

11 changed files

pr created time in a month

create barnchtomhatzer/laravel.io

branch : feature/580-add_way_to_decline_article

created branch time in a month

PR opened laravelio/laravel.io

Fix #695 - Add word breaks to titles

Hey!

This fixes #695 . I've added break-all because break-words did not always break long strings.

Have a great day 😃

+9 -9

0 comment

9 changed files

pr created time in a month

create barnchtomhatzer/laravel.io

branch : bugfix/695-add_linebreak_to_thread_titles

created branch time in a month

fork tomhatzer/laravel.io

The Laravel.io Community Portal.

https://laravel.io

fork in a month

more