profile
viewpoint
If you are wondering where the data of this site comes from, please visit https://api.github.com/users/tomfitzhenry/events. GitMemory does not store any data, but only uses NGINX to cache data for a period of time. The idea behind GitMemory is simply to give users a better reading experience.

google/vc-defer 11

vc-defer makes (some) Emacs VC operations fast(er).

tomfitzhenry/nixpkgs 0

Nix Packages collection

issue commentNixOS/nixpkgs

[pkgs.clapper] JS ERROR: Error: Requiring Soup, version 2.4:

clapper works fine for me on my amd64 desktop, but I can reproduce your error on my Pinephone.

It seems missing a build deps appstream-glib & a runtime deps libsoup. If the mantainer agrees, I can do a PR : )

Sounds good to me! :)

VergeDX

comment created time in 9 days

pull request commentNixOS/nixpkgs

libqmi: 1.28.8 -> 1.30.2, modemmanager: 1.16.10 -> 1.18.2

This will be land in master as of https://github.com/NixOS/nixpkgs/pull/141684. https://nixpk.gs/pr-tracker.html?pr=137233

maxeaubrey

comment created time in 10 days

PR closed NixOS/nixpkgs

Reviewers
nixos/geoclue2: allow Phosh to use geoclue 6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Motivation for this change

Allow Phosh to use geoclue, per:

  • https://gitlab.freedesktop.org/geoclue/geoclue/-/commit/a9aea6a4948e2ff9ec5ff066cf20dac069c0d3a0 .
  • https://source.puri.sm/Librem5/phosh/-/tags/v0.11.0
Things done
  • [ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • [ ] NixOS
    • [ ] macOS
    • [ ] other Linux distributions
  • [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • [ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • [ ] Tested execution of all binary files (usually in ./result/bin/)
  • 21.11 Release Notes (or backporting 21.05 Relase notes)
    • [ ] (Package updates) Added a release notes entry if the change is major or breaking
    • [ ] (Module updates) Added a release notes entry if the change is significant
    • [ ] (Module addition) Added a release notes entry if adding a new NixOS module
  • [x] Fits CONTRIBUTING.md.
+6 -1

6 comments

2 changed files

tomfitzhenry

pr closed time in a month

pull request commentNixOS/nixpkgs

nixos/geoclue2: allow Phosh to use geoclue

I've lost context/state on this, sorry!

tomfitzhenry

comment created time in a month

push eventtomfitzhenry/nixpkgs

Tom

commit sha a72cf113d8d6f8dbdb5ef8037702b2c31d90111f

Update pkgs/applications/audio/spot/default.nix Co-authored-by: Artturi <Artturin@artturin.com>

view details

push time in a month

push eventtomfitzhenry/nixpkgs

Artturi

commit sha 944ca5b185d19e490afe0244c5ad529acf2f4e06

Merge pull request #137817 from r-ryantm/auto-update/qsynth

view details

Artturi

commit sha c7c8126c15b142c4c8bf0df62404cf2e95ef3d28

Merge pull request #137819 from r-ryantm/auto-update/k0sctl k0sctl: 0.9.0 -> 0.10.2

view details

R. RyanTM

commit sha 2dcab2aa335b91ad761f0dfb5e03007ea5432c38

python38Packages.pytest-snapshot: 0.6.1 -> 0.6.3

view details

Artturi

commit sha 382e553285d9bbcb71429b3f05406a47cf2ea9d5

Merge pull request #137822 from r-ryantm/auto-update/qcad qcad: 3.26.1.0 -> 3.26.4.7

view details

Artturi

commit sha 0d1f2481fd67412297ce010c6b2650ae2f78170d

Merge pull request #137826 from r-ryantm/auto-update/kubescape

view details

Artturi

commit sha 3193cbf7d6ac74efccf13f6f85c49e38838a30fb

Merge pull request #137823 from r-ryantm/auto-update/kapp kapp: 0.38.0 -> 0.39.0

view details

Artturi

commit sha 9cdca6ace6ed94e162414f6b2199defa0cb8c16b

Merge pull request #137825 from r-ryantm/auto-update/kubedb-cli

view details

Artturi

commit sha eb605522ce8b959699785b8bde05220e5c831bfa

Merge pull request #137824 from r-ryantm/auto-update/kube-score

view details

Bobby Rong

commit sha c50a3bfc4d2d59f2ed5fe55f6c682893599e78f0

Merge pull request #135947 from r-ryantm/auto-update/apt-offline apt-offline: unstable-2021-04-11 -> unstable-2021-07-25

view details

sternenseemann

commit sha 012cc2970c5242f55d2bad84191513f2d01ae952

Merge remote-tracking branch 'origin/master' into haskell-updates

view details

figsoda

commit sha b3d047de5c0a613efba8edf4785f6121dafc4f95

Merge pull request #135812 from r-ryantm/auto-update/unclutter-xfixes unclutter-xfixes: 1.5 -> 1.6

view details

R. RyanTM

commit sha a9a2bb267751fab783178f91f3f988b745c06500

qbs: 1.19.1 -> 1.20.0

view details

figsoda

commit sha 1f6570927e92c004031fb7eee6afc61eca25e16d

Merge pull request #135984 from r-ryantm/auto-update/smtube smtube: 20.6.0 -> 21.7.0

view details

Bobby Rong

commit sha b4a5ca2a1ee7b2a46656a4eca7ea2ad582271fb9

Merge pull request #134973 from r-ryantm/auto-update/avocode avocode: 4.15.0 -> 4.15.1

view details

Bobby Rong

commit sha 39261adc92fb68a89132d85c034296fbaa42b0a0

Merge pull request #135626 from delroth/tor-netlink nixos/tor: allow AF_NETLINK address family

view details

Sandro

commit sha 307d1cc45515d24013185b51ec44a42d45bffa1a

Merge pull request #136937 from fabaff/aiogithubapi python3Packages.aiogithubapi: init at 21.8.1

view details

Lein Matsumaru

commit sha f7978d726a881a6911a596b19d246604ad8bab75

exploitdb: 20221-09-10 -> 2021-09-14

view details

Bobby Rong

commit sha 90956d40e6b8b4c98d6446daa69cddc73339c33b

Merge pull request #136625 from yusdacra/update-buf buf: 0.52.0 -> 0.54.1

view details

Benjamin Asbach

commit sha ac74b42351e671d45949341fe5b9dac5bb69f574

csvs-to-sqlite: removed from `python-package` since it's an command line application

view details

Naïm Favier

commit sha d9d3ea6278a78a657c772784f92f404e0bfd1b20

gnome.file-roller: avoid wrapping the program twice Use gappsWrapperArgs instead of wrapProgram to avoid double wrapping which causes problems with argv[0].

view details

push time in a month

push eventtomfitzhenry/nixpkgs

Bernardo Meurer

commit sha 01f0a46258d95158302d21336054fa1701c7eb01

linuxPackages.zfs: use the kernel's stdenv when possible

view details

Bernardo Meurer

commit sha 505a6f5f06e78785048b4bf9cafb8925fe494ca9

Revert "linuxPackages.zfs: fix m4 script when not using GCC" This reverts commit 5280cdee8d6c3ec3155150c703ccd50d038b2cdb.

view details

Tom Fitzhenry

commit sha ec0a2e72aadd96c3d087113aa62b20f023cefa4a

calls: 0.3.1 -> 41.0

view details

push time in a month

pull request commentNixOS/nixpkgs

spot: Build an optimised binary, to drop CPU usage: 70% -> 10%

I have raised https://github.com/NixOS/nixpkgs/pull/138412 upstream, so that we won't need this special case for spot. It might help other distributions too.

tomfitzhenry

comment created time in a month

issue openedxou816/spot

Support Meson buildtype "plain"

Describe the bug On my NixOS Pinephone, I realised spot CPU usage was ~70%, and this was fixed by setting a Meson buildtype of "release", as described in spot's README.

NixOS sets buildtype to "plain" by default, per Meson's advice in https://mesonbuild.com/Running-Meson.html

[plain:] no extra build flags are used, even for compiler warnings, useful for distro packagers and other cases where you need to specify all arguments by yourself

It'd be great if spot supported the Meson buildtype "plain", so that distributions produced automagically optimised builds.

Until then, I have raised https://github.com/NixOS/nixpkgs/pull/138412 for NixOS to specify buildtype "release".

To Reproduce Steps to reproduce the behavior:

  1. Compile with -Dbuildtype=plain
  2. Play music
  3. Observe CPU usage is 70%

Expected behavior CPU usage is 10%

General information:

  • Distribution: NixOS
  • Installation method [e. g. built from source, installed from Flathub...]: built from source
  • Version [e.g. 0.1.0]: 0.2.0
  • Device used [e. g. desktop, phone...]: Pinephone

created time in a month

PR opened NixOS/nixpkgs

spot: Build an optimised binary, to drop CPU usage: 70% -> 10%
Motivation for this change

My Pinephone had 70% CPU usage while playing music on Spot.

https://github.com/xou816/spot/blob/2a591febcfa4b9690ea166097392d2a327cd0c60/README.md?plain=1#L111 suggests the fix in this PR.

This PR dropped CPU usage to 10%.

https://github.com/xou816/spot/issues/131 reports that this dropped ~30-40% to 5-10% on an i7-7700.

Things done

<!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  • Built on platform(s)
    • [ ] x86_64-linux
    • [ ] aarch64-linux
    • [x] x86_64-darwin
    • [ ] aarch64-darwin
  • [ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • [ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • [ ] Tested execution of all binary files (usually in ./result/bin/)
  • 21.11 Release Notes (or backporting 21.05 Release notes)
    • [ ] (Package updates) Added a release notes entry if the change is major or breaking
    • [ ] (Module updates) Added a release notes entry if the change is significant
    • [ ] (Module addition) Added a release notes entry if adding a new NixOS module
  • [ ] Fits CONTRIBUTING.md.
+3 -0

0 comment

1 changed file

pr created time in a month

create barnchtomfitzhenry/nixpkgs

branch : spot-fast

created branch time in a month

issue closedNixOS/mobile-nixos

Flashlight/Torch support

Phosh has a torch icon, but when pressed no torch is displayed.

pine64-pinephone does support a torch, via echo 255 | sudo tee /sys/class/leds/white\:flash/brightness. (echo 0 to turn it off).

Phosh's torch supported was introduced in https://source.puri.sm/Librem5/phosh/-/merge_requests/621 and appears to rely on an unmerged PR of upower: https://gitlab.freedesktop.org/upower/upower/-/merge_requests/50

closed time in a month

tomfitzhenry

issue closedNixOS/nixpkgs

Python application spends 5s on importing modules: it doesn't attempt to load pyc files

Describe the bug

numberstation on my Pinephone takes ~7 seconds to load. Profiling shows ~5s of this is importing modules.

Steps To Reproduce

Steps to reproduce the behavior:

  1. Modify the wrapped numberstation script to run with python -X importtime [...], and name the script prof.sh: https://paste.debian.net/1206021/
  2. Execute:
$ ./prof.sh 2> importtimes.log
$ cat importtimes.log  | awk '{print $3}' | grep -E '^[0-9]+$' | awk '{sum += $1} END {print sum }'

5224074

i.e. this application spends 5s on imports.

https://pastebin.ubuntu.com/p/t9z6cXyXrD/ is my importtimes.log

Expected behavior

I expected this importtimes to take <1-2s.

Metadata

$ nix-shell -p nix-info --run "nix-info -m"
warning: Nix search path entry '/nix/var/nix/profiles/per-user/root/channels/nixos' does not exist, ignoring
warning: Nix search path entry '/nix/var/nix/profiles/per-user/root/channels/nixos' does not exist, ignoring
 - system: `"aarch64-linux"`
 - host os: `Linux 5.13.0, NixOS, 21.11pre-git (Porcupine)`
 - multi-user?: `yes`
 - sandbox: `yes`
 - version: `nix-env (Nix) 2.3.14`
 - channels(root): `"nixpkgs-21.11pre302356.2489eb5e451"`
warning: Nix search path entry '/nix/var/nix/profiles/per-user/root/channels/nixos' does not exist, ignoring
 - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixpkgs`

Maintainer information:

# a list of nixpkgs attributes affected by the problem
attribute:
# a list of nixos modules affected by the problem
module:

closed time in a month

tomfitzhenry

issue commentNixOS/nixpkgs

Python application spends 5s on importing modules: it doesn't attempt to load pyc files

https://github.com/NixOS/nixpkgs/pull/120858 has been merged to master, and I can confirm numberstation on my Pinephone is now starting in 4s rather than 7s.

tomfitzhenry

comment created time in a month

pull request commentNixOS/nixpkgs

spot: 0.1.14 -> 0.2.0

This is tracked in #135477. This PR is blocked until then.

#135477 has been merged, and I have tested this to now be compiling and working.

tomfitzhenry

comment created time in a month

push eventtomfitzhenry/nixpkgs

Sergei Trofimovich

commit sha 79031203b88f8b96b1321416f59e23481cceed45

xvkbd: explicitly set LIBDIR and CONFDIR In preparation to fix long-standing `imake` bug #135337 we need to set `LIBDIR` and `CONFDIR` away from incorrectly embedded `xorg-cf-files`. Before #135337 the package worked by chance. Issue: https://github.com/NixOS/nixpkgs/issues/135337

view details

Sergei Trofimovich

commit sha 6073831a11510127a41ff2478abd799f0965e2f4

imake: do not skip Linux* vendor definitions Initial build failure is onserved on `staging` branch: ``` $ nix-build -A transfig ... make[1]: Entering directory '/build/transfig.3.2.4' Imakefile.c:20:2: Include file Imake.tmpl not found imake: Exit code 1. Stop. ``` This happened after 8675ca0 ("xorg.xorgcffiles: 1.0.6 -> 1.0.7") bump which exposed an old bug in `imake.patch`. `imake.patch` dropped by accident definiton of `LinuxRedHat` enum and changed evaluation of the following code: ``` #if LinuxDistribution == LinuxRedHat ... # define ProjectRoot /usr #endif ``` References to `/usr` were addded in https://gitlab.freedesktop.org/xorg/util/cf/-/commit/d47131ed97ee491bb883c29ec0b106e8d5acfcd3. Before this change `LinuxDistribution == LinuxRedHat` evaluated to true. After this change `LinuxDistribution == LinuxRedHat` evaluates to false. Mechanically I moved `#if 0` right after enum definitions but still before system autodetection. Now `transfig` builds successfully. Closes: https://github.com/NixOS/nixpkgs/issues/135337 Signed-off-by: Sergei Trofimovich <slyich@gmail.com>

view details

R. RyanTM

commit sha c6b45fdb961e388071175f13b038104b5baaf497

kitsas: 2.3 -> 3.0

view details

R. RyanTM

commit sha 61e1284e9943ce9cffa2a8c6cacc14d6880a8432

konstraint: 0.14.2 -> 0.15.0

view details

github-actions[bot]

commit sha 58c8736bdb2ed5b5194de8f2da21c564f27f254c

Merge master into staging-next

view details

R. RyanTM

commit sha a82ea7eaac10d22bee5edd250e06ad5c887e0127

kubeconform: 0.4.8 -> 0.4.10

view details

R. RyanTM

commit sha 7868800a10e7536c6d5212fcbeb0ae35618290a3

libxsmm: 1.16.1 -> 1.16.2

view details

Ryan Burns

commit sha 590471d1772e0045e93097c19f955d919350c06c

ocamlPackages.extlib: fix build We can no longer set dontConfigure, because findlib now sets up a necessary preConfigure hook

view details

Ryan Burns

commit sha 125c7a4ef53def6ffb1a06852e47a64a796e5577

ocamlPackages.erm_xmpp: fix build Add missing pre/post hooks - preConfigure is now required, as findlib sets a necessary preConfigure hook

view details

Ryan Burns

commit sha 6310613bb00ff433b53908f859a06aee4b7f07ba

ocamlPackages.ocaml_oasis: fix build Add missing pre/post hooks - preConfigure is now required, as findlib sets a necessary preConfigure hook

view details

Ryan Burns

commit sha 3a5fc1aad414f2de7813cec48d25e73aa553c0bb

ocamlPackages.camomile: fix output dest dir Add missing pre/post hooks - preConfigure is now required to set correct ocaml dest dir as findlib sets a necessary preConfigure hook

view details

Ryan Burns

commit sha 53b78c1a641964d54850f427bcd19fa0935400b5

ocamlPackages.cryptokit: fix output dest dir Add missing pre/post hooks - preConfigure is now required to set correct ocaml dest dir as findlib sets a necessary preConfigure hook

view details

Nikolay Korotkiy

commit sha ee2a63485d3ced32f1c23aa0c3f89d7b031d1044

cudatext: 1.142.0 → 1.143.0

view details

github-actions[bot]

commit sha b6f0eb91360e3836d37ab7081a35be380229f937

Merge master into staging-next

view details

github-actions[bot]

commit sha 2f5ea43e02a3ce3844fc28be2216cf92e26ae103

Merge master into staging-next

view details

R. RyanTM

commit sha 266fe4814befff219e84d9d6f8280ba069dfc9ca

python38Packages.Markups: 3.1.1 -> 3.1.2

view details

Luke Granger-Brown

commit sha 4e1b102af618fc3e8da11da8a0cea28e5c104f3a

curl: reenable ca-fallback when not using wolfsslSupport 904625852d535bbe53cadb006c9e1137ab481818 accidentally swapped the behaviour, and enabled ca-fallback when using wolfssl and disabled it without. This effectively disables curl's ability to use the built in CA stack.

view details

Luke Granger-Brown

commit sha 8dbbdbc04e8f4780e5629908f274607bfcab1d8b

Merge pull request #136946 from lukegb/staging-next curl: reenable ca-fallback when not using wolfsslSupport

view details

R. RyanTM

commit sha d83697e448777cd846cecb639f39c865137e679d

python38Packages.asyncssh: 2.7.0 -> 2.7.1

view details

Jessica Chen

commit sha a03dc132a5cf07424201cf860b471ae926ff602e

sidequest: 0.10.19 -> 0.10.24

view details

push time in a month

issue commentNixOS/mobile-nixos

pinephone: bluetooth firmware failing to load

https://github.com/NixOS/mobile-nixos/pull/396#issuecomment-896752527 has the steps to get this working.

tomfitzhenry

comment created time in a month

issue closedNixOS/mobile-nixos

pinephone: bluetooth firmware failing to load

With the following config:

hardware.firmware = [ config.mobile.device.firmware ];

I expected the bluetooth firmware to load, per https://github.com/NixOS/mobile-nixos/blob/81f8dff8c7cec430de43d08b07220760b35b31bb/devices/pine64-pinephone/firmware/default.nix#L16 .

However, this firmware fails to load:

$ dmesg | grep -i bluetooth
[    1.254148] Bluetooth: Core ver 2.22
[    1.254231] Bluetooth: HCI device and connection manager initialized
[    1.254282] Bluetooth: HCI socket layer initialized
[    1.254294] Bluetooth: L2CAP socket layer initialized
[    1.254350] Bluetooth: SCO socket layer initialized
[    1.475415] Bluetooth: HCI UART driver ver 2.3
[    1.475430] Bluetooth: HCI UART protocol H4 registered
[    1.475494] Bluetooth: HCI UART protocol LL registered
[    1.475542] Bluetooth: HCI UART protocol Three-wire (H5) registered
[    1.475822] Bluetooth: HCI UART protocol Broadcom registered
[    1.528990] Bluetooth: HIDP (Human Interface Emulation) ver 1.2
[    1.529007] Bluetooth: HIDP socket layer initialized
[    2.325477] Bluetooth: hci0: RTL: examining hci_ver=07 hci_rev=000b lmp_ver=07 lmp_subver=8703
[    2.329956] Bluetooth: hci0: RTL: chip_type status=0 type=5
[    2.333973] Bluetooth: hci0: RTL: rom_version status=0 version=1
[    2.333982] Bluetooth: hci0: RTL: loading rtl_bt/rtl8723cs_xx_fw.bin
[    2.334077] bluetooth hci0: Direct firmware load for rtl_bt/rtl8723cs_xx_fw.bin failed with error -2
[    2.334088] Bluetooth: hci0: RTL: firmware file rtl_bt/rtl8723cs_xx_fw.bin not found

$ ls -lh /run/current-system/firmware/rtl_bt/rtl8723cs_xx_fw.bin
-r--r--r-- 1 root root 25K Jan  1  1970 /run/current-system/firmware/rtl_bt/rtl8723cs_xx_fw.bin

$ sha256sum /run/current-system/firmware/rtl_bt/rtl8723cs_xx_fw.bin
c68091565d90c29735bedf72d0bf6590c186ab802ef4fef4caa66ef5af25b870  /run/current-system/firmware/rtl_bt/rtl8723cs_xx_fw.bin

closed time in a month

tomfitzhenry
PullRequestReviewEvent

pull request commentNixOS/nixpkgs

numberstation: 0.4.0 -> 0.5.0

@tomfitzhenry Would you like to become a maintainer of this package?

Yes, I am happy to do this. I am an active user, and have contributed to upstream.

dotlambda

comment created time in a month

issue commentNixOS/mobile-nixos

pine64-pinephone: Phosh boot delayed by network-online.target (6.7s for my Wifi; timeout for when there is no signal)

I've realised my conclusions in this thread so far have been wrong.

Since phone's can expect to occasionally be in places without signal, it's not reasonable to wait for the network to be online before booting the GUI.

The GUI does not wait for the network to be online: graphical.target completing is not the point at which the GUI is displayed. That'd be Phosh's service unit. graphical.target is dependent on the set of units that should be started for graphical sessions, of which network-online.target is reasonable.

"Boot speed" is poorly defined: many independent things occur at boot.

"Time to interactive GUI" is what I care about. To improve that, I should look into what Phosh's unit dependencies, and Phosh's startup itself.

tomfitzhenry

comment created time in a month

issue commentNixOS/mobile-nixos

pine64-pinephone: Phosh boot delayed by network-online.target (6.7s for my Wifi; timeout for when there is no signal)

You think 18 seconds is a long boot? Looks at android boot times... ;)

Haha. I tend to compare the boot time to my desktop, which seems faster.

tomfitzhenry

comment created time in a month

issue commentNixOS/mobile-nixos

pine64-pinephone: Phosh boot delayed by network-online.target (6.7s for my Wifi; timeout for when there is no signal)

I can't figure out where the dependency between multi-user.target and network-online.target comes from...

A workaround:

  systemd.services.NetworkManager-wait-online.serviceConfig.ExecStart = [
    "" # clear old command
    # Don't wait for online. This is a phone!
    "${pkgs.coreutils}/bin/true"
  ];

Eww.

tomfitzhenry

comment created time in a month

issue openedNixOS/mobile-nixos

pine64-pinephone: Phosh boot delayed by network-online.target (6.7s for my Wifi; timeout for when there is no signal)

My boot has been slow for a while, so I looked into it.

$ systemd-analyze critical-chain
The time when unit became active or started is printed after the "@" character.
The time the unit took to start is printed after the "+" character.

graphical.target @18.004s
└─multi-user.target @18.004s
  └─network-online.target @18.003s
    └─NetworkManager-wait-online.service @11.341s +6.659s
      └─NetworkManager.service @9.276s +1.649s
        └─network-pre.target @9.216s
          └─resolvconf.service @8.590s +604ms
            └─basic.target @8.319s
              └─sockets.target @8.304s
                └─nix-daemon.socket @8.288s
                  └─sysinit.target @8.122s
                    └─systemd-timesyncd.service @7.839s +265ms
                      └─systemd-tmpfiles-setup.service @7.694s +119ms
                        └─systemd-journal-flush.service @3.329s +4.338s
                          └─systemd-journald.service @2.821s +451ms
                            └─systemd-journald.socket @2.616s
                              └─system.slice @2.216s
                                └─-.slice @2.216s

The two big consumers are network-online.target and systemd-journal-flush.service . This issue tracks the time taken by network-online.target.

Since phone's can expect to occasionally be in places without signal, it's not reasonable to wait for the network to be online before booting the GUI.

created time in a month

pull request commentNixOS/nixpkgs

feedbackd: add device themes

Surprisingly, despite my local feedbackd build failing, Hydra is able to build this PR.

Locally I am building this via binfmt, which might be a factor in the difference in behaviour.

I will try to get this built locally so I can actually test it.

tomfitzhenry

comment created time in a month

pull request commentNixOS/nixpkgs

spot: 0.1.14 -> 0.2.0

You can target staging-next to get that.

Per https://nixos.org/manual/nixpkgs/stable/#submitting-changes-staging-next-branch, I will wait until staging-next gets merged into master. This is tracked in https://github.com/NixOS/nixpkgs/pull/135477.

tomfitzhenry

comment created time in a month

pull request commentNixOS/nixpkgs

video/clapper: init at 0.4.0

@tomfitzhenry 0.4.0 is released! And here is my package: https://github.com/VergeDX/config-nixpkgs/blob/master/packages/gui/clapper.nix

Great! 0.4.0 fixes the issues this PR had re the binary using argv[0] to build a resource path (which broke when wrapGapps changed argv[0]).

tomfitzhenry

comment created time in a month

Pull request review commentNixOS/nixpkgs

video/clapper: init at 0.4.0

+{ config, lib, stdenv, fetchFromGitHub+,  glib+,  gobject-introspection+,  python3+,  pkg-config+,  ninja+,  wayland+,  wayland-protocols+,  desktop-file-utils+,  makeWrapper+,  shared-mime-info+,  wrapGAppsHook+,  meson, gjs, gtk4, gst_all_1+}:++stdenv.mkDerivation rec {+  pname = "clapper";+  version = "0.3.0";++  src = fetchFromGitHub {+    owner  = "Rafostar";+    repo   = pname;+    rev    = version;+    sha256 = "0gvn36njyhvz1hcywmdkla5as0qdqgc1bvkymmaipn26d80vxkdr";+  };++  nativeBuildInputs = [+    desktop-file-utils # for update-desktop-database+    glib+    gobject-introspection+    meson+    ninja+    makeWrapper+    pkg-config+    python3+    shared-mime-info # for update-mime-database+    wrapGAppsHook # for gsettings+  ];++  buildInputs = [+    gjs+    gst_all_1.gstreamer+    gst_all_1.gst-plugins-base+    gst_all_1.gst-plugins-good+    gst_all_1.gst-plugins-bad+    gst_all_1.gst-plugins-ugly+    gst_all_1.gst-libav+    gst_all_1.gst-vaapi+    gtk4+    wayland+    wayland-protocols+  ];++  postPatch = ''+    patchShebangs build-aux/meson/postinstall.py+  '';++  mesonFlags = [+    # TODO: https://github.com/NixOS/nixpkgs/issues/36468+    "-Dc_args=-I${glib.dev}/include/gio-unix-2.0"+  ];++  postInstall = ''+    mv $out/bin $out/nobin

Fixed in latest PR, which uses 0.4, which doesn't need these hacks.

tomfitzhenry

comment created time in a month

PullRequestReviewEvent

push eventtomfitzhenry/nixpkgs

Sumner Evans

commit sha 8c6e887e750ed2c184e6018a8c3504124a09b1b3

matrix-synapse: 1.41.1 -> 1.42.0

view details

Ben Siraphob

commit sha 714c90ee5f04c1a0628cb5a708c3c70b869e7c05

coqPackages.mathcomp-analysis: 0.3.9 -> 0.3.10

view details

R. RyanTM

commit sha 9d0fb7791ce4e77e4fa72687a631e0daf555f323

python38Packages.python-nomad: 1.3.0 -> 1.4.1

view details

Hunter Jones

commit sha 3678b3d2c77c72547dea4714c5c3afcd4389bb1c

stellarsolver: 1.5 -> 1.8

view details

Bart Brouns

commit sha 6ffa6c67c95fdf65e503027cf7d605771c569291

ardour: 6.7 -> 6.9 (#136694)

view details

figsoda

commit sha d05a0f9cea9428be209231a51dbff7d9b877fe23

vimPlugins.vim-toml: fix branch name

view details

Mukund Lakshman

commit sha da8eac3184610dabfa6b80499f0d4f2b1af1548f

vimPlugins: update

view details

Mukund Lakshman

commit sha 47aadbb2377b220b4a0cb97faa50c68534e73437

vimPlugins.nvim-solarized-lua: init at 2021-07-09

view details

figsoda

commit sha 82d19cb068d7213c8beaa96220f1d81d57a28381

vimPlugins: fix update script

view details

R. RyanTM

commit sha e70fac7374980c31b3346008f76405d04e1bc2f4

python38Packages.pubnub: 5.2.0 -> 5.2.1

view details

Fabian Affolter

commit sha 6439f26a9b6f95ad1717388a0d27541eeffa00e2

python3Packages.archinfo: 9.0.9684 -> 9.0.9792

view details

Fabian Affolter

commit sha 6ba261ca10031a7f6582273549db81740030b7e9

python3Packages.ailment: 9.0.9684 -> 9.0.9792

view details

Fabian Affolter

commit sha 2df513ae1a621c9f7e9b77b7a2fd11869a7158c3

python3Packages.pyvex: 9.0.9684 -> 9.0.9792

view details

Fabian Affolter

commit sha a7cb4dabc70beaf675f172468bf4b2331b1473f3

python3Packages.claripy: 9.0.9684 -> 9.0.9792

view details

Fabian Affolter

commit sha 7d835af9d6f5cd7a7a78e1f940e2e63b210e95bb

python3Packages.cle: 9.0.9684 -> 9.0.9792

view details

Fabian Affolter

commit sha e46e3c798b8e2d456e41e5e8af3420ee516a51a1

python3Packages.angr: 9.0.9684 -> 9.0.9792

view details

Fabian Affolter

commit sha 9215390c882ae8c6d12694c575299e857e7b943f

python3Packages.angrop: 9.0.9684 -> 9.0.9792

view details

Jacob Foard

commit sha ec4c589e8da964edbdbba5f9942c549227d10665

golangci-lint: 1.42.0 -> 1.42.1

view details

Hunter Jones

commit sha bc19f8dd1eaca6cb0e9af129f1b6815b1b9cffc7

kstars: 3.5.3 -> 3.5.4

view details

taku0

commit sha 706f6c57be606a5676ea3e5193e671d36182c47a

thunderbird-bin: 91.0.3 -> 91.1.0

view details

push time in a month