profile
viewpoint

che-incubator/chectl 46

CLI to manage Eclipse Che server and workspaces

theia-ide/vscode-builtin-extensions 27

Built-in VS Code extensions for Theia

che-incubator/community-operators 0

The canonical source for Kubernetes Operators that appear on OperatorHub.io, OpenShift Container Platform and OKD.

che-incubator/ms-code.typescript 0

ms-code.typescript

che-incubator/vscode-intelephense 0

vscode-intelephense

che-samples/aspnetcore-realworld-example-app 0

ASP.NET Core backend implementation for RealWorld

issue commenteclipse/che

The rust getting started sample should use the vscode extension

@gattytto you can give a try:

apiVersion: 1.0.0
metadata:
  generateName: rust-
projects:
  - name: HelloWorld-Rust
    source:
      location: 'https://github.com/che-samples/helloworld-rust.git'
      type: git
      branch: master
components:
  - mountSources: true
    memoryLimit: 512Mi
    type: dockerimage
    alias: rust
    image: quay.io/eclipse/che-rust-1.39:nightly
 
  - type: chePlugin
    reference: 'https://gist.githubusercontent.com/sunix/eb86fdf6802afbfb4de059ed19f08d37/raw/41515915211723ca3c740d28263d7b8a87e0a8b6/meta.yaml'
 
commands:
  - name: build
    actions:
      - workdir: '${CHE_PROJECTS_ROOT}/HelloWorld-Rust'
        type: exec
        command: cargo build
        component: rust
  - name: run
    actions:
      - workdir: '${CHE_PROJECTS_ROOT}/HelloWorld-Rust'
        type: exec
        command: cargo run
        component: rust

sunix

comment created time in 3 minutes

issue closedeclipse/che

[chectl] - set CheCluster `server.cheClusterRoles` to namespace-editor ClusterRole

Is your enhancement related to a problem? Please describe.

<!-- A clear and concise description of what the problem is. Ex. I'm always frustrated when [...] --> When chectl deploys ClusterRoles for operator, it uses custom naming. It needs to tell che-operator the name of namespace-editor ClusterRole.

Describe the solution you'd like

<!-- A clear and concise description of what you want to happen. --> When chectl deploys che-operator, it should set the namespace-editor ClusterRole name to server.cheClusterRoles of the CheCluster CR.

Describe alternatives you've considered

<!--A clear and concise description of any alternative solutions or features you've considered. -->

Additional context

<!-- Add any other context or screenshots about the enhancement here. --> https://github.com/eclipse/che/issues/17504

closed time in 30 minutes

sparkoo

issue commenteclipse/che

[chectl] - set CheCluster `server.cheClusterRoles` to namespace-editor ClusterRole

fixed by https://github.com/che-incubator/chectl/pull/1003

sparkoo

comment created time in 30 minutes

issue openedeclipse/che

Rework the "ProjectTree.waitProjectImported" method for avoiding project import rejecting

Is your task related to a problem? Please describe.

By default, the "ProjectTree.waitProjectImported" has a too small timeout for waiting project folder before page refresh. It leeads to the rejecting project import.

Describe the solution you'd like

Rework method logic for waiting a longer time before the page refreshing.

Describe alternatives you've considered

<!--A clear and concise description of any alternative solutions or features you've considered. -->

Additional context

<!-- Add any other context or screenshots about the task here. -->

created time in an hour

issue openedeclipse/che

Expose DevWorkspaces CR from the Dashboard

To promote DevWorkspace Operator, we want to optionally expose DevWorkspace CRs from the Dashboard according to DevWorkspace Operator availability + user preferences. It may be something like mode, where we don't mix old workspace and new ones, but just write Dashboard from one workspace type to another.

From UI Perspective they both have Devfile (old devfile1.x and devworkspace with devfile 2.x) + Workspace Status.

Che Server already has a temporary solution (k8s proxy) that allows users to access K8s API with user token, it's supported on OpenShift cluster where Che is configured with OpenShift OAuth enabled.

created time in an hour

pull request commenteclipse/che

Adding support for Keycloak admin secret and endpoint-watcher image configuration

Thank you for contribution. I've changed some names to be consistent with --installer operator approach.

That's perfect and a good idea. I am not really familiar with the operator, so yes feel free to show the way 👍

cccs-eric

comment created time in 2 hours

Pull request review commenteclipse/che

Adding support for Keycloak admin secret and endpoint-watcher image configuration

 spec:           value: keycloak         - name: DB_PASSWORD           value: keycloak+{{- if .Values.keycloakAdminUserSecret }}         - name: KEYCLOAK_USER-          value: {{ .Values.keycloakAdminUserName }}+          valueFrom:+            secretKeyRef:+              name: {{ .Values.keycloakAdminUserSecret }}+              key: KEYCLOAK_USER         - name: KEYCLOAK_PASSWORD-          value: {{ .Values.keycloakAdminUserPassword }}+          valueFrom:+            secretKeyRef:+              name: {{ .Values.keycloakAdminUserSecret }}+              key: KEYCLOAK_PASSWORD+{{- else }}+        - name: KEYCLOAK_USER+          value: {{ .Values.keycloakAdminUserName | default "admin" }}

You are right, but I thought some defensive programming wouldn't harm. I find sometimes it acts as unofficial documentation! But I am fine with removing the default if you want to keep it consistent with the rest of the chart.

cccs-eric

comment created time in 2 hours

issue openedeclipse/che

Upgrade VS Code Language Support for camel to 0.0.29

Is your enhancement related to a problem? Please describe.

new release available

Describe the solution you'd like

<!-- A clear and concise description of what you want to happen. -->

Describe alternatives you've considered

<!--A clear and concise description of any alternative solutions or features you've considered. -->

Additional context

<!-- Add any other context or screenshots about the enhancement here. -->

created time in 3 hours

issue commenteclipse/che

Upgrade VS Code Camel K to 0.0.19

prepared plufin reguistry branch https://github.com/apupier/che-plugin-registry/tree/18521-upgradeVSCodeCamelKTo0.0.19 will need to put the new sidecar image id when https://github.com/che-dockerfiles/che-sidecar-camelk/pull/15 will be merged

apupier

comment created time in 3 hours

issue openedeclipse/che

Upgrade VS Code Camel K to 0.0.20

Is your enhancement related to a problem? Please describe.

new release available

Describe the solution you'd like

<!-- A clear and concise description of what you want to happen. -->

Describe alternatives you've considered

<!--A clear and concise description of any alternative solutions or features you've considered. -->

Additional context

needs to update sidecar to use Kamel 1.2.1

created time in 3 hours

issue openedeclipse/che

Enable external solvers of WorkspaceRouting objects in devworkspace operator

Is your enhancement related to a problem? Please describe.

To kickstart the work on Che as an "enabler" of devworkspaces we need an ability to hook into the workspace resolution as done by the devworkspace controller.

Today, this is done in-process of the devworkspace controller using a concept of a "solver" of a WorkspaceRouting object. The "solution" might be a list of additions to the workspace pod but also external objects like configmaps, services, secrets, etc. This is required for all tasks that need to be done "around" the workspace pod, like reconfiguring the reverse proxy in singlehost mode, mounting secrets with credentials, etc.

Describe the solution you'd like

We should extend the concept of the "solver" to also happen out-of-process by e.g. en external controller reconciling the WorkspaceRouting objects.

created time in 3 hours

delete branch eclipse/che

delete branch : che-17634-fix1

delete time in 3 hours

push eventeclipse/che

Mykola Morhun

commit sha 286459283ad2097d7c177df829033f785a2e21ea

Fix exception if no data in certs config map (#18519) Signed-off-by: Mykola Morhun <mmorhun@redhat.com>

view details

push time in 3 hours

PR merged eclipse/che

Reviewers
Fix exception if no data in certs config map kind/bug status/code-review

What does this PR do?

Provides fix for inability to start second workspace for the user

Screenshot/screencast of this PR

N/A

What issues does this PR fix or reference?

Failure to start second workspace for the user cause by exception:

<details>

2020-12-03 07:46:49,827[aceSharedPool-1]  [WARN ] [.i.k.KubernetesInternalRuntime 257]  - Failed to start Kubernetes runtime of workspace workspacem1wn6pmb06ltlsrn.
java.lang.NullPointerException: null
	at org.eclipse.che.workspace.infrastructure.kubernetes.provision.KubernetesTrustedCAProvisioner.provision(KubernetesTrustedCAProvisioner.java:117)
	at org.eclipse.che.workspace.infrastructure.kubernetes.KubernetesEnvironmentProvisioner$KubernetesEnvironmentProvisionerImpl.provision(KubernetesEnvironmentProvisioner.java:185)
	at org.eclipse.che.workspace.infrastructure.kubernetes.wsplugins.PluginBrokerManager.getTooling(PluginBrokerManager.java:118)
	at org.eclipse.che.workspace.infrastructure.kubernetes.wsplugins.SidecarToolingProvisioner.provision(SidecarToolingProvisioner.java:90)
	at org.eclipse.che.workspace.infrastructure.kubernetes.KubernetesInternalRuntime.provisionWorkspace(KubernetesInternalRuntime.java:288)
	at org.eclipse.che.workspace.infrastructure.kubernetes.KubernetesInternalRuntime.internalStart(KubernetesInternalRuntime.java:204)
	at org.eclipse.che.api.workspace.server.spi.InternalRuntime.start(InternalRuntime.java:141)
	at org.eclipse.che.api.workspace.server.WorkspaceRuntimes$StartRuntimeTask.run(WorkspaceRuntimes.java:969)
	at org.eclipse.che.commons.lang.concurrent.CopyThreadLocalRunnable.run(CopyThreadLocalRunnable.java:38)
	at java.base/java.util.concurrent.CompletableFuture$AsyncRun.run(Unknown Source)
	at io.micrometer.core.instrument.internal.TimedRunnable.run(TimedRunnable.java:44)
	at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(Unknown Source)
	at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(Unknown Source)
	at org.eclipse.che.commons.observability.CountedThreadFactory.lambda$newThread$0(CountedThreadFactory.java:75)
	at java.base/java.lang.Thread.run(Unknown Source)
2020-12-03 07:46:49,903[aceSharedPool-1]  [INFO ] [o.e.c.a.w.s.WorkspaceRuntimes 995]   - Workspace 'admin:golang-omt8y' with id 'workspacem1wn6pmb06ltlsrn' start failed
2020-12-03 07:46:49,903[aceSharedPool-1]  [ERROR] [o.e.c.a.w.s.WorkspaceRuntimes 1005]  - An exception occurred.
org.eclipse.che.api.workspace.server.spi.InternalInfrastructureException: An exception occurred.
	at org.eclipse.che.workspace.infrastructure.kubernetes.KubernetesInternalRuntime.wrapAndRethrow(KubernetesInternalRuntime.java:966)
	at org.eclipse.che.workspace.infrastructure.kubernetes.KubernetesInternalRuntime.internalStart(KubernetesInternalRuntime.java:277)
	at org.eclipse.che.api.workspace.server.spi.InternalRuntime.start(InternalRuntime.java:141)
	at org.eclipse.che.api.workspace.server.WorkspaceRuntimes$StartRuntimeTask.run(WorkspaceRuntimes.java:969)
	at org.eclipse.che.commons.lang.concurrent.CopyThreadLocalRunnable.run(CopyThreadLocalRunnable.java:38)
	at java.base/java.util.concurrent.CompletableFuture$AsyncRun.run(Unknown Source)
	at io.micrometer.core.instrument.internal.TimedRunnable.run(TimedRunnable.java:44)
	at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(Unknown Source)
	at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(Unknown Source)
	at org.eclipse.che.commons.observability.CountedThreadFactory.lambda$newThread$0(CountedThreadFactory.java:75)
	at java.base/java.lang.Thread.run(Unknown Source)
Caused by: java.lang.NullPointerException: null
	at org.eclipse.che.workspace.infrastructure.kubernetes.provision.KubernetesTrustedCAProvisioner.provision(KubernetesTrustedCAProvisioner.java:117)
	at org.eclipse.che.workspace.infrastructure.kubernetes.KubernetesEnvironmentProvisioner$KubernetesEnvironmentProvisionerImpl.provision(KubernetesEnvironmentProvisioner.java:185)
	at org.eclipse.che.workspace.infrastructure.kubernetes.wsplugins.PluginBrokerManager.getTooling(PluginBrokerManager.java:118)
	at org.eclipse.che.workspace.infrastructure.kubernetes.wsplugins.SidecarToolingProvisioner.provision(SidecarToolingProvisioner.java:90)
	at org.eclipse.che.workspace.infrastructure.kubernetes.KubernetesInternalRuntime.provisionWorkspace(KubernetesInternalRuntime.java:288)
	at org.eclipse.che.workspace.infrastructure.kubernetes.KubernetesInternalRuntime.internalStart(KubernetesInternalRuntime.java:204)
	... 9 common frames omitted

</details>

How to test this PR?

Start two workspaces simultaniously

PR Checklist

As the author of this Pull Request I made sure that:

Reviewers

Reviewers, please comment how you tested the PR when approving it.

+3 -1

1 comment

1 changed file

mmorhun

pr closed time in 3 hours

issue commenteclipse/che

The rust getting started sample should use the vscode extension

@gattytto yes this is WIP :)

sunix

comment created time in 3 hours

issue commenteclipse/che

'Application not available' when starting a Che workspace

This is a central outage issue and if can not affect it. Closing since there was no issue reported during the periodic test summary.

sunix

comment created time in 3 hours

issue closedeclipse/che

'Application not available' when starting a Che workspace

Describe the bug

Starting a workspace it happens randomly about 3 times a day in che.openshift.io

image

I guess there is a synch issue, che-theia may be available internally but not externally maybe?

closed time in 3 hours

sunix

issue closedeclipse/che

Make it possible to deny usage of plugins not from plugin-registry

Is your task related to a problem? Please describe.

Some modes may provide potential security risk for the workspace, in case of the usage of untrusted plugins that are located not in the central registry that was certified by Che vendor and configured by admin.

Describe the solution you'd like

We want to have a property that can enable the mode when the user can't start a workspace with plugins not from the central plugin registry.

Describe alternatives you've considered

n/a

Additional context

n/a

closed time in 3 hours

skabashnyuk

issue commenteclipse/che

Make it possible to deny usage of plugins not from plugin-registry

should be solved in a different way.

skabashnyuk

comment created time in 3 hours

issue commenteclipse/che

'Application not available' when starting a Che workspace

yeah, so we can increase it in the success threshold in the upstream, but it would result in slower performance - so it is a tradeoff. Also, note that there will be no such an issue when single-host become a default route exposure strategy

sunix

comment created time in 3 hours

delete branch eclipse/che

delete branch : pr-7.12.0-to-7.12.1

delete time in 3 hours

delete branch eclipse/che

delete branch : 7.18.1-fix

delete time in 3 hours

delete branch eclipse/che

delete branch : test-dto-build

delete time in 3 hours

Pull request review commenteclipse/che

Fix exception if no data in certs config map

 public void provision(KubernetesEnvironment k8sEnv, RuntimeIdentity runtimeID)      KubernetesNamespace namespace = namespaceFactory.getOrCreate(runtimeID);     Optional<ConfigMap> existing = namespace.configMaps().get(configMapName);-    if (existing.isEmpty() || !existing.get().getData().equals(allCaCertsConfigMap.getData())) {+    if (existing.isEmpty()+        || !(existing.get().getData() == allCaCertsConfigMap.getData()

Conditions B and C are logically related so, to my mind, it is clearer to leave that as is.

mmorhun

comment created time in 3 hours

pull request commenteclipse/che

Adapt tests to multi-root workspaces related changes

:x: E2E Happy path tests failed :heavy_exclamation_mark:

<details> <summary>See Details</summary> <p>

Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)

</p> </details>

  • Use comment "[crw-ci-test]" to rerun happy path E2E test.
  • Use comment "[crw-ci-test --rebuild]" to re-build the images and rerun happy path E2E test.
RomanNikitenko

comment created time in 3 hours

Pull request review commenteclipse/che

Fix exception if no data in certs config map

 public void provision(KubernetesEnvironment k8sEnv, RuntimeIdentity runtimeID)      KubernetesNamespace namespace = namespaceFactory.getOrCreate(runtimeID);     Optional<ConfigMap> existing = namespace.configMaps().get(configMapName);-    if (existing.isEmpty() || !existing.get().getData().equals(allCaCertsConfigMap.getData())) {+    if (existing.isEmpty()+        || !(existing.get().getData() == allCaCertsConfigMap.getData()

A || !(B || C) is hard to read and understand. The following can be a bit easier if A || !B && !C! If empty OR not the same (not equals in pointers terms && does not have the same values)

WDYT?

mmorhun

comment created time in 4 hours

push eventeclipse/che

Sergii Kabashniuk

commit sha 84f83abfc75911e10d309fad57721916eaaac472

Allow to replace backslash in usernames during first login (#18425) * Allow replacing backslash in usernames during the first login Signed-off-by: Sergii Kabashniuk <skabashniuk@redhat.com>

view details

Lukas Krejci

commit sha 0f1805e2bfea394f79b24d60580a4d18e5a2b568

Enable infrastructure request logging. (#16616) Signed-off-by: Lukas Krejci <lkrejci@redhat.com>

view details

Nick Boldt

commit sha 323136311f58c22375d73e0b062ed42d55fcf595

link to release guide section 2 - manual steps; instead of manually updated links to community PRs, use query (#18505) Change-Id: I29c1febedf33206eac510a428e1db07810d68707 Signed-off-by: nickboldt <nboldt@redhat.com>

view details

Roman Nikitenko

commit sha 82bfa0e909184545e0cff37a7ae9ccdc20ee119c

Adapt tests to multi-root workspaces related changes Signed-off-by: Roman Nikitenko <rnikiten@redhat.com>

view details

Roman Nikitenko

commit sha 0992b1f84d5fb48981a2b2f3e544d7f8688e1a2e

Allign name of the debug configuration with multi-root related changes Signed-off-by: Roman Nikitenko <rnikiten@redhat.com>

view details

push time in 4 hours

push eventeclipse/che

Roman Nikitenko

commit sha db640801eb014de6f437ee4750145dea11401e80

Allign name of the debug configuration with multi-root related changes Signed-off-by: Roman Nikitenko <rnikiten@redhat.com>

view details

push time in 4 hours

issue closedeclipse/che

Useless error message on factory crane screen if devfile is invalid

<!-- To make it easier for us to help you, please include as much useful information as possible.

Useful Links:

  • Documentation: https://www.eclipse.org/che/docs
  • Contributing: https://github.com/eclipse/che/blob/master/CONTRIBUTING.md

Eclipse Che has public chat on:

  • Mattermost: https://mattermost.eclipse.org/eclipse/channels/eclipse-che

Before opening a new issue, please search existing issues https://github.com/eclipse/che/issues -->

Describe the bug

<!-- A clear and concise description of what the bug is. --> Factory crane screen does not give meaningful message when devfile is invalid. It only writes Failed to fetch the devfile due to "400 Bad Request" returned by "/api/factory/resolver", which is more misleading than useful.

https://che.openshift.io/f?url=https://gist.githubusercontent.com/sparkoo/61c3edb2e245362e8aafda71074bd92c/raw/07b3081c6987cfe4f712711185de17f37104e2e6/invalidDevfile.yaml

Che version

<!-- (if workspace is running, version can be obtained with help/about menu) -->

  • [x] latest

Steps to reproduce

  1. open invalid devfile with factory url
    • you can use this devfile https://gist.githubusercontent.com/sparkoo/61c3edb2e245362e8aafda71074bd92c/raw/07b3081c6987cfe4f712711185de17f37104e2e6/invalidDevfile.yaml
    • che.openshift.io factory link https://che.openshift.io/f?url=https://gist.githubusercontent.com/sparkoo/61c3edb2e245362e8aafda71074bd92c/raw/07b3081c6987cfe4f712711185de17f37104e2e6/invalidDevfile.yaml
  2. see error message

Expected behavior

<!-- A clear and concise description of what you expected to happen. --> We should give meaningful message what really happens. In this case something like "invalid devfile" and even better to write some output of devfile validation (like in dashboard editor).

Runtime

  • [x] Openshift (include output of oc version)

Screenshots

<!-- If applicable, add screenshots to help explain your problem. --> 20201202_145812_687x556_scrot

Installation method

  • [x] I don't know

Environment

  • [x] che.openshift.io

Eclipse Che Logs

<!-- https://www.eclipse.org/che/docs/che-7/collecting-logs-using-chectl -->

Additional context

<!-- Add any other context about the problem here. -->

closed time in 4 hours

sparkoo

issue commenteclipse/che

Useless error message on factory crane screen if devfile is invalid

I think it's a duplicate of #18164

yes, I'm closing this one

sparkoo

comment created time in 4 hours

more