profile
viewpoint
Thanh Nguyen thanhcs Ascension Austin, Texas

brianleppez/collatz 0

This repo was created for the first assignment in Object-Oriented Programming taught by Dr. Downing.

brianleppez/darwin 0

This repo was created for the fourth assignment in Object-Oriented Programming taught by Dr. Downing

brianleppez/life 0

This repo was created for the fifth and final assignment in Object-Oriented Programming taught by Dr. Downing.

brianleppez/voting 0

This repo was created for the second assignment in Object-Oriented Programming taught by Dr.Downing

issue commentsjh37/EntityFramework-Reverse-POCO-Code-First-Generator

How to use Identity 3

thank you very much

javadinasab

comment created time in 10 minutes

push eventxamarin/Xamarin.Forms

shane

commit sha 7da164d55e8db52d87c2ac053cb5f0a318d37a51

- fix nre

view details

push time in 2 hours

pull request commentxamarin/Xamarin.Forms

Add ability to set WebView ExecutionMode property (addresses #4720)

<samp> No pipelines are associated with this pull request.<br>

</samp>

t-johnson

comment created time in 2 hours

Pull request review commentxamarin/Xamarin.Forms

Convert ShellContent transitions to use animators and be smarter about selecting visible content

 protected virtual void OnShellSectionPropertyChanged(object sender, PropertyChan 					return;  				var currentRenderer = _renderers[newContent];+				_isAnimatingOut = oldRenderer;+				_pageAnimation?.StopAnimation(true);+				_pageAnimation = null;+				_pageAnimation = CreateContentAnimator(oldRenderer, currentRenderer, oldIndex, newIndex, _containerArea); -				// -1 == slide left, 1 ==  slide right-				int motionDirection = newIndex > oldIndex ? -1 : 1;+				if (_pageAnimation != null)+				{+					_pageAnimation.AddCompletion((p) =>+					{+						if (_isDisposed)+							return; -				_containerArea.AddSubview(currentRenderer.NativeView);+						if (p == UIViewAnimatingPosition.End)+						{+							RemoveNonVisibleRenderers();+						}+					}); -				_isAnimatingOut = oldRenderer;+					_pageAnimation.StartAnimation();+				}+				else+				{+					RemoveNonVisibleRenderers();+				}+			}+		} -				currentRenderer.NativeView.Frame = new CGRect(-motionDirection * View.Bounds.Width, 0, View.Bounds.Width, View.Bounds.Height);+		UIViewPropertyAnimator CreateContentAnimator(

@GiampaoloGabba I'm thinking after this PR is merged we can make this or something close to this virtual for some added animation customizations!!

PureWeen

comment created time in 3 hours

push eventxamarin/Xamarin.Forms

Shane Neuville

commit sha f4d81b6d419770180e6a039f8b8e6183a6d585cd

P3 update

view details

push time in 3 hours

issue commentxamarin/Xamarin.Forms

[Bug] [iOS] DatePicker & TimePicker inconsistency on iOS 14

The workaround did change the style perfectly. But it didn't help show the selected date? I also tried adding UITextField entry = Control;UIDatePicker picker = (UIDatePicker)entry.InputView; It doesn't work. Anything missing?

mduchev

comment created time in 3 hours

issue commentxamarin/Xamarin.Forms

[Bug] HttpClient with HttpClientHandler // Timeout is not working

i think this is same problem #10214

gtame

comment created time in 4 hours

create barnchxamarin/Xamarin.Forms

branch : housekeeping/fix-codeformatting

created branch time in 4 hours

PR opened xamarin/Xamarin.Forms

[housekeeping] Automated PR to fix formatting errors

Automated PR to fix formatting errors

+8 -9

0 comment

4 changed files

pr created time in 4 hours

issue commentxamarin/Xamarin.Forms

[Bug] In a UWP AppShell app, using a CollectionView within a StackLayout along with a solitary label gives a blank screen.

This and #8814 do indeed appear to be the same problem. It's something specific to Shell, and possibly related to the timing things we fixed in #12017.

davefxy

comment created time in 4 hours

issue commentxamarin/Xamarin.Forms

[Bug] In a UWP AppShell app, using a CollectionView within a StackLayout along with a solitary label gives a blank screen.

Why does having a button in stacklayout have the same effect as the window resize?

My guess is that it's an image button, and the image loading is async. So once the image has loaded, the button resizes and causes a re-layout; essentially the same thing that's happening when you resize the window.

davefxy

comment created time in 4 hours

issue commentxamarin/Xamarin.Forms

[Bug] Scroll position issues with CollectionView when inside RefreshView

Any workaround for this issue? Facing the exactly same situation....

dsdilpreet

comment created time in 4 hours

pull request commentxamarin/Xamarin.Forms

[Bug] [UWP] Modify ItemsViewRenderer to handle ItemsSource being set during Layout

@hartez Great!, glad the other layout changes addressed this problem. I was wondering if a lower level issue might have been involved.

bmacombe

comment created time in 4 hours

PR closed xamarin/Xamarin.Forms

Reviewers
[Bug] [UWP] Modify ItemsViewRenderer to handle ItemsSource being set during Layout a/carouselview a/collectionview a/layout a/shell :shell: blocker m/high impact :black_large_square: p/UWP t/bug :bug:

Description of Change

This PR prevents the ItemsViewRenderer from setting the ItemSource on ListViewBase before it has been through the layout process. Waiting for the ListViewBase SizeChanged event to be called and for it to have a width is used as the check for layout completed. UpdateItemSource was split into two methods with setting the ListViewBase.ItemSource and Empty view only occurring after SizeChanged has been called.

Original Description Forces a Layout of the ItemList in the ItemsViewRenderer (CollectionView and CarouselView) when the ItemsSource is updated.

As shown in #10977 if the ItemsSource of the CollectionView is changed during a page OnAppearing event, it causes an issue with the UWP layout cycle. It's some type of timing issues as adding a delay of even 1ms resolves the issue in testing, but relying on a simple delay could be inconsistent depending on the machine, etc.

Ideally, I would want to detect if we were in OnAppearing event and only force the UploadLayout in that case. But I've been unable to find a way to detect that. This PR could be improved if there is a way to do that.

Since UWP is a desktop platform, it's likely that forcing a Layout cycle of just the ListViewBase and it's sub tree won't be very noticeable.

I did test the same example in 10977 with a ListView and it worked fine to set ItemSource in OnAppearing, so it's likely that existing apps my use this method to set ItemsSource and should be expected to work.

Issues Resolved

  • fixes #10977
  • fixes #8814
  • likely fixes #12009 - Don't have a repro to test

API Changes

None

Platforms Affected

  • UWP

Behavioral/Visual Changes

Forces the collection view to layout and be displayed when the itemsSource is updated during page appearance.

Before/After Screenshots

10977 Before

Before

After

After

8814 Before

Before

After

After

Testing Procedure

Open Issue 10977 page and ensure all controls are visible and click both test buttons

PR Checklist

<!-- To be completed by reviewers -->

  • [ ] Targets the correct branch
  • [ ] Tests are passing (or failures are unrelated)
+146 -1

30 comments

4 changed files

bmacombe

pr closed time in 5 hours

pull request commentxamarin/Xamarin.Forms

[Bug] [UWP] Modify ItemsViewRenderer to handle ItemsSource being set during Layout

I'm going to go ahead and close this; if you think you have one of the issues addressed here and updating to 5.0.0 pre-2 or higher doesn't address it, ping me here and I'll reopen.

bmacombe

comment created time in 5 hours

pull request commentxamarin/Xamarin.Forms

[Bug] [UWP] Modify ItemsViewRenderer to handle ItemsSource being set during Layout

@bmacombe you were right, this was a timing/race condition issue. Looks like this issue was fixed by https://github.com/xamarin/Xamarin.Forms/pull/12017. So updating to 5.0.0 pre2 or higher will take care of it.

bmacombe

comment created time in 5 hours

issue closedxamarin/Xamarin.Forms

[Bug] UWP: Page with CollectionView is not displayed until the window is resized.

Description

In some situations, only blank page is rendered when the application starts. After the window is resized by the user, all the content suddenly appears. I have prepared a simplified version of my project:

UwpBug-2020-06-06.zip

There is a page with a SearchBar, CollectionView and a Button. When the app is started, only blank page is displayed. When I resize the window, all the content (SearchBar, CollectionView and a Button) becomes visible.

This is even more complicated as this bug is present about 90% of times, but sometimes when I run the app, the content is visible immediately (usually when I delete bin and obj folders manually). When I rerun the app, the bug is there.

Another complication is that depending on Xamarin.Forms version, the behavior seems to be sometimes different depending on if you use Debug or Release versions! I have found the bug when just before uploading my app to Microsoft Store. I have used only Debug version during development. Before uploading the final version I wanted to try also the Release version just to be sure. And I have found out that it is not working. In my case, version 4.6.0.726 worked correctly in Debug but not in the Release mode. Upgrading to 4.6.0.847 made things even worse and the bug was there in both Debug and Release modes. However, I am not able to reproduce this difference in by repro solution.

Just creating the repro solution took me a few hours because I started with my app and removed one thing by another and tested if the bug is still there (both in debug and release; and UWP release build is ridiculously slow). I needed to make sure that the bug is not caused by some other Nuget.

This bug might be connected to the Issue #10862. However, there is no need to click and navigate in this case (compared to the situation mentioned in #10862). So it can be a different problem.

Steps to Reproduce

  1. Download the attached solution.
  2. Run the UWP project. The page is blank (if it is not, close the app and run it again).
  3. Resize the window. Now the content is visible.
  4. I have included also Android project for comparison to make sure there is no problem in the code. If you try the Android project, it is displayed correctly. The bug is only in UWP.

Expected Behavior

The content (SearchBar, CollectionView and a Button) is visible right after the start. Also the behavior should be deterministic and it should be the same for Debug and Release versions.

Actual Behavior

The content is hidden (most of the times) until the window is resized.

Basic Information

  • Version with issue: Xamarin.Forms 4.6.0.847
  • Last known good version: unknown
  • IDE: VS 2019 (16.6.1)
  • Platform Target Frameworks:
    • UWP: 1903
  • Nuget Packages: Only basic packages that are included when new Xamarin.Forms project is created in VS (Xamarin.Forms, Essentials, etc.).

Screenshots

When the app is started, nothing is there: UWPBug-release-after start

When I resize the window, all content become visible: UWPBug-release-after resize

closed time in 5 hours

holecekp

issue commentxamarin/Xamarin.Forms

[Bug] UWP: Page with CollectionView is not displayed until the window is resized.

The original repro project from @holecekp works fine if I update it to 5.0.0 pre2. The layout timing/update issue appears to have been fixed by https://github.com/xamarin/Xamarin.Forms/pull/12017.

holecekp

comment created time in 5 hours

PR opened xamarin/Xamarin.Forms

[DNM] Remove reflection from Resource Manager DO-NOT-MERGE-!!! :stop_sign:

Run Android UI Tests without reflection to see everything still works

+34 -162

0 comment

6 changed files

pr created time in 5 hours

push eventxamarin/Xamarin.Forms

github-actions[bot]

commit sha a78e39ccac19e46a7c6837805eaa27e822ad0179

Automated dotnet-format update (#12985) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

view details

Rui Marinho

commit sha da92891e80dd82bf7c7e959b3d0147986e950404

[Nuget] Fix sigining on main nightly

view details

Rui Marinho

commit sha 0ecd46dc042a60ed4d0669e01da6d59a4d19c684

[Build] Update sign nuget when nightly main is building

view details

E.Z. Hart

commit sha f6370c22c886865b383699bada44ab678deb2f49

Handle selected background color updates after cell is added as child of CollectionView (#12823) fixes #9282 * Handle selected background color updates after cell is added as child of CollectionView Fixes #9282 * Fix formatting

view details

Rui Marinho

commit sha 2dfbf5f5b9ca2637828136abbdc6b50190de5fab

[iOS] Fix when removing current last Item on CarouselView (#12837) * [iOS] Fix when removing current last Item on CarouselView * [Uitests] Try fix test for 12574 * [iOS] Fix scroll when removing item on CarouselView * [iOS] Use CollectionView.PerformBatchUpdates to scroll to item after CollectionView reloads it's items * [iOS] Set Reload next to Scroll to better understand the logic between the 2 * [iOS] Fix for reload items and wait for iOS12 and iOS11 * Provide pre and post update events for CarouselView to do its bookkeeping * Remove animation after item removal * [Controls] Fix sample 12574 * [UITests] Enable test * Remove performBatchUpdates calls to prevent data disparity; * Remove async stuff from ObservableGroupedSource * Fix reload race condition with deletion/insertion of groups * Reset current item and position when ItemsSource resets * Update ObservableSource count before invoking Carousel's changed handler; Reset position/current item on ItemsSource update Don't update position until drag is released * Clean up unnecessary ReloadRequired stuff * Handle UICollectionView internal accounting edge cases Co-authored-by: E.Z. Hart <hartez@gmail.com>

view details

memu8

commit sha 0b74649bf318ae4067f98e736b1e08b12153ffa2

Added a Flow Direction Property to action sheets and alert dialogs (#11679) * added constructor actionsheet * added flow direction to action sheets on Android * added flow direction to alerts on Android * added Android alert dialog flow direction * UWP alert/actionsheet flow direction * add alert dialog flow direction * added flow direction to UWP alert and actionsheets * fixes #2448 * fixes #2448 * fixes #2448 * fixes #2448 * fixes #2448 * fixes #2448 * fixes #2448 * Fix rebase errors * - fix rebase Co-authored-by: E.Z. Hart <hartez@gmail.com> Co-authored-by: Shane Neuville <shneuvil@microsoft.com>

view details

Shane Neuville

commit sha 999a07262a1e3dffe281a5c7f64bd7dc58f755f2

Merge branch '5.0.0' into flyout_sizing

view details

push time in 5 hours

pull request commentxamarin/Xamarin.Forms

Shell FlyoutWidth and FlyoutHeight

https://dev.azure.com/xamarin/public/_releaseProgress?releaseId=2596&_a=release-pipeline-progress

PureWeen

comment created time in 5 hours

create barnchxamarin/Xamarin.Forms

branch : remove_resource_reflection

created branch time in 5 hours

issue commentxamarin/Xamarin.Forms

[Bug] Big Sur: XamarinFormsPrevieweriOS cannot be opened because of a problem

I can’t unfortunately provide a repro as it’s not project dependent, and happens with any project (including bug repro projects downloaded from this site).

Tommigun1980

comment created time in 6 hours

pull request commentxamarin/Xamarin.Forms

[iOS] Fix issue using TapGesture

We should run all uitests as this test is not just on iOS

jsuarezruiz

comment created time in 6 hours

Pull request review commentxamarin/Xamarin.Forms

[iOS] Fix issue using TapGesture

+using System;+using System.Collections.Generic;+using System.Linq;+using Xamarin.Forms.CustomAttributes;+using Xamarin.Forms.Internals;+using Xamarin.Forms.Shapes;++#if UITEST+using Xamarin.Forms.Core.UITests;+using Xamarin.UITest;+using NUnit.Framework;+#endif++namespace Xamarin.Forms.Controls.Issues+{+#if UITEST+	[Category(UITestCategories.Shape)]+#endif+    [Preserve(AllMembers = true)]+    [Issue(IssueTracker.Github, 10623, "Tap Gesture not working on iOS [Bug]", PlatformAffected.iOS)]+    public class Issue10623 : TestContentPage+	{+		public Issue10623()+        {+            Device.SetFlags(new List<string>(Device.Flags ?? new List<string>()) { "Shapes_Experimental" });

think we don't need this right?

jsuarezruiz

comment created time in 6 hours

create barnchxamarin/Xamarin.Forms

branch : ChummerUA-fix-9125

created branch time in 6 hours

pull request commentxamarin/Xamarin.Forms

Fix-9906 [Bug] Setting CharacterSpacing on Button leads to crash on iOS

<samp> No pipelines are associated with this pull request.<br>

</samp>

yurkinh

comment created time in 6 hours

more