profile
viewpoint
If you are wondering where the data of this site comes from, please visit https://api.github.com/users/tddsg/events. GitMemory does not store any data, but only uses NGINX to cache data for a period of time. The idea behind GitMemory is simply to give users a better reading experience.

tddsg/alembic 0

⚗️ A Jekyll boilerplate theme designed to be a starting point for any Jekyll website

tddsg/architect-theme 0

Open Source version of the GitHub Pages theme

tddsg/BeamerTitleSlide 0

Example showing how to make a slick title slide for beamer presentations

tddsg/clang-ast-builder 0

Example Code for using Clang as an AST Builder

tddsg/emacs-helm-ag 0

The silver searcher with helm interface

tddsg/golden-ratio.el 0

Automatic resizing of Emacs windows to the golden ratio

tddsg/Guitar 0

Score

tddsg/header-line.el 0

A package showing header line of Emacs

tddsg/helm 0

Emacs incremental completion and selection narrowing framework

issue commentrust-lang/rust

Tracking Issue for `std::io::read_to_string`

@rust-lang/libs

Can we start an FCP?

camelid

comment created time in 15 minutes

pull request commentrust-lang/rust

Better errors for Debug and Display traits

:hourglass: Testing commit 20ea5fedeab3834b2b2579c11c63e8b696de49ea with merge 8cb207ae69700de3e782eec5cc9013c0987b2519... <!-- homu: {"type":"BuildStarted","head_sha":"20ea5fedeab3834b2b2579c11c63e8b696de49ea","merge_sha":"8cb207ae69700de3e782eec5cc9013c0987b2519"} -->

inquisitivecrystal

comment created time in 16 minutes

pull request commentrust-lang/rust

[beta] Bootstrap from stable

:broken_heart: Test failed - checks-actions <!-- homu: {"type":"BuildFailed","builder_url":"https://github.com/rust-lang-ci/rust/runs/2891164317","builder_name":"checks-actions"} -->

Mark-Simulacrum

comment created time in 16 minutes

pull request commentrust-lang/rust

[beta] Bootstrap from stable

The job dist-x86_64-linux-alt failed! Check out the build log: (web) (plain)

<details><summary><i>Click to see the possible cause of the failure (guessed by this bot)</i></summary>


To learn more, run the command again with --verbose.
command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "build" "--target" "x86_64-unknown-linux-gnu" "-Zbinary-dep-depinfo" "-j" "16" "--release" "--locked" "--color" "always" "--manifest-path" "/checkout/src/tools/miri/Cargo.toml" "--features" "rustc-workspace-hack/all-static" "--message-format" "json-render-diagnostics"
expected success, got: exit status: 101
thread 'main' panicked at 'Unable to build miri', src/bootstrap/dist.rs:44:9
[TIMING] ToolBuild { compiler: Compiler { stage: 1, host: TargetSelection { triple: "x86_64-unknown-linux-gnu", file: None } }, target: TargetSelection { triple: "x86_64-unknown-linux-gnu", file: None }, tool: "miri", path: "src/tools/miri", mode: ToolRustc, is_optional_tool: true, source_type: Submodule, extra_features: [] } -- 31.013
[TIMING] Miri { compiler: Compiler { stage: 1, host: TargetSelection { triple: "x86_64-unknown-linux-gnu", file: None } }, target: TargetSelection { triple: "x86_64-unknown-linux-gnu", file: None }, extra_features: [] } -- 0.000
failed to run: /checkout/obj/build/bootstrap/debug/bootstrap dist --host x86_64-unknown-linux-gnu --target x86_64-unknown-linux-gnu --include-default-paths src/tools/build-manifest --rust-profile-use=/tmp/rustc-pgo.profdata
Build completed unsuccessfully in 0:22:51

</details>

Mark-Simulacrum

comment created time in 16 minutes

pull request commentrust-lang/rust

Revert "List trait impls before methods from deref in the sidebar ..."

:pushpin: Commit 093e2464455bd7fff614ff4c658f6a1eb5e7a89d has been approved by jyn514

<!-- @bors r=jyn514 093e2464455bd7fff614ff4c658f6a1eb5e7a89d --> <!-- homu: {"type":"Approved","sha":"093e2464455bd7fff614ff4c658f6a1eb5e7a89d","approver":"jyn514"} -->

jsha

comment created time in 17 minutes

pull request commentrust-lang/rust

Revert "List trait impls before methods from deref in the sidebar ..."

@bors r+

jsha

comment created time in 17 minutes

issue commentrust-lang/rust

Can't infer type

Please do not attach a screenshot. Provide your two functions in text, so one can use the playground to test/reproduce this.

Tobs40

comment created time in 39 minutes

issue commentrust-lang/rust

variable shadowing bug in loop not caught by compiler and crashing at runtime.

This is not a bug in the compiler. You can shadow variables.

let mut guess = String::new();
loop {
    io::stdin().read_line(&mut guess).expect("Failed to read line");
    // ^ `guess` as a variable of `u32` is not visible to this line...
    let guess:u32 = guess.trim().parse().expect("Please type a number!");
    // because it is only defined here in the loop...
}
IwateKyle

comment created time in 40 minutes

pull request commentrust-lang/rust

Fix crate filter search reset

:umbrella: The latest upstream changes (presumably #86559) made this pull request unmergeable. Please resolve the merge conflicts.

GuillaumeGomez

comment created time in 41 minutes

Pull request review commentsyl20bnr/spacemacs

Adds function to run default shell in project root, with leader keys `SPC p $`

 Some advanced configuration is setup for =eshell= in this layer:  * Key bindings -| Key binding   | Description                                                |-|---------------+------------------------------------------------------------|-| ~SPC '​~       | Open, close or go to the default shell                     |-| ~SPC "​~       | Open external terminal emulator in current directory       |-| ~SPC p '​~     | Open a shell in the project's root                         |-| ~SPC p "​~     | Open external terminal emulator in project root            |-| ~SPC a t s e~ | Open, close or go to an =eshell=                           |-| ~SPC a t s i~ | Open, close or go to a =shell=                             |-| ~SPC a t s m~ | Open, close or go to a =multi-term=                        |-| ~SPC a t s t~ | Open, close or go to a =ansi-term=                         |-| ~SPC a t s T~ | Open, close or go to a =term=                              |-| ~TAB~         | browse completion with =helm=                              |-| ~SPC m H~     | browse history with =helm= (works in =eshell= and =shell=) |-| ~SPC a t s v~ | Open, close or go to a =vterm=                             |-| ~C-j~         | next item in history                                       |-| ~C-k~         | previous item in history                                   |+| Key binding   | Description                                                        |+|---------------+--------------------------------------------------------------------|+| ~SPC '​~       | Pop-up, close or visit the buffer for your default shell           |+| ~SPC "​~       | Open external terminal emulator in current directory               |+| ~SPC p '​~     | Pop-up your default shell in the project root                      |+| ~SPC p "​~     | Open external terminal emulator in project root                    |+| ~SPC a t s e~ | Pop-up, close or visit an =eshell= buffer                          |+| ~SPC a t s i~ | Pop-up, close or visit a =shell=  buffer                           |+| ~SPC a t s m~ | Pop-up, close or visit a =multi-term= buffer                       |+| ~SPC a t s t~ | Pop-up, close or visit an =ansi-term= buffer                       |+| ~SPC a t s T~ | Pop-up, close or visit a =term= buffer                             |+| ~SPC a t s v~ | Pop-up, close or visit a =vterm= buffer                            |+| ~SPC p $~     | Create a default shell buffer in the project root and switch to it |

I've updated the organization & descriptions in this table.

ryanprior

comment created time in 44 minutes

Pull request review commentsyl20bnr/spacemacs

Adds function to run default shell in project root, with leader keys `SPC p $`

   (defun spacemacs/projectile-shell-pop ()-  "Open a term buffer at projectile project root."+  "Pop-up a shell buffer at the project root.+Customize `shell-default-shell' to control what type of shell+buffer you create. This function will pop-up a full-width buffer+and move your focus to it; to switch the current buffer view, use+`spacemacs/projectile-shell'."   (interactive)   (let ((default-directory (projectile-project-root)))

I decided instead to use projectile-acquire-root, which prompts the user to specify a project root when they call spacemacs/projectile-pop-shell outside a project directory. This matches the behavior of projectile-run-shell and cohorts, so will hopefully be least surprising.

ryanprior

comment created time in 44 minutes

push eventmicrosoft/checkedc-clang

Mandeep Singh Grang

commit sha 72209524bb1747af0c563896002d2c11c3597c35

Reset killed bounds to declared bounds

view details

push time in an hour

pull request commentrust-lang/rust

Use `use_verbose` for `mir::Constant`

r? @varkor

(rust-highfive has picked a reviewer for you, use r? to override)

fee1-dead

comment created time in an hour

PR opened rust-lang/rust

Use `use_verbose` for `mir::Constant`

Fixes #79799.

+19 -60

0 comment

12 changed files

pr created time in an hour

pull request commentrust-lang/rust

extract code path shared between FromIterator and Extend

:umbrella: The latest upstream changes (presumably #86559) made this pull request unmergeable. Please resolve the merge conflicts.

the8472

comment created time in an hour

issue openedcoq/coq

coqdep is ignoring `From X` in imports

<!-- Thank you for reporting a bug to Coq! -->

Description of the problem

coqdep seems to not take into account the From prefix in imports leading to warnings like this:

*** Warning: in file theories/WildCat/Adjoint.v, 
    required library Core matches several files in path
    (found Core.v in theories/Metatheory, theories/WildCat, theories/Pointed, theories/Truncations, theories/Spaces/Int, theories/Spaces/Pos, theories/Spaces/No, theories/Categories/PseudonaturalTransformation, theories/Categories/NaturalTransformation, theories/Categories/NaturalTransformation/Composition, theories/Categories/CategoryOfSections, theories/Categories/SetCategory, theories/Categories/Limits, theories/Categories/InitialTerminalCategory, theories/Categories/Adjoint, theories/Categories/Adjoint/UniversalMorphisms, theories/Categories/Adjoint/Composition, theories/Categories/Adjoint/Functorial, theories/Categories/GroupoidCategory, theories/Categories/Structure, theories/Categories/Comma, theories/Categories/Grothendieck/ToSet, theories/Categories/Pseudofunctor, theories/Categories/Category, theories/Categories/Category/Sigma, theories/Categories/KanExtensions, theories/Categories/LaxComma, theories/Categories/Functor/Prod, theories/Categories/Functor, theories/Categories/Functor/Composition, theories/Categories/Functor/Composition/Functorial, theories/Categories/Functor/Pointwise, theories/Categories/Profunctor, theories/Categories/Cat and theories/Categories/FunctorCategory; used the latter)

In this case there is an import such as From WildCat Import Core. Coq doesn't complain about this but coqdep seems to find every other file named Core not in the WildCat folder.

<!-- If you can, it's helpful to provide self-contained example of some code that reproduces the bug. If not, a link to a larger example is also helpful. You can generate a shorter version of your program by following these instructions: https://github.com/coq/coq/wiki/Coqbot-minimize-feature. -->

Coq Version

8.15+alpha <!-- You can get this information by running coqtop -v. If relevant, please also include your operating system. -->

created time in an hour

issue commentrust-lang/rust

Allocator traits and std::heap

Excuse me, it is 1202 now, and is there a stablization plan for this?

nikomatsakis

comment created time in an hour

push eventrust-lang/rust

Deadbeef

commit sha 200fdaac777b8c0a4d5cf2be86f639c61358d518

Specify the kind of the item for E0121

view details

Deadbeef

commit sha 9b6c7ffa0601643aa1724d6552b276a7f4496aa0

Updated tests to reflect specified types in E0121

view details

Deadbeef

commit sha e66f241b80a91133c454cc02306f25269c03ea73

Update #83739 with type of the item specified

view details

LeSeulArtichaut

commit sha 4cd5affcf2d4a9c708b4f20d4f3afaaa3e3c5b2a

Fix handling of disambiguator suffixes for intra-doc links

view details

Guillaume Gomez

commit sha 3af9c9157e40197f404c95ddfda68114d9ef2adb

Update browser-ui-test version

view details

Guillaume Gomez

commit sha 5c9e10eec3b8a131c0b1f20ef21835a5a48a18bc

Add check to ensure that the line numbers are aligned with the source code

view details

LeSeulArtichaut

commit sha dc591e18e8597703caa6d84482ff59ba535f83d1

Accept `!{}` and `![]` as macro disambiguators

view details

LeSeulArtichaut

commit sha f387e8c207b47f0da4fcaa675460745ab325f3f8

Add test for macro disambiguators

view details

mbartlett21

commit sha 9db5c483ab50d70db6381f70c17711e2e472c0d3

Add destructuring example of E0508 This adds an example that destructures the array to move the value, instead of taking a reference or cloning.

view details

The8472

commit sha e0d70153cdee47421b0ec9220dc8fea65f243cfe

Add comments around code where ordering is important due for panic-safety Iterators contain arbitrary code which may panic. Unsafe code has to be careful to do its state updates at the right point between calls that may panic.

view details

Eric Huss

commit sha ac604ac945c7ee8ef0b9eb6566b30eee0ef7c448

Update books

view details

Dylan DPC

commit sha af9e5d1a14be84830008204627b489f94c4aad24

Rollup merge of #86223 - fee1-dead:better-E0121, r=petrochenkov Specify the kind of the item for E0121 Fixes #86005

view details

Dylan DPC

commit sha 6023ac2c8d10661f7a4f405edf795d956c927620

Rollup merge of #86521 - the8472:add-footgun-comments, r=RalfJung Add comments around code where ordering is important due for panic-safety Iterators contain arbitrary code which may panic. Unsafe code has to be careful to do its state updates at the right point between calls that may panic. As requested in https://github.com/rust-lang/rust/pull/86452#discussion_r655153948 r? `@RalfJung`

view details

Dylan DPC

commit sha f9ebf1edb51f257e73586d429800e3a1914b873a

Rollup merge of #86523 - LeSeulArtichaut:macros-disambiguators, r=jyn514 Improvements to intra-doc link macro disambiguators A few small improvements around macro disambiguators: - display the link text as it was entered: previously `[macro!()]` would be displayed without the parantheses (fixes #86309) - support `!{}` and `![]` as macro disambiguators (fixes #86310) r? `@jyn514` cc `@Manishearth` `@camelid`

view details

Dylan DPC

commit sha f19aad85a8736d13af677e50188f08cf900a1d03

Rollup merge of #86542 - GuillaumeGomez:line-numbers-aligned-with-content, r=jyn514 Line numbers aligned with content We had the issue a few times in the past where the source code pages' content wasn't aligned with the line numbers but completely below. This test will prevent this change to go unnoticed. The first commit comes from https://github.com/rust-lang/rust/pull/86541 so it needs it to be merged first. r? `@jsha`

view details

Dylan DPC

commit sha 68485b47976f8fdb4da11f202bd17d99c91cd2d3

Rollup merge of #86549 - mbartlett21:patch-1, r=GuillaumeGomez Add destructuring example of E0508 This adds an example that destructures the array to move the value, instead of taking a reference or cloning.

view details

Dylan DPC

commit sha bd04f4caffcc4a702e62a9a913a93541455eba0d

Rollup merge of #86557 - ehuss:update-books, r=ehuss Update books ## nomicon 10 commits in 55de6fa3c1f331774da19472c9ee57d2ae9eb039..b9ca313e687c991223e23e5520529815dc281205 2021-05-12 00:31:01 +0900 to 2021-06-22 12:02:20 -0400 - The #[repr(C)] attribute on the callback example is not necessary, since the type is not used in C. - Reorganize some chapters (rust-lang-nursery/nomicon#282) - Mention "extern types" on the opaque structs section (rust-lang-nursery/nomicon#273) - Clarify the conditions on the aliasing section (rust-lang-nursery/nomicon#272) - Upgrade to edition 2018 (rust-lang-nursery/nomicon#280) - Update some wording making reference to issues/RFCs (rust-lang-nursery/nomicon#271) - Some improvements on the "subtyping" chapter (rust-lang-nursery/nomicon#278) - Clarify casting between the same size fixed ints (rust-lang-nursery/nomicon#277) - Add a link to show why unused lifetimes on structs are forbidden (rust-lang-nursery/nomicon#276) - Fix small typo in the Drop Check chapter (rust-lang-nursery/nomicon#275) ## reference 8 commits in 8f598e2af6c25b4a7ee88ef6a8196d9b8ea50ca8..d9699fa8f3186440fdaadd703d63d8d42322c176 2021-06-01 19:00:46 +0100 to 2021-06-21 12:23:10 -0700 - Make explicit reference to scrutinee expression in grammar snippet (rust-lang-nursery/reference#1044) - Document sub-namespaces. (rust-lang-nursery/reference#1043) - Default all examples to 2018 edition. (rust-lang-nursery/reference#1041) - Minor update to macros. (rust-lang-nursery/reference#1048) - (rust-lang-nursery/reference#1049) - Add a note why the same size int casting is a no-op (rust-lang-nursery/reference#1046) - Add notes on `#[target_feature]` for wasm (rust-lang-nursery/reference#1047) - Make statement about variable visibility more precise (rust-lang-nursery/reference#1045) ## rustc-dev-guide 8 commits in c8da5bfd1c7c71d90ef1646f5e0a9f6609d5c78a..fe34beddb41dea5cb891032512a8d5b842b99696 2021-06-04 09:08:56 +0200 to 2021-06-21 21:50:12 +0200 - Update "Inference variables" section (rust-lang/rustc-dev-guide#1145) - Document how to run unit tests (rust-lang/rustc-dev-guide#1141) - We stopped using allow_internal_unstable a while ago (rust-lang/rustc-dev-guide#1142) - Change the feature used as an example of stabilizing lib features (rust-lang/rustc-dev-guide#1143) - We use HIR to do type inference, trait solving and type checking (rust-lang/rustc-dev-guide#1139) - Add suggested settings note for coc (rust-lang/rustc-dev-guide#1144) - move 7/8 to prose - Add a section on keeping things up to date in the git section ## edition-guide 2 commits in 302a115e8f71876dfc884aebb0ca5ccb02b8a962..c74b2a0d6bf55774cf15d69f05dfe05408b8f81a 2021-05-21 10:46:11 -0400 to 2021-06-14 10:48:27 -0700 - Fix lies. (rust-lang/edition-guide#244) - Add short summaries to all 2021 edition changes. (rust-lang/edition-guide#243) ## embedded-book 1 commits in 7349d173fa28a0bb834cf0264a05286620ef0923..cbec77fbd8eea0c13e390dd9eded1ae200e811d1 2021-05-25 13:59:05 +0000 to 2021-06-10 06:26:32 +0000 - Fix punctuation in c-with-rust.md (rust-embedded/book#294)

view details

bors

commit sha 574c9dd6f293784da0d89837f85abb1777a729ad

Auto merge of #86559 - Dylan-DPC:rollup-aixg3q5, r=Dylan-DPC Rollup of 6 pull requests Successful merges: - #86223 (Specify the kind of the item for E0121) - #86521 (Add comments around code where ordering is important due for panic-safety) - #86523 (Improvements to intra-doc link macro disambiguators) - #86542 (Line numbers aligned with content) - #86549 (Add destructuring example of E0508) - #86557 (Update books) Failed merges: - #86548 (Fix crate filter search reset) r? `@ghost` `@rustbot` modify labels: rollup

view details

push time in an hour

PR merged rust-lang/rust

Specify the kind of the item for E0121 S-waiting-on-bors

Fixes #86005

+455 -388

14 comments

34 changed files

fee1-dead

pr closed time in an hour

PR merged rust-lang/rust

Update books S-waiting-on-bors

nomicon

10 commits in 55de6fa3c1f331774da19472c9ee57d2ae9eb039..b9ca313e687c991223e23e5520529815dc281205 2021-05-12 00:31:01 +0900 to 2021-06-22 12:02:20 -0400

  • The #[repr(C)] attribute on the callback example is not necessary, since the type is not used in C.
  • Reorganize some chapters (rust-lang-nursery/nomicon#282)
  • Mention "extern types" on the opaque structs section (rust-lang-nursery/nomicon#273)
  • Clarify the conditions on the aliasing section (rust-lang-nursery/nomicon#272)
  • Upgrade to edition 2018 (rust-lang-nursery/nomicon#280)
  • Update some wording making reference to issues/RFCs (rust-lang-nursery/nomicon#271)
  • Some improvements on the "subtyping" chapter (rust-lang-nursery/nomicon#278)
  • Clarify casting between the same size fixed ints (rust-lang-nursery/nomicon#277)
  • Add a link to show why unused lifetimes on structs are forbidden (rust-lang-nursery/nomicon#276)
  • Fix small typo in the Drop Check chapter (rust-lang-nursery/nomicon#275)

reference

8 commits in 8f598e2af6c25b4a7ee88ef6a8196d9b8ea50ca8..d9699fa8f3186440fdaadd703d63d8d42322c176 2021-06-01 19:00:46 +0100 to 2021-06-21 12:23:10 -0700

  • Make explicit reference to scrutinee expression in grammar snippet (rust-lang-nursery/reference#1044)
  • Document sub-namespaces. (rust-lang-nursery/reference#1043)
  • Default all examples to 2018 edition. (rust-lang-nursery/reference#1041)
  • Minor update to macros. (rust-lang-nursery/reference#1048)
  • (rust-lang-nursery/reference#1049)
  • Add a note why the same size int casting is a no-op (rust-lang-nursery/reference#1046)
  • Add notes on #[target_feature] for wasm (rust-lang-nursery/reference#1047)
  • Make statement about variable visibility more precise (rust-lang-nursery/reference#1045)

rustc-dev-guide

8 commits in c8da5bfd1c7c71d90ef1646f5e0a9f6609d5c78a..fe34beddb41dea5cb891032512a8d5b842b99696 2021-06-04 09:08:56 +0200 to 2021-06-21 21:50:12 +0200

  • Update "Inference variables" section (rust-lang/rustc-dev-guide#1145)
  • Document how to run unit tests (rust-lang/rustc-dev-guide#1141)
  • We stopped using allow_internal_unstable a while ago (rust-lang/rustc-dev-guide#1142)
  • Change the feature used as an example of stabilizing lib features (rust-lang/rustc-dev-guide#1143)
  • We use HIR to do type inference, trait solving and type checking (rust-lang/rustc-dev-guide#1139)
  • Add suggested settings note for coc (rust-lang/rustc-dev-guide#1144)
  • move 7/8 to prose
  • Add a section on keeping things up to date in the git section

edition-guide

2 commits in 302a115e8f71876dfc884aebb0ca5ccb02b8a962..c74b2a0d6bf55774cf15d69f05dfe05408b8f81a 2021-05-21 10:46:11 -0400 to 2021-06-14 10:48:27 -0700

  • Fix lies. (rust-lang/edition-guide#244)
  • Add short summaries to all 2021 edition changes. (rust-lang/edition-guide#243)

embedded-book

1 commits in 7349d173fa28a0bb834cf0264a05286620ef0923..cbec77fbd8eea0c13e390dd9eded1ae200e811d1 2021-05-25 13:59:05 +0000 to 2021-06-10 06:26:32 +0000

  • Fix punctuation in c-with-rust.md (rust-embedded/book#294)
+5 -5

3 comments

5 changed files

ehuss

pr closed time in an hour

PR merged rust-lang/rust

Add destructuring example of E0508 S-waiting-on-bors

This adds an example that destructures the array to move the value, instead of taking a reference or cloning.

+13 -0

5 comments

1 changed file

mbartlett21

pr closed time in an hour

PR merged rust-lang/rust

Line numbers aligned with content S-waiting-on-bors T-rustdoc

We had the issue a few times in the past where the source code pages' content wasn't aligned with the line numbers but completely below. This test will prevent this change to go unnoticed.

The first commit comes from https://github.com/rust-lang/rust/pull/86541 so it needs it to be merged first.

r? @jsha

+42 -40

3 comments

9 changed files

GuillaumeGomez

pr closed time in an hour

PR merged rust-lang/rust

Improvements to intra-doc link macro disambiguators A-intra-doc-links S-waiting-on-bors T-rustdoc

A few small improvements around macro disambiguators:

  • display the link text as it was entered: previously [macro!()] would be displayed without the parantheses (fixes #86309)
  • support !{} and ![] as macro disambiguators (fixes #86310)

r? @jyn514 cc @Manishearth @camelid

+37 -27

6 comments

2 changed files

LeSeulArtichaut

pr closed time in an hour

PR merged rust-lang/rust

Rollup of 6 pull requests S-waiting-on-bors merged-by-bors rollup

Successful merges:

  • #86223 (Specify the kind of the item for E0121)
  • #86521 (Add comments around code where ordering is important due for panic-safety)
  • #86523 (Improvements to intra-doc link macro disambiguators)
  • #86542 (Line numbers aligned with content)
  • #86549 (Add destructuring example of E0508)
  • #86557 (Update books)

Failed merges:

  • #86548 (Fix crate filter search reset)

r? @ghost @rustbot modify labels: rollup <!-- homu-ignore:start --> Create a similar rollup <!-- homu-ignore:end -->

+569 -460

4 comments

55 changed files

Dylan-DPC

pr closed time in an hour

PR merged rust-lang/rust

Add comments around code where ordering is important due for panic-safety S-waiting-on-bors

Iterators contain arbitrary code which may panic. Unsafe code has to be careful to do its state updates at the right point between calls that may panic.

As requested in https://github.com/rust-lang/rust/pull/86452#discussion_r655153948

r? @RalfJung

+17 -0

2 comments

4 changed files

the8472

pr closed time in an hour

pull request commentrust-lang/rust

[beta] Bootstrap from stable

:hourglass: Testing commit b35a5cfdac4452fb2839ddc64ec5543be7123995 with merge 656ccd0f207bf0c2cf5204b1c260142e10ad24c4... <!-- homu: {"type":"BuildStarted","head_sha":"b35a5cfdac4452fb2839ddc64ec5543be7123995","merge_sha":"656ccd0f207bf0c2cf5204b1c260142e10ad24c4"} -->

Mark-Simulacrum

comment created time in an hour

issue closedrust-lang/rust

Intra-doc links don't accept all macro delimiters

Consider this code:

// This can be invoked with `foo!()`, `foo[]` or `foo{}`
#[macro_export] macro_rules! foo {
    () => {}
}

/// This is parsed as an intra-doc link: [foo!()]...
/// ...but those aren't: [foo![]] [foo!{}]
pub struct Foo;

I'm not sure if this is a deliberate decision or not. If it is, what's the rationale for not accepting [] and {}? cc @jyn514

closed time in an hour

LeSeulArtichaut

issue closedrust-lang/rust

Intra-doc link `foo!()` is rendered without the parentheses

Consider this code:

#[macro_export] macro_rules! foo {
    () => {}
}

/// [foo!()]
pub struct Foo;

In the generated docs, the link on the Foo page appears as foo!, with the correct link, but without the parentheses.

closed time in an hour

LeSeulArtichaut

issue closedrust-lang/rust

The meaning of an "item" in E0121 should be elaborated on

<!-- Thank you for filing a bug report! 🐛 Please provide a short summary of the bug, along with any information you feel relevant to replicating the bug. -->

I tried this code:

fn main() {
    const BAD: [_; 3] = [1u8, 2u8, 3u8];
}

I expected to see this happen: an error which explains why this doesn't work with const even though it does work with let, like what would happen with the code:

fn main() {
    const BAD = 1u8;
}

Instead, this happened: E0121, which doesn't explain that the problem is that const's need to be explicitly typed, but instead refers to an "item signature", which is an unexplained term of art. The explanation in rustc --explain E0121 does not elaborate on what an "item signature" means either.

Meta

<!-- If you're using the stable version of the compiler, you should also check if the bug also exists in the beta or nightly versions. -->

rustc --version --verbose: Occurs on 1.52.1 stable and on 1.54.0 nightly.

<!-- TRIAGEBOT_START -->

<!-- TRIAGEBOT_ASSIGN_START -->

<!-- TRIAGEBOT_ASSIGN_DATA_START$${"user":"fee1-dead"}$$TRIAGEBOT_ASSIGN_DATA_END -->

<!-- TRIAGEBOT_ASSIGN_END --> <!-- TRIAGEBOT_END -->

closed time in an hour

skmendez

pull request commentrust-lang/rust

Rollup of 6 pull requests

:sunny: Test successful - checks-actions Approved by: Dylan-DPC Pushing 574c9dd6f293784da0d89837f85abb1777a729ad to master... <!-- homu: {"type":"BuildCompleted","approved_by":"Dylan-DPC","base_ref":"master","builders":{"checks-actions":"https://github.com/rust-lang-ci/rust/runs/2890940733"},"merge_sha":"574c9dd6f293784da0d89837f85abb1777a729ad"} -->

Dylan-DPC

comment created time in an hour