profile
viewpoint
If you are wondering where the data of this site comes from, please visit https://api.github.com/users/tarzan/events. GitMemory does not store any data, but only uses NGINX to cache data for a period of time. The idea behind GitMemory is simply to give users a better reading experience.
Maarten Jacobs tarzan Defacto Groningen

DefactoSoftware/BearNecessities 19

Multiplayer bear game with Phoenix Live View

DefactoSoftware/timex 0

A complete date/time library for Elixir projects.

fatboypunk/Scriptie 0

De scriptie van mijn afstudeer stage bij Nidaros gemaakt in latex

JeroenHoekstra91/EaaS 0

Encryption as a Service

JeroenHoekstra91/NoteApp 0

App for making notes and saving them using Dropbox.

tarzan/active_model_serializers 0

ActiveModel::Serializer implementation and Rails hooks

tarzan/angular-quiz 0

AngularJS sample project

tarzan/angular-ui-switch 0

On/off switch button for AngularJS

tarzan/apartment 0

Database multi-tenancy for Rack (and Rails) applications

pull request commentdiscourse/onebox

let the vimeo engine use the returned oembed html instead of constructing an own iframe

Way to reproduce:

  1. upload a video to Vimeo
  2. set it to private
  3. whitelist a domain which is allowed to play the video (don't know if this option is offered on a free account)
  4. try a Onebox.preview(URL).to_s and embed the HTML on a page on this whitelisted domain
tarzan

comment created time in 2 hours

PR opened discourse/onebox

let the vimeo engine use the returned oembed html instead of constructing an own iframe

I do not know why, but instead of using the HTML returned by Vimeo's OEmbed API response, Onebox constructs it's own HTML. Resulting in some videos to be rendered as this: image

The OEmbed API does return correct HTML, however, so I prefer to use that instead.

(I'm sorry but as the video, that was shown as such, is private I can not share the URI for it)

+7 -5

0 comment

1 changed file

pr created time in 6 hours

create barnchtarzan/onebox

branch : fix-vimeo

created branch time in 7 hours

push eventtarzan/onebox

Robin Ward

commit sha bdcb5be95ee870520cab65a1f8b3cecae5c14204

FIX: Don't raise DownloadTooLarge to the outside world

view details

Vinoth Kannan

commit sha e444918b170a4047dbf7593b02a3a21cdcf3c00c

fix: normalizing % symbol in url gives broken URL

view details

Régis Hanol

commit sha 67a165a14b4bde573691138d383a15b74ab60d36

Merge pull request #338 from vinothkannans/fix-normalize fix: normalizing % symbol in url gives broken URL

view details

Gleb Mazovetskiy

commit sha b0b769cc5f301a9578996ef591a9fb11ef3271ee

Update nokogiri dep from ~> 1.6.6 to ~> 1.7.0

view details

Régis Hanol

commit sha a3c77c21815b6f8a07caac2aedc2f6d490682ff4

Merge pull request #339 from glebm/patch-1 Update nokogiri dep from ~> 1.6.6 to ~> 1.7.0

view details

Gleb Mazovetskiy

commit sha 985bb646a204eb6abcaf769f2112a0ea48fe4cd5

Fix Amazon onebox data serialization Nokogiri::XML::Attr cannot be serialized, so `image` must return a string for compatibility with caches that require serialization

view details

Régis Hanol

commit sha 96dbcab073d7e32178f2b1fa17a3c11b354d9888

Merge pull request #341 from glebm/patch-3 Fix Amazon onebox data serialization

view details

Gleb Mazovetskiy

commit sha e4186b8fa762b7f94cdf4c14061863f3bb33af6a

Bump Moneta dep to v1.0

view details

Régis Hanol

commit sha ca57d487a0dfdd07d8abce251af8c6acc306ee87

Merge pull request #343 from glebm/moneta-version Bump Moneta dep to v1.0

view details

Gleb Mazovetskiy

commit sha 26182c3b9d1ac9d2fe793fdcaf0cf66951ae7de3

Do not lock MINOR in runtime deps Semver means MINOR updates do not introduce backwards incompatibilities, so we should not lock MINOR.

view details

Régis Hanol

commit sha 4ea6493429db316278349c29828bba1ade02384c

Merge pull request #342 from glebm/semver-deps Do not lock MINOR in runtime deps

view details

Régis Hanol

commit sha 238cea90d93d0bc96d8abcf4ff0a76cd3e3b81f9

bump version

view details

Bianca Nenciu

commit sha 40d8e20667d5238668464402ff4e66fbe47f23e9

Added WikiMedia OneBox thumbnails.

view details

Régis Hanol

commit sha e843b413ba02f54f230d8af797ffe3f899b597f6

Merge pull request #344 from nbianca/wikimedia_onebox Added WikiMedia OneBox thumbnails.

view details

Gleb Mazovetskiy

commit sha 407fd0b8d6d41956e2400efc1918ace255aecd37

Security: sandbox iframes, add rel to abs anchors This is a pre-emptive measure: there is not an actual vulnerability that I am aware of. 1. Add a sandbox to all `<iframe>`s. The sandbox is very permissive, but still better than no sandbox. 2. Add `rel="noopener nofollow"`, the former is to prevent a certain kind of phishing attacks, and the latter discourage spammers. Also, removed the excessive `merge` calls. `Sanitize::Config.merge` is a deep merge already.

view details

Bianca Nenciu

commit sha 520d9befc2dd34304abcdfb2a408362e83fd9f69

Renamed file to match others.

view details

Régis Hanol

commit sha b9b7466ac4a6bfa71ccec7f459b7b92b563ea5db

Merge pull request #346 from nbianca/wikimedia_onebox Renamed file to match others.

view details

Bianca Nenciu

commit sha 0c1e51e04358a8314413a277eefc0ce06d19d974

Refactored Gfycat Onebox module. Improved video quality by using different source. Refactored module. Added tests.

view details

David Taylor

commit sha b3163e0cf93fb3195c84c11d3eee2aaaab934343

Allow optional trailing slash on twitter URLs, and add support for video/photo urls Video/photo links do not need to be treated differently from standard links, since all photo/video links have their "canonical URL" set to the the raw "status" URL, so all we need to do is match them to the existing onebox.

view details

Régis Hanol

commit sha 2d34d0cd696360feaa3032c70f208a6f7d438d6d

Merge pull request #345 from nbianca/gfycat_onebox Refactored Gfycat Onebox module.

view details

push time in 7 hours

startedtinyproxy/tinyproxy

started time in 25 days

PullRequestReviewEvent

startedLukeCroteau/mtg_arena_wildcard_files

started time in a month

push eventtarzan/sublime-text-elixir-tests

Andreas Hellwig

commit sha 9db5681cb31252cdcf417ba86707f0d1d65b13c0

Remove Reference to ruby

view details

Maarten Jacobs

commit sha e133783be7aa06ef43a2225ce9e491ca1b61a05d

Merge pull request #5 from A5308Y/master Remove Reference to ruby

view details

push time in a month

PR merged tarzan/sublime-text-elixir-tests

Remove Reference to ruby

I think it's pretty self-explanatory :-)

+2 -2

1 comment

1 changed file

A5308Y

pr closed time in a month

pull request commenttarzan/sublime-text-elixir-tests

Remove Reference to ruby

Thx!

A5308Y

comment created time in a month

startedtoothbrush/debounce-mac

started time in 2 months