profile
viewpoint
Tarik Hamilton tarikhamilton Masonite Saint Petersburg, Florida https://tarikhamilton.com I love all aspects of web development. Things I like/use the most: Laravel, Vue.js, WordPress

tarikhamilton/styling-animating-vue-slides 2

Presentation on styling and animation in Vue.js 2

tarikhamilton/calc-drills 1

A Meteor JS app for studying calculus and trig identities.

tarikhamilton/SpaceMySpace 1

Give a web page a living, breathing, dynamically generated, space background.

tarikhamilton/camera-transfer 0

My personal camera transfer scripts.

tarikhamilton/core-js 0

Standard Library

tarikhamilton/docs 0

The FeathersJS documentation, powered by GitBook

tarikhamilton/dotfiles 0

My Vim settings

tarikhamilton/enzyme 0

JavaScript Testing utilities for React

tarikhamilton/equal-height-columns 0

Give your (Bootstrap) columns equal heights with JavaScript

tarikhamilton/feathers-vue-boilerplate 0

Feathers 3 and Vue.js 2 in a single project.

delete branch masonitedoors/MDL

delete branch : MXP-818-file-manager-icons

delete time in 18 days

push eventmasonitedoors/MDL

willyrk1

commit sha 253a78f50d028434fc8b373ef65d645dee5b7707

MXP-818 adjacent: Add file manager home and sidebar icons. Create ch… (#111)

view details

push time in 18 days

push eventmasonitedoors/MDL

Tarik Hamilton

commit sha 5bff20e932acc7325715cf156a6c426bfd73e109

Publish - @masonite/svg-icons@1.3.0

view details

push time in 20 days

created tagmasonitedoors/MDL

tag@masonite/svg-icons@1.3.0

Masonite Design Language components

created time in 20 days

push eventmasonitedoors/MDL

Tarik Hamilton

commit sha 32aaf278c203c7d3f022ab38e280908c7f8e66cc

Update micons submodule

view details

push time in 20 days

push eventmasonitedoors/MDL

willyrk1

commit sha 5186f8cdbababcf281829b7f37cd41e28d5f7e69

Add several new icons. Also fix issue where a file name with dash an… (#110)

view details

push time in 20 days

delete branch masonitedoors/MDL

delete branch : new-icons-plus-build-fix

delete time in 20 days

PR merged masonitedoors/MDL

Reviewers
Add several new icons. Also fix issue where a file name with dash an…

…d a capital letter result in bad export names (e.g., doc-with-Icon.svg).

Before submitting a pull request, please make sure the following is done:

  1. Make sure your updates are reflected in both the React and HTML side of MDL.
  2. If you've fixed a bug or added code that should be tested, add tests!
  3. Make sure the test suite passes (npm test).
+71 -1

0 comment

2 changed files

willyrk1

pr closed time in 20 days

PR closed masonitedoors/MDL

Reviewers
Add zeplin connected components to react ui enhancement

Let's check this out!!

+283 -6

1 comment

7 changed files

tarikhamilton

pr closed time in 24 days

pull request commentmasonitedoors/MDL

Add zeplin connected components to react ui

I misconstrued some things. Connected components aren't intended to be used in this way (to be imported by another library). Taking this PR down, but keeping the branch, json changes are good.

tarikhamilton

comment created time in 24 days

push eventmasonitedoors/MDL

Tarik Hamilton

commit sha 4012fce5a2074f7c53c5c67f906fcf1b0785ecb3

Add zeplinConnectedComponents as export to external-ui-react

view details

push time in 24 days

push eventmasonitedoors/MDL

Tarik Hamilton

commit sha 79263745d667b43ab586fa73bb8ff1dcc30fa0be

Add zeplinConnectedComponents as export to external-ui-react

view details

push time in 24 days

PR opened masonitedoors/MDL

Reviewers
Add zeplin connected components to react ui enhancement

Let's check this out!!

+293 -6

0 comment

7 changed files

pr created time in 24 days

create barnchmasonitedoors/MDL

branch : add-zeplinConnectedComponents-to-ReactUI

created branch time in 24 days

startedcasmith/todoist-habitica-sync

started time in a month

push eventmasonitedoors/MDL

Tarik Hamilton

commit sha 11aa8e6bbe6189f3817f667e1329573a3568aa7b

Publish - @masonite/external-ui-react@2.21.0 - @masonite/svg-icons@1.2.0

view details

push time in a month

created tagmasonitedoors/MDL

tag@masonite/external-ui-react@2.21.0

Masonite Design Language components

created time in a month

created tagmasonitedoors/MDL

tag@masonite/svg-icons@1.2.0

Masonite Design Language components

created time in a month

push eventmasonitedoors/MDL

Tarik Hamilton

commit sha ec543304918cf337e22e87459d1085c7d7542fb7

Add Zeplin Connected Components config

view details

Tarik Hamilton

commit sha 3c30b25aaf8f159f6baaae20cd429392efe9afae

Merge branch 'master' of github.com:masonitedoors/MDL

view details

Tarik Hamilton

commit sha 1e4d55bcab84e9a990e5ac437641729c08856229

Update changelog for 2.21

view details

push time in a month

push eventmasonitedoors/MDL

Tarik Hamilton

commit sha 580d6e59031aedd2de64b550c171f8dca7d6a041

Add the cli packages

view details

push time in a month

create barnchmasonitedoors/MDL

branch : connected-components

created branch time in a month

startedzeplin/connected-components-docs

started time in a month

issue commentelegantthemes/create-divi-extension

.JSX, JS, .CSS files not updated after yarn start

I was having this issue as well and I solved it after many hours, so I hope this helps someone.

I'm using macOS 10.14 and serving WP using Laravel Valet. npm run build is fine. npm start starts fine, watches successfully as it says compiling whenever I save changes, but the files themselves do not update.

This was two problems rolled into one: 1.) I needed my ${MY_EXTENSION_PREFIX}_DEBUG to be set to true. 2.) I needed to override my script paths on my DiviExtension class. (link to code)

The possible source of the issue was posted in this issue, but may have been missed.

@lots0logs answers:

The debug constant is automatically set in wp-config.php when you run yarn start. When you exit out of yarn start, the debug constant is removed.

I added define( 'MYPREFIX_DEBUG', true ) to my Divi plugin's main file and it fixed the paths. I think some people may have permission issues or maybe what is setup only well if you're using the Divi Docker stuff. I'm not sure if you need to add it to wp-config, but it was more convenient for me to add it here and it works. I may make a Node script to add/remove the constant until the real fix is figured out.

So, @MarieComet, I see you had no errors and your script paths are to the built files. You probably have this same issue as me. Try the solution out.

MarieComet

comment created time in a month

delete branch masonitedoors/MDL

delete branch : add-cross-env-at-lower-levels

delete time in a month

push eventmasonitedoors/MDL

willyrk1

commit sha a5525b5b95c557601975755fa0ba7195a470b92c

Apply cross-env to lower-level package.jsons to fix Windows-spec… (#106) * Apply cross-env to lower-level package.jsons to fix Windows-specific script errors. * Turns out you don't need to actually install cross-env at every level, just use it. Co-authored-by: Bill Knight <BKnight@Masonite.com>

view details

push time in a month

PR merged masonitedoors/MDL

Reviewers
Apply cross-env to lower-level package.jsons to fix Windows-specific …

…script errors.

Before submitting a pull request, please make sure the following is done:

  1. Make sure your updates are reflected in both the React and HTML side of MDL.
  2. If you've fixed a bug or added code that should be tested, add tests!
  3. Make sure the test suite passes (npm test).
+2 -2

1 comment

2 changed files

willyrk1

pr closed time in a month

startedWordPress/gutenberg

started time in 2 months

push eventmasonitedoors/MDL

Tarik Hamilton

commit sha afb2ba43f9a43461eb3b87ba40a0df3e11639ea7

Publish - @masonite/external-ui-react@2.20.0

view details

push time in 2 months

created tagmasonitedoors/MDL

tag@masonite/external-ui-react@2.20.0

Masonite Design Language components

created time in 2 months

push eventmasonitedoors/MDL

Tarik Hamilton

commit sha 87bd54a9f3327c71f0baea76c1ddbaad995fdb31

Update CHANGELOG

view details

push time in 2 months

delete branch masonitedoors/MDL

delete branch : OverflowMenu-dark-variant

delete time in 2 months

push eventmasonitedoors/MDL

Tarik Hamilton

commit sha e893abe055b6bf39da361fcd52dde2606f13adab

Add dark variant to OverflowMenu icon

view details

Tarik Hamilton

commit sha ff19f29ac058e20089c36cf1b1761c5512d2f269

Add left position 0 to ensure left alignment I only noticed this in Storybook due to their default padding around the body in the iframe

view details

Tarik Hamilton

commit sha c630bb51c459121c6d8b4b179b67d67c43891b86

Merge branch 'master' into OverflowMenu-dark-variant

view details

Tarik Hamilton

commit sha d8ca6054e72136918b641d43248259d885a45648

Merge pull request #103 from masonitedoors/OverflowMenu-dark-variant Add dark variant to OverflowMenu icon

view details

push time in 2 months

PR merged masonitedoors/MDL

Reviewers
Add dark variant to OverflowMenu icon component enhancement

Before submitting a pull request, please make sure the following is done:

  1. Make sure your updates are reflected in both the React and HTML side of MDL.
  2. If you've fixed a bug or added code that should be tested, add tests!
  3. Make sure the test suite passes (npm test).
+61 -28

1 comment

4 changed files

tarikhamilton

pr closed time in 2 months

push eventmasonitedoors/MDL

Tarik Hamilton

commit sha 740769270d8ae41805e826b31d157b96feee3da8

Update SidebarNav The ideal setup should've been a relatively positioned. Also, made props to hook into into the layoutWrapper and contentWrapper. These are needed, if you want to change some styles, such as in the Header Above Example

view details

Tarik Hamilton

commit sha 1fff185831a18e21204b82dd546a48ee74f53c9d

Merge pull request #102 from masonitedoors/SidebarNav-update Update SidebarNav

view details

Tarik Hamilton

commit sha 436483ef84d51f5e9267cb253c8ca77f3d56a436

Update for deploy

view details

Tarik Hamilton

commit sha f69af287340bcedd207c922170837a43c809c25c

Publish - @masonite/external-ui-react@2.19.0

view details

Tarik Hamilton

commit sha c630bb51c459121c6d8b4b179b67d67c43891b86

Merge branch 'master' into OverflowMenu-dark-variant

view details

push time in 3 months

Pull request review commentmasonitedoors/MDL

Add dark variant to OverflowMenu icon

 $submenu-width: 180px; .sidebar {   position: fixed;   top: 0;+  left: 0;

yea

tarikhamilton

comment created time in 3 months

startedjkroso/flowtype

started time in 3 months

created tagmasonitedoors/MDL

tag@masonite/external-ui-react@2.19.0

Masonite Design Language components

created time in 3 months

push eventmasonitedoors/MDL

Tarik Hamilton

commit sha f69af287340bcedd207c922170837a43c809c25c

Publish - @masonite/external-ui-react@2.19.0

view details

push time in 3 months

push eventmasonitedoors/MDL

Tarik Hamilton

commit sha 436483ef84d51f5e9267cb253c8ca77f3d56a436

Update for deploy

view details

push time in 3 months

Pull request review commentmasonitedoors/MDL

Add dark variant to OverflowMenu icon

 export class OverflowMenu extends Component {    render() {     const { displayOverflowMenuActions } = this.state-    const { children } = this.props+    const { children, variant } = this.props     return (-      <div className={cx('overflow-menu')}>+      <div+        className={cx('overflow-menu', {+          'overflow-menu--dark': ['secondary', 'dark'].includes(variant),

We do want the menu to be dark too, but it isn't designed yet. I was waiting for Simon to do it, but we can always update the library incrementally.

tarikhamilton

comment created time in 3 months

Pull request review commentmasonitedoors/MDL

Add dark variant to OverflowMenu icon

 export class OverflowMenu extends Component {    render() {     const { displayOverflowMenuActions } = this.state-    const { children } = this.props+    const { children, variant } = this.props     return (-      <div className={cx('overflow-menu')}>+      <div+        className={cx('overflow-menu', {+          'overflow-menu--dark': ['secondary', 'dark'].includes(variant),

I don't think it is totally necessary.

tarikhamilton

comment created time in 3 months

Pull request review commentmasonitedoors/MDL

Add dark variant to OverflowMenu icon

 $submenu-width: 180px; .sidebar {   position: fixed;   top: 0;+  left: 0;

It is needed. If there is padding in the wrapper (aka Storybook), if left isn't specified, it'll be lined up with the padding, creating a little gap.

tarikhamilton

comment created time in 3 months

push eventmasonitedoors/MDL

push time in 3 months

create barnchmasonitedoors/MDL

branch : SidebarNav-update

created branch time in 3 months

Pull request review commentmasonitedoors/MDL

Update SidebarNav

 import React from 'react' import { storiesOf } from '@storybook/react'-import { withKnobs } from '@storybook/addon-knobs'+import { withKnobs, boolean } from '@storybook/addon-knobs' import {-  mEntry, mInterior, mExport, mContact, mSignout,+  mEntry, mExport, mContact, mSignout, } from '@masonite/svg-icons' import logo from 'images/masonite-icon.png' import SidebarNavLayout from './react' import Readme from './react.README.md'  const addKey = item => ({ ...item, key: item.label }) -storiesOf('SidebarNav', module)-  .addParameters({ readme: { sidebar: Readme } })-  .addDecorator(withKnobs)-  .add('Default', () => {-    const onClick = () => console.log('Mock onClick call')-    const location = {-      pathname: '/glass/inventory',-    }-    const menuItems = [-      {-        label: 'Exterior Doors',-        icon: <span dangerouslySetInnerHTML={{ __html: mEntry }} />,-        active: true,-        href: '/',-        items: [-          {-            label: 'Menu Item 1',-            href: '/menu/1',-            onClick,-          },-          {-            label: 'Menu Item 2',-            href: '/menu/2',-            onClick,-          },-        ].map(addKey),-      },+const combatStorybookPaddingStyle = {+  position: 'fixed',+  top: 0,+  left: 0,+}++const Content = () => (+  <div style={{ padding: 20 }}>+    <h1>Page</h1>

Updating.

tarikhamilton

comment created time in 3 months

Pull request review commentmasonitedoors/MDL

Update SidebarNav

 import React from 'react' import { storiesOf } from '@storybook/react'-import { withKnobs } from '@storybook/addon-knobs'+import { withKnobs, boolean } from '@storybook/addon-knobs' import {-  mEntry, mInterior, mExport, mContact, mSignout,+  mEntry, mExport, mContact, mSignout, } from '@masonite/svg-icons' import logo from 'images/masonite-icon.png' import SidebarNavLayout from './react' import Readme from './react.README.md'  const addKey = item => ({ ...item, key: item.label }) -storiesOf('SidebarNav', module)-  .addParameters({ readme: { sidebar: Readme } })-  .addDecorator(withKnobs)-  .add('Default', () => {-    const onClick = () => console.log('Mock onClick call')-    const location = {-      pathname: '/glass/inventory',-    }-    const menuItems = [-      {-        label: 'Exterior Doors',-        icon: <span dangerouslySetInnerHTML={{ __html: mEntry }} />,-        active: true,-        href: '/',-        items: [-          {-            label: 'Menu Item 1',-            href: '/menu/1',-            onClick,-          },-          {-            label: 'Menu Item 2',-            href: '/menu/2',-            onClick,-          },-        ].map(addKey),-      },+const combatStorybookPaddingStyle = {+  position: 'fixed',+  top: 0,+  left: 0,+}++const Content = () => (+  <div style={{ padding: 20 }}>+    <h1>Page</h1>+    <p>+      Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod tempor incididunt ut+      labore et dolore magna aliqua. Ut enim ad minim veniam, quis nostrud exercitation ullamco+      laboris nisi ut aliquip ex ea commodo consequat. Duis aute irure dolor in reprehenderit in+      voluptate velit esse cillum dolore eu fugiat nulla pariatur. Excepteur sint occaecat cupidatat+      non proident, sunt in culpa qui officia deserunt mollit anim id est laborum.+    </p>+    <p>+      Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod tempor incididunt ut+      labore et dolore magna aliqua. Ut enim ad minim veniam, quis nostrud exercitation ullamco+      laboris nisi ut aliquip ex ea commodo consequat. Duis aute irure dolor in reprehenderit in+      voluptate velit esse cillum dolore eu fugiat nulla pariatur. Excepteur sint occaecat cupidatat+      non proident, sunt in culpa qui officia deserunt mollit anim id est laborum.+    </p>+    <p>+      Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod tempor incididunt ut+      labore et dolore magna aliqua. Ut enim ad minim veniam, quis nostrud exercitation ullamco+      laboris nisi ut aliquip ex ea commodo consequat. Duis aute irure dolor in reprehenderit in+      voluptate velit esse cillum dolore eu fugiat nulla pariatur. Excepteur sint occaecat cupidatat+      non proident, sunt in culpa qui officia deserunt mollit anim id est laborum.+    </p>+    <p>+      Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod tempor incididunt ut+      labore et dolore magna aliqua. Ut enim ad minim veniam, quis nostrud exercitation ullamco+      laboris nisi ut aliquip ex ea commodo consequat. Duis aute irure dolor in reprehenderit in+      voluptate velit esse cillum dolore eu fugiat nulla pariatur. Excepteur sint occaecat cupidatat+      non proident, sunt in culpa qui officia deserunt mollit anim id est laborum.+    </p>+    <p>+      Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod tempor incididunt ut+      labore et dolore magna aliqua. Ut enim ad minim veniam, quis nostrud exercitation ullamco+      laboris nisi ut aliquip ex ea commodo consequat. Duis aute irure dolor in reprehenderit in+      voluptate velit esse cillum dolore eu fugiat nulla pariatur. Excepteur sint occaecat cupidatat+      non proident, sunt in culpa qui officia deserunt mollit anim id est laborum.+    </p>+    <p>+      Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod tempor incididunt ut+      labore et dolore magna aliqua. Ut enim ad minim veniam, quis nostrud exercitation ullamco+      laboris nisi ut aliquip ex ea commodo consequat. Duis aute irure dolor in reprehenderit in+      voluptate velit esse cillum dolore eu fugiat nulla pariatur. Excepteur sint occaecat cupidatat+      non proident, sunt in culpa qui officia deserunt mollit anim id est laborum.+    </p>+    <p>+      Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod tempor incididunt ut+      labore et dolore magna aliqua. Ut enim ad minim veniam, quis nostrud exercitation ullamco+      laboris nisi ut aliquip ex ea commodo consequat. Duis aute irure dolor in reprehenderit in+      voluptate velit esse cillum dolore eu fugiat nulla pariatur. Excepteur sint occaecat cupidatat+      non proident, sunt in culpa qui officia deserunt mollit anim id est laborum.+    </p>+    <p>+      Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod tempor incididunt ut+      labore et dolore magna aliqua. Ut enim ad minim veniam, quis nostrud exercitation ullamco+      laboris nisi ut aliquip ex ea commodo consequat. Duis aute irure dolor in reprehenderit in+      voluptate velit esse cillum dolore eu fugiat nulla pariatur. Excepteur sint occaecat cupidatat+      non proident, sunt in culpa qui officia deserunt mollit anim id est laborum.+    </p>+    <p>+      Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod tempor incididunt ut+      labore et dolore magna aliqua. Ut enim ad minim veniam, quis nostrud exercitation ullamco+      laboris nisi ut aliquip ex ea commodo consequat. Duis aute irure dolor in reprehenderit in+      voluptate velit esse cillum dolore eu fugiat nulla pariatur. Excepteur sint occaecat cupidatat+      non proident, sunt in culpa qui officia deserunt mollit anim id est laborum.+    </p>+  </div>+)++const menuItems = [+  {+    label: 'Exterior Doors',+    icon: <span dangerouslySetInnerHTML={{ __html: mEntry }} />,+    active: true,+    href: '/',+    items: [       {-        label: 'External Link',-        icon: <span dangerouslySetInnerHTML={{ __html: mExport }} />,-        href: '#',+        label: 'Menu Item 1',+        href: '/menu/1',+        onClick,       },       {-        label: 'Contact',-        icon: <span dangerouslySetInnerHTML={{ __html: mContact }} />,-        href: '#',+        label: 'Menu Item 2',+        href: '/menu/2',+        onClick,       },-    ].map(addKey)+    ].map(addKey),+  },+  {+    label: 'External Link',+    icon: <span dangerouslySetInnerHTML={{ __html: mExport }} />,+    href: '#',+  },+  {+    label: 'Contact',+    icon: <span dangerouslySetInnerHTML={{ __html: mContact }} />,+    href: '#',+  },+].map(addKey) -    const bottomMenuItems = [-      {-        label: 'Log Out',-        icon: <span dangerouslySetInnerHTML={{ __html: mSignout }} />,-      },-    ].map(addKey)+const bottomMenuItems = [+  {+    label: 'Log Out',+    icon: <span dangerouslySetInnerHTML={{ __html: mSignout }} />,+  },+].map(addKey)++const Logo = (+  <a href="/" tabIndex="0">

The logo prop accepts a component. It isn't an automatic link, so it needs to be provided, if it is a link.

tarikhamilton

comment created time in 3 months

delete branch masonitedoors/MDL

delete branch : SidebarNav-update

delete time in 3 months

push eventmasonitedoors/MDL

Tarik Hamilton

commit sha 740769270d8ae41805e826b31d157b96feee3da8

Update SidebarNav The ideal setup should've been a relatively positioned. Also, made props to hook into into the layoutWrapper and contentWrapper. These are needed, if you want to change some styles, such as in the Header Above Example

view details

Tarik Hamilton

commit sha 1fff185831a18e21204b82dd546a48ee74f53c9d

Merge pull request #102 from masonitedoors/SidebarNav-update Update SidebarNav

view details

push time in 3 months

PR merged masonitedoors/MDL

Reviewers
Update SidebarNav component enhancement

The ideal setup should've been a relatively positioned.

Also, made props to hook into into the layoutWrapper and contentWrapper.

These are needed, if you want to change some styles, such as in the Header Above Example

Before submitting a pull request, please make sure the following is done:

  1. Make sure your updates are reflected in both the React and HTML side of MDL.
  2. If you've fixed a bug or added code that should be tested, add tests!
  3. Make sure the test suite passes (npm test).
+183 -134

0 comment

3 changed files

tarikhamilton

pr closed time in 3 months

push eventmasonitedoors/MDL

Tarik Hamilton

commit sha ff19f29ac058e20089c36cf1b1761c5512d2f269

Add left position 0 to ensure left alignment I only noticed this in Storybook due to their default padding around the body in the iframe

view details

push time in 3 months

PR opened masonitedoors/MDL

Reviewers
Add dark variant to OverflowMenu icon component enhancement

Before submitting a pull request, please make sure the following is done:

  1. Make sure your updates are reflected in both the React and HTML side of MDL.
  2. If you've fixed a bug or added code that should be tested, add tests!
  3. Make sure the test suite passes (npm test).
+60 -28

0 comment

3 changed files

pr created time in 3 months

push eventmasonitedoors/MDL

push time in 3 months

PR opened masonitedoors/MDL

Reviewers
Update SidebarNav component enhancement

The ideal setup should've been a relatively positioned.

Also, made props to hook into into the layoutWrapper and contentWrapper.

These are needed, if you want to change some styles, such as in the Header Above Example

Before submitting a pull request, please make sure the following is done:

  1. Make sure your updates are reflected in both the React and HTML side of MDL.
  2. If you've fixed a bug or added code that should be tested, add tests!
  3. Make sure the test suite passes (npm test).
+183 -134

0 comment

3 changed files

pr created time in 3 months

create barnchmasonitedoors/MDL

branch : SidebarNav-update

created branch time in 3 months

create barnchmasonitedoors/MDL

branch : OverflowMenu-dark-variant

created branch time in 3 months

more