profile
viewpoint
Jimmy Jia taion @4Catalyzer New York http://fashionablenonsense.com/ "Whatsoever doeth Him most honour, will certainly do us most good."

reactjs/react-transition-group 7379

An easy way to perform animations when a React component enters or leaves the DOM

goatslacker/alt 3471

Isomorphic flux implementation

react-restart/hooks 90

A set of utility and general-purpose React hooks.

knowbody/react-router-docs 56

Rewrite of the React Router docs - work in progress

reactjs/rackt-codemod 41

Codemod scripts for Rackt libraries

taion/cls-isoflux-marty 1

[Deprecated] Marty bindings for cls-isoflux

taion/airbnb-javascript 0

JavaScript Style Guide

pull request comment4Catalyzer/webpack-plugin-unpolyfill

chore(deps): bump npm from 6.13.6 to 6.14.6

@dependabot squash and merge

dependabot[bot]

comment created time in 16 hours

pull request comment4Catalyzer/graphql-node-resource

chore(deps): bump npm-registry-fetch from 4.0.3 to 4.0.5

@dependabot squash and merge

dependabot[bot]

comment created time in 17 hours

pull request commentreactjs/react-transition-group

build(deps): bump npm-registry-fetch from 4.0.3 to 4.0.5

@dependabot squash and merge

dependabot[bot]

comment created time in 17 hours

pull request comment4Catalyzer/graphql-subscription-server

chore(deps): bump npm-registry-fetch from 4.0.2 to 4.0.5

@dependabot squash and merge

dependabot[bot]

comment created time in 17 hours

pull request commentreactjs/react-transition-group

build(deps): bump npm from 6.14.4 to 6.14.6

@dependabot squash and merge

dependabot[bot]

comment created time in 17 hours

pull request comment4Catalyzer/graphql-subscription-server

chore(deps): bump npm from 6.13.6 to 6.14.6

@dependabot squash and merge

dependabot[bot]

comment created time in 17 hours

pull request comment4Catalyzer/graphql-node-resource

chore(deps): bump npm from 6.14.4 to 6.14.6

@dependabot squash and merge

dependabot[bot]

comment created time in 17 hours

pull request commentreact-restart/context

chore(deps): bump npm from 6.13.7 to 6.14.6

@dependabot squash and merge

dependabot[bot]

comment created time in 17 hours

pull request commentreact-restart/context

chore(deps): bump npm-registry-fetch from 4.0.3 to 4.0.5

@dependabot squash and merge

dependabot[bot]

comment created time in 17 hours

issue comment4Catalyzer/found

Shallow routing?

We don't necessarily have an out-of-the-box way to do this. You can sort of implement this yourself, though. Two options:

  • If you're not changing the URL involved, in your getData calls, just check your cache to see if the data you need are already present; if so, just serve those data instead of refetching (this is what Found Relay does by default, which is why I asked)
  • When pushing/replacing to a new location, add e.g. shallow: true to the state of the location, then use this in your getData and other methods to skip data fetching if that state is set and if the current transition is a PUSH or REPLACE
dminkovsky

comment created time in 21 hours

issue closed4Catalyzer/found

Documentation: Router comparison

It would be very useful to be able to view a succinct router feature comparison in order to quickly inform prospective adopters of the pros and cons of using this router library vs the other available options.

closed time in 21 hours

Shannanigans

issue comment4Catalyzer/found

Documentation: Router comparison

I'm going to consolidate this with https://github.com/4Catalyzer/found/issues/180 to keep things organized. It's a good idea, but I haven't had the chance to get around to it.

Feel free to follow up in that thread with any specific questions you might have, and I'll do my best to answer.

Shannanigans

comment created time in 21 hours

issue commentreact-bootstrap/react-bootstrap

Popover placement is misaligned when using "auto" OverlayTrigger placement, but only for the first time it is opened

@jquense sounds like this is maybe an issue w/the margin calculation?

dumbmatter

comment created time in 21 hours

issue commentreact-bootstrap/react-bootstrap

Pagination.Prev / Pagination.Next complains with missing children in TypeScript

We'd be happy to take a PR to fix this. children needs to be marked optional there.

frankie567

comment created time in 21 hours

issue comment4Catalyzer/found

Shallow routing?

Are you using Found Relay?

dminkovsky

comment created time in 2 days

issue commentreact-bootstrap/react-bootstrap

Failed to compile. Attempted import error.

@jquense looks like the FooProps imports/exports made it into the compiled CJS code in 1.1.0: https://unpkg.com/browse/react-bootstrap@1.1.0/cjs/index.js

should we swap these out for import type/export type so TS doesn't do something weird?

samja666

comment created time in 2 days

push eventreact-bootstrap/react-bootstrap

renovate[bot]

commit sha d8cbaea52bc5fdc5005a0a35e542b1d296efbccf

chore(deps): update all non-major dependencies (#5266) Co-authored-by: Renovate Bot <bot@renovateapp.com>

view details

push time in 2 days

delete branch react-bootstrap/react-bootstrap

delete branch : renovate/all-minor-patch

delete time in 2 days

PR merged react-bootstrap/react-bootstrap

chore(deps): update all non-major dependencies

This PR contains the following updates:

Package Type Update Change
@babel/cli (source) devDependencies patch ^7.10.3 -> ^7.10.4
@babel/core (source) devDependencies patch ^7.10.3 -> ^7.10.4
@babel/register devDependencies patch ^7.10.3 -> ^7.10.4
eslint (source) devDependencies minor ^7.3.1 -> ^7.4.0
eslint-plugin-react devDependencies patch ^7.20.1 -> ^7.20.3
gatsby (changelog) devDependencies patch ^2.23.11 -> ^2.23.21
gatsby-plugin-catch-links devDependencies patch ^2.3.7 -> ^2.3.10
gatsby-plugin-mdx devDependencies patch ^1.2.18 -> ^1.2.22
gatsby-plugin-sass devDependencies patch ^2.3.6 -> ^2.3.10
gatsby-remark-prismjs devDependencies patch ^3.5.6 -> ^3.5.9
gatsby-source-filesystem devDependencies patch 2.3.14 -> 2.3.18
gatsby-transformer-react-docgen devDependencies patch ^5.2.7 -> ^5.2.10
gatsby-transformer-remark devDependencies patch ^2.8.19 -> ^2.8.23
typescript (source) devDependencies patch ^3.9.5 -> ^3.9.6

Release Notes

<details> <summary>babel/babel</summary>

v7.10.4

Compare Source

:eyeglasses: Spec Compliance
  • babel-helper-member-expression-to-functions, babel-plugin-proposal-class-properties
  • babel-parser, babel-types
:bug: Bug Fix
:nail_care: Polish
:house: Internal

</details>

<details> <summary>eslint/eslint</summary>

v7.4.0

Compare Source

</details>

<details> <summary>yannickcr/eslint-plugin-react</summary>

v7.20.3

Compare Source

Fixed
  • [Fix] no-unused-prop-types/prop-types: typescript interface support literal type and only FunctionComponent should have propTypes validation (#​2690 @​hank121314)
  • [Fix] no-unused-prop-types/TypeScript: avoid crash on indexable interface (#​2687 @​ljharb)

v7.20.2

Compare Source

Fixed

</details>

<details> <summary>gatsbyjs/gatsby</summary>

v2.23.21

Compare Source

v2.23.20

Compare Source

v2.23.19

Compare Source

v2.23.18

Compare Source

v2.23.17

Compare Source

v2.23.16

Compare Source

v2.23.15

Compare Source

v2.23.14

Compare Source

v2.23.12

Compare Source

</details>


Renovate configuration

:date: Schedule: "before 3am on Monday" (UTC).

:vertical_traffic_light: Automerge: Disabled by config. Please merge this manually once you are satisfied.

:recycle: Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

:ghost: Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.


  • [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

This PR has been generated by WhiteSource Renovate. View repository job log here.

+411 -1071

0 comment

4 changed files

renovate[bot]

pr closed time in 2 days

push eventreact-bootstrap/react-overlays

renovate[bot]

commit sha 212ffc2aa72756c4c9a2054bb3093050fe0db75b

chore(deps): update all non-major dependencies (#834) Co-authored-by: Renovate Bot <bot@renovateapp.com>

view details

push time in 2 days

delete branch react-bootstrap/react-overlays

delete branch : renovate/all-minor-patch

delete time in 2 days

PR merged react-bootstrap/react-overlays

chore(deps): update all non-major dependencies

This PR contains the following updates:

Package Type Update Change
@babel/cli (source) devDependencies patch ^7.10.3 -> ^7.10.4
@babel/core (source) devDependencies patch ^7.10.3 -> ^7.10.4
@babel/plugin-proposal-class-properties devDependencies patch ^7.10.1 -> ^7.10.4
@babel/plugin-transform-runtime devDependencies patch ^7.10.3 -> ^7.10.4
@babel/polyfill (source) devDependencies patch ^7.8.7 -> ^7.10.4
@babel/preset-env (source) devDependencies patch ^7.10.3 -> ^7.10.4
@babel/preset-react (source) devDependencies patch ^7.10.1 -> ^7.10.4
@babel/preset-typescript devDependencies patch ^7.10.1 -> ^7.10.4
@typescript-eslint/eslint-plugin devDependencies minor ^3.4.0 -> ^3.5.0
@typescript-eslint/parser devDependencies minor ^3.4.0 -> ^3.5.0
eslint (source) devDependencies minor ^7.3.1 -> ^7.4.0
eslint-plugin-react devDependencies patch ^7.20.1 -> ^7.20.3
eslint-plugin-react-hooks (source) devDependencies patch ^4.0.4 -> ^4.0.5
gatsby (changelog) devDependencies patch ^2.23.11 -> ^2.23.21
gatsby-plugin-sass devDependencies patch ^2.3.6 -> ^2.3.10
rollup (source) devDependencies minor ^2.18.1 -> ^2.19.0
typescript (source) devDependencies patch ^3.9.5 -> ^3.9.6

Release Notes

<details> <summary>babel/babel</summary>

v7.10.4

Compare Source

:eyeglasses: Spec Compliance
  • babel-helper-member-expression-to-functions, babel-plugin-proposal-class-properties
  • babel-parser, babel-types
:bug: Bug Fix
:nail_care: Polish
:house: Internal

</details>

<details> <summary>typescript-eslint/typescript-eslint</summary>

v3.5.0

Compare Source

Bug Fixes
  • eslint-plugin: [naming-convention] support unicode in regex (#​2241) (5fdd21a)
  • typescript-estree: forward compatibility for new compound assignment operators (#​2253) (ba41680)
Features

</details>

<details> <summary>eslint/eslint</summary>

v7.4.0

Compare Source

</details>

<details> <summary>yannickcr/eslint-plugin-react</summary>

v7.20.3

Compare Source

Fixed
  • [Fix] no-unused-prop-types/prop-types: typescript interface support literal type and only FunctionComponent should have propTypes validation (#​2690 @​hank121314)
  • [Fix] no-unused-prop-types/TypeScript: avoid crash on indexable interface (#​2687 @​ljharb)

v7.20.2

Compare Source

Fixed

</details>

<details> <summary>gatsbyjs/gatsby</summary>

v2.23.21

Compare Source

v2.23.20

Compare Source

v2.23.19

Compare Source

v2.23.18

Compare Source

v2.23.17

Compare Source

v2.23.16

Compare Source

v2.23.15

Compare Source

v2.23.14

Compare Source

v2.23.12

Compare Source

</details>

<details> <summary>rollup/rollup</summary>

v2.19.0

Compare Source

2020-07-05

Features
  • Allow plugins to return a Promise in the options hook (#​3660)
Pull Requests

v2.18.2

Compare Source

2020-07-02

Bug Fixes
  • Do not remove spread element args when the corresponding positional parameter is unused (#​3652)
Pull Requests

</details>


Renovate configuration

:date: Schedule: "before 3am on Monday" (UTC).

:vertical_traffic_light: Automerge: Disabled by config. Please merge this manually once you are satisfied.

:recycle: Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

:ghost: Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.


  • [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

This PR has been generated by WhiteSource Renovate. View repository job log here.

+939 -1653

0 comment

4 changed files

renovate[bot]

pr closed time in 2 days

push eventtaion/flask-resty-demo

Jimmy Jia

commit sha 0c10ba99b176ab4de9acb914235a4fdea31ac252

feat: Set everything up

view details

push time in 2 days

PR merged react-bootstrap/configs

chore(deps): update all non-major dependencies

This PR contains the following updates:

Package Type Update Change
@typescript-eslint/eslint-plugin devDependencies minor ^3.4.0 -> ^3.5.0
eslint (source) devDependencies minor ^7.3.1 -> ^7.4.0
eslint-plugin-react devDependencies patch ^7.20.1 -> ^7.20.3

Release Notes

<details> <summary>typescript-eslint/typescript-eslint</summary>

v3.5.0

Compare Source

Bug Fixes
  • eslint-plugin: [naming-convention] support unicode in regex (#​2241) (5fdd21a)
  • typescript-estree: forward compatibility for new compound assignment operators (#​2253) (ba41680)
Features

</details>

<details> <summary>eslint/eslint</summary>

v7.4.0

Compare Source

</details>

<details> <summary>yannickcr/eslint-plugin-react</summary>

v7.20.3

Compare Source

Fixed
  • [Fix] no-unused-prop-types/prop-types: typescript interface support literal type and only FunctionComponent should have propTypes validation (#​2690 @​hank121314)
  • [Fix] no-unused-prop-types/TypeScript: avoid crash on indexable interface (#​2687 @​ljharb)

v7.20.2

Compare Source

Fixed

</details>


Renovate configuration

:date: Schedule: "before 3am on Monday" (UTC).

:vertical_traffic_light: Automerge: Enabled.

:recycle: Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

:ghost: Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.


  • [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

This PR has been generated by WhiteSource Renovate. View repository job log here.

+40 -26

0 comment

3 changed files

renovate[bot]

pr closed time in 2 days

push eventreact-bootstrap/configs

renovate[bot]

commit sha 7983dbe3fa1aa376c555a3ca2f781e3ebd4a66c9

chore(deps): update all non-major dependencies (#16) Co-authored-by: Renovate Bot <bot@renovateapp.com>

view details

push time in 2 days

delete branch react-bootstrap/configs

delete branch : renovate/all-minor-patch

delete time in 2 days

push eventtaion/flask-resty-demo

Jimmy Jia

commit sha a307555a1c5f6598c6e93ee8230690f7ce53a41d

feat: Set everything up

view details

push time in 4 days

pull request commentreact-bootstrap/react-bootstrap

[types/helpers] add 'this : void' to SelectCallback

@react-bootstrap/collaborators thoughts?

hexagonal-sun

comment created time in 4 days

PR closed react-bootstrap/react-bootstrap

docs: Remove link to nonexistent popover docs page

Fixes https://github.com/react-bootstrap/react-bootstrap/issues/5214

+0 -2

7 comments

1 changed file

taion

pr closed time in 4 days

IssuesEvent

issue commentreact-bootstrap/react-bootstrap

Dead link: https://react-bootstrap.github.io/components/popovers/

Per https://github.com/react-bootstrap/react-bootstrap/pull/5215#issuecomment-638404342, we should fix the link

AdityaAnand1

comment created time in 4 days

pull request commentreact-bootstrap/react-bootstrap

docs: Remove link to nonexistent popover docs page

oh oops

taion

comment created time in 4 days

pull request commentreact-bootstrap/react-bootstrap

docs: Remove link to nonexistent popover docs page

Do you want to make an issue to fix the generated docs, then?

taion

comment created time in 4 days

create barnchtaion/flask-resty-demo

branch : master

created branch time in 5 days

created repositorytaion/flask-resty-demo

Flask-RESTy demo for FlaskCon 2020

created time in 5 days

issue commenttaion/graphql-type-json

Can't import from graphql-type-json

Ahh, okay, thanks for digging into things. Sorry this didn't quite work. Let me know if there's any progress on the upstream end.

I guess I should probably remove the ES module exports here, as they don't really help anyone and at best just lead to confusion.

lenneis

comment created time in 5 days

issue closedtaion/graphql-type-json

JSONObject cannot represent non-object value

Saving data is correct and is not returning any errors. OK.

But taking the record from the database and returning the response to the request is generating the following error: JSONObject cannot represent non-object value: [object Object],[object Object],[object Object]

My model:

import { Entity, PrimaryGeneratedColumn, Column, BaseEntity } from 'typeorm';
import { ObjectType, Field, ID } from 'type-graphql';
import { GraphQLJSONObject } from 'graphql-type-json';

@ObjectType()
@Entity({ name: 'medical-templates' })
export class Contents extends BaseEntity {
  @Field(() => ID)
  @PrimaryGeneratedColumn()
  id: string;

  @Field(() => String)
  @Column({ type: 'varchar', length: 100 })
  title: string;

  @Field(() => GraphQLJSONObject)
  @Column({ type: 'json', nullable: true })
  content: any[];
}

Is there another type to be used instead of GraphQLJSONObject?

closed time in 5 days

etc-tiago

issue commenttaion/graphql-type-json

JSONObject cannot represent non-object value

Looking at this, you probably want GraphQLList(GraphQLJSONObject) if you have a list of JSON objects. You could also do GraphQLJSON if you want "any JSON-serializable value".

etc-tiago

comment created time in 5 days

issue commentandymccurdy/redis-py

Document TLS/SSL support

I'm still happy to write this up if I can get some pointers on which doc to update.

edmorley

comment created time in 6 days

Pull request review comment4Catalyzer/javascript

feat: change default browsers to only include browsers that support esmodules

 const PRESET_ENV_OPTIONS = [   'shippedProposals', ]; -const DEFAULT_BROWSERS = [-  'ie >= 11',

we definitely don't want any IE support by default?

don't all of our apps set custom browser lists anyway?

manon-pilaud

comment created time in 6 days

issue closedreact-bootstrap/react-overlays

Uncaught TypeError: (0 , _uncontrollable.default) is not a function

issue: Uncaught TypeError: (0 , _uncontrollable.default) is not a function

packages: react-dom: 16.8.6 react:16.8.6 react-overlays:1.2.0

still getting this error:

browser source: Uncaught TypeError: (0 , _uncontrollable.default) is not a function

var UncontrolledDropdown = (0, _uncontrollable.default)(Dropdown, { show: 'onToggle' });

browsewr console output: Uncaught TypeError: (0 , _uncontrollable.default) is not a function at Object../node_modules/react-bootstrap/node_modules/react-overlays/Dropdown.js (Dropdown.js:305) at webpack_require (bootstrap 5aa110fbdd7b2189a480:680) at fn (bootstrap 5aa110fbdd7b2189a480:105) at Object../node_modules/react-bootstrap/es/Dropdown.js (app.5aa110fbdd7b2189a480.js:105655) at webpack_require (bootstrap 5aa110fbdd7b2189a480:680) at fn (bootstrap 5aa110fbdd7b2189a480:105) at Object../node_modules/react-bootstrap/es/index.js (app.5aa110fbdd7b2189a480.js:110277) at webpack_require (bootstrap 5aa110fbdd7b2189a480:680) at fn (bootstrap 5aa110fbdd7b2189a480:105) at Object.<anonymous> (TooltipWrapper.jsx:2) client?843a:38 [WDS] Hot Module Replacement enabled.

we do not directly use the uncontrolled component, it is being used by react-overlays in the Dropdown component.

anything i may be missing? and do i need to open a new issue for the same problem?

Originally posted by @MarkEmerson in https://github.com/react-bootstrap/react-overlays/issues/300#issuecomment-515867172

closed time in 6 days

MarkEmerson

Pull request review commentreact-bootstrap/react-bootstrap

[types/helpers] add 'this : void' to SelectCallback

 export type BsPrefixComponentClass< > = React.ComponentClass<ReplaceProps<As, BsPrefixProps<As> & P>>;  export type SelectCallback = (+  this : void,

nitpick: formatting

  this: void,
hexagonal-sun

comment created time in 6 days

pull request comment4Catalyzer/tqp

fix: Use single policy statement

on the array thing, i'm following https://docs.aws.amazon.com/IAM/latest/UserGuide/reference_policies_multi-value-conditions.html

taion

comment created time in 6 days

pull request comment4Catalyzer/tqp

fix: Use single policy statement

seems to work

taion

comment created time in 6 days

created tag4Catalyzer/tqp

tagv0.4.10

An opinionated library for pub/sub over SQS and SNS

created time in 7 days

push event4Catalyzer/tqp

Jimmy Jia

commit sha 547463c8b2b70d1a7ecbefc5760cbe9d3adb369e

0.4.10

view details

push time in 7 days

delete branch 4Catalyzer/tqp

delete branch : policy

delete time in 7 days

push event4Catalyzer/tqp

Jimmy Jia

commit sha d4cca29c497580b9313d1ea19f4fe40b08961235

fix: Use single policy statement (#31)

view details

push time in 7 days

PR merged 4Catalyzer/tqp

Reviewers
fix: Use single policy statement
+18 -13

1 comment

1 changed file

taion

pr closed time in 7 days

Pull request review comment4Catalyzer/cli

chore(deps): update dependency fork-ts-checker-webpack-plugin to v5

 function getMaxSeverityErrors(errors) {   return errors.filter((e) => e.severity === maxSeverity); } +function configureTypeChecker(config) {+  if (Array.isArray(config)) return config.map(configureTypeChecker);++  const { plugins = [], ...rest } = config;++  const index = plugins.findIndex(+    (p) => p.constructor.name === 'ForkTsCheckerWebpackPlugin',+  );++  if (index > -1 && !plugins[index].constructor.version)+    throw new Error(+      '@4c/start is only compatible with ForkTsCheckerWebpackPlugin v5 and above',+    );++  const options = index !== -1 ? plugins[index].options : {};++  const plugin = new ForkTsCheckerWebpackPlugin({+    ...options,+    async: true,

isn't this effectively true by default now when running in dev mode?

renovate[bot]

comment created time in 7 days

Pull request review comment4Catalyzer/cli

chore(deps): update dependency fork-ts-checker-webpack-plugin to v5

+const get = require('lodash/get');+ module.exports = (error) => {+  const message = error.message || get(error, 'webpackError');

question: why isn't this just

  const message = error.message || error.webpackError;
renovate[bot]

comment created time in 7 days

Pull request review comment4Catalyzer/cli

chore(deps): update dependency fork-ts-checker-webpack-plugin to v5

 const formatErrors = require('friendly-errors-webpack-plugin/src/core/formatErro const transformErrors = require('friendly-errors-webpack-plugin/src/core/transformErrors'); const colors = require('friendly-errors-webpack-plugin/src/utils/colors'); // eslint-disable-next-line import/no-extraneous-dependencies

thought: this was meant to apply to webpack below

renovate[bot]

comment created time in 7 days

issue commenttaion/graphql-type-json

What's the purpose of specifiedByUrl ?

I'm not sure why the file size of the GraphQL schema matters. In general, if you're running the appropriate build steps, I don't think it should get shipped to clients.

I'm also not sure that this is a matter of this schema per se... does the spec say somewhere that it's impermissible to add these? It seems more like this is something opted into by e.g. an upgrade to graphql @ 15.x, as versions of GraphQL.js prior to this would not emit this directive.

joonhocho

comment created time in 7 days

pull request commentreactjs/react-transition-group

Fix issues #474 and #410 - add new items in correct order

I was thinking that we'd export the "prepend instead of append" variant to satisfy the basic use case, but still expose the lower-level API just in case.

I dunno, just a thought – @silvenon @jquense?

nol13

comment created time in 7 days

pull request comment4Catalyzer/tqp

fix: Use single policy statement

@sloria @emmilco adding new poll handlers is broken without this

taion

comment created time in 7 days

PR opened 4Catalyzer/tqp

fix: Use single policy statement
+18 -13

0 comment

1 changed file

pr created time in 7 days

create barnch4Catalyzer/tqp

branch : policy

created branch time in 7 days

issue commentreact-bootstrap/react-bootstrap

Error when trying to create a customized variant for Button

so... do we have a proposal for how we'd like to do this? if it doesn't work straightforwardly with TS...

i mean, patch-package is an option, but it's a bad one.

i wonder if we can make the variant types themselves be interfaces that users can ... do something with?

longnguyennn

comment created time in 8 days

issue closedreact-bootstrap/react-bootstrap

Update Badge.d.ts

Describe the bug

TypeScript error when using "outline-primary", "outline-secondary" etc as variant prop for Badge component

To Reproduce

Steps to reproduce the behavior:

  1. Try to use "outline-primary" as variant prop for Badge component

Expected behavior

No TypeScript errors

Screenshots

image

Environment (please complete the following information)

  • React-Bootstrap Version 1.0.1

Additional context

I would've sent a pr if I had permissions. Maybe you should describe how to get permissions for contribution in the docs

closed time in 8 days

makarkotlov

issue commentreact-bootstrap/react-bootstrap

Update Badge.d.ts

  1. This doesn't seem to be a specified variant in https://getbootstrap.com/docs/4.5/components/badge/
  2. You don't need special permissions to create a PR; you just make the branch in your fork and PR from there, as with any other repo

But for custom variants, see https://github.com/react-bootstrap/react-bootstrap/issues/4461

makarkotlov

comment created time in 8 days

IssuesEvent
CommitCommentEvent

issue openedyannickcr/eslint-plugin-react

no-unused-prop-types: Crashes on indexable TypeScript prop declarations

This is an issue with https://github.com/yannickcr/eslint-plugin-react/pull/2661 that makes it crash in certain cases. cc @eltonio450

Consider something like https://astexplorer.net/#/gist/dea688bfbbfb2b2a2ffc3b4e293e0a01/63d1542090fe4a6545194562b88ffa34d7b22c83.

The interface body here consists of a TSPropertySignature and a TSIndexSignature. The foundDeclaredPropertiesList is thus not actually a list of declared properties: https://github.com/yannickcr/eslint-plugin-react/pull/2661/files#diff-3ed4052fa9471077711e82f482c3f819R304

When iterating through them, attempting to access tsPropertySignature.key.name on the index signature in https://github.com/yannickcr/eslint-plugin-react/pull/2661/files#diff-3ed4052fa9471077711e82f482c3f819R317 fails, because the index signature has no key property.

created time in 8 days

push event4Catalyzer/karma-jest

renovate[bot]

commit sha 234ebbed039b6a2671b9567d12071eb89cee77b9

chore(deps): update all non-major dependencies (#37) * chore(deps): update all non-major dependencies * more Co-authored-by: Renovate Bot <bot@renovateapp.com> Co-authored-by: Jimmy Jia <tesrin@gmail.com>

view details

push time in 8 days

delete branch 4Catalyzer/karma-jest

delete branch : renovate/all-minor-patch

delete time in 8 days

PR merged 4Catalyzer/karma-jest

chore(deps): update all non-major dependencies

This PR contains the following updates:

Package Type Update Change
@typescript-eslint/eslint-plugin devDependencies minor ^3.3.0 -> ^3.5.0
@typescript-eslint/parser devDependencies minor ^3.3.0 -> ^3.5.0
browser-jest-message-util devDependencies minor 26.0.1 -> 26.1.0
browser-jest-snapshot devDependencies minor 26.0.1 -> 26.1.0
browser-jest-util devDependencies minor 26.0.1 -> 26.1.0
eslint-plugin-import devDependencies minor ^2.21.2 -> ^2.22.0
eslint-plugin-jest devDependencies minor ^23.16.0 -> ^23.17.1
rollup (source) devDependencies minor ^2.17.1 -> ^2.18.1

Release Notes

<details> <summary>typescript-eslint/typescript-eslint</summary>

v3.5.0

Compare Source

Bug Fixes
  • eslint-plugin: [naming-convention] support unicode in regex (#​2241) (5fdd21a)
  • typescript-estree: forward compatibility for new compound assignment operators (#​2253) (ba41680)
Features

v3.4.0

Compare Source

Bug Fixes
  • eslint-plugin: [no-base-to-string] handle intersection types (#​2170) (9cca3a9)
  • eslint-plugin: [unbound-method] handling destructuring (#​2228) (c3753c2)
  • experimental-utils: correct types for TS versions older than 3.8 (#​2217) (5e4dda2)
  • experimental-utils: getParserServices takes a readonly context (#​2235) (26da8de)
Features
  • eslint-plugin: [no-unnecessary-boolean-literal-compare] add option to check nullable booleans (#​1983) (c0b3057)
  • eslint-plugin: add extension rule no-loss-of-precision (#​2196) (535b0f2)

</details>

<details> <summary>facebook/jest</summary>

v26.1.0

Compare Source

Features
  • [jest-mock] Export Mock, MockInstance, SpyInstance types (#​10138)
  • [jest-config] Support config files exporting (async) functions (#​10001)
  • [jest-cli, jest-core] Add --selectProjects CLI argument to filter test suites by project name (#​8612)
  • [jest-cli, jest-init] Add coverageProvider to jest --init prompts (#​10044)
Fixes
  • [jest-console] getConsoleOutput to receive global stack trace config and use it to format stack trace (#​10081)
  • [jest-jasmine2] Stop adding : after an error that has no message (#​9990)
  • [jest-diff] Control no diff message color with commonColor in diff options (#​9997)
  • [jest-snapshot] Fix TypeScript compilation (#​10008)
Chore & Maintenance
  • [docs] Correct confusing filename in enableAutomock example (#​10055)
  • [jest-core] 🎉🎉🎉🎉🎉🎉🎉🎉🎉🎉🎉🎉🎉🎉🎉🎉🎉🎉🎉🎉🎉🎉🎉🎉🎉 (#​10000)
  • [jest-core, jest-reporters, jest-test-result, jest-types] Cleanup displayName type (#​10049)
  • [jest-runtime] Jest-internal sandbox escape hatch (#​9907)
  • [jest-fake-timers] Update now param type to support Date in addition to number. (#​10169)
  • [docs] Add param to setSystemTime docs and remove preceding period from it and getRealSystemTime (#​10169)
  • [jest-snapshot, jest-util] Replace make-dir with fs.mkdir (#​10136)
  • [docs] Added parcel-bundler documentation inside readme.md file
Performance
  • [jest-core, jest-transform, jest-haste-map] Improve Jest startup time and test runtime, particularly when running with coverage, by caching micromatch and avoiding recreating RegExp instances (#​10131)

</details>

<details> <summary>benmosher/eslint-plugin-import</summary>

v2.22.0

Compare Source

Added
  • [no-unused-modules]: consider exported TypeScript interfaces, types and enums ([#​1819], thanks [@​nicolashenry])
  • [no-cycle]: allow maxDepth option to be "∞" (thanks [@​ljharb])
Fixed
  • [order]/TypeScript: properly support import = object expressions ([#​1823], thanks [@​manuth])
  • [no-extraneous-dependencies]/TypeScript: do not error when importing type from dev dependencies ([#​1820], thanks [@​fernandopasik])
  • [default]: avoid crash with export = ([#​1822], thanks [@​AndrewLeedham])
  • [order]/[newline-after-import]: ignore TypeScript's "export import object" ([#​1830], thanks [@​be5invis])
  • [dynamic-import-chunkname]/TypeScript: supports @typescript-eslint/parser ([#​1833], thanks [@​noelebrun])
  • [order]/TypeScript: ignore ordering of object imports ([#​1831], thanks [@​manuth])
  • [namespace]: do not report on shadowed import names ([#​518], thanks [@​ljharb])
  • [export]: avoid warning on export * as non-conflicts ([#​1834], thanks [@​ljharb])
Changed
  • [no-extraneous-dependencies]: add tests for importing types ([#​1824], thanks [@​taye])
  • [docs][no-default-export]: Fix docs url ([#​1836], thanks [@​beatrizrezener])
  • [docs][imports-first]: deprecation info and link to first docs ([#​1835], thanks [@​beatrizrezener])

</details>

<details> <summary>jest-community/eslint-plugin-jest</summary>

v23.17.1

Compare Source

Bug Fixes

v23.17.0

Compare Source

Features

</details>

<details> <summary>rollup/rollup</summary>

v2.18.1

Compare Source

2020-06-26

Bug Fixes
  • Make sure synthetic exports are present when a module is imported dynamically (#​3648)
  • Strip the rollup-plugin- prefix off the plugin name when looking for the plugin export in a CLI plugin without a default export (#​3647)
  • Convert plugin names with dashes to camel case when looking for the plugin export in a CLI plugin without a default export (#​3647)
Pull Requests
  • #​3647: Strip rollup-plugin prefix to find named plugin exports, throw when export cannot be found (@​lukastaegert)
  • #​3648: Always create a dynamic namespace object when a module with synthetic named exports is imported dynamically (@​lukastaegert)

v2.18.0

Compare Source

2020-06-22

Features
  • inlineDynamicImports, manualChunks and preserveModules can now be used as output options (#​3645)
  • Use sourcemaps for certain warnings that reference source code locations (#​3645)
Bug Fixes
  • this.getFileName will now always return the correct file name for chunks when multiple outputs are created (#​3645)
Pull Requests

</details>


Renovate configuration

:date: Schedule: "before 3am on Monday" (UTC).

:vertical_traffic_light: Automerge: Enabled.

:recycle: Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

:ghost: Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.


  • [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

This PR has been generated by WhiteSource Renovate. View repository job log here.

+147 -128

1 comment

5 changed files

renovate[bot]

pr closed time in 8 days

push event4Catalyzer/karma-jest

Jimmy Jia

commit sha 99300316d983ca4781f09eb21f4cb965c4bdcf89

more

view details

push time in 8 days

release 4Catalyzer/flask-resty

v1.2.0

released time in 9 days

created tag4Catalyzer/flask-resty

tagv1.2.0

Building blocks for REST APIs for Flask

created time in 9 days

push event4Catalyzer/flask-resty

Jimmy Jia

commit sha cab9744cfd5c2d60022e55abf216640c71877300

feat: Allow disabling validation on cursor values (#337)

view details

push time in 9 days

delete branch 4Catalyzer/flask-resty

delete branch : no-validate-values

delete time in 9 days

issue commenttaion/graphql-type-json

Can't import from graphql-type-json

Yeah, my build is wrong – I didn't properly tag the ES modules to be usable by Node. Do you want to send in a PR to fix the package.json?

lenneis

comment created time in 9 days

push event4Catalyzer/found-scroll

renovate[bot]

commit sha 99ab0505b42248de362867847b33eaa5ccbf11ce

chore(deps): update all non-major dependencies (#296) Co-authored-by: Renovate Bot <bot@renovateapp.com> Co-authored-by: Jimmy Jia <tesrin@gmail.com>

view details

push time in 9 days

delete branch 4Catalyzer/found-scroll

delete branch : renovate/all-minor-patch

delete time in 9 days

PR merged 4Catalyzer/found-scroll

chore(deps): update all non-major dependencies

This PR contains the following updates:

Package Type Update Change
babel-jest devDependencies minor ^26.0.1 -> ^26.1.0
eslint (source) devDependencies minor ^7.2.0 -> ^7.3.1
eslint-plugin-import devDependencies minor ^2.21.2 -> ^2.22.0
eslint-plugin-jest devDependencies minor ^23.16.0 -> ^23.17.1
eslint-plugin-react devDependencies patch ^7.20.0 -> ^7.20.1
jest (source) devDependencies minor ^26.0.1 -> ^26.1.0

Release Notes

<details> <summary>facebook/jest</summary>

v26.1.0

Compare Source

Features
  • [jest-mock] Export Mock, MockInstance, SpyInstance types (#​10138)
  • [jest-config] Support config files exporting (async) functions (#​10001)
  • [jest-cli, jest-core] Add --selectProjects CLI argument to filter test suites by project name (#​8612)
  • [jest-cli, jest-init] Add coverageProvider to jest --init prompts (#​10044)
Fixes
  • [jest-console] getConsoleOutput to receive global stack trace config and use it to format stack trace (#​10081)
  • [jest-jasmine2] Stop adding : after an error that has no message (#​9990)
  • [jest-diff] Control no diff message color with commonColor in diff options (#​9997)
  • [jest-snapshot] Fix TypeScript compilation (#​10008)
Chore & Maintenance
  • [docs] Correct confusing filename in enableAutomock example (#​10055)
  • [jest-core] 🎉🎉🎉🎉🎉🎉🎉🎉🎉🎉🎉🎉🎉🎉🎉🎉🎉🎉🎉🎉🎉🎉🎉🎉🎉 (#​10000)
  • [jest-core, jest-reporters, jest-test-result, jest-types] Cleanup displayName type (#​10049)
  • [jest-runtime] Jest-internal sandbox escape hatch (#​9907)
  • [jest-fake-timers] Update now param type to support Date in addition to number. (#​10169)
  • [docs] Add param to setSystemTime docs and remove preceding period from it and getRealSystemTime (#​10169)
  • [jest-snapshot, jest-util] Replace make-dir with fs.mkdir (#​10136)
Performance
  • [jest-core, jest-transform, jest-haste-map] Improve Jest startup time and test runtime, particularly when running with coverage, by caching micromatch and avoiding recreating RegExp instances (#​10131)

</details>

<details> <summary>eslint/eslint</summary>

v7.3.1

Compare Source

v7.3.0

Compare Source

</details>

<details> <summary>benmosher/eslint-plugin-import</summary>

v2.22.0

Compare Source

Added
  • [no-unused-modules]: consider exported TypeScript interfaces, types and enums ([#​1819], thanks [@​nicolashenry])
  • [no-cycle]: allow maxDepth option to be "∞" (thanks [@​ljharb])
Fixed
  • [order]/TypeScript: properly support import = object expressions ([#​1823], thanks [@​manuth])
  • [no-extraneous-dependencies]/TypeScript: do not error when importing type from dev dependencies ([#​1820], thanks [@​fernandopasik])
  • [default]: avoid crash with export = ([#​1822], thanks [@​AndrewLeedham])
  • [order]/[newline-after-import]: ignore TypeScript's "export import object" ([#​1830], thanks [@​be5invis])
  • [dynamic-import-chunkname]/TypeScript: supports @typescript-eslint/parser ([#​1833], thanks [@​noelebrun])
  • [order]/TypeScript: ignore ordering of object imports ([#​1831], thanks [@​manuth])
  • [namespace]: do not report on shadowed import names ([#​518], thanks [@​ljharb])
  • [export]: avoid warning on export * as non-conflicts ([#​1834], thanks [@​ljharb])
Changed
  • [no-extraneous-dependencies]: add tests for importing types ([#​1824], thanks [@​taye])
  • [docs][no-default-export]: Fix docs url ([#​1836], thanks [@​beatrizrezener])
  • [docs][imports-first]: deprecation info and link to first docs ([#​1835], thanks [@​beatrizrezener])

</details>

<details> <summary>jest-community/eslint-plugin-jest</summary>

v23.17.1

Compare Source

Bug Fixes

v23.17.0

Compare Source

Features

</details>

<details> <summary>yannickcr/eslint-plugin-react</summary>

v7.20.1

Compare Source

Fixed
Changed
  • [forbid-prop-types]: warn on destructured values as well (#​2676 @​ajkovar)
  • relax JSX pragma regexp (#​2643 @​gfmio)
  • Cache detected React version (#​2673 @​lencioni)
  • [refactor][jsx-pascal-case]: Remove xregexp (#​2636 @​yacinehmito))
  • [Tests] a [no-typos] test fails in eslint v7.3 ([#​2678][] @​toshi-toma)
  • [Deps] update jsx-ast-utils, object.entries, resolve
  • [Dev Deps] update @types/eslint, @types/estree, @types/node, @typescript-eslint/parser, eslint-config-airbnb-base, eslint-plugin-eslint-plugin, eslint-plugin-import, typescript

</details>


Renovate configuration

:date: Schedule: "before 3am on Monday" (UTC).

:vertical_traffic_light: Automerge: Disabled due to failing status checks.

:recycle: Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

:ghost: Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.


  • [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

This PR has been generated by WhiteSource Renovate. View repository job log here.

+388 -451

1 comment

3 changed files

renovate[bot]

pr closed time in 9 days

push event4Catalyzer/found-scroll

Jimmy Jia

commit sha e8080127c959aa1f3681dee22a7d1ba99fd63667

fix

view details

push time in 9 days

delete branch react-bootstrap/code-sandbox-examples

delete branch : renovate/all-minor-patch

delete time in 9 days

push eventreact-bootstrap/code-sandbox-examples

renovate[bot]

commit sha 0966fa2aa8e8b31e7f7ce401eb01b54d9de531a2

chore(deps): update all non-major dependencies (#98) Co-authored-by: Renovate Bot <bot@renovateapp.com>

view details

push time in 9 days

PR merged react-bootstrap/code-sandbox-examples

chore(deps): update all non-major dependencies

This PR contains the following updates:

Package Type Update Change
@types/jest dependencies patch 26.0.0 -> 26.0.3
@types/react dependencies patch 16.9.38 -> 16.9.41

Renovate configuration

:date: Schedule: "before 3am on Monday" (UTC).

:vertical_traffic_light: Automerge: Disabled by config. Please merge this manually once you are satisfied.

:recycle: Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

:ghost: Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.


  • [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

This PR has been generated by WhiteSource Renovate. View repository job log here.

+10 -10

0 comment

2 changed files

renovate[bot]

pr closed time in 9 days

push eventreact-bootstrap/configs

renovate[bot]

commit sha 1cf701c62f2f37f6e8af41a8c88bdd935bf65a58

chore(deps): update all non-major dependencies (#15) Co-authored-by: Renovate Bot <bot@renovateapp.com>

view details

push time in 9 days

delete branch react-bootstrap/configs

delete branch : renovate/all-minor-patch

delete time in 9 days

PR merged react-bootstrap/configs

chore(deps): update all non-major dependencies

This PR contains the following updates:

Package Type Update Change
@typescript-eslint/eslint-plugin devDependencies minor ^3.3.0 -> ^3.4.0
eslint (source) devDependencies patch ^7.3.0 -> ^7.3.1
eslint-plugin-import devDependencies minor ^2.21.2 -> ^2.22.0
eslint-plugin-react devDependencies patch ^7.20.0 -> ^7.20.1
npm-name devDependencies patch ^6.0.0 -> ^6.0.1

Release Notes

<details> <summary>typescript-eslint/typescript-eslint</summary>

v3.4.0

Compare Source

Bug Fixes
  • eslint-plugin: [no-base-to-string] handle intersection types (#​2170) (9cca3a9)
  • eslint-plugin: [unbound-method] handling destructuring (#​2228) (c3753c2)
  • experimental-utils: correct types for TS versions older than 3.8 (#​2217) (5e4dda2)
  • experimental-utils: getParserServices takes a readonly context (#​2235) (26da8de)
Features
  • eslint-plugin: [no-unnecessary-boolean-literal-compare] add option to check nullable booleans (#​1983) (c0b3057)
  • eslint-plugin: add extension rule no-loss-of-precision (#​2196) (535b0f2)

</details>

<details> <summary>eslint/eslint</summary>

v7.3.1

Compare Source

</details>

<details> <summary>benmosher/eslint-plugin-import</summary>

v2.22.0

Compare Source

Added
  • [no-unused-modules]: consider exported TypeScript interfaces, types and enums ([#​1819], thanks [@​nicolashenry])
  • [no-cycle]: allow maxDepth option to be "∞" (thanks [@​ljharb])
Fixed
  • [order]/TypeScript: properly support import = object expressions ([#​1823], thanks [@​manuth])
  • [no-extraneous-dependencies]/TypeScript: do not error when importing type from dev dependencies ([#​1820], thanks [@​fernandopasik])
  • [default]: avoid crash with export = ([#​1822], thanks [@​AndrewLeedham])
  • [order]/[newline-after-import]: ignore TypeScript's "export import object" ([#​1830], thanks [@​be5invis])
  • [dynamic-import-chunkname]/TypeScript: supports @typescript-eslint/parser ([#​1833], thanks [@​noelebrun])
  • [order]/TypeScript: ignore ordering of object imports ([#​1831], thanks [@​manuth])
  • [namespace]: do not report on shadowed import names ([#​518], thanks [@​ljharb])
  • [export]: avoid warning on export * as non-conflicts ([#​1834], thanks [@​ljharb])
Changed
  • [no-extraneous-dependencies]: add tests for importing types ([#​1824], thanks [@​taye])
  • [docs][no-default-export]: Fix docs url ([#​1836], thanks [@​beatrizrezener])
  • [docs][imports-first]: deprecation info and link to first docs ([#​1835], thanks [@​beatrizrezener])

</details>

<details> <summary>yannickcr/eslint-plugin-react</summary>

v7.20.1

Compare Source

Fixed
Changed
  • [forbid-prop-types]: warn on destructured values as well (#​2676 @​ajkovar)
  • relax JSX pragma regexp (#​2643 @​gfmio)
  • Cache detected React version (#​2673 @​lencioni)
  • [refactor][jsx-pascal-case]: Remove xregexp (#​2636 @​yacinehmito))
  • [Tests] a [no-typos] test fails in eslint v7.3 ([#​2678][] @​toshi-toma)
  • [Deps] update jsx-ast-utils, object.entries, resolve
  • [Dev Deps] update @types/eslint, @types/estree, @types/node, @typescript-eslint/parser, eslint-config-airbnb-base, eslint-plugin-eslint-plugin, eslint-plugin-import, typescript

</details>

<details> <summary>sindresorhus/npm-name</summary>

v6.0.1

Compare Source

</details>


Renovate configuration

:date: Schedule: "before 3am on Monday" (UTC).

:vertical_traffic_light: Automerge: Enabled.

:recycle: Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

:ghost: Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.


  • [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

This PR has been generated by WhiteSource Renovate. View repository job log here.

+59 -76

0 comment

3 changed files

renovate[bot]

pr closed time in 9 days

push eventreact-bootstrap/react-bootstrap

renovate[bot]

commit sha 5c21cc2bc84239dfd4936a4baeea00af23319e76

chore(deps): update all non-major dependencies (#5257) Co-authored-by: Renovate Bot <bot@renovateapp.com>

view details

push time in 9 days

delete branch react-bootstrap/react-bootstrap

delete branch : renovate/all-minor-patch

delete time in 9 days

PR merged react-bootstrap/react-bootstrap

chore(deps): update all non-major dependencies

This PR contains the following updates:

Package Type Update Change
eslint (source) devDependencies minor ^7.2.0 -> ^7.3.1
eslint-plugin-import devDependencies minor ^2.21.2 -> ^2.22.0
eslint-plugin-react devDependencies patch ^7.20.0 -> ^7.20.1
gatsby (changelog) devDependencies patch ^2.23.8 -> ^2.23.11
gatsby-plugin-catch-links devDependencies patch ^2.3.5 -> ^2.3.7
gatsby-plugin-mdx devDependencies patch ^1.2.16 -> ^1.2.18
gatsby-plugin-sass devDependencies patch ^2.3.4 -> ^2.3.6
gatsby-remark-prismjs devDependencies patch ^3.5.4 -> ^3.5.6
gatsby-source-filesystem devDependencies patch 2.3.12 -> 2.3.14
gatsby-transformer-react-docgen devDependencies patch ^5.2.5 -> ^5.2.7
gatsby-transformer-remark devDependencies patch ^2.8.17 -> ^2.8.19

Release Notes

<details> <summary>eslint/eslint</summary>

v7.3.1

Compare Source

v7.3.0

Compare Source

</details>

<details> <summary>benmosher/eslint-plugin-import</summary>

v2.22.0

Compare Source

Added
  • [no-unused-modules]: consider exported TypeScript interfaces, types and enums ([#​1819], thanks [@​nicolashenry])
  • [no-cycle]: allow maxDepth option to be "∞" (thanks [@​ljharb])
Fixed
  • [order]/TypeScript: properly support import = object expressions ([#​1823], thanks [@​manuth])
  • [no-extraneous-dependencies]/TypeScript: do not error when importing type from dev dependencies ([#​1820], thanks [@​fernandopasik])
  • [default]: avoid crash with export = ([#​1822], thanks [@​AndrewLeedham])
  • [order]/[newline-after-import]: ignore TypeScript's "export import object" ([#​1830], thanks [@​be5invis])
  • [dynamic-import-chunkname]/TypeScript: supports @typescript-eslint/parser ([#​1833], thanks [@​noelebrun])
  • [order]/TypeScript: ignore ordering of object imports ([#​1831], thanks [@​manuth])
  • [namespace]: do not report on shadowed import names ([#​518], thanks [@​ljharb])
  • [export]: avoid warning on export * as non-conflicts ([#​1834], thanks [@​ljharb])
Changed
  • [no-extraneous-dependencies]: add tests for importing types ([#​1824], thanks [@​taye])
  • [docs][no-default-export]: Fix docs url ([#​1836], thanks [@​beatrizrezener])
  • [docs][imports-first]: deprecation info and link to first docs ([#​1835], thanks [@​beatrizrezener])

</details>

<details> <summary>yannickcr/eslint-plugin-react</summary>

v7.20.1

Compare Source

Fixed
Changed
  • [forbid-prop-types]: warn on destructured values as well (#​2676 @​ajkovar)
  • relax JSX pragma regexp (#​2643 @​gfmio)
  • Cache detected React version (#​2673 @​lencioni)
  • [refactor][jsx-pascal-case]: Remove xregexp (#​2636 @​yacinehmito))
  • [Tests] a [no-typos] test fails in eslint v7.3 ([#​2678][] @​toshi-toma)
  • [Deps] update jsx-ast-utils, object.entries, resolve
  • [Dev Deps] update @types/eslint, @types/estree, @types/node, @typescript-eslint/parser, eslint-config-airbnb-base, eslint-plugin-eslint-plugin, eslint-plugin-import, typescript

</details>

<details> <summary>gatsbyjs/gatsby</summary>

v2.23.11

Compare Source

v2.23.10

Compare Source

v2.23.9

Compare Source

</details>


Renovate configuration

:date: Schedule: "before 3am on Monday" (UTC).

:vertical_traffic_light: Automerge: Disabled by config. Please merge this manually once you are satisfied.

:recycle: Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

:ghost: Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.


  • [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

This PR has been generated by WhiteSource Renovate. View repository job log here.

+797 -728

0 comment

4 changed files

renovate[bot]

pr closed time in 9 days

push eventreact-bootstrap/react-overlays

renovate[bot]

commit sha ae8fd111cecee93bb8bfb21811037d70b40fb3c4

chore(deps): update all non-major dependencies (#832) Co-authored-by: Renovate Bot <bot@renovateapp.com>

view details

push time in 9 days

delete branch react-bootstrap/react-overlays

delete branch : renovate/all-minor-patch

delete time in 9 days

PR merged react-bootstrap/react-overlays

chore(deps): update all non-major dependencies

This PR contains the following updates:

Package Type Update Change
@types/react devDependencies patch ^16.9.38 -> ^16.9.41
@typescript-eslint/eslint-plugin devDependencies minor ^3.3.0 -> ^3.4.0
@typescript-eslint/parser devDependencies minor ^3.3.0 -> ^3.4.0
eslint (source) devDependencies minor ^7.2.0 -> ^7.3.1
eslint-plugin-import devDependencies minor ^2.21.2 -> ^2.22.0
eslint-plugin-react devDependencies patch ^7.20.0 -> ^7.20.1
gatsby (changelog) devDependencies patch ^2.23.8 -> ^2.23.11
gatsby-plugin-sass devDependencies patch ^2.3.4 -> ^2.3.6
rollup (source) devDependencies patch ^2.18.0 -> ^2.18.1
sass devDependencies patch ^1.26.8 -> ^1.26.9

Release Notes

<details> <summary>typescript-eslint/typescript-eslint</summary>

v3.4.0

Compare Source

Bug Fixes
  • eslint-plugin: [no-base-to-string] handle intersection types (#​2170) (9cca3a9)
  • eslint-plugin: [unbound-method] handling destructuring (#​2228) (c3753c2)
  • experimental-utils: correct types for TS versions older than 3.8 (#​2217) (5e4dda2)
  • experimental-utils: getParserServices takes a readonly context (#​2235) (26da8de)
Features
  • eslint-plugin: [no-unnecessary-boolean-literal-compare] add option to check nullable booleans (#​1983) (c0b3057)
  • eslint-plugin: add extension rule no-loss-of-precision (#​2196) (535b0f2)

</details>

<details> <summary>eslint/eslint</summary>

v7.3.1

Compare Source

v7.3.0

Compare Source

</details>

<details> <summary>benmosher/eslint-plugin-import</summary>

v2.22.0

Compare Source

Added
  • [no-unused-modules]: consider exported TypeScript interfaces, types and enums ([#​1819], thanks [@​nicolashenry])
  • [no-cycle]: allow maxDepth option to be "∞" (thanks [@​ljharb])
Fixed
  • [order]/TypeScript: properly support import = object expressions ([#​1823], thanks [@​manuth])
  • [no-extraneous-dependencies]/TypeScript: do not error when importing type from dev dependencies ([#​1820], thanks [@​fernandopasik])
  • [default]: avoid crash with export = ([#​1822], thanks [@​AndrewLeedham])
  • [order]/[newline-after-import]: ignore TypeScript's "export import object" ([#​1830], thanks [@​be5invis])
  • [dynamic-import-chunkname]/TypeScript: supports @typescript-eslint/parser ([#​1833], thanks [@​noelebrun])
  • [order]/TypeScript: ignore ordering of object imports ([#​1831], thanks [@​manuth])
  • [namespace]: do not report on shadowed import names ([#​518], thanks [@​ljharb])
  • [export]: avoid warning on export * as non-conflicts ([#​1834], thanks [@​ljharb])
Changed
  • [no-extraneous-dependencies]: add tests for importing types ([#​1824], thanks [@​taye])
  • [docs][no-default-export]: Fix docs url ([#​1836], thanks [@​beatrizrezener])
  • [docs][imports-first]: deprecation info and link to first docs ([#​1835], thanks [@​beatrizrezener])

</details>

<details> <summary>yannickcr/eslint-plugin-react</summary>

v7.20.1

Compare Source

Fixed
Changed
  • [forbid-prop-types]: warn on destructured values as well (#​2676 @​ajkovar)
  • relax JSX pragma regexp (#​2643 @​gfmio)
  • Cache detected React version (#​2673 @​lencioni)
  • [refactor][jsx-pascal-case]: Remove xregexp (#​2636 @​yacinehmito))
  • [Tests] a [no-typos] test fails in eslint v7.3 ([#​2678][] @​toshi-toma)
  • [Deps] update jsx-ast-utils, object.entries, resolve
  • [Dev Deps] update @types/eslint, @types/estree, @types/node, @typescript-eslint/parser, eslint-config-airbnb-base, eslint-plugin-eslint-plugin, eslint-plugin-import, typescript

</details>

<details> <summary>gatsbyjs/gatsby</summary>

v2.23.11

Compare Source

v2.23.10

Compare Source

v2.23.9

Compare Source

</details>

<details> <summary>rollup/rollup</summary>

v2.18.1

Compare Source

2020-06-26

Bug Fixes
  • Make sure synthetic exports are present when a module is imported dynamically (#​3648)
  • Strip the rollup-plugin- prefix off the plugin name when looking for the plugin export in a CLI plugin without a default export (#​3647)
  • Convert plugin names with dashes to camel case when looking for the plugin export in a CLI plugin without a default export (#​3647)
Pull Requests
  • #​3647: Strip rollup-plugin prefix to find named plugin exports, throw when export cannot be found (@​lukastaegert)
  • #​3648: Always create a dynamic namespace object when a module with synthetic named exports is imported dynamically (@​lukastaegert)

</details>

<details> <summary>sass/dart-sass</summary>

v1.26.9

Compare Source

  • Use an updated version of node_preamble when compiling to JS.

</details>


Renovate configuration

:date: Schedule: "before 3am on Monday" (UTC).

:vertical_traffic_light: Automerge: Disabled by config. Please merge this manually once you are satisfied.

:recycle: Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

:ghost: Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.


  • [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

This PR has been generated by WhiteSource Renovate. View repository job log here.

+814 -741

0 comment

4 changed files

renovate[bot]

pr closed time in 9 days

pull request commentreactjs/react-transition-group

Fix issues #474 and #410 - add new items in correct order

Okay, what if instead of trying to be clever here, we just let the user pass in a custom callback that will replace our mergeChildMappings is specified?

It's not the best API ever, but it should solve any potential customization use case.

nol13

comment created time in 11 days

issue closedreact-bootstrap/react-bootstrap

There's no information on borders, spacing and all normal utilities from normal bootstrap in the react-bootstrap website

Is your feature request related to a problem? Please describe

There's no information on borders, spacing and all normal utilities from normal bootstrap in the react-bootstrap website.

Describe the solution you'd like

Could you please add some documentation regarding these utilities? Thanks!

Describe alternatives you've considered

The only alternative I have managed to get to work is to use normal html classes but that just undermines the whole effort of using react.

Additional context

Nothing else. Thank you.

closed time in 11 days

DanielBakas

issue commentreact-bootstrap/react-bootstrap

There's no information on borders, spacing and all normal utilities from normal bootstrap in the react-bootstrap website

This isn't currently part of the API, as these are just CSS classes with no "component"-like behavior. See discussion in https://github.com/react-bootstrap/react-bootstrap/issues/5152, though.

DanielBakas

comment created time in 11 days

create barnch4Catalyzer/flask-resty

branch : no-validate-values

created branch time in 11 days

pull request comment4Catalyzer/cli

chore(deps): update dependency fork-ts-checker-webpack-plugin to v5

@jquense might be good to switch to this at some point; it's a big enough API change though that i can't quite take care of this just as a matter of course

renovate[bot]

comment created time in 12 days

issue closedreactjs/react-transition-group

Transition Firefox bad performance

I have been researching it and found no solution.

I'm using the React Transigion Group to create a fade in fade out transition.

Specifically in Firefox there are problems during the animation. The transition is not smooth. In all other browsers, I had no problem (Chrome, Opera, Safari etc).

I also tested on 4 different computers and on all of them I had a performance problem only in Firefox.

Here there are an example of implementation:

<Transition
        in={inProp}
        onEnter={onEnter}
        onExit={onExit}
        timeout={timeout}
        mountOnEnter={mountOnEnter}
        unmountOnExit={unmountOnExit}
        addEndListener={() => true}
        {...rest}
      >
        {(state) => (
          <FadeInAnimation
            ref={ref}
            data-testid="fade-animation"
            state={state}
            {...rest}
          >
            {children}
          </FadeInAnimation>
        )}
</Transition>

In this case, FadeAnimationis just a Styled Component element:

import styled from 'styled-components';
import { TransitionStatus } from 'react-transition-group/Transition';

export const FadeInAnimation = styled.div<{
  state: TransitionStatus;
}>`
  transition: 0.3s;
  opacity: ${({ state }) => (state === 'entered' ? 1 : 0)};
  visibility: ${({ state }) => (state === 'entered' ? 'block' : 'hidden')};
`;

Any ideas on how to fix this performance problem in Firefox?

Thank you.

closed time in 12 days

avallonazevedo

issue commentreactjs/react-transition-group

Transition Firefox bad performance

The transition animation is just the browser applying a CSS transition. It's not anything that's controlled by the code here. There's not really much to be done here.

avallonazevedo

comment created time in 12 days

issue commenttaion/graphql-type-json

What's the purpose of specifiedByUrl ?

It's just better documentation.

How specifically is it breaking? It sounds like the directive is just getting ignored in your case, which doesn't seem like an issue to me?

joonhocho

comment created time in 12 days

more