profile
viewpoint
Taehwan Noh taehwanno @modusign Seoul, Republic of Korea https://taehwannoh.dev Software Engineer

taehwanno/warnings-to-errors-webpack-plugin 14

a webpack plugin that can recognize every warning as errors.

taehwanno/jest-image-snapshot-example 12

Jest Image Snapshot Example with puppeteer and Circle CI

taehwanno/hnpwa-react 10

Hacker News readers as Progressive Web Apps with React, react-router, redux, Immutable.js

taehwanno/react-github-renderer 9

:octocat: A react custom renderer for Github

taehwanno/react-simple-seed 9

react simple seed for GDG Busan react.js study

taehwanno/props-type 5

Utility type that defines the type of the React component props through propTypes and defaultProps in TypeScript

g2ang/face-transformation 3

Face Transformation with StyleGAN

taehwanno/react-outside-click-handler 3

:blossom: React Component for handling click events outside a specific component.

taehwanno/redux-user-timing 3

User Timing middleware for Redux

taehwanno/instagram-shortcut-extension 2

Instagram keyboard ⌨️ shortcut extension

delete branch reactjs/ko.reactjs.org

delete branch : sync-569949e2

delete time in 3 days

pull request commentreactjs/ko.reactjs.org

Sync with reactjs.org @ 569949e2

#410 에서 처리하겠습니다

react-translations-bot

comment created time in 3 days

PR closed reactjs/ko.reactjs.org

Reviewers
Sync with reactjs.org @ 569949e2 beta

This PR was automatically generated.

Merge changes from reactjs.org at 569949e2

The following files have conflicts and may need new translations:

Please fix the conflicts by pushing new commits to this pull request, either by editing the files directly on GitHub or by checking out this branch.

DO NOT SQUASH MERGE THIS PULL REQUEST!

Doing so will "erase" the commits from main and cause them to show up as conflicts the next time we merge.

+183 -19

1 comment

9 changed files

react-translations-bot

pr closed time in 3 days

delete branch reactjs/ko.reactjs.org

delete branch : sync-b41b1dc3

delete time in 3 days

PR closed reactjs/ko.reactjs.org

Reviewers
Sync with reactjs.org @ b41b1dc3 beta

This PR was automatically generated.

Merge changes from reactjs.org at b41b1dc3

The following files have conflicts and may need new translations:

Please fix the conflicts by pushing new commits to this pull request, either by editing the files directly on GitHub or by checking out this branch.

DO NOT SQUASH MERGE THIS PULL REQUEST!

Doing so will "erase" the commits from main and cause them to show up as conflicts the next time we merge.

+177 -18

1 comment

7 changed files

react-translations-bot

pr closed time in 3 days

pull request commentreactjs/ko.reactjs.org

Sync with reactjs.org @ b41b1dc3

#410 에서 처리하겠습니다

react-translations-bot

comment created time in 3 days

delete branch modusign/odata-v4-parser

delete branch : fix/deps

delete time in 6 days

push eventmodusign/odata-v4-parser

Taehwan Noh

commit sha 2c25f7f1b3799a8816d9f372fa96e24aab65869d

chore: add missing dependency (#4)

view details

push time in 6 days

PR merged modusign/odata-v4-parser

chore: add missing dependency

Fixes #3

Improve the change in #2

+17680 -1631

0 comment

3 changed files

taehwanno

pr closed time in 6 days

issue closedmodusign/odata-v4-parser

The automated release is failing 🚨

:rotating_light: The automated release from the master branch failed. :rotating_light:

I recommend you give this issue a high priority, so other packages depending on you can benefit from your bug fixes and new features again.

You can find below the list of errors reported by semantic-release. Each one of them has to be resolved in order to automatically publish your package. I’m sure you can fix this 💪.

Errors are usually caused by a misconfiguration or an authentication problem. With each error reported below you will find explanation and guidance to help you to resolve it.

Once all the errors are resolved, semantic-release will release your package the next time you push a commit to the master branch. You can also manually restart the failed CI job that runs semantic-release.

If you are not sure how to resolve this, here are some links that can help you:

If those don’t help, or if this issue is reporting something you think isn’t right, you can always ask the humans behind semantic-release.


No Slack web-hook defined.

A Slack Webhook must be created and set in the SLACK_WEBHOOK environment variable on your CI environment.

Please make sure to create a Slack Webhook and to set it in the SLACK_WEBHOOK environment variable on your CI environment. Alternatively, provide slackWebhook as a configuration option.


Good luck with your project ✨

Your semantic-release bot :package::rocket:

<!-- semantic-release:github -->

closed time in 6 days

github-actions[bot]

PR opened modusign/odata-v4-parser

chore: add missing dependency

Improve the change in #2

+17680 -1631

0 comment

3 changed files

pr created time in 6 days

push eventmodusign/odata-v4-parser

Taehwan Noh

commit sha c022a8c8d5853a0e7c226e448c8292e7d90b56b2

chore: add missing dependency

view details

push time in 6 days

create barnchmodusign/odata-v4-parser

branch : fix/deps

created branch time in 6 days

PullRequestReviewEvent

push eventmodusign/odata-v4-parser

Taehwan Noh

commit sha 3d7c7d4040bd99d932a9f83053214cc508bce8c0

ci: improve npm dependency caching

view details

push time in 6 days

Pull request review commentmodusign/odata-v4-parser

fix: 문자열에 특수문자 사용이 가능하도록 개선

+name: CI++on:+  push:+    branches: [master]+  pull_request:+    branches: [master]++jobs:+  build:+    runs-on: ubuntu-latest+    strategy:+      matrix:+        node-version: [16.x]+    steps:+      - uses: actions/checkout@v2++      - name: Setup Node.js environment+        uses: actions/setup-node@v2+        with:+          node-version: ${{ matrix.node-version }}+          registry-url: https://npm.pkg.github.com/++      - uses: actions/cache@v2

setup-node의 cache 옵션 이용해서 의존성 캐싱 쉽게 할 수 있어서 개선해둘게용

Ref : https://github.com/actions/setup-node#caching-packages-dependencies

developer-spock

comment created time in 6 days

PullRequestReviewEvent
PullRequestReviewEvent

push eventmodusign/odata-v4-parser

Taehwan Noh

commit sha 48a0364590df363e77c8b667138e0db021fdfd32

style: append end of line

view details

Taehwan Noh

commit sha a9a5dd96b6b5e44bdcc4ea0c32b4bfecea3f7470

ci: fix setup-node action version

view details

push time in 6 days

Pull request review commentmodusign/odata-v4-parser

feat(odata-v4-parser): 문자열의 특수문자 사용이 가능 하도록 추가

+name: CI++on:+  push:+    branches: [master]+  pull_request:+    branches: [master]++jobs:+  build:+    runs-on: ubuntu-latest+    strategy:+      matrix:+        node-version: [16.x]+    steps:+      - uses: actions/checkout@v2++      - name: Setup Node.js environment+        uses: actions/setup-node@v2.1.4
        uses: actions/setup-node@v2

v2 최신 버전 자동으로 사용하도록 하시죵

developer-spock

comment created time in 6 days

PullRequestReviewEvent

Pull request review commentmodusign/odata-v4-parser

feat(odata-v4-parser): 문자열의 특수문자 사용이 가능 하도록 추가

+# Semantic Pull Requests (https://github.com/zeke/semantic-pull-requests)+#+# Always validate the PR title AND all the commits+titleAndCommits: true+# Allow use of Merge commits (eg on github: "Merge branch 'main' into feature/ride-unicorns")+# this is only relevant when using commitsOnly: true (or titleAndCommits: true)+allowMergeCommits: true+# Allow use of Revert commits (eg on github: "Revert "feat: ride unicorns"")+# this is only relevant when using commitsOnly: true (or titleAndCommits: true)+allowRevertCommits: true++types:+  - feat+  - fix+  - docs+  - style+  - refactor+  - perf+  - test+  - build+  - ci+  - chore+  - revert

자잘한건데 EOL 하나씩 추가해줄게염

developer-spock

comment created time in 6 days

PullRequestReviewEvent

pull request commentmodusign/odata-v4-parser

feat(odata-v4-parser): 문자열의 특수문자 사용이 가능 하도록 추가

feat은 semantic release에서 마이너 버전 변경을 의미하는데용, 지금 변화는 패치 버전을 올리는게 맞아 보여서 fix로 PR 제목 변경해둘게요!

developer-spock

comment created time in 6 days

pull request commentreactjs/ko.reactjs.org

Translate : 'writing markup with jsx' section

기여해주셔서 감사합니다

030ii

comment created time in 20 days

push eventreactjs/ko.reactjs.org

안녕하채영(HELLO)

commit sha faac99a8b4fa630c22561a390607ba3f7e13880f

Translate : 'writing markup with jsx' section (#393) * translate: the topic of [JSX: Putting markup into JavaScript] * translate: the rest of the topics * translate: remove English * translate: spelling check * Update beta/src/pages/learn/writing-markup-with-jsx.md Co-authored-by: Minsu Kim <alstn2468_@naver.com> * Update beta/src/pages/learn/writing-markup-with-jsx.md Co-authored-by: Gyuhyeon Sim <wallys0213@gmail.com> Co-authored-by: Minsu Kim <alstn2468_@naver.com> Co-authored-by: Gyuhyeon Sim <wallys0213@gmail.com>

view details

push time in 20 days

PR merged reactjs/ko.reactjs.org

Translate : 'writing markup with jsx' section beta

<!--

Thank you for the PR! Contributors like you keep React awesome!

Please see the Contribution Guide for guidelines:

https://github.com/reactjs/reactjs.org/blob/main/CONTRIBUTING.md

If your PR references an existing issue, please add the issue number below

-->

Progress

베타 문서 페이지 참고 링크 : https://beta.reactjs.org/learn/writing-markup-with-jsx

+46 -46

0 comment

1 changed file

030ii

pr closed time in 20 days

PullRequestReviewEvent

pull request commentreactjs/ko.reactjs.org

Translate : Rendering Lists

충돌 해결 부탁드리겠습니다 ㅎㅎ

jiseung-kang

comment created time in a month

Pull request review commentreactjs/ko.reactjs.org

Translate : Rendering Lists

 export const recipes = [{  </Sandpack> -Here, `<Recipe {...recipe} key={recipe.id} />` is a syntax shortcut saying "pass all properties of the `recipe` object as props to the `Recipe` component". You could also write each prop explicitly: `<Recipe id={recipe.id} name={recipe.name} ingredients={recipe.ingredients} key={recipe.id} />`.+여기서 `<Recipe {...recipe} key={recipe.id} />`는 “`recipe` 객체의 모든 속성을 props로 `Recipe` 컴포넌트로 전달”하는 손쉬운 문법입니다. `<Recipe id={recipe.id} name={recipe.name} ingredients={recipe.ingredients} key={recipe.id} />` 처럼 각 prop를 명시적으로 작성할 수도 있습니다. -**Note that the `key` is specified on the `<Recipe>` itself rather than on the root `<div>` returned from `Recipe`.** This is because this `key` is needed directly within the context of the surrounding array. Previously, you had an array of `<div>`s so each of them needed a `key`, but now you have an array of `<Recipe>`s. In other words, when you extract a component, don't forget to leave the `key` outside the JSX you copy and paste.+**`key`는 `Recipe`에서 반환된 루트 `<div>`가 아니라 `<Recipe>` 자체에 지정되어있음에 유의하세요.** 주변 배열의 context 내에서 `key`가 직접적으로 필요하기 때문입니다. 이전에는 배열에 `<div>` 태그가 있어서 각각에 대해 `key`가 필요했지만, 지금은 `<Recipe>` 배열이 있습니다. 즉, 컴포넌트를 추출할 때 복사 붙여넣기 한 JSX 외부에 `key`를 위치시켜야 한다는 것을 잊지 마세요.  </Solution> -### List with a separator {/*list-with-a-separator*/}+### 구분 기호가 있는 리스트 {/*list-with-a-separator*/} -This example renders a famous haiku by Katsushika Hokusai, with each line wrapped in a `<p>` tag. Your job is to insert an `<hr />` separator between each paragraph. Your resulting structure should look like this:+예시는 Katsushika Hokusai의 유명한 시 haiku를 렌더링하며 각 행은 `<p>` 태그로 래핑되어 있습니다. 각 단락 사이에 `<hr />` 구분 기호를 삽입하세요. 결과 구조는 다음과 같아야 합니다.

넵 좋습니다~ 다만 1089번 라인도 통일해서 하이쿠로 표현하는게 좋아보입니당

jiseung-kang

comment created time in a month

more