profile
viewpoint
If you are wondering where the data of this site comes from, please visit https://api.github.com/users/sylvestre/events. GitMemory does not store any data, but only uses NGINX to cache data for a period of time. The idea behind GitMemory is simply to give users a better reading experience.
Sylvestre Ledru sylvestre Mozilla Paris http://sylvestre.ledru.info/ Director at @mozilla , @Debian / Ubuntu Developer, LLVM/Clang committer, etc

llvm/llvm-project 10424

The LLVM Project is a collection of modular and reusable compiler and toolchain technologies. Note: the repository does not accept github pull requests at this moment. Please submit your patches at http://reviews.llvm.org.

llvm-mirror/llvm 4447

Project moved to: https://github.com/llvm/llvm-project

llvm-mirror/clang 2860

Mirror kept for legacy. Moved to https://github.com/llvm/llvm-project

llvm-mirror/libcxx 684

Project moved to: https://github.com/llvm/llvm-project

llvm-mirror/lldb 416

Project moved to: https://github.com/llvm/llvm-project

llvm-mirror/clang-tools-extra 368

Mirror kept for legacy. Moved to https://github.com/llvm/llvm-project

llvm-mirror/compiler-rt 276

Project moved to: https://github.com/llvm/llvm-project

llvm-mirror/lld 196

Project moved to: https://github.com/llvm/llvm-project

llvm-mirror/openmp 137

Mirror kept for legacy. Moved to https://github.com/llvm/llvm-project

llvm-mirror/polly 86

Mirror kept for legacy. Moved to https://github.com/llvm/llvm-project

push eventsylvestre/gecko-dev

owlishDeveloper

commit sha 7acebc65af0cbb7650ff7b0e865269a6a71de05c

Bug 1697866 - Add HTTPS-only specific error code and pass it to GeckoView, to handle HTTPS-only specific errors correctly r=agi,JulianWels,nika,ckerschb Differential Revision: https://phabricator.services.mozilla.com/D120914

view details

Jonathan Kew

commit sha 2cfc8b951364c9b7429294411b199fa2b62b48f8

Bug 1719544 - part 1 - Add low-level normalization-data accessors ComposePairNFC and DecomposeRawNFD to mozilla::intl::String. r=platform-i18n-reviewers,dminor Differential Revision: https://phabricator.services.mozilla.com/D126259

view details

Jonathan Kew

commit sha 71ac7ba47456d52d968ade8bfbfffcc22700db71

Bug 1719544 - part 2 - Convert gfxHarfBuzzShaper normalization callbacks from direct ICU access to mozilla::intl::String APIs. r=platform-i18n-reviewers,dminor Depends on D126259 Differential Revision: https://phabricator.services.mozilla.com/D126260

view details

Stephen A Pohl

commit sha a3dbfef293dbf31e23499bf02e1a8200b4f4ce07

Bug 1419375: Ensure that window control buttons on macOS appear correctly when the system locale is RTL since the fullscreen and close buttons are reversed in RTL. r=mstange Differential Revision: https://phabricator.services.mozilla.com/D120109

view details

Stephen A Pohl

commit sha 87f63ab1b8351adc0249587b28aba05865eef45a

Bug 1633860: Place window control buttons on the right side on macOS when using an RTL system locale, regardless of the Firefox locale. r=mstange,emilio,harry Differential Revision: https://phabricator.services.mozilla.com/D116921

view details

Gijs Kruitbosch

commit sha 8fe353f4c1bb5d9dac75dea1372b47eed6c49dd3

Bug 1731774 - fix download blocked badge colour in dark themes, r=mtigley Differential Revision: https://phabricator.services.mozilla.com/D126323

view details

Mike Conley

commit sha 0861ac02ec87a270c201bf928d1caeb0dc91b748

Bug 1730042 - Bump expiry of about:home startup cache probes. data-review=mmccorquodale, r=Gijs Differential Revision: https://phabricator.services.mozilla.com/D126378

view details

Mike Conley

commit sha 0317f92eb3378b9d895bf0a2dc3f3c0f81453a81

Bug 1730041 - Bump expiry on tab closing probes. data-review=mmccorquodale, r=Gijs Differential Revision: https://phabricator.services.mozilla.com/D126385

view details

Sean Feng

commit sha a1b9c83581711c88d8507c6a48614a57b45f0b1c

Bug 1731831 - Rename timedChannel to timedChannelInfo for ReplacementChannelConfig r=dragana,necko-reviewers `timedChannel` is wrong because it implies it is a channel, however it is in fact a `TimedChannelInfo`. Differential Revision: https://phabricator.services.mozilla.com/D126254

view details

Jan Varga

commit sha a294b48418d93eef342565ad001741c18d99942a

Bug 1722668 - Implement nsIQuotaManagerService::getFullOriginMetadata; r=dom-storage-reviewers,jari Differential Revision: https://phabricator.services.mozilla.com/D125168

view details

Jan Varga

commit sha 6e2ea3fb58f9d4165bd822c1eb44d4f42899a24c

Bug 1722668 - Add test_unsetLastAccessTime.js for the case when quota information is cached; r=dom-storage-reviewers,jari Differential Revision: https://phabricator.services.mozilla.com/D125169

view details

Mike Kaply

commit sha d48bcd22acf52bfedef3a5dbe8bb31604d80794a

Bug 1732131 - Allow security.tls.enable_0rtt_data via policy. r=emalysz Differential Revision: https://phabricator.services.mozilla.com/D126368

view details

criss

commit sha 7f1d028a6fede86b04618c321d3b9ab7ce0c18b5

Bug 1722668 - Fix lint failure r=fix

view details

criss

commit sha 6685fa570db2278d418472d7301c57ed2a188b83

Backed out 2 changesets (bug 1719544) for causing bustages on gtest.h:1445:11. CLOSED TREE Backed out changeset 4ab330369412 (bug 1719544) Backed out changeset b5d8d32d8326 (bug 1719544)

view details

Julian Descottes

commit sha 3e3571444a8cd8ff53ae32deb5b652e55e51a881

Bug 1729553 - [devtools] Fallback on x86_64 adb binaries on Darwin + arm64 r=bomsy We already fallback on x86 for aarch64 for adb binaries. Update this logic to also fallback on x86_64 for arm64. This will allow to support m1 apple machines. Differential Revision: https://phabricator.services.mozilla.com/D126314

view details

Katherine Patenio

commit sha d2129b2d30f1ef2201727de9aa04d81f21802396

Bug 1731381 - remove brandProductName properties for Fluent migration r=fluent-reviewers,flod,mtigley Differential Revision: https://phabricator.services.mozilla.com/D126027

view details

Brendan Dahl

commit sha 8092a892047c18c1dd37a758d97e046e33075e75

Bug 1732117 - Update pdf.js to version 2.11.283 r=pdfjs-reviewers,calixte Differential Revision: https://phabricator.services.mozilla.com/D126363

view details

Jeff Muizelaar

commit sha c17a2525236dc1e9c4507e314b013c2b73fa353d

Bug 1728423 - Migrate display list building time metric to glean. r=chutten,miko Differential Revision: https://phabricator.services.mozilla.com/D124124

view details

Kimberly Sereduck

commit sha 9241c7d5172a2255051d4694105d766ba65d55b7

Bug 1731657: Update facebook warm page load test to navigate to sub-page rather than about:blank r=perftest-reviewers,AlexandruIonescu Differential Revision: https://phabricator.services.mozilla.com/D126129

view details

Noemi Erli

commit sha 50d4e6c8787d64e62e285fd885e2aab3dd04c786

Backed out changeset 890d147bad1d (bug 1697866) for causing bustages in WindowGlobalParent.cpp CLOSED TREE

view details

push time in 11 hours

push eventllvm/llvm-project

Mike Hommey

commit sha 08ef24f6abdfaee038c47e3fe0b61b40e8fd9053

Wrap xar/xar.h include in extern "C" block Without such wrapping, linking lld fails with missing symbols because of C++ symbol mangling with older versions of the MacOSX SDK, in which xar.h doesn't have an extern "C" block itself. Reviewed By: #lld-macho, thakis Differential Revision: https://reviews.llvm.org/D110224

view details

push time in a day

push eventsylvestre/gecko-dev

Tooru Fujisawa

commit sha 9eaf31ee8f2275a9f0c73060f5739788770e1f8b

Bug 1718711 - Part 1: Remove stale requirement around saveIncrementalBytecode and assertEqBytecode. r=nbp assertEqBytecode couldn't be used with saveIncrementalBytecode because we were merging at decode timing. Bug 1687095 changed it to merge before encoding, and the resulting XDR buffer becomes same between incremental encode and re-encode. Differential Revision: https://phabricator.services.mozilla.com/D121262

view details

Tooru Fujisawa

commit sha 12de1bb33c34526ebff936baf13f30d6e52dc266

Bug 1718711 - Part 2: Fix help comment for compileToStencil. r=nbp Differential Revision: https://phabricator.services.mozilla.com/D121263

view details

Tooru Fujisawa

commit sha 30af321bc51bf35023d6abe8da6451ca89fd45b6

Bug 1718711 - Part 3: Add module option to compileToStencil. r=nbp Differential Revision: https://phabricator.services.mozilla.com/D121264

view details

Tooru Fujisawa

commit sha 838d8f3d95103471677e0187f51681ba1c2df808

Bug 1718711 - Part 4: Use compileToStencilXDR instead of codeModule. r=nbp Differential Revision: https://phabricator.services.mozilla.com/D121265

view details

Tooru Fujisawa

commit sha 179dc1309fbb8f34b7cdf2e3e78f412bbddbdde6

Bug 1718711 - Part 5: Remove codeModule/decodeModule shell functions. r=nbp Differential Revision: https://phabricator.services.mozilla.com/D121266

view details

Sandor Molnar

commit sha bf98cdbcb80223434dcccc42f17ae28d55108951

Backed out 5 changesets (bug 1718711) for causing multiple failures in xdr/module-oom.js. CLOSED TREE Backed out changeset 73bf3a3d829a (bug 1718711) Backed out changeset 429677b09999 (bug 1718711) Backed out changeset 32023146b793 (bug 1718711) Backed out changeset 75eac408c699 (bug 1718711) Backed out changeset 48fdf77fbc02 (bug 1718711)

view details

Nazım Can Altınova

commit sha de9c3115116a873d8a40fec53c6816859233d066

Bug 1654413 - Rerun the profiler API build.rs when the included header files are changed r=emilio For some reason, I thought that `parse_callbacks(Box::new(CargoCallbacks))` would also automatically adds the initial header files that are manually added. But apparently `parse_callbacks` is only executed when the inner included header files are found. Differential Revision: https://phabricator.services.mozilla.com/D124017

view details

Nazım Can Altınova

commit sha 53a1965f9e0aa96a5587c0bb11e5349c5d1bb8b5

Bug 1654413 - Add ProfilerTime Rust struct for marker API r=emilio,gerald This will be used to get the time from profiler, so marker API can use it to understand the start or end time. Differential Revision: https://phabricator.services.mozilla.com/D124018

view details

Nazım Can Altınova

commit sha 2957052aa811335fd24a4dd4407c4e67f8a6d304

Bug 1654413 - Add a small gecko_profiler_category macro as a sugar for marker categories r=emilio This is a syntactical sugar to write the categories more easily. I prefer to have this macro because this is the same syntax as the categories in the label frames API. Differential Revision: https://phabricator.services.mozilla.com/D124019

view details

Nazım Can Altınova

commit sha 7ec023dfe3eacc049b9704e259c9a5cf3a1ae78e

Bug 1654413 - Add a MarkerTiming and MarkerOptions Rust structs for the marker API r=emilio,gerald These structs are needed for the marker APIs. We also have the same structs as the C++ classes. See `mozilla::MarkerTiming` and `mozilla::MarkerOptions`. Differential Revision: https://phabricator.services.mozilla.com/D124020

view details

Nazım Can Altınova

commit sha 7f96087d60ee3efed6a6aa9356221441a34c69ed

Bug 1654413 - Add a MarkerStack Rust enum for the marker API r=emilio,gerald MarkerStack object is a bit more complex in the C++ side. But we don't need a complex object like that in here. A simple enum is enough to determine what type of marker stack we are capturing. C++ side will be handling the capturing of the stack. Differential Revision: https://phabricator.services.mozilla.com/D124021

view details

Nazım Can Altınova

commit sha 02f9877e83d5c753424e334cf180f116032fd1f2

Bug 1654413 - Add add_untyped_marker Rust API r=emilio,gerald This is the first and simplest API for the markers. There will be two more APIs in the following patches (add_text_marker and add_marker). You can see the PROFILER_MARKER_UNTYPED macro for the C++ counterpart. Differential Revision: https://phabricator.services.mozilla.com/D124022

view details

Nazım Can Altınova

commit sha 978dbc8ab8e348f7d9139c1e6b3b4d034027887a

Bug 1654413 - Add add_text_marker Rust API r=emilio,gerald This is the second API for the markers. This allows one payload as a text for more information. See the PROFILER_MARKER_TEXT macro for the C++ counterpart. Differential Revision: https://phabricator.services.mozilla.com/D124023

view details

Nazım Can Altınova

commit sha c850585eae6ce0c43dc4f42015c4cab7412d9b6d

Bug 1654413 - Add JSONWriter struct for marker schema r=emilio,gerald JSON writer will be used for the third and last marker API. This is needed because we need to describe a marker payload struct on how to serialize it. Differential Revision: https://phabricator.services.mozilla.com/D124024

view details

Nazım Can Altınova

commit sha a5b9cfdadb75914b2eca850f50ac42f310f73777

Bug 1654413 - Add MarkerSchema struct and its enums for marker API r=emilio,gerald You can see the `mozilla::MarkerSchema` for the C++ counterpart. This Rust struct simply wraps the C++ object and keeps the reference of it as RAII. This heap allocates the inner C++ object but it's fine to do it here, because it's we only create a MarkerSchema object at the end of a profiling session and it happens once per marker type. It should be very rare. Differential Revision: https://phabricator.services.mozilla.com/D124025

view details

Nazım Can Altınova

commit sha ca180f8629a6db850b9f1fafefe6445cb3e44542

Bug 1654413 - Add add_marker Rust profiler API and serialize the marker to the buffer r=emilio,gerald This only adds the API and then adds the profiler payload to the buffer. The deserialization and streaming will happen in the next patch. Differential Revision: https://phabricator.services.mozilla.com/D124026

view details

Nazım Can Altınova

commit sha a15be90d61e57ce7865974d4b842dd024a242bb0

Bug 1654413 - Deserialize and stream the markers and marker schemas r=emilio,gerald Now we can deserialize and stream everything to the JSON. Differential Revision: https://phabricator.services.mozilla.com/D124027

view details

Jon Coppeard

commit sha 13d878dcbba0d455aabbf73592b069886e41b681

Bug 1731218 - Part 0: Remove unnecessary template from Rooted constructor r=sfink I don't think this does anything. The type is always present so we won't restrict use of this constructor by SFINAE, although I may have misunderstood the purpose of this. I tried 'fixing' the SFINAE to what I though it should be by using enable_if_t but it had the same effect as removing it. In both cases the code compiles, and if I try to construct a rooted with an inappropriate argument it fails with a sensible error. Differential Revision: https://phabricator.services.mozilla.com/D125949

view details

Jon Coppeard

commit sha 174d70460649707a6aaeafaece7d9b5fe131fbed

Bug 1731218 - Part 1: Rename rooting API base classes to 'Operations' in prepartion for adding base classes r=sfink These are really mixins used to add public methods based on the type and don't need to the base of an inheritance tree. Differential Revision: https://phabricator.services.mozilla.com/D125950

view details

Jon Coppeard

commit sha b3e8fa487ffd4ef3a9bbe7bbdf924c7a547dd03e

Bug 1731218 - Part 2: Give PersistentRooted a base class and use this refer to these roots when we don't know the type r=tcampbell This removes the need for a bunch of reinterpret_casts. Differential Revision: https://phabricator.services.mozilla.com/D125951

view details

push time in a day

push eventopencollab/llvm-jenkins.debian.net

Sylvestre Ledru

commit sha dfff8aa8ef9e726c7d28d63e00ad9567dc343779

add impish jobs

view details

Sylvestre Ledru

commit sha fc667c57c524c3c042947823264635bc1bdd8711

new jenkins versions

view details

push time in 2 days

Pull request review commentuutils/coreutils

`ls`: add support for showing SELinux context (--context/-Z)

 fn display_symlink_count(_metadata: &Metadata) -> String { fn display_symlink_count(metadata: &Metadata) -> String {     metadata.nlink().to_string() }++// This returns the SELinux security context as UTF8 `String`.+// In the long term this should be changed to `OsStr`, see discussions at #2621/#2656+fn get_security_context(config: &Config, p_buf: &PathBuf, must_dereference: bool) -> String {

Feels free to silent the warning if it increases the complexity

jhscheer

comment created time in 2 days

PullRequestReviewEvent
PullRequestReviewEvent

Pull request review commentuutils/coreutils

`ls`: add support for showing SELinux context (--context/-Z)

 fn display_symlink_count(_metadata: &Metadata) -> String { fn display_symlink_count(metadata: &Metadata) -> String {     metadata.nlink().to_string() }++// This returns the SELinux security context as UTF8 `String`.+// In the long term this should be changed to `OsStr`, see discussions at #2621/#2656+fn get_security_context(config: &Config, p_buf: &PathBuf, must_dereference: bool) -> String {

you have some warnings here :)

jhscheer

comment created time in 2 days

PullRequestReviewEvent

Pull request review commentuutils/coreutils

`chroot`: quick fix for #2687

 fn test_preference_of_userspec() {     println!("result.stdout = {}", result.stdout_str());     println!("result.stderr = {}", result.stderr_str()); }++#[test]+fn test_default_shell() {+    // NOTE: This test intends to trigger code which can only be reached with root permissions.+    let ts = TestScenario::new(util_name!());+    let at = &ts.fixtures;++    let dir = "CHROOT_DIR";+    at.mkdir(dir);++    let shell = std::env::var("SHELL").unwrap_or_else(|_| "/bin/sh".to_string());+    let expected = format!(

could you please fix this warning?

jhscheer

comment created time in 2 days

push eventsylvestre/gecko-dev

Tom Ritter

commit sha c41133e5b2b153629d0393b5c50ca4cf9d6ecb10

Bug 1730959: Provide a level for logging.disable in mach vendor r=jewilde Differential Revision: https://phabricator.services.mozilla.com/D125741

view details

Tom Ritter

commit sha c630db4497a65406023a7e5f5b73c242bc9a0fc3

Bug 1700396 - Bump updatebot for the comment length fix r=jewilde Differential Revision: https://phabricator.services.mozilla.com/D126118

view details

Tom Ritter

commit sha 507252d29e420e04aac4e7efbe28707dab4c4acb

Bug 1731357: Enable the updatebot verification job on autoland r=bhearsum Differential Revision: https://phabricator.services.mozilla.com/D126011

view details

Byron Campen

commit sha 1a3c093ae02da288b4a8ab4b7ff1ccae91124060

Bug 1693804: Re-enable these tests on linux. r=ng Differential Revision: https://phabricator.services.mozilla.com/D126098

view details

Lee Salzman

commit sha 5712e001aaf415935701d077bbf444eed7202cd4

Bug 1731636 - Guard against failed BufferData when loading vertex attributes in SWGL. r=nical Differential Revision: https://phabricator.services.mozilla.com/D126119

view details

Ben Hearsum

commit sha a2883c096872724913e4c0b027afd00451bcf28b

No bug: backout rerun-pr action because it cannot be made to work in a reasonable fashion. r=releng-reviewers,aki Differential Revision: https://phabricator.services.mozilla.com/D126123

view details

Alex Lopez

commit sha f9280b82f8aca63791c03c3cb9de22466f582657

Bug 1696251: Rename setup to avoid name conflict when declassing mach commands. r=mhentges,perftest-reviewers,AlexandruIonescu Differential Revision: https://phabricator.services.mozilla.com/D126035

view details

Francesco Lodolo (:flod)

commit sha cb963e1cc50379c086907c9ea34fbddbfa7aca40

Bug 1731528 - Add Santali (sat) to Nightly builds, r=firefox-build-system-reviewers,mhentges Differential Revision: https://phabricator.services.mozilla.com/D126066

view details

Harry Twyford

commit sha 42b741a2fd7c2c2d5c6e7336c55b54b03d01c3fa

Bug 1730262 - Add first monochromatic theme. r=desktop-theme-reviewers,dao,mixedpuppy Differential Revision: https://phabricator.services.mozilla.com/D125283

view details

Sean Feng

commit sha c01f1a8018e35329dd7cbf37f2d172f5fb9c2706

Bug 1729342 - Use delegatesFocus for <input type=date/time/datetime-local> widget r=emilio Currently datetimebox uses some hardcoded logic to find the edit field inside the shadow tree and focus it. Since we have delegatesFocus implemented, we could just use it without these logic. Differential Revision: https://phabricator.services.mozilla.com/D125440

view details

Brad Werth

commit sha 8313bf8e70cca9bb4593859e14d1d0da64146e71

Bug 1653417 Part 1: Define a pref for specialized video layers on macOS. r=gfx-reviewers,jrmuizel If this pref is set, native layers will use a specialized video layer api for fullscreen video content, which will reduce power consumption. It will do this by isolating the fullscreen video layer from other layers. It may also remove non-video content accompanying the fullscreen video. Content behind the video *will* be replaced with a black fullscreen rectangle. Future bugs will aim to reduce this side effect. Differential Revision: https://phabricator.services.mozilla.com/D124999

view details

Molly Howell

commit sha 92fc13dacf6c6dd1b755dec9073da30eeff82110

Bug 1724319 - Fix toolkit downloads component tests for when new download changes are enabled. r=mtigley Differential Revision: https://phabricator.services.mozilla.com/D125901

view details

Molly Howell

commit sha d8d823a0e537ba2dc63a40cc50a6456dd12f319b

Bug 1730835 - Prevent toolbarbuttons used as menu items from aligning to the center of the menu. r=desktop-theme-reviewers,dao Differential Revision: https://phabricator.services.mozilla.com/D125751

view details

Brad Werth

commit sha 1a1a751ea15b5b6148ee275b99ae8b5a60a689f3

Bug 1653417 Part 2: Make nsCocoaWindow notify its native layer when toggling fullscreen. r=gfx-reviewers,mstange This allows the native layer code to determine when specialized video layers might be beneficial for reducing power consumption. Differential Revision: https://phabricator.services.mozilla.com/D124149

view details

Brad Werth

commit sha 8b0ed5b62c216a9880c2be869b8b89b02982e34c

Bug 1653417 Part 3: Convert NativeLayerCA::Representation flags to use a bitfield. r=gfx-reviewers,mstange The size of the NativeLayerCA::Representation struct seems to be a factor in the power consumption of native layer updates. Converting this series of bools into a bitfield is an easy way to reduce the structure size. Differential Revision: https://phabricator.services.mozilla.com/D124992

view details

Brad Werth

commit sha 32624d8ae8440c731f28a988b418999682443f8f

Bug 1653417 Part 4: Add scaffolding for NativeLayerCA to specialize video layers. r=gfx-reviewers,mstange This is scaffolding for checking the conditions where the specialized video layers will reduce power consumption. In the next part, we'll actually create and fill the specialized layers. Differential Revision: https://phabricator.services.mozilla.com/D107292

view details

Brad Werth

commit sha 2931358d79fffa3c66bca2cfbabe8b7a573d79de

Bug 1653417 Part 5: Make NativeLayerCA use AVSampleBufferDisplayLayers for video. r=gfx-reviewers,mstange This patch reconstitutes a CMSampleBuffer from an IOSurface using spoofed timing information to display the single sample immediately. Using this method is neccessary, but not sufficient for the video display layer to be detached and use less power. The remaining requirements are covered by later parts of this patch series. Differential Revision: https://phabricator.services.mozilla.com/D116643

view details

Brad Werth

commit sha fb11266988e100da091fa25cb511e4c676fca1e4

Bug 1653417 Part 6: Make NativeLayerRootCA attempt to isolate video layers. r=gfx-reviewers,jrmuizel This is another requirement for the video display layer to be detached and use less power: the layer must be topmost and have only a black layer behind it. Differential Revision: https://phabricator.services.mozilla.com/D124150

view details

lamoure6

commit sha a4e720c69d07f2ff0c248057ee3c8742e038bee0

Bug 1719938 - Removed remaining (non-negated) -moz-proton media queries. r=mhowell,mtigley,emilio Differential Revision: https://phabricator.services.mozilla.com/D125328

view details

Edgar Chen

commit sha d10e28e07274caec83de317f95b51f1ffbcee655

Bug 1730117 - Part 1: Make sync XHR suppress event handling for the nested in-process documents; r=smaug Differential Revision: https://phabricator.services.mozilla.com/D125187

view details

push time in 2 days

Pull request review commentuutils/coreutils

`ls`: add support for showing SELinux context (--context/-Z)

 impl PathData {             None => OnceCell::new(),         }; +        let substitute_string = "?".to_string();+        let security_context = if config.context {+            if config.selinux_supported {+                #[cfg(feature = "selinux")]+                {+                    match selinux::SecurityContext::of_path(&p_buf, must_dereference, false) {

what do you think about moving this block into a new function to simplify a bit the code?

jhscheer

comment created time in 3 days

PullRequestReviewEvent

push eventllvm/llvm-project

Sylvestre Ledru

commit sha eccd477ce312c54e317876ca714c661325f3e318

Add CMAKE_BUILD_TYPE to the list of BOOTSTRAP_DEFAULT_PASSTHROUGH variables When building clang in stage2, when -DCMAKE_BUILD_TYPE=RelWithDebInfo is set, the developer can expect that the stage2 clang is built using the same mode. Especially as the performances are much worst in debug mode. (Principle of least astonishment) Differential Revision: https://reviews.llvm.org/D53014

view details

push time in 3 days

delete branch sylvestre/coreutils

delete branch : more-dep-cleanup

delete time in 3 days

push eventsylvestre/gecko-dev

Bas Schouten

commit sha 469ae763544f8d1daf1e01213997905c007e3df9

Bug 1730772: Do not use GDI classic rendering when rendering Canvas. r=jfkthame,jrmuizel Differential Revision: https://phabricator.services.mozilla.com/D125982

view details

David Parks

commit sha 50cd921be04c42b8aeb8c353fce35f518a4e47df

Bug 1643936: Fix vtable for Windows IVirtualDesktopManager r=cmartin Differential Revision: https://phabricator.services.mozilla.com/D125348

view details

Alexandre Lissy

commit sha 05968f9966a0880ff6c4b4d7c0ed805a6e130876

Bug 1730045 - Update expiration of buildID mismatch probe r=jld Differential Revision: https://phabricator.services.mozilla.com/D125790

view details

Lars T Hansen

commit sha 11e3475a50014c555feae92d4add17a9db7888a9

Bug 1727254 - Simplify i32 multiply in baseline compiler. r=yury The baseline compiler previously assumed that the multiplication instruction that was emitted for mul32() was the very old-fashioned 32x32->64 instruction that requires the input in eax and clobbers edx. This is not so; the chip has a general GPR1 *= GPR2 instruction that has none of these problems when using the two-argument form of mul32(). So simplify. Differential Revision: https://phabricator.services.mozilla.com/D125961

view details

Lars T Hansen

commit sha 3fd2173adeb6a164ce025c36913f593edd68bc55

Bug 1727254 - Simplify i64 multiply in baseline compiler. r=yury The x64 case for multiplication does not need to 'reserve rdx' for its operation, the chip has a fine GPR1 *= GPR2 instruction that does not have any clobbering effects on other registers. The x86 case can be cleaned up slightly but remains special, for now. Differential Revision: https://phabricator.services.mozilla.com/D125962

view details

Lars T Hansen

commit sha 306f63401cc23072135edbbbfaed3ee28f489cbb

Bug 1727254 - Remove implicit edx argument to quotient32 and remainder32. r=yury Two related fixes here: The implicit edx argument to quotient32 and remainder32 on x86 and x64 is made explicit. Then the baseline compiler is adapted to deal with that, resulting in some desirable cleanup in the process: the logic that allocates registers and the logic that uses registers are moved textually closer together, following the pattern recently introduced in WasmBCMemory.cpp. Differential Revision: https://phabricator.services.mozilla.com/D125963

view details

Lars T Hansen

commit sha 3637a4545ad3a201198f56ccefb487297c0c7568

Bug 1727254 - Tidy up i64 divide in baseline compiler. r=yury Tidy up a few names and ifdefs and move code that depends on specific register assignments closer to the code performing the allocation, following the pattern established by i32 divide. Differential Revision: https://phabricator.services.mozilla.com/D125964

view details

Lars T Hansen

commit sha e4c8acdc6c8c22d63741238763404845a6b97c55

Bug 1727254 - Introduce template to capture pattern common to all divide instructions in baseline compiler. r=yury All the divide instructions have common patterns for checking for division-by-zero and overflow. These patterns can be captured using a template + static functions for emitting the actual code. Differential Revision: https://phabricator.services.mozilla.com/D125965

view details

Andreas Pehrson

commit sha 144d6103122eede59fd7a5aa420df1a92cfe8adb

Bug 1729364 - Before validating stats await *new* rtcp packets *after* media flows. r=ng,jib Differential Revision: https://phabricator.services.mozilla.com/D124917

view details

Jon Coppeard

commit sha 5bf7e704923c707ac89da6fb95f83aa3e140e0c7

Bug 1601228 - Move GC sweeping implementation to a new source file r=sfink Differential Revision: https://phabricator.services.mozilla.com/D125980

view details

Nicolas Chevobbe

commit sha f1c59fa2b83d8538d594a568d67adca109a9e765

Bug 1688445 - [devtools] Fix browser/browser_window_close.js intermittent. r=jdescottes. The test seemed to fail because the page was already loaded when we started awaiting for `BrowserTestUtils.browserLoaded`. This patch removes it and instead pass an `url` param to `BrowserTestUtils.waitForNewWindow`, which means we'll wait for the page to be loaded. Differential Revision: https://phabricator.services.mozilla.com/D126063

view details

Kershaw Chang

commit sha 519e179d25aa9414bc38cf453f113dbaa2312336

Bug 1731192 - Enable "network.send_ODA_to_content_directly" by default, r=necko-reviewers,dragana Differential Revision: https://phabricator.services.mozilla.com/D125930

view details

Olli Pettay

commit sha f083f381d8dfe6089a539a207944f528a34eb3bb

Bug 1727514 - media playback should stop in the bfcache, r=peterv This version doesn't change SetContainer handling, since it seems to be tricky for the top level page. So only activity change notification is fired and IsActive() is updated. The comment about IsActive() was wrong even with the old bfcache implementation. (I did check that it returned false when the page was in bfcache and many of the activity observers rely on that) The changes to HTMLMediaElement are needed to ensure page can enter bfcache.. Differential Revision: https://phabricator.services.mozilla.com/D124684

view details

Frederik Braun

commit sha 4c092a56f59b8f7dc746fd6af23dd293fb1165d3

Bug 1731025 - systemprincipal telemetry for userChrome.css profiles (and avoid racing with pref checks) r=ckerschb,tjr Differential Revision: https://phabricator.services.mozilla.com/D125804

view details

Sylvestre Ledru

commit sha ae9b67173741121bdc67c490df7d50fb9d80c7b1

no bug - doc: move the text on the same line to fix some weird presentation r=marco DONTBUILD Differential Revision: https://phabricator.services.mozilla.com/D126073

view details

Sebastian Hengst

commit sha 00a4a306b13c93ea467bf01464f9e9fd6346de01

Bug 1731407 - set secure context test step in shared-array-buffers/blob-data.https.html as passing DONTBUILD This passes since bug 1660452 landed. Differential Revision: https://phabricator.services.mozilla.com/D126075

view details

Marian-Vasile Laza

commit sha 2dcd85644c23ad4459b15c6ac80c8079aa51a1a4

Backed out changeset a445650b1858 (bug 1730534) for conflicts with backout of Bug 1536061. a=backout

view details

Marian-Vasile Laza

commit sha cf90d36979cc9c411cea50fadedfb12df827908b

Merge autoland to mozilla-central. a=merge

view details

Marian-Vasile Laza

commit sha 889ce29976aaf8ba3afa27d51f35238b3adc7314

Merge mozilla-central to autoland. a=merge CLOSED TREE

view details

Emilio Cobos Álvarez

commit sha 9b0fa46c6825a70b8d728287856db7a88e08abba

Bug 1727399 - When style updates font information, make sure to invalidate style asynchronously. r=jfkthame Some style system APIs (like StyleNewSubtree) don't deal with nested restyles really well (it'd be weird if StyleNewSubtree would end up styling not only that subtree but the whole document). To prevent breaking style system invariants, make sure to invalidate the style asynchronously using an early runner. This should ensure at most one frame of wrong metrics, but usually zero. Differential Revision: https://phabricator.services.mozilla.com/D126076

view details

push time in 3 days

pull request commentuutils/coreutils

tests/util: add a convenience wrapper to run a ucmd with root permissions

Fails with:


failures:

---- common::util::tests::test_run_ucmd_as_root stdout ----
current_directory_resolved: 
run: sudo -E --non-interactive whoami
thread 'common::util::tests::test_run_ucmd_as_root' panicked at 'called `Result::unwrap()` on an `Err` value: Os { code: 2, kind: NotFound, message: "No such file or directory" }', tests/common/util.rs:965:14
jhscheer

comment created time in 4 days

push eventsylvestre/review

Sylvestre Ledru

commit sha 85198845e4abc9181f349a27da8f9b508f83f2fe

Remove "arc_last_check" from the default configuration

view details

push time in 4 days

PR opened mozilla-conduit/review

Remove references to "arc" in the doc

Please use Phabricator to submit changes. You can do that by calling moz-phab.

+0 -18

0 comment

1 changed file

pr created time in 4 days

push eventsylvestre/review

Sylvestre Ledru

commit sha ea0633716e6c4b43f40bd9f76ef480f8d9f7541a

Remove references to "arc" in the doc

view details

push time in 4 days

push eventsylvestre/gecko-dev

Itiel

commit sha 6051ff17be270e6e1932040585f5451784e7277d

Bug 1731144 - Improve theming in about:config r=mconley Differential Revision: https://phabricator.services.mozilla.com/D125885

view details

Daniel Holbert

commit sha 5c8ea5d84b8d1a4c07898195e2fcb6fc4cf29ffc

Bug 1731371: Remove REQUIRES_UNIFIED_BUILD declaration from layout subdirectories that don't need it. r=emilio Differential Revision: https://phabricator.services.mozilla.com/D126014

view details

Jan Alexander Steffens (heftig)

commit sha 13378066961f195595822d4f543c8ac5b7f46490

Bug 1731495 - Don't typecheck the pipewire session_handle. r=rmader Since xdg-desktop-portal 1.10.0, the type is "o" (an object path string) instead of "s" (a normal string). g_variant_lookup fails if the type doesn't match exactly, even though both are strings. Use g_variant_lookup_value to get the field value, telling it not to typecheck. Use g_variant_dup_string to extract the string, which doesn't care about the exact type, so this code should work with all versions of xdg-desktop-portal. Following a similar fix to OBS, see https://github.com/obsproject/obs-studio/commit/ef0540c0d7df. Differential Revision: https://phabricator.services.mozilla.com/D126053

view details

Sylvestre Ledru

commit sha 8268b7fc3c6398a4fc44747090ab87fdc7e8365c

update renovate

view details

push time in 4 days

push eventuutils/coreutils

Jan Verbeek

commit sha 9d5133157ae70da60eb9c30553c9e3cf1ac120d2

uucore::fsext: Replace some unsafe calls GetLastError() and libc::stat() were unnecessary as libstd offered equivalents. LPWSTR2String() was technically unsafe if passed a slice without zeroes, but it's a private function and was probably always called correctly in practice.

view details

Jan Verbeek

commit sha 8cfe0290cd142946de7337187d94a31ee636631a

uucore::fsext: Avoid unnecessary allocations

view details

Jan Verbeek

commit sha cc652c7fe9b0fb64e388408f846fb0dc09bd3257

uucore::mode: Add notes about umask and platform support

view details

Jan Verbeek

commit sha 601ea3ef1918feb1bb69687a6b43c091cc9f4e13

uucore::process: Add a few notes

view details

Sylvestre Ledru

commit sha a0f538f2e811bfe09ce0a975189aaf7b41765938

Merge pull request #2679 from blyxxyz/uucore-inspection uucore: Minor cleanup

view details

push time in 5 days

PR merged uutils/coreutils

uucore: Minor cleanup
  • Replace some unsafe code in fsext
  • Avoid some unnecessary copies
  • Add notes about safety considerations and platform support
+41 -33

0 comment

5 changed files

blyxxyz

pr closed time in 5 days

push eventuutils/coreutils

Raphaël Thériault

commit sha 6931dd11f1fd6e0526003b5704b4d6442548f776

Use non-yanked version of digest crate in hashsum

view details

Sylvestre Ledru

commit sha 629e446da4a6dd17eb31b93990719cd3d297677e

Merge pull request #2691 from raftario/yanked-digest Use non-yanked version of digest crate in hashsum

view details

push time in 5 days

PR merged uutils/coreutils

Use non-yanked version of digest crate in hashsum

Fixes #2690

+3 -3

2 comments

2 changed files

raftario

pr closed time in 5 days

issue closeduutils/coreutils

digest 0.6.2 yanked

It's currently impossible to build the utils because hashsum depends on digest ^0.6.2, which has apparently been yanked from crates.io.

closed time in 5 days

raftario

pull request commentuutils/coreutils

Use non-yanked version of digest crate in hashsum

(to be clearer, I will take this patch, it is just that if you are motivated to upgrade the version, please do it :)

raftario

comment created time in 5 days

pull request commentuutils/coreutils

Use non-yanked version of digest crate in hashsum

I would have prefer and update to 0.7 or later

raftario

comment created time in 5 days

issue commentuutils/coreutils

digest 0.6.2 yanked

Interesting, I wonder what happened

raftario

comment created time in 5 days

pull request commentuutils/coreutils

`chroot`: quick fix for #2687

oh, just that passing 0 argument doesn't panic :) doesn't need more!

jhscheer

comment created time in 5 days