profile
viewpoint
遗忘
Scott Wolchok swolchok Facebook Menlo Park

phreeza/cells 224

a game where players programm agents that compete for resources in a simulated environment

schrockn-zz/fbjs-env 13

Scripts to create and keep an environment up-to-date with Facebook's JS best practices

swolchok/cells 6

a game where players programm agents that compete for resources in a simulated environment

swolchok/dspython 3

Fork of http://www.develer.com/~lmancini/dspython/ to hold fixes

swolchok/lark 1

An Arc-like language on top of Python. Implemented on a lark, hence the name.

swolchok/babel 0

Babel is a compiler for writing next generation JavaScript.

swolchok/bloaty 0

Bloaty McBloatface: a size profiler for binaries

swolchok/buildifier 0

A bazel BUILD file formatter and editor

swolchok/codemod 0

Codemod is a tool/library to assist you with large-scale codebase refactors that can be partially automated but still require human oversight and occasional intervention. Codemod was developed at Facebook and released as open source.

swolchok/componentkit 0

A React-inspired view framework for iOS.

fork swolchok/json

Strongly typed JSON library for Rust

fork in 2 months

issue commentfacebook/fishhook

iOS 13Crash

Can you please provide a full stacktrace (bt all in the debugger), the exact fishhook commit hash you are using, and more information about where and how often this repros? (simulator, device, both)

lucifer717

comment created time in 2 months

issue closedfacebookincubator/fastmod

Panic "out of bounds of"

$ cat b
#!/bin/bash
t () {
    echo bla;
    return $?
}

# Next command should have been: "fastmod '\$\?' '$?;' b" instead, but:

$ fastmod '\$?' '$?;' b
thread 'main' panicked at 'byte index 18446744073709551615 is out of bounds of `#!/bin/bash
t () {
    echo bla;
    return $?
}
`', src/libcore/str/mod.rs:2131:9
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

$ RUST_BACKTRACE=1 fastmod '\$?' '$?;' b
thread 'main' panicked at 'byte index 18446744073709551615 is out of bounds of `#!/bin/bash
t () {
    echo bla;
    return $?
}
`', src/libcore/str/mod.rs:2131:9
stack backtrace:
   0: backtrace::backtrace::libunwind::trace
             at /cargo/registry/src/github.com-1ecc6299db9ec823/backtrace-0.3.40/src/backtrace/libunwind.rs:88
   1: backtrace::backtrace::trace_unsynchronized
             at /cargo/registry/src/github.com-1ecc6299db9ec823/backtrace-0.3.40/src/backtrace/mod.rs:66
   2: std::sys_common::backtrace::_print_fmt
             at src/libstd/sys_common/backtrace.rs:77
   3: <std::sys_common::backtrace::_print::DisplayBacktrace as core::fmt::Display>::fmt
             at src/libstd/sys_common/backtrace.rs:59
   4: core::fmt::write
             at src/libcore/fmt/mod.rs:1052
   5: std::io::Write::write_fmt
             at src/libstd/io/mod.rs:1426
   6: std::sys_common::backtrace::_print
             at src/libstd/sys_common/backtrace.rs:62
   7: std::sys_common::backtrace::print
             at src/libstd/sys_common/backtrace.rs:49
   8: std::panicking::default_hook::{{closure}}
             at src/libstd/panicking.rs:204
   9: std::panicking::default_hook
             at src/libstd/panicking.rs:224
  10: std::panicking::rust_panic_with_hook
             at src/libstd/panicking.rs:472
  11: rust_begin_unwind
             at src/libstd/panicking.rs:380
  12: core::panicking::panic_fmt
             at src/libcore/panicking.rs:85
  13: core::str::slice_error_fail
             at src/libcore/str/mod.rs:0
  14: core::str::traits::<impl core::slice::SliceIndex<str> for core::ops::range::RangeTo<usize>>::index::{{closure}}
  15: fastmod::index_to_row_col
  16: fastmod::fastmod
  17: fastmod::main
  18: std::rt::lang_start::{{closure}}
  19: std::rt::lang_start_internal::{{closure}}
             at src/libstd/rt.rs:52
  20: std::panicking::try::do_call
             at src/libstd/panicking.rs:305
  21: __rust_maybe_catch_panic
             at src/libpanic_unwind/lib.rs:86
  22: std::panicking::try
             at src/libstd/panicking.rs:281
  23: std::panic::catch_unwind
             at src/libstd/panic.rs:394
  24: std::rt::lang_start_internal
             at src/libstd/rt.rs:51
  25: main
  26: __libc_start_main
  27: <unknown>
note: Some details are omitted, run with `RUST_BACKTRACE=full` for a verbose backtrace.

closed time in 3 months

ghuls

issue commentfacebookincubator/fastmod

Panic "out of bounds of"

Should be fixed.

ghuls

comment created time in 3 months

issue commentfacebookincubator/fastmod

Panic "out of bounds of"

I've reproduced the issue. Turns out the problem is that this pattern generates zero length matches (compare the patterns 'a?' and ''), and we assumed that that could never happen.

ghuls

comment created time in 3 months

push eventfacebook/fishhook

xurunkang

commit sha 49e91e7f3cdb5747ce111496dbef83bcfb2504cd

Replace __DATA_CONST with SEG_DATA_CONST

view details

Scott Wolchok

commit sha 8ef82f0711494ecc78d16bf6ce76f5ad92e5f67b

Merge pull request #72 from xurunkang/master Replace __DATA_CONST with SEG_DATA_CONST

view details

push time in 3 months

PR merged facebook/fishhook

Reviewers
Replace __DATA_CONST with SEG_DATA_CONST CLA Signed
+1 -1

2 comments

1 changed file

xurunkang

pr closed time in 3 months

pull request commentfacebook/fishhook

Replace __DATA_CONST with SEG_DATA_CONST

Thanks!

xurunkang

comment created time in 3 months

more