profile
viewpoint
If you are wondering where the data of this site comes from, please visit https://api.github.com/users/superheri/events. GitMemory does not store any data, but only uses NGINX to cache data for a period of time. The idea behind GitMemory is simply to give users a better reading experience.
Alexandre Paré superheri Québec, Canada

superheri/bootstrap-menu 0

Context menu plugin using Bootstrap's style

superheri/Color-Logs 0

Node.js module to get better logs.

superheri/DefinitelyTyped 0

The repository for high quality TypeScript type definitions.

superheri/dolphin 0

Dolphin is a GameCube / Wii emulator, allowing you to play games for these two platforms on PC with improvements.

superheri/express 0

Fast, unopinionated, minimalist web framework for node.

superheri/material 0

Material design for AngularJS

superheri/mongoose 0

MongoDB object modeling designed to work in an asynchronous environment.

superheri/node-jsonwebtoken 0

JsonWebToken implementation for node.js http://self-issued.info/docs/draft-ietf-oauth-json-web-token.html

superheri/npm-expansions 0

Send us a pull request by editing expansions.txt

superheri/nusdownloader 0

Automatically exported from code.google.com/p/nusdownloader

PullRequestReviewEvent

pull request commentangular/material

build: Fix SCSS division deprecation

Is there a way we could make it work without updating gulp? Because this will invevitably make it impossible to update sass for projects in the future which is a big problem. Or at least apply a build task at the end which run the command of sass-migrator?

superheri

comment created time in 3 months

PR opened angular/material

build: Fix SCSS division deprecation

<!-- Filling out this template is required! Do not delete it when submitting a Pull Request! Without this information, your Pull Request may be auto-closed. -->

AngularJS Material is in LTS mode

We are no longer accepting changes that are not critical bug fixes into this project. See Long Term Support for more detail.

PR Checklist

Please check your PR fulfills the following requirements:

  • [x] Does this PR fix a regression since 1.2.0, a security flaw, or a problem caused by a new browser version?
  • [ ] The commit message follows our guidelines
  • [ ] Tests for the changes have been added or this is not a bug fix / enhancement
  • [x] Docs have been added, updated, or were not required

PR Type

What kind of change does this PR introduce? <!-- Please check the one that applies to this PR using "x". -->

[ ] Bugfix
[ ] Enhancement
[ ] Documentation content changes
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[x] CI related changes
[ ] Infrastructure changes
[x] Other... Please describe: Fixing the output for scss builds

What is the current behavior?

<!-- Please describe the current behavior that you are modifying and link to one or more relevant issues. -->

When building with newer SASS version we get this deprecation message and many others :

DEPRECATION WARNING: Using / for division is deprecated and will be removed in Dart Sass 2.0.0.

Recommendation: math.div($button-fab-height - $button-fab-padding, 2)

More info and automated migrator: https://sass-lang.com/d/slash-div

    ╷
345 │   @include fab-position(bottom-right, auto, ($button-fab-width - $button-fab-padding)/2, ($button-fab-height - $button-fab-padding)/2, auto);
    │                                                                                          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    ╵
    node_modules\angular-material\angular-material.scss 345:90  fab-all-positions()
    node_modules\angular-material\angular-material.scss 2000:5  @import

Fixes #

What is the new behavior?

This changes the division notation in scss files so that it fits the new expected writing.

These changes where made using the sass-migrator that sass themselves are telling to use.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

<!-- If this PR contains a breaking change, please describe the impact and migration path for existing applications below. --> <!-- Note that breaking changes are highly unlikely to get merged to master unless the validation is clear and the use case is critical. -->

Other information

+93 -73

0 comment

18 changed files

pr created time in 3 months

create barnchsuperheri/material

branch : sass-division

created branch time in 3 months

fork superheri/material

Material design for AngularJS

https://material.angularjs.org/

fork in 3 months