profile
viewpoint
If you are wondering where the data of this site comes from, please visit https://api.github.com/users/subintp/events. GitMemory does not store any data, but only uses NGINX to cache data for a period of time. The idea behind GitMemory is simply to give users a better reading experience.

chatwoot/chatwoot 9717

Open-source customer engagement suite, an alternative to Intercom, Zendesk, Salesforce Service Cloud etc. 🔥💬

chatwoot/chatwoot-mobile-app 216

Mobile app for Chatwoot - React Native

chatwoot/docs 10

Official docs, handbook for Chatwoot

chatwoot/twitty 7

Ruby client for Twitter Business APIs

chatwoot/node 3

A node.js client for Chatwoot APIs

subintp/bestpricy 1

free time madness

subintp/anemone 0

Anemone web-spider framework

subintp/Autolinker.js 0

Simple utility to automatically link the URLs, email addresses, and Twitter handles in a given block of text/HTML.

PullRequestReviewEvent

Pull request review commentrazorpay/opencensus-php

Add array value as csv if value is array for attribute

 trait AttributeTrait     public function addAttributes(array $attributes)     {         foreach ($attributes as $attribute => $value) {+            if (is_array($value)) {+                $value = implode(', ', $value);

Why are we passing array in first place ?

akashsharma95

comment created time in 6 days

startedupgundecha/howtheysre

started time in 16 days

Pull request review commenthypertrace/hypertrace-core-graphql

Added config for gateway gRPC client deadline

    private static final String GATEWAY_SERVICE_HOST_PROPERTY = "gateway.service.host";   private static final String GATEWAY_SERVICE_PORT_PROPERTY = "gateway.service.port";+  private static final String GATEWAY_SERVICE_RPC_CLIENT_DEADLINE = "gateway.service.deadline";

Why do we need to keep it as a mandatory field? Can we take the value from config if it is defined or take the default value?

suddendust

comment created time in a month

PullRequestReviewEvent

issue openedhypertrace/hypertrace-ui

Support for adding web analytics tracker eg: Google analytics

Use Case

*Currently there is no way to track developer engagement on Hypertrace. Engagement tracking will help us to understand how developers use the apps and also plan the evangelization around the features effectively within the company *

Proposal

There is should some way to inject this javascript code into hypertrace UI.

created time in 2 months

startedlovoo/goka

started time in 2 months

PullRequestReviewEvent

Pull request review commentToolJet/ToolJet

Add ability to archive organization_users

 class OrganizationUser < ApplicationRecord   belongs_to :organization   belongs_to :user +  enum status: { invited: "invited", archived: "archived" }

Key and value aresame for enum. Why are defining it as hash

You could define it like this

enum status: [ :active, :invited, :archived ]

JibranKalia

comment created time in 2 months

PullRequestReviewEvent

Pull request review commentToolJet/ToolJet

Add ability to archive organization_users

 def change_role     authorize org_user     org_user.update(role: params[:role])   end++  def archive+    org_user = OrganizationUser.find params[:organization_user_id]+    authorize org_user

This is common to all controller methods. Can you move this before_action filter?

JibranKalia

comment created time in 2 months

PullRequestReviewEvent

Pull request review commentToolJet/ToolJet

#150 Add copy to clipboard to actions

 export const EventSelector = ({                 </div>               )} +              {definition.actionId === 'copy-to-clipboard' && (

Please check below comment

prasadwalvekar

comment created time in 2 months

PullRequestReviewEvent
PullRequestReviewEvent

Pull request review commentToolJet/ToolJet

#150 Add copy to clipboard to actions

 function executeAction(_ref, event) {        _ref.setState(newState)     }++    if (event.actionId === 'copy-to-clipboard') {

Why are you hardcoding id again ? You could take the id from ActionTypes.

prasadwalvekar

comment created time in 2 months

issue commenthypertrace/hypertrace

[Feature Request] Alerting support for metric series

@kotharironak I am guessing this will configurable from Hypertrace UI or do we have to create a separate rule definition for the alert

kotharironak

comment created time in 2 months

push eventToolJet/ToolJet

James Lewis

commit sha 15a7ca18652d5ef3c7b5905b851682f329e6d47f

Update README.md

view details

Subin T P

commit sha 668f1c3b6c52ba7c0691b1540d484566deb731eb

Merge pull request #192 from jamesphlewis/patch-1 Update README.md to fix "TooJet" misspelling

view details

push time in 2 months

PR merged ToolJet/ToolJet

Update README.md to fix "TooJet" misspelling

Misspelling in the README.md

+1 -1

0 comment

1 changed file

jamesphlewis

pr closed time in 2 months

PullRequestReviewEvent

fork subintp/ToolJet

Opensource internal tool builder. An alternative to Retool, AppSmith, JetAdmin, Internal.io etc

https://tooljet.io

fork in 2 months

PullRequestReviewEvent
PullRequestReviewEvent

Pull request review commentrazorpay/opencensus-php

Add changes to handle baggage in jaeger propagator

 ZEND_END_ARG_INFO() ZEND_BEGIN_ARG_INFO_EX(arginfo_opencensus_trace_set_context, 0, 0, 1)     ZEND_ARG_TYPE_INFO(0, traceId, IS_STRING, 0)     ZEND_ARG_TYPE_INFO(0, parentSpanId, IS_STRING, 1)+    ZEND_ARG_ARRAY_INFO(0, baggage, 1)

Why pass by value?

akashsharma95

comment created time in 2 months

Pull request review commentrazorpay/opencensus-php

Add changes to handle baggage in jaeger propagator

 void opencensus_trace_rinit()      OPENCENSUS_G(current_span) = NULL;     OPENCENSUS_G(trace_id) = NULL;+    ALLOC_HASHTABLE(OPENCENSUS_G(baggage));+    zend_hash_init(OPENCENSUS_G(baggage), 16, NULL, NULL, 0);

nit: Define baggage length as numeric constant. Will increase readability

#define MAX_BAGGAGE_LENGTH 16

akashsharma95

comment created time in 2 months

PullRequestReviewEvent

Pull request review commentrazorpay/opencensus-php

Add changes to handle baggage in jaeger propagator

 void opencensus_trace_rinit()      OPENCENSUS_G(current_span) = NULL;     OPENCENSUS_G(trace_id) = NULL;+    ALLOC_HASHTABLE(OPENCENSUS_G(baggage));+    zend_hash_init(OPENCENSUS_G(baggage), 16, NULL, NULL, 0);

We are not releasing the memory allocated for the baggage. We can release memory in trace shutdown hook

eg:

void opencensus_trace_rshutdown()
{
    /* cleanup baggage */
    zend_hash_destroy(OPENCENSUS_G(baggage));
    FREE_HASHTABLE(OPENCENSUS_G(baggage));
}
akashsharma95

comment created time in 2 months

PullRequestReviewEvent
PullRequestReviewEvent