profile
viewpoint
If you are wondering where the data of this site comes from, please visit https://api.github.com/users/stormc/events. GitMemory does not store any data, but only uses NGINX to cache data for a period of time. The idea behind GitMemory is simply to give users a better reading experience.

siemens/meta-iot2000 106

SIMATIC IOT2000 Yocto Board Support Package

siemens/efibootguard 41

Simple UEFI boot loader with support for safely switching between current and updated partition sets

siemens/swupdate 5

Software Update for Embedded Systems

stormc/lua-clidebugger 3

A simple Lua CLI debugger

stormc/waitforpid 2

Wait for a (non-child) process' exit using Linux's PROC_EVENTS and POSIX capabilities.

stormc/brightnessd 1

Daemon regulating screen brightness depending on user input (in)activity

stormc/vim-lua-ftplugin 1

Lua file type plug-in for the Vim text editor

andi8086/efibootguard 0

efi boot guard

stormc/luajit-sdl2_gfx-ffi 0

A LuaJIT binding to SDL2_gfx

Pull request review commentsiemens/meta-iot2050

Add swupdate

+#+# Copyright (c) Siemens AG, 2021+#+# Authors:+#  Quirin Gylstorff <quirin.gylstorff@siemens.com>+#+# SPDX-License-Identifier: MIT++[Unit]+Description=update u-boot environment for swupdate+Conflicts=shutdown.target+Before=swupdate.service shutdown.target++[Service]+Type=oneshot+ExecStart=/usr/share/u-boot-env/patch-u-boot-env.sh /usr/share/u-boot-env/patch-u-boot-env.config+ExecStartPost=-/bin/systemctl disable patch-u-boot-env.service

Hm, you disable the service but don't cleanup the files used while this first boot setup. Is there a reason not to delete those files?

gylstorffq

comment created time in a day

PullRequestReviewEvent

Pull request review commentsiemens/meta-iot2050

Add swupdate

+#+# Copyright (c) Siemens AG, 2021+#+# Authors:+#  Quirin Gylstorff <quirin.gylstorff@siemens.com>+#+# This file is subject to the terms and conditions of the MIT License.  See+# COPYING.MIT file in the top-level directory.+#++bootloader --ptable gpt --append "console=ttyS3,115200n8 earlycon=ns16550a,mmio32,0x02810000 mtdparts=47040000.spi.0:512k(ospi.tiboot3),2m(ospi.tispl),4m(ospi.u-boot),128k(ospi.env),128k(ospi.env.backup),1m(ospi.sysfw),64k(pru0-fw),64k(pru1-fw),64k(rtu0-fw),64k(rtu1-fw),-@8m(ospi.rootfs) rootwait ${EXTRA_KERNEL_PARAMS}"++# rootfs A+part --source rootfs-u-boot --sourceparams="no_initrd=yes,script_prepend=if test \\\"\$\{board_name\}\\\" = \\\"IOT2050-ADVANCED\\\"; then set fdtfile ti/k3-am6548-iot2050-advanced.dtb; else setenv fdtfile ti/k3-am6528-iot2050-basic.dtb; fi;env exists sysselect || setenv sysselect 1,root=PARTLABEL=rootfs\"\$\{sysselect\}\"" --fixed-size 4G --fstype ext4 --label rootfs1 --align 1024

Way better, can't we merge that first?

gylstorffq

comment created time in a day

PullRequestReviewEvent

issue commenthrsh7th/nvim-cmp

Terminal title flickers when completion menu opens

@adrian5 No worries, I think it still helped to come to a common understanding (and workaround) of the problem.

Question is whether the workaround should be documented in the wiki (as we cannot do something generic in code) and/or whether to pursue the necessary change for a real fix in nvim-core?

adrian5

comment created time in 4 days

issue commenthrsh7th/nvim-cmp

Terminal title flickers when completion menu opens

I agree. My filename-caching titlestring function above is a hack/workaround to this problem. And it's too broad in using the cached filename unconditionally for all floating windows (condition: vim.api.nvim_win_get_config(0).relative ~= ""). This problem also extends to other than filename information you may put in titlestring that is different in the buffer and the floating window.

What would be needed for a real solution is a flag or something to tell nvim not to render titlestring for a particular window/popup, maybe set by a nvim_win_set_option() option. But that's a nvim-core change...

adrian5

comment created time in 4 days

Pull request review commentsiemens/meta-iot2050

Add swupdate

+#+# Copyright (c) Siemens AG, 2021+#+# Authors:+#  Quirin Gylstorff <quirin.gylstorff@siemens.com>+#+# This file is subject to the terms and conditions of the MIT License.  See+# COPYING.MIT file in the top-level directory.+#++bootloader --ptable gpt --append "console=ttyS3,115200n8 earlycon=ns16550a,mmio32,0x02810000 mtdparts=47040000.spi.0:512k(ospi.tiboot3),2m(ospi.tispl),4m(ospi.u-boot),128k(ospi.env),128k(ospi.env.backup),1m(ospi.sysfw),64k(pru0-fw),64k(pru1-fw),64k(rtu0-fw),64k(rtu1-fw),-@8m(ospi.rootfs) rootwait ${EXTRA_KERNEL_PARAMS}"++# rootfs A+part --source rootfs-u-boot --sourceparams="no_initrd=yes,script_prepend=if test \\\"\$\{board_name\}\\\" = \\\"IOT2050-ADVANCED\\\"; then set fdtfile ti/k3-am6548-iot2050-advanced.dtb; else setenv fdtfile ti/k3-am6528-iot2050-basic.dtb; fi;env exists sysselect || setenv sysselect 1,root=PARTLABEL=rootfs\"\$\{sysselect\}\"" --fixed-size 4G --fstype ext4 --label rootfs1 --align 1024

This DTB mumbo jumbo seems ugly. Isn't there a better way?

gylstorffq

comment created time in 5 days

PullRequestReviewEvent
PullRequestReviewEvent

Pull request review commentsiemens/meta-iot2050

Add swupdate

+#+# Copyright (c) Siemens AG, 2021+#+# Authors:+#  Quirin Gylstorff <quirin.gylstorff@siemens.com>+#+# This file is subject to the terms and conditions of the MIT License.  See+# COPYING.MIT file in the top-level directory.+#++software =+{+    version = "0.1";+    name = "fat-edge iot2050 update image"

fat-edge? Why this prefix?

gylstorffq

comment created time in 5 days

Pull request review commentsiemens/meta-iot2050

Add swupdate

 device.  NOTE: This selection is not persistent. The boot loader will fall back to its default boot order after reset.++## Building with SWUpdate support++The option `kas/opt/swupdate-example.yml` will create an image  with a+[double copy root file system](https://sbabic.github.io/swupdate/overview.html#double-copy-with-fall-back).+You can find the image under `build/tmp/deploy/images/iot2050/iot2050-image-swu-example-iot2050-debian-iot2050.wic.img`++NOTE: The image has a size of 7 Gigabytes.++It also will create a binary for updating the system at+This call will write the image to the unused root partition`build/tmp/deploy/images/iot2050/iot2050-image-swu-examp+le-iot2050-debian-iot2050.swu`++The binary can be uploaded to the device and be applied by executing:++```shell+$ swupdate -i iot2050-image-swu-example-iot2050-debian-iot2050.swu+```+SWUpdate will write the image to the unused root partition and+sets the necessary U-Boot variables.

Hm, what are these? Why confirm later on? There's a description of the overall process missing.

gylstorffq

comment created time in 5 days

PullRequestReviewEvent
PullRequestReviewEvent

Pull request review commentsiemens/meta-iot2050

Add swupdate

 device.  NOTE: This selection is not persistent. The boot loader will fall back to its default boot order after reset.++## Building with SWUpdate support++The option `kas/opt/swupdate-example.yml` will create an image  with a+[double copy root file system](https://sbabic.github.io/swupdate/overview.html#double-copy-with-fall-back).+You can find the image under `build/tmp/deploy/images/iot2050/iot2050-image-swu-example-iot2050-debian-iot2050.wic.img`++NOTE: The image has a size of 7 Gigabytes.++It also will create a binary for updating the system at+This call will write the image to the unused root partition`build/tmp/deploy/images/iot2050/iot2050-image-swu-examp+le-iot2050-debian-iot2050.swu`++The binary can be uploaded to the device and be applied by executing:++```shell+$ swupdate -i iot2050-image-swu-example-iot2050-debian-iot2050.swu

You should mention verbose output so to see what's wrong if something goes wrong or refer to SWUpdate's documentation.

gylstorffq

comment created time in 5 days

PullRequestReviewEvent

Pull request review commentsiemens/meta-iot2050

Add swupdate

 device.  NOTE: This selection is not persistent. The boot loader will fall back to its default boot order after reset.++## Building with SWUpdate support++The option `kas/opt/swupdate-example.yml` will create an image  with a+[double copy root file system](https://sbabic.github.io/swupdate/overview.html#double-copy-with-fall-back)+You can find the image under+`build/tmp/deploy/images/iot2050/iot2050-image-swu-example-iot2050-debian-iot2050.wic.img`++It also will create an binary for updating the system at+This call will write the image to the unused root partition`build/tmp/deploy/images/iot2050/iot2050-image-swu-examp+le-iot2050-debian-iot2050.swu`++The binary can be applied on the booted target with:++```shell+$ swupdate -i iot2050-image-swu-example-iot2050-debian-iot2050.swu

You should mention verbose output so to see what's wrong if something goes wrong or refer to SWUpdate's documentation.

gylstorffq

comment created time in 5 days

Pull request review commentsiemens/meta-iot2050

Add swupdate

 device.  NOTE: This selection is not persistent. The boot loader will fall back to its default boot order after reset.++## Building with SWUpdate support++The option `kas/opt/swupdate-example.yml` will create an image  with a+[double copy root file system](https://sbabic.github.io/swupdate/overview.html#double-copy-with-fall-back).+You can find the image under `build/tmp/deploy/images/iot2050/iot2050-image-swu-example-iot2050-debian-iot2050.wic.img`++NOTE: The image has a size of 7 Gigabytes.++It also will create a binary for updating the system at

Incomplete sentence.

gylstorffq

comment created time in 5 days

PullRequestReviewEvent

issue commenthrsh7th/nvim-cmp

Terminal title flickers when completion menu opens

@Shougo If you don't see the flicker with the code snippet above, then it "solves" it :) So, it does not reproduce the flicker but instead shows how to avoid it, sorry for the inaccuracy.

adrian5

comment created time in 7 days

issue commenthrsh7th/nvim-cmp

Terminal title flickers when completion menu opens

This is a fast hack to demonstrate it (I made titlestring longer so that you have time to notice the flicker, you can also introduce a synthetic delay):

set title
lua << EOF
function titlestring_file()
    if vim.api.nvim_win_get_config(0).relative ~= "" then
        return vim.t.titlestring_file or ""
    end
    local fname = vim.fn.expand('%:p:~:.')
    vim.t.titlestring_file = fname
    return fname
end
EOF
let &titlestring="%{v:lua.titlestring_file()}   %<{%{fnamemodify(getcwd(), ':~')}}  - VIM"

I don't know how to reasonably integrate this in to nvim-cmp as it has to parse/know/mess with the user-set titlestring then. Probably this is something for the documentation/wiki instead of code?

adrian5

comment created time in 7 days

issue commenthrsh7th/nvim-cmp

Terminal title flickers when completion menu opens

If you set title then titlestring gets evaluated in the floating/popup windows' context. Since this may not have a file attached (or the "wrong" one), you see [No Name]. You can test/work-around this by evaluating a function in titlestring that returns the (cached) filename value if the current context is a floating/popup windows (with no file attached).

adrian5

comment created time in 8 days

PR opened jose-elias-alvarez/null-ls.nvim

fix(builtins): handle gitsigns returning nil

gitsign's get_actions() may return nil, e.g., if the buffer is not version-controlled. Handle this case as well.

+1 -1

0 comment

1 changed file

pr created time in 11 days

create barnchstormc/null-ls.nvim

branch : code-actions-fix-nil

created branch time in 11 days

fork stormc/null-ls.nvim

Use Neovim as a language server to inject LSP diagnostics, code actions, and more via Lua.

fork in 11 days

issue commentnvim-lua/completion-nvim

Upstream nvim at 23fe6dba1 breaks tab completion

@mrkz You're welcome, #400 does also proper-fix hover and signature for which you would have to apply this workaround's gist as well, so I suggest to use that instead of this workaround until it's been merged.

arsham

comment created time in 19 days

issue commentnvim-lua/completion-nvim

Upstream nvim at 23fe6dba1 breaks tab completion

The handler function's signature in source/lsp.lua needs to be updated, possibly adding a backwards-compatible wrapper for neovim versions prior to this commit. As an intermediate hack, this should help:

-  vim.lsp.buf_request(params.bufnr, 'textDocument/completion', position_param, function(err, _, result)
+  vim.lsp.buf_request(params.bufnr, 'textDocument/completion', position_param, function(err, result)
arsham

comment created time in a month

PullRequestReviewEvent

Pull request review commentnvim-lua/completion-nvim

Highlight active parameter in signature help pupup

 M.autoOpenSignatureHelp = function()       local client = vim.lsp.get_client_by_id(client_id)       local handler = client and client.handlers['textDocument/signatureHelp']       if handler then-          handler(err, method, result, client_id)-          return+        handler(err, method, result, client_id)+        return       end       if not (result and result.signatures and result.signatures[1]) then         return       end-      local lines = vim.lsp.util.convert_signature_help_to_markdown_lines(result, filetype)+      local lines, hl = vim.lsp.util.convert_signature_help_to_markdown_lines(result, filetype)+      lines = vim.lsp.util.trim_empty_lines(lines)       if vim.tbl_isempty(lines) then         return       end        -- if `lines` can be trimmed, it is modified in place       local trimmed_lines_filetype = vim.lsp.util.try_trim_markdown_code_blocks(lines)-	  local opts = {}-	  if vim.g.completion_popup_border then-	    opts.border = vim.g.completion_popup_border-	  end-      local bufnr, _ = vim.lsp.util.open_floating_preview(-        -- TODO show popup when signatures is empty?+      local opts = {}+      if vim.g.completion_popup_border then+        opts.border = vim.g.completion_popup_border+      end+      local fbuf, fwin = vim.lsp.util.open_floating_preview(         vim.lsp.util.trim_empty_lines(lines),

You're welcome and thanks for this, works great for me.

ranjithshegde

comment created time in 2 months

Pull request review commentnvim-lua/completion-nvim

Highlight active parameter in signature help pupup

 M.autoOpenSignatureHelp = function()       local client = vim.lsp.get_client_by_id(client_id)       local handler = client and client.handlers['textDocument/signatureHelp']       if handler then-          handler(err, method, result, client_id)-          return+        handler(err, method, result, client_id)+        return       end       if not (result and result.signatures and result.signatures[1]) then         return       end-      local lines = vim.lsp.util.convert_signature_help_to_markdown_lines(result, filetype)+      local lines, hl = vim.lsp.util.convert_signature_help_to_markdown_lines(result, filetype)+      lines = vim.lsp.util.trim_empty_lines(lines)       if vim.tbl_isempty(lines) then         return       end        -- if `lines` can be trimmed, it is modified in place       local trimmed_lines_filetype = vim.lsp.util.try_trim_markdown_code_blocks(lines)-	  local opts = {}-	  if vim.g.completion_popup_border then-	    opts.border = vim.g.completion_popup_border-	  end-      local bufnr, _ = vim.lsp.util.open_floating_preview(-        -- TODO show popup when signatures is empty?+      local opts = {}+      if vim.g.completion_popup_border then+        opts.border = vim.g.completion_popup_border+      end+      local fbuf, fwin = vim.lsp.util.open_floating_preview(         vim.lsp.util.trim_empty_lines(lines),

This trim is superfluous as it's been trimmed in (new) line 42 already, right?

ranjithshegde

comment created time in 2 months

PullRequestReviewEvent