profile
viewpoint
Steve Azzopardi steveazz @GitLab Malta I solve more problems then I create. Backend Engineer @GitLab 🦊

pull request commentmoby/moby

Remove error return on !exists

@thaJeztah I managed to make the pipeline green 🎉 I had to refactor the initial implementation a bit to make it successful and not modify any existing logic. I'm not 100% sure about the code quality, I welcome any feedback!

steveazz

comment created time in 12 hours

push eventsteveazz/moby

Steve Azzopardi

commit sha d4abc4b8ae3cb8115c92e1808648ed2a19b9c23b

Add check for bind source path exists Add a new check to validate if the source path of the volume binding exists. This is a is not always validated since in `ParseMountRaw` we don't want to validate this. This brings feature parity between the Linux parse and Windows parser, where a directory is created if the source path doesn't exists. Signed-off-by: Steve Azzopardi <sazzopardi@gitlab.com>

view details

Steve Azzopardi

commit sha ab1cd4c6c27d45ce427dc20613fd5e53a181d8a6

Move source must be dir err to func For consistency, testtability and reuseability sake move the string to a func that returns a formatted error. Signed-off-by: Steve Azzopardi <sazzopardi@gitlab.com>

view details

Steve Azzopardi

commit sha f1c6708078115ce633516f72eb3f0bfaa1c1aa42

Add specific mock for TestValidateMount Create a new mock specific for the test `TestValidateMount` which returns `exist` to `false` only when it's equal to `testSourcePathDoesNotExist` so that the validation is done correctly. Signed-off-by: Steve Azzopardi <sazzopardi@gitlab.com>

view details

Brian Goff

commit sha e08e7029c8fcd6f21de4ec9afd82c3a6e64696bf

Make parser tests a little easier to read and decipher for test fails Signed-off-by: Brian Goff <cpuguy83@gmail.com>

view details

Steve Azzopardi

commit sha e0293f3426431530810c1cd8245d3c932a7247ee

Add check for pipe for bind volume When the mount type is set to `bind` check that the target is not a named pipe. Signed-off-by: Steve Azzopardi <sazzopardi@gitlab.com>

view details

push time in 13 hours

push eventsteveazz/moby

Steve Azzopardi

commit sha 2f9100d1e41fc192a7bd34fae76996b0c1336be2

Move validation for bind source on volume mount Create a new `mountValidator` called `validateBindSourceExists` which checks whether the source of the volume binding exists or not. Don't use this validation for `ParseMountRaw` to remove the feature parity between Windows and Linux were using the `-v` flag and the directory doesn't exist, it is automatically created. Signed-off-by: Steve Azzopardi <sazzopardi@gitlab.com>

view details

Steve Azzopardi

commit sha 539007be6eb809e4d23bf3d3860b8a64eda6503a

Move source must be dir err to func For consistency, testtability and reuseability sake move the string to a func that returns a formatted error. Signed-off-by: Steve Azzopardi <sazzopardi@gitlab.com>

view details

Steve Azzopardi

commit sha e8df29df9d41e5e4125def462b9ffa89126c87c2

Add specific mock for TestValidateMount Create a new mock specific for the test `TestValidateMount` which returns `exist` to `false` only when it's equal to `testSourcePathDoesNotExist` so that the validation is done correctly. Signed-off-by: Steve Azzopardi <sazzopardi@gitlab.com>

view details

Brian Goff

commit sha 18d1e78db6c03713d4d2d03af897165e6f2c44c1

Make parser tests a little easier to read and decipher for test fails Signed-off-by: Brian Goff <cpuguy83@gmail.com>

view details

Steve Azzopardi

commit sha df5800a8b8b6877d873ac2908d0b8800bd78f3de

Add check for pipe for bind volume When the mount type is set to `bind` check that the target is not a named pipe. Signed-off-by: Steve Azzopardi <sazzopardi@gitlab.com>

view details

push time in 3 days

push eventsteveazz/moby

Steve Azzopardi

commit sha fbedb19cff88eb16074f941e38804f96612ed45b

Move validation for bind source on volume mount Create a new `mountValidator` called `validateBindSourceExists` which checks whether the source of the volume binding exists or not. Don't use this validation for `ParseMountRaw` to remove the feature parity between Windows and Linux were using the `-v` flag and the directory doesn't exist, it is automatically created. Signed-off-by: Steve Azzopardi <sazzopardi@gitlab.com>

view details

Steve Azzopardi

commit sha 68beca1a1fe9b7557b043317eb3d141c026cc928

Move source must be dir err to func For consistency, testtability and reuseability sake move the string to a func that returns a formatted error. Signed-off-by: Steve Azzopardi <sazzopardi@gitlab.com>

view details

Steve Azzopardi

commit sha 97ae23111542415cb9b11eae42011d3839e90a9a

Add specific mock for TestValidateMount Create a new mock specific for the test `TestValidateMount` which returns `exist` to `false` only when it's equal to `testSourcePathDoesNotExist` so that the validation is done correctly. Signed-off-by: Steve Azzopardi <sazzopardi@gitlab.com>

view details

Brian Goff

commit sha 9c6118fb9e1c04d9d5a15f8ac7b54d348589c01f

Make parser tests a little easier to read and decipher for test fails Signed-off-by: Brian Goff <cpuguy83@gmail.com>

view details

Steve Azzopardi

commit sha 0329d3674bebb5c669787034c5472b93ed574c3b

Add check for pipe for bind volume When the mount type is set to `bind` check that the target is not a named pipe. Signed-off-by: Steve Azzopardi <sazzopardi@gitlab.com>

view details

push time in 4 days

push eventsteveazz/moby

Steve Azzopardi

commit sha 282ced20c0e789d931321516b8f138936b362920

Move validation for bind source on volume mount Create a new `mountValidator` called `validateBindSourceExists` which checks whether the source of the volume binding exists or not. Don't use this validation for `ParseMountRaw` to remove the feature parity between Windows and Linux were using the `-v` flag and the directory doesn't exist, it is automatically created. Signed-off-by: Steve Azzopardi <sazzopardi@gitlab.com>

view details

Steve Azzopardi

commit sha 694218951e2dc7ac6396b96c9052c2490a9234b7

Move source must be dir err to func For consistency, testtability and reuseability sake move the string to a func that returns a formatted error. Signed-off-by: Steve Azzopardi <sazzopardi@gitlab.com>

view details

Steve Azzopardi

commit sha 885055eb70c5e7d78a0a4a3ffddc087336dcdeaf

Add specific mock for TestValidateMount Create a new mock specific for the test `TestValidateMount` which returns `exist` to `false` only when it's equal to `testSourcePathDoesNotExist` so that the validation is done correctly. Signed-off-by: Steve Azzopardi <sazzopardi@gitlab.com>

view details

Brian Goff

commit sha 94d58613b9ba101e6396cf2cc6edb287d2c01cdd

Make parser tests a little easier to read and decipher for test fails Signed-off-by: Brian Goff <cpuguy83@gmail.com>

view details

Steve Azzopardi

commit sha 56885683e4e9fdc1c2853e13b5b6729f30cd7cb1

Add check for pipe for bind volume When the mount type is set to `bind` check that the target is not a named pipe. Signed-off-by: Steve Azzopardi <sazzopardi@gitlab.com>

view details

push time in 4 days

push eventsteveazz/moby

Sebastiaan van Stijn

commit sha 9cf349d0f80d2399cdfad0321e0f181c2e7efa17

bump libnetwork 90afbb01e1d8acacb505a092744ea42b9f167377 full diff: https://github.com/docker/libnetwork/compare/0025177e3dabbe0de151be0957dcaff149d43536...90afbb01e1d8acacb505a092744ea42b9f167377 includes: - docker/libnetwork#/2459 Fix Error Check in NewNetwork - docker/libnetwork#/2466 Revert "Merge pull request #2339 from phyber/iptables-check" - reverts docker/libnetwork#/2339 controller: Check if IPTables is enabled for arrangeUserFilterRule - re-opens docker/libnetwork#2158 dockerd when run with --iptables=false modifies iptables by adding DOCKER-USER - re-opens moby/moby#35777 With iptables=false dockerd still creates DOCKER-USER chain and rules - re-opens docker/for-linux#136 dockerd --iptables=false adds DOCKER-USER chain and modify FORWARD chain anyway Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

view details

Tibor Vass

commit sha 36ffe9edc2b37a5154633f3fbc260217114039d4

Merge pull request #40192 from thaJeztah/bump_libnetwork bump libnetwork 90afbb01e1d8acacb505a092744ea42b9f167377

view details

Steve Azzopardi

commit sha 4044f9a4c0723f05ccaba2a462478ada99e74271

Remove error return on !exists On Linux, volume binding creates the directory on the host. This conditional check on Windows was preventing Windows Containers from creating the directory producing inconsistent behavior between platforms. Signed-off-by: Steve Azzopardi <sazzopardi@gitlab.com>

view details

Steve Azzopardi

commit sha a588f6222dc942fd406eb758b76b74dcfb783316

Move validation for bind source on volume mount Create a new `mountValidator` called `validateBindSourceExists` which checks whether the source of the volume binding exists or not. Don't use this validation for `ParseMountRaw` to remove the feature parity between Windows and Linux were using the `-v` flag and the directory doesn't exist, it is automatically created. Signed-off-by: Steve Azzopardi <sazzopardi@gitlab.com>

view details

Steve Azzopardi

commit sha fc668f9bce91c8992a94ccc9ddac50633f39eed9

Move source must be dir err to func For consistency, testtability and reuseability sake move the string to a func that returns a formatted error. Signed-off-by: Steve Azzopardi <sazzopardi@gitlab.com>

view details

Steve Azzopardi

commit sha dc75ad32d838366c643c6dd551dd26f925d20fcd

Add specific mock for TestValidateMount Create a new mock specific for the test `TestValidateMount` which returns `exist` to `false` only when it's equal to `testSourcePathDoesNotExist` so that the validation is done correctly. Signed-off-by: Steve Azzopardi <sazzopardi@gitlab.com>

view details

Brian Goff

commit sha 7a582076968413cb4ed3d52c15030bf85fa6d7fb

Make parser tests a little easier to read and decipher for test fails Signed-off-by: Brian Goff <cpuguy83@gmail.com>

view details

Steve Azzopardi

commit sha 5294704849cc7e241ac6b09bc9f2504aabb40414

Add check for pipe for bind volume When the mount type is set to `bind` check that the target is not a named pipe. Signed-off-by: Steve Azzopardi <sazzopardi@gitlab.com>

view details

push time in 7 days

pull request commentmoby/moby

Remove error return on !exists

Ok I've updated an update the fixes the failure for TestParseMountRawSplit with 60f63c84bb38be6a9be8514b949c906692e8a05f but now I see a new failure in https://ci.docker.com/public/blue/rest/organizations/jenkins/pipelines/moby/branches/PR-38465/runs/4/nodes/53/steps/234/log/ I will spend some more time this weekend investigating to see if I can get the pipeline green 🙇

steveazz

comment created time in 9 days

push eventsteveazz/moby

Hannes Ljungberg

commit sha 4d09fab232ed282d020afbe1e0935b53379df4ad

Update service networks documentation The previous description stated that an array of names / ids could be passed when the API in reality expects objects in the form of NetworkAttachmentConfig. This is fixed by updating the description and adding a definition for NetworkAttachmentConfig. Signed-off-by: Hannes Ljungberg <hannes@5monkeys.se>

view details

Justen Martin

commit sha 3b49bd1d840d64ec603333eae28655b9ff5edc0c

replaced call to deprecated grpc method WithDialer with WithContextDialer Signed-off-by: Justen Martin <jmart@the-coder.com>

view details

lzhfromustc

commit sha 49fbb9c9854ff18ad9304f435c7c6722b0b4cfdb

registry: add a critical section to protect authTransport.modReq Signed-off-by: Ziheng Liu <lzhfromustc@gmail.com>

view details

Ziheng Liu

commit sha 6233217a31395b69aa814c7d3db5cf844eb87437

integration/internal/container: fix a goroutine leak bug by adding 1 buffer Signed-off-by: Ziheng Liu <lzhfromustc@gmail.com>

view details

Kir Kolyshkin

commit sha 9d4e81e8bf0d52a063c46a3dc826f7e85068b07d

hack/validate/vendor: print diff for modified files In case some files were modified (rather than merely added or removed), we're curious to see the diff for those. Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>

view details

Kir Kolyshkin

commit sha 4be12ad3d04aefe6d5822d426813b33d2d4f9a7e

hack/validate/vendor: shellcheck fixes The export statement is definitely not needed. The rest is obvious. > In hack/validate/vendor line 3: > export SCRIPTDIR="$( cd "$( dirname "${BASH_SOURCE[0]}" )" && pwd )" > ^-- SC2155: Declare and assign separately to avoid masking return values. > > > In hack/validate/vendor line 43: > if ls -d vendor/$f > /dev/null 2>&1; then > ^-- SC2086: Double quote to prevent globbing and word splitting. > > > In hack/validate/vendor line 44: > found=$(find vendor/$f -iregex '.*LICENSE.*' -or -iregex '.*COPYRIGHT.*' -or -iregex '.*COPYING.*' | wc -l) > ^-- SC2086: Double quote to prevent globbing and word splitting. > > > In hack/validate/vendor line 45: > if [ $found -eq 0 ]; then > ^-- SC2086: Double quote to prevent globbing and word splitting. Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>

view details

Kir Kolyshkin

commit sha 57910190288c71242d914c292930a496d05f30cb

hack/validate/vendor: simplify looking for license It was suggested that we use '.*\(COPYING\|LICENSE\|COPYRIGHT\).*' as an argument to `find -iregex`, and this is how it all started. Next thing, there is no COPYRIGHT in any of the vendored packages, so it can be removed for good. Next, we should not look too deep inside the package directory, as the license should be in its root directory, so add `-maxdepth 1` to `find`. This should also speed things up. Finally, since we're not using the recursion feature of `find`, it can be replaced with `echo | grep`. While at it, * avoid temporary $pkgs variable as it is only used once; * replace `ls -d "vendor/$f" > /dev/null 2>&1` with `test -d`. Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>

view details

Sam Whited

commit sha d6a91ca71c655f71c171e375b787c9c8b361c19e

Rename DCO check param in Jenkinsfile Previously it was a negative parameter for skiping the DCO check, but this is different from other checks. It was requested that I change this in #40023 but I'm factoring it out as an unrelated change. Signed-off-by: Sam Whited <sam@samwhited.com>

view details

Sebastiaan van Stijn

commit sha 9a7e96b5b7e97e034ce7bb0f1e7788d1bd881c7f

Rename "v1" to "statsV1" follow-up to 27552ceb15bca544820229e574427d4c1d6ef585, where this was left as a review comment, but the PR was already merged. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

view details

Kirill Kolyshkin

commit sha 7cde98488c2cfd7c3bc5a4a9044047cdab596663

Merge pull request #40159 from SamWhited/jenkins_dco_var_name Rename DCO check param in Jenkinsfile

view details

Kirill Kolyshkin

commit sha 76dbd884d3f1a02dc193305d2ac5824bcd3e4f0f

Merge pull request #40167 from thaJeztah/stats_alias Rename "v1" to "statsV1"

view details

Brian Goff

commit sha 6f8c671d702197a189d162d86a3f4cccfa5a3db2

Merge pull request #39495 from hannseman/network-attachment-config-docs Update service networks documentation

view details

Sebastiaan van Stijn

commit sha 3df4f86f21fbcae3535e2231828dce16a1940dbb

swagger: fix "generated code" comment not in correct format As described in https://golang.org/s/generatedcode, Go has a formalized format that should be used to indicate that a file is generated. Matching that format helps linters to skip generated files; From https://golang.org/s/generatedcode (https://github.com/golang/go/issues/13560#issuecomment-288457920); > Generated files are marked by a line of text that matches the regular expression, in Go syntax: > > ^// Code generated .* DO NOT EDIT\.$ > > The `.*` means the tool can put whatever folderol it wants in there, but the comment > must be a single line and must start with `Code generated` and end with `DO NOT EDIT.`, > with a period. > > The text may appear anywhere in the file. This patch updates the template used for our generated types to match that format. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

view details

Sebastiaan van Stijn

commit sha c511db70ed39f344f41ea8773cc9264a1eeddfda

api/types: re-generate with new template Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

view details

Sebastiaan van Stijn

commit sha 6186e9fe8794660d669f19a2e2ba7127321b817f

hack/make/.go-autogen: fix "generated code" comment not in correct format As described in https://golang.org/s/generatedcode, Go has a formalized format that should be used to indicate that a file is generated. Matching that format helps linters to skip generated files; From https://golang.org/s/generatedcode (https://github.com/golang/go/issues/13560#issuecomment-288457920); > Generated files are marked by a line of text that matches the regular expression, in Go syntax: > > ^// Code generated .* DO NOT EDIT\.$ > > The `.*` means the tool can put whatever folderol it wants in there, but the comment > must be a single line and must start with `Code generated` and end with `DO NOT EDIT.`, > with a period. > > The text may appear anywhere in the file. This patch updates the autogenerated code to match that format. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

view details

Brian Goff

commit sha 47c5c67ed825589b0d88d98d05d81c5d22b3e9a9

Merge pull request #40032 from jmartin84/fix-grpc-withdialer-deprecation-warning Fix grpc withdialer deprecation warning

view details

Kirill Kolyshkin

commit sha c36460c437c8c515c543dd31afcbb5c2a9f5dd48

Merge pull request #40077 from thaJeztah/fix_autogen_detection Update "auto-generate" comments to improve detection by linters

view details

Sam Whited

commit sha b96a0c775400821d80972619fbfe6a2070f3e9ba

Add daemon options required by buildkit tests Signed-off-by: Sam Whited <sam@samwhited.com>

view details

Sebastiaan van Stijn

commit sha 31abc6c089eb5acc8161f480335b33b12564a565

Merge pull request #40177 from SamWhited/buildkit_test_options Add daemon options required by buildkit tests

view details

Sam Whited

commit sha 0c9b232bf5263ab896637b394308510c4cfbd45d

Remove unused GlobalFlags Signed-off-by: Sam Whited <sam@samwhited.com>

view details

push time in 9 days

push eventsteveazz/moby

Hannes Ljungberg

commit sha 4d09fab232ed282d020afbe1e0935b53379df4ad

Update service networks documentation The previous description stated that an array of names / ids could be passed when the API in reality expects objects in the form of NetworkAttachmentConfig. This is fixed by updating the description and adding a definition for NetworkAttachmentConfig. Signed-off-by: Hannes Ljungberg <hannes@5monkeys.se>

view details

Justen Martin

commit sha 3b49bd1d840d64ec603333eae28655b9ff5edc0c

replaced call to deprecated grpc method WithDialer with WithContextDialer Signed-off-by: Justen Martin <jmart@the-coder.com>

view details

lzhfromustc

commit sha 49fbb9c9854ff18ad9304f435c7c6722b0b4cfdb

registry: add a critical section to protect authTransport.modReq Signed-off-by: Ziheng Liu <lzhfromustc@gmail.com>

view details

Ziheng Liu

commit sha 6233217a31395b69aa814c7d3db5cf844eb87437

integration/internal/container: fix a goroutine leak bug by adding 1 buffer Signed-off-by: Ziheng Liu <lzhfromustc@gmail.com>

view details

Kir Kolyshkin

commit sha 9d4e81e8bf0d52a063c46a3dc826f7e85068b07d

hack/validate/vendor: print diff for modified files In case some files were modified (rather than merely added or removed), we're curious to see the diff for those. Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>

view details

Kir Kolyshkin

commit sha 4be12ad3d04aefe6d5822d426813b33d2d4f9a7e

hack/validate/vendor: shellcheck fixes The export statement is definitely not needed. The rest is obvious. > In hack/validate/vendor line 3: > export SCRIPTDIR="$( cd "$( dirname "${BASH_SOURCE[0]}" )" && pwd )" > ^-- SC2155: Declare and assign separately to avoid masking return values. > > > In hack/validate/vendor line 43: > if ls -d vendor/$f > /dev/null 2>&1; then > ^-- SC2086: Double quote to prevent globbing and word splitting. > > > In hack/validate/vendor line 44: > found=$(find vendor/$f -iregex '.*LICENSE.*' -or -iregex '.*COPYRIGHT.*' -or -iregex '.*COPYING.*' | wc -l) > ^-- SC2086: Double quote to prevent globbing and word splitting. > > > In hack/validate/vendor line 45: > if [ $found -eq 0 ]; then > ^-- SC2086: Double quote to prevent globbing and word splitting. Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>

view details

Kir Kolyshkin

commit sha 57910190288c71242d914c292930a496d05f30cb

hack/validate/vendor: simplify looking for license It was suggested that we use '.*\(COPYING\|LICENSE\|COPYRIGHT\).*' as an argument to `find -iregex`, and this is how it all started. Next thing, there is no COPYRIGHT in any of the vendored packages, so it can be removed for good. Next, we should not look too deep inside the package directory, as the license should be in its root directory, so add `-maxdepth 1` to `find`. This should also speed things up. Finally, since we're not using the recursion feature of `find`, it can be replaced with `echo | grep`. While at it, * avoid temporary $pkgs variable as it is only used once; * replace `ls -d "vendor/$f" > /dev/null 2>&1` with `test -d`. Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>

view details

Sam Whited

commit sha d6a91ca71c655f71c171e375b787c9c8b361c19e

Rename DCO check param in Jenkinsfile Previously it was a negative parameter for skiping the DCO check, but this is different from other checks. It was requested that I change this in #40023 but I'm factoring it out as an unrelated change. Signed-off-by: Sam Whited <sam@samwhited.com>

view details

Sebastiaan van Stijn

commit sha 9a7e96b5b7e97e034ce7bb0f1e7788d1bd881c7f

Rename "v1" to "statsV1" follow-up to 27552ceb15bca544820229e574427d4c1d6ef585, where this was left as a review comment, but the PR was already merged. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

view details

Kirill Kolyshkin

commit sha 7cde98488c2cfd7c3bc5a4a9044047cdab596663

Merge pull request #40159 from SamWhited/jenkins_dco_var_name Rename DCO check param in Jenkinsfile

view details

Kirill Kolyshkin

commit sha 76dbd884d3f1a02dc193305d2ac5824bcd3e4f0f

Merge pull request #40167 from thaJeztah/stats_alias Rename "v1" to "statsV1"

view details

Brian Goff

commit sha 6f8c671d702197a189d162d86a3f4cccfa5a3db2

Merge pull request #39495 from hannseman/network-attachment-config-docs Update service networks documentation

view details

Sebastiaan van Stijn

commit sha 3df4f86f21fbcae3535e2231828dce16a1940dbb

swagger: fix "generated code" comment not in correct format As described in https://golang.org/s/generatedcode, Go has a formalized format that should be used to indicate that a file is generated. Matching that format helps linters to skip generated files; From https://golang.org/s/generatedcode (https://github.com/golang/go/issues/13560#issuecomment-288457920); > Generated files are marked by a line of text that matches the regular expression, in Go syntax: > > ^// Code generated .* DO NOT EDIT\.$ > > The `.*` means the tool can put whatever folderol it wants in there, but the comment > must be a single line and must start with `Code generated` and end with `DO NOT EDIT.`, > with a period. > > The text may appear anywhere in the file. This patch updates the template used for our generated types to match that format. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

view details

Sebastiaan van Stijn

commit sha c511db70ed39f344f41ea8773cc9264a1eeddfda

api/types: re-generate with new template Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

view details

Sebastiaan van Stijn

commit sha 6186e9fe8794660d669f19a2e2ba7127321b817f

hack/make/.go-autogen: fix "generated code" comment not in correct format As described in https://golang.org/s/generatedcode, Go has a formalized format that should be used to indicate that a file is generated. Matching that format helps linters to skip generated files; From https://golang.org/s/generatedcode (https://github.com/golang/go/issues/13560#issuecomment-288457920); > Generated files are marked by a line of text that matches the regular expression, in Go syntax: > > ^// Code generated .* DO NOT EDIT\.$ > > The `.*` means the tool can put whatever folderol it wants in there, but the comment > must be a single line and must start with `Code generated` and end with `DO NOT EDIT.`, > with a period. > > The text may appear anywhere in the file. This patch updates the autogenerated code to match that format. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

view details

Brian Goff

commit sha 47c5c67ed825589b0d88d98d05d81c5d22b3e9a9

Merge pull request #40032 from jmartin84/fix-grpc-withdialer-deprecation-warning Fix grpc withdialer deprecation warning

view details

Kirill Kolyshkin

commit sha c36460c437c8c515c543dd31afcbb5c2a9f5dd48

Merge pull request #40077 from thaJeztah/fix_autogen_detection Update "auto-generate" comments to improve detection by linters

view details

Sam Whited

commit sha b96a0c775400821d80972619fbfe6a2070f3e9ba

Add daemon options required by buildkit tests Signed-off-by: Sam Whited <sam@samwhited.com>

view details

Sebastiaan van Stijn

commit sha 31abc6c089eb5acc8161f480335b33b12564a565

Merge pull request #40177 from SamWhited/buildkit_test_options Add daemon options required by buildkit tests

view details

Sam Whited

commit sha 0c9b232bf5263ab896637b394308510c4cfbd45d

Remove unused GlobalFlags Signed-off-by: Sam Whited <sam@samwhited.com>

view details

push time in 9 days

push eventsteveazz/moby

Steve Azzopardi

commit sha fcea52dcb3f3eb681f80eaf600ace4ee749d915c

Add check for pipe for bind volume When the mount type is set to `bind` check that the target is not a named pipe. Signed-off-by: Steve Azzopardi <sazzopardi@gitlab.com>

view details

push time in 9 days

push eventsteveazz/closeby

Steve Azzopardi

commit sha c2f810f8c3244a5aab589ecbdb9d41ab6071e4b7

Run on self hosted

view details

push time in 10 days

push eventsteveazz/moby

Steve Azzopardi

commit sha 0045314cd54f4c624aa8c5ca03a2e54d9b2110f0

Remove error return on !exists On Linux, volume binding creates the directory on the host. This conditional check on Windows was preventing Windows Containers from creating the directory producing inconsistent behavior between platforms. Signed-off-by: Steve Azzopardi <sazzopardi@gitlab.com>

view details

Steve Azzopardi

commit sha 4f6bb4f75c69d000fa7a31c849ac98a988dd2ec8

Move validation for bind source on volume mount Create a new `mountValidator` called `validateBindSourceExists` which checks whether the source of the volume binding exists or not. Don't use this validation for `ParseMountRaw` to remove the feature parity between Windows and Linux were using the `-v` flag and the directory doesn't exist, it is automatically created. Signed-off-by: Steve Azzopardi <sazzopardi@gitlab.com>

view details

Steve Azzopardi

commit sha 4e8270f247984a2985e61e4942007aa75379b389

Move source must be dir err to func For consistency, testtability and reuseability sake move the string to a func that returns a formatted error. Signed-off-by: Steve Azzopardi <sazzopardi@gitlab.com>

view details

Steve Azzopardi

commit sha 8db1088222be75c115d58c203837bc59968a0d36

Add specific mock for TestValidateMount Create a new mock specific for the test `TestValidateMount` which returns `exist` to `false` only when it's equal to `testSourcePathDoesNotExist` so that the validation is done correctly. Signed-off-by: Steve Azzopardi <sazzopardi@gitlab.com>

view details

Brian Goff

commit sha 95c6a34b8aeb2610d9d340c9bcf1a53cba869038

Make parser tests a little easier to read and decipher for test fails Signed-off-by: Brian Goff <cpuguy83@gmail.com>

view details

push time in 15 days

push eventsteveazz/moby

Drew Erny

commit sha a84a78e9767d82abd4744dad9ce4fb3f64141a8f

Fix more grpc list message sizes There are a few more places, apparently, that List operations against Swarm exist, besides just in the List methods. This increases the max received message size in those places. Signed-off-by: Drew Erny <drew.erny@docker.com>

view details

Tibor Vass

commit sha 7410f1a859063d4ed3d8fca44f27bdde4c2cb5a3

pkg/archive: keep walkRoot clean if source is / Previously, getWalkRoot("/", "foo") would return "//foo" Now it returns "/foo" Signed-off-by: Tibor Vass <tibor@docker.com>

view details

Sebastiaan van Stijn

commit sha fb5fe241b5931c7031fc4aa2ad4ca61159888df1

Merge pull request #39357 from tiborvass/cp-slash-fix Fix docker cp when container source path is /

view details

Sebastiaan van Stijn

commit sha d5669ec1c6eedcd5dd8b0ecd615638934561daa4

Update containerd to v1.2.7 From the release notes: https://github.com/containerd/containerd/releases/tag/v1.2.7 > Welcome to the v1.2.7 release of containerd! > > The seventh patch release for containerd 1.2 introduces OCI image > descriptor annotation support and contains fixes for containerd shim logs, > container stop/deletion, cri plugin and selinux. > > It also contains several important bug fixes for goroutine and file > descriptor leakage in containerd and containerd shims. > > Notable Updates > > - Support annotations in the OCI image descriptor, and filtering image by annotations. containerd/containerd#3254 > - Support context timeout in ttrpc which can help avoid containerd hangs when a shim is unresponsive. containerd/ttrpc#31 > - Fix a bug that containerd shim leaks goroutine and file descriptor after containerd restarts. containerd/ttrpc#37 > - Fix a bug that a container can't be deleted if first deletion attempt is canceled or timeout. containerd/containerd#3264 > - Fix a bug that containerd leaks file descriptor when using v2 containerd shims, e.g. containerd-shim-runc-v1. containerd/containerd#3273 > - Fix a bug that a container with lingering processes can't terminate when it shares pid namespace with another container. moby/moby#38978 > - Fix a bug that containerd can't read shim logs after restart. containerd/containerd#3282 > - Fix a bug that shim_debug option is not honored for existing containerd shims after containerd restarts. containerd/containerd#3283 > - cri: Fix a bug that a container can't be stopped when the exit event is not successfully published by the containerd shim. containerd/containerd#3125, containerd/containerd#3177 > - cri: Fix a bug that exec process is not cleaned up if grpc context is canceled or timeout. contaienrd/cri#1159 > - Fix a selinux keyring labeling issue by updating runc to v1.0.0-rc.8 and selinux library to v1.2.2. opencontainers/selinux#50 > - Update ttrpc to f82148331ad2181edea8f3f649a1f7add6c3f9c2. containerd/containerd#3316 > - Update cri to 49ca74043390bc2eeea7a45a46005fbec58a3f88. containerd/containerd#3330 Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

view details

Kir Kolyshkin

commit sha a77e147d322c153ae1c2ae0ee45c1835c109e231

For ipvlan tests check that the ipvlan module is enabled (instead of just ensuring the kernel version is greater than 4.2) Co-Authored-By: Jim Ehrismann <jim-docker@users.noreply.github.com> Co-Authored-By: Sebastiaan van Stijn <thaJeztah@users.noreply.github.com> Signed-off-by: Jim Ehrismann <jim.ehrismann@docker.com>

view details

andrea

commit sha 0a9842a705b1574b2553dea409bec0c6b05e9c9f

Create SECURITY.md for GitHub security policy page What would you like to be added: GitHub has a [security policy](https://github.com/moby/moby/security/policy) page that uses a SECURITY.md file from the repository to show the project's security policy. Why is this needed: Adding this file makes it easier for security researchers to learn about the correct place to report a vulnerability in the [Moby](https://github.com/moby/moby) project. Signed-off-by: Andrea <crypto.andrea@protonmail.ch>

view details

Brian Goff

commit sha 882e26a4a883c38a838232852529c86b90f8cf28

Merge pull request #39364 from thaJeztah/bump_containerd_1.2.7 Update containerd to v1.2.7

view details

Tibor Vass

commit sha f23a51a8603a92b124e5037106958baf8c70c5e1

Revert "Remove Schema1 integration test suite" This reverts commit 13b7d11be1a97ebe82b3a0f0b5db9b873a481637. Signed-off-by: Tibor Vass <tibor@docker.com>

view details

Tibor Vass

commit sha 0811297608499e8be473473b80eaac9d2ced9dd8

use gotest.tools assertions in docker_cli_push_test.go Signed-off-by: Tibor Vass <tibor@docker.com>

view details

Tibor Vass

commit sha f695e98cb7cbb39eb7e5bd0a268ae1cd2e594fc1

Revert "Remove the rest of v1 manifest support" This reverts commit 98fc09128b3f8221680bd22c2de5b893bd3d7ef8 in order to keep registry v2 schema1 handling and libtrust-key-based engine ID. Because registry v2 schema1 was not officially deprecated and registries are still relying on it, this patch puts its logic back. However, registry v1 relics are not added back since v1 logic has been removed a while ago. This also fixes an engine upgrade issue in a swarm cluster. It was relying on the Engine ID to be the same upon upgrade, but the mentioned commit modified the logic to use UUID and from a different file. Since the libtrust key is always needed to support v2 schema1 pushes, that the old engine ID is based on the libtrust key, and that the engine ID needs to be conserved across upgrades, adding a UUID-based engine ID logic seems to add more complexity than it solves the problems. Hence reverting the engine ID changes as well. Signed-off-by: Tibor Vass <tibor@docker.com>

view details

Tibor Vass

commit sha 53dad9f0274fcc1ec742f9411142382c83d08ff9

Remove v1 manifest code Signed-off-by: Tibor Vass <tibor@docker.com>

view details

Tibor Vass

commit sha f923321aae7a961e94c00207cc80e51d410c676d

Add test for keeping same daemon ID on upgrade Signed-off-by: Tibor Vass <tibor@docker.com>

view details

Tibor Vass

commit sha d35f8f4329bef6de0db3457959d81a32c2a530c6

Add deprecation message for schema1 This will add a warning log in the daemon, and will send the message to be displayed by the CLI. Signed-off-by: Tibor Vass <tibor@docker.com>

view details

Tibor Vass

commit sha 3f1cdd5364d87f9a4fa4f62428f4e4bccbb594e4

validate: temporarily disable deprecate-integration-cli as part of a revert Signed-off-by: Tibor Vass <tibor@docker.com>

view details

Brian Goff

commit sha 8d1309222c58143c1e7fa02658e04d06e2e934ce

Merge pull request #39370 from da-edra/patch-1 Create SECURITY.md for GitHub security policy page

view details

Yong Tang

commit sha 1d792e6bbaf1463c152c975c32a4edc671c94ea8

Update SECURITY.md to have an option to keep name anonymous if requested. Signed-off-by: Yong Tang <yong.tang.github@outlook.com>

view details

Tobias Klauser

commit sha ba8a15694ae8036ec6589e468e25f87eae190a7c

Use functions from x/sys/unix to get number of CPUs on Linux Use Getpid and SchedGetaffinity from golang.org/x/sys/unix to get the number of CPUs in numCPU on Linux. Signed-off-by: Tobias Klauser <tklauser@distanz.ch>

view details

Tibor Vass

commit sha 4866f5139a0b0bc026aa4b0c916ee1071c695134

Merge pull request #39365 from tiborvass/deprecate-v2-schema1 Keep but deprecate registry v2 schema1 logic and revert to libtrust-key-based engine ID

view details

Brian Goff

commit sha 384c782721c7d0865b7d40ce7ca402022c690058

Merge pull request #39355 from tao12345666333/bump-golang-1.12.6 Bump Golang 1.12.6

view details

Tibor Vass

commit sha a9026e0e3f6c72d1c9a308216f8906ba03b528b1

Revert "validate: temporarily disable deprecate-integration-cli as part of a revert" This reverts commit 3f1cdd5364d87f9a4fa4f62428f4e4bccbb594e4. Signed-off-by: Tibor Vass <tibor@docker.com>

view details

push time in 15 days

push eventsteveazz/moby

Ethan Mosbaugh

commit sha 50c6a5fb07c873fd5c9ae3fb6294e0b11c689de2

Fix rate limiting for logger, increase refill rate Signed-off-by: Ethan Mosbaugh <ethan@replicated.com>

view details

Sebastiaan van Stijn

commit sha 4dc6b217d32ae2e90188d288367324df899386ef

Merge pull request #39359 from tiborvass/fix-test-compiling integration: get tests to compile again

view details

Brian Goff

commit sha 6db9f1c3d6e9ad634554cacaf197a435efcf8833

Add test for copying entire container rootfs CID=$(docker create alpine) docker cp $CID:/ out Signed-off-by: Brian Goff <cpuguy83@gmail.com> Signed-off-by: Tibor Vass <tibor@docker.com>

view details

Tibor Vass

commit sha 02f1eb89a42b4a9e91a8c80c213f7dc3193c75b9

add more tests Signed-off-by: Tibor Vass <tibor@docker.com>

view details

Tibor Vass

commit sha 171538c190ee3a1a8211946ab8fa78cdde54b47a

daemon: fix docker cp when container source is / Before 7a7357da, archive.TarResourceRebase was being used to copy files and folders from the container. That function splits the source path into a dirname + basename pair to support copying a file: if you wanted to tar `dir/file` it would tar from `dir` the file `file` (as part of the IncludedFiles option). However, that path splitting logic was kept for folders as well, which resulted in weird inputs to archive.TarWithOptions: if you wanted to tar `dir1/dir2` it would tar from `dir1` the directory `dir2` (as part of IncludedFiles option). Although it was weird, it worked fine until we started chrooting into the container rootfs when doing a `docker cp` with container source set to `/` (cf 3029e765). The fix is to only do the path splitting logic if the source is a file. Unfortunately, 7a7357da added support for LCOW by duplicating some of this subtle logic. Ideally we would need to do more refactoring of the archive codebase to properly encapsulate these behaviors behind well- documented APIs. This fix does not do that. Instead, it fixes the issue inline. Signed-off-by: Tibor Vass <tibor@docker.com>

view details

Drew Erny

commit sha a84a78e9767d82abd4744dad9ce4fb3f64141a8f

Fix more grpc list message sizes There are a few more places, apparently, that List operations against Swarm exist, besides just in the List methods. This increases the max received message size in those places. Signed-off-by: Drew Erny <drew.erny@docker.com>

view details

Tibor Vass

commit sha 7410f1a859063d4ed3d8fca44f27bdde4c2cb5a3

pkg/archive: keep walkRoot clean if source is / Previously, getWalkRoot("/", "foo") would return "//foo" Now it returns "/foo" Signed-off-by: Tibor Vass <tibor@docker.com>

view details

Sebastiaan van Stijn

commit sha fb5fe241b5931c7031fc4aa2ad4ca61159888df1

Merge pull request #39357 from tiborvass/cp-slash-fix Fix docker cp when container source path is /

view details

Sebastiaan van Stijn

commit sha d5669ec1c6eedcd5dd8b0ecd615638934561daa4

Update containerd to v1.2.7 From the release notes: https://github.com/containerd/containerd/releases/tag/v1.2.7 > Welcome to the v1.2.7 release of containerd! > > The seventh patch release for containerd 1.2 introduces OCI image > descriptor annotation support and contains fixes for containerd shim logs, > container stop/deletion, cri plugin and selinux. > > It also contains several important bug fixes for goroutine and file > descriptor leakage in containerd and containerd shims. > > Notable Updates > > - Support annotations in the OCI image descriptor, and filtering image by annotations. containerd/containerd#3254 > - Support context timeout in ttrpc which can help avoid containerd hangs when a shim is unresponsive. containerd/ttrpc#31 > - Fix a bug that containerd shim leaks goroutine and file descriptor after containerd restarts. containerd/ttrpc#37 > - Fix a bug that a container can't be deleted if first deletion attempt is canceled or timeout. containerd/containerd#3264 > - Fix a bug that containerd leaks file descriptor when using v2 containerd shims, e.g. containerd-shim-runc-v1. containerd/containerd#3273 > - Fix a bug that a container with lingering processes can't terminate when it shares pid namespace with another container. moby/moby#38978 > - Fix a bug that containerd can't read shim logs after restart. containerd/containerd#3282 > - Fix a bug that shim_debug option is not honored for existing containerd shims after containerd restarts. containerd/containerd#3283 > - cri: Fix a bug that a container can't be stopped when the exit event is not successfully published by the containerd shim. containerd/containerd#3125, containerd/containerd#3177 > - cri: Fix a bug that exec process is not cleaned up if grpc context is canceled or timeout. contaienrd/cri#1159 > - Fix a selinux keyring labeling issue by updating runc to v1.0.0-rc.8 and selinux library to v1.2.2. opencontainers/selinux#50 > - Update ttrpc to f82148331ad2181edea8f3f649a1f7add6c3f9c2. containerd/containerd#3316 > - Update cri to 49ca74043390bc2eeea7a45a46005fbec58a3f88. containerd/containerd#3330 Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

view details

Kir Kolyshkin

commit sha a77e147d322c153ae1c2ae0ee45c1835c109e231

For ipvlan tests check that the ipvlan module is enabled (instead of just ensuring the kernel version is greater than 4.2) Co-Authored-By: Jim Ehrismann <jim-docker@users.noreply.github.com> Co-Authored-By: Sebastiaan van Stijn <thaJeztah@users.noreply.github.com> Signed-off-by: Jim Ehrismann <jim.ehrismann@docker.com>

view details

andrea

commit sha 0a9842a705b1574b2553dea409bec0c6b05e9c9f

Create SECURITY.md for GitHub security policy page What would you like to be added: GitHub has a [security policy](https://github.com/moby/moby/security/policy) page that uses a SECURITY.md file from the repository to show the project's security policy. Why is this needed: Adding this file makes it easier for security researchers to learn about the correct place to report a vulnerability in the [Moby](https://github.com/moby/moby) project. Signed-off-by: Andrea <crypto.andrea@protonmail.ch>

view details

Brian Goff

commit sha 882e26a4a883c38a838232852529c86b90f8cf28

Merge pull request #39364 from thaJeztah/bump_containerd_1.2.7 Update containerd to v1.2.7

view details

Tibor Vass

commit sha f23a51a8603a92b124e5037106958baf8c70c5e1

Revert "Remove Schema1 integration test suite" This reverts commit 13b7d11be1a97ebe82b3a0f0b5db9b873a481637. Signed-off-by: Tibor Vass <tibor@docker.com>

view details

Tibor Vass

commit sha 0811297608499e8be473473b80eaac9d2ced9dd8

use gotest.tools assertions in docker_cli_push_test.go Signed-off-by: Tibor Vass <tibor@docker.com>

view details

Tibor Vass

commit sha f695e98cb7cbb39eb7e5bd0a268ae1cd2e594fc1

Revert "Remove the rest of v1 manifest support" This reverts commit 98fc09128b3f8221680bd22c2de5b893bd3d7ef8 in order to keep registry v2 schema1 handling and libtrust-key-based engine ID. Because registry v2 schema1 was not officially deprecated and registries are still relying on it, this patch puts its logic back. However, registry v1 relics are not added back since v1 logic has been removed a while ago. This also fixes an engine upgrade issue in a swarm cluster. It was relying on the Engine ID to be the same upon upgrade, but the mentioned commit modified the logic to use UUID and from a different file. Since the libtrust key is always needed to support v2 schema1 pushes, that the old engine ID is based on the libtrust key, and that the engine ID needs to be conserved across upgrades, adding a UUID-based engine ID logic seems to add more complexity than it solves the problems. Hence reverting the engine ID changes as well. Signed-off-by: Tibor Vass <tibor@docker.com>

view details

Tibor Vass

commit sha 53dad9f0274fcc1ec742f9411142382c83d08ff9

Remove v1 manifest code Signed-off-by: Tibor Vass <tibor@docker.com>

view details

Tibor Vass

commit sha f923321aae7a961e94c00207cc80e51d410c676d

Add test for keeping same daemon ID on upgrade Signed-off-by: Tibor Vass <tibor@docker.com>

view details

Tibor Vass

commit sha d35f8f4329bef6de0db3457959d81a32c2a530c6

Add deprecation message for schema1 This will add a warning log in the daemon, and will send the message to be displayed by the CLI. Signed-off-by: Tibor Vass <tibor@docker.com>

view details

Tibor Vass

commit sha 3f1cdd5364d87f9a4fa4f62428f4e4bccbb594e4

validate: temporarily disable deprecate-integration-cli as part of a revert Signed-off-by: Tibor Vass <tibor@docker.com>

view details

Brian Goff

commit sha 8d1309222c58143c1e7fa02658e04d06e2e934ce

Merge pull request #39370 from da-edra/patch-1 Create SECURITY.md for GitHub security policy page

view details

push time in 15 days

pull request commentmoby/moby

Remove error return on !exists

Let me try getting this discussed in the maintainers meeting / review session (I might have another look at it before that).

In the meantime; could you rebase this PR? We replaced our CI with a new Jenkins, so it would be helpful to have it up to date, and have a fresh run of CI

Sure, I will try and find time to update it this week!

steveazz

comment created time in 16 days

pull request commentmoby/moby

Remove error return on !exists

@tallandtree there is one comment from me in https://github.com/moby/moby/pull/38465#issuecomment-452702606 that I'd like guidance on so we get the CI green after that it should be ready for review.

steveazz

comment created time in 17 days

issue commentgolangci/golangci-lint

golint errors are not reported

@alexcpn that seems to be a different error then "Go lints not showing" opening a different issue might be ideal to keep the discussion focus 🙇

mantzas

comment created time in 2 months

issue commentgolangci/golangci-lint

golint errors are not reported

@jirfag you might want to close this 🙇

mantzas

comment created time in 2 months

issue commentgolangci/golangci-lint

golint errors are not reported

@mantzas to upgrade? I used curl -sfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh| sh -s -- -b $(go env GOPATH)/bin v1.18.0 that is specified in the install docs.

The config I used to run my golint is like the following:

linters:
  disable-all: true
  enable:
    - golint
    - govet
    - gofmt
    - gocyclo

issues:
  exclude-use-default: false
  exclude:
    # should have a package comment, unless it's in another file for this package (golint)
    - 'in another file for this package'

linters-settings:
  gocyclo:
    min-complexity: 5
  golint:
    # minimal confidence for issues, default is 0.8
    min-confidence: 0
  govet:
    # report about shadowed variables
    check-shadowing: true

output:
  # colored-line-number|line-number|json|tab|checkstyle|code-climate, default is "colored-line-number"
  format: colored-line-number

  # print lines of code with issue, default is true
  print-issued-lines: false

  # print linter name in the end of issue text, default is true
  print-linter-name: true
mantzas

comment created time in 2 months

issue commentgolangci/golangci-lint

golint errors are not reported

I was experiencing the same issue, but when I updated to v1.18.0 it fixed the problem for me. @mantzas @alexcpn can you see if updating to the latest version fixes it for you?

mantzas

comment created time in 2 months

push eventsteveazz/closeby

Steve Azzopardi

commit sha fe964d7b3ae6399eb1951b4ad28e95e633272a3a

Add go modules

view details

Steve Azzopardi

commit sha 1e7fa4784f1d5a55172ede2840c2d4f64cc3a31e

Remove go dep

view details

Steve Azzopardi

commit sha 6581d763f08b151958db668346a1fc438b119b7b

Build correct binary

view details

Steve Azzopardi

commit sha 0e6253e8962df5313ced774f3c2df54b94963ef9

Merge pull request #1 from steveazz/fix-build Fix GitHub CI builds

view details

Steve Azzopardi

commit sha 94212d38537d19dbb7c1defd823652fee996cf7b

Build on Windows

view details

push time in 3 months

PR opened steveazz/closeby

Build on Windows
+4 -1

0 comment

1 changed file

pr created time in 3 months

create barnchsteveazz/closeby

branch : add-windows

created branch time in 3 months

push eventsteveazz/closeby

Steve Azzopardi

commit sha fe964d7b3ae6399eb1951b4ad28e95e633272a3a

Add go modules

view details

Steve Azzopardi

commit sha 1e7fa4784f1d5a55172ede2840c2d4f64cc3a31e

Remove go dep

view details

Steve Azzopardi

commit sha 6581d763f08b151958db668346a1fc438b119b7b

Build correct binary

view details

Steve Azzopardi

commit sha 0e6253e8962df5313ced774f3c2df54b94963ef9

Merge pull request #1 from steveazz/fix-build Fix GitHub CI builds

view details

push time in 3 months

PR merged steveazz/closeby

Fix GitHub CI builds
+32 -20835

0 comment

93 changed files

steveazz

pr closed time in 3 months

push eventsteveazz/closeby

Steve Azzopardi

commit sha 6581d763f08b151958db668346a1fc438b119b7b

Build correct binary

view details

push time in 3 months

push eventsteveazz/closeby

Steve Azzopardi

commit sha 1e7fa4784f1d5a55172ede2840c2d4f64cc3a31e

Remove go dep

view details

push time in 3 months

push eventsteveazz/closeby

Steve Azzopardi

commit sha 53cb8defce2dfb47fddd7b8b98c9ed85d6df278b

wip

view details

push time in 3 months

push eventsteveazz/closeby

Steve Azzopardi

commit sha 4d6428e8d16d1ad0f2cea016f2dce9f6ca19c206

wip

view details

push time in 3 months

push eventsteveazz/closeby

Steve Azzopardi

commit sha fe964d7b3ae6399eb1951b4ad28e95e633272a3a

Add go modules

view details

push time in 3 months

push eventsteveazz/closeby

Steve Azzopardi

commit sha 005e001ff601959032fd78cd5af8ed9c410e25db

Add new GitHub CI/CD

view details

Steve Azzopardi

commit sha 5f641d37b15fb098d4bbf3947dd850d86b04d416

Add go modules

view details

push time in 3 months

PR opened steveazz/closeby

Add go modules
+21 -0

0 comment

2 changed files

pr created time in 3 months

create barnchsteveazz/closeby

branch : fix-build

created branch time in 3 months

push eventsteveazz/closeby

Steve Azzopardi

commit sha 005e001ff601959032fd78cd5af8ed9c410e25db

Add new GitHub CI/CD

view details

push time in 3 months

push eventsteveazz/closeby

Steve Azzopardi

commit sha 5de9e74578ea8db84987ba3cfcfdf8dd618200e1

Remove old GitHub actions

view details

push time in 3 months

more