profile
viewpoint

sqal/popper.js 1

A kickass library to manage your poppers

sqal/babel 0

:tropical_fish: Babel is a compiler for writing next generation JavaScript.

sqal/cash 0

An absurdly small jQuery alternative for modern browsers

sqal/create-react-app 0

Set up a modern web app by running one command.

sqal/dush 0

:clap: Microscopic & functional event emitter in ~350 bytes, extensible through plugins.

sqal/final-form 0

🏁 Framework agnostic, high performance, subscription-based form state management

sqal/headroom.js 0

Give your pages some headroom. Hide your header until you need it

sqal/javascript 0

JavaScript Style Guide

sqal/perfect-scrollbar 0

Minimalistic but perfect custom scrollbar plugin

starteddessalines/lemmy

started time in 18 hours

startedhsnaydd/buttono

started time in a day

startedrefactoringui/heroicons

started time in 3 days

startedevanw/esbuild

started time in 4 days

issue commentGoogleChromeLabs/preload-webpack-plugin

How to preload js file in multiple html page?

I have the same issue, i believe we have to wait for https://github.com/GoogleChromeLabs/preload-webpack-plugin/pull/109

happylindz

comment created time in 9 days

startedKong/swrv

started time in 11 days

startedstreamich/nano-css

started time in 13 days

startedelninotech/uppload

started time in 16 days

startedionic-team/ionicons

started time in 18 days

startedphuoc-ng/csslayout

started time in 20 days

startedAnalyticalGraphicsInc/cesium

started time in a month

issue openedJetBrains/svg-sprite-loader

npm-shrinkwrap needs to be regenerated or removed

Do you want to request a feature, report a bug or ask a question? Bug

What is the current behavior? I recently upgraded this plugin from 4.1.6 to the latest version 4.2.0 and all icons in my app disappeared. After some digging, I found this was caused by some old version of svg-baker, reference issue https://github.com/JetBrains/svg-mixer/issues/2. This dependency was updated in the commit 02d0c33743d98792fc6449791 before releasing 4.2.0 but there are still old dependencies listed in npm-shrinkwrap.json.

What is the expected behavior? npm should install correct dependencies.

If this is a feature request, what is motivation or use case for changing the behavior?

Please tell us about your environment:

  • Node.js version: -
  • webpack version: -
  • svg-sprite-loader version: 4.2.0
  • OS type & version: -

Other information (e.g. detailed explanation, stacktraces, related issues, suggestions how to fix,

Remove npm-shrinkwrap (not sure why it's needed since the project using yarn lockfile).

created time in a month

starteddaveberning/griddle

started time in a month

pull request commentvuejs/rfcs

Portal functionality

@JosephSilber

If we can't use the same target for multiple portals, how can we use it, for example, for multiple stacked modals?

Who said you can't ? You can use Portal to mount as many elements as you wan in the same target node. You can create a functional component that renders Portal and mounts target element in the DOM just once, then you can reuse this component anywhere you want.

// DialogPortal.js

import { h, Portal } from 'vue';

let target = null

export function DialogPortal(_, { slots }) {
  if (!target) {
    target = document.createElement('div')
    target.id = 'dialog-root';
    document.body.appendChild(target)
  }

  return h(Portal, { target }, slots.default())
}

// Dialog.vue

<template>
  <DialogPortal>
    <div class="dialog">
      dialog content
    </div>
  </DialogPortal>
</template>
LinusBorg

comment created time in a month

issue commentvuejs/vue-next

Can let emit return a Promise array?please

A similar issue was reported in 2.x long time ago https://github.com/vuejs/vue/issues/5443

however, emit in vue 3 works differently than $emit in 2.x. In vue 3, emit basically calls a prop which name starts with onXXX so emit('click') is equivalent to calling props.onClick(). As we can see in the source code emit currently doesn't return anything so you should probably try with calling the onClick prop directly:

// Promise.all expects an array
await Promise.all([
  props.onClick()
])
LastHeaven

comment created time in a month

startedlukeed/taskr

started time in a month

startedryanelian/instapack

started time in a month

startedlukeed/klona

started time in a month

fork sqal/javascript

JavaScript Style Guide

fork in 2 months

pull request commentvuejs/rfcs

Remove data object declaration

object declaration should no longer be valid and produce an error with an explanation that only function declaration is valid for a component. It should also contain a link to an API and migration example.

hmm.. I am confused, because it always worked that way. There is appropriate warning in dev mode if you try to define data using plain object instead of function.

https://jsfiddle.net/vp4k9ebt/

CyberAP

comment created time in 2 months

pull request commentvuejs/rfcs

Remove data object declaration

object declaration should no longer be valid and produce an error with an explanation that only function declaration is valid for a component. It should also contain a link to an API and migration example.

hmm.. I am confused, because it always worked that way. There is appropriate warning in dev mode if you try to define data using plain object instead of function https://github.com/vuejs/vue/blob/33e669b22f69a1f9c9147528360fe0bba85534f0/src/core/instance/state.js#L117

CyberAP

comment created time in 2 months

startedvisualfanatic/svg-to-vue

started time in 2 months

issue comments-yadav/react-number-format

can't set limit for react number format

I'm having a similar problem right now and wonder if there is some workaround or perhaps would be better to add a new props to the lib like min and max

Lmjcvm

comment created time in 2 months

issue openedvuejs/vue-next

Attributes gets converted to camelCase without explicit props declaration

Version

3.0.0-alpha.1

Reproduction link

https://codesandbox.io/s/zen-field-ewni3

Steps to reproduce

import { h, createApp } from "vue";

function Button(props, { attrs }) {
  console.log({
    props,
    attrs
  });
}

const App = {
  setup() {
    return () => [
      h(Button, {
        "data-id": 1,
        "aria-label": "Close",
      })
    ];
  }
};

createApp().mount(App, "#root");

What is expected?

Button's props should be in camelCase and attrs in kebab-case

What is actually happening?

Without explicit props declaration Button attrs keys are converted to camelCase.

<!-- generated by vue-issues. DO NOT REMOVE -->

created time in 2 months

issue commentvuejs/vue-next

Support passing down slots with v-bind like in 2.x

I fully understand that :) I was just playing with the alpha today and noticed that this feature is not implemented so I thought I'd open a new issue and maybe someone with free time would like to contribute to vue 3 and add this feature.

sqal

comment created time in 2 months

issue openedvuejs/vue-next

Support passing down slots with v-bind like in 2.x

What problem does this feature solve?

https://github.com/vuejs/vue/issues/7178

It seems like this still needs to be implemented, in v3 because currently it passes slots as component's prop instead of its children.

https://vue-next-template-explorer.netlify.com/#%7B%22src%22%3A%22%3Cchild%20v-bind%3D%5C%22%7B%20slots%3A%20%24slots%20%7D%5C%22%3E%3C%2Fchild%3E%22%2C%22options%22%3A%7B%22mode%22%3A%22module%22%2C%22prefixIdentifiers%22%3Afalse%2C%22hoistStatic%22%3Atrue%2C%22cacheHandlers%22%3Atrue%2C%22scopeId%22%3Anull%7D%7D

What does the proposed API look like?

<child v-bind="{ slots: $slots }"></child>

<!-- generated by vue-issues. DO NOT REMOVE -->

created time in 2 months

issue commentvuejs/vue-next

Behavior changed in the rendering of primitive values

@posva of course, here's an example I do that all the time when writing components in plain JS

function render() {
  return h('div', [
    // isOpen is boolean
    props.isOpen && h('div', [])
  ])
}
sqal

comment created time in 2 months

issue closedvuejs/vue

Behavior changed in the rendering of primitive values

Version

3.0.0-alpha.1

Reproduction link

2.x - https://jsfiddle.net/natuqebm/ 3.0.0-alpha.1 - https://jsfiddle.net/u7pt6gjo/

Steps to reproduce

Just open these above reproductions links

What is expected?

There is an inconsistency between Vue 2.x and the latest alpha. 3.x should not render a boolean values in the render function.

What is actually happening?

Renders 0falsetrueNaN instead of 0NaN

<!-- generated by vue-issues. DO NOT REMOVE -->

closed time in 2 months

sqal

issue commentvuejs/vue

Behavior changed in the rendering of primitive values

This should be filled in the vue-next repo, my apologies :D

sqal

comment created time in 2 months

issue openedvuejs/vue-next

Behavior changed in the rendering of primitive values

Version

3.0.0-alpha.1

Reproduction link

2.x - https://jsfiddle.net/natuqebm/ 3.0.0-alpha.1 - https://jsfiddle.net/u7pt6gjo/

Steps to reproduce

Just open these above reproductions links

What is expected?

There is an inconsistency between Vue 2.x and the latest alpha. 3.x should not render a boolean values in the render function.

What is actually happening?

Renders 0falsetrueNaN instead of 0NaN

<!-- generated by vue-issues. DO NOT REMOVE -->

created time in 2 months

issue openedvuejs/vue

Behavior changed in the rendering of primitive values

Version

3.0.0-alpha.1

Reproduction link

2.x - https://jsfiddle.net/natuqebm/ 3.0.0-alpha.1 - https://jsfiddle.net/u7pt6gjo/

Steps to reproduce

Just open these above reproductions links

What is expected?

There is an inconsistency between Vue 2.x and the latest alpha. 3.x should not render a boolean values in the render function.

What is actually happening?

Renders 0falsetrueNaN instead of 0NaN

<!-- generated by vue-issues. DO NOT REMOVE -->

created time in 2 months

startedsw-yx/spark-joy

started time in 2 months

startedneutraltone/awesome-stock-resources

started time in 2 months

startedbytefury/crater

started time in 2 months

issue openedfinal-form/final-form

(4.18.6) isEqual regression

<!--

👋 Hey, thanks for taking an interest in 🏁 Final Form!

-->

Are you submitting a bug report or a feature request?

Bug report

<!-- For support request, please use Stack Overflow instead. This issue tracker is reserved for bugs and features. -->

What is the current behavior?

Seconds parameter passed to custom isEqual function is sometimes undefined

Please check reproduction example:

  1. Go to https://codesandbox.io/s/final-form-vanilla-js-demo-irobj
  2. Check console logs

You can see that array2 value is sometimes undefined.

What is the expected behavior?

array2 in isEqual function should always be an array.

Other information

Affected version: 4.18.6. It worked correctly in previous versions of Final Form

created time in 2 months

startedsboriskirov/fluiditype

started time in 3 months

pull request commentvuejs/rfcs

Composition API (revised from #42 Function-based Component API)

@ggedde yes, it will be possible to drop 2.x options features during compile time

https://github.com/vuejs/vue-next/search?q=FEATURE_OPTIONS&unscoped_q=FEATURE_OPTIONS

yyx990803

comment created time in 3 months

create barnchsqal/vue-next

branch : perf-tweaks

created branch time in 3 months

issue openedbabel/babel

@babel/plugin-proposal-null-coalescing-operator injects unnecessary variable

Bug Report

Current Behavior @babel/plugin-proposal-null-coalescing-operator creates unnecesary variable declaration when conditional expression is within function scope

Input Code https://babeljs.io/repl#?babili=false&browsers=&build=&builtIns=false&spec=false&loose=false&code_lz=GYVwdgxgLglg9mABACwIZgCYBsCmBhNMAcxwAoYwAHEKANVSxBwEpEBvAKEUQgQGcoiAG4MmiALyIK1OqJyIA_AsRRkMPgDoRjHAG4OAXyA&debug=false&forceAllTransforms=false&shippedProposals=false&circleciRepo=&evaluate=false&fileSize=false&timeTravel=false&sourceType=module&lineWrap=true&presets=es2015%2Creact%2Cstage-2&prettier=false&targets=&version=7.7.3&externalPlugins=

function handleChange(inputValue) {
  const value = inputValue ?? this.value;
}

Expected behavior/code I expect output to not have additional var _inputValue; declaration because it's unnecessary.

function handleChange(inputValue) {
  // since we don't accessing nested property in inputValue so the output should be:
  var value = inputValue !== null && inputValue !== void 0 ? inputValue : this.value;
}

Babel Configuration (.babelrc, package.json, cli command)

{
  presets: [
    ['@babel/preset-env', {
      useBuiltIns: true,
      loose: true,
      modules: false,
      corejs: 3,
    }],
  ],
  plugins: [
    '@babel/plugin-proposal-optional-chaining',
    '@babel/plugin-proposal-nullish-coalescing-operator'
  ],
}

Environment

  • Babel version(s): 7.7.2
  • Node/npm version: 13.1.0
  • OS: Windows 10
  • Monorepo: no
  • How you are using Babel: babel-loader

Possible Solution

Additional context/Screenshots

created time in 3 months

issue commentvuejs/vetur

Got "valid-v-for" if I write key in bind attribute

You should report this issue in the eslint-plugin-vue repository, this is not directly related to Vetur.

iigmir

comment created time in 4 months

pull request commentvuejs/rfcs

v-model API change

Regarding modelModifiers prop. I noticed that if I use more than one v-model on the component with different modifiers, then compiler creates modelModifiers prop with modifiers only from the first v-model. is this a bug?

Demo: https://vue-next-template-explorer.netlify.com/#%7B%22src%22%3A%22%3CComp%20%20%5Cr%5Cn%20%20v-model%3Aname.a.b%3D%5C%22name%5C%22%5Cr%5Cn%20%20v-model%3Aemail.c%3D%5C%22email%5C%22%5Cr%5Cn%2F%3E%22%2C%22options%22%3A%7B%22mode%22%3A%22module%22%2C%22prefixIdentifiers%22%3Afalse%2C%22hoistStatic%22%3Afalse%2C%22cacheHandlers%22%3Afalse%7D%7D

yyx990803

comment created time in 4 months

startedrachelandrew/gridbugs

started time in 4 months

starteddavidtheclark/focus-trap

started time in 4 months

startedmciastek/sal

started time in 4 months

startedwesbos/css-grid

started time in 4 months

startedtinacms/tinacms

started time in 4 months

startedposva/focus-trap-vue

started time in 4 months

startedHiswe/vh-check

started time in 4 months

startedalexreardon/raf-schd

started time in 4 months

issue commentvuejs/vue-loader

getLocalIdent option from css-loader doesn't work

@MitchTalmadge This issue was resolved a long time ago with release of vue-loader v15.0.0 :), read about the changes here https://vue-loader.vuejs.org/migrating.html#loader-inference

If you're using vue-cli you can easily configure css-loader's options for your needs in thevue.config.js like this:

module.exports = {
  css: {
    loaderOptions: {
      css: {
        modules: {
          getLocalIdent: () => {}
        },
      },
    }
  }
}
sqal

comment created time in 5 months

Pull request review commentvuejs/vue-next

feat(runtime-dom): support event options

 type EventValue = (Function | Function[]) & {   invoker?: Invoker | null } +type EventListenerOptions = {

You can use built-in AddEventListenerOptions type here instead of writing your own

CyberAP

comment created time in 5 months

startedkripod/standard-hooks

started time in 5 months

startedvuejs/vue-next

started time in 5 months

startedhankchizljaw/modern-css-reset

started time in 5 months

startedkentcdodds/advanced-react-hooks

started time in 5 months

startedganlanyuan/tiny-slider

started time in 5 months

pull request commentvuejs/rfcs

Composition API (revised from #42 Function-based Component API)

@nchutchind https://vue-composition-api-rfc.netlify.com/#usage-alongside-existing-api

yyx990803

comment created time in 5 months

fork sqal/create-react-app

Set up a modern web app by running one command.

https://create-react-app.dev

fork in 5 months

pull request commentWickyNilliams/headroom.js

Fix: clear pending scrollTracker's timeout when the instance is destroyed

@WickyNilliams No, I hadn't seen your comment in the other PR before I opened mine. I guess we can close this PR now that you've done refactoring and this bug should be fixed? :)

sqal

comment created time in 5 months

create barnchsqal/headroom.js

branch : fix/destroy

created branch time in 5 months

issue openedWickyNilliams/headroom.js

Uncaught TypeError: Cannot read property 'destroy' of undefined

Bug Report

Hello. I would like to report a bug in the latest version of Headroom.js. The problem is that in rare cases the destroy method can be called before scrollTracker has been initialized in line #42 due to putting it in the setTimeout callback which is not canceled when destroying the headroom instance.

Reproduction: https://jsfiddle.net/d20mxrbz/1/

created time in 5 months

fork sqal/headroom.js

Give your pages some headroom. Hide your header until you need it

http://wicky.nillia.ms/headroom.js/

fork in 5 months

more