profile
viewpoint
If you are wondering where the data of this site comes from, please visit https://api.github.com/users/spilist/events. GitMemory does not store any data, but only uses NGINX to cache data for a period of time. The idea behind GitMemory is simply to give users a better reading experience.
Hwidong Bae spilist @koreacreditdata Seoul https://spilist.github.io/ Software Engineer. Mainly interested in Web Frontend.

koreacreditdata/guides 54

한국신용데이터 엔지니어링 가이드

spilist/shoong 1

슈웅슈웅

koreacreditdata/react-stickynode 0

A performant and comprehensive React sticky component.

spilist/3H-room-allocator 0

CS562 DB Design Project for KAIST 2013 Fall

spilist/Calculator 0

For learning Swift Tutorial

spilist/clojure-exercise 0

Clojure 연습용

spilist/components 0

Create consistent styled-system based React UI components

spilist/cps_seat_picker 0

CPS Seat Picker

push eventkoreacreditdata/utilities

ted

commit sha c2459de698f09aae9546b22541b7ecccd3433198

Add README for hammerspoon plugin

view details

push time in 9 days

create barnchkoreacreditdata/utilities

branch : master

created branch time in 9 days

created repositorykoreacreditdata/utilities

KCD 직원들을 위한 유틸리티들

created time in 23 days

push eventkoreacreditdata/eslint-config

Heejae

commit sha 573077cfd10882fecfc06073955f8be27bd68ddc

Strict rules (#14)

view details

push time in 2 months

delete branch koreacreditdata/eslint-config

delete branch : strict-rules

delete time in 2 months

PR merged koreacreditdata/eslint-config

Strict rules

[eslint-config] 코드스펠체커 PR 후속 작업

커밋 단위로 보시면 편리하실 것 같습니다!

+1 -32

0 comment

1 changed file

J132134

pr closed time in 2 months

PullRequestReviewEvent

push eventkoreacreditdata/eslint-config

ted

commit sha 0b542fda824e85b70c95fbc223c31b9fd61be62b

Turn off prefer-default-export

view details

push time in 2 months

created tagkoreacreditdata/eslint-config

tagv0.3.2

created time in 2 months

push eventkoreacreditdata/eslint-config

ted

commit sha b41a7f06be1b72dff2fbd310be6ccab1000366f5

룰 코멘트 개선, 중복 룰 제거, tsconfig에 의존하는 룰 제거

view details

ted

commit sha 3c63161afa26599e3d5f4579c9d03bf645ea92e6

0.3.2

view details

push time in 2 months

push eventkoreacreditdata/eslint-config

JongHyeok Park

commit sha 4d4226e1cba218b8721f1b7d143875812be1f193

Code spell checker 및 merlin 과 feather 에 공통으로 사용되는 룰 추가 (#13)

view details

push time in 2 months

PR merged koreacreditdata/eslint-config

Reviewers
Code spell checker 및 merlin 과 feather 에 공통으로 사용되는 룰 추가

작업 내용

  • eslint code spell checker 적용
  • merlin 및 feather 공통 룰 추가
  • rule 에 comment 추가

논의 하고 싶은 내용

  • skipWords 현재 빈 배열로 처리했는데, 이대로 두고 사용하는 곳에서 추가해서 사용하면 될까요? 아니면, 공통으로 사용할만한 단어들 (bg, cx, idx, num 등..) 을 미리 추가해놓을까요?
    • 공통으로 사용할 만한 단어 추가했습니다. 더 추가할 내용있으면 코멘트 부탁드립니다.

-> 어차피 override될 것이므로 skipWords는 비워두되, override하지 않을 저장소를 감안하여 옵션은 추가해둡니다.

+115 -7

0 comment

7 changed files

parkoon

pr closed time in 2 months

PullRequestReviewEvent
PullRequestReviewEvent
PullRequestReviewEvent
PullRequestReviewEvent

Pull request review commentkoreacreditdata/eslint-config

Code spell checker 및 merlin 과 feather 에 공통으로 사용되는 룰 추가

 {   "name": "@koreacreditdata/eslint-config",-  "version": "0.3.1",+  "version": "0.3.2",

저도 PR 브랜치는 버전을 올리지 않고, 버전 올리는 (+ 태그 붙은) develop 브랜치의 커밋이라든가가 따로 있는 게 더 적절하다고 생각합니다~

parkoon

comment created time in 3 months

PR opened peacechen/node-git-hooks

Use `prepare` instead of `postinstall` to initialize hooks

node-git-hooks is only used as devDependencies, but postinstall is also triggered when published package is installed via npm. Thus one should also install node-git-hooks in their repository, or the package publisher should include node-git-hooks as a dependencies, not devDependencies.

Changing postinstall to prepare prevent it, since it installs the hooks only when developing the package, not when installing the package via npm.

Refer to the npm docs for more detail.

+2 -2

0 comment

1 changed file

pr created time in 3 months

PR merged spilist/node-git-hooks

Use `prepare` instead of `postinstall` to initialize hooks

node-git-hooks is only used as devDependencies, but postinstall is also triggered when published package is installed via npm. Thus one should also install node-git-hooks in their repository, or the package publisher should include node-git-hooks as a dependencies, not devDependencies.

Changing postinstall to prepare prevent it, since it installs the hooks only when developing the package, not when installing the package via npm.

Refer to the npm docs for more detail.

+2 -2

0 comment

1 changed file

spilist

pr closed time in 3 months

push eventspilist/node-git-hooks

Hwidong Bae

commit sha 9e7bc2ec5c8258ac82a44803af4757b7e1499a18

Use `prepare` instead of `postinstall` to initialize hooks `node-git-hooks` is only used as devDependencies, but `postinstall` is also triggered when published package is installed via npm. Thus one should also install `node-git-hooks` in their repository, or the package publisher should include `node-git-hooks` as a dependencies, not devDependencies. Changing `postinstall` to `prepare` prevent it, since it installs the hooks only when developing the package, not when installing the package via npm. Refer to the [npm docs](https://docs.npmjs.com/cli/v7/using-npm/scripts#prepare-and-prepublish) for more detail.

view details

Hwidong Bae

commit sha e1b364f5de17308ca3e3227dc8b4f2de5da0de77

Merge pull request #1 from spilist/use-prepare-instead-of-postinstall Use `prepare` instead of `postinstall` to initialize hooks

view details

push time in 3 months

PR opened spilist/node-git-hooks

Use `prepare` instead of `postinstall` to initialize hooks

node-git-hooks is only used as devDependencies, but postinstall is also triggered when published package is installed via npm. Thus one should also install node-git-hooks in their repository, or the package publisher should include node-git-hooks as a dependencies, not devDependencies.

Changing postinstall to prepare prevent it, since it installs the hooks only when developing the package, not when installing the package via npm.

Refer to the npm docs for more detail.

+2 -2

0 comment

1 changed file

pr created time in 3 months

create barnchspilist/node-git-hooks

branch : use-prepare-instead-of-postinstall

created branch time in 3 months

push eventkoreacreditdata/frontend-dotfiles

JongHyeok Park

commit sha e9c42a157a77a817dc140dc1eeeeb5a8f2e14f1f

Apply code spell checker extension (#1)

view details

push time in 3 months

PR merged koreacreditdata/frontend-dotfiles

Apply code spell checker extension

아래 단어를 제외하고 나름대로의 기준으로 의미있는 단어는 포함시켰습니다. 포함된 단어 중에도 이상한게 있다면 코멘트 부탁드립니다.

오탈자 의심

bottocm Reconnet Intialized

없는 단어 !?

Startable metas vite CREFIA cafefia Invalidatable

Camel case 의심

subtabs Selectbox Bottomsheet bottomsheet mylink


merlin 기준으로 체크한 단어 입니다. merlin 에서 검색 후 확인 해주시면 될 것 같습니다.

+25 -1

2 comments

3 changed files

parkoon

pr closed time in 3 months

PullRequestReviewEvent

Pull request review commentkoreacreditdata/frontend-dotfiles

Apply code spell checker extension

 # KCD Frontend dotfiles +## Setting++### Code Spell Checker++> 현재 설정은 예시로 되어 있으며, 각 프로젝트에 맞게 설정해주시면 됩니다.++[cspell.json](public/.vscode/cspell.json) 에서 각 프로젝트에 맞게 설정을 해줍니다.

https://marketplace.visualstudio.com/items?itemName=streetsidesoftware.code-spell-checker 를 참고하라고 링크 추가해두면 좋겠습니다.

parkoon

comment created time in 3 months

pull request commentkoreacreditdata/frontend-dotfiles

Apply code spell checker extension

bottocm Reconnet Intialized

오타 맞음

Startable metas vite CREFIA cafefia Invalidatable

cafefia는 없는 것 같고 나머지는 가져가도 될듯

camelCase 의심도 그대로 한 단어로 봐도 됨

js, ts, jsx, tsx -> 이것만 보고, src/ 안쪽만 보는 식으로

각 프로젝트에서 자기가 쓰는 dictionary 를 각 프로젝트에 추가해서 사용. 이 dotfiles가 자체적으로 단어사전을 가질 필요는 없는데, 단어사전을 추가하는 방법은 가이드가 되면 좋겠다.

parkoon

comment created time in 3 months