profile
viewpoint
Spencer Gibb spencergibb VMWare Ann Arbor, MI https://gibb.tech Engineer at VMWare working on @spring-cloud. Former Pivotal

micrometer-metrics/micrometer 2152

An application metrics facade for the most popular monitoring tools. Think SLF4J, but for metrics.

joshlong/cloud-native-workshop 649

win w/ Spring Boot, Spring Cloud and Cloud Foundry

spencergibb/battleschool 418

Development environment provisioning using ansible, ala boxen -> puppet, kitchenplan -> chef

spencergibb/ansible-osx 82

A battleschool ansible repository for osx

pivotal/credhub-release 30

BOSH release of CredHub server

dsyer/presos 10

Presentations for conferences and user groups etc.

rsocket-routing/rsocket-routing 4

RSocket Routing Specification

spencergibb/cloud-native-workshop 4

win w/ Spring Boot, Spring Cloud and Cloud Foundry

create barnchspencergibb/spring-cloud-config

branch : normalize

created branch time in 9 hours

fork spencergibb/spring-cloud-config

External configuration (server and client) for Spring Cloud

fork in 9 hours

issue commentspring-cloud/spring-cloud-gateway

add ConditionalOnMissingBean to RoutePredicateHandlerMapping auto configure bean factory method

Describe alternatives you've considered A clear and concise description of any alternative solutions or features you've considered.

Additional context Add any other context or screenshots about the feature request here.

As requested you have not described why you want to override RoutePredicateHandlerMapping. You've also not said what fields you want access to and why.

amine-labassi

comment created time in 10 hours

issue commentspring-cloud/spring-cloud-sleuth

spring boot 2.1.2 not starting when adding Sleuth

@packoxD please provide a complete, minimal, verifiable sample that reproduces the problem. It should be available as a GitHub (or similar) project or attached to this issue as a zip file.

aggaton

comment created time in a day

issue commentspring-cloud/spring-cloud-gateway

Springcloud gateway + BFF

Change the controller mapping to something else and move /api to a gateway route

ramonli

comment created time in 2 days

issue commentspring-cloud/spring-cloud-commons

Why RestartListener?

Use am atomic Boolean to see that the event is only consumed once?

HashZhang

comment created time in 2 days

issue commentspring-cloud/spring-cloud-gateway

Springcloud gateway + BFF

Your controller matches /api first, it never hits the gateway

ramonli

comment created time in 2 days

issue commentspring-cloud/spring-cloud-gateway

[Question] how to customize RateLimiter

That's not where I asked you to look

liangyuanpeng

comment created time in 2 days

issue commentspring-cloud/spring-cloud-gateway

Provide request specific configuration of HttpClient

I'd accept a PR that made httpClientWithTimeoutFrom(Route) generic, take the parameters you need and make it protected, then you could extend

GuyLewin

comment created time in 2 days

issue commentspring-cloud/spring-cloud-gateway

[Question] how to customize RateLimiter

Put a breakpoint here https://github.com/spring-cloud/spring-cloud-gateway/blob/2.2.x/spring-cloud-gateway-core/src/main/java/org/springframework/cloud/gateway/filter/factory/RequestRateLimiterGatewayFilterFactory.java#L95 to see what happens.

liangyuanpeng

comment created time in 2 days

issue commentspring-cloud/spring-cloud-gateway

Provide request specific configuration of HttpClient

Let's wait please

GuyLewin

comment created time in 2 days

issue commentspring-cloud/spring-cloud-gateway

[Question] how to customize RateLimiter

What debugging have you done?

liangyuanpeng

comment created time in 3 days

issue commentspring-cloud/spring-cloud-commons

Why RestartListener?

You'll need to check that the context in the event is not the bootstrap context

HashZhang

comment created time in 3 days

Pull request review commentspring-cloud/spring-cloud-cloudfoundry

update cf discovery defaults in service discovery

 protected ServiceInstance mapApplicationInstanceToServiceInstance( 		String instanceId = applicationId + "." + applicationIndex; 		String name = applicationDetail.getName(); 		String url = applicationDetail.getUrls().size() > 0-				? applicationDetail.getUrls().get(0) : null;-		boolean secure = (url + "").toLowerCase().startsWith("https");

Why did you change this?

srinivasa-vasu

comment created time in 3 days

Pull request review commentspring-cloud/spring-cloud-cloudfoundry

update cf discovery defaults in service discovery

 public String description() { 				.map(this::mapApplicationInstanceToServiceInstance); 	} -	private boolean isInternalDomain(String url) {-		return url != null && url.endsWith(INTERNAL_DOMAIN);+	protected String getRouteURL(List<String> urls) {+		return urls.stream().filter(this::isInternalDomain).findFirst().orElse("");

Don't use stream apis please

srinivasa-vasu

comment created time in 3 days

Pull request review commentspring-cloud/spring-cloud-cloudfoundry

update cf discovery defaults in service discovery

  	private final ServiceIdToHostnameConverter serviceIdToHostnameConverter; -	public SimpleDnsBasedReactiveDiscoveryClient(

Unfortunately, if you want this to go in hoxton you can't remove constructors. We need to be backwards compatible

srinivasa-vasu

comment created time in 3 days

pull request commentspring-cloud/spring-cloud-config

Add check if the file extension is null before calling the to toLowerCase() - Fixes gh-20302

Can you please add a test. Also which issue does it fix since this project doesn't have that number issue

mohammedalics

comment created time in 3 days

issue commentspring-cloud/spring-cloud-commons

Why RestartListener?

We create a bootstrap application context. This publishes additional events

HashZhang

comment created time in 3 days

issue commentspring-cloud/spring-cloud-gateway

[Question] how to customize RateLimiter

What's "not working"?

liangyuanpeng

comment created time in 3 days

issue commentspring-projects/spring-cloud

Why Spring Cloud has't 'Role' like the Dubbo

Not sure how that helps. Where in spring cloud do you want this role?

98DE9E1F

comment created time in 3 days

issue commentspring-cloud/spring-cloud-gateway

Cross-domain issues; gateway returned multiple Access-Control-Allow-Origin;

Can you please create a minimal project that recreates the problem. Only gateway and one downstream project.

cielswift

comment created time in 3 days

issue commentspring-cloud/spring-cloud-gateway

Cross-domain issues; gateway returned multiple Access-Control-Allow-Origin;

What version are you using? Does the project include spring security? The downstream project may also produce those headers. Spring Security automatically adds those headers and a customer filter is not needed. Gateway does not add those headers at all.

cielswift

comment created time in 3 days

issue commentspring-cloud/spring-cloud-gateway

NettyRoutingFilter - Use Bean to provide session-specific HttpClient

The netty routing filter already gets the http client from a bean.

GuyLewin

comment created time in 4 days

issue closedspring-cloud/spring-cloud-gateway

Not supporting proxy mode

Describe the bug When trying to proxy requests through Spring cloud gateway:

curl -k --proxy https://local-api.yapily.com:8080  https://httpbin.org/get

the response is:

curl: (56) Received HTTP code 404 from proxy after CONNECT

However:

curl -k  https://local-api.yapily.com:8080/get --header 'host: httpbin.org'

works fine:

{
  "args": {},
  "headers": {
    "Accept": "*/*",
    "Content-Length": "0",
    "Forwarded": "proto=https;host=httpbin.org;for=\"127.0.0.1:56283\"",
    "Host": "httpbin.org",
    "User-Agent": "curl/7.64.1",
    "X-Amzn-Trace-Id": "Root=1-5e4ffd2a-7502421dd2e64f1145125dc3",
    "X-Forwarded-Host": "httpbin.org"
  },
  "origin": "127.0.0.1, 35.189.96.6",
  "url": "https://httpbin.org/get"
}

Sample I reproduce the issue here: https://github.com/qcastel/reproduce-spring-cloud-gateway-error

Please note that I use the latest netty snapshot, as they were an NPE on netty that is now solved by https://github.com/reactor/reactor-netty/issues/948

closed time in 4 days

qcastel

issue commentspring-cloud/spring-cloud-gateway

Not supporting proxy mode

Correct, gateway is a reverse proxy.

qcastel

comment created time in 4 days

issue commentspring-cloud/spring-cloud-commons

Cloud config client reversing remote property sources with certain settings

Ah yes, it will be in are in a week

jeffbswope

comment created time in 5 days

push eventrsocket-routing/rsocket-routing

Spencer Gibb

commit sha 4e20e58fcc3530fa2d4af6a22f1940a9d8346c50

Create RoutingAndForwardingSpecification.md

view details

push time in 5 days

create barnchrsocket-routing/rsocket-routing

branch : master

created branch time in 5 days

created repositoryrsocket-routing/rsocket-routing

RSocket Routing Specification

created time in 5 days

issue commentspring-projects/spring-boot

Rewrite Actuator MVC adapter layer for Servlet Functional Endpoints

Would this affect writing web extensions to actuator? I guess I'm really asking about backwards compatibility.

bclozel

comment created time in 5 days

issue closedspring-cloud/spring-cloud-consul

ConsulAutoRegistration.registration(...) not supported metadata property

NewService.class has field private meta Map<String, String> but no way to init it in the ConsulAutoRegistration by default.

I would like to add new field in ConsulDiscoveryProperties

private Map<String, String> metadata = new HashMap<>();

and use this like

ConsulAutoRegistration.registration(..) {
  ...
    service.setMeta(properties.getMetadata());
  ...
}

closed time in 6 days

kc4kt4

issue commentspring-projects/spring-cloud

Why Spring Cloud has't 'Role' like the Dubbo

Not sure how this relates to spring cloud. As I'm not familiar with dubbo, what does role mean?

98DE9E1F

comment created time in 6 days

issue commentspring-projects/spring-boot

@AutoConfigureAfter not working as expected

What is the result you get?

ranarula

comment created time in 6 days

issue commentspring-cloud/spring-cloud-config

Config Client not fetching config when Spring Security is active on Spring Cloud Config Server

Please don't cross post, closing in favor of stack overflow

NecoHorne

comment created time in 7 days

issue closedspring-cloud/spring-cloud-config

Config Client not fetching config when Spring Security is active on Spring Cloud Config Server

When I run spring cloud config server without spring security the service fetches the config without issue but when I activate Spring security it won't fetch the config files. It seems to throw a 401 http error. I have checked that the username and password is correct, I have also tried the user:password@url way of authenticating with the same issue.

If i access the url http://localhost:8888/service/default directly in browser and enter the username and password the configs are displayed.

I tried adding it to existing services I had and it did not work so I created a new config server and a new client via the spring initializer on https://start.spring.io/ with the below config and still does not work. it seems to always fail with the same issue.

Spring Boot version: '2.2.4.RELEASE' spring-cloud-config-server version: '2.2.1.RELEASE' Build system: Gradle Java 8

Configs and logs detailed in this stack overflow post:

https://stackoverflow.com/questions/60298657/spring-cloud-config-client-not-fetching-config-when-spring-security-is-active-on

closed time in 7 days

NecoHorne

issue commentspring-cloud/spring-cloud-openfeign

Switch Ribbon-based tests to use SC LoadBalancer

Didn't I do that already?

OlgaMaciaszek

comment created time in 7 days

issue commentspring-projects/spring-boot

@AutoConfigureAfter not working as expected

It only works on autoconfiguration, nested classes are not. Only one class is listed in spring.factories

ranarula

comment created time in 7 days

issue closedspring-cloud/spring-cloud-openfeign

Provide an attribute to ignore certain exceptions for Feign Hystrix support

The @FeignClient annotation has an attribute fallback, named appropriately. It'd be nice to have an attribute Class<? extends Throwable>[] ignoreExceptions() default {} that doesn't open the circuit for the exceptions listed. Currently, the workaround is to disable feign support (feign.hystrix.enabled=false will do it globally) and annotate the caller of the feign client with com.netflix.hystrix.contrib.javanica.annotation.HystrixCommand. This is more code to implement what I assume is a common use case. Also, if any ErrorDocoder is present, ignoreExceptions should honor it, that is give the decoder a chance to translate HTTP status code to exceptions.

See the SO thread here for background.

closed time in 8 days

asarkar

issue commentspring-cloud/spring-cloud-openfeign

Provide an attribute to ignore certain exceptions for Feign Hystrix support

Hystrix has entered maintenance mode. This means that the Spring Cloud team will no longer be adding new features to the module. We will fix blocker bugs and security issues, and we will also consider and review small pull requests from the community.

asarkar

comment created time in 8 days

push eventspring-cloud/spring-cloud-release

Spencer Gibb

commit sha 93ebad189723478de15d7021f8bbac87171109e9

Updates s-c-release to Hoxton.SR2

view details

push time in 8 days

IssuesEvent

issue commentspring-cloud/spring-cloud-consul

@ConstructorBinding not refreshing

and reload the application context.

It doesn't actually reload the application context.

jkstrauss

comment created time in 8 days

push eventspring-cloud/spring-cloud-release

Spencer Gibb

commit sha 490315a9d92171d9cc600ff707dcd7197070fb5a

ignores .flattened-pom.xml

view details

Spencer Gibb

commit sha c9831a1137196e537b311a656a6da566304fb491

Adds hoxton_sr2.properties

view details

push time in 8 days

issue commentspring-cloud/spring-cloud-netflix

* in exclusion causes warning in maven

Version 1.x is no longer supported

spencergibb

comment created time in 8 days

issue commentspring-cloud/spring-cloud-consul

@ConstructorBinding not refreshing

Refresh triggers configuration property rebinding and clears the refresh scope cache. So that statement isn't quite right

jkstrauss

comment created time in 8 days

issue closedspring-cloud/spring-cloud-config

How to point Config-server to a deep nested subfolder of a git repository without reading the whole tree?

Hi,

I have a working Config Server pointed to a small git repository and everything works fine. I am using searchPaths to look for files in subfolders working fine. My problem is that I need to use an existing git repository with huge content where the files I need are placed in a subfolder. If I try to point my config-server to this new git, it tries to read the whole tree folder (including brothers and cousins from the actual folder I need) and produces a timeout. Is there any way to tell Config Server to work only with a determined subfolder and ignore the rest of the git tree?

Thanks in advance!

closed time in 9 days

raulgv1980

issue commentspring-cloud/spring-cloud-config

How to point Config-server to a deep nested subfolder of a git repository without reading the whole tree?

That's really a limitation of git. Not sure what else to say.

raulgv1980

comment created time in 9 days

issue commentspring-cloud/spring-cloud-config

How to point Config-server to a deep nested subfolder of a git repository without reading the whole tree?

That's not really how git works is it? Are these huge files configuration?

raulgv1980

comment created time in 9 days

GollumEvent
GollumEvent

issue closedspring-cloud/spring-cloud-consul

@ConstructorBinding not refreshing

@ConstructorBinding annotated classes not refreshing I am using Spring Cloud version Hoxton with Spring Boot 2.2.x

Spring Boot 2.2.x introduced a an annotation @ConstructorBinding that allows defining @ConfigurationProperties classes strictly through constructors, which allows using immutable classes in configurations.

While the initial configuration is being loaded from my Consul K/V server, subsequent changes to the server do not get reflected in the configuration objects. The problem is not mitigated by using @RefreshScope.

closed time in 9 days

jkstrauss

issue commentspring-cloud/spring-cloud-consul

@ConstructorBinding not refreshing

Immutable classes are just that and are not refreshable

jkstrauss

comment created time in 9 days

issue commentspring-cloud/spring-cloud-zookeeper

Zookeeper link not working

Just link to https://zookeeper.apache.org/

albertotn

comment created time in 9 days

issue commentrsocket/rsocket-java

Whitelist client IP address

Whitelist typically means always allow, is there something blocking your ip address. Can you explain what problem you are experiencing and why you believe a whitelist is needed?

kacper-emersoft

comment created time in 10 days

issue commentspring-cloud/spring-cloud-config

Client-Side PropertySource Order Different between Spring Boot 2.1.x and 2.2.x

We just fixed something like that in commons, can you try with snapshots?

tkvangorder

comment created time in 12 days

issue closedspring-cloud/spring-cloud-openfeign

Add support for reactive feign clients

See https://github.com/spring-cloud/spring-cloud-netflix/issues/1554 for history.

closed time in 13 days

ryanjbaxter

issue commentspring-cloud/spring-cloud-openfeign

Add support for reactive feign clients

We're going to defer to the community project mentioned by @kptfh https://github.com/Playtika/feign-reactive

To aid in discovery of community projects, I've created https://github.com/spring-cloud/spring-cloud-commons/issues/686 to add a list to our docs.

ryanjbaxter

comment created time in 13 days

issue openedspring-cloud/spring-cloud-commons

Add a list of community starters

See https://github.com/ge0ffrey/spring-boot/blob/master/spring-boot-project/spring-boot-starters/README.adoc

The boot one lives in a readme. I'd think it would be better as an appendix to docs or something.

This may not be the right repo, maybe spring-cloud-release?

created time in 13 days

pull request commentspring-cloud/spring-cloud-gateway

Lazily test AsyncPredicate for 'and' and 'or' operations.

@9longbear why the comment?

adrianotr

comment created time in 14 days

issue closedspring-cloud/spring-cloud-gateway

AsyncPredicate AND and OR operations eagerly test every predicate

Because AsyncPredicate and and or operations are tested using Flux.zip it ends up calling every single one of the chained predicates.

This is specially a problem when using the readBody predicate because we end up reading the request body eagerly.

This can impact memory utilization as well as cause issues with readBody if used in different routes with different content types.

I am pushing a code change to only invoke the next predicate when it's actually necessary to determine the boolean result.

closed time in 14 days

adrianotr

issue commentspring-cloud/spring-cloud-gateway

AsyncPredicate AND and OR operations eagerly test every predicate

No need for an issue if you've already got a PR.

Closing in favor of #1571

adrianotr

comment created time in 14 days

issue commentspring-cloud/spring-cloud-gateway

Provide A Way To Simplify Reading And Caching A Body In A Filter or Predicate

configuration based routing isn't second class at all. I literally can't put a programming language in yaml required to support body-based predicates and filters.

Aloren

comment created time in 14 days

issue commentspring-cloud/spring-cloud-gateway

General SSLEngine problem exception 200 status

Can you provide a complete, minimal, verifiable sample that reproduces the problem? It should be available as a GitHub (or similar) project or attached to this issue as a zip file.

DmitriPunko

comment created time in 14 days

issue commentspring-cloud/spring-cloud-gateway

General SSLEngine problem exception 200 status

Do you need to use then() rather than success or error?

DmitriPunko

comment created time in 15 days

issue commentspring-cloud/spring-cloud-gateway

Provide A Way To Simplify Reading And Caching A Body In A Filter or Predicate

@DJLB #1121 is still open. Otherwise checkout ec0d906ff3992789a79ab6e3029374dae478aea8

Aloren

comment created time in 15 days

pull request commentspring-cloud/spring-cloud-commons

fixes issues from gh-683

@robotmrv this PR is fine, no need to open anything else.

robotmrv

comment created time in 15 days

issue commentspring-cloud/spring-cloud-gateway

General SSLEngine problem exception 200 status

Getting the response before the filter chain is run will always return 200. See set status filter for how to run post request.

DmitriPunko

comment created time in 16 days

issue commentspring-cloud/spring-cloud-gateway

Can't configure spring security with OAuth 2.0 to permit unauthenticated exchange.

I'm still confused you allow /user/logged in the gateway, yet you want gateway to react to some response from the downstream service? If that is what you are looking for it will need to be custom as that is not supported.

jaggerwang

comment created time in 16 days

issue commentspring-cloud/spring-cloud-config

Using the incorrect URI even when the spring.cloud.config.uri is specified

Without a project that reproduces the problem, I won't be able to help

mjosephd

comment created time in 16 days

PR opened rsocket/rsocket

Cleanup of Routing-And-Forwarding.md

Fixes tables of contents with links, frame diagrams, tables and a few readability issues.

Because the original files was CRLF, 3f49cc01ab149506838a523056f5dfce80fb9417 will be easier to view differences.

+672 -736

0 comment

1 changed file

pr created time in 16 days

push eventspencergibb/rsocket

Spencer Gibb

commit sha 6dcbcb0bbe5bb68209291aaf4a50741d6c2bbd43

Changes line ending to LF

view details

Spencer Gibb

commit sha 3f49cc01ab149506838a523056f5dfce80fb9417

Cleanup of Routing-And-Forwarding.md Fixes tables of contents with links, frame diagrams, tables and a few readability issues.

view details

push time in 16 days

create barnchspencergibb/rsocket

branch : routing-forwarding-cleanup

created branch time in 16 days

fork spencergibb/rsocket

RSocket Protocol Definition

http://rsocket.io

fork in 16 days

issue commentspring-cloud/spring-cloud-openfeign

Add support for reactive feign clients

No. For now I would suggest https://github.com/spring-cloud/spring-cloud-openfeign/issues/4#issuecomment-458514280

Marking for team discussion to see if this is something we want to pursue.

ryanjbaxter

comment created time in 17 days

issue closedspring-cloud/spring-cloud-config

Spring cloud decryption issue

I set spring.cloud.config.server.encrypt.enabled=true in bootstrap.properties. But the decryption working. It can able to decrypt the encrypted value. I'm using Springboot 2.2.1.RELEASE and Spring cloud Hoxton.RELEASE.

closed time in 18 days

jacksonjoseph

issue commentspring-cloud/spring-cloud-config

Spring cloud decryption issue

Duplicates #1548. Please don't open multiple issues

jacksonjoseph

comment created time in 18 days

push eventspring-cloud/spring-cloud-kubernetes

Spencer Gibb

commit sha 6caac403dc44e525d557f3dc33a2adf03a498c8a

formatting

view details

push time in 19 days

PR closed spring-cloud/spring-cloud-kubernetes

Change http/https schemas in kubernetes service instance in progress

Fixes https://github.com/spring-cloud/spring-cloud-kubernetes/issues/486

+6 -3

1 comment

1 changed file

ArtyomGabeev

pr closed time in 19 days

pull request commentspring-cloud/spring-cloud-kubernetes

Change http/https schemas in kubernetes service instance

Cherry-picked and merged with a test in 1.1.x via 521195d08d81b482802020fe46f8ee79ddda9081

ArtyomGabeev

comment created time in 19 days

push eventspring-cloud/spring-cloud-kubernetes

Artyom Gabeev

commit sha 521195d08d81b482802020fe46f8ee79ddda9081

Removes "://" from KubernetesServiceInstance.getScheme() fixes gh-486

view details

Spencer Gibb

commit sha b64a05fb729c6c2d2cfd58402951b966834c6285

Merge branch '1.1.x'

view details

push time in 19 days

issue closedspring-cloud/spring-cloud-kubernetes

BlockingLoadBalancerClient does not work with KubernetesDiscoveryClient

Hi,

I'm trying to migrate from ribbon LB to newly introduced blocking LB.

Here is a test replicating the issue:

    @Test
    public void testReconstructURIForK8S() {
        ServiceInstance instance = new KubernetesServiceInstance("auth-server", "auth-server",
                new EndpointAddress("hostname", "127.0.0.1", "nodeName", null),
                new EndpointPort("http", 8091, "tcp"),
                Collections.emptyMap(),
                false);
        URI uri = LoadBalancerUriTools.reconstructURI(new TruncateSchemaServiceInstance(instance),
                URI.create("http://auth-server/oauth/token"));

        assertThat(uri.toString()).isEqualTo("http://127.0.0.1:8091/oauth/token");
    }

Fails with:

   001:  "java.lang.IllegalStateException: Could not create URI object: Expected hostname at index 7: http://://127.0.0.1:8091/oauth/token"     
   002:  "at org.springframework.web.util.HierarchicalUriComponents.toUri(HierarchicalUriComponents.java:514)"     
   003:  "at org.springframework.cloud.client.loadbalancer.LoadBalancerUriTools.doReconstructURI(LoadBalancerUriTools.java:111)"     
   004:  "at org.springframework.cloud.client.loadbalancer.LoadBalancerUriTools.reconstructURI(LoadBalancerUriTools.java:95)"     
   005:  "at org.springframework.cloud.loadbalancer.blocking.client.BlockingLoadBalancerClient.reconstructURI(BlockingLoadBalancerClient.java:75)"     
   006:  "at org.springframework.cloud.client.loadbalancer.ServiceRequestWrapper.getURI(ServiceRequestWrapper.java:43)"     
   007:  "at org.springframework.http.client.InterceptingClientHttpRequest$InterceptingRequestExecution.execute(InterceptingClientHttpRequest.java:97)"     
   008:  "at org.springframework.cloud.client.loadbalancer.LoadBalancerRequestFactory.lambda$createRequest$0(LoadBalancerRequestFactory.java:61)"     
   009:  "at org.springframework.cloud.loadbalancer.blocking.client.BlockingLoadBalancerClient.execute(BlockingLoadBalancerClient.java:62)"     

The issue is that KubernetesServiceInstance returns for schema either "http://" or "https://". Current implementation of LoadBalancerUriTools except schema to be "http" or "https".

I've checked implementation of ServiceIntance for Eureka, it returns null when getSchema is called.

Should we fix issue in KubernetesServiceInstance or adjust LoadBalancerUriTools to trim "://" during URI reconstruction? (second one looks more safe).

Thanks, Artyom

closed time in 19 days

ArtyomGabeev

push eventspring-cloud/spring-cloud-kubernetes

Artyom Gabeev

commit sha 521195d08d81b482802020fe46f8ee79ddda9081

Removes "://" from KubernetesServiceInstance.getScheme() fixes gh-486

view details

push time in 19 days

issue closedspring-cloud/spring-cloud-config

Spring cloud spring.cloud.config.server.encrypt.enabled=true is not working

Spring cloud spring.cloud.config.server.encrypt.enabled=true is not working in bootstrap.properties with Springboot 2.2.1.RELEASE and spring cloud Hoxton.RELEASE.

Can you please give me a solution?

closed time in 19 days

jacksonjoseph

issue commentspring-cloud/spring-cloud-config

Spring cloud spring.cloud.config.server.encrypt.enabled=true is not working

closing in favor of stack overflow. If it turns out to be a bug, we can reopen.

jacksonjoseph

comment created time in 19 days

issue commentspring-cloud/spring-cloud-config

Spring cloud spring.cloud.config.server.encrypt.enabled=true is not working

Is this the same as https://stackoverflow.com/questions/60117845/spring-cloud-decrypt-api

jacksonjoseph

comment created time in 19 days

Pull request review commentspring-cloud/spring-cloud-commons

fixes issues from gh-683

 public HealthCheckServiceInstanceListSupplier(ServiceInstanceListSupplier delega 	}  	private void initInstances() {-		delegate.get().subscribe(delegateInstances -> {-			instances.clear();-			instances.addAll(delegateInstances);-		});--		Flux<List<ServiceInstance>> healthCheckFlux = healthCheckFlux();--		healthCheckFlux.subscribe(verifiedInstances -> {-			healthyInstances.clear();-			healthyInstances.addAll(verifiedInstances);-		});+		healthCheckDisposable = delegate.get().doOnNext(delegateInstances -> {+			instances = Collections.unmodifiableList(new ArrayList<>(delegateInstances));+		})+		.thenMany(healthCheckFlux()).subscribeOn(Schedulers.parallel())+		.subscribe(verifiedInstances -> healthyInstances = verifiedInstances); 	}  	protected Flux<List<ServiceInstance>> healthCheckFlux() {-		return Flux.create(emitter -> Schedulers-				.newSingle("Health Check Verifier: " + getServiceId(), true)-				.schedulePeriodically(() -> {-					List<ServiceInstance> verifiedInstances = new ArrayList<>();-					Flux.fromIterable(instances).filterWhen(this::isAlive)-							.subscribe(serviceInstance -> {-								verifiedInstances.add(serviceInstance);-								emitter.next(verifiedInstances);-							});-				}, healthCheck.getInitialDelay(), healthCheck.getInterval().toMillis(),-						TimeUnit.MILLISECONDS),-				FluxSink.OverflowStrategy.LATEST);+		return Flux.defer(() -> {+			List<ServiceInstance> result = new CopyOnWriteArrayList<>();++			List<Mono<ServiceInstance>> checks = new ArrayList<>();+			for (ServiceInstance instance : instances) {+				Mono<ServiceInstance> alive = isAlive(instance)+						.onErrorResume(throwable -> Mono.empty())

yes, debug is my first instinct.

robotmrv

comment created time in 19 days

Pull request review commentspring-cloud/spring-cloud-commons

fixes issues from gh-683

 public String getServiceId() { 				.uri(UriComponentsBuilder.fromUri(serviceInstance.getUri()) 						.path(healthCheckPath).build().toUri()) 				.exchange()-				.map(clientResponse -> HttpStatus.OK.equals(clientResponse.statusCode()));+				.flatMap(clientResponse -> clientResponse.releaseBody()+						.thenReturn(HttpStatus.OK.equals(clientResponse.statusCode()))

sure

robotmrv

comment created time in 19 days

Pull request review commentspring-cloud/spring-cloud-commons

fixes issues from gh-683

 public HealthCheckServiceInstanceListSupplier(ServiceInstanceListSupplier delega 	}  	private void initInstances() {-		delegate.get().subscribe(delegateInstances -> {-			instances.clear();-			instances.addAll(delegateInstances);-		});--		Flux<List<ServiceInstance>> healthCheckFlux = healthCheckFlux();--		healthCheckFlux.subscribe(verifiedInstances -> {-			healthyInstances.clear();-			healthyInstances.addAll(verifiedInstances);-		});+		healthCheckDisposable = delegate.get().doOnNext(delegateInstances -> {

yes

robotmrv

comment created time in 19 days

issue commentspring-cloud/spring-cloud-openfeign

Hoxton.SR1 cannot recognize consul URL (unknown host exception)

You shouldn't be using url if you are using discovery

timpamungkas

comment created time in 20 days

push eventspring-cloud/spring-cloud-build

Dave Syer

commit sha fb26806aa80d225ceedd9e8518a794a9af97f330

Update versions for checkstyle and puppy thing (#152) Avoid nag by github security alert

view details

push time in 20 days

more