profile
viewpoint
If you are wondering where the data of this site comes from, please visit https://api.github.com/users/simonswine/events. GitMemory does not store any data, but only uses NGINX to cache data for a period of time. The idea behind GitMemory is simply to give users a better reading experience.
Christian Simon simonswine @grafana London / Germany https://www.simon.im

helm/charts 15241

⚠️(OBSOLETE) Curated applications for Kubernetes

cluster-api-provider-hcloud/cluster-api-provider-hcloud 26

Cluster API infrastructure provider for Hetzner's Hcloud

grafana/prometheus-pulsar-remote-write 5

A Prometheus remote_write adapter for Pulsar

simonswine/btsmareader 1

Read out statistics from SMA Sunny Boys with Bluetooth interface

dippynark/k8s-examples 0

Kubernetes configuration examples

JoshVanL/tarmak 0

Tarmak is a toolkit for Kubernetes cluster provisioning and management

krisajenkins/Shakespeare-Trie 0

Shakespeare's Trie Structure

simonswine/acs-engine 0

Azure Container Service Engine - a place for community to collaborate and build the best open Docker container infrastructure for Azure.

PullRequestReviewEvent

create barnchsimonswine/drone-ci-log-forwarder

branch : main

created branch time in 15 days

created repositorysimonswine/drone-ci-log-forwarder

created time in 15 days

push eventgrafana/cortex-jsonnet

Jack Baldry

commit sha e90e0de42193f6ffbb38e5f806b9534060a1833a

feat: Allow configuration of ring members in gossip alerts Signed-off-by: Jack Baldry <jack.baldry@grafana.com>

view details

Jack Baldry

commit sha 36cf15b5db36e503e3200bf35ff9062ab42b975d

fix: Add store-gateway and compactor ring_members Also re-order names for readability. Signed-off-by: Jack Baldry <jack.baldry@grafana.com>

view details

Jack Baldry

commit sha a95639d83b5c0e7a21e40834959ee8fd82ccdb9b

fix: Match all ingester workloads and avoid matching the cortex-gateway Signed-off-by: Jack Baldry <jack.baldry@grafana.com>

view details

Jack Baldry

commit sha 4ddad08fbc2b0660064dc02173320aac5de1d823

feat: Optionally allow use of array or string to configure ring members Signed-off-by: Jack Baldry <jack.baldry@grafana.com>

view details

Jack Baldry

commit sha 9c152e4723d5c245b70c1971c4429c32eff2921e

address review feedback Signed-off-by: Jack Baldry <jack.baldry@grafana.com>

view details

Jack Baldry

commit sha c3d6055f337b11fa50735a67475ca5ccaf998d80

fix: Correct ingester and querier regexps Signed-off-by: Jack Baldry <jack.baldry@grafana.com>

view details

Christian Simon

commit sha dda3e687fc8f47c7a2e1f4f88d48cb6559324a93

Merge pull request #301 from grafana/jdb/parameterize-ring-member-selector feat: Allow configuration of ring members in gossip alerts

view details

push time in 18 days

delete branch grafana/cortex-jsonnet

delete branch : jdb/parameterize-ring-member-selector

delete time in 18 days

PR merged grafana/cortex-jsonnet

feat: Allow configuration of ring members in gossip alerts

What this PR does: Allows library consumers to configure the names of jobs that are members of the gossip ring which is used by the CortexGossipMembersMismatch alert.

Checklist

  • [ ] CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]
+12 -5

4 comments

2 changed files

jdbaldry

pr closed time in 18 days

PullRequestReviewEvent

PR opened prometheus-operator/prometheus-operator

Add metric relabeling support for Probes

Description

Add metric relabeling support for Probes

Type of change

What type of changes does your code introduce to the Prometheus operator? Put an x in the box that apply.

  • [ ] CHANGE (fix or feature that would cause existing functionality to not work as expected)
  • [x] FEATURE (non-breaking change which adds functionality)
  • [ ] BUGFIX (non-breaking change which fixes an issue)
  • [x] ENHANCEMENT (non-breaking change which improves existing functionality)
  • [ ] NONE (if none of the other choices apply. Example, tooling, build system, CI, docs, etc.)

Changelog entry

Please put a one-line changelog entry below. This will be copied to the changelog file during the release process.

<!-- Your release note should be written in clear and straightforward sentences. Most often, users aren't familiar with the technical details of your PR, so consider what they need to know when you write your release note.

Some brief examples of release notes:

  • Add metadataConfig field to the Prometheus CRD for configuring how remote-write sends metadata information.
  • Generate correct scraping configuration for Probes with empty or unset module parameter. -->
Add metricRelabelings field to the Probe CRD for configuring metric relabel configs.
+127 -3

0 comment

8 changed files

pr created time in a month

PR opened grafana/tanka

Fix api-resources table parsing

For sometime tk pruning fails, as my cluster has overlapping CRD names/mismatching Kind and Name fields . Errors persisted like this:

$ tk prune environments/default
fetching UID's .. done 555.50452ms
fetching previously created resources .. Error: error: the server doesn't have a resource type "NetworkAttachmentDefinition"

The reason why this was happing was a failed parsing of the -o wide table of kubectl api-resources: The field APIGROUP no longer exists and is now part of APIVERSION.

+21 -17

0 comment

3 changed files

pr created time in a month

create barnchsimonswine/tanka

branch : 20210821_fix-bug-api-resources-parsing

created branch time in a month

push eventsimonswine/nixos

Christian Simon

commit sha 3a5f6081f5f401e2d82c11877f15fe06b0128c29

Add tplink-switch-exporter pkg and module

view details

push time in a month

push eventsimonswine/nixos

Christian Simon

commit sha 44a419b70effce3e2231cb7ab7db1211d1d6446c

Reduce time to daily

view details

push time in a month

push eventsimonswine/nixos

Christian Simon

commit sha 624e434468b118fc6443ef27fb5a822c8f1339cd

Enable cert-updater timer

view details

push time in a month

pull request commentgrafana/dskit

Add e2e test framework

I have started moving the labels package out of prometheus into prometheus/common:

https://github.com/prometheus/common/compare/main...simonswine:20210820_move-pkg-labels

In the meantime we could use: https://github.com/simonswine/prometheus-labels

We are currently still depending on cortex via Thanos:

https://github.com/grafana/dskit/pull/8/files#diff-d8682c232bddbc1ce0b4b704b0dd36f60da0f9d93f13cd728d0c3423c4f6afdbR15

simonswine

comment created time in a month

push eventsimonswine/dskit

Christian Simon

commit sha da3b98f1277b02a34ce6581c8f24b59fb26ccedb

WIP TODO: - provide a CI test including docker Signed-off-by: Christian Simon <simon@swine.de>

view details

push time in a month

push eventsimonswine/dskit

Christian Simon

commit sha da3b98f1277b02a34ce6581c8f24b59fb26ccedb

WIP TODO: - provide a CI test including docker Signed-off-by: Christian Simon <simon@swine.de>

view details

push time in a month

push eventsimonswine/dskit

Christian Simon

commit sha 245dc6367bb1be00bb3667ddc95389c3320f9962

Add GitHub action E2E

view details

Christian Simon

commit sha dc7b396063b4ac6b3f5cc79348f4572911d78de0

WIP TODO: - provide a CI test including docker Signed-off-by: Christian Simon <simon@swine.de>

view details

push time in a month

push eventsimonswine/dskit

Christian Simon

commit sha 245dc6367bb1be00bb3667ddc95389c3320f9962

Add GitHub action E2E

view details

Christian Simon

commit sha dc7b396063b4ac6b3f5cc79348f4572911d78de0

WIP TODO: - provide a CI test including docker Signed-off-by: Christian Simon <simon@swine.de>

view details

push time in a month

push eventsimonswine/dskit

Christian Simon

commit sha 488f0418c0d2965bcbfb67289cdd0e968b472841

x

view details

push time in a month

push eventsimonswine/dskit

Christian Simon

commit sha 488f0418c0d2965bcbfb67289cdd0e968b472841

x

view details

push time in a month

push eventsimonswine/dskit

Christian Simon

commit sha ab5b3e10c39bc1e27e0a0088c99f33e50b914a80

x

view details

push time in a month

push eventsimonswine/dskit

Christian Simon

commit sha e2ce3d8c03fb261d7525adaf810b7c92c9d4e719

x

view details

push time in a month

push eventsimonswine/dskit

Christian Simon

commit sha 53cc13cff4b814979c19433f26c9ff158beb0be2

x

view details

push time in a month

push eventsimonswine/dskit

Christian Simon

commit sha 3d4395afdefd0a331a1c0fb7a269023410842950

x

view details

push time in a month

push eventsimonswine/dskit

Christian Simon

commit sha b13695bd463840227a9112174ce7b9f35479d1e6

x

view details

push time in a month

push eventsimonswine/dskit

Peter Štibraný

commit sha bbdc23306d9659e16ce093cd8df24e418d9cb276

Make module service wrapper reusable from other projects (#2250) Moved moduleServiceWrapper to util, available via NewModuleService. It is also bit more generic, to make it reusable between projects. Renamed ErrStopCortex to ErrStopProcess Signed-off-by: Peter Štibraný <peter.stibrany@grafana.com>

view details

Peter Štibraný

commit sha f498973fd53c94c72475fb9f2de6f6243b35bf6a

Only wait for other modules if underlying service is still running. (#2547) Otherwise there is no point in waiting. Signed-off-by: Peter Štibraný <peter.stibrany@grafana.com>

view details

Peter Štibraný

commit sha d65d4eaace3b4275615c22773f31965eebf9976d

Merge release-1.0 to master Signed-off-by: Peter Štibraný <peter.stibrany@grafana.com>

view details

Peter Štibraný

commit sha e150d15115d4ae1c6718633246e6725bfb276be5

Move signal handling out of Server module. (#2576) * Update weaveworks/common Signed-off-by: Peter Štibraný <peter.stibrany@grafana.com> * Moved signal handling out of Server module. This simplifies module service setup, we no longer need to make a distinction between services when using the wrapper or not. Signed-off-by: Peter Štibraný <peter.stibrany@grafana.com> * Updated tests to match updated logic. Signed-off-by: Peter Štibraný <peter.stibrany@grafana.com> * Review feedback. Signed-off-by: Peter Štibraný <peter.stibrany@grafana.com> * Update comment. Signed-off-by: Peter Štibraný <peter.stibrany@grafana.com>

view details

Annanay Agarwal

commit sha c4ef552dc881e8bea5d4e6990a61219698342341

Generalise Modules Service to make it extensible (#2559) * Generalise module service into separate package Signed-off-by: Annanay <annanayagarwal@gmail.com> * Fix build and tests Signed-off-by: Annanay <annanayagarwal@gmail.com> * Fix test Signed-off-by: Annanay <annanayagarwal@gmail.com> * Address review comments Signed-off-by: Annanay <annanayagarwal@gmail.com> * Cleanup cortex_test.go Signed-off-by: Annanay <annanayagarwal@gmail.com> * Fix module test Signed-off-by: Annanay <annanayagarwal@gmail.com> * Checkpoint Signed-off-by: Annanay <annanayagarwal@gmail.com> * Ignore inverse dependencies if module returns nil service Signed-off-by: Annanay <annanayagarwal@gmail.com> * Lint, fix tests Signed-off-by: Annanay <annanayagarwal@gmail.com> * Fix tests for unknown module name Signed-off-by: Annanay <annanayagarwal@gmail.com> * Create module service wrapper only if service is not nil Signed-off-by: Annanay <annanayagarwal@gmail.com>

view details

Peter Štibraný

commit sha f831bb8045a8fd6d215ce1e7ea88c442dcfd1cbd

Merge release-1.1 branch. Signed-off-by: Peter Štibraný <peter.stibrany@grafana.com>

view details

alvinlin123

commit sha 89ab7425ecf97111b3cefa9c9fdb6a1532b71ac4

Dynamically generate available options for -target commandline arg (#2752) * Add ModuleOption to ModuleManager Signed-off-by: Alvin Lin <alvinlin@amazon.com> * add support for -modules option Signed-off-by: Alvin Lin <alvinlin@amazon.com> * refactor so the -modules flag is defied in cortex.go instead of main.go Signed-off-by: Alvin Lin <alvinlin@amazon.com> * Error out if given invalid target name Signed-off-by: Alvin Lin <alvinlin@amazon.com> * Fix tests by defaulting moudules to public Signed-off-by: Alvin Lin <alvinlin@amazon.com> * Update changelog Signed-off-by: Alvin Lin <alvinlin@amazon.com> * Update changelog Signed-off-by: Alvin Lin <alvinlin@amazon.com> * Implemented functional options for RegisterModule Signed-off-by: Alvin Lin <alvinlin@amazon.com> * Remove RegisterModuleWithOption method Signed-off-by: Alvin Lin <alvinlin@amazon.com> * Handled majority of PR comments Signed-off-by: Alvin Lin <alvinlin@amazon.com> * More PR review comments handling Signed-off-by: Alvin Lin <alvinlin@amazon.com> * put functional options for modules inside module package Signed-off-by: Alvin Lin <alvinlin@amazon.com> * Update pkg/util/modules/modules.go Co-authored-by: Peter Štibraný <pstibrany@gmail.com> Signed-off-by: Alvin Lin <alvinlin@amazon.com> * Update pkg/util/modules/modules.go Co-authored-by: Peter Štibraný <pstibrany@gmail.com> Signed-off-by: Alvin Lin <alvinlin@amazon.com> * Address more PR comments Signed-off-by: Alvin Lin <alvinlin@amazon.com> * Remove unneeded asserts Signed-off-by: Alvin Lin <alvinlin@amazon.com> * Update CHANGELOG.md Co-authored-by: Peter Štibraný <pstibrany@gmail.com> Signed-off-by: Alvin Lin <alvinlin@amazon.com> * Minimize diff with upstream/master Signed-off-by: Alvin Lin <alvinlin@amazon.com> * Make code more readible Signed-off-by: Alvin Lin <alvinlin@amazon.com> * avoid creating new type for simple concept Signed-off-by: Alvin Lin <alvinlin@amazon.com> * Update pkg/cortex/cortex.go Co-authored-by: Peter Štibraný <pstibrany@gmail.com> Signed-off-by: Alvin Lin <alvinlin@amazon.com> * remove unused import Signed-off-by: Alvin Lin <alvinlin@amazon.com> * Resolve more conflict Signed-off-by: Alvin Lin <alvinlin@amazon.com> Co-authored-by: Peter Štibraný <pstibrany@gmail.com>

view details

Peter Štibraný

commit sha b4f5914e66fa7c314673190d0f5824e69ca573ed

Make it possible for user to discover which modules are included in "All" target. (#3155) * Make it possible for user to discover which modules are part of "All" target. Signed-off-by: Peter Štibraný <peter.stibrany@grafana.com> * Use "module" terminology. Added CHANGELOG.md. Signed-off-by: Peter Štibraný <peter.stibrany@grafana.com> * Added PR number. Signed-off-by: Peter Štibraný <peter.stibrany@grafana.com>

view details

Igor Novgorodov

commit sha 4ed99e82700b39d1f56afc8836feafef1f0d17ed

Add an ability to load an arbitrary list of Cortex modules (#3275) * Add an ability to load an arbitrary list of Cortex modules Signed-off-by: Igor Novgorodov <igor@novg.net> * Fix module loading logic Signed-off-by: Igor Novgorodov <igor@novg.net> * Improve multiple module loading Signed-off-by: Igor Novgorodov <igor@novg.net> * Add forgotten files Signed-off-by: Igor Novgorodov <igor@novg.net> * Fix linter errors Signed-off-by: Igor Novgorodov <igor@novg.net> * Reduce state in ModuleManager Signed-off-by: Igor Novgorodov <igor@novg.net> * Fix pkg/cortex & pkg/util/modules tests, make initModules() stateless, update docs Signed-off-by: Igor Novgorodov <igor@novg.net> * Fix missed mess with &c.Target pointer cast Signed-off-by: Igor Novgorodov <igor@novg.net> * Cosmetic changes to minimize diff Signed-off-by: Igor Novgorodov <igor@novg.net> * Fix problems with PR #3287 Signed-off-by: Igor Novgorodov <igor@novg.net> * Update CHANGELOG.md Signed-off-by: Marco Pracucci <marco@pracucci.com> * Update pkg/cortex/cortex_test.go Signed-off-by: Marco Pracucci <marco@pracucci.com> * Fixed linter Signed-off-by: Marco Pracucci <marco@pracucci.com> Co-authored-by: Marco Pracucci <marco@pracucci.com>

view details

Peter Štibraný

commit sha a0431805f28c1d730aab43eabb55fa189a9019ea

Query frontend with scheduler fixes (#3508) * Log stream context error, but don't report this error. Added comment. Signed-off-by: Peter Štibraný <peter.stibrany@grafana.com> * Added debug file for frontend with scheduler. Signed-off-by: Peter Štibraný <peter.stibrany@grafana.com> * Check response when forwarding cancellation request. Signed-off-by: Peter Štibraný <peter.stibrany@grafana.com> * Remove frontend address when using scheduler. Signed-off-by: Peter Štibraný <peter.stibrany@grafana.com> * Added query scheduler to launch configs. Signed-off-by: Peter Štibraný <peter.stibrany@grafana.com>

view details

Peter Štibraný

commit sha de8ecd68f90a1a666c865a049713f44decd44b58

Module needs to wait for services from all of its dependencies. (#3551) Signed-off-by: Peter Štibraný <peter.stibrany@grafana.com>

view details

Peter Štibraný

commit sha 36e3e448867b1c8997278028cf6ed6f5d8d787d0

Remove util.Logger and move util.InitLogger to util/log package. (#3781) * Remove util.Logger and move util.InitLogger to util/log package. Signed-off-by: Peter Štibraný <peter.stibrany@grafana.com> * Review feedback. Signed-off-by: Peter Štibraný <peter.stibrany@grafana.com>

view details

Ken Haines

commit sha 1791e358a9e1e787a6afddad9218d1997272292f

fix: reconcile CHANGELOG for v1.7.0 Signed-off-by: Ken Haines <khaines@microsoft.com>

view details

Peter Štibraný

commit sha 38299710913f36383b0fec32d5066c316bf363f1

Merge remote-tracking branch 'upstream-private/release-1.7' into fix-release-1.8 Signed-off-by: Peter Štibraný <peter.stibrany@grafana.com>

view details

Peter Štibraný

commit sha 3d983c8cb1808a863aa79e42f7a3b0b08c301e8b

Merge release-1.7 into release-1.8

view details

Peter Štibraný

commit sha 44f36bad18a964894803950f195fbce1942ef3e5

Merge branch 'release-1.8'. Signed-off-by: Peter Štibraný <peter.stibrany@grafana.com>

view details

Nick Pillitteri

commit sha 936fec98ec346b0501aa1aa305fdd7e4ae960bf1

Add IsModuleRegistered method to modules.Manager (#4173) Add new method for checking if a module has previously been registered with the module Manager. This helps in cases where downstream consumers of Cortex are conditionally adding new modules. Signed-off-by: Nick Pillitteri <nick.pillitteri@grafana.com>

view details

Christian Simon

commit sha 462282f8a34ef2312fce4088a21377182efb83de

Remove backoff to add it with history after

view details

Bryan Boreham

commit sha fb7c8c5c95155921aeae02e8cd4cf0747ac68a71

Unify four backoff implementations (#615) * Replace four backoff implementations with common one

view details

Bryan Boreham

commit sha c39c5addbdd7d4e1198632ec5464fe08bd277539

Break out of backoff loop if Context is terminated (#618) * Remove unused WatchPrefix() * Break out of backoff loop if Context is terminated Previously we would only stop if the Context signalled cancellation while we were in a sleep. Now, loops that check `backoff.Ongoing()` will end if the Context is terminated any time. A new `backoff.Err()` function is added to report back the reason for termination

view details

push time in a month

push eventsimonswine/dskit

Tom Wilkie

commit sha 3d5d34f8f276f1ca1e7d359e1cc8a1ad6d176e46

Move & split up util/flags.go to utils/flagext. Signed-off-by: Tom Wilkie <tom.wilkie@gmail.com>

view details

Tom Wilkie

commit sha 7218f6b8e7b103603f84f56897901307c26c3d41

Specify multiple interfaces to look for an address on. This allows us to start Cortex on the Mac. Signed-off-by: Tom Wilkie <tom.wilkie@gmail.com>

view details

Tom Wilkie

commit sha a2469aab58964a71816b93dc64072e5ffccc5b5b

All URLValues to be unmarshaled from YAML. Signed-off-by: Tom Wilkie <tom.wilkie@gmail.com>

view details

Tom Wilkie

commit sha 7dd31525af1ef891f1df32c7943cfbad622b15a2

Lint, build and test. Signed-off-by: Tom Wilkie <tom.wilkie@gmail.com>

view details

Tom Wilkie

commit sha e55a046b02b6ee36eadcd50864fdfd53774948d3

Review feedback: warn when trying to use a deprecated flag. Typo. Signed-off-by: Tom Wilkie <tom.wilkie@gmail.com>

view details

Bryan Boreham

commit sha 87e524530e716cf8c75a3d941e8da89b958cc571

Re-use Set() method in URLValue.UnmarshalYAML() Signed-off-by: Bryan Boreham <bryan@weave.works>

view details

Chris Marchbanks

commit sha cc9185dafd20eb7e3554b8ec40a46841e7b6f2b9

Use ingester prefix for LifecyclerConfig Many ingester flags were recently broken. This fixes the flags that were broken, but if anyone is running the new HA Ruler they will need to update their consul flags. Signed-off-by: Chris Marchbanks <csmarchbanks@gmail.com>

view details

Chris Marchbanks

commit sha 1e8efa10deee890881b0b3fc77257d4258185828

Revert "Use ingester prefix for LifecyclerConfig" This reverts commit 928ae26d81d18b430786dbebd7e5ee8b7f5059ac. Signed-off-by: Chris Marchbanks <csmarchbanks@gmail.com>

view details

Tom Wilkie

commit sha 78327eac6a81578d4a05916393859cec05f81d8f

Etcd KVClient implementation. (#1322) * Use go.etcd.io/bbolt import and vendor master etcd to we don't import github.com/coreos/... * Move code around - start a kv package with the interface, and subpackages for consul and etcd. * Add prefix to the config of the kvstore. NB This removed the `-consul.prefix` flag. * Split codec into its own package and prefix client into separate files. * Add unit tests and etcd mock. * Remove Client.PutBytes - its only used in one test, can be done with a CAS, and doesn't fit rest of interface with Codecs etc. * Instrument all ring clients, and add comments. Signed-off-by: Tom Wilkie <tom.wilkie@gmail.com>

view details

Tom Wilkie

commit sha b4a47bdeec953bc9942bea09a5c7ee76745b0ce6

Restore previous default for Consul key prefix. (#1506) NB the flag name used to be -consul.prefix, and is now -ring.prefix. Signed-off-by: Tom Wilkie <tom.wilkie@gmail.com>

view details

Callum Styan

commit sha a4ce3f5a879a03384280e12a46c24fbcd55d59cb

Log as debug if etcd CAS comparison does not succeed. (#1524) Signed-off-by: Callum Styan <callumstyan@gmail.com>

view details

Callum Styan

commit sha 6cf0fac5be93142104a4370c48858ff8fcfc1812

Add documentation for HA tracker flags. (#1465) * Add documentation for HA tracker args. Signed-off-by: Callum Styan <callumstyan@gmail.com> * Fix misspelling of Prometheus in HA replica/cluster flags. Signed-off-by: Callum Styan <callumstyan@gmail.com> * Rename accept-ha-samples to enable-ha-tracker Signed-off-by: Callum Styan <callumstyan@gmail.com> * Update args docs based on review and addition of etcd. Signed-off-by: Callum Styan <callumstyan@gmail.com> * Add note in architecture.md about HA tracking. Signed-off-by: Callum Styan <callumstyan@gmail.com> * Specify that certain flags can/should be prefixed with ring/ha-tracker. Signed-off-by: Callum Styan <callumstyan@gmail.com> * Move -ha-tracker.* to -distributor.ha-tracker.* Signed-off-by: Goutham Veeramachaneni <gouthamve@gmail.com> * Make the flags part of ha-tracker and explicit Signed-off-by: Goutham Veeramachaneni <gouthamve@gmail.com>

view details

Tom Wilkie

commit sha 92bb1c50cf4573deb90bbb780e38fb98b71346d8

Honor ConsistentReads in WatchPrefix. (#1555) Signed-off-by: Tom Wilkie <tom.wilkie@gmail.com>

view details

Callum Styan

commit sha 190daaece7675877b3c8f8f186f94df1141bbace

Add HA tracker metrics (#1530) * Add metrics to distributor/HA tracker. Signed-off-by: Callum Styan <callumstyan@gmail.com> * Don't log error in etcd CAS if the return code is a 202. Signed-off-by: Callum Styan <callumstyan@gmail.com> * Add change propagation time histogram Signed-off-by: Goutham Veeramachaneni <gouthamve@gmail.com> * Fix issues with the metrics. 1. Total sample count is wrong 2. The non-ha counting is wrong 3. Deduped doesn't check for 202 Signed-off-by: Goutham Veeramachaneni <gouthamve@gmail.com> * Review fixes + add a separate metric for total samples in (before validation/dedupe). Signed-off-by: Callum Styan <callumstyan@gmail.com> * Don't recount numSamples, update nonHASamples metric properly. Signed-off-by: Callum Styan <callumstyan@gmail.com> * We need to check if removeReplica is false here. Signed-off-by: Callum Styan <callumstyan@gmail.com> * Clarify that receivedSamples metric is accepted samples, post validation/dedupe. Count valid samples for receivedSamples metric instead of using the total samples found in the request. Signed-off-by: Callum Styan <callumstyan@gmail.com> * Log errors from CAS calls at the consumer, instead of in the KV clients. We already do this for HTTP, do this for ring/lifecycler and ha tracker as well. Signed-off-by: Callum Styan <callumstyan@gmail.com>

view details

Bryan Boreham

commit sha 1732277e7eca9c62f8ba727c26807c33389702e3

Update for newer upstream alertmanager Signed-off-by: Bryan Boreham <bryan@weave.works>

view details

Peter Štibraný

commit sha 238fdec4f7fabd83d7b6c5d370f9d323f1c8edc6

Implement Hashicorps's recommendations when watching consul key (#1713) * Implemented recommendations from Consul docs https://www.consul.io/api/features/blocking.html#implementation-details Fixes issue #1708 Signed-off-by: Peter Štibraný <peter.stibrany@grafana.com> * Added tests for rate limiting, and index resets. Signed-off-by: Peter Štibraný <peter.stibrany@grafana.com> * Call cancel function, even though we don't use it. This makes lint happy. Signed-off-by: Peter Štibraný <peter.stibrany@grafana.com> * Use rate limiter from golang.org/x/time/rate Removed copy of modified jaegers' rate-limiter Signed-off-by: Peter Štibraný <peter.stibrany@grafana.com> * Rate limit configuration Signed-off-by: Peter Štibraný <peter.stibrany@grafana.com> * WatchPrefix should use same index checks as WatchKey Signed-off-by: Peter Štibraný <peter.stibrany@grafana.com> * Added comment for NewInMemoryClientWithConfig Signed-off-by: Peter Štibraný <peter.stibrany@grafana.com> * Use rate.Inf as rate limit, when it is not set. Signed-off-by: Peter Štibraný <peter.stibrany@grafana.com> * TestReset doesn't use rate limit now. Signed-off-by: Peter Štibraný <peter.stibrany@grafana.com> * Remove unused variable. Signed-off-by: Peter Štibraný <peter.stibrany@grafana.com> * Rename watch-rate -> watch-rate-limit, watch-burst -> watch-burst-size. Signed-off-by: Peter Štibraný <peter.stibrany@grafana.com> * Use 0 instead of "Zero" Signed-off-by: Peter Štibraný <peter.stibrany@grafana.com> * Updated changelog with consul client enhancements. Signed-off-by: Peter Štibraný <peter.stibrany@grafana.com> * Moved changelog entries to the unreleased version. Signed-off-by: Peter Štibraný <peter.stibrany@grafana.com>

view details

Peter Štibraný

commit sha b38839c41a8cd925a476fb98b4282b26004821ab

Various fixes in Consul client and mockKV ("inmemory" KV store) (#1756) * Various fixes in Consul client and Mock client. - Added tests for WatchKey and WatchKeyPrefix kv.Client methods. - Removed backoff from Consul client when Consul reports no value for given key. Since Consul also reports index, next query will block as expected. - Changed WatchKeyPrefix in Consul client to not report values that were not modified. Consul returns them even if they haven't changed. - Fixed mockKV to always start with Index 1. This in line with how Consul works and what our client expects. It treats returned index 0 as invalid value (per Hashicorps recommendations). - Fixed Get call in mockKV to block for non-existant key if WaitIndex > 0. Again, this is how Consul works, and this inconsistency was primary reason for PR #560, which introduced backoff in such case instead (which then delays everything, especially tests). Added test for this. - Respect context deadline in mockKV.List function - mockKV.List only returns values with supplied prefix now Signed-off-by: Peter Štibraný <peter.stibrany@grafana.com> * Change mock etcd logger to avoid data race. Signed-off-by: Peter Štibraný <peter.stibrany@grafana.com> * Don't handle nil kvps specially. Related to #1680 TODO: Add test Signed-off-by: Peter Štibraný <peter.stibrany@grafana.com> * WatchKey comment, improved tests. Producers in TestWatchKey and TestWatchPrefix now start with sleep, so that clients performing the watching operation will see empty KV store at the beginning. Signed-off-by: Peter Štibraný <peter.stibrany@grafana.com> * TestWatchPrefix now checks that it doesn't see keys under different prefix Signed-off-by: Peter Štibraný <peter.stibrany@grafana.com> * Reduce indentation in Get method, added log line Signed-off-by: Peter Štibraný <peter.stibrany@grafana.com>

view details

Peter Štibraný

commit sha 587ae4536315200953be6da55b1a6a4629ad9bab

Implement kv.Client based on memberlist library. (#1727) Signed-off-by: Peter Štibraný <peter.stibrany@grafana.com>

view details

Peter Štibraný

commit sha 1bd76c65fbade27de79f6a77416b901f1e5f3892

Fix for flaky test. (#1770) * Fix for flaky test. Make sure we get most notifications, but not necessarily all. Signed-off-by: Peter Štibraný <peter.stibrany@grafana.com> * Different fix for flaky test. Timeout for entire test is now longer, but we end early if there is no value for 500ms. We again check that all keys were received exactly once, no room for exceptions. Signed-off-by: Peter Štibraný <peter.stibrany@grafana.com> * Stop test early if we have observed enough keys. Signed-off-by: Peter Štibraný <peter.stibrany@grafana.com>

view details

Callum Styan

commit sha 9164e4bbb716d9ebfbfd6f84fc6cbd95436265a0

CAS calls to the KV store can return HTTP status codes since the (#1798) addition of the HA tracking code. If the return error of the CAS has an HTTP status code, we should return that. This will resolve the issue of the KV metrics showing 500's for all writes from the non-elected Prometheus replicas. Signed-off-by: Callum Styan <callumstyan@gmail.com>

view details

push time in a month

push eventgrafana/dskit

Christian Simon

commit sha ca6ff3ecffd8f9a79b184b1e512cfecc6e3a57a8

Add README and CONTRIBUTING Signed-off-by: Christian Simon <simon@swine.de>

view details

Christian Simon

commit sha 0ade757c5993ad7e64f066512096ed0d10f26024

Apply suggestions from code review Co-authored-by: Arve Knudsen <arve.knudsen@gmail.com> Signed-off-by: Christian Simon <simon@swine.de>

view details

Christian Simon

commit sha 3d288e39e326502b9cbc2b5529b47d62f41e7d35

Apply suggestions from code review Co-authored-by: Arve Knudsen <arve.knudsen@gmail.com>

view details

Christian Simon

commit sha c22e8761f335e66379c9b064348ab14986701361

Merge pull request #17 from simonswine/20210819_add-readme-contributing Add README and CONTRIBUTING

view details

push time in a month

PR merged grafana/dskit

Add README and CONTRIBUTING

This is my first stab at both a README and a CONTRIBUTING markdown. I have used the cortex contributing guide as source of inspiration :slightly_smiling_face:

+142 -1

0 comment

3 changed files

simonswine

pr closed time in a month