profile
viewpoint
If you are wondering where the data of this site comes from, please visit https://api.github.com/users/shobhitagarwal1612/events. GitMemory does not store any data, but only uses NGINX to cache data for a period of time. The idea behind GitMemory is simply to give users a better reading experience.
Shobhit Agarwal shobhitagarwal1612 @google Bangalore Software Developer | Open Source Enthusiast

google/ground-android 142

Ground mobile data collection app for Android

google/ground-platform 77

Ground hosted components: Web console, Cloud Functions, db config

shobhitagarwal1612/Emotion-Analysis 3

Analyze the sentiments of comments in e-commerce website using machine learning and provides specification wise rating of the product

shobhitagarwal1612/android-architecture 0

A collection of samples to discuss and showcase different architectural tools and patterns for Android apps.

shobhitagarwal1612/android-client 0

An android client for the MifosX platform

shobhitagarwal1612/aws-sdk-android-samples 0

This repository has samples that demonstrate various aspects of the AWS Mobile SDK for Android, you can get the SDK source on Github

PR opened google/ground-android

[Testing] Simplify testing by pulling boilerplate to base class

<!-- NOTE: The comments can be left as is as they don't end up in the final preview. -->

<!-- Add one or more issues below if already present. Otherwise, create one. --> Fixes #

<!-- PR description. -->

<!-- Checklist or simple bullet list of things done in the PR. If the PR is WIP, then leave the corresponding task unchecked.

Example:

  • [x] Refactor ObservationViewModel allow modification of sort order.
  • [x] Sort results when returned from ObservationRepository. -->

<!-- Add steps to verify bug/feature. -->

<!-- Attach or paste in a screenshot or GIF (optional) to illustrate the proposed change. -->

@... PTAL?

+479 -617

0 comment

35 changed files

pr created time in 13 hours

PR opened shobhitagarwal1612/ground-android

Hilt tests refactor

<!-- NOTE: The comments can be left as is as they don't end up in the final preview. -->

<!-- Add one or more issues below if already present. Otherwise, create one. --> Fixes #

<!-- PR description. -->

<!-- Checklist or simple bullet list of things done in the PR. If the PR is WIP, then leave the corresponding task unchecked.

Example:

  • [x] Refactor ObservationViewModel allow modification of sort order.
  • [x] Sort results when returned from ObservationRepository. -->

<!-- Add steps to verify bug/feature. -->

<!-- Attach or paste in a screenshot or GIF (optional) to illustrate the proposed change. -->

@... PTAL?

+479 -617

0 comment

35 changed files

pr created time in 13 hours

create barnchshobhitagarwal1612/ground-android

branch : hilt-tests-refactor

created branch time in 13 hours

delete branch shobhitagarwal1612/ground-android

delete branch : cleanup-tests

delete time in 14 hours

PR closed shobhitagarwal1612/ground-android

WIP : Cleanup tests

<!-- NOTE: The comments can be left as is as they don't end up in the final preview. -->

<!-- Add one or more issues below if already present. Otherwise, create one. --> Fixes #

<!-- PR description. -->

<!-- Checklist or simple bullet list of things done in the PR. If the PR is WIP, then leave the corresponding task unchecked.

Example:

  • [x] Refactor ObservationViewModel allow modification of sort order.
  • [x] Sort results when returned from ObservationRepository. -->

<!-- Add steps to verify bug/feature. -->

<!-- Attach or paste in a screenshot or GIF (optional) to illustrate the proposed change. -->

@... PTAL?

+153 -254

0 comment

17 changed files

shobhitagarwal1612

pr closed time in 14 hours

push eventshobhitagarwal1612/ground-android

scottolsen

commit sha 6ccb824337f73fe6000fa13f8c0c0b08b3a275e4

Refactor use of RX in basemap selector; add annotations

view details

scottolsen

commit sha 7393a64fbd31412009fee46cca6d2460aab4e4e5

Refactor use of RX in basemap ui; add annotations

view details

scottolsen

commit sha d525d4dde6e2e0f0312f00b104359c9cc6b57ddf

Update offlineBaseMaps list viewholder on BindViewHolder Previously, the viewholder sometimes maintained a dead reference to the original list of areas on view restoration (e.g after deleting an area), since we never assigned the view holder's area list on Binding. This commit fixes that issue, ensuring we can delete multiple areas in sequence without triggering a crash.

view details

scottolsen

commit sha 59402586443ea382b0358459bd0cb02d91033dbc

Annotate RX observables in repositories and local data store

view details

scottolsen

commit sha 87c70c61d4fdd632ff4b710774c8933cb7e3f0ee

Annotate and refactor RX observables in OfflineBaseMapViewer

view details

scottolsen

commit sha 15fff7e17942a12fc1c9ef012b17053f0db1d69a

Merge branch 'master' of https://github.com/google/ground-android into rx-refactors

view details

scottolsen

commit sha 55587891517693187742474b9bf6502ba558444b

Fix checkstyle violation (bad variable name) in OfflineBaseMapViewerViewModel

view details

scottolsen

commit sha e117865fb3240175607cacfed2572f67cfb4eb4c

pmd: remove unused import

view details

scottolsen

commit sha 012a630cedfb4f4e0360cd19bad855f6a3a6de98

Merge branch 'master' of https://github.com/google/ground-android into rx-refactors

view details

scottolsen

commit sha 8f1be1da6e8707a1b87f9a2762dc2c16fef6f597

OfflineBaseMapViewer clean up RX uses Use more accurate RX types to model single elements, dispose remove clicks stream on clear, rename some variables.

view details

Gino Miceli

commit sha 05a72ee042dd64cf30b828d7374f8e2a12a88988

Merge branch 'master' into rx-refactors

view details

scottolsen

commit sha 5ed2f3403c023e4b6a5d1dd6c09ef75b19b865ff

Restore copyrights

view details

scottolsen

commit sha 0b5c8b5a639e4482caf773990c7b783ef1e3410d

Merge branch 'rx-refactors' of https://github.com/scolsen/ground-android into rx-refactors

view details

scottolsen

commit sha b3c39d7c162ffb22ae16c274f27f4c6380837439

Don't annotate LiveData; fix typo

view details

scottolsen

commit sha 011c713da16b74e3223509436b5b629a5407f04c

Fixup comments; remove some unneeded annotations

view details

scottolsen

commit sha af54260f03d4157ef858440559f8e038df2851b7

refactor(offline-maps): use single subject in download stream This simplifies the stream slightly since we do not need to call `complete` explicitly like we do for a flowable; likewise, any late observers will always receive the value initially emitted by the single subject, so we always download the first selected area.

view details

scottolsen

commit sha 384cf4a5bcf06a70d6caadad19cdbcb6abfeaa59

chore: fix PMD errors

view details

scottolsen

commit sha 7cbb7669aeaa45818872a22ce7baad76677152cf

refactor(offline-maps): clean up selector rx streams - Use a SingleSubject for remove button clicks - Remove unnecessary nesting from streams

view details

scottolsen

commit sha d67164c57d35df5e8287d5ffa9df87fd700ce972

refactor(offline-maps): use resources directly in selector VM Rather than pass the default area name resource string from the selector fragment, we just inject the context and retrieve the resource directly in the selector view model.

view details

Gino Miceli

commit sha 0f086874a917f777b9bc1e0db0ecd1dd74dad56b

Merge branch 'master' into rx-refactors

view details

push time in 19 hours

PR opened shobhitagarwal1612/ground-android

WIP : Cleanup tests

<!-- NOTE: The comments can be left as is as they don't end up in the final preview. -->

<!-- Add one or more issues below if already present. Otherwise, create one. --> Fixes #

<!-- PR description. -->

<!-- Checklist or simple bullet list of things done in the PR. If the PR is WIP, then leave the corresponding task unchecked.

Example:

  • [x] Refactor ObservationViewModel allow modification of sort order.
  • [x] Sort results when returned from ObservationRepository. -->

<!-- Add steps to verify bug/feature. -->

<!-- Attach or paste in a screenshot or GIF (optional) to illustrate the proposed change. -->

@... PTAL?

+153 -254

0 comment

17 changed files

pr created time in 19 hours

create barnchshobhitagarwal1612/ground-android

branch : cleanup-tests

created branch time in 19 hours

push eventshobhitagarwal1612/ground-android

Shobhit Agarwal

commit sha d9a7bc7c980e15ff5f550046166b8a494df25149

Add ApplicationErrorManager for handling exceptions

view details

push time in 2 days

push eventshobhitagarwal1612/ground-android

Shobhit Agarwal

commit sha 1d18d122bb42dfe9be2d01547756c68d74247af2

Add ApplicationErrorManager for handling global exception

view details

push time in 2 days

Pull request review commentgoogle/ground-android

Intercept permission denied exceptions and handle globally

   @Hot(replays = true)   private final MutableLiveData<Boolean> signInProgressDialogVisibility = new MutableLiveData<>(); -  @Hot private final Subject<Integer> unrecoverableErrors = PublishSubject.create();-+  private final RemoteDataStore remoteDataStore;

Thanks for the detailed comment. SGTM.

shobhitagarwal1612

comment created time in 2 days

PullRequestReviewEvent

push eventshobhitagarwal1612/ground-android

Shobhit Agarwal

commit sha 9fcccdbdf0ce01326d6fdf0ac3462bb53d7731db

Replace if-else with ternary for less clutter

view details

push time in 2 days

push eventshobhitagarwal1612/ground-android

Shobhit Agarwal

commit sha 7fe2502aef37c81e92fc218d6a064b9caeccff54

Update tests for MainViewModel

view details

push time in 2 days

PR opened google/ground-android

Intercept permission denied exceptions and handle globally

<!-- NOTE: The comments can be left as is as they don't end up in the final preview. -->

<!-- Add one or more issues below if already present. Otherwise, create one. --> Fixes #1021

<!-- PR description. -->

<!-- Checklist or simple bullet list of things done in the PR. If the PR is WIP, then leave the corresponding task unchecked.

Example:

  • [x] Refactor ObservationViewModel allow modification of sort order.
  • [x] Sort results when returned from ObservationRepository. -->

<!-- Add steps to verify bug/feature. -->

<!-- Attach or paste in a screenshot or GIF (optional) to illustrate the proposed change. -->

@... PTAL?

+122 -28

0 comment

5 changed files

pr created time in 2 days

create barnchshobhitagarwal1612/ground-android

branch : remote-permission-denied

created branch time in 2 days

issue commentgoogle/ground-android

[Code coverage] Unable to open files in codecov

The above suggestion related to relative path is unrelated. Tested in https://github.com/google/ground-android/pull/1025

Needs more investigation

shobhitagarwal1612

comment created time in 8 days

PR closed google/ground-android

Fix relative paths of codecov files cla: yes

https://codecov.freshdesk.com/support/solutions/articles/43000593943-files-not-showing-in-codecov-fixing-paths-

<!-- NOTE: The comments can be left as is as they don't end up in the final preview. -->

<!-- Add one or more issues below if already present. Otherwise, create one. --> Fixes #1023

<!-- PR description. -->

<!-- Checklist or simple bullet list of things done in the PR. If the PR is WIP, then leave the corresponding task unchecked.

Example:

  • [x] Refactor ObservationViewModel allow modification of sort order.
  • [x] Sort results when returned from ObservationRepository. -->

<!-- Add steps to verify bug/feature. -->

<!-- Attach or paste in a screenshot or GIF (optional) to illustrate the proposed change. -->

@... PTAL?

+19 -1

3 comments

2 changed files

shobhitagarwal1612

pr closed time in 8 days

pull request commentgoogle/ground-android

Fix relative paths of codecov files

/gcbrun

shobhitagarwal1612

comment created time in 8 days

push eventshobhitagarwal1612/ground-android

Shobhit Agarwal

commit sha 85a43cac73ab8a625668882bbcafe6b7b4727d66

Copy jacoco to GCS for debugging

view details

push time in 8 days

pull request commentgoogle/ground-android

Fix relative paths of codecov files

/gcbrun

shobhitagarwal1612

comment created time in 8 days

push eventshobhitagarwal1612/ground-android

Shobhit Agarwal

commit sha ed530334471ffebee6be0ba82d24924672b27e3b

Merge MapAdapter into MapFragment

view details

Shobhit Agarwal

commit sha 7c7e28773cbb42f5b3ee67d4de13ef6794db4046

Merge GoogleMapsMapAdapter into GoogleMapsFragment

view details

Shobhit Agarwal

commit sha 270e0338fd45d8badde58d31c713d15be7e50c34

Make custom views accept MapFragment instead of injecting directly Custom Views needs the same instance of MapFragment. Currently, they are being inflated via layout. MapFragment isn't injected into the container fragments yet. So, remove inflation via xml and prepare to inject dependency whenever map is ready.

view details

Shobhit Agarwal

commit sha 848b56f5141d8c04e06da1e46769c3cb8a444495

Migrate container fragments to use AbstractMapViewerFragment

view details

Shobhit Agarwal

commit sha 3f1138198ef1942e2dd23791a4c38bb0db7e096f

Cleanup remaining usages.

view details

Shobhit Agarwal

commit sha c6bc7b45e908f0e1823315c68dd0b231f330db9a

Apply suggested refactors * better method naming * merge overloaded methods * typos

view details

Shobhit Agarwal

commit sha 9d578f2a7cb4f36a639295b3b5ec7a00c5b038ab

Merge pull request #1022 from shobhitagarwal1612/map-refactor Merge MapAdapter with MapFragment and cleanup usages

view details

Shobhit Agarwal

commit sha a2083fd8c1037fb8bd2c80140ce978a05637f18a

Merge branch 'master' into codecov-relative-path

view details

push time in 8 days

PR opened google/ground-android

Fix relative paths of codecov files

https://codecov.freshdesk.com/support/solutions/articles/43000593943-files-not-showing-in-codecov-fixing-paths-

<!-- NOTE: The comments can be left as is as they don't end up in the final preview. -->

<!-- Add one or more issues below if already present. Otherwise, create one. --> Fixes #1023

<!-- PR description. -->

<!-- Checklist or simple bullet list of things done in the PR. If the PR is WIP, then leave the corresponding task unchecked.

Example:

  • [x] Refactor ObservationViewModel allow modification of sort order.
  • [x] Sort results when returned from ObservationRepository. -->

<!-- Add steps to verify bug/feature. -->

<!-- Attach or paste in a screenshot or GIF (optional) to illustrate the proposed change. -->

@... PTAL?

+18 -0

0 comment

1 changed file

pr created time in 8 days

delete branch shobhitagarwal1612/ground-android

delete branch : map-refactor

delete time in 8 days

push eventgoogle/ground-android

Shobhit Agarwal

commit sha ed530334471ffebee6be0ba82d24924672b27e3b

Merge MapAdapter into MapFragment

view details

Shobhit Agarwal

commit sha 7c7e28773cbb42f5b3ee67d4de13ef6794db4046

Merge GoogleMapsMapAdapter into GoogleMapsFragment

view details

Shobhit Agarwal

commit sha 270e0338fd45d8badde58d31c713d15be7e50c34

Make custom views accept MapFragment instead of injecting directly Custom Views needs the same instance of MapFragment. Currently, they are being inflated via layout. MapFragment isn't injected into the container fragments yet. So, remove inflation via xml and prepare to inject dependency whenever map is ready.

view details

Shobhit Agarwal

commit sha 848b56f5141d8c04e06da1e46769c3cb8a444495

Migrate container fragments to use AbstractMapViewerFragment

view details

Shobhit Agarwal

commit sha 3f1138198ef1942e2dd23791a4c38bb0db7e096f

Cleanup remaining usages.

view details

Shobhit Agarwal

commit sha c6bc7b45e908f0e1823315c68dd0b231f330db9a

Apply suggested refactors * better method naming * merge overloaded methods * typos

view details

Shobhit Agarwal

commit sha 9d578f2a7cb4f36a639295b3b5ec7a00c5b038ab

Merge pull request #1022 from shobhitagarwal1612/map-refactor Merge MapAdapter with MapFragment and cleanup usages

view details

push time in 8 days

PR merged google/ground-android

Merge MapAdapter with MapFragment and cleanup usages cla: yes

<!-- NOTE: The comments can be left as is as they don't end up in the final preview. -->

<!-- Add one or more issues below if already present. Otherwise, create one. --> Fixes #993, Fixes #999

<!-- PR description. --> Follow up to #1018. Things done:

  • Merges MapAdapter with MapFragment and GooglemapsMapAdapter with GoogleMapsFragment
  • Uses AbstractMapViewerFragment to attach MapFragment into container fragments.
  • Manually initialises custom views when the map is ready
  • Removes unused code.

<!-- Checklist or simple bullet list of things done in the PR. If the PR is WIP, then leave the corresponding task unchecked.

Example:

  • [x] Refactor ObservationViewModel allow modification of sort order.
  • [x] Sort results when returned from ObservationRepository. -->

<!-- Add steps to verify bug/feature. --> Features tested manually:

  • Adding / deleting / repositioning a feature
  • Updating basemap type
  • Changing screen orientation
  • Offline base maps

<!-- Attach or paste in a screenshot or GIF (optional) to illustrate the proposed change. -->

@gino-m PTAL?

+734 -1039

4 comments

15 changed files

shobhitagarwal1612

pr closed time in 8 days

issue closedgoogle/ground-android

App crashed with "Map fragment already initialized"

Occurring on a fresh install at HEAD on AS emulator with Nexus 5X API 29. Not sure of exact repro steps yet.

2021-08-25 18:28:25.560 8661-8661/com.google.android.gnd E/WindowManager: android.view.WindowLeaked: Activity com.google.android.gnd.MainActivity has leaked window DecorView@e01e221[MainActivity] that was originally added here
        at android.view.ViewRootImpl.<init>(ViewRootImpl.java:597)
        at android.view.WindowManagerGlobal.addView(WindowManagerGlobal.java:377)
        at android.view.WindowManagerImpl.addView(WindowManagerImpl.java:95)
        at android.app.Dialog.show(Dialog.java:342)
        at com.google.android.gnd.ui.home.HomeScreenFragment.showProjectLoadingDialog(HomeScreenFragment.java:485)
        at com.google.android.gnd.ui.home.HomeScreenFragment.onActiveProjectChange(HomeScreenFragment.java:429)
        at com.google.android.gnd.ui.home.HomeScreenFragment.lambda$N1alPoKff1duM2PhBC9QtepNGdM(Unknown Source:0)
        at com.google.android.gnd.ui.home.-$$Lambda$HomeScreenFragment$N1alPoKff1duM2PhBC9QtepNGdM.onChanged(Unknown Source:4)
        at androidx.lifecycle.LiveData.considerNotify(LiveData.java:133)
        at androidx.lifecycle.LiveData.dispatchingValue(LiveData.java:151)
        at androidx.lifecycle.LiveData.setValue(LiveData.java:309)
        at androidx.lifecycle.LiveData$1.run(LiveData.java:93)
        at android.os.Handler.handleCallback(Handler.java:883)
        at android.os.Handler.dispatchMessage(Handler.java:100)
        at android.os.Looper.loop(Looper.java:214)
        at android.app.ActivityThread.main(ActivityThread.java:7356)
        at java.lang.reflect.Method.invoke(Native Method)
        at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:492)
        at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:930)
2021-08-25 18:28:25.797 8661-8661/com.google.android.gnd E/gle.android.gn: Invalid ID 0x00000000.
2021-08-25 18:28:26.295 8661-8661/com.google.android.gnd E/AndroidRuntime: FATAL EXCEPTION: main
    Process: com.google.android.gnd, PID: 8661
    java.lang.IllegalStateException: Map fragment already initialized
        at com.google.android.gnd.ui.map.gms.GoogleMapsMapProvider.init(GoogleMapsMapProvider.java:55)
        at com.google.android.gnd.ui.map.gms.GoogleMapsMapProvider.restore(GoogleMapsMapProvider.java:50)
        at com.google.android.gnd.ui.home.mapcontainer.MapContainerFragment.onViewCreated(MapContainerFragment.java:149)
        at androidx.fragment.app.Fragment.performViewCreated(Fragment.java:2987)
        at androidx.fragment.app.FragmentStateManager.createView(FragmentStateManager.java:546)
        at androidx.fragment.app.FragmentStateManager.moveToExpectedState(FragmentStateManager.java:282)
        at androidx.fragment.app.FragmentStore.moveToExpectedState(FragmentStore.java:112)
        at androidx.fragment.app.FragmentManager.moveToState(FragmentManager.java:1647)
        at androidx.fragment.app.FragmentManager.dispatchStateChange(FragmentManager.java:3128)
        at androidx.fragment.app.FragmentManager.dispatchViewCreated(FragmentManager.java:3065)
        at androidx.fragment.app.Fragment.performViewCreated(Fragment.java:2988)
        at androidx.fragment.app.FragmentStateManager.createView(FragmentStateManager.java:546)
        at androidx.fragment.app.FragmentStateManager.moveToExpectedState(FragmentStateManager.java:282)
        at androidx.fragment.app.FragmentStore.moveToExpectedState(FragmentStore.java:112)
        at androidx.fragment.app.FragmentManager.moveToState(FragmentManager.java:1647)
        at androidx.fragment.app.FragmentManager.dispatchStateChange(FragmentManager.java:3128)
        at androidx.fragment.app.FragmentManager.dispatchViewCreated(FragmentManager.java:3065)
        at androidx.fragment.app.Fragment.performViewCreated(Fragment.java:2988)
        at androidx.fragment.app.FragmentStateManager.createView(FragmentStateManager.java:546)
        at androidx.fragment.app.FragmentStateManager.moveToExpectedState(FragmentStateManager.java:282)
        at androidx.fragment.app.FragmentStore.moveToExpectedState(FragmentStore.java:112)
        at androidx.fragment.app.FragmentManager.moveToState(FragmentManager.java:1647)
        at androidx.fragment.app.FragmentManager.dispatchStateChange(FragmentManager.java:3128)
        at androidx.fragment.app.FragmentManager.dispatchActivityCreated(FragmentManager.java:3072)
        at androidx.fragment.app.FragmentController.dispatchActivityCreated(FragmentController.java:251)
        at androidx.fragment.app.FragmentActivity.onStart(FragmentActivity.java:501)
        at androidx.appcompat.app.AppCompatActivity.onStart(AppCompatActivity.java:246)
        at com.google.android.gnd.AbstractActivity.onStart(AbstractActivity.java:73)
        at android.app.Instrumentation.callActivityOnStart(Instrumentation.java:1425)
        at android.app.Activity.performStart(Activity.java:7825)
        at android.app.ActivityThread.handleStartActivity(ActivityThread.java:3294)
        at android.app.servertransaction.TransactionExecutor.performLifecycleSequence(TransactionExecutor.java:221)
        at android.app.servertransaction.TransactionExecutor.cycleToPath(TransactionExecutor.java:201)
        at android.app.servertransaction.TransactionExecutor.executeLifecycleState(TransactionExecutor.java:173)
        at android.app.servertransaction.TransactionExecutor.execute(TransactionExecutor.java:97)
        at android.app.ClientTransactionHandler.executeTransaction(ClientTransactionHandler.java:57)
        at android.app.ActivityThread.handleRelaunchActivityLocally(ActivityThread.java:5238)
        at android.app.ActivityThread.access$3400(ActivityThread.java:219)
        at android.app.ActivityThread$H.handleMessage(ActivityThread.java:2026)
        at android.os.Handler.dispatchMessage(Handler.java:107)
        at android.os.Looper.loop(Looper.java:214)
        at android.app.ActivityThread.main(ActivityThread.java:7356)
        at java.lang.reflect.Method.invoke(Native Method)
        at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:492)
        at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:930)

closed time in 8 days

gino-m

issue closedgoogle/ground-android

[Regression] App crashes on screen rotate

Describe the bug App crashes on rotation the screen

To Reproduce Steps to reproduce the behavior:

  1. Open the app and login
  2. Select any project
  3. Change screen orientation
  4. See error

Expected behavior No crash

Actual behavior App crashes

Screenshots n/a

closed time in 8 days

shobhitagarwal1612

create barnchshobhitagarwal1612/ground-android

branch : codecov-relative-path

created branch time in 8 days