jonathantneal/svg4everybody 3166
Use external SVG spritemaps today
shawnbot/aight 757
JavaScript shims and shams for making IE8-9 behave reasonably
afiedler/sketch-node-parser 110
Parse files from Sketch using pure NodeJS
SFDigitalServices/sf-dahlia-web 20
DAHLIA is the affordable housing portal for the City and County of San Francisco.
Combine disparate geographic data sets to create motley visual concoctions.
Generate ASCII maps of your favorite United States! :us:
SFDigitalServices/formio-sfds 8
The form.io theme for sf.gov
shawnbot/bookmarklet-boilerplate 8
Bookmarklets 4 life.
Intuitive JavaScript type coercion and data cleanup
[WIP] A collection of low-level vanilla JS tools for building accessible UIs with ARIA
startedpascalgn/npm-publish-action
started time in an hour
PR opened SFDigitalServices/formio-sfds
This adds an "alias" workflow that creates a Vercel deployment URL alias whenever a tag beginning with v is created. For instance, when we tag the next major release with v7.0.0, the workflow should run and create an alias from formio-sfds-v7-0-0.vercel.app to the current production deployment.
The point of this is to make it easier to compare rendered examples in different versions of our theme.
In the future, these aliases could also power a dropdown on the site that allows you to see the examples and docs as of a specific version by changing the hostname of the current URL. I'm going to manually add aliases for a few recent versions by going down the production deployments list. I don't think there's any need to automate doing the retroactive aliases for versions earlier than, say, 6.3.0.
pr created time in an hour
push eventSFDigitalServices/formio-sfds
commit sha 233c20eb844d7d264310000dbefbf55801b70b5d
add back dot-component for /api/strings
push time in an hour
push eventSFDigitalServices/formio-sfds
commit sha 7af996cebc6646855aa55f81b5bc8f0d33a7fab2
also run alias workflow on main
push time in an hour
push eventSFDigitalServices/formio-sfds
commit sha e874b3eaa09c93f5e936c346331454c5c387dba5
simplify, nix workflow_dispatch
push time in an hour
create barnchSFDigitalServices/formio-sfds
created branch time in 2 hours
push eventSFDigitalServices/formio-sfds
commit sha ff479310ea0a8256ec4333183130473b7d2b51d3
clarify how we're using unpkg now, add Vercel link /cc @JimBrodbeck
push time in 3 hours
PR opened SFDigitalServices/sfgov
This bumps us two patch versions:
- 6.4.2 fixes state and zip inputs bumping up on smaller screens and the order of our CSS utilities in the output
- 6.4.3 adds U.S. states to state input lists and removes a
globalThisreference that was breaking IE and Edge ≤ 18
See the diff for the nitty gritty.
pr created time in a day
push eventSFDigitalServices/formio-sfds
commit sha 0fa5957a85db8fb739623de7aab203eaa1052cdb
add htmlelement template tests
commit sha 06789c112d5f512be1a0d058566dabd2e8f6b8e8
fix htmlelement missing content
commit sha 18cacda6e0794ebabb1a505300e1fc676122b102
add template test for "content" component (rich text)
commit sha c61c06e70a56ff5f0ae4708a80609bb16629ec8e
add assertion to fail "Unknown component:" in rendered HTML
commit sha 669613aa47d0ce1b801d711559380e0f40fe1eca
fix "htmlelement" component example (was: "html"), add "content"
commit sha 9b074d72d1924aef34412c5e6a799d7b28f187f5
update snapshots
commit sha 4c9d45e849f21ffc00e56f6eac6503ffbf9bc9c9
bump: v6.4.1
commit sha 22c67b708a55da49835b6c1468947f189145081a
tidy up content smoke tests
commit sha cb51f51a7b4d843088652241df67a972182b21ab
fall back to defaultValue in tk() helper
commit sha 01894abfe1ae432051dc09928c288c9b3eea1a12
Merge pull request #124 from SFDigitalServices/release-6.4.1 Release 6.4.1
commit sha c74fe6783503b9202f4785887c7c11965eab69ee
bump: v6.4.2
commit sha 58d1547920bd61f9adfc7eea59de775108b6233c
add mb-sm-2 class to address component state input
commit sha fff262b3052f7cc5a0305e4ec5aa6fb74ab48c58
update snapshots
commit sha 410ae58b72f0204cd8422662b1640f31ddc6080f
fix flex-wrap utilities (set flex-wrap, not flex-direction)
commit sha 7f4393ff83216c8f3e700ebf19d56dd794ddf2ba
add builder schema JSON preview to portal view
commit sha af0fed678be3132650aef6936234c896cbcf284d
fix output order of responsive spacing utilities
commit sha b455eea2723c019d63486febd29fece6fe5f84d8
fix output order of responsive position utilities
commit sha daa9d65de4217f452500db8f80f0dfbe1d8e8b2b
fix output order or responsive display utilities
commit sha ef285c25ce88e46231eef1ee3ce698e937057a63
tweak address component state margin
commit sha 0c9b7ac0e5cf428bd11d6766388343347cd9ba0c
Merge pull request #125 from SFDigitalServices/release-6.4.2 Release 6.4.2
push time in a day
PR merged SFDigitalServices/formio-sfds
I first merged 6.4.3 to #73 from the CLI and pushed directly, but there were some follow-on items that need addressing. So I've force-pushed that branch back to 70df586 and am working on the remaining issues here.
pr closed time in a day
PR opened SFDigitalServices/formio-sfds
I first merged 6.4.3 to #73 from the CLI and pushed directly, but there were some follow-on items that need addressing. So I've force-pushed that branch back to 70df586 and am working on the remaining issues here.
pr created time in a day
push eventSFDigitalServices/formio-sfds
push time in a day
push eventSFDigitalServices/formio-sfds
commit sha 4879f51de077edcf0501d582277453719032cf8d
bump: v6.4.3
commit sha 1eaccdbc5393ec97e17db9d30a432d07212b032f
update google-spreadsheet
commit sha a2fe42873ef59340eefa15cbab0c57b4c74dc674
add ungap/global-this polyfill
commit sha 7a8f347d30199893f35cf7e656dc1d75b7919c06
remove ungap/global-this import
commit sha 35ea79c2bceea88869b7c2166b67be6d1eca52b1
simplify process.env.NODE_ENV ref
commit sha cb3d07fb59334c55018eb2c2edb0a00aa5585ad8
replace rollp-plugin-inject-process-env with rollup-plugin-define
commit sha d64fa8f10cc07cb1f39ddc65c059d463c1ded734
Merge pull request #127 from SFDigitalServices/states-and-territories Include U.S. territories in "state" component
commit sha 2ce0a62e7f2d5bf692abb69379b9b0394ca6c3a1
Merge pull request #130 from SFDigitalServices/release-6.4.3 Release 6.4.3
commit sha f5b7c8e1692869d31cdd75b262d622db6e0e3a95
Merge remote-tracking branch 'origin/main' into release-7.0.0
push time in a day
issue closedSFDigitalServices/formio-sfds
Script execution fails in IE, Edge < 78
The culprit? rollup-inject-process-env refers to globalThis, which is undefined in older browsers.
closed time in a day
shawnbot
issue commentSFDigitalServices/formio-sfds
Script execution fails in IE, Edge < 78
Fixed in #129.
comment created time in a day
push eventSFDigitalServices/formio-sfds
commit sha 0fa5957a85db8fb739623de7aab203eaa1052cdb
add htmlelement template tests
commit sha 06789c112d5f512be1a0d058566dabd2e8f6b8e8
fix htmlelement missing content
commit sha 18cacda6e0794ebabb1a505300e1fc676122b102
add template test for "content" component (rich text)
commit sha c61c06e70a56ff5f0ae4708a80609bb16629ec8e
add assertion to fail "Unknown component:" in rendered HTML
commit sha 669613aa47d0ce1b801d711559380e0f40fe1eca
fix "htmlelement" component example (was: "html"), add "content"
commit sha 9b074d72d1924aef34412c5e6a799d7b28f187f5
update snapshots
commit sha 4c9d45e849f21ffc00e56f6eac6503ffbf9bc9c9
bump: v6.4.1
commit sha 22c67b708a55da49835b6c1468947f189145081a
tidy up content smoke tests
commit sha cb51f51a7b4d843088652241df67a972182b21ab
fall back to defaultValue in tk() helper
commit sha 01894abfe1ae432051dc09928c288c9b3eea1a12
Merge pull request #124 from SFDigitalServices/release-6.4.1 Release 6.4.1
commit sha c74fe6783503b9202f4785887c7c11965eab69ee
bump: v6.4.2
commit sha 58d1547920bd61f9adfc7eea59de775108b6233c
add mb-sm-2 class to address component state input
commit sha fff262b3052f7cc5a0305e4ec5aa6fb74ab48c58
update snapshots
commit sha 410ae58b72f0204cd8422662b1640f31ddc6080f
fix flex-wrap utilities (set flex-wrap, not flex-direction)
commit sha 7f4393ff83216c8f3e700ebf19d56dd794ddf2ba
add builder schema JSON preview to portal view
commit sha af0fed678be3132650aef6936234c896cbcf284d
fix output order of responsive spacing utilities
commit sha b455eea2723c019d63486febd29fece6fe5f84d8
fix output order of responsive position utilities
commit sha daa9d65de4217f452500db8f80f0dfbe1d8e8b2b
fix output order or responsive display utilities
commit sha ef285c25ce88e46231eef1ee3ce698e937057a63
tweak address component state margin
commit sha 0c9b7ac0e5cf428bd11d6766388343347cd9ba0c
Merge pull request #125 from SFDigitalServices/release-6.4.2 Release 6.4.2
push time in a day
push eventSFDigitalServices/formio-sfds
commit sha c522c98ef92ab1ae34d7504b343d96462c4e2445
add "state" and "zip" snapshots; force <select> elements to refresh
commit sha 3a6609afd6e043b4f675c1797a1478b98afa5360
remote <span> from state select options
commit sha 0691aed058ae299d27223d6f9c395fb83521e911
use "us" npm module for list of states + territories
commit sha 4879f51de077edcf0501d582277453719032cf8d
bump: v6.4.3
commit sha 1eaccdbc5393ec97e17db9d30a432d07212b032f
update google-spreadsheet
commit sha a2fe42873ef59340eefa15cbab0c57b4c74dc674
add ungap/global-this polyfill
commit sha 7a8f347d30199893f35cf7e656dc1d75b7919c06
remove ungap/global-this import
commit sha 35ea79c2bceea88869b7c2166b67be6d1eca52b1
simplify process.env.NODE_ENV ref
commit sha cb3d07fb59334c55018eb2c2edb0a00aa5585ad8
replace rollp-plugin-inject-process-env with rollup-plugin-define
commit sha d64fa8f10cc07cb1f39ddc65c059d463c1ded734
Merge pull request #127 from SFDigitalServices/states-and-territories Include U.S. territories in "state" component
commit sha 2ce0a62e7f2d5bf692abb69379b9b0394ca6c3a1
Merge pull request #130 from SFDigitalServices/release-6.4.3 Release 6.4.3
push time in a day
PR merged SFDigitalServices/formio-sfds
🐛 Bug fixes
- Add U.S. territories to the
statedropdown component list in #127 - Remove unqualified reference to
globalThisthat was throwing errors in IE and Edge <= 18 in #128
🏠 Internal
- Upgrade
google-spreadsheetto 3.0.13 (security update)
Pull requests
- [x] #127 Add U.S. territories to state component values
- [x] #128 Fix
globalThisreference
pr closed time in a day
push eventSFDigitalServices/formio-sfds
commit sha c522c98ef92ab1ae34d7504b343d96462c4e2445
add "state" and "zip" snapshots; force <select> elements to refresh
commit sha 3a6609afd6e043b4f675c1797a1478b98afa5360
remote <span> from state select options
commit sha 0691aed058ae299d27223d6f9c395fb83521e911
use "us" npm module for list of states + territories
commit sha d64fa8f10cc07cb1f39ddc65c059d463c1ded734
Merge pull request #127 from SFDigitalServices/states-and-territories Include U.S. territories in "state" component
push time in a day
delete branch SFDigitalServices/formio-sfds
delete branch : states-and-territories
delete time in a day
PR merged SFDigitalServices/formio-sfds
This updates our list of U.S. states in the state component to include territories (D.C., American Samoa, Guam, Puerto Rico, Virgin Islands. The list comes courtesy of the "us" npm module, and there's a script that regenerates the JSON for our state component from the list, should it ever need to change:
script/make-states
I've also removed the unnecessary <span> elements from the option templates; added snapshot tests for the state and zip components; and added a snippet to the snapshot test suite that triggers the redrawing of select component values, which are not added in the initial render, and which causes the <option> elements to be included in the HTML snapshots.
pr closed time in a day
push eventSFDigitalServices/formio-sfds
commit sha 1eaccdbc5393ec97e17db9d30a432d07212b032f
update google-spreadsheet
commit sha a2fe42873ef59340eefa15cbab0c57b4c74dc674
add ungap/global-this polyfill
commit sha 7a8f347d30199893f35cf7e656dc1d75b7919c06
remove ungap/global-this import
commit sha 35ea79c2bceea88869b7c2166b67be6d1eca52b1
simplify process.env.NODE_ENV ref
commit sha cb3d07fb59334c55018eb2c2edb0a00aa5585ad8
replace rollp-plugin-inject-process-env with rollup-plugin-define
push time in a day
push eventSFDigitalServices/formio-sfds
commit sha c522c98ef92ab1ae34d7504b343d96462c4e2445
add "state" and "zip" snapshots; force <select> elements to refresh
commit sha 3a6609afd6e043b4f675c1797a1478b98afa5360
remote <span> from state select options
commit sha 0691aed058ae299d27223d6f9c395fb83521e911
use "us" npm module for list of states + territories
commit sha d40046c1e0338bb539eb6b4c7b3e79e30e927ebd
update google-spreadsheet
commit sha b79c3a7091b3cd243bb06a73ea48748b58c6a676
add ungap/global-this polyfill
commit sha 6c6f12a74e04e2eb19120fd46d72030d24a12a4d
remove ungap/global-this import
commit sha dd7d0e43d1d2aef3c80db30f8f3a8e425daf0c67
simplify process.env.NODE_ENV ref
commit sha 53e81abd39f0890c57fb64b5a717ae536602c491
replace rollp-plugin-inject-process-env with rollup-plugin-define
commit sha c17cd15540bc087a409df19ba06cecad292b7f50
Merge pull request #129 from SFDigitalServices/global-this Fix unqualified globalThis reference
push time in a day
PR merged SFDigitalServices/formio-sfds
Should fix #128
pr closed time in a day
PR opened SFDigitalServices/formio-sfds
Pull requests
- [ ] #127 Add U.S. territories to state component values
- [ ] #128 Fix
globalThisreference
pr created time in a day
push eventSFDigitalServices/formio-sfds
commit sha 4879f51de077edcf0501d582277453719032cf8d
bump: v6.4.3
push time in a day
pull request commentSFDigitalServices/formio-sfds
As of 53e81ab, this appears to work in Edge 18:
comment created time in a day
startedautomerge/automerge
started time in a day
startednotable/notable
started time in a day
push eventSFDigitalServices/formio-sfds
commit sha 6c6f12a74e04e2eb19120fd46d72030d24a12a4d
remove ungap/global-this import
commit sha dd7d0e43d1d2aef3c80db30f8f3a8e425daf0c67
simplify process.env.NODE_ENV ref
commit sha 53e81abd39f0890c57fb64b5a717ae536602c491
replace rollp-plugin-inject-process-env with rollup-plugin-define
push time in a day
issue openedSFDigitalServices/formio-sfds
Script execution fails in IE, Edge < 78
The culprit? rollup-inject-process-env refers to globalThis, which is undefined in older browsers.
created time in a day
PR opened SFDigitalServices/formio-sfds
This updates our list of U.S. states in the state component to include territories (D.C., American Samoa, Guam, Puerto Rico, Virgin Islands. The list comes courtesy of the "us" npm module, and there's a script that regenerates the JSON for our state component from the list, should it ever need to change:
script/make-states
I've also removed the unnecessary <span> elements from the option templates; added snapshot tests for the state and zip components; and added a snippet to the snapshot test suite that triggers the redrawing of select component values, which are not added in the initial render, and which causes the <option> elements to be included in the HTML snapshots.
pr created time in 4 days
create barnchSFDigitalServices/formio-sfds
branch : states-and-territories
created branch time in 4 days
push eventSFDigitalServices/formio-sfds
commit sha 906a101110e59ac573019c83a569aa4ece62cf36
add preview (proxy) endpoint
commit sha be337c6e347b335ef8ad2fa45ac4a2ff3327e030
make path configurable, try reading standalone bundle w/o require.resolve()
commit sha df8ce8ced0a0dd24a4f8b85802a582085e0feb62
move reading script source into conditional
commit sha 53e5463252c802898c241d9629d2268039a9c436
fix injection logic, better debugging output
commit sha 56c54b3dbd4489cd6c6f7c7df51ca4687cf0e034
fix protocol concatenation
commit sha cfd9f9030b0d09d249b032553d7ca84268a848a9
fix where "env={env}" is output
commit sha 77d9c6d6f0223e76c8c9e2b409cfd3857720a571
tidy up well template
commit sha e940b578ac0d2104214204d8d58d898221839977
add address to list of components that render their own label
commit sha feb1a737eb130689774417860fd114b175b5b8fb
wrap address in <fieldset>, tidy up
commit sha c6a6c71da424eda2dbd846fde907d950565d1274
add integration test for weird invalid state case
commit sha 89f685e3d674a76195f351359d3a7436f2be9491
document and get more specific on the weird test case
commit sha 687deafb66236ed71dfd6a65f872aca4febe13a4
make the address component use the "address" template
commit sha f59cb9357326ff9056ce20dca4de2438f9fc61cd
clean up fieldset scss
commit sha 4060ebd423392562912cc61eba7352988f01da7a
add .formio-nested styles
commit sha 335d7bb8509f7d667b3c5058c0a078f8a5b08c36
add formio-nested class to address template
commit sha f058f1b1c1cd419121e6b09eabfc7bd0ea1f6411
normalize field description styles
commit sha 019d725850176b9795a3999a2d4c1c25eb5c6475
move label (fieldset + legend) into radio template
commit sha d5ec030bcc8c89da4241dbd1b6338da58c81d467
tidy up fieldset template
commit sha bf041e7b0e5b1cc5d28d6b8738b7427c8566b36b
fix errant left margin on "Get started" wizard button
commit sha 9d1b02e8e439948ea3cbd55cb265eaa2ba7b13d1
reset label margins, set font-size: 16px in nested components
push time in 5 days
PR merged SFDigitalServices/formio-sfds
This includes changes to catch up #73 with #122.
pr closed time in 5 days
issue commentSFDigitalServices/formio-sfds
Address component schemas are difficult to control
Some todos from a chat with @sashax, @hshaosf, and @josh-chou:
- [x] Make sure Hui and Josh are invited to the forms working group meeting
- [ ] Update/rewrite this issue so that folks without experience in form.io/formio.js internals can understand it
- [ ] Turn our address component (back) into a "schema template" rather than "component class"
- [ ] Set up webhooks to keep our form.io schemas in git (read-only) so that we can audit address usage
comment created time in 6 days
issue commentSFDigitalServices/formio-sfds
Address component schemas are difficult to control
Okay, I've mulled this over and here are a couple of things that I think we (I) need to do, in approximately this order:
-
Audit our existing forms for existing address components: both ones with the
addresstype and the ones that our custom address component classes (via different versions of our theme) have generated. (Until recently, the component class was generatingcontainercomponents that the form.io portal doesn't treat as "address" types.) -
Bring the design (content, data, and visual) of our ideal address component to the forms working group and hammer out how it should really work: which fields it needs, which ones are required, and potential customizations that it might require for individual forms.
-
Write a thorough test suite for address inputs that ensures it behaves as we expect it. We should consider integration tests with form.io that ensure the roundtrip from portal/builder → server → client/renderer doesn't change its behavior.
-
Rebuild our custom address component to pass the tests and any additional QA.
-
Update (some? all?) existing address fields to use our new component.
comment created time in 6 days
push eventSFDigitalServices/formio-sfds
commit sha c74fe6783503b9202f4785887c7c11965eab69ee
bump: v6.4.2
commit sha 58d1547920bd61f9adfc7eea59de775108b6233c
add mb-sm-2 class to address component state input
commit sha fff262b3052f7cc5a0305e4ec5aa6fb74ab48c58
update snapshots
commit sha 410ae58b72f0204cd8422662b1640f31ddc6080f
fix flex-wrap utilities (set flex-wrap, not flex-direction)
commit sha 7f4393ff83216c8f3e700ebf19d56dd794ddf2ba
add builder schema JSON preview to portal view
commit sha af0fed678be3132650aef6936234c896cbcf284d
fix output order of responsive spacing utilities
commit sha b455eea2723c019d63486febd29fece6fe5f84d8
fix output order of responsive position utilities
commit sha daa9d65de4217f452500db8f80f0dfbe1d8e8b2b
fix output order or responsive display utilities
commit sha ef285c25ce88e46231eef1ee3ce698e937057a63
tweak address component state margin
commit sha 0c9b7ac0e5cf428bd11d6766388343347cd9ba0c
Merge pull request #125 from SFDigitalServices/release-6.4.2 Release 6.4.2
push time in 7 days
PR merged SFDigitalServices/formio-sfds
🐛 Bug fixes
-
Fixes an issue with the state and ZIP code inputs being too close to one another on smaller screens, as reported by @nlsfds:
-
Fixes the output order of many of our responsive CSS utility classes. Previously, each value was output sequentially, which gave precedence to classes with higher values. (For instance,
mb-2was output aftermb-*-0, so it was impossible to usemb-2 mb-md-0.) Now, we output breakpoint media queries sequentially, then values, so that responsive utilities have precedence over non-responsive ones. This is what allowsmb-2 mb-md-0("bottom margin 2 by default, 0 at the medium breakpoint and above") to work.
pr closed time in 7 days
push eventSFDigitalServices/formio-sfds
commit sha ef285c25ce88e46231eef1ee3ce698e937057a63
tweak address component state margin
push time in 7 days
push eventSFDigitalServices/formio-sfds
commit sha 410ae58b72f0204cd8422662b1640f31ddc6080f
fix flex-wrap utilities (set flex-wrap, not flex-direction)
commit sha 7f4393ff83216c8f3e700ebf19d56dd794ddf2ba
add builder schema JSON preview to portal view
commit sha af0fed678be3132650aef6936234c896cbcf284d
fix output order of responsive spacing utilities
commit sha b455eea2723c019d63486febd29fece6fe5f84d8
fix output order of responsive position utilities
commit sha daa9d65de4217f452500db8f80f0dfbe1d8e8b2b
fix output order or responsive display utilities
push time in 7 days
push eventSFDigitalServices/sfgov
commit sha 617a623abf316bacd32b0e32875b0a492d4ce9c0
6.4.2 → 6.4.1
push time in 7 days
issue openedSFDigitalServices/formio-sfds
Address component schemas are difficult to control
So, we have a pretty hairy problem with the address component. It's complicated, and the behavior of the component differs pretty greatly depending on how the component was added to the form.
-
When you drag a component into the form in the portal, the "builder" gets the _ default schema_ of the component from its class definition. The important part of the schema to note is the
components, or children, which might be:- A list of input components defined by the formio.js Address component
- A list of input components defined by our custom Address component
Whichever schema is read by the form builder gets saved to the form definition, and always overrides whatever we have in our theme. That's why, when the built-in Address component is used, our theme still renders the set of fields defined in formio.js (rather than our theme). And, even if we've added one of our custom components, updates to the schema in our theme will be ignored because the component's children on the server "win" when they're merged at runtime.
-
When we instantiate forms with components as
{type: 'address'}and (basically) nothing else in the schema, as inexamples.yml, the default schema is read from our component class at runtime and merged into the one defined in YAML. Because the schema we've provided doesn't have acomponentskey, the one in our component class "wins". This is why our examples all render our address inputs.
So, here's how this is breaking right now:
- Forms that got address components from our custom schema on the form.io portal are "locked in" to whatever default schema was defined in the version of our theme that we told the portal to load (most recently, 6.1.0).
- Forms that use the built-in address component have a schema that includes a Country field between state and ZIP code, and none of the fields are required.
Neither of these is doing the right thing, because the schema that they were locked into doesn't include the right customClass fields that get the spacing right. #125 was intended to fix vertical spacing between the city and ZIP inputs on smaller screens, but only works for our example components; any form with the components locked in ignores the custom classes we've updated in the default schema.
There are a couple of different ways that we can fix this, but they all have positives and negatives. I'll enumerate those in a bit, but I wanted to get this down for now and reach out to the form.io folks for some advice before embarking on a solution.
created time in 7 days
PR opened SFDigitalServices/sfgov
I'll open this for review once https://github.com/SFDigitalServices/formio-sfds/pull/125 is released.
pr created time in 7 days
PR opened SFDigitalServices/formio-sfds
This patch release fixes an issue with the state and ZIP code inputs being too close to one another on smaller screens, as reported by @hshaosf:
The fix is adding an mb-sm-2 utility to the state input, which adds a margin-bottom: 20px at/below the "small" viewport with breakpoint.
pr created time in 7 days
push eventSFDigitalServices/formio-sfds
commit sha fff262b3052f7cc5a0305e4ec5aa6fb74ab48c58
update snapshots
push time in 7 days
push eventSFDigitalServices/formio-sfds
commit sha 0fa5957a85db8fb739623de7aab203eaa1052cdb
add htmlelement template tests
commit sha 06789c112d5f512be1a0d058566dabd2e8f6b8e8
fix htmlelement missing content
commit sha 18cacda6e0794ebabb1a505300e1fc676122b102
add template test for "content" component (rich text)
commit sha c61c06e70a56ff5f0ae4708a80609bb16629ec8e
add assertion to fail "Unknown component:" in rendered HTML
commit sha 669613aa47d0ce1b801d711559380e0f40fe1eca
fix "htmlelement" component example (was: "html"), add "content"
commit sha 9b074d72d1924aef34412c5e6a799d7b28f187f5
update snapshots
commit sha 4c9d45e849f21ffc00e56f6eac6503ffbf9bc9c9
bump: v6.4.1
commit sha 22c67b708a55da49835b6c1468947f189145081a
tidy up content smoke tests
commit sha cb51f51a7b4d843088652241df67a972182b21ab
fall back to defaultValue in tk() helper
commit sha 01894abfe1ae432051dc09928c288c9b3eea1a12
Merge pull request #124 from SFDigitalServices/release-6.4.1 Release 6.4.1
push time in 8 days
PR merged SFDigitalServices/formio-sfds
🐛 Bug fixes
- Fixes missing content when rendering
contentcomponents
🏠 Internal
- Adds smoke tests for
htmlelementandcontentcomponents to ensure that content is rendered - Ensures that HTML snapshots do not contain the text content
Unknown component:, which is what formio.js renders if it doesn't recognize the component type
pr closed time in 8 days
push eventSFDigitalServices/formio-sfds
commit sha 22c67b708a55da49835b6c1468947f189145081a
tidy up content smoke tests
commit sha cb51f51a7b4d843088652241df67a972182b21ab
fall back to defaultValue in tk() helper
push time in 8 days
PR opened SFDigitalServices/formio-sfds
🐛 Bug fixes
- Fixes missing content when rendering
contentcomponents
🏠 Internal
- Adds smoke tests for
htmlelementandcontentcomponents to ensure that content is rendered - Ensures that HTML snapshots do not contain the text content
Unknown component:, which is what formio.js renders if it doesn't recognize the component type
pr created time in 8 days
push eventSFDigitalServices/formio-sfds
commit sha 4c9d45e849f21ffc00e56f6eac6503ffbf9bc9c9
bump: v6.4.1
push time in 8 days
PR opened SFDigitalServices/formio-sfds
🚧 Documenting changes to catch up #73 with #122.
pr created time in 8 days
PR opened SFDigitalServices/sfgov
See https://github.com/SFDigitalServices/formio-sfds/releases/tag/v6.4.0 for more info.
@aekong This release has been tested more thoroughly and is ready to go. This supersedes #695.
pr created time in 8 days
push eventSFDigitalServices/formio-sfds
commit sha 906a101110e59ac573019c83a569aa4ece62cf36
add preview (proxy) endpoint
commit sha be337c6e347b335ef8ad2fa45ac4a2ff3327e030
make path configurable, try reading standalone bundle w/o require.resolve()
commit sha df8ce8ced0a0dd24a4f8b85802a582085e0feb62
move reading script source into conditional
commit sha 53e5463252c802898c241d9629d2268039a9c436
fix injection logic, better debugging output
commit sha 56c54b3dbd4489cd6c6f7c7df51ca4687cf0e034
fix protocol concatenation
commit sha cfd9f9030b0d09d249b032553d7ca84268a848a9
fix where "env={env}" is output
commit sha 77d9c6d6f0223e76c8c9e2b409cfd3857720a571
tidy up well template
commit sha e940b578ac0d2104214204d8d58d898221839977
add address to list of components that render their own label
commit sha feb1a737eb130689774417860fd114b175b5b8fb
wrap address in <fieldset>, tidy up
commit sha c6a6c71da424eda2dbd846fde907d950565d1274
add integration test for weird invalid state case
commit sha 89f685e3d674a76195f351359d3a7436f2be9491
document and get more specific on the weird test case
commit sha 687deafb66236ed71dfd6a65f872aca4febe13a4
make the address component use the "address" template
commit sha f59cb9357326ff9056ce20dca4de2438f9fc61cd
clean up fieldset scss
commit sha 4060ebd423392562912cc61eba7352988f01da7a
add .formio-nested styles
commit sha 335d7bb8509f7d667b3c5058c0a078f8a5b08c36
add formio-nested class to address template
commit sha f058f1b1c1cd419121e6b09eabfc7bd0ea1f6411
normalize field description styles
commit sha 019d725850176b9795a3999a2d4c1c25eb5c6475
move label (fieldset + legend) into radio template
commit sha d5ec030bcc8c89da4241dbd1b6338da58c81d467
tidy up fieldset template
commit sha bf041e7b0e5b1cc5d28d6b8738b7427c8566b36b
fix errant left margin on "Get started" wizard button
commit sha 9d1b02e8e439948ea3cbd55cb265eaa2ba7b13d1
reset label margins, set font-size: 16px in nested components
push time in 8 days
PR merged SFDigitalServices/formio-sfds
🚀 New features
- Improved vertical spacing between components
- Improved font styles for labels and fieldset legends
- Improved spacing between nested (
address,fieldset, andwell) components - Improves direct nesting of
<label>in<fieldset>elements
🐛 Bug fixes
- adds a smoke test for a weird case of failed form validation
- fixes address component "decoupling" issues in the form.io portal
- improves
Pull requests
- [x] #121
- [x] #116 (cherry-picked on the command line)
pr closed time in 8 days
push eventSFDigitalServices/formio-sfds
commit sha c6a6c71da424eda2dbd846fde907d950565d1274
add integration test for weird invalid state case
commit sha 89f685e3d674a76195f351359d3a7436f2be9491
document and get more specific on the weird test case
commit sha 687deafb66236ed71dfd6a65f872aca4febe13a4
make the address component use the "address" template
commit sha f59cb9357326ff9056ce20dca4de2438f9fc61cd
clean up fieldset scss
commit sha 4060ebd423392562912cc61eba7352988f01da7a
add .formio-nested styles
commit sha 335d7bb8509f7d667b3c5058c0a078f8a5b08c36
add formio-nested class to address template
commit sha f058f1b1c1cd419121e6b09eabfc7bd0ea1f6411
normalize field description styles
commit sha 019d725850176b9795a3999a2d4c1c25eb5c6475
move label (fieldset + legend) into radio template
commit sha d5ec030bcc8c89da4241dbd1b6338da58c81d467
tidy up fieldset template
commit sha bf041e7b0e5b1cc5d28d6b8738b7427c8566b36b
fix errant left margin on "Get started" wizard button
commit sha 9d1b02e8e439948ea3cbd55cb265eaa2ba7b13d1
reset label margins, set font-size: 16px in nested components
commit sha 36c2619f5dcd2fc1b874a9d6336fe6910189d681
add well example
commit sha 0a1290ee975f9a35326b49429391f90a309d2ad6
add empty default description to address schema
commit sha 41337a30c0210e12a0b6ddb6f1d66ff74d5c8a9f
use <span> in <label> rather than <div> in checkbox template
commit sha 16c18fc4fc9b431c09a48198f35d8427034ff5a9
conditionally add fg-light-slate to "visible" wells
commit sha 09e90402e95031960c545293c11edc9a61ad49b7
tweak vertical spacing in nested, address components
commit sha 0043259f74ef7691f53761cca3d25f03f8561ff5
remove address component city & state defaults
commit sha 7ab7f37e522d7923d3db645597f7287e2ec97925
add well, fieldset, and fieldset-in-well examples
commit sha 2c173d741db1e30ebff9d755fae1e7b8edaf8560
rework vertical component rhythm css again
commit sha fd3d1724e88a021671c3fe4bc6b4310265c43e6a
improve spacing around fieldset legend + description
push time in 8 days
PR merged SFDigitalServices/formio-sfds
This is a (manual) re-application the blue background and vertical spacing fixes originally introduced in #109, but without the weird regression documented in #119.
Current status
- Something in the 6.3.0 release (#109) broke this form in such a way that it's impossible to move past the 3rd page
- sf.gov is stuck on 6.2.1 until this issue is resolved
- I was hoping to plow ahead to the 7.0 release (#73), but the issue persists in that branch as well
What this does
-
Introduces an integration test that simulates the failure condition of the form linked above. I downloaded the JSON from form.io and turned that into a test fixture, then wrote a very basic test that jumps to the third page, simulates clicking the "next" button, and checks that all of the required fields are properly marked as invalid.
-
Removes blue background from radio, checkbox, and fieldset components; preserves it in address and "well" components; and normalizes vertical spacing within nested components.
Review links
| v6.3.0 | This PR | |
|---|---|---|
| The broken form | Before | After |
| Fieldset component | Before | After |
| Well component | Before | After |
| Radio component | Before | After |
| Selectboxes component | Before | After |
| Address component | Before | After |
| Kitchen sink example | Before | After |
The plan moving forward
- Release this in #122
- Deprecate 6.32. Cherry-pick the integration test onto the 7.0 release branch (and make sure that the test fails as expected!)
- Get the tests passing again
- Release 7.0 #73
pr closed time in 8 days
push eventSFDigitalServices/formio-sfds
commit sha a9c29ecd483f953b459ddc9e5dec70545a43e2a2
update snapshots
push time in 8 days
push eventSFDigitalServices/formio-sfds
commit sha e1971d055af438263890192e0b715e2abc00ef99
bump: v6.3.0
commit sha 33208eafa12e04b34e0fef217c73ee34b0a131ba
add html snapshot serializer
commit sha 8e4535261d5767e2c1648ef7c2cddcefbf2d8254
add component HTML snapshot tests
commit sha 10c3fb28d5d0d44292923986b9c6f0de88707832
add more component snapshots
commit sha ba71a568105fea246a802aa1d0a7fc4ac71f4f76
revert snapshots
commit sha ce098d6815137ca57b17f3781ce08c22f3cb2ff7
bump jest
commit sha dcd00920bdf827c33808737ab596396d8cce1863
Merge pull request #110 from SFDigitalServices/html-snapshots Add HTML snapshot tests
commit sha cc8ec45887b17d7a2e2f70a582f31fc81d9b341f
nix .field-wrapper negative margins
commit sha 5bad5d2461f3b6f36a4557ac229b46d018230ab8
use the "address" template in the Address component
commit sha 504855e0cd0cd7d56af83058e8929165c8485897
add tk(field) template helper
commit sha a2e17337b4d603ae6e25f975294ce7d355c3151d
add CSS fix for button:hover border-bottom
commit sha 984144ba02dceb72ebff8094f2ed62fe5e51d867
fix phoneNumber type, more example descriptions
commit sha 49a40dbbb11a99dccba3436d9245849795f0aa13
fix some bugs in tk() helper
commit sha cbccac37277afcf2ccb350b11e02ef7a0b862a33
move button border-bottom patch out of .btn
commit sha 6391031a0fc52ecc68fcfa3c7f3f4fed8cf29b64
simplify fieldset CSS reset
commit sha a7f87dc67d6ee3d727d7ba0ae1de8a2ba9b6138f
promote <label> letter-spacing reset to hacks
commit sha 5d055d909df00cb7174707afbe1012f7c3dff9e6
wrap address inputs in fieldset w/legend
commit sha 4de617f45e45db3b4d8ea239fbaa1e9cee637ec5
tweak spacing in checkbox template
commit sha ed258d6526d6856c525987d2ebaf464a5d9ffe48
add more "inner description" cases to field template, nix tooltip
commit sha dcbbd3b0ce243dc18a5adde7e153da08feffa320
simplify fieldset component template
push time in 11 days
PR closed SFDigitalServices/formio-sfds
🚧 proof of concept 🚧
This is a second take on the JSX template proof of concept in #107 that uses jsx-pragmatic's HTML renderer as the runtime, and improves the JSX linting situation a bit.
pr closed time in 11 days
PR closed SFDigitalServices/formio-sfds
Nothing to see here... 😗
pr closed time in 11 days
push eventSFDigitalServices/formio-sfds
commit sha 463f771d7bbbb52ae229c8f19828de05cc864bf1
add field label translation test
commit sha d87d27970f3896270933c3fc383c5b4163be4dfc
move more i18n tests from patch -> i18n
commit sha 4abc274500366a68d5ad6f9b9b2535aefe3bec6f
Merge pull request #102 from SFDigitalServices/more-i18n-tests More i18n/translation tests
push time in 11 days
PR merged SFDigitalServices/formio-sfds
This reorganizes the localization tests and adds a kind of smoke test for textfield label translations that we were missing. (The other "end" of this test suite is making sure that the localizations are loaded in the first place. The new test makes sure that i18next gets the localized strings and that they're output in the template.)
pr closed time in 11 days
PR closed SFDigitalServices/formio-sfds
This is a (manual) re-application the blue background and vertical spacing fixes originally introduced in #109, but without the weird regression documented in #119.
Current status
- Something in the 6.3.0 release (#109) broke this form in such a way that it's impossible to move past the 3rd page
- sf.gov is stuck on 6.2.1 until this issue is resolved
- I was hoping to plow ahead to the 7.0 release (#73), but the issue persists in that branch as well
What this does
-
Introduces an integration test that simulates the failure condition of the form linked above. I downloaded the JSON from form.io and turned that into a test fixture, then wrote a very basic test that jumps to the third page, simulates clicking the "next" button, and checks that all of the required fields are properly marked as invalid.
-
Removes blue background from radio, checkbox, and fieldset components; preserves it in address and "well" components; and normalizes vertical spacing within nested components.
Review links
| v6.3.0 | This PR | |
|---|---|---|
| The broken form | Before | After |
| Fieldset component | Before | After |
| Well component | Before | After |
| Radio component | Before | After |
| Selectboxes component | Before | After |
| Address component | Before | After |
| Kitchen sink example | Before | After |
The plan moving forward
- Release this in a patch for 6.2.1 (6.2.2)
- Cherry-pick the integration test onto the 7.0 release branch (and make sure that the test fails as expected!)
- Get the tests passing again
- Release 7.0
- Deprecate 6.3
pr closed time in 11 days
pull request commentSFDigitalServices/formio-sfds
Reapply vertical spacing fixes to 6.2.x, add integration test case
Closing as I've merged this manually in #122.
comment created time in 11 days
PR opened SFDigitalServices/formio-sfds
This PR is a mash-up of #116 and #121, which I merged and resolved conflicts from the command line. It turns out that the conflicts weren't too bad to make this work off of the main branch, which simplifies the release process quite a bit.
🚀 New features
- Improved vertical spacing between components
- Improved font styles for labels and fieldset legends
- Improved spacing between nested (
address,fieldset, andwell) components - Improves direct nesting of
<label>in<fieldset>elements
🐛 Bug fixes
- adds a smoke test for a weird case of failed form validation
- fixes address component "decoupling" issues in the form.io portal
- improves
Pull requests
- #121 (merged on the command line)
- #116 (cherry-picked on the command line)
pr created time in 11 days
push eventSFDigitalServices/formio-sfds
commit sha 906a101110e59ac573019c83a569aa4ece62cf36
add preview (proxy) endpoint
commit sha be337c6e347b335ef8ad2fa45ac4a2ff3327e030
make path configurable, try reading standalone bundle w/o require.resolve()
commit sha df8ce8ced0a0dd24a4f8b85802a582085e0feb62
move reading script source into conditional
commit sha 53e5463252c802898c241d9629d2268039a9c436
fix injection logic, better debugging output
commit sha 56c54b3dbd4489cd6c6f7c7df51ca4687cf0e034
fix protocol concatenation
commit sha cfd9f9030b0d09d249b032553d7ca84268a848a9
fix where "env={env}" is output
commit sha 77d9c6d6f0223e76c8c9e2b409cfd3857720a571
tidy up well template
commit sha e940b578ac0d2104214204d8d58d898221839977
add address to list of components that render their own label
commit sha feb1a737eb130689774417860fd114b175b5b8fb
wrap address in <fieldset>, tidy up
commit sha c2ef0d820e84bcf0d422263ac436e3877f2d990f
bump: v6.2.2
push time in 11 days
push eventSFDigitalServices/formio-sfds
commit sha 5e8947fa4c4472017299341dfda7abfb792317ce
tidy up wizardHeader template
push time in 11 days
push eventSFDigitalServices/formio-sfds
commit sha b2124f29fc41b2eefc97b4e8b960e23ec0018993
add blank option to state values
push time in 11 days
push eventSFDigitalServices/formio-sfds
commit sha da1504419b4731cfb2783d1a7e852b05cd9e328f
prevent custom address component from "detaching" in builder view
push time in 11 days