The difference is because difflib uses the Ratcliff-Obershelp algorithm, not the Levenshtein distance. Probably the readme should be updated, because not always Levenshtein distance is used.

Yeah, Jarvis is now Python 3 only - feel free to use type hints. I should probably use them more often, too ;).

Hi, I am trying to use a shared load balancer in the environment and i have specified everything in the ebextensions file

While uploading the app, it creates a listener in the shared load balancer but also creates another load balancer

I have specified the configuration as below

namespace: aws:elasticbeanstalk:environment option_name: ServiceRole value:

• namespace: aws:elasticbeanstalk:environment option_name: LoadBalancerType value: application

• namespace: aws:elasticbeanstalk:environment option_name: LoadBalancerIsShared value: true

• namespace: aws:elbv2:loadbalancer option_name:ManagedSecurityGroup value:

• namespace: aws:elbv2:loadbalancer option_name: SharedLoadBalancer value: arn

has anyone faced this issue before or am I missing something Thanks Sameer

Makes sense, worst case scenario users will simply end up with larger error message.

Thanks for the fast review!

Up to you really, I don't mind either way. If you want to have the functionality sooner probably merge it and I will implement your suggestions over the weekend and make a new PR. Also, I wanted to ask you about using Python type hints. I usually use type hints with python3, but I noticed that there are not any in the code. Is that because we want to have compatibility with python2? Should I add type hints in my next commits or refrain for doing that for now?

Btw, awesome project and idea!

Thanks for pointing that out!

Looks like nmap may still produce meaningful output even if an error was reported. At last on my system it reports:

warning: Unable to determine any DNS servers.

(don't know why) but still works. Maybe remove the else-clause and call the code in any case?

Noticed python-nmap default adds '-sV' as option. According to man

-sV: Probe open ports to determine service/version info

This takes ages and in line 49 you are dropping this information anyway. As a suggestion, overwrite this parameter for extremely faster scan times:

        nm_scan.scan(s, arguments="")

Hello,

I created a plugin that uses nmap to scan a network address. It could be helpful for a quick check of what devices are active in your LAN. Also you can provide a specific address to be scanned - either private or public IPv4 one. Here are two examples of how the new Jarvis command works:

This image demonstrates scanning a particular address

This example shows how you can scan your local network for example

Future Work I am planning to add more functionalities that give greater flexibility. For example, scan for a specific port range, check if a particular host is up, etc. Also I will add more test cases.

As discussed in the #801 the idea for a marketplace would be a nice addition to the Jarvis community. I've built two new plugins which allow the user to list features ("market find") and also to install new plugins from Github repositories ("market buy"). All the codes should be spotted in the Github Topics and follow the main Jarvis branch. All the documentation and proposal is written in the PLUGINS_MARKETPLACE.md.

An example of basket of plugin is found here. (it is also an template repo.) This is a plugin to read your LinkedIn feed, it needs the Chrome browser and your credentials.

If something isn't clear in the plugins or in the general idea, please let me know! I shall try to explain better.

PS: Of course, there is lots of room for improvement!! Like how to install the necessary requirements without using the "python installer .", etc.

Like the "Duplicated plugin workspace!" warning.

Sorry about that! This warning is completely unrelated to your changes ;). Did not notice, there are two workspace-plugins, since one wasn't loaded because of '@require(native='wmctrl')'

Also, could you explain it to me how would jarvis be able to load the plugins inside the folders on the "marketplace" folder?

Because it's added to the search-path:

diff --git a/jarviscli/Jarvis.py b/jarviscli/Jarvis.py
index dba47287..23f0eb13 100644
--- a/jarviscli/Jarvis.py
+++ b/jarviscli/Jarvis.py
@@ -52,7 +52,7 @@ class Jarvis(CmdInterpreter, object):
 
     def __init__(self, first_reaction_text=first_reaction_text,
                  prompt=prompt, first_reaction=True,
-                 directories=["jarviscli/plugins", "custom"]):
+                 directories=["jarviscli/plugins", "custom", "marketplace"]):
         directories = self._rel_path_fix(directories)
 
         if sys.platform == 'win32':

=> Then I'd say; let's merge! Thanks, again!

Thanks for reporting this issue ;).

We have a benchmark script here: https://github.com/seatgeek/fuzzywuzzy/blob/master/benchmarks.py

I assume there is some way to have these get reported back somewhere, so would be good to get them to run in CI and see if the benchmarks still hold true. Its possible that using python-levenshtein is slower for some class of strings and not others.

So, @pnhofmann , I tried to implement your codes and got all sort of weird things. Like the "Duplicated plugin workspace!" warning. And also my path were all messed up! It kept pointing to my home directory, like "/home/adriel_martins". So I think it is better that you implement this so I could learn from it!

My two ideas are very simple.

1. Delete all non .py files in the git clone process. In order to maintain a certain "hygiene" in the marketplace. No weird things whatsoever.

    # Installing dependencies and removing unwanted files
    basket_files = []
    for root, dirs, files in os.walk(plugin_dir):
        if '.git' in root:
            continue
        else:
            for f in files:
                if f == 'requirements.txt':
                    os.system('cd ' + self.PATH_TO_JARVIS + ' && env/bin/pip install -U -r ' + str(Path(root) / f))
                    os.remove(plugin_dir / f)
                if '.py' not in f:
                    os.remove(plugin_dir / f)
                else:
                    basket_files.append(f)
    os.rmdir(plugin_dir / '.git')
   

2. Mantain a log of downloaded (and, in the future, removed baskets of plugins!)

    # Adding log of baskets bought.
    path = 'jarviscli/data/marketplace_history.csv'
    with path.open('a') as csv_file:
            writer = csv.writer(csv_file)
            writer.writerow([s, str(datetime.datetime.now()), 'installed', basket_files])
   

Well, best regards! I'm execited to see the jarvis project grow! And if there is any more doubts you can contact me!

after inputting the dimensions of the matrix if you input something different from a number this error appears:

I think pypdf2 and further pyttsx might come handy.

Related to #424

dev-branch contains some improvements.

If you like, just really write done some example of common sentence you would like to use with Jarvis. Would be useful for testing ;).

Hi,

Came across this. Amazing job. Great going.

Can you please share how to use this API with little more information for GET, POST, PUT methods?

Thanks in advance.

Hi! Can you give an example what you mean with "basic common commands"?

like when i tested it out, i used the common sentences that we use daily so in that sense

Most of the basic common commands are not defined in the program

Maybe he is referring to https://github.com/Alenjojo/Friday 😉

Oh, I'm Sorry - totally missed your post! Thanks anyway and even if it's a bit late, of course you too a happy new year ;).

Sure, happy to hear you have some more in mind ;). Yeah, I think the straightforward way is, I'll just keep this PR open a bit longer - yes, just commit into the marketplace branch.

(And of course feel free to copy-paste + adapt my 10 code lines from above)

Hi! Can you give an example what you mean with "basic common commands"?

Thanks for reporting this issue! And Sorry for long delay.

In any case, this is interesting... Maybe a version miss-match between nltk and the data? I'll think try to think of something...