profile
viewpoint
Ambrose Chua serverwentdown @scalethat, @makerforceio Singapore, ::1 https://ambrose.website Learning about systems that scale, occasionally taking apart (physical and digital) things.

serverwentdown/alias 9

CoreDNS plugin for replacing CNAME records on zone apex

GeekcampSG/conference-playbook 2

Guide for GeekcampSG Conferences

serverwentdown/assignment-terrible-editor 2

assignment is a synchronised text editor

buildingblocs/2017 1

BuildingBloCS 2017 Website

makerforceio/terra 1

Organic farming, personified and fun

appventure-nush/id-AllApps 0

A simple custom app launcher that reads from a JSON file, made for landscape.

buildingblocs/2018 0

BuildingBloCS 2018 Website

startedm1k1o/neko

started time in 4 days

issue commentpython-poetry/poetry

Poetry on Windows fails with File does not exists error

@lululukas You can adjust the command accordingly, replace 1.1 with master

lululukas

comment created time in 4 days

startednnsee/fileless-elf-exec

started time in 7 days

pull request commentpython-poetry/poetry

[1.1] fix: Broken cache on Windows

@Red-Eyed It wouldn't directly address the mistake made by the previous author.

serverwentdown

comment created time in 8 days

pull request commentpython-poetry/poetry

[1.1] fix: Broken cache on Windows

I believe the curl command wouldn't work on Windows. That's why you're not getting the updated version.

I have updated my comment to fix the PowerShell command.

serverwentdown

comment created time in 10 days

create barnchserverwentdown/scramble

branch : next

created branch time in 11 days

pull request commentpython-poetry/poetry

[1.1] fix: Broken cache on Windows

@damarvin That's the command for Linux. For Windows:

(Invoke-WebRequest -Uri https://raw.githubusercontent.com/python-poetry/poetry/master/install-poetry.py -UseBasicParsing).Content | python - --git git+https://github.com/python-poetry/poetry.git@master
serverwentdown

comment created time in 11 days

push eventserverwentdown/podman

Aditya Rajan

commit sha c050f05ccff6416ccd41d271f0051b395cbe5a1f

filter: add basic pattern matching for label keys Following PR adds basic pattern matching to filter by labels for `keys`. Adds support for use-cases like `--filter label=some.prefix.com/key/*` where end-users want to match a pattern for keys as compared to exact value. Signed-off-by: Aditya Rajan <arajan@redhat.com>

view details

Paul Holzinger

commit sha 8ca300ae94768aae2c3d1d78137ee96423d48e7f

podman machine start wait for ssh Wait for sshd to be ready before we return from start. This should make podman machine ssh immediately available without any race conditions. Fixes #11532 [NO NEW TESTS NEEDED] I could not reproduce the issue so I am not sure if this fixes it. Signed-off-by: Paul Holzinger <pholzing@redhat.com>

view details

Michael Scherer

commit sha 422dc5e6931a652f0aed4013d79b6c6545df48cf

Change error message for compatibility with docker Fix #12315 Signed-off-by: Michael Scherer <misc@redhat.com>

view details

Giuseppe Scrivano

commit sha 277d52686999b9386f8879e742fbe63337a9bb70

rootless: use auto cleanup functions simplify code using auto cleanup functions [NO NEW TESTS NEEDED] it is a refactoring of existing code Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>

view details

Giuseppe Scrivano

commit sha 084e32336aafb5862007f0941485f93bdf78e806

rootless: reuse existing open_namespace function there is already a function for opening a namespace path, reuse it. Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>

view details

Giuseppe Scrivano

commit sha cb9de1007cfacdf2d065dace07476c10fb47a134

rootless: drop strerror(errno) calls *printf functions already support printing the errno string with %m Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>

view details

Giuseppe Scrivano

commit sha 3073543fd95d48a59436b0b5def9cce2244417fc

rootless: use catatonit to maintain user+mnt namespace if catatonit is present, use it to keep the rootless user+mnt namespace alive. [NO NEW TESTS NEEDED] no new features added. Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>

view details

Ed Santiago

commit sha d6c18902ef65ee0fd603f0d29d3ba547afb17faf

System tests: new checkpoint tests Includes a test for the stdout-goes-away bug (crun #756). Skip on Ubuntu due to a many-months-old kernel bug that keeps getting fixed and then un-fixed. Signed-off-by: Ed Santiago <santiago@redhat.com>

view details

etenzy

commit sha 010bee04c3ae05c1e406dca2ad928e723a1aeda4

fix: take absolute path for dd on apple silicon Fixes #12329 [NO NEW TESTS NEEDED] podman machine Signed-off-by: Michael Rödel <hello@mroedel.de>

view details

OpenShift Merge Robot

commit sha 55b2efc02891d5aa867950f630b86cbe550e37dd

Merge pull request #12326 from giuseppe/catatonit-rootless rootless: use catatonit to maintain user+mnt namespace

view details

OpenShift Merge Robot

commit sha 878d22e8319ad6d8df623d8f592db84f8b0096a2

Merge pull request #12325 from giuseppe/rootless-use-auto-cleanup rootless: use auto cleanup functions

view details

OpenShift Merge Robot

commit sha 69e1204e5e5f73319930fa957a850cb8d3dc6910

Merge pull request #12330 from etenzy/main fix: take absolute path for dd on apple silicon

view details

Valentin Rothberg

commit sha 6f6a6925b22d822ec9a04f8832d949f2e52b01e0

fix CI Our fedora-minimal image on Quay bases on fedora-minimal:latest which starting with F35 removed a number of binaries that our CI depends on. Fix that by pulling `fedora-minimal:34` from the Fedora registry directly. Once the build bot on Quay has been disabled, we move the image over there to make sure that it will not change over time. Signed-off-by: Valentin Rothberg <rothberg@redhat.com>

view details

OpenShift Merge Robot

commit sha 9b964945d661d4f97b4a97f2f67d33f9dcd11e50

Merge pull request #12343 from vrothberg/fix-ci fix CI

view details

Valentin Rothberg

commit sha fceecc3a5bb48280fb40f7547156fda44e313421

remote checkpoint/restore: more fixes * Support `checkpoint --pre-checkpoint` * Support `checkpoint --with-previous` * Disable `restore --import-previous` for the remote client since we had to send two files which in turn would require to tar them up and hence be a breaking change. Podman 4.0 would be the chance and I hope we'll find time before that to remote-restore prettier. Note that I did not run over swagger yet to check whether all parameters are actually documented due to time constraints. Fixes: #12334 Signed-off-by: Valentin Rothberg <rothberg@redhat.com>

view details

Giuseppe Scrivano

commit sha e83d366651e9c68e2802924d7c7d3ac69ca3eb14

volumes: add new option idmap pass down the "idmap" mount option to the OCI runtime. Needs: https://github.com/containers/crun/pull/780 Closes: https://github.com/containers/podman/issues/12154 [NO NEW TESTS NEEDED] there is no crun version yet that support the new feature. Test case (must run as root): podman run --rm -v foo:/foo alpine touch /foo/bar podman run --uidmap 0:1:1000 --rm -v foo:/foo:idmap alpine ls -l /foo total 0 -rw-r--r-- 1 root root 0 Nov 15 14:01 bar Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>

view details

Federico Gimenez

commit sha 2e5d3e8fb34ba3ab42d53da9ba39b71e1f53bb75

Introduce Address type to be used in secondary IPv4 and IPv6 inspect data structure. Resolves a discrepancy between the types used in inspect for docker and podman. This causes a panic when using the docker client against podman when the secondary IP fields in the `NetworkSettings` inspect field are populated. Fixes containers#12165 Signed-off-by: Federico Gimenez <fgimenez@redhat.com>

view details

Paul Holzinger

commit sha 62d6b6bf74e2d9be340ee2aaab02d7c54e42535e

rootless netns, one netns per libpod tmp dir The netns cleanup code is checking if there are running containers, this can fail if you run several libpod instances with diffrent root/runroot. To fix it we use one netns for each libpod instances. To prevent name conflicts we use a hash from the static dir as part of the name. Previously this worked because we would use the CNI files to check if the netns was still in use. but this is no longer possible with netavark. [NO NEW TESTS NEEDED] Fixes #12306 Signed-off-by: Paul Holzinger <pholzing@redhat.com>

view details

OpenShift Merge Robot

commit sha 0376e6092c850435b4740876045fdccb467cafd8

Merge pull request #12342 from vrothberg/fix-12334 remote checkpoint/restore: more fixes

view details

Chris Evich

commit sha d6d1ce98022c164cc0074e6eb7850f4cb80d16fb

Minor Makefile fix Signed-off-by: Chris Evich <cevich@redhat.com>

view details

push time in 16 days

create barnchserverwentdown/k3d

branch : docs-podman-compat

created branch time in 16 days

push eventserverwentdown/k3d

Ambrose Chua

commit sha e2c0874dbb29a3b8fe17ff2c1823073009b4a811

fix: Remove call to ContainerExecStart when execing This call seems to be unnecessary and removing it allows usage with Podman. See https://github.com/docker/cli/blob/b0343d9104a1794c3252fa45b985710d6b6afc05/cli/command/container/exec.go#L111

view details

Ambrose Chua

commit sha 873865744ea13e85da9fb690c6925643560c907e

feat: Allow creating the registry on user-defined networks This might be useful when a user wants to use a different network to run the registry, especially for Podman users. This patch avoids adding such a flag to clusterCreate to avoid polluting the arguments for that command. A better long-term solution would be to create a new network for the registry.

view details

push time in 16 days

PR opened rancher/k3d

feat: Weak Podman compatibility

<!-- Hi there, have an early THANK YOU for your contribution! k3d is a community-driven project, so we really highly appreciate any support. Please make sure, you've read our Code of Conduct and the Contributing Guidelines :)

  • Code of Conduct: https://github.com/rancher/k3d/blob/main/CODE_OF_CONDUCT.md
  • Contributing Guidelines: https://github.com/rancher/k3d/blob/main/CONTRIBUTING.md -->

What

<!-- What does this PR do or change? -->

  1. Removes unnecessary call to ContainerExecStart
    • The call seems unnecessary because a container should either be started or attached, according to Docker CLI source code.
  2. Adds a --default-network option to registry create for Podman users & special cases

Why

<!-- Link issues, discussions, etc. or just explain why you're creating this PR -->

  • Some users might like to use k3d with Podman
  • This PR provides some workarounds for compatibility with Podman

Implications

<!-- Does this change existing behavior? If so, does it affect the CLI (cmd/) only or does it also/only change some internals of the Go module (pkg/)? Especially mention breaking changes here! --> None

@all-contributors please add @serverwentdown for code

+24 -16

0 comment

6 changed files

pr created time in 16 days

push eventserverwentdown/k3d

Ambrose Chua

commit sha 380840a1eaa05c1ef9701093b8affd777fcc566e

Remove call to ContainerExecStart when execing This call seems to be unnecessary and removing it allows usage with Podman. See https://github.com/docker/cli/blob/b0343d9104a1794c3252fa45b985710d6b6afc05/cli/command/container/exec.go#L111

view details

Ambrose Chua

commit sha b8a2233ed4f8566140e02e7d950aa9dbad4ea890

Allow creating the registry on user-defined networks This might be useful when a user wants to use a different network to run the registry, especially for Podman users. This patch avoids adding such a flag to clusterCreate to avoid polluting the arguments for that command. A better long-term solution would be to create a new network for the registry.

view details

push time in 16 days

push eventserverwentdown/podman

Ambrose Chua

commit sha 71f870e5f18c9dec5437e963e80e616c8923c29c

compat: Add subnet mask behind IP address to match Docker API Signed-off-by: Ambrose Chua <ambrose@hey.com>

view details

push time in 16 days

pull request commentcontainers/podman

compat: Add subnet mask behind IP address to match Docker API

@Luap99 I have added an APIv2 test but because the API tests run as rootless, it won't populate the IP address field.

serverwentdown

comment created time in 16 days

startedkokseen1/Ka-Ching

started time in 17 days

issue commentpython-poetry/poetry

Installing packages fails when already cached on Windows (making 1.1.9+ unusable on Windows)

@pohlt Wait a while for the next release. In the meantime, you can install the 1.2 branch with:

(Invoke-WebRequest -Uri https://raw.githubusercontent.com/python-poetry/poetry/master/install-poetry.py -UseBasicParsing).Content | python - --git git+https://github.com/python-poetry/poetry.git@master
bparzella

comment created time in 19 days

issue commentrancher/k3d

[FEATURE] Podman support

Oh yes, it's working! Screenshot 2021-11-17 at 21-11-52

Will submit PRs after some cleanup for:

  • Removing ContainerExecStart
  • Documentation regarding using Podman
kkimdev

comment created time in 19 days

issue commentrancher/k3d

[FEATURE] Podman support

I found a compatibility bug in Podman and made a minor change in K3s to get quite far:

  • https://github.com/containers/podman/pull/12328
  • https://github.com/rancher/k3d/compare/main...serverwentdown:fix-podman-compat

Next up I'd have to fix this: Screenshot 2021-11-17 at 20-11-25

kkimdev

comment created time in 19 days

push eventserverwentdown/podman

Ambrose Chua

commit sha ab172262475d11c71fe3d6e7dc3de6e6c97cd66d

compat: Add subnet mask behind IP address to match Docker API Signed-off-by: Ambrose Chua <ambrose@hey.com>

view details

push time in 19 days

create barnchserverwentdown/k3d

branch : fix-podman-compat

created branch time in 19 days

fork serverwentdown/k3d

Little helper to run Rancher Lab's k3s in Docker

https://k3d.io/

fork in 19 days

PR opened containers/podman

compat: Add subnet mask behind IP address to match Docker API

<!-- Thanks for sending a pull request!

Please make sure you've read our contributing guidelines and how to submit a pull request (https://github.com/containers/podman/blob/main/CONTRIBUTING.md#submitting-pull-requests).

In case you're only changing docs, make sure to prefix the pull-request title with "[CI:DOCS]". That will prevent functional tests from running and save time and energy.

Finally, be sure to sign commits with your real name. Since by opening a PR you already have commits, you can add signatures if needed with something like git commit -s --amend. -->

What this PR does / why we need it:

Mismatch between Podman and Docker APIs when listing network containers.

<!--- Please put your overall PR description here -->

How to verify it

On both Docker and Podman, create a container on a network and run:

curl -X GET --unix-socket /var/run/docker.sock http://d/networks/<id> | jq

<!--- Please specify the precise conditions and/or the specific test(s) which must pass. -->

Which issue(s) this PR fixes:

<!-- Please uncomment this block and include only one of the following on a line by itself:

None

-OR-

Fixes #<issue number>

*** Please also put 'Fixes #' in the commit and PR description***

-->

None

Special notes for your reviewer:

+4 -2

0 comment

1 changed file

pr created time in 19 days

push eventserverwentdown/podman

Ambrose Chua

commit sha 364adaecc7abf49c843925db071a9702712deec0

compat: Add subnet mask behind IP address to match Docker API Signed-off-by: Ambrose Chua <ambrose@hey.com>

view details

push time in 19 days

create barnchserverwentdown/podman

branch : fix-compat-ipaddress

created branch time in 19 days

fork serverwentdown/podman

Podman: A tool for managing OCI containers and pods.

https://podman.io

fork in 19 days

issue commentserverwentdown/datetime.link

Redesign

Alternatively, a simpler and crazy scalable implementation is to use Cloudflare Workers with vite-plugin-ssr: https://github.com/brillout/vite-plugin-ssr/tree/master/examples/cloudflare-workers-vue-html-streaming

serverwentdown

comment created time in 20 days

issue commentserverwentdown/file-manager

Cleanup code

  • [ ] Have proper error handling
    • [ ] Shared default error handler, that will always do req.flash()
  • [ ] Switch to async/await syntax, and Promises APIs
  • [ ] Split across multiple files
serverwentdown

comment created time in 20 days

push eventserverwentdown/file-manager

Ambrose Chua

commit sha 249344bd03c9e50b3498e9ae75f8609e9016a78e

style: Format code

view details

push time in 20 days

release serverwentdown/file-manager

v0.2.4

released time in 20 days

created tagserverwentdown/file-manager

tagv0.2.4

A basic node.js file manager

created time in 20 days

more