profile
viewpoint
Andriy Semenets semanser Lutsk, Ukraine

startedseanmonstar/reqwest

started time in 6 days

pull request commentgraphql/graphiql

Add VIM keybindings support

@acao so, I guess adding more tests has no sense, because this PR is going to be rejected?

semanser

comment created time in 7 days

push eventsemanser/graphiql

Andriy Semenets

commit sha 51bdc0e7bb3aecfcb5b656f28f1676b760a694b5

Add even more tests

view details

push time in 7 days

pull request commentgraphql/graphiql

Add VIM keybindings support

ugh i hate to do this because you did a great job of implementing this, and i asked you to add tests. That's totally fine, don't worry :)

for your purposes currently, is there a way you can just require codemirror-vim in a way that overwrites those bindings in a more minimal fashion?

What do you mean with that? Right now, I'm using the default codemirror vim keybindings (and I guess they should work fine). I guess for now, this implementation can work pretty well, and can be replaced later with plugins.

semanser

comment created time in 7 days

push eventsemanser/graphiql

Andriy Semenets

commit sha f9571c198dd5b5c1ec758825fc6aacdefdcab438

Add more tests

view details

push time in 7 days

Pull request review commentgraphql/graphiql

Add VIM keybindings support

 export class QueryEditor extends React.Component {     require('codemirror/addon/dialog/dialog');     require('codemirror/addon/lint/lint');     require('codemirror/keymap/sublime');+    require('codemirror/keymap/vim');

For the toggling between vim/sublime modes, we need to have these files to be preloaded.

semanser

comment created time in 7 days

push eventsemanser/graphiql

Andriy Semenets

commit sha c66374fb8e8db24b3f4262e800fdeb14226f4dea

Add basic tests

view details

push time in 7 days

startedyarnpkg/yarn

started time in 8 days

startedhecrj/iced

started time in 8 days

issue commentrecharts/recharts

Pie Chart - No Label Shown

I was trying to investigate this issue, because I was getting it before, but it seems like all the demos are working fine right now.

Can someone reproduce this issue with the latest version of recharts and yarn demo command?

quangas

comment created time in 8 days

PR opened graphql/graphiql

Add VIM keybindings support

Issue: https://github.com/graphql/graphiql/issues/909

This PR brings VIM key bindings support to the Graphiql.

Features:

  • [x] Query editor
  • [x] Variables editor
  • [x] Toggle keybinding: Cmd-\ or Ctrl-\
  • [x] Local storage persistance
  • [x] Passing like an option to theGraphiQL component
+87 -24

0 comment

3 changed files

pr created time in 9 days

push eventsemanser/graphiql

Andriy Semenets

commit sha b8bb7c5fee3d5431c369561e296afaaca5e4f30b

Add keyMap support for the VariableEditor

view details

push time in 9 days

push eventsemanser/graphiql

Andriy Semenets

commit sha 3ab07be376ded524f9054fb2f481ffb49bbfbeca

Save keyMap to the local storage

view details

push time in 9 days

create barnchsemanser/graphiql

branch : add-vim-keybindings

created branch time in 9 days

fork semanser/graphiql

An in-browser IDE for exploring GraphQL.

fork in 9 days

startedgraphql/graphiql

started time in 9 days

startedpastelsky/bundlephobia

started time in 9 days

startedRasukarusan/fzf-chrome-active-tab

started time in 24 days

startedsindresorhus/query-string

started time in a month

startedjoshdick/dntw

started time in a month

pull request commentsemanser/vim-outdated-plugins

Use origin/branch when checking for new commits + python rewrite

It seems like I'm not able to add commits to this PR (I can't push to your branch).

thisisrandy

comment created time in a month

pull request commentsemanser/vim-outdated-plugins

Use origin/branch when checking for new commits + python rewrite

hi @thisisrandy! Thanks for your work and sorry for my late reply.

I've tried it and it works much better than vimscript version. Good job!

What is the minimal version of python required? I want to update the README file.

thisisrandy

comment created time in a month

starteditchyny/calendar.vim

started time in a month

startedreact-spring/react-spring

started time in a month

startedfaltimiras/GlacierBackupper

started time in a month

startedLeaflet/Leaflet

started time in a month

startedsindresorhus/Gifski

started time in 2 months

startedwting/autojump

started time in 2 months

startedIMOKURI/line-number-interval.nvim

started time in 2 months

startedliuchengxu/vista.vim

started time in 2 months

startedappleboy/telegram-action

started time in 3 months

startedsmooth-code/loadable-components

started time in 3 months

more