profile
viewpoint

dkhamsing/open-source-ios-apps 23975

:iphone: Collaborative List of Open-Source iOS Apps

Deevad/peppercarrot 78

Tools, Scenarios, character descriptions, world, main repository of the Pepper&Carrot open webcomic project

morevnaproject-org/RenderChan 34

A smart rendering manager

chchwy/pencil2d 9

Pencil2D lets you create traditional hand-drawn animation (cartoon) using both bitmap and vector graphics. Pencil2D works on Windows, macOS and Linux.

morevnaproject/subtitles-translation 4

Subtitles for animated shorts of Morevna Project

scribblemaniac/Fibonacc-iClock 4

A clock for iOS based off of the famous fibonacci sequence

morevnaproject/RenderChan-Blender-Plugin 1

A plugin for Blender that will render various file formats before importing them.

scribblemaniac/automator-collection 1

A collaborative collection of Mac Automator scripts

scribblemaniac/AwakenDreams 1

A large Middle Earth mod for Minecraft

scribblemaniac/duckduckgo-tor-browser-search-plugin 1

A Tor Browser search plugin for DuckDuckGo's hidden service

CommitCommentEvent
CommitCommentEvent
CommitCommentEvent

push eventscribblemaniac/pencil

transifex-integration[bot]

commit sha 05cbfb5c9eb64ef4ae78b93df8fe93ef412d4c4e

Translate /translations/pencil.ts in da (#1387) translation completed for the source file '/translations/pencil.ts' on the 'da' language. Co-authored-by: transifex-integration[bot] <43880903+transifex-integration[bot]@users.noreply.github.com>

view details

scribblemaniac

commit sha 575103bd8134b6a3c7175521dd02035ff4729578

Fix short scrub toggle not working at first position

view details

scribblemaniac

commit sha 4cf997e7fa51c9c7c70cb5bb156b0c72457a1fda

Uncheck loop option when disabled in movie export dialog This avoids possible confusion that the video formats which do not support looping will be forced to loop.

view details

scribblemaniac

commit sha 41917e3cbeedb204d36f87005356fc1fe93002b3

Log ffprobe failure even if ffmpeg fallback succeeds

view details

scribblemaniac

commit sha 300eb3de80c7a7b637670f5c210a54757dc1ebf5

Fix frames not being rendered because they are not loaded This can happen when going to a frame where at least one of the layers is on an exposure of a keyframe that has not been loaded.

view details

scribblemaniac

commit sha 317a5ae2ffa5f82a2c4efd7e6eec292c9a7bd08f

Draw active selection transformation over current layer

view details

Matt Chang

commit sha f3dee2aa7fee448b8814f55d94b0d5e6f1b076ec

Sync translations from Transifex

view details

Matt Chang

commit sha 61158c1bc4aaf9d487731e9acecc48f202730abb

lupdate: update the source language

view details

Matt Chang

commit sha cc7b81ebc3bf4a1fd579b24d0f660d10e387b6d3

lrelease: generating qm files

view details

Matt Chang

commit sha 24415f140b9a7a9495218c6b6dce412280c88b18

Try fixing linux nightly by add python package typing

view details

transifex-integration[bot]

commit sha 9ab84e411462085d36129566bf9c279d72d7790f

Translate '/translations/pencil.ts' in 'da' (#1389) * Translate /translations/pencil.ts in da translation completed updated for the source file '/translations/pencil.ts' on the 'da' language. * Translate /translations/pencil.ts in da translation completed updated for the source file '/translations/pencil.ts' on the 'da' language. * Translate /translations/pencil.ts in da translation completed updated for the source file '/translations/pencil.ts' on the 'da' language. * Translate /translations/pencil.ts in da translation completed updated for the source file '/translations/pencil.ts' on the 'da' language. * Translate /translations/pencil.ts in da translation completed updated for the source file '/translations/pencil.ts' on the 'da' language. Co-authored-by: transifex-integration[bot] <43880903+transifex-integration[bot]@users.noreply.github.com>

view details

scribblemaniac

commit sha d4c7bc6e0ba4373d6d0f8be8ca55e5c8bb50b678

Check for null pointer returned by getLastVectorImageAtFrame where relevant There are places that only have a Q_CHECK_PTR because they follow a call to ScribbleArea::handleDrawingOnEmptyFrame which should guarantee a frame after invocation. However this is called only at the start of a stroke typically, which means that if the frame is deleted while the stroke is in progress (ex. with a shortcut), then it will still crash without a check. Users who aren't trying to break the program will likely never do this, but we might as well add the checks if we know the issue is there.

view details

scribblemaniac

commit sha 75d6cc594b8c03d56e588af4a250f29ff56b991f

Check for null pointer returned by getLastBitmapImageAtFrame where relevant See commit message of f61b6ad. This is the same thing execpt for bitmaps.

view details

scribblemaniac

commit sha 5a4487c203e7c4a40e7c544bb40fb53f31f588e7

Fix unhandled cases where LastFrameAtFrame returns -1 This was causing crashes when there were no previous frames on any layer.

view details

transifex-integration[bot]

commit sha 4e1fe58be711fa9aea94dc093d1dd8987f8a333b

Translate /translations/pencil.ts in da (#1392) translation completed updated for the source file '/translations/pencil.ts' on the 'da' language. Co-authored-by: transifex-integration[bot] <43880903+transifex-integration[bot]@users.noreply.github.com>

view details

transifex-integration[bot]

commit sha e1404f97273914948495cd0d380571bd086f60df

Translate '/translations/pencil.ts' in 'cs' (#1391) * Translate /translations/pencil.ts in cs translation completed for the source file '/translations/pencil.ts' on the 'cs' language. * Translate /translations/pencil.ts in cs translation completed updated for the source file '/translations/pencil.ts' on the 'cs' language. Co-authored-by: transifex-integration[bot] <43880903+transifex-integration[bot]@users.noreply.github.com>

view details

Matt Chang

commit sha f83023b67a8dac4f43e54f5e12f45aa9eac8671f

Remove debug print

view details

Matt Chang

commit sha 7e45c379fa8f062c065d2095b3b46fc1f0a5491f

CanvasPainter does not need to be a QObject

view details

Matt Chang

commit sha 0738cac1c68510bf133975b96755b3f28d88e057

No need to set current layer when opening an Object

view details

Matt Chang

commit sha 91f0b97d933fff060727f3a78a63a5dfe8c5a18d

Always generate debug info in Visual Studio

view details

push time in 15 hours

CommitCommentEvent
CommitCommentEvent
CommitCommentEvent

PR opened homebrew-ffmpeg/homebrew-ffmpeg

Switch from NASM to YASM

This is a quick workaround for #30. I was able to reproduce the issue and switching to YASM like so fixed it. This probably should not be a long-term fix as ffmpeg intentionally prefers NASM (see https://github.com/FFmpeg/FFmpeg/commit/4f9297ac3b39098547863d28fbc8d2a906d5be49), but they basically both do the same thing as I understand it so it's not a big deal to do this for now.

Fixes #30

+2 -1

0 comment

1 changed file

pr created time in 2 days

push eventscribblemaniac/homebrew-ffmpeg

scribblemaniac

commit sha a7bc6c4c0140fb6e7fdae7dca5bafec3f15f4f67

Switch from NASM to YASM Fixes #30

view details

push time in 2 days

fork scribblemaniac/homebrew-ffmpeg

A homebrew tap for an ffmpeg formula with lots of options

fork in 2 days

issue commenthomebrew-ffmpeg/homebrew-ffmpeg

Can't build ffmpeg 4.3: "vf_blend.asm:416: out of memory"

Base on the information provided so far, I would bet that this issue is caused by an upgrade to NASM 2.15.01 which was done a few days ago. As a workaround you could switch to another assembler (ex. YASM) with an environment variable (X86ASM?) and it might build successfully. If this is the issue, it's up to ffmpeg or nasm to fix it.

JaceTBL

comment created time in 3 days

issue commentpencil2d/pencil

[BUG] Drawing Tools Stroke Latency (Lag) & Interpolation Issue

There is some caching done since v0.6.4 which should improve the speed of brush strokes rendering, particularly when you have many layers. Issues will remain when drawing very large strokes and probably under some other circumstances.

Jose-Moreno

comment created time in 16 days

push eventscribblemaniac/pencil

scribblemaniac

commit sha 317a5ae2ffa5f82a2c4efd7e6eec292c9a7bd08f

Draw active selection transformation over current layer

view details

push time in 19 days

push eventscribblemaniac/pencil

scribblemaniac

commit sha 300eb3de80c7a7b637670f5c210a54757dc1ebf5

Fix frames not being rendered because they are not loaded This can happen when going to a frame where at least one of the layers is on an exposure of a keyframe that has not been loaded.

view details

push time in 19 days

push eventscribblemaniac/pencil

scribblemaniac

commit sha 41917e3cbeedb204d36f87005356fc1fe93002b3

Log ffprobe failure even if ffmpeg fallback succeeds

view details

push time in 20 days

push eventscribblemaniac/pencil

scribblemaniac

commit sha 575103bd8134b6a3c7175521dd02035ff4729578

Fix short scrub toggle not working at first position

view details

scribblemaniac

commit sha 4cf997e7fa51c9c7c70cb5bb156b0c72457a1fda

Uncheck loop option when disabled in movie export dialog This avoids possible confusion that the video formats which do not support looping will be forced to loop.

view details

push time in 20 days

push eventscribblemaniac/pencil

scribblemaniac

commit sha b58207e341e8e34d1ce4a9a9d2257b97e2ef7c5f

Fix unhandled cases where LastFrameAtFrame returns -1 This was causing crashes when there were no previous frames on any layer.

view details

push time in 20 days

push eventscribblemaniac/pencil

David Lamhauge

commit sha f9ee57e8ac8c83fc92ef5a21a239c6c5cc923fda

Changed Colour to Color. Filenames and file content

view details

David Lamhauge

commit sha 3a731ce07176f79cc30aa1a5f3e5629eef7f8848

Secure backward compatibility where needed

view details

David Lamhauge

commit sha e1764013074154b0008ef30378ee7394249c434e

merged master into branch

view details

David Lamhauge

commit sha 4c4ef16ae0d7b7359210dd08ccde5b12647bd6e7

Changed *.ts files to 'colour'

view details

David Lamhauge

commit sha c73599a4ac6f7b3aa42fb972aa47196f8be716ba

Checking for nullptr to prevent crash with Ctrl+A and Ctrl+D

view details

Matt Chang

commit sha 692ef85683959928e2a77c12257be3b23d96e70d

Code cleanup: add comments, remove unused keyword virtual, remove extra spaces.

view details

Matt Chang

commit sha f6173dd91bfa36a8eb60b8891e6def980fc781bd

Missing header file QPainterPath - Build error with Qt 5.15

view details

Matt Chang

commit sha e7dddddbd593cd3edb6e0d2719a0bf4e77c997d5

Merge pull request #1365 from davidlamhauge/changeColourToColor Change: Colour -> Color (Filenames and file content)

view details

Jakob Gahde

commit sha ce30ae18d957c42e5c7b67ca53f9aca47e770bdb

Fix errors, warnings and deprecations from Qt 5.15

view details

Jakob Gahde

commit sha afdf906042f3a4913cf43d81e74ab04fd1ef932e

Remove old code whose functionality is now also provided by Qt

view details

Matt Chang

commit sha 2a27d506fe690b3bccdb42475e5b44587d015290

Merge branch 'master' into pre-release-fixes

view details

Matt Chang

commit sha 00fc2b577d01b6eee14800577c74ec546860329a

Fix compiler errors after merging

view details

Matt Chang

commit sha 35087530a683a09d2b412a752b8b1bd23061267f

Merge branch 'pre-release-fixes'

view details

Matt Chang

commit sha 21a4dbfd6a94c99fb4fa1bca8d80864dc6660e8a

lupdate: update the source language

view details

Matt Chang

commit sha bf478f29bb2e1094a772e9bb8267f5312620c7cf

lupdate: update the source language

view details

Matt Chang

commit sha 2142e15f60c986b93589ab64752a40df4d5c43cf

Fix a Transifex error about Qt plural strings

view details

Matt Chang

commit sha 738c8e236594c749f938684c11c51f7cbf1955ec

Fix an unnecessary translation

view details

Matt Chang

commit sha 51970262ddc1be96ae7ee50b0d36f2d468457e39

Test Transifex integration

view details

transifex-integration[bot]

commit sha 6647e4f96c4b62bb7cf29db32ca84643473e2bc8

Translate /translations/pencil.ts in zh_CN (#1374) at least 60% translated updated for the source file '/translations/pencil.ts' on the 'zh_CN' language. Manual sync of partially translated files: untranslated content is included with an empty translation or source language content depending on file format Co-authored-by: transifex-integration[bot] <43880903+transifex-integration[bot]@users.noreply.github.com>

view details

Matt Chang

commit sha 8b531d0ea143e12d9c25128467885dd9d4b40a00

Fix QStringLiteral

view details

push time in 20 days

PR opened pencil2d/pencil

Fix more crashes when there is no previous frame

This is a follow up to #1371 and deals with the same type of issues that caused #834. Hopefully this takes care of all such issues.

+161 -92

0 comment

12 changed files

pr created time in 20 days

create barnchscribblemaniac/pencil

branch : no-previous-frame-crashes

created branch time in 20 days

create barnchscribblemaniac/pencil

branch : selectDeselectAllCrashing

created branch time in 20 days

push eventscribblemaniac/pencil

scribblemaniac

commit sha f7eae262b84f95b26a5ef0ba1f09d9075d5c74c8

Match eraser dab behavior to eraser stroke behavior

view details

scribblemaniac

commit sha 909976edc1367303a563ac98ad03a94ad77d3a3d

Fix deselect all action not updating view

view details

scribblemaniac

commit sha ace69d8e06a901bd46b6d9684b6f7b8dbe97a642

Remove useless code in quick sizing The only way this code would be executed is when there is feather and the alt key is held (command is handled in the block above). However, all tools with feather use alt for the eyedropper, so this is never used.

view details

scribblemaniac

commit sha 586e8d94fb42c44ec679db3b1bb3ebde3a39b749

Rewrite quick size cursor display The cursor now stays and the inital place where pressed. Various cosmetic changes have been applied to improve visibility and code quality.

view details

scribblemaniac

commit sha 3b69bf15e2e820c72aed428e432bb360cd194691

Properly write the current frame when saving a project file

view details

scribblemaniac

commit sha 8283e027b950afbbbef02cfe3745bb7683b98d47

Change zoom slider focus policy I believe the default focus policy for QSlider is StrongFocus, but the focus when clicking behavior means that it will often block shortcuts from working after performing certain actions.

view details

scribblemaniac

commit sha 305b26f6ce28eb663f9ade9fd9edf7d21051601a

Merge branch 'master' of github.com:scribblemaniac/pencil into pre-release-fixes

view details

scribblemaniac

commit sha 66616c481ab907db7689e8684caddb1d75f85ff8

Remove multilayer onion skin action from menu Having a multilayer onion skin setting would be good, but we don't have that feature right now, so this action does nothing. Even if we did have this feature, the menu isn't the best place for this setting.

view details

scribblemaniac

commit sha d9760f56b90496346f6edfb751ddc096ac4f4987

Fix Recent File list wipe issue The recent file list was being wiped on startup because we are now opening a project on startup (templates) which saves an empty recent file list before the old one can be loaded. Additionally, it was saving every time it clears the list, which is not a good idea since that can be used internally before making other changes.

view details

scribblemaniac

commit sha 908388e0f9ec34195d8fca2a2b474b23778797bb

Allow new selection to be created by clicking and dragging outside of an existing selection

view details

scribblemaniac

commit sha 8ac0e514441bc8d3dfc6c655226f93895cb7d40f

Round selection to the nearest pixel when on the bitmap layer This was fixed and then reintroduced by #1223. All points of a selection need to be a whole number right now. Otherwise you have borders drawn ambiguously between pixels, and obscure issues when the values are rounded differently. For instance, flipping a selection and then moving it could in some circumstances leave behind a row/column of pixels.

view details

scribblemaniac

commit sha ee8248944e738ebe9c358523461f093836766eae

Improve center overlay rendering Depending on the zoom level, the center overlay sometimes would not show lines right in the center, or would only show half of the lines because it is dashed. By drawing four lines from the center instead of two through the center, it seems there will always be lines at the center, even when zoomed out or in.

view details

scribblemaniac

commit sha 6bd0fb72bdfec9cd9824858ae347fd94be1d5262

Disable selection actions in menu when there is no selection Also removed updateCurrentFrame in a few places because it will be triggered by selectionChanged.

view details

scribblemaniac

commit sha 1b8a7347130ee29fa66f0381815468130ece4b7e

Change default project color I've always hated this crap brown color on startup. Black is a much more practical color and matches with the initial vector layer color.

view details

scribblemaniac

commit sha 5c4730681519dfd1b33bc4a604f3bf95b40d1f8a

Fix many preset issues There were issues with not using the default preset when opening. There were issues with the window title and save state not being reset. There were probably other issues. Mostly from 7992c8f.

view details

scribblemaniac

commit sha 701dd95f035c0e4359a160ef0162e2a63754f355

Add possible workaround for #1017

view details

scribblemaniac

commit sha bfda42fc5c2b2bd6b6e93e0da480696f34f048b5

Move quick size handling to the tools In addition to be being a more logical location for this code, it also allows for more customization of the quick sizing to each tools specific needs. For example, the bucket tool uses it for adjusting the fill expansion, but that only applies to the vector layer so it should not be active when using the bitmap layer. The pencil tool has a feather property, but it can't be changed, so quick sizing should not be enabled for that. Fixes #1186

view details

scribblemaniac

commit sha 0f69bb53279dd66e057dad9fe043466b1bf8b345

Add more information to ffmpeg error messages Having the command executed is particularly important so it can be executed separately for testing purposes.

view details

scribblemaniac

commit sha 5eca8a100775d8342b7c01873eb5633588761f6e

Remove the import preview box from the export dialogs

view details

scribblemaniac

commit sha 094a2395681a504d1c82ffc4dc1a9e598b329e67

Fix some operations which ignored the draw on empty frame preference Specifically modified the select/move tools, cut, paste, and delete selection actions.

view details

push time in 20 days

push eventpencil2d/pencil

David Lamhauge

commit sha c73599a4ac6f7b3aa42fb972aa47196f8be716ba

Checking for nullptr to prevent crash with Ctrl+A and Ctrl+D

view details

scribblemaniac

commit sha c718ee5094bb396afdcbb37b6502c8613e3c0db1

Merge pull request #1371 from davidlamhauge/selectDeselectAllCrashing Checking for nullptr to prevent crash with Ctrl+A and Ctrl+D

view details

push time in 20 days

PR merged pencil2d/pencil

Reviewers
Checking for nullptr to prevent crash with Ctrl+A and Ctrl+D bug

Pencil2D was crashing if there was no frame on frame 1, and you tried to Ctrl+A on that frame. Checking for nullPtr fixes that.

Does this close #834?

+8 -1

1 comment

1 changed file

davidlamhauge

pr closed time in 20 days

issue closedpencil2d/pencil

Segfault with the move tool

--Issue Summary--

Pencil2d crashes with a segmentation fault when clicking on the canvas under certain circumstances.

--Steps to Reproduce--

  1. With a bitmap layer selected, create a new keyframe
  2. Go to the first frame and delete it.
  3. Click on the canvas with the move tool

--System Information--

  • Pencil2D Version: 0.6.0

  • Operating System: macOS 10.13.1

  • RAM Size: 16 GB

--For Code Contributors--

The dispatch queue when the crash occurred was:

BitmapImage::copy(QRect)
BitmapImage::transformed(QRect, QTransform, bool)
ScribbleArea::applyTransformedSelection()
TimeLineCells::mousePressEvent(QMouseEvent*)

closed time in 20 days

scribblemaniac

pull request commentpencil2d/pencil

Checking for nullptr to prevent crash with Ctrl+A and Ctrl+D

This looks fine. There are a couple places where it would be better to run the code that uses the BitmapImage/VectorImage in an if statement it is not a nullptr rather than returning the whole function as it skips over other code. I will fix this and add more fixes for issues similar to the ones fixed here soon. I will merge this for now.

davidlamhauge

comment created time in 20 days

issue commenttobspr/shapez.io

Feature request: Map image export

Tested at it works, thanks!

scribblemaniac

comment created time in 21 days

issue openedtobspr/shapez.io

Feature request: Map image export

I really like to see the designs my buildings make when I zoom out, and I'd like to be able to share that with others too. Taking a screenshot while zoomed out works, but only for an area small enough to fit completely in the window. So it would be nice to have some way to export the entire area that the user has built on as an image (PNG, etc.) like it appears in the zoomed out view except without all of the interface elements.

created time in 22 days

issue openedtobspr/shapez.io

Level Complete message is skipped if you pass multiple levels

If you fulfill the goals for multiple levels at the same time, only the Level Complete dialog for the last goal you fulfilled will be shown. For example if you collect enough squares to complete level 3 before you have enough semicircles to complete level 2, it will completely skip the level two complete message and and the message describing upgrades. As you can imagine, this can cause issues particularly when this happen in the lower levels where these messages are the only way you inform users about new buildings or mechanics.

Tested on version 1.1.11

created time in 22 days

issue commentpencil2d/pencil

0.6.5 release plan

Actually I agree with @Kaikogf, the list isn't very good right now, and translations won't help. The current format is <language_name_in_current_language> (<language_name_in_english>), but I think it would be more useful to have it as <language_name_in_current_language> (<endonym>) where an endonym is the name of the language in its own language (ex: Español, Français, Deutsche, etc.). People should not need to know the name of their language in English or whatever the default language is to find their language in the list.

chchwy

comment created time in a month

issue commentpencil2d/pencil

[ISSUE] The Quick Sizing Tool does not work properly

This has been closed because the quick sizing should work anywhere on the canvas now. However I believe there were still some issues with controlling it in the latest version that I will try to fix at some point (soon hopefully).

Kaikogf

comment created time in a month

push eventscribblemaniac/pencil

Matt Chang

commit sha 60926dbdc8ea3197fe79793f4a2f387956efb516

Fix mac compiler errors

view details

scribblemaniac

commit sha ec3cb53cadde9c37da712f701e56eff9a54ca4c0

Merge pull request #6 from chchwy/scribblemaniac-pre-release-fixes Fix mac compiler errors

view details

push time in a month

push eventscribblemaniac/pencil

mc-csharpclass

commit sha 8907dcfcbe6420bcfb0ebacf11bba4ca72b59c05

added test_colormanager and updated tests.pro to include the new test file

view details

mc-csharpclass

commit sha 28dda58804119ef94edb1478511a13f052e1f512

Merge branch 'master' of https://github.com/pencil2d/pencil

view details

mc-csharpclass

commit sha befddac2337e0a656786fae6b998620135e788d4

added getCurvesColor which returns the color of a specific curve

view details

mc-csharpclass

commit sha 155858441adeb2a470dd5d2b1182df6ce6fabda5

added getCurvesColor which takes an int and returns the int color of that curve.

view details

mc-csharpclass

commit sha 414b6c9084a49eed4d6e93a73625ee51bf8c3a13

updated eyedroppertool to work on vectors.

view details

David Lamhauge

commit sha f9ee57e8ac8c83fc92ef5a21a239c6c5cc923fda

Changed Colour to Color. Filenames and file content

view details

Matt Chang

commit sha fd8b848fbed2924bc58dbe835b92be8d00a5f5b4

Give a better variable name

view details

Matt Chang

commit sha 19ad1c9675466374faf0d7087bb4e822f8e6a268

Refactor

view details

Matt Chang

commit sha fbbb9a29009a8a906797ee030dd57ec28abaf21c

Merge branch 'mc-csharpclass-master'

view details

David Lamhauge

commit sha 3a731ce07176f79cc30aa1a5f3e5629eef7f8848

Secure backward compatibility where needed

view details

David Lamhauge

commit sha e1764013074154b0008ef30378ee7394249c434e

merged master into branch

view details

David Lamhauge

commit sha 4c4ef16ae0d7b7359210dd08ccde5b12647bd6e7

Changed *.ts files to 'colour'

view details

Matt Chang

commit sha 692ef85683959928e2a77c12257be3b23d96e70d

Code cleanup: add comments, remove unused keyword virtual, remove extra spaces.

view details

Matt Chang

commit sha f6173dd91bfa36a8eb60b8891e6def980fc781bd

Missing header file QPainterPath - Build error with Qt 5.15

view details

Matt Chang

commit sha e7dddddbd593cd3edb6e0d2719a0bf4e77c997d5

Merge pull request #1365 from davidlamhauge/changeColourToColor Change: Colour -> Color (Filenames and file content)

view details

Jakob Gahde

commit sha ce30ae18d957c42e5c7b67ca53f9aca47e770bdb

Fix errors, warnings and deprecations from Qt 5.15

view details

Jakob Gahde

commit sha afdf906042f3a4913cf43d81e74ab04fd1ef932e

Remove old code whose functionality is now also provided by Qt

view details

push time in a month

pull request commenthomebrew-ffmpeg/homebrew-ffmpeg

ffmpeg 4.2.3

Still same error. libxext is not part of the Linuxbrew Xorg Provided Formulae.

I would like to point out that libxext is in the list you've linked, and does have a formula in that repo. I'm not sure why it isn't finding and tapping that automatically, that seems like something that linuxbrew should do, but the obvious potential workaround would just be to run brew tap linuxbrew/xorg before installing the formula.

retokromer

comment created time in a month

push eventscribblemaniac/vpaint

scribblemaniac

commit sha 42aa1845ba5cb8b3f981b0ff0087f2292a56ab53

Started svg import functionality Currently only works with the rect tag and certain attributes

view details

scribblemaniac

commit sha a3659c5c173535fa9faad3246ceeb6d6527c6060

Fixed undo action

view details

scribblemaniac

commit sha d01a66d04b475f051f8b2878dbf7fa27fd652e2c

Added opacity attribute support A little bit of buggyness with translucent strokes.

view details

scribblemaniac

commit sha 7cf41878f9e81a8d9bf96c2435ce7169ebd428e1

Factored out presentation elements

view details

scribblemaniac

commit sha e15474ff1e31309224179e9b26b2ff60cb3c4555

Implemented line tag

view details

scribblemaniac

commit sha 2dda80a19fd1701f29c1d1837f2a69a859231533

Implemented polyline tag

view details

scribblemaniac

commit sha 62b004e5082b5ca7f876c70ef617ff540bcc0a6b

Implemented polygon tag

view details

scribblemaniac

commit sha a6253077debb6d8ec9b7558f002da08b8d9ac7b4

Corrected capitalization

view details

scribblemaniac

commit sha 8e593923ac53cd4b951358a3d32f6d810e0ce65e

Implemented circle tag

view details

scribblemaniac

commit sha 91b18a831f155b54952bcea962c483c60f848337

Added copyright headers

view details

scribblemaniac

commit sha 365d6aff1a16f9c47a3c2cee92419dcdc516e2c8

Implemented ellipse tag

view details

scribblemaniac

commit sha b5c30e013e085ffc57a79d693de90c346067f6c8

Added coordinate pair reader for path data and added PotentialPoint class

view details

scribblemaniac

commit sha cfc7bdc360c87d29dd6b699ddb5192a0ef78224d

Added structure for path implementation

view details

scribblemaniac

commit sha eb6e472fb9a17cc9488ca8a7a7dc3fa31cf05b26

Lots of work on the path tag

view details

scribblemaniac

commit sha 0894e43262d99fbd44a5853e2cb52d96a2edf154

Improved ellipse drawing

view details

scribblemaniac

commit sha 4d179d3d2977374fdd4714d949b915c958427c60

Improved circle drawing

view details

scribblemaniac

commit sha 5cbce932fd7f87b24d18ad7ec566b4454e39f3f1

Implemented path curveto

view details

scribblemaniac

commit sha d4c83c79b837e438ad17b5b9ed56fc2932033cbe

Implemented elliptical curves

view details

scribblemaniac

commit sha 5696c58e0276e85a72c1ea468f204224755f1ea6

Began refactoring for the g tag

view details

Boris Dalstein

commit sha e9859feeb2b9437378af4f890fe14850fad7e92c

Fixed typo in COPYRIGHT file

view details

push time in a month

issue commentpencil2d/pencil

Segfault with the move tool

Another solution is to put an empty guard frame at position 0 (The first frame is at position 1) so it will never be null.

This is a bad idea. If some one does manage to modify this frame (ex. keep drawing on previous option), then the users could be left with an unclearable start. Maybe it would onion skin that too. There's not telling how a frame at a position < 1 would save or how it would affect any place where we assume the keyframes start at 1. On the sound layer this would mean having an empty sound keyframe, which also causes issues.

Even if we found a way to guarantee that there is always a frame before the queried frame, the function could still potentially return a null pointer if the keyframe type is wrong (which would cause the static_cast to return nullptr) or it has been added improperly and is actually just a nullptr. Neither of these situations are not particularly likely now, but I could see the former happening when we allow frames to be moved between layers. Having a check for nullptr is good practice in any case.

scribblemaniac

comment created time in a month

issue commentpencil2d/pencil

Segfault with the move tool

I also don't like forcing there to be a frame at the beginning. We have discussed this previously I believe and the consensus was to allow it because we've already fixed multiple bugs related to this, such as the original issue here. If getLastBitmapImageAtFrame can possibly return nullptr (which is likely because it would be difficult to fully guarantee that there is always a frame at the beginning), then we should always be checking for a nullptr, regardless of which approach we take.

scribblemaniac

comment created time in a month

pull request commentpencil2d/pencil

Make onion skin widget scrollable

This is an alright solution for now. Personally I wanted to change the default layout, but I could see that not fixing the issue for everyone. I have not tested this yet, but based on the preview, can you remove the margin between the widget and the scroll area?

CandyFace

comment created time in a month

push eventscribblemaniac/pencil

mc-csharpclass

commit sha 8907dcfcbe6420bcfb0ebacf11bba4ca72b59c05

added test_colormanager and updated tests.pro to include the new test file

view details

mc-csharpclass

commit sha 28dda58804119ef94edb1478511a13f052e1f512

Merge branch 'master' of https://github.com/pencil2d/pencil

view details

mc-csharpclass

commit sha befddac2337e0a656786fae6b998620135e788d4

added getCurvesColor which returns the color of a specific curve

view details

mc-csharpclass

commit sha 155858441adeb2a470dd5d2b1182df6ce6fabda5

added getCurvesColor which takes an int and returns the int color of that curve.

view details

mc-csharpclass

commit sha 414b6c9084a49eed4d6e93a73625ee51bf8c3a13

updated eyedroppertool to work on vectors.

view details

Matt Chang

commit sha fd8b848fbed2924bc58dbe835b92be8d00a5f5b4

Give a better variable name

view details

Matt Chang

commit sha 19ad1c9675466374faf0d7087bb4e822f8e6a268

Refactor

view details

Matt Chang

commit sha fbbb9a29009a8a906797ee030dd57ec28abaf21c

Merge branch 'mc-csharpclass-master'

view details

scribblemaniac

commit sha 1cbd28b851d7b4846f69393c31e48abd74102491

Merge branch 'master' of github.com:pencil2d/pencil into pre-release-fixes

view details

scribblemaniac

commit sha 049b2e6c714c72cdb042a26a14044f749d2d2b3c

Fix curve ordering for vector eyedropper

view details

push time in a month

issue openedpencil2d/pencil

Exported mp4 videos have distorted color

Issue Summary

When exporting to the mp4 format, the resulting video may play back with slightly different colors than in Pencil2D due to differing standards for the RGB <-> YUV conversion.

Actual Results

Rec. 601 appears to always be used for the RGB -> YUV conversion required for the mp4 video format. No metadata is written to the video concerning this. This results in off-color videos when playing back with a player that assumes that Rec. 709 is being used, particularly with HD videos.

Expected Results

Since these standards were designed for television, it is a bit ambiguous how they should be applied to digital videos which don't always have clear divisions between SD, HD, and 4K videos. However the general behavior of video players is to use use Rec. 601 for videos below a certain height, width, or resolution, and Rec. 709 for everything else. Sometimes the version specified in the metadata is used if it is present, sometimes it is not. In VLC, Rec. 709 is use for videos with a height >= 720. Rec. 2020 is never used. So I would expect that we would follow the same rules, and that we would always write the relevant metadata for which standard was used to encode the data.

Steps to reproduce

  1. Change the line strCmd += QString(" -pix_fmt yuv420p"); in movieexporter.cpp to strCmd += QString(" -pix_fmt yuv444p"); then build and run. The issue occurs without doing this, but the test pattern needs this to clearly show the issue.
  2. Open this test project. This contains a chroma test page from: https://obsproject.com/forum/resources/obs-studio-color-space-color-format-color-range-settings-guide-test-charts.442/
  3. Export the test project.
  4. Note two things in the exported video when viewed at 1:1 zoom ratio. First, you should see a dark pink checkmark to the left of 4:4:4, if you do not, make sure you did step 1 correctly. Second, you should notice a pink tint on the "Wrong Decoding Matrix coefficients detection test". the pink tint indicates that the video was encoded with BT.601, but decoded with BT.709.

System Information

  • Pencil2D Version: v0.6.4, fbbb9a2

<!-- WRITE ABOVE THIS LINE ----- hint: You can find the VERSION in Menu->Help->About, e.g., 0.5.4 or Nightly build 02 June 2017 ------ OR BELOW THIS -->

  • Operating System: Ubuntu 20.04

<!-- WRITE ABOVE THIS LINE ----- hint: Windows 10, Mac OS 10.12, Ubuntu 16.04 etc. ------ OR BELOW THIS -->

<hr>

Developer Notes

Writing the metadata with ffmpeg uses the color_primaries, color_trc, and colorspace flags, see this question for examples https://video.stackexchange.com/questions/16840/ffmpeg-explicitly-tag-h-264-as-bt-601-rather-than-leaving-unspecified.

Setting the actual standard used can be set with scale's out_color_matrix option, the colorspace filter, or the colormatrix filter. See https://forum.videohelp.com/threads/395345-ffmpeg-yuv-colorspace-is-BT-601-or-BT-709 and https://trac.ffmpeg.org/wiki/colorspace.

created time in a month

push eventscribblemaniac/pencil

scribblemaniac

commit sha 647d0de3e76e363277728834a2822d32d480b165

Fix crash and incorrect color issues with eyedropper tool I intially was fixing an issue where translucent colors would not be picked correctly, and this was because it was not correctly reversing the premultiply. I did some refactoring along with this because there was lots of duplciated code between updateFrontColor and pointerMoveEvent. When doing this, I noticed that there was no check for getLast*ImageAtFrame returning null, which means that Pencil2D will instantly crash with the eyedropper tool whenever they current frame is before the first keyframe. All these issues have been fixed.

view details

push time in a month

push eventscribblemaniac/pencil

scribblemaniac

commit sha 0f69bb53279dd66e057dad9fe043466b1bf8b345

Add more information to ffmpeg error messages Having the command executed is particularly important so it can be executed separately for testing purposes.

view details

scribblemaniac

commit sha 5eca8a100775d8342b7c01873eb5633588761f6e

Remove the import preview box from the export dialogs

view details

scribblemaniac

commit sha 094a2395681a504d1c82ffc4dc1a9e598b329e67

Fix some operations which ignored the draw on empty frame preference Specifically modified the select/move tools, cut, paste, and delete selection actions.

view details

push time in a month

push eventscribblemaniac/pencil

scribblemaniac

commit sha bfda42fc5c2b2bd6b6e93e0da480696f34f048b5

Move quick size handling to the tools In addition to be being a more logical location for this code, it also allows for more customization of the quick sizing to each tools specific needs. For example, the bucket tool uses it for adjusting the fill expansion, but that only applies to the vector layer so it should not be active when using the bitmap layer. The pencil tool has a feather property, but it can't be changed, so quick sizing should not be enabled for that. Fixes #1186

view details

push time in a month

push eventscribblemaniac/pencil

scribblemaniac

commit sha 701dd95f035c0e4359a160ef0162e2a63754f355

Add possible workaround for #1017

view details

push time in a month

push eventscribblemaniac/pencil

scribblemaniac

commit sha ee8248944e738ebe9c358523461f093836766eae

Improve center overlay rendering Depending on the zoom level, the center overlay sometimes would not show lines right in the center, or would only show half of the lines because it is dashed. By drawing four lines from the center instead of two through the center, it seems there will always be lines at the center, even when zoomed out or in.

view details

scribblemaniac

commit sha 6bd0fb72bdfec9cd9824858ae347fd94be1d5262

Disable selection actions in menu when there is no selection Also removed updateCurrentFrame in a few places because it will be triggered by selectionChanged.

view details

scribblemaniac

commit sha 1b8a7347130ee29fa66f0381815468130ece4b7e

Change default project color I've always hated this crap brown color on startup. Black is a much more practical color and matches with the initial vector layer color.

view details

scribblemaniac

commit sha 5c4730681519dfd1b33bc4a604f3bf95b40d1f8a

Fix many preset issues There were issues with not using the default preset when opening. There were issues with the window title and save state not being reset. There were probably other issues. Mostly from 7992c8f.

view details

push time in a month

push eventscribblemaniac/pencil

scribblemaniac

commit sha 8ac0e514441bc8d3dfc6c655226f93895cb7d40f

Round selection to the nearest pixel when on the bitmap layer This was fixed and then reintroduced by #1223. All points of a selection need to be a whole number right now. Otherwise you have borders drawn ambiguously between pixels, and obscure issues when the values are rounded differently. For instance, flipping a selection and then moving it could in some circumstances leave behind a row/column of pixels.

view details

push time in a month

push eventscribblemaniac/pencil

scribblemaniac

commit sha 908388e0f9ec34195d8fca2a2b474b23778797bb

Allow new selection to be created by clicking and dragging outside of an existing selection

view details

push time in a month

push eventscribblemaniac/pencil

scribblemaniac

commit sha 66616c481ab907db7689e8684caddb1d75f85ff8

Remove multilayer onion skin action from menu Having a multilayer onion skin setting would be good, but we don't have that feature right now, so this action does nothing. Even if we did have this feature, the menu isn't the best place for this setting.

view details

scribblemaniac

commit sha d9760f56b90496346f6edfb751ddc096ac4f4987

Fix Recent File list wipe issue The recent file list was being wiped on startup because we are now opening a project on startup (templates) which saves an empty recent file list before the old one can be loaded. Additionally, it was saving every time it clears the list, which is not a good idea since that can be used internally before making other changes.

view details

push time in a month

PR opened pencil2d/pencil

[WIP] Pre release fixes bug

During testing of the latest version, I found many, many previously unknown issues, and there are still many known issues. This PR is to address as many of the "low-hanging fruit" before the next release. I will continue to add things to this for probably the next few days and I will remove the WIP when this is ready to merge. See commit messages for a list of changes.

+37 -42

0 comment

7 changed files

pr created time in a month

push eventscribblemaniac/pencil2d.github.io

Morr

commit sha 0eb3c710d31c750816e31a4c43b70e98c8b168d3

Hacktoberfest 2019 start - alt guide - Removed redundant hacktoberfest intro text and left that for the dedicated page - Re-organized the getting started section of this guide

view details

Morr

commit sha e3645b0abb02000f7c77ab1313a72b8362bfb199

Hacktoberfest 2019 start - dev guide - Removed redundant hacktoberfest intro text and left that for the dedicated page - Re-organized the getting started section of this guide

view details

Morr

commit sha 90f2d1ed6c43cef6ad83a3567d741a9bf851139e

Hacktoberfest 2019 start - news article - This commit is for publishing the post. - Added a link to the hacktober fest inner site - fixed missing hyperlink to digital ocean's FAQ site.

view details

Morr

commit sha 53ff360b8eade4ba738c66d787a283cdb87c13af

Hacktoberfest 2019 start - landing page - Added intro from contribution guides which had specific links to digital ocean's sites and an organized description.

view details

Morr

commit sha 49e107b91f6e6734b003b0a215ecb7d7a9dc85cf

minor fix - forgot to update the guide links as they were looking inline and did not properly conveyed that were different links so added them to their own list point.

view details

Morr

commit sha 20bdbbf986b1698154f41c8b7d8e05bec707bbd3

minor page update - Added David Lamhauge's recent video tutorial series playlist

view details

Matt Chang

commit sha 4ad178e66a5dc2327dd34271972e53008c73474f

Update 2019-05-31-pencil2d-0.6.4-release.md

view details

Matt Chang

commit sha b5d01325d789954ed2c786497ca940c80e2907b3

Update index.md

view details

Matt Chang

commit sha 9bff6fe6f6f476758919f75316902044d313d4cb

Update index.md

view details

Matt Chang

commit sha a3d8ee4e81eac23d7877a4dfaebe23ce24d57c40

Update index.md

view details

Matt Chang

commit sha 722236c72da7a3b5d1912ed0df63d529c63c994d

Update index.md

view details

Matt Chang

commit sha 4008ca97d99828d4a62530eff9915b4f0292afcb

Update index.md

view details

Matt Chang

commit sha adf0c7ef8279aee66eb11e40c89a499d954530f1

Update index.md

view details

Matt Chang

commit sha f114c8b5974963dfb5aa5d78691aaa842d55e868

Update index.md

view details

Jakob Gahde

commit sha 9fe51b794cc8e89a7f61cfd617bad139ea1fde2a

Fix invalid HTML (typo) on the downloads page

view details

Matt Chang

commit sha ef9064ce91762b7983df4eaad504203b486fb5de

Update download page

view details

Jakob Gahde

commit sha 286c0d9e1a7b3b226efea2b0aedd6a79e94f006e

Add screenshot for Linux appdata

view details

Jakob Gahde

commit sha 28680e094a62201677b954c57aee820c9b1734f0

Ignore Jekyll cache

view details

push time in a month

push eventscribblemaniac/pencil

Peter Eszlari

commit sha 23472e903505d3650e3c52f9ac5006030996c869

Linux: add metainfo

view details

mc-csharpclass

commit sha 88e75801a8d05f3bf6445d0fe180b0467de26b86

added invalide sound frame test

view details

Jakob Gahde

commit sha 2460048e2e5aade1950c8e6bc7137ae686bc8fd3

Use Linux screenshot in metainfo

view details

Jakob Gahde

commit sha c36563985717a3ae0af750d1e1222006df65c11d

Merge pull request #1035 from eszlari/appdata add linux appdata

view details

Jakob Gahde

commit sha c48163025d27d0d241eb43e79082b1eff38c87dd

Apply MIME package tweaks and fixes

view details

Jakob Gahde

commit sha f350fc7c9b3dfcb2acbd051a751cfb045f74d64a

Use reverse DNS naming for desktop entry, MIME package and icon (for FlatPak)

view details

Jakob Gahde

commit sha 396be522c10d2b57b1728261a4c62592276afab3

Enhance AppStream metadata

view details

mc-csharpclass

commit sha a7d510621652386e57e95223d34e2dba218f7f12

added test_colormanager and updated tests.pro to include the new test file

view details

Matt Chang

commit sha f535aa719862c9368242b40b7269d2a69e3603e1

Add precompile headers to app.pro & core_lib.pro

view details

Matt Chang

commit sha 3581e675e157841b43783c4efb32f9c8c896bc53

Reduce unnecessary header includes

view details

Matt Chang

commit sha fe03132ea649510f635bd2f4616b96298acc5936

Fix compilation errors

view details

Matt Chang

commit sha 1dd3dadb449f10ee828d1a686538c49497a036ff

Add a missing header for macOS

view details

Matt Chang

commit sha 70d7b22485ef8f54898904cf585e6362644c3617

lupdate: update the source language

view details

Jakob Gahde

commit sha 1fb472d2b4cf4b611a9a0e04ec3b42bbbbe9c88d

Make shortcut names translatable

view details

Jakob Gahde

commit sha 4966f57f471f92f36dc268dde7e4cab5ed0535bb

Fix typos in ShortcutsPage

view details

Matt Chang

commit sha 9668850227b25e2e412c2de9661554e71d90d2f7

Use defined Macro as the hash key. Add translation help strings.

view details

Matt Chang

commit sha 9b7ac636307705a4eb8712995d71156eab902b7b

lupdate: update the source language

view details

scribblemaniac

commit sha 305b26f6ce28eb663f9ade9fd9edf7d21051601a

Merge branch 'master' of github.com:scribblemaniac/pencil into pre-release-fixes

view details

push time in a month

push eventscribblemaniac/pencil

Peter Eszlari

commit sha 23472e903505d3650e3c52f9ac5006030996c869

Linux: add metainfo

view details

mc-csharpclass

commit sha 88e75801a8d05f3bf6445d0fe180b0467de26b86

added invalide sound frame test

view details

Jakob Gahde

commit sha 2460048e2e5aade1950c8e6bc7137ae686bc8fd3

Use Linux screenshot in metainfo

view details

Jakob Gahde

commit sha c36563985717a3ae0af750d1e1222006df65c11d

Merge pull request #1035 from eszlari/appdata add linux appdata

view details

Jakob Gahde

commit sha c48163025d27d0d241eb43e79082b1eff38c87dd

Apply MIME package tweaks and fixes

view details

Jakob Gahde

commit sha f350fc7c9b3dfcb2acbd051a751cfb045f74d64a

Use reverse DNS naming for desktop entry, MIME package and icon (for FlatPak)

view details

Jakob Gahde

commit sha 396be522c10d2b57b1728261a4c62592276afab3

Enhance AppStream metadata

view details

mc-csharpclass

commit sha a7d510621652386e57e95223d34e2dba218f7f12

added test_colormanager and updated tests.pro to include the new test file

view details

Matt Chang

commit sha f535aa719862c9368242b40b7269d2a69e3603e1

Add precompile headers to app.pro & core_lib.pro

view details

Matt Chang

commit sha 3581e675e157841b43783c4efb32f9c8c896bc53

Reduce unnecessary header includes

view details

Matt Chang

commit sha fe03132ea649510f635bd2f4616b96298acc5936

Fix compilation errors

view details

Matt Chang

commit sha 1dd3dadb449f10ee828d1a686538c49497a036ff

Add a missing header for macOS

view details

Matt Chang

commit sha 70d7b22485ef8f54898904cf585e6362644c3617

lupdate: update the source language

view details

Jakob Gahde

commit sha 1fb472d2b4cf4b611a9a0e04ec3b42bbbbe9c88d

Make shortcut names translatable

view details

Jakob Gahde

commit sha 4966f57f471f92f36dc268dde7e4cab5ed0535bb

Fix typos in ShortcutsPage

view details

Matt Chang

commit sha 9668850227b25e2e412c2de9661554e71d90d2f7

Use defined Macro as the hash key. Add translation help strings.

view details

Matt Chang

commit sha 9b7ac636307705a4eb8712995d71156eab902b7b

lupdate: update the source language

view details

push time in a month

push eventscribblemaniac/pencil

scribblemaniac

commit sha 8283e027b950afbbbef02cfe3745bb7683b98d47

Change zoom slider focus policy I believe the default focus policy for QSlider is StrongFocus, but the focus when clicking behavior means that it will often block shortcuts from working after performing certain actions.

view details

push time in a month

issue commentpencil2d/pencil

I'm interested in redesigning all icons in the software

I also haven't been keeping up with this fully. I will try to go through some of the comments I have here, but I probably won't be exhaustive the first time around, there is a lot to comment on in no particular order.

First off I'd like to thank you for your hard work so far. I was very skeptical of this in the beginning, and I still have my reservations, but now that I see it all coming together it is looking better.

Preferences Timeline

I like the preferences timeline icon, but I think that the red scrubber should be translucent like in the real timeline, and it should line up with the tick marks to avoid being OCD-triggering :wink:.

Before After
preferences-timelines preferences-timelines-new

preferences-timelines.zip

Preferences Tools

As previously noted, the hammer looks out of place. I think the issue here is mainly with the proportions. The handle is too thin and the head is too large. Also there is a lot more whitespace at the top. I think it might also look better if the full thing is visible and angled like the preferences pencil.

Preferences Pencil & Pencil Tool

I mostly like the pencil icon but there are two issues I have with it. First is the highlight on the lead. At larger sizes it looks fine, but at very small sizes like in the toolbox, it causes it to look a little deformed. I see it as something more like this:

pencil

Not entirely sure why this is, but I'm sure it can be improved with some slight tweaks to that highlight.

The second issue I have with the pencil icon in the yellow part. Every yellow pencil I have ever seen has been hexagonal, but this icon makes it looks very cylindrical. I think just expanding the highlight and shadow you already have would be good enough, and maybe making the lower border a bit flatter would also be good, maybe not:

pencil

If you pay attention to how pencils actually look, the border should look something like this:

pencil

But this is probably too realistic for the look you are going for.

Clear Tool

I was fine with the recycling bin, and I don't mind your paper peeling either. I get it. I did not like the red X though as that represents a close action to me, and I wouldn't even want to try to press it if it might just quit the program or something like that.

Move Tool

I think the the current icon you have for the move tool is a perfectly fine arrow, and it is in line with the existing icon, however I do not think it is very good for a move tool. The purpose of the move tool is to move, scale, and rotate a selection, so it really acts as a "unified transformation tool" which we should make a better effort to convey. Something like the arrow-select-move icon could be a good starting point.

Hand Tool

I agree with CandyFace's criticism of the open hand. Even it it's not fully open, it does not look right. the fingers should be spread some. When you look at typical OS open hand icons, they have the same finger spread, especially the thumb (like the icons from older versions of Pencil2D Jose pointed out). Take a moment to put a piece of paper on your desk and try to grab it. If your fingers are all tight up against each other, curled up in a hook, with your thumb bent inwards, you may need to seek medical attention :laughing:

Brush Tool

The brush tool is good, but the bristles feel too detailed next to the other tool icons. Maybe fewer, thicker lines would be better:

Before After
brush brush

brush.zip

Polyline Tool

Personally I like Jose's approach to this with the original shape and the control points. The biggest issue I have with the current shape is that it resembles the Cyrillic character "И" and thus could have different interpretations in other languages. For instance in Russian that means "and". This is not to mention that it could be mistaken for a text tool both in languages that have that character and in other languages with the very similar "N" character.

Smudge Tool

I'm still not sure how I feel about that hand, so I won't comment on it for now. What I will comment on is the smudge underneath the finger. I think that's a really good idea, but it should be made more horizontal so that it does not look like just a shadow of the hand.

Layer Icons

The designs are alright for the layer icons, in fact I really like the bitmap layer icon. Maybe the sound layer icon could be squished to the left a bit to make room for a "sound wave" coming out of it like most typical sound icons. Something like this:

layer-sound-2

I mostly have issues with the colors used. The gray on gray of the sound and camera layers aren't as hard to see as I was expecting because of the gradients, but I think brighter color would be easier to see, especially given how small they are. I'll discuss this further in the Color Palette section.

Timeline Sound

The timeline sound icon is alright, the red slash when it is off is very clear, however maybe we could add some sound waves when it is on similar to my sound layer icon proposal.

The sound scrubbing icon was bad before, and is still bad. When it's off, your icon is basically indistinguishable from the sound icon, and when it's on, the red line, which I assume is supposed to be the scrubber, looks more like it's crossing off the icon like the disabled sound icon. I don't have a good idea to solve the issue, but I'm also not a designer. Maybe use horizontal arrows to suggest the scrubbing action:

soundscrub-new

Jump to Start/End Control

Your icons are just like the old ones, which is normally alright. But now that I really look at these icons and what they are supposed to do, I think we have them backwards. In the video players I've seen that have these buttons, the triangle points towards the vertical line, which I interpret as moving (denoted by the arrow) towards the beginning/end (denoted by the line). Here are a couple different ways they could look:

endplay-1

endplay-3

endplay-2 (this one I usually associate with skipping to the beginning of the next track/video because of the double arrow)

Loop Control

Same as the jump to start/end controls, your icon is a true to the original, but has some room for improvement. Right now it looks like more of a "return" than a "loop" icon. I think maybe it should go completely back to the beginning, something like this:

loop

loop.zip

Duplicate Key

This icon is fine, there isn't really to much to it after all. However at the size it is in the timeline, the border of the two keys starts to blend into each other. If they could be separated a bit that would be good, even if that means the the frames need to be shrunk slightly for that icon.

Color Palette More Options

I don't like the icon for more options in the color palette widget at all. It looks like it would make my colors grayscale or something like that, especially when in the list view. The original icon was a hamburger icon, but this no longer resembles that or anything else particularly useful.

We could go back to the old design, but there is probably a better way to represent what it does. Basically it opens a menu for color palette view options, so maybe a small settings cog?

Another option which is my personal favourite would be to break it up into two separate buttons. One would be a layout button which would toggle between a grid icon and a list icon, and the second would be to change the swatch size and could be a magnifying glass.

Onion Skin Previous/Next On/Off

It would be nice to come up with a better way of representing this. It was difficult to tell before which one is onion skinning for the previous frame and which one is for the next frame, and your recolored versions do not make that any clearer to me. I currently have no ideas for this.

Display Overlays

The line thickness of the cross should be the same as it is in the other icons.

Display Flip X/Y

It doesn't make sense to have the white parts of these outlined but the the same parts in the display overlay icons. It should be one or the other, probably no outline since the outline would be hard to do on the safe area button.

As CandyFace said, these are only for flipping the view, which can lead to the occasional confused user. We should think about if there there is some way to represent the temporary nature of this better.

Invisible Lines and Outlines Only

There has been some good discussion about this already. I actually don't mind having invisible lines associated with the pencil tool because we really should only allow them to be drawn with that. However, the current iteration is superior to those old designs in my opinion.

<hr>

That is all the comments I have about specific existing icons so far. Now I want to talk about some more general things related to these design changes.

Perspective

In the angled icons (pencil, eraser, pen, bucket, eyedropper, brush, and smudge tool) there is a really inconsistent use of perspective and I think as a whole the toolbox would benefit from making these more similar.

  • The bucket and pencil appear to have the bottom of the object closer to the user than the top. You can see this on the pencil the upward curve of the border between the lead and the wood and the wood and the yellow paint. On the bucket it's clear because you can see inside the bucket and the closer edge again curves upwards.
  • The eraser, pen, eyedropper, and brush tools all have straight edges with no undersides which makes it look like they are parallel to the screen.
  • The smudge tool looks it's being viewed from above with the way that we see the smudge.

The pencil and bucket tool would probably look weird straight on, so I'm inclined to say that the other icons should be viewed in the same way as them. Here's just an example of what the eyedropper might look like this way:

eyedropper

States

Here is an idea for improving upon this design. You don't need to strictly follow the way icons are currently used in Pencil2D, new ones can be added and old ones can be removed. I personally think it would be nice in some situations to use custom button icons for each button state. For toggle buttons, that usually consists of a normal on and off state, a select on and off state (when the element has focus), and a disabled on and off state (which is usually generated automatically as a grayscale version. In particular, I think the split display icons would benefit from this because it is not clear if, for example, the invisible lines are shown when the button is down or up. You could highlight one half to show that it is the currently active option, or make it inset/outset. It would make sense to do a similar state change for the other display options for the sake of consistency. I don't see many other places where this would be useful, but maybe you do. Something to think about.

Color Palette

Now I've come to perhaps the perhaps the most important part to me, the color palette. I'm not talking about the widget, I am talking about the colors you are choosing to make all of these icons. It's kind of all over the place right now. If there is some logic behind your color choices, I'd like to hear it, but I'm not seeing it.

When looking at the program overall, I see many places with related icons that should use related color schemes. The timeline layer colors are fixed, so that's a good place to start. Make the camera layer icon yellow, sound icon red, bitmap layer blue (which it mostly is already), and vector icon green. Then use those colors for anything that is exclusive to one of those layers. The display vector icons are already green which is great, but the other ones should probably be yellow since they are based on the camera location and dimensions. Moving away from the layer types, the key icons and the onion skin "current frame" should be the same, the controls should probably be the same (ex. why are the playback and loop buttons different?).

I think limiting the number of colors used in the tool box would be good, maybe something like this: toolbox-screenshot I went with blue and yellow because the pencil kind of has to be yellow and blue is it's complementary color. I'm not great with picking colors. I'm not a fan of the magenta-pink that you are using for some of the icons now. I find it very bright and a bit distracting. Following from the discussion above, maybe there could be different colors for different categories of tools (ex. drawing tools, other modifying tools, non-modifying tools) but in this case it's a little harder to to do something like that since creating recognizable symbols should be the top priority, while coloring is secondary.

Finally, whatever design/coloring you go with, it would be nice to have some documentation of the palette, how they're used, etc. to help guide future designs.

Other Icons

I was looking into redesigning the icons in the menu bar but is it really necessary to even have icons in there?

Since nobody answered this directly, I will. The menu icons are very important. It's true that not many applications have them, and maybe they could be removed, but they are still important because they may be used in the future. For example we have an operations widget in the works which will use some of these icons for sure, and although this has not been discussed yet, it may have support for adding other actions eventually too: see #1289.

That leads me to my next point. Just because something in the menu doesn't have an icon currently, doesn't mean it shouldn't have one. Basically any action should have an icon if we want to eventually incorporate that into the operations widget.

As David pointed out, there are also icons needed for pending pull requests (#1352 and others) and eventually there will be a need for new icons for other new features, the timeline rewrite, etc. You should at least give these some thought, and you're welcome to work on them as well if you want to.

Other Notes

Before these are merged, the svgs need to be cleaned up. I have noticed that many of them have content outside of the view box). I understand why this is helpful from a design perspective, but it makes unnecessary work for the icon renderer and bloats the file. If you want to keep them around for design purposes, then perhaps we can have two versions, a design version and an optimized version with only the latter being used in the program.

@chchwy

It was a crumpled paper.

This whole time I thought it was smoke like what appears when you remove an app from the Dock on mac :eyes: (https://www.youtube.com/watch?v=aXeVNl-ud-0)

If not, can we get this merged? I don't want this endeavour to get stretched out like what @davidlamhauge said earlier in this issue.

Settle in, because this isn't going to happen overnight. I appreciate your enthusiasm and how fast you've been working on this. However changing the design of most of an app is an involved process and not something to be taken lightly. It will take time for our team to work through this and iterate until we're all completely happy with the result. Testing has to be done to make sure everything still works properly. On top of all of that, we have other things to do, obviously in real life, but also as part of the project. We are currently working on making a new release, and getting that ready will be our top priority in the short-term, not this. There are lots of things to work through still, and lots of things that are already good which I have not mentioned because this post is already too long. So be patient, work with us, and I'm sure we'll be able make Pencil2D look amazing :slightly_smiling_face:

Fatih20

comment created time in a month

create barnchscribblemaniac/pencil

branch : pre-release-fixes

created branch time in a month

GollumEvent
GollumEvent

issue commentpencil2d/pencil

File open dialog appears behind application window

@J5lx I agree with your assesment that this is caused by the linked issue. However, there may be a way we can work around it. I was thinking that something like this would work:

In FileDialog::openFile, replace the call to QFileDialog::getOpenFileName with something like this:

QFileDialog openDialog( mRoot, strTitle, strInitialFilePath, strFilter );
 openDialog.open();
 QApplication::setActiveWindow(openDialog.window());

Obviously there will be a bit more to it than that as we will have to connect to the signal to get the result wherever that is used, but that is probably a better thing to do anyway.

Unfortunately (or maybe fortunately), I am unable to reproduce this issue with the flatpak version on Ubuntu 20.04, so I am unable to test if the above code would fix the issue. Can you maybe try this?

scribblemaniac

comment created time in a month

create barnchscribblemaniac/pencil

branch : flatpak-test

created branch time in a month

issue commentpencil2d/pencil

0.6.5 release plan

@eszlari Thanks for the reminder, it has been added to the release checklist.

chchwy

comment created time in a month

GollumEvent

issue commentpencil2d/pencil

I'm interested in redesigning all icons in the software

Also, I've redesigned the error icons but I don't know how to trigger the error dialog to test how it would look.

A simple way to trigger the error dialog is to follow these steps:

  1. Open a project in Pencil2D.
  2. Rename that project on your file system.
  3. Try to open the file again from the recent files dialog.

You can trigger the warning dialog easily by trying to draw on a hidden layer.

Fatih20

comment created time in a month

issue commentpencil2d/pencil

I'm interested in redesigning all icons in the software

Can you give me a directory of each of those files?

Just search for the filename in github and it will show all the places in the code where that resource is used.

I second what @CandyFace has said that you should be posting updates here and discussing things with the rest of the team. Development nor design happen in isolation.

Also, while I agree with your desire for more consistent design principles, I do not believe that the toolbox icons are the problem. Quite frankly they are by far the best icons we have, and it is things like the timeline, menu, and display icons which I would be interested in seeing improved to match the tool icons.

Yet another thing. So you are aware, any SVGs you make for this should conform to the SVG Tiny specification with no dynamic features (ECMA scripts/DOM manipulation) as that is all that the framework we use supports.

Fatih20

comment created time in a month

issue commentpencil2d/pencil

exporting doesn't get the audio out

@SamuzMBlast Any update on this?

SamuzMBlast

comment created time in a month

push eventpencil2d/pencil

scribblemaniac

commit sha a360997783e18af3e7c7c3d11e9aa838d52a8aa1

Escape audio output path This shouldn't be necessary as long as there are no spaces in the path to the temporary directory, but better safe than sorry.

view details

push time in 2 months

push eventscribblemaniac/pencil

scribblemaniac

commit sha a360997783e18af3e7c7c3d11e9aa838d52a8aa1

Escape audio output path This shouldn't be necessary as long as there are no spaces in the path to the temporary directory, but better safe than sorry.

view details

push time in 2 months

issue commentpencil2d/pencil

exporting doesn't get the audio out

Can you try removing accented characters from your project file name? Ie. MinhaAnimação.pclx -> MinhaAnimacao.pclx

SamuzMBlast

comment created time in 2 months

issue commentpencil2d/pencil

exporting doesn't get the audio out

Alright thanks. That narrows the issue down a bit.

SamuzMBlast

comment created time in 2 months

issue commentpencil2d/pencil

exporting doesn't get the audio out

I understand. I have made a video showing the process which you should be able to follow along much more easily:

https://youtu.be/m6yoQbLltZw

Notes:

  • Do not press either button in the "Finished. Open movie now?" dialog, until you are done testing.
  • The folder Pencil2D-CcOxej will have different letters at the end for you.

There is one main question I am looking for an answer to:

Is there a file named tmpaudio or tmpaudio.wav like in the video? If your answer is yes, please upload that file here.

SamuzMBlast

comment created time in 2 months

CommitCommentEvent

push eventpencil2d/pencil

scribblemaniac

commit sha 3fd0126a5423d617584b35f3eaf2fc767646c060

Make unknown export dialog translatable

view details

push time in 2 months

push eventscribblemaniac/pencil

Matt Chang

commit sha 0b1094c159b489422194924de9963a77e63b2aac

Sync translations from Transifex

view details

Matt Chang

commit sha b86b904d3e5b3fa92cc72036ddea90b4892cd613

lupdate: update the source language

view details

Matt Chang

commit sha fd64cdd5432601d746fb39000dfa0fc05f10b827

lrelease: generating qm files

view details

CandyFace

commit sha 616617bef6d6dd0b5ba15fdef3df40aca473421e

Fix mac compilation error

view details

scribblemaniac

commit sha 6309bb33fde05c302681971470876da4e36378e9

Add an action to open Pencil2D's temporary directory

view details

scribblemaniac

commit sha c13aa624ea52bf6cabcaa891db0855a1f41c9cfd

Merge pull request #1351 from scribblemaniac/the-button Add an action to open Pencil2D's temporary directory

view details

scribblemaniac

commit sha 3fd0126a5423d617584b35f3eaf2fc767646c060

Make unknown export dialog translatable

view details

push time in 2 months

delete branch scribblemaniac/pencil

delete branch : the-button

delete time in 2 months

push eventpencil2d/pencil

scribblemaniac

commit sha 6309bb33fde05c302681971470876da4e36378e9

Add an action to open Pencil2D's temporary directory

view details

scribblemaniac

commit sha c13aa624ea52bf6cabcaa891db0855a1f41c9cfd

Merge pull request #1351 from scribblemaniac/the-button Add an action to open Pencil2D's temporary directory

view details

push time in 2 months

PR merged pencil2d/pencil

Add an action to open Pencil2D's temporary directory request: enhancement ux

Implemented as discussed. It is an action in the Help menu, and when clicked, it produces a warning message before opening the user directory. Works on Ubuntu, should be tested on other platforms.

+22 -4

4 comments

4 changed files

scribblemaniac

pr closed time in 2 months

push eventscribblemaniac/pencil

scribblemaniac

commit sha 6309bb33fde05c302681971470876da4e36378e9

Add an action to open Pencil2D's temporary directory

view details

push time in 2 months

pull request commentpencil2d/pencil

Add an action to open Pencil2D's temporary directory

The qDebug statement was left in unintentionally. It has been fixed now.

@CandyFace Summed it up fine. There's not really much to this, it's an action that takes you to the temporary directory. This will simplify providing support to users who want to try and recover their project after a crash. This has previously been particularly difficult on macOS where the directory is different for everyone, but even Windows users had difficulty navigating to a hidden directory. It was extensively discussed in #feature-requests so if you have some complaint about it, it has probably already been complained about.

scribblemaniac

comment created time in 2 months

CommitCommentEvent

PR opened pencil2d/pencil

Reviewers
Add an action to open Pencil2D's temporary directory request: enhancement ux

Implemented as discussed. It is an action in the Help menu, and when clicked, it produces a warning message before opening the user directory. Works on Ubuntu, should be tested on other platforms.

+22 -4

0 comment

4 changed files

pr created time in 2 months

create barnchscribblemaniac/pencil

branch : the-button

created branch time in 2 months

issue commentpencil2d/pencil

exporting doesn't get the audio out

@SamuzMBlast Okay I have something for you to do to narrow down where the issue is occurring:

  1. Follow steps 1, 2, 3, and 4 under "RECOVERY STEPS" here: https://discuss.pencil2d.org/t/pencil2d-project-file-corruption-prevention-partial-recovery-guide/3105. You should now have the temporary directory where you can see a Pencil2D directory, however do not open the Pencil2D directory.
  2. Start the Pencil2D application (the development build you used earlier is fine) and open your project.
  3. Export the project like you normally would.
  4. When the export completes and it asks if you want to open the video now, do not press any of the options. Instead, go to the temporary directory you opened up earlier and there should be a new folder with a name that starts with "Pencil2D-" followed by a bunch or random characters. Open that up.
  5. Tell me if you see a file named "tmpaudio.wav".
  6. If there is a tmpaudio.wav file, play it and tell me if it has the sound from your animation. Also please upload it here.
  7. You can close the dialog when you are done. The directory will be automatically deleted when you do this.
SamuzMBlast

comment created time in 2 months

issue commentpencil2d/pencil

exporting doesn't get the audio out

Unfortunately, if that is the dialog which comes up, then my changes won't make any difference. Let me think about this for a bit and I'll let you know when I think of something else you can test. Thank you for your help so far. We're close to making a new release, and it would be wonderful if we can figure out what is causing this issue for some people and fix it before that release. It has been hard to test however since none of our team have been able to reproduce this.

SamuzMBlast

comment created time in 2 months

push eventpencil2d/pencil

scribblemaniac

commit sha 987929ed6abd9f737ced44d90414ec436723f25a

Display error dialog when non-ok status is returned by movie export

view details

push time in 2 months

push eventscribblemaniac/pencil

Jakob Gahde

commit sha 2222b25e0591b2c4460b8ed355c479567a335523

Add install support for other Unixes. Fixes #1127

view details

Jakob Gahde

commit sha 5a591897e1c9f2f6f2d27bbf2210c33e54c40f9f

Merge pull request #1347 from J5lx/install-other Add install support for other Unixes

view details

scribblemaniac

commit sha 987929ed6abd9f737ced44d90414ec436723f25a

Display error dialog when non-ok status is returned by movie export

view details

push time in 2 months

push eventscribblemaniac/pencil

scribblemaniac

commit sha efa3e5b7734f76fcf37601091cc4f9079eb0ee4b

Display error dialog when non-ok status is returned by movie export

view details

push time in 2 months

issue commentpencil2d/pencil

exporting doesn't get the audio out

@SamuzMBlast With the development build, when the export completes, are you seeing an error dialog, are you seeing a dialog asking you if you want to open the video now, or are you seeing no dialog?

SamuzMBlast

comment created time in 2 months

issue commentpencil2d/pencil

exporting doesn't get the audio out

@SamuzMBlast Please try restarting Pencil2D and then exporting again. If that fails, you can try using the latest nightly build available by scrolling down on our downloads page. It might work right away, or you may have to reimport any sounds that came from mp3 files.

SamuzMBlast

comment created time in 2 months

issue commentpencil2d/pencil

Selection tool resets camera frame visually when zooming

Please try to reproduce this issue with the latest code. I suspect it has been fixed.

Jose-Moreno

comment created time in 2 months

push eventpencil2d/pencil

scribblemaniac

commit sha 97963e80231ee3ccb1b37e3e4577fb59c9619f97

Invalidate canvas painter cache when view changes Fixes #1329 and probably more

view details

push time in 2 months

issue closedpencil2d/pencil

View not updating correctly when changed while the polyline tool is active

Issue Summary

When in the middle of drawing something with the polyline tool, if you move the view with the space, middle mouse button, right mouse button, or rotating shortcuts the view stops updating correctly.

Actual Results

When moving the view with the space, shortcuts, or middle mouse buttons, after releasing, only the current layer remains in the correct position, the remaining layers snap back to their previous position until the polyline drawing is complete, after which they snap to the correct position. If the view is changed with the right mouse button, the view updates correctly, but the current stroke of the polyline no longer updates until it is set.

Expected Results

The view should update the exact same whether the polyline is drawing or not.

Steps to reproduce

  1. Start a new file or open a file with existing content.
  2. Begin drawing with the polyline tool.
  3. Change the view using one of the methods mentioned above.
  4. Observe how the border moves.

System Information

  • Pencil2D Version: Nightly Build 2020-03-30_13:30:35 AppImage (d1add7b12ad464ede3e6e303d98a65db9a5edb41)

  • Operating System: Ubuntu 19.10

  • RAM Size: 16 GB

  • Graphics Tablet: N/A

Developer Notes

This could possibly be caused by recent changes to the frame caching in #1267.

closed time in 2 months

scribblemaniac

push eventscribblemaniac/pencil

scribblemaniac

commit sha 97963e80231ee3ccb1b37e3e4577fb59c9619f97

Invalidate canvas painter cache when view changes Fixes #1329 and probably more

view details

push time in 2 months

issue closedpencil2d/pencil

Pencil 2D save problem

There is the problem :

FileManager::save strFileName = /Users/mael/Desktop/Animation panéte.pclx strTempWorkingFolder = /var/folders/yx/6_wc8ldd3fg3j1fxlb8c031m0000gp/T/Pencil2D/Animation panéte.Y2xD/ layerCount = 3 layer[0] = Layer[id=1, name=Calque caméra, type=5] layer[1] = Layer[id=2, name=Calque vecteur, type=2] layer[2] = Layer[id=3, name=Calque image, type=1]

Error Display Title: Erreur interne Description: Une erreur interne a eu lieu. Votre fichier peut ne pas être enregistré avec succès.

System Info Pencil version: 0.6.1.1 Build ABI: x86_64-little_endian-lp64 Kernel: darwin 14.5.0 Product name: OS X Yosemite (10.10)

closed time in 2 months

mael-ui

issue commentpencil2d/pencil

Pencil 2D save problem

Given how old the version of Pencil2D was that this occurred on and that we haven't had any other reports like this, I'm going to close this. Please create a new issue if this is still an issue with the updated version.

mael-ui

comment created time in 2 months

push eventpencil2d/pencil

scribblemaniac

commit sha bbdecb9b358c30e0962abf327436cb31271abaed

Make code compatible with Qt 5.6 again

view details

push time in 2 months

push eventscribblemaniac/pencil

scribblemaniac

commit sha bbdecb9b358c30e0962abf327436cb31271abaed

Make code compatible with Qt 5.6 again

view details

push time in 2 months

push eventscribblemaniac/pencil

scribblemaniac

commit sha 789d7f2d1700e08729c86bdf3460c3ad9a182e78

Make code compatible with Qt 5.6 again

view details

push time in 2 months

push eventpencil2d/pencil

scribblemaniac

commit sha 0247ea2994c9b8f4e78bdcf70487e6c39e2131d9

Fix assertion triggered when opening projects sometimes If you open a project or create a new project, and the current layer index is out of bounds on the new project, it will try and get the current layer in a timeline update a fail. This timeline update is caused by scrubbing to the last frame in the opening project, so the simplest solution is to simply set the layer index before the frame position.

view details

push time in 2 months

push eventscribblemaniac/pencil

scribblemaniac

commit sha 0247ea2994c9b8f4e78bdcf70487e6c39e2131d9

Fix assertion triggered when opening projects sometimes If you open a project or create a new project, and the current layer index is out of bounds on the new project, it will try and get the current layer in a timeline update a fail. This timeline update is caused by scrubbing to the last frame in the opening project, so the simplest solution is to simply set the layer index before the frame position.

view details

push time in 2 months

more