That's interesting. I've carried the a2crd conversion one step further: ChordPro now automatically detects whether the input is crd and, if so, converts (internally) to cho before further processing. The command line option --a2crd merely causes the result from the internal conversion to be sent to output.

The new test is t/70_a2crd.t. It processes all .crd files in the t/a2crd directory and compares the result to a corresponding .cho file in the t/a2crd directory. If the compare fails, it leaves a .tmp file for visual inspection. So adding new test cases is just a matter of putting the .crd into the t/a2crd directory and adding a .cho with the desired result.

I have reworked some of the A2Crd stuff and added your changes. Please checkout the latest 'dev' branch.

You can close (and remove) your a2crd_new_chord_ext branch.

A contacts app that doesn't show addresses is severly crippled (a.k.a. useless). Please raise the priority on this issue.

If I use the contacts app to add a new contact I do get the address shown.

Looking at the VCF (Jane Doe shows an address, while Joe Doe doesn't) is it appears to me that the main difference is the use of attribute grouping (ITEM0.ADR versus ADR).

jane.vcf.txt joe.vcf.txt

Sorry, no change. Still no addresses :( .

Great, thank you!

Did I mention that the problem is with all address entries?

I Control-R-ed the page. Is there anything else I can do?

Something like this?

GEThttps://cloud.squirrel.nl/apps/contacts/Not%20grouped/el2todnx-8bjs-d2xx-sltk-j81r60yumccu~addresses
[HTTP/2 200 OK 2174ms]

GEThttps://cloud.squirrel.nl/apps/user_status/img/app.svg?v=fa956741
[HTTP/2 304 Not Modified 1ms]

GEThttps://cloud.squirrel.nl/core/js/dist/main.js?v=fa956741-0
[HTTP/2 304 Not Modified 0ms]

GEThttps://cloud.squirrel.nl/core/js/dist/files_fileinfo.js?v=fa956741-0
[HTTP/2 304 Not Modified 0ms]

GEThttps://cloud.squirrel.nl/core/js/dist/files_client.js?v=fa956741-0
[HTTP/2 304 Not Modified 0ms]

GEThttps://cloud.squirrel.nl/js/core/merged-template-prepend.js?v=fa956741-0
[HTTP/2 200 OK 0ms]

GEThttps://cloud.squirrel.nl/core/l10n/en_GB.js?v=fa956741-0
[HTTP/2 304 Not Modified 0ms]

GEThttps://cloud.squirrel.nl/apps/accessibility/l10n/en_GB.js?v=fa956741-0
[HTTP/2 304 Not Modified 0ms]

GEThttps://cloud.squirrel.nl/apps/accessibility/js/accessibilityoca.js?v=fa956741-0
[HTTP/2 304 Not Modified 0ms]

GEThttps://cloud.squirrel.nl/apps/files_pdfviewer/js/files_pdfviewer-public.js?v=fa956741-0
[HTTP/2 304 Not Modified 0ms]

GEThttps://cloud.squirrel.nl/apps/files_sharing/l10n/en_GB.js?v=fa956741-0
[HTTP/2 304 Not Modified 0ms]

GEThttps://cloud.squirrel.nl/apps/files_sharing/js/dist/main.js?v=fa956741-0
[HTTP/2 304 Not Modified 0ms]

GEThttps://cloud.squirrel.nl/apps/files_videoplayer/js/main.js?v=fa956741-0
[HTTP/2 304 Not Modified 0ms]

GEThttps://cloud.squirrel.nl/apps/notifications/l10n/en_GB.js?v=fa956741-0
[HTTP/2 304 Not Modified 0ms]

GEThttps://cloud.squirrel.nl/apps/notifications/js/notifications-main.js?v=fa956741-0
[HTTP/2 304 Not Modified 0ms]

GEThttps://cloud.squirrel.nl/apps/contacts/l10n/en_GB.js?v=fa956741-0
[HTTP/2 304 Not Modified 0ms]

GEThttps://cloud.squirrel.nl/apps/contacts/js/contacts-main.js?v=fa956741-0
[HTTP/2 304 Not Modified 0ms]

GEThttps://cloud.squirrel.nl/apps/files_rightclick/l10n/en_GB.js?v=fa956741-0
[HTTP/2 304 Not Modified 0ms]

GEThttps://cloud.squirrel.nl/apps/files_rightclick/js/script.js?v=fa956741-0
[HTTP/2 304 Not Modified 0ms]

GEThttps://cloud.squirrel.nl/apps/files_rightclick/js/files.js?v=fa956741-0
[HTTP/2 304 Not Modified 0ms]

GEThttps://cloud.squirrel.nl/apps/firstrunwizard/l10n/en_GB.js?v=fa956741-0
[HTTP/2 304 Not Modified 0ms]

GEThttps://cloud.squirrel.nl/apps/firstrunwizard/js/about.js?v=fa956741-0
[HTTP/2 304 Not Modified 0ms]

GEThttps://cloud.squirrel.nl/apps/theming/l10n/en_GB.js?v=fa956741-0
[HTTP/2 304 Not Modified 0ms]

GEThttps://cloud.squirrel.nl/apps/theming/js/theming.js?v=fa956741-0
[HTTP/2 304 Not Modified 0ms]

GEThttps://cloud.squirrel.nl/apps/user_status/js/user-status-menu.js?v=fa956741-0
[HTTP/2 304 Not Modified 0ms]

GEThttps://cloud.squirrel.nl/core/js/dist/unified-search.js?v=fa956741-0
[HTTP/2 304 Not Modified 0ms]

GEThttps://cloud.squirrel.nl/apps/files/img/app.svg?v=fa956741
[HTTP/2 304 Not Modified 1ms]

GEThttps://cloud.squirrel.nl/apps/photos/img/app.svg?v=fa956741
[HTTP/2 304 Not Modified 0ms]

GEThttps://cloud.squirrel.nl/apps/activity/img/activity.svg?v=fa956741
[HTTP/2 304 Not Modified 0ms]

GEThttps://cloud.squirrel.nl/apps/contacts/img/app.svg?v=fa956741
[HTTP/2 304 Not Modified 0ms]

GEThttps://cloud.squirrel.nl/apps/calendar/img/calendar.svg?v=fa956741
[HTTP/2 304 Not Modified 0ms]

GEThttps://cloud.squirrel.nl/apps/tasks/img/tasks.svg?v=fa956741
[HTTP/2 304 Not Modified 0ms]

GEThttps://cloud.squirrel.nl/apps/notes/img/notes.svg?v=fa956741
[HTTP/2 304 Not Modified 0ms]

GEThttps://cloud.squirrel.nl/apps/settings/img/admin.svg?v=fa956741
[HTTP/2 304 Not Modified 0ms]

GEThttps://cloud.squirrel.nl/apps/settings/img/apps.svg?v=fa956741
[HTTP/2 304 Not Modified 0ms]

GEThttps://cloud.squirrel.nl/apps/firstrunwizard/img/info.svg?v=fa956741
[HTTP/2 304 Not Modified 0ms]

GEThttps://cloud.squirrel.nl/apps/settings/img/users.svg?v=fa956741
[HTTP/2 304 Not Modified 0ms]

GEThttps://cloud.squirrel.nl/apps/settings/img/help.svg?v=fa956741
[HTTP/2 304 Not Modified 0ms]

GEThttps://cloud.squirrel.nl/core/img/actions/logout.svg?v=fa956741
[HTTP/2 304 Not Modified 0ms]

GEThttps://cloud.squirrel.nl/avatar/jv/32?v=2
[HTTP/2 304 Not Modified 1910ms]

No OC found index.js:46:12
JQMIGRATE: Migrate is installed, version 1.4.1 jquery-migrate.min.js:2:551
jQuery is deprecated: The global jQuery is deprecated. It will be updated to v3.x in Nextcloud 21. In later versions of Nextcloud it might be removed completely. Please ship your own. globals.js:60:15
$ is deprecated: The global jQuery is deprecated. It will be updated to v3.x in Nextcloud 21. In later versions of Nextcloud it might be removed completely. Please ship your own. 4 globals.js:60:15
Notifications permissions granted App.vue:296
GEThttps://cloud.squirrel.nl/apps/notifications/img/notifications-new.svg

GEThttps://cloud.squirrel.nl/apps/notifications/img/notifications.svg
[HTTP/2 304 Not Modified 1ms]

jQuery is deprecated: The global jQuery is deprecated. It will be updated to v3.x in Nextcloud 21. In later versions of Nextcloud it might be removed completely. Please ship your own. 3 globals.js:60:15
Initial state loaded defaultProfileState HOME rfcProps.js:39:8
Initial state loaded localesState 
Array(750) [ {…}, {…}, {…}, {…}, {…}, {…}, {…}, {…}, {…}, {…}, … ]
rfcProps.js:40:8
OCA.Search is deprecated. Please use the unified search API instead search.js:31:10
jQuery is deprecated: The global jQuery is deprecated. It will be updated to v3.x in Nextcloud 21. In later versions of Nextcloud it might be removed completely. Please ship your own. 2 globals.js:60:15
jQuery is deprecated: The global jQuery is deprecated. It will be updated to v3.x in Nextcloud 21. In later versions of Nextcloud it might be removed completely. Please ship your own. 4 globals.js:60:15
session heartbeat polling started session-heartbeat.js:97:9
jQuery is deprecated: The global jQuery is deprecated. It will be updated to v3.x in Nextcloud 21. In later versions of Nextcloud it might be removed completely. Please ship your own. 145 globals.js:60:15
GEThttps://cloud.squirrel.nl/core/img/favicon-touch.png
[HTTP/2 200 OK 0ms]

GEThttps://cloud.squirrel.nl/core/img/favicon.ico
[HTTP/2 200 OK 0ms]

[DEBUG] unified-search: Unified Search initialized with the following providers 
Object { 0: {…}, 1: {…}, 2: {…}, 3: {…}, 4: {…}, 5: {…}, 6: {…}, 7: {…}, app: "unified-search", uid: "jv" }
ConsoleLogger.js:42:18
Connected to dav! 
Object { rootUrl: "https://cloud.squirrel.nl/remote.php/dav/", advertisedFeatures: (17) […], currentUserPrincipal: {…}, principalCollections: (4) […], calendarHomes: [], publicCalendarHome: {…}, addressBookHomes: (1) […], parser: {…}, _isConnected: true, _request: {…} }
Contacts.vue:472
String.prototype.toRgb is deprecated! It will be removed in Nextcloud 22. 8 placeholder.js:140:9
GEThttps://cloud.squirrel.nl/remote.php/dav/addressbooks/users/jv/addresses/dee32c9a-b7c1-4ef0-b30d-5653b0dbd95a.vcf?photo
[HTTP/2 304 Not Modified 238ms]

jQuery is deprecated: The global jQuery is deprecated. It will be updated to v3.x in Nextcloud 21. In later versions of Nextcloud it might be removed completely. Please ship your own. 8 globals.js:60:15
String.prototype.toRgb is deprecated! It will be removed in Nextcloud 22. 2 placeholder.js:140:9
OC.Util.relativeModifiedDate is deprecated and will be removed in Nextcloud 21. See @nextcloud/moment util.js:130:10
jQuery is deprecated: The global jQuery is deprecated. It will be updated to v3.x in Nextcloud 21. In later versions of Nextcloud it might be removed completely. Please ship your own. 204 globals.js:60:15
jQuery is deprecated: The global jQuery is deprecated. It will be updated to v3.x in Nextcloud 21. In later versions of Nextcloud it might be removed completely. Please ship your own. 4 globals.js:60:15
OC.requestToken changed lmGTqFFZSvy4uvgxotCtTp19OcVNszyNayumWvhL0Bk=:/yX9kBwXHtPx7ZJQm5jJIM0RVbMI6wnjElnDYsF5sUk= index.js:311:9
OC.requestToken changed oh8kzCTen/iFuglATdiFx3IYvBONbdtlpbZQyYn9QHo=:y1tK9GmQy9fM7WMhdJDhqSJ00GXINe4L3MQ18bDPISo= index.js:311:9
OC.requestToken changed HUEAO+2kcYuwwpfTYsjt9kYn49xh6+9QW3ioenMLkwU=:dAVuA6DqJaT5lf2yW4CJmBZLj6oks9o+IgrNQko58lU= index.js:311:9
OC.requestToken changed gJ/TP5h0J4+yXWawUAlRg6zBpLdkZxVX4Yc3WxCa/go=:6du9B9U6c6D7CgzRaUE17fytyMEhPyA5mPVSYymon1o= index.js:311:9
OC.requestToken changed qG0n0dQdpE/TaoKd9h/gSdSwajrrHso22d/Nxi+qlMo=:wSlJ6ZlT8GCaPej8z1eEJ4TcBkyuRv9YoK2o/haY9Zo= index.js:311:9
OC.requestToken changed nzdrZ1c8kHKZAaX7vO+nkNOXhaC/HjdGhuH9UvOOg1M=:9nMFXxpyxF3QVs+ahafD/oP76db6RgIo/5OYasq84gM= index.js:311:9
OC.requestToken changed LEm5gFbsF1kMmmiNSrjonNCt95xuSbFVRwIR4qI+MA4=:RQ3XuBuiQ3ZFzQLsc/CM8oDBm+orEYQ7PnB02psMUV4= index.js:311:9
jQuery is deprecated: The global jQuery is deprecated. It will be updated to v3.x in Nextcloud 21. In later versions of Nextcloud it might be removed completely. Please ship your own. 24 globals.js:60:15

<!-- Thanks for reporting issues back to Nextcloud! This is the issue tracker of Nextcloud, if you have any support question please check out https://nextcloud.com/support

To make it possible for us to help you please fill out below information carefully. You can also use the Issue Template application to prefill most of the required information: https://apps.nextcloud.com/apps/issuetemplate

⚠ Please report only issues corresponding to the contacts app for Nextcloud ⚠

Migration and CardDAV issues belong in the server repo! https://github.com/nextcloud/server/issues

If you have any questions, head over to https://help.nextcloud.com/c/apps/contacts

Note that Nextcloud is an open source project backed by Nextcloud GmbH. Most of our volunteers are home users and thus primarily care about issues that affect home users. Our paid engineers prioritize issues of our customers. If you are neither a home user nor a customer, consider paying somebody to fix your issue, do it yourself or become a customer. -->

Describe the bug

On the contacts page, addresses for entries are not shown. ...... ......

To Reproduce Steps to reproduce the behavior:

1. Select any contact
2. No address is shown

Expected behavior The address should be shown

Actual behavior See screenshot.

Screenshots

Attachments Attached is the ics as downloaded from the contacts app. As you can see, the ADR information is there. 889a7409-18fd-4737-bbb9-fe6e38ffd8d6.txt

Server configuration

<!-- You can use the Issue Template application to prefill most of the required information: https://apps.nextcloud.com/apps/issuetemplate -->

Operating system: Linux (Raspbian 10)

Web server: Nginx

Database: PostgreSQL

PHP version: 7.3.14

Nextcloud version: 20.0.0

Contacts version: 3.4.0

Updated from an older Nextcloud or fresh install: Updated

Browser: Firefox 81.0.1

Ok, done.

Moved $skipsentinel into folderFilter() sub.

I'm not sure if My Music is the right place for the skipsentinel setting. My Music deals with music (meta)data content. Skipsentinel operates on the scanning level, not the content level.

Done.

I also added a preference setting.

I'm not afraid for performance penalties. It is just a stat of a name in a directory that is being processed and therefore already in memory.

I have a vast collection of music, mostly ripped CDs, but not all of them are eligible to be included in the LMS library. So many years ago (2007 to be precise) I added a small tweak to function folderFilter (module Slim::Utils::Misc) to stop scanning a folder when a sentinel file .slimskip is present.

Since this may be interesting for other users as well (and because I always forget to re-apply this tweak after an upgrade) I hereby present it as a formal pull request.

With NC 20 the Calendar has improved, but I noticed may style settings are now hard-wired (inline) and cannot be modified with the Custom CSS app.

Things I would like to modifiy include:

--fc-daygrid-event-dot-width: 12px;
.fc-daygrid-dot-event: padding: 0pt 0pt;

Any alternatives?

Thanks for your persistence and confidence!

Thanks for reporting. You seem to have a very uncommon system setup. CPAN kits are intended to be build using the cpan or cpanm tool so this may induce surprises.

The error you get is due to a load failure of the harfbuzz library. It is missing entry point hb_font_set_ptem. This entry point was added to the harfbuzz library in version 1.6.0 (2017!) but it may be possible that your system still has an even older version. On the other hand, the build procedure did already verify that there is a usuable harfbuzz library (line 352: "using platform library") -- and succeeds, while a couple of lines later it reports "No library found for -lharfbuzz". The build procedure checks for libraries in common places like /lib, '/use/local/libetc and it seems to detect a usuable library there. But the actual compile and link phase use a quite different environment in/gnu/store/8zvc5mvk0xm3ygrxsgpyy5ilxb5rzjry-perl-5.30.2/`.

The only suggestion I can give is to contact your platform support.

You may try to change line 64 of Makefile.PL into my $hb_include = 1 and see if this helps.

Hey there,

I'm trying to fix a package definition I wrote for chordpro v. 0.974_017, but I'm getting the following error:

No backend for PDF
No PDF backend App::Music::ChordPro::Output::PDFClassic::PDF at (eval 47) line 1.
Compilation failed in require at (eval 47) line 1.

Here is what PDF.pm looks like.

I am not entirely sure why it is complaining. Any pointers will be much appreciated.

P. S: Yes, I do plan on updating the package definition to a newer version. But I'd like to make this work first and foremost.

So far all apparent problems were related to the build environment. Closing this issue since it is not related to ChordPro. For questions about ChordPro please use the forum. Build problems related to HarfBuzz::Shaper should go to its own issue tracker, https://github.com/sciurius/perl-HarfBuzz-Shaper/issues

HarfBuzz::Shaper does not have any CPAN dependencies, but expects the harfbuzz library to be available on the build system. Can you share the HarfBuzz::Shaper build log (not the test log)?

For completeness, this version of ChordPro does no longer require Pango and Cairo (I think 0.974 used Pango for the Devanagari rendering).

I may assume then that you have the devanagari fonts visible again.

For correct rendering of Devanagari, you need to install (or verify) Text::Layout version 0.019 and HarfBuzz::Shaper version 0.023. To build/install HarfBuzz::Shaper you probably need to install the harfbuzz package (I'm pretty sure it is already on your system).

In your config, you must use the newer fontconfig method to specify fonts. See https://www.chordpro.org/chordpro/chordpro-fonts/. This will become something similar to:

      "fontconfig" : {
         "devanagari" : {
            "" : { "file" : "/absolute/path/to/devanagari/aware/font.ttf",
                    "shaping" : true },
         },
        ....
      "fonts" : {
         "text" : {
            "description" : "devanagari",
            "size" : 12
         },
         ....

The attached config produces the desired results on my system. You may need to update the location of the font files.

I hope this will make it work for you as well.
[deva.json.txt](https://github.com/ChordPro/chordpro/files/5213771/deva.json.txt)

As a general advice: Do not use --text-font and similar on the command line. The results are not always what you would expect...

There were some changes in the font config settings. Can you add the --debug option to chordpro, run again, and send the pdf?

IO::String is a dependency registered with ChordPro. If it is not installed during the ChordPro install there is definitely something wrong with your build environment.

To get correctly rendered Devanagari fonts you need special tweaks. Forget it with that version.

If your build environment is anything decent, 0.977 should build and run w/o problems.

Without additional information it is not possible to say anything. Your PDF.pm looks okay except for a weird first #! line. However, 0.974_017 is an undefined snapshot from the git development, so it is not even possible to reconstruct your exact situation. When I reconstruct what I think is your situation it passes all tests.

Every bit of PDF processing had changed between snapshot 0.974_017 and current 0.977. So please upgrade and if you encounter issues send them to the community forum. We are there to help.

There are similar delays when using webdav so the problem may be more general.

Describe the bug The web info reads "Furthermore, a separate allows for an easy integration into third-party apps...".

The words "REST API" are missing.

We then also have to consider that such folder might grow so big that device can get out of storage

That is by far the weakest excuse I heard so far for not implementing this.

Any progress?

Describe the bug When I fetch a note (or note information) using the API, there seems to be a 2-3 second delay. This is consistent, independent of server load, so it may indicate some internal time-out

To Reproduce Steps to reproduce the behavior:

1. Use curl to fetch note info, e.g. `curl -u "user:password" https://cloud.squirrel.nl/index.php/apps/notes/api/v1/notes/141980
2. Response after 3 seconds.

Expected behavior Output within a reasonable amount of time. Since this is a lightly loaded server on a local LAN I'd expect a response in milliseconds.

Server (please complete the following information):

• Notes app version: 3.6.2
• Nextcloud version: 19.0.1
• OS: Raspbian
• Web server: nginx
• PHP version: 7.3
• Database: PostgreSQL

Client (please complete the following information):

• Browser (incl. version): curl 7.66.0
• OS: Fedora 31

Log files A message similar to this is written to the NC log for each request:

{"reqId":"c4dvydfNm08qhTtBCKb2","level":3,"time":"2020-08-22T18:35:38+00:00","remoteAddr":"192.168.1.251","user":"--","app":"PHP","method":"GET","url":"/index.php/apps/notes/api/v1/notes?exclude=content","message":"session_start(): A session had already been started - ignoring at /var/www/nextcloud/lib/private/Session/Internal.php#209","userAgent":"curl/7.66.0","version":"19.0.1.1"}

I have added sorttitle artist composer collection key year to the columns of the csv.

When the --csv option is used while creating a PDF output file, ChordPro creates a CSV file that can be used to import the songs in the PDF into MobileSheetsPro or into other database applications. Currently the CSV file contains only "title" and "pages" It would be great if other metadata like keys, artists, composers, years would also be written as additional columns into the CSV file

Getopt::Long->import() was resetting $requested_version to 0 after Getopt::Long->VERSION() called, so that auto_help/auto_version was always off if not enabled explicitly even if the version required greater than 2.3203, which is not consist with the document. So removed the buggy line.

Describe the bug chordpro --a2crd raises "Can't use an undefined value as a HASH reference"

To Reproduce

cat >test.txt <<EOL
Title: Swing Low Sweet Chariot
 
      D          G    D
Swing low, sweet chariot,
                       A7
Comin’ for to carry me home.
      D7         G    D
Swing low, sweet chariot,
              A7       D
Comin’ for to carry me home.
EOL

chordpro --a2crd -o test.pro test.txt

Output Can't use an undefined value as a HASH reference at App/Music/ChordPro/Chords/Parser.pm line 76.

Please complete the following information:

• OS: Ubuntu 18.04
• Perl version 5.26.1
• ChordPro version 0.975_002 (Github) and 0.975 (CPAN)

Thanks, fixed.

I agree this should be an installer function. However, much to my surprise, InnoSetup has no support for adding the application path to the system path decently, and, also important, remove it when uninstalled. There are some workarounds, each with pros and cons, that I would rather avoid.

I'll leave the issue as enhancement.

The culprit is 3rd party module Text::Layout that fails to cache the fonts needed. As a result, all fonts are included in the PDF several times. I have a fix in place for Text::Layout that will solve the issue.

Nice suggestion. What subset of metadata do you think is relevant? Or should it be configurable?

It seems like Pango markup is not working when the text contains [Chords]. The open tag seems to be getting closed at the first square bracket.

test.pro

# A simple ChordPro song.
{title: Swing Low Sweet Chariot}

{start_of_chorus}
Swing [D]low, sweet [G]chari[D]ot,
<i>Comin' for to carry me [A7]home.</i>
Swing [D7]low, sweet [G]chari[D]ot,
<i>Comin' for to [A7]carry me [D]home.</i>
{end_of_chorus}

chordpro -V
This is ChordPro version 0.975_001

chordpro -X -o test.pdf test.pro

Markup error: "<i>Comin’ for to carry me  home.</i>"
  Closing <i> but no markup is open
  ...

Screwed by a last-minute fix to support perl 5.10.1... Fixed, thanks.

Sigh.

Giving everything a second thought, I think that your idea to name it copy_dir is actually better. As it is implemented this is exactly what it is: it copies the dir like it would have copied the individual files based on copy patterns.

That this can be used for things like assets is a different matter.